[tlbuild] Broken tests for mendexk on arm

[Johannes Hielscher]

Am Mon, 10 May 2021 11:51:41 -0600
schrieb Karl Berry <karl at freefriends.org>:

>     test if my upmendex binary
> 
> Ah. I fixed mendex (yes, the same test failed for me and yes, it
> succeeded after my change), but not upmendex. I forgot there are two
> programs. (Aside: The massive code duplication throughout TeX and TL
> is a maintenance nightmare.)
> 
> It will take a long time for Nelson's system to compile icu and
> upmendex.  I started it running. In the meantime, I suggest just
> making the same change (char -> int) in upmendex/mendex.h and ...
> fingers crossed.
> 
> Thanks,
> Karl

Success! The tiny modification below indeed made upmendex now pass all
its tests for me too. I'm glad that it was not “another hidden bug”, but
“merely” code duplication. One of the reasons why this isn't a very
desirable thing, to turn it in diplomatic words.

Without diving into the code structure of the .*mendex.* tools, I had
already wondered why the test suites borrow bits from each other.

Thanks,
Johannes



Index: Build/source/texk/upmendex/mendex.h
===================================================================
--- Build/source/texk/upmendex/mendex.h (revision 59153)
+++ Build/source/texk/upmendex/mendex.h (working copy)
@@ -14,7 +14,7 @@
 struct page {
        char *page;
        char *enc;
-       char attr[3];
+       int attr[3];
 };