[tlbuild] Patch for icu

[Ken Brown]

On 3/23/2012 8:45 AM, Peter Breitenlohner wrote:
> On Fri, 23 Mar 2012, Jonathan Kew wrote:
>
>> On 23 Mar 2012, at 09:56, Ken Brown wrote:
>>
>>> The patch is consistent with what's done at other places in the file
>>> where HMODULE occurs; it's also consistent with icu-4.8.
>>>
>>> Ken
>>
>> Is this needed for a standalone ICU build on cygwin, too? If so (and
>> maybe even if not, just for consistency?), it'd be good to file a
>> report and proposed patch in the ICU tracker so it can be fixed
>> upstream. Thanks!
>
> Hi Jonathan,
>
> you may have noticed that I had submitted five bug reports against 49.rc
> during the last weeks (or was involved in them). Four of them are now fixed
> in 49.1 and the last one has been accepted for the maint branch.
>
> So I'll have a close look at this problem and then act accordingly.
>
> Ken's finding that a standalone ICU build on cygwin works out of the box
> could be due to the difference between static and shared libraries!

Hi Peter,

I think that's exactly right.  As a result of "#if U_ENABLE_DYLOAD" on 
line 2101 of putil.cpp, the code containing "HMODULE" is not compiled in 
the build with shared libraries.  So my patch might indeed be the right 
thing, but it has no effect for the build with shared libraries.

Ken