[tlbuild] build problem (with a fix)

[Vladimir Volovich]

Hi!

when building on sparc solaris 8 using sun studio compiler, i got an error:

source='libttf/ttfread.c' object='ttfread.o' libtool=no \
        DEPDIR=.deps depmode=none /opt/csw/bin/bash ../../../texk/ttfdump/../../build-aux/depcomp \
        cc -DHAVE_CONFIG_H -I. -I../../../texk/ttfdump -I../../../texk/ttfdump/include -I/opt/home/vvv/src/texlive/source/Work/texk -I/opt/home/vvv/src/texlive/source/texk    -xarch=v8 -O -c -o ttfread.o `test -f 'libttf/ttfread.c' || echo '../../../texk/ttfdump/'`libttf/ttfread.c
"../../../texk/ttfdump/libttf/ttfread.c", line 25: identifier redefined: ttfGetBYTE
        current : function(pointer to struct __FILE {int _cnt, pointer to unsigned char _ptr, pointer to unsigned char _base, unsigned char _flag, unsigned char _file, unsigned int __orientation :2, unsigned int __ionolock :1, unsigned int __filler :5}) returning unsigned char
        previous: function(pointer to struct __FILE {int _cnt, pointer to unsigned char _ptr, pointer to unsigned char _base, unsigned char _flag, unsigned char _file, unsigned int __orientation :2, unsigned int __ionolock :1, unsigned int __filler :5}) returning unsigned char : "../../../texk/ttfdump/include/ttf.h", line 46
cc: acomp failed for ../../../texk/ttfdump/libttf/ttfread.c
gmake[4]: *** [ttfread.o] Error 2
gmake[4]: Leaving directory `/opt/home/vvv/src/texlive/source/Work/texk/ttfdump'

and the following patch fixes it:

=====================
--- texk/ttfdump/libttf/ttfread.c	(revision 13581)
+++ texk/ttfdump/libttf/ttfread.c	(working copy)
@@ -19,6 +19,8 @@
 static char vcid[] = "$Id: ttfread.c,v 1.2 1998/07/04 13:17:51 werner Exp $";
 #endif /* lint */
 
+#if 0
+/* this is already defined in ttf.h */
 inline BYTE ttfGetBYTE(FILE *fp)
 {
     int cc;
@@ -31,6 +33,7 @@
 	}
     return (BYTE) cc;
 }
+#endif
 short ttfGetLSB16(FILE *fp)
 {
     int cc;
=====================

i'm not sure, though, why an error was not occurring in the previous year(s),
as these files were not changed for years, as svn log shows (and i was
using the same compiler)...

Best,
v.