[latex3-commits] [latex3/hyperref] develop: correct and to or in a test (f364992)

[github at latex-project.org]

Repository : https://github.com/latex3/hyperref
On branch  : develop
Link       : https://github.com/latex3/hyperref/commit/f36499256aedc6f436734a443777bc634772207b

>---------------------------------------------------------------

commit f36499256aedc6f436734a443777bc634772207b
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Sat Aug 31 17:02:29 2024 -0700

    correct and to or in a test


>---------------------------------------------------------------

f36499256aedc6f436734a443777bc634772207b
 ChangeLog.txt              | 3 +++
 hyperref-linktarget.dtx    | 4 ++--
 testfiles/missing-theH.lvt | 9 +++++++++
 testfiles/missing-theH.tlg | 8 ++++++++
 4 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/ChangeLog.txt b/ChangeLog.txt
index 0ff7510..b42f74e 100644
--- a/ChangeLog.txt
+++ b/ChangeLog.txt
@@ -1,3 +1,6 @@
+2024-08-31 Ulrike Fischer
+	* hyperref-linktarget.dtx: correct a test, see test missing-theH 
+
 Version: 2024-07-10 v7.01j
 2024-07-10 Ulrike Fischer
 	* hyperref.dtx: define \HyOrg at addtoreset always for cleveref
diff --git a/hyperref-linktarget.dtx b/hyperref-linktarget.dtx
index 1e6c347..dd3fd38 100644
--- a/hyperref-linktarget.dtx
+++ b/hyperref-linktarget.dtx
@@ -216,7 +216,7 @@
 % \texttt{\cs{MakeLinkTarget}*\{destname\}} is roughly equivalent to
 % \texttt{\cs{hypertarget}\{destname\}\{\}} but unlike the
 % latter it also raises the destination in a PDF, there is no text argument,
-% and---most importantly--it updates \cs{@currentHref}, that means the target
+% and---most importantly---it updates \cs{@currentHref}, that means the target
 % name is stored by the next \cs{label}, something that \cs{hypertarget} doesn't do).
 % The target name is expanded, see the remarks about prefixes above regarding
 % the allowed chars.
@@ -534,7 +534,7 @@
 %    \begin{macrocode}
 \cs_new_protected:Npn \@@_target_counter_doc:nn #1 #2
   {
-    \bool_lazy_and:nnTF { \cs_if_free_p:c {c@#2} } { \cs_if_free_p:c {theH#2} }
+    \bool_lazy_or:nnTF { \cs_if_free_p:c {c@#2} } { \cs_if_free_p:c {theH#2} }
       {
         \PackageWarning {hyperref}{Counter~'#2'~or~the~representation~'\string\theH#2`\MessageBreak
         don't~exist.~No~target~created.}{}
diff --git a/testfiles/missing-theH.lvt b/testfiles/missing-theH.lvt
new file mode 100644
index 0000000..f7604cd
--- /dev/null
+++ b/testfiles/missing-theH.lvt
@@ -0,0 +1,9 @@
+\documentclass{book}
+\input{regression-test}
+\newtheorem{defn}{Definition}[chapter]
+\usepackage{hyperref}
+
+\begin{document}
+\START
+\begin{defn}\label{def:test} test\end{defn}
+\end{document}
diff --git a/testfiles/missing-theH.tlg b/testfiles/missing-theH.tlg
new file mode 100644
index 0000000..56fb694
--- /dev/null
+++ b/testfiles/missing-theH.tlg
@@ -0,0 +1,8 @@
+This is a generated file for the l3build validation system.
+Don't change this file in any respect.
+Package hyperref Warning: Counter 'defn' or the representation '\theHdefn`
+(hyperref)                don't exist. No target created. on input line ....
+[1
+] (missing-theH.aux)
+Package rerunfilecheck Info: File `missing-theH.out' has not changed.
+(rerunfilecheck)             Checksum: D41D8CD98F00B204E9800998ECF8427E;0.