[latex3-commits] [latex3/latex2e] ltmarks-multicol: Apply suggestions from code review (6810b119d)

github at latex-project.org github at latex-project.org
Fri Nov 15 10:02:06 CET 2024


Repository : https://github.com/latex3/latex2e
On branch  : ltmarks-multicol
Link       : https://github.com/latex3/latex2e/commit/6810b119de7c5f9f5279ef5b1751dbc56503fb53

>---------------------------------------------------------------

commit 6810b119de7c5f9f5279ef5b1751dbc56503fb53
Author: Frank Mittelbach <frank.mittelbach at latex-project.org>
Date:   Fri Nov 15 10:02:06 2024 +0100

    Apply suggestions from code review
    
    Co-authored-by: David Carlisle <d.p.carlisle at gmail.com>


>---------------------------------------------------------------

6810b119de7c5f9f5279ef5b1751dbc56503fb53
 base/ltmarks.dtx            |  2 +-
 required/tools/multicol.dtx | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/base/ltmarks.dtx b/base/ltmarks.dtx
index 08a4ad3a7..c4fbbb6ee 100644
--- a/base/ltmarks.dtx
+++ b/base/ltmarks.dtx
@@ -984,7 +984,7 @@
 %    \end{macrocode}
 %    
 %    All marks will have an identification in form of a number that is
-%    incremented each time an mark insertion happens and therefore the
+%    incremented each time a mark insertion happens and therefore the
 %    initial empty values should have that too, so that data extraction
 %    is going to be uniform.
 % \changes{v1.0g}{2024/05/31}{Initialize all marks with an id, use
diff --git a/required/tools/multicol.dtx b/required/tools/multicol.dtx
index a8dea06c5..0c7b48295 100644
--- a/required/tools/multicol.dtx
+++ b/required/tools/multicol.dtx
@@ -185,7 +185,7 @@
 % \begin{multicols}{3}[\section*{Preface to versions 1.9 + 2.0}]
 %
 %    Version 1.9 added tagging support and also a number of smaller
-%    enhancements, such as as and optional argument to
+%    enhancements, such as an optional argument to
 %    \cs{columnbreak} to allow for conditional breaks instead of
 %    forced ones. The min column depth was also made customizable
 %    (previously it was hardwired to the depth of \enquote{p}) to support
@@ -1783,7 +1783,7 @@
     \global\setbox\mc at boxedresult\vbox{%
 %    \end{macrocode}
 %    We first update the mark structures and collect all marks that
-%    need reinsertion once \mc{} has finished. The we output the boxed
+%    need reinsertion once \mc{} has finished. Then we output the boxed
 %    columns and finally we reinsert the marks.
 % \changes{v2.0a}{2024/11/10}{Use new mark mechanism}
 %    \begin{macrocode}
@@ -3755,7 +3755,7 @@
 %
 % \section{Further extensions}
 %
-% This section does contain code for extensions added to this package
+% This section  contains code for extensions added to this package
 % over time. Not all of them may be active, some might sit dormant and
 % wait for being activated in some later release.
 %
@@ -4376,8 +4376,8 @@
 %    \end{macrocode}
 %    It might be possible that there was a previous \mc{} (either
 %    before the current one, or a boxed one inside) and that one might
-%    had more columns than the current one. If so we should make these
-%    column structures am error as they are no longer valid (or at
+%    have had more columns than the current one. If so, we should make these
+%    column structures an error as they are no longer valid (or at
 %    least empty them, not sure what is better).
 %    \begin{macrocode}
   \int_step_inline:nnn {\col at number + 1} { \g_@@_curr_col_int }
@@ -4598,7 +4598,7 @@
 %
 %
 %  \begin{macro}{\leftmark,\rightmark}
-%    We change the legacy \cs{leftmark} and \cs{rightmark} to the use
+%    We change the legacy \cs{leftmark} and \cs{rightmark} to use
 %    the new mark mechanism. For now we do this only if pkg{multicol}
 %    is loaded, but eventually this will move to the kernel which then
 %    also simplifies the definitions for \cs{markboth} and friends.
@@ -4634,7 +4634,7 @@
 %  }
 %    \end{macrocode}
 %
-%     This one has also been moved to the development %kernel
+%     This one has also been moved to the development kernel
 %    \begin{macrocode}
 %\str_if_exist:cF { l__socket_tagsupport/page at sofar }
 %  {
@@ -4645,7 +4645,7 @@
 %    The plug definition for now just implements the old interface
 %    currently used by tagpdf. This needs to change and \cs{@mult at ptagging@hook}
 %    replaced by directly using the socket/plug.  
-%    \changes{v2.0a}{2024/11/12}{Addedd tagging socket}
+%    \changes{v2.0a}{2024/11/12}{Added tagging socket}
 %    \begin{macrocode}
 \NewSocketPlug {tagsupport/page at sofar}{default}
   {





More information about the latex3-commits mailing list.