[latex3-commits] [latex3/latex2e] latex-lab/uf-review-05: some docu/comments in title module (7dc5316f)

[github at latex-project.org]

Repository : https://github.com/latex3/latex2e
On branch  : latex-lab/uf-review-05
Link       : https://github.com/latex3/latex2e/commit/7dc5316f1fb0d5045e70cfa7baebaad82d416888

>---------------------------------------------------------------

commit 7dc5316f1fb0d5045e70cfa7baebaad82d416888
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Tue Jan 2 12:35:54 2024 +0100

    some docu/comments in title module


>---------------------------------------------------------------

7dc5316f1fb0d5045e70cfa7baebaad82d416888
 required/latex-lab/latex-lab-title.dtx | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/required/latex-lab/latex-lab-title.dtx b/required/latex-lab/latex-lab-title.dtx
index 04e40619..a8087a9c 100644
--- a/required/latex-lab/latex-lab-title.dtx
+++ b/required/latex-lab/latex-lab-title.dtx
@@ -101,6 +101,28 @@
 % \texttt{pdfauthor} key used in \cs{hypersetup}. Both can be used (and the last
 % key used will win). 
 % 
+% \subsection{Open questions and TODOs}
+% 
+% \begin{itemize}
+% \item Writing into the Info dictionary needs to convert the input into a PDF string.
+% This is here done with a simple version of hyperref's \cs{pdfstringdef}, similar code
+% exist also in in the generic hyperref driver. This should be moved into a better place
+% module. 
+% 
+% \item Is it sensible to enhance \cs{author} and \cs{title} with an optional argument as done here?
+% An advantage is that it is rather light-weight and
+% doesn't require to decide how this values should be set in \cs{DocumentMetadata} (and would also work
+% without \cs{DocumentMetadata}. But a problem could be that various classes and packages already
+% extend this commands with other optional arguments.
+% 
+% \item Some of the definitions related to metadata should perhaps be moved into l3pdfmeta.
+% 
+% \item Are the names \texttt{pdftitle} and \texttt{pdfauthor} ok? 
+% 
+% \item The patch for \cs{thanks} to get a rlap-footnotemarker looks wrong. This 
+% probably means that some configuration option is missing in the footnote code.
+% \end{itemize}
+% 
 %   
 % 
 % \section{Implementation}