[latex3-commits] [latex3/latex2e] lab-review-01: address issues from review (8be0787d)

[github at latex-project.org]

Repository : https://github.com/latex3/latex2e
On branch  : lab-review-01
Link       : https://github.com/latex3/latex2e/commit/8be0787d52aabef518cec2a2430a465fa3e448c6

>---------------------------------------------------------------

commit 8be0787d52aabef518cec2a2430a465fa3e448c6
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Wed Jun 7 18:32:49 2023 +0200

    address issues from review


>---------------------------------------------------------------

8be0787d52aabef518cec2a2430a465fa3e448c6
 required/latex-lab/documentmetadata-support.dtx     | 4 ++--
 required/latex-lab/latex-lab-bib.dtx                | 6 +++---
 required/latex-lab/latex-lab-block-tagging.dtx      | 2 +-
 required/latex-lab/latex-lab-toc-kernel-changes.dtx | 6 ++----
 4 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/required/latex-lab/documentmetadata-support.dtx b/required/latex-lab/documentmetadata-support.dtx
index c3bf479e..0dccdd87 100644
--- a/required/latex-lab/documentmetadata-support.dtx
+++ b/required/latex-lab/documentmetadata-support.dtx
@@ -170,9 +170,9 @@
 %       It differs from \texttt{phase-II} \emph{a lot}: It will
 %       load new code for the tagging of lists, sectioning commands,
 %       table of contents and similar lists, graphics, minipages and floats. 
-%       As it redefines many internals it is restricted to the use of 
+%       As it redefines many internals it is currently restricted to the use of 
 %       standard classes (article, report, and book) 
-%       and it supports only a limited number of add-on package.  
+%       and it supports only a limited number of add-on packages.  
 %    \item[\texttt{new-or-1}] This patches a few commands related
 %    to the output routine. The patches are needed for the tagging
 %    of paragraphs, for the tagging of header and footer and 
diff --git a/required/latex-lab/latex-lab-bib.dtx b/required/latex-lab/latex-lab-bib.dtx
index 4319c69b..9a5ee817 100644
--- a/required/latex-lab/latex-lab-bib.dtx
+++ b/required/latex-lab/latex-lab-bib.dtx
@@ -161,7 +161,7 @@
 % 
 %\subsection{Handling the bibliography}
 % \begin{macro}{\@lbibitem}
-% The item command if an optional argument is use. 
+% The item command if an optional argument is used. 
 % 
 % We only prepend some code. 
 %    \begin{macrocode}
@@ -222,7 +222,7 @@
 % \end{macro}
 % 
 % TODO The LI-structure should set a label, we redefine the internal command locally for 
-% now, but perhaps this need a receipe? 
+% now, but perhaps this need a recipe? 
 % 
 %    \begin{macrocode}
 \AddToHook{env/thebibliography/begin}
@@ -243,7 +243,7 @@
 % structure. Even if it looks a bit odd it is now used for many years and so 
 % hopefully compatible with various packages. But differently to hyperref we use
 % the new hooks with arguments.
-% TODO: consider hook name. Perhaps use the generic names?
+% TODO: consider hook name. 
 %    \begin{macrocode}
 \NewMirroredHookPairWithArguments{bibcite/before}{bibcite/after}{2}  
 \def\bibcite#1#2{%
diff --git a/required/latex-lab/latex-lab-block-tagging.dtx b/required/latex-lab/latex-lab-block-tagging.dtx
index 95486ad1..63145d92 100644
--- a/required/latex-lab/latex-lab-block-tagging.dtx
+++ b/required/latex-lab/latex-lab-block-tagging.dtx
@@ -1346,7 +1346,7 @@
 %    will help with the transion. But instead of using a
 %    \env{trivlist} we use a blockenv and some tagging for the title
 %    (as a Caption).
-%    We do not want the \texttt{Strong} tagging from \cs{textbf} here,
+%    We do not want potential tagging from \cs{textbf} here,
 %    so we use \cs{bfseries} to set the font.
 %    \begin{macrocode}
 \def\@begintheorem#1#2{
diff --git a/required/latex-lab/latex-lab-toc-kernel-changes.dtx b/required/latex-lab/latex-lab-toc-kernel-changes.dtx
index a38a6b4b..1c1ce7f4 100644
--- a/required/latex-lab/latex-lab-toc-kernel-changes.dtx
+++ b/required/latex-lab/latex-lab-toc-kernel-changes.dtx
@@ -178,13 +178,11 @@
 %
 % \cs{addcontentsline} should always write the unique counter representation
 % \cs{@currentHref} so that we can create the |/Ref| key. At the same time
-% we need a hook, so that hyperref can add its bookmarks code. The generic hook
-% is ok. We only declare it and add until the merge.
+% we need a hook, so that hyperref can add its bookmarks code, the generic hook
+% with arguments is ok. 
 %
 %    \begin{macrocode}
-\NewHookWithArguments{cmd/addcontentsline/before}{3}
 \def\addcontentsline#1#2#3{% #1=toc extension, #2= heading type, tag
-    \UseHookWithArguments{cmd/addcontentsline/before}{3}{#1}{#2}{#3}%
     \addtocontents{#1}{%
       \protect\contentsline{#2}{#3}{\thepage}{\@currentHref}\protected at file@percent
     }}