[latex3-commits] [latex3/latex2e] gh1123: unhbox in showkeys for #1123 (435f6d8e)

[github at latex-project.org]

Repository : https://github.com/latex3/latex2e
On branch  : gh1123
Link       : https://github.com/latex3/latex2e/commit/435f6d8e4ce3d2e7d66255193b20e9ffda8bbd11

>---------------------------------------------------------------

commit 435f6d8e4ce3d2e7d66255193b20e9ffda8bbd11
Author: David Carlisle <d.p.carlisle at gmail.com>
Date:   Sat Dec 16 10:13:55 2023 +0000

    unhbox in showkeys for #1123


>---------------------------------------------------------------

435f6d8e4ce3d2e7d66255193b20e9ffda8bbd11
 base/doc/ltnews39.tex                           | 7 +++++++
 required/tools/changes.txt                      | 5 +++++
 required/tools/showkeys.dtx                     | 8 +++++---
 required/tools/testfiles-search/github-1123.lvt | 2 +-
 4 files changed, 18 insertions(+), 4 deletions(-)

diff --git a/base/doc/ltnews39.tex b/base/doc/ltnews39.tex
index 52bc4c5a..909d85dc 100644
--- a/base/doc/ltnews39.tex
+++ b/base/doc/ltnews39.tex
@@ -262,6 +262,13 @@ mechanism at all.
 %
 \githubissue{1130}
 
+\subsection{\pkg{showkeys}: Allow \cs{newline} in \pkg{amsthm} to work}
+%
+Previously \pkg{showkeys} added an extra box layer which disabled the \cs{newline}
+of \pkg{amsthm} theorem styles. This extra box has now been avoided.
+%
+\githubissue{1123}
+
 
 \section{Changes to files in the \pkg{cyrillic} category}
 
diff --git a/required/tools/changes.txt b/required/tools/changes.txt
index 065f2453..2cc2a13a 100644
--- a/required/tools/changes.txt
+++ b/required/tools/changes.txt
@@ -5,6 +5,11 @@ completeness or accuracy and it contains some references to files that
 are not part of the distribution.
 =======================================================================
 
+2023-12-16  David Carlisle  <David.Carlisle at latex-project.org>
+
+	* showkeys.dtx: avoid adding extra box to \@lables gh/1123
+
+
 2023-11-10  Frank Mittelbach  <Frank.Mittelbach at latex-project.org>
 
 	* multicol.dtx (subsection{Maintaining the mark registers}]):
diff --git a/required/tools/showkeys.dtx b/required/tools/showkeys.dtx
index c90b3863..271dd372 100644
--- a/required/tools/showkeys.dtx
+++ b/required/tools/showkeys.dtx
@@ -22,7 +22,7 @@
 % \fi
 % \iffalse
 %% File: showkeys.dtx Copyright (C) 1992-1997 David Carlisle
-%% File: showkeys.dtx Copyright (C) 2006-2019 David Carlisle, LaTeX Project
+%% File: showkeys.dtx Copyright (C) 2006-2023 David Carlisle, LaTeX Project
 %
 %<*dtx>
           \ProvidesFile{showkeys.dtx}
@@ -39,7 +39,7 @@
 %<driver> \ProvidesFile{showkeys.drv}
 % \fi
 %         \ProvidesFile{showkeys.dtx}
-          [2023/07/08 v3.19 Show cite and label keys (DPC, MH)]
+          [2023/12/16 v3.20 Show cite and label keys (DPC, MH)]
 %
 % \iffalse
 %<*driver>
@@ -417,6 +417,8 @@
 %    \end{macrocode}
 % \changes{v3.02}{1995/03/17}
 %         {New code for `in label' case.}
+% \changes{v3.20}{2023/12/16}
+%         {Avoid adding an extra box layer github/1123}
 % If the |\label| is straight after |\item| (|\bibitem| is handled by
 % this case as well) then the item label has not been added to the page
 % yet. It is hanging around in the box |\@labels| waiting for the
@@ -425,7 +427,7 @@
       \global\setbox\@labels\hbox{%
         \llap{\SK at lab\SK at lab@relax
               \kern\@totalleftmargin\kern\marginparsep}%
-        \box\@labels}%
+        \unbox\@labels}%
 %    \end{macrocode}
 %
 %    \begin{macrocode}
diff --git a/required/tools/testfiles-search/github-1123.lvt b/required/tools/testfiles-search/github-1123.lvt
index 746ca3f6..16a0d3a1 100644
--- a/required/tools/testfiles-search/github-1123.lvt
+++ b/required/tools/testfiles-search/github-1123.lvt
@@ -1,7 +1,7 @@
 \documentclass{article}
 \input{test2e}
 \usepackage{amsthm}% required to demonstrate issue
-%\usepackage[notcite,notref]{showkeys}
+\usepackage[notcite,notref]{showkeys}
 \newtheoremstyle{mystyle}
 {}%
 {}%