[latex3-commits] [git/LaTeX3-latex3-latex3] main: Properly correct xfrac issue (3d7eaa03c)

[Joseph Wright]

Repository : https://github.com/latex3/latex3
On branch  : main
Link       : https://github.com/latex3/latex3/commit/3d7eaa03c345169b535fde0b2cff3fb2ee36b3ce

>---------------------------------------------------------------

commit 3d7eaa03c345169b535fde0b2cff3fb2ee36b3ce
Author: Joseph Wright <joseph.wright at morningstar2.co.uk>
Date:   Sat May 29 09:33:34 2021 +0100

    Properly correct xfrac issue
    
    The problem here is tricky. The older set-up had the value of "numerator-top-sep" as part of the restricted template, so it was always set. However, one of the top or bottom sep values have to be maxdimen to avoid an error. With restrictions actually working, we couldn't undo the global setting of the top-sep, so we were stuck. Thus here I've made that a setting which is applied to an instance, not a restriction.


>---------------------------------------------------------------

3d7eaa03c345169b535fde0b2cff3fb2ee36b3ce
 l3packages/xfrac/xfrac.dtx | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/l3packages/xfrac/xfrac.dtx b/l3packages/xfrac/xfrac.dtx
index 81e4a1664..4a1a9beba 100644
--- a/l3packages/xfrac/xfrac.dtx
+++ b/l3packages/xfrac/xfrac.dtx
@@ -979,7 +979,6 @@
     scale-factor        = 0.7          ,
     scale-relative      = false        ,
     scaling             = true         ,
-    numerator-top-sep   = 0pt          ,
     denominator-bot-sep = 0 pt         ,
     math-mode           = true         ,
     phantom             = ( % )
@@ -996,9 +995,12 @@
 \DeclareInstance { xfrac } { default } { text } { }
 %    \end{macrocode}
 %
-%  The default \enquote{math(s)} instance.
+%  The default \enquote{math(s)} instance. We annot set the
+%  |numerator-top-sep| in the restricted template above as it clashes
+%  with the requirements of the |plainmath| collection which comes next.
 %    \begin{macrocode}
-\DeclareInstance { xfrac } { mathdefault } { math } { }
+\DeclareInstance { xfrac } { mathdefault } { math }
+  { numerator-top-sep = 0pt }
 %    \end{macrocode}
 %
 %    \begin{macrocode}