[latex3-commits] [git/LaTeX3-latex3-pdfresources] correctannot: remove \pdfannot_box:nnnnn (65182e7)

[Ulrike Fischer]

Repository : https://github.com/latex3/pdfresources
On branch  : correctannot
Link       : https://github.com/latex3/pdfresources/commit/65182e7bb07c40cf323afc60a294b84538da0d5f

>---------------------------------------------------------------

commit 65182e7bb07c40cf323afc60a294b84538da0d5f
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Wed Mar 3 12:32:14 2021 +0100

    remove \pdfannot_box:nnnnn


>---------------------------------------------------------------

65182e7bb07c40cf323afc60a294b84538da0d5f
 CHANGELOG.md              |  4 ++++
 l3pdfannot.dtx            | 27 +--------------------------
 testfiles-dvips/annot.pvt |  5 ++---
 testfiles/annot.pvt       |  5 ++---
 4 files changed, 9 insertions(+), 32 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index c6d8908..7d210eb 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -13,6 +13,10 @@ this project uses date-based 'snapshot' version identifiers.
 ### Changed
 -
 
+### Removed
+- \pdfannot_box:nnnnn: Concept to mix manual specs and dictionaries is wrong.
+  This can lead to duplicate entries in the dictionaries.
+  
 ### Fixed
 - Wrong default setting of \g_@@_active_bool (issue #13)
 - l3pdffile: Wrong casing: FileSpec -> Filespec   
diff --git a/l3pdfannot.dtx b/l3pdfannot.dtx
index 94b7a89..76a6451 100644
--- a/l3pdfannot.dtx
+++ b/l3pdfannot.dtx
@@ -77,19 +77,7 @@
 %   This creates an \texttt{/Type/Annot} object with the given dimensions.
 %   It doesn't use hooks or dictionaries.
 % \end{function}
-% \begin{function}[added = 2020-03-30]
-%   { \pdfannot_box:nnnnn }
-%   \begin{syntax}
-%     \cs{pdfannot_box:nnnnn} \Arg{type} \Arg{width} \Arg{height} \Arg{depth} \Arg{annot spec}
-%   \end{syntax}
-%   This creates an \texttt{/Type/Annot} object with the given dimensions.
-%   \meta{type} should be currently one of |link/URI|, |link/GoToR|,
-%  |link/Launch|, |link/GoTo| or |link/Named| or
-%  |widget|, it will then insert the attribute dictionary of this type
-%   additionally to the manually given \meta{annot spec}.
-%   The attribute dictionaries can be filled with commands described below.
-%   Hooks are not used.
-% \end{function}
+%
 % \begin{function}[added = 2019-09-05]
 %   { \pdfannot_box_ref_last: }
 %   \begin{syntax}
@@ -362,19 +350,6 @@
     \__pdf_backend_annotation_last:
   }
 
-\cs_new_protected:Npn \pdfannot_box:nnnnn #1 #2 #3 #4 #5
-  {
-    \exp_args:Nx
-    \__pdf_backend_annotation:nnnn {#2}{#3}{#4}
-      {
-        \pdfdict_if_exist:nT { l_@@/#1 }
-          {
-            \pdfdict_use:n { l_@@/#1}
-          }
-        #5
-      }
-    \bool_gset_false:N\g_@@_use_lastlink_bool
-  }
 %    \end{macrocode}
 % \subsection{Annotations, subtype Widget}\label{pdf:annot:widget}
 % Currently no code is provided here.
diff --git a/testfiles-dvips/annot.pvt b/testfiles-dvips/annot.pvt
index d99da53..aea0999 100644
--- a/testfiles-dvips/annot.pvt
+++ b/testfiles-dvips/annot.pvt
@@ -10,9 +10,8 @@
 % just to avoid to have to escape every space ...
 \def\testcontent{/Subtype/Widget/F 4/T(abc)/FT/Tx/Q 0/BS<</W 1 /S /S>>/MK<</BC[1 0 0]/BG[1 1 1]>>/DA(/Helv 10 Tf 0 0 0 rg)/DV()/V()}
 \ExplSyntaxOn
-\cs_generate_variant:Nn \pdfannot_box:nnnnn {nnnno}
-xx\pdfannot_box:nnnno
-          {}
+\cs_generate_variant:Nn \pdfannot_box:nnnn {nnno}
+xx\pdfannot_box:nnno
           {1cm}
           {1cm}
           {0pt}
diff --git a/testfiles/annot.pvt b/testfiles/annot.pvt
index d99da53..16aa31f 100644
--- a/testfiles/annot.pvt
+++ b/testfiles/annot.pvt
@@ -10,9 +10,8 @@
 % just to avoid to have to escape every space ...
 \def\testcontent{/Subtype/Widget/F 4/T(abc)/FT/Tx/Q 0/BS<</W 1 /S /S>>/MK<</BC[1 0 0]/BG[1 1 1]>>/DA(/Helv 10 Tf 0 0 0 rg)/DV()/V()}
 \ExplSyntaxOn
-\cs_generate_variant:Nn \pdfannot_box:nnnnn {nnnno}
-xx\pdfannot_box:nnnno
-          {}
+\cs_generate_variant:Nn \pdfannot_box:nnnn {nnno}
+xx\pdfannot_box:nnno          
           {1cm}
           {1cm}
           {0pt}