[latex3-commits] [git/LaTeX3-latex3-latex2e] testmetadata: clean up comments (9249e3f2)

Ulrike Fischer fischer at troubleshooting-tex.de
Thu Dec 30 17:08:34 CET 2021


Repository : https://github.com/latex3/latex2e
On branch  : testmetadata
Link       : https://github.com/latex3/latex2e/commit/9249e3f2169415df583be56ad14fc94aa1a2cde5

>---------------------------------------------------------------

commit 9249e3f2169415df583be56ad14fc94aa1a2cde5
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Thu Dec 30 17:08:34 2021 +0100

    clean up comments


>---------------------------------------------------------------

9249e3f2169415df583be56ad14fc94aa1a2cde5
 required/latex-lab/documentmetadata-support.dtx | 42 ++-----------------------
 1 file changed, 3 insertions(+), 39 deletions(-)

diff --git a/required/latex-lab/documentmetadata-support.dtx b/required/latex-lab/documentmetadata-support.dtx
index 84fb5d59..852eddf4 100644
--- a/required/latex-lab/documentmetadata-support.dtx
+++ b/required/latex-lab/documentmetadata-support.dtx
@@ -166,24 +166,16 @@
         \cs_set_protected:Npn \DocumentMetadata ##1
           {
             \keys_set_filter:nnn  { document / metadata } { init } { ##1 }
-%FMi
             \str_remove_all:cn {opt at hyperref.sty}{customdriver=hgeneric-testphase}
-%FMi this doesn't seem to need the F case if we move the removal to
-%    the front
             \bool_if:NT \g__pdfmanagement_active_bool
              {
-%FMi               \str_remove_all:cn {opt at hyperref.sty}{customdriver=hgeneric-testphase}
                \PassOptionsToPackage{customdriver=hgeneric-testphase}{hyperref}
              }
-%FMi             {
-%FMi               \str_remove_all:cn {opt at hyperref.sty}{customdriver=hgeneric-testphase}
-%FMi             }
           }
 %    \end{macrocode}
-% Load more modules, the testphase code and the firstaid code.
+% Load more modules, the testphase code and the firstaid code. The code is only
+% loaded in the first \cs{DocumentMetadata} call!
 %    \begin{macrocode}
-%FMi this doesn't look correct -- testphase code is not loaded if only
-%    in second call --- see test 001
         \g_@@_testphase_tl
         \RequirePackage{pdfmanagement-firstaid}
       }
@@ -199,6 +191,7 @@
 %FMi
 %FMi \clist_new:N \g_@@_firstaidoff_clist
 %FMi \tl_new:N \g_@@_testphase_tl
+% UFi should the definition move to here?
 \keys_define:nn { document / metadata }
   {
     backend .choices:nn =
@@ -341,32 +334,3 @@
 %
 % \Finale
 %
-
-\endinput
-
-\prop_new:N \g__pdfmanagement_documentproperties_prop %
-\NewDocumentCommand\AddToDocumentProperties{O{\@currname}mm}
-  {
-    \exp_args:NNx
-      \prop_gput:Nnn \g__pdfmanagement_documentproperties_prop
-        {
-          \tl_if_blank:eTF {#1}{top-level/}{#1/} #2
-        }
-        { #3}
-  }
-\NewExpandableDocumentCommand\GetDocumentProperties{m}
-  {
-    \prop_item:Nn \g__pdfmanagement_documentproperties_prop {#1}
-  }
-\msg_new:nnn  { pdfmanagement } { show-properties }
-  {
-    The~following~document~properties~have~been~stored:
-    #1
-  }
-\NewDocumentCommand\ShowDocumentProperties {}
-  {
-    \msg_show:nnx {pdfmanagement}{show-properties}
-      {
-        \prop_map_function:NN \g__pdfmanagement_documentproperties_prop \msg_show_item:nn
-      }
-  }





More information about the latex3-commits mailing list.