[latex3-commits] [git/LaTeX3-latex3-pdfresources] master: improve docu (5f68359)

[Ulrike Fischer]

Repository : https://github.com/latex3/pdfresources
On branch  : master
Link       : https://github.com/latex3/pdfresources/commit/5f683591f506dfd5f7d45b8793df09577abb0de4

>---------------------------------------------------------------

commit 5f683591f506dfd5f7d45b8793df09577abb0de4
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Fri Mar 20 19:10:30 2020 +0100

    improve docu


>---------------------------------------------------------------

5f683591f506dfd5f7d45b8793df09577abb0de4
 hgeneric-experimental.def | 44 ++++++++++++++++++++++++++++++++++----------
 1 file changed, 34 insertions(+), 10 deletions(-)

diff --git a/hgeneric-experimental.def b/hgeneric-experimental.def
index cd76151..498e62c 100644
--- a/hgeneric-experimental.def
+++ b/hgeneric-experimental.def
@@ -5,6 +5,29 @@
 %% from pdfresources.sty
 %%
 %% drivers are loaded in line 4745 in hyperref.sty in a \Hy at AtEndOfPackage command.
+%%%%%%%%%%%%%%%%%%%%%%%%%%%%
+%% list of new internal commands
+%% \__hyp_link_begin_goto:nw : start command for links to internal destination
+%%                             replaces \find at pdflink
+%% \__hyp_pagelabels_gput:n : puts pagelabels in the catalog.
+%% \__hyp_pstringdef:Nn     : replaces Hy at pstringdef, converts n to pdfstring and stores in N
+%%                            naming??
+%% \__hyp_info_generate_addons: what did this do??
+%% list of new variables
+%% \l__hyp_pdfa_bool : for pdfa option (unclear if it will stay)
+%% \l__hyp_pdfstring_tmp_tl
+%% \c__hyp_destname_undefined_tl
+%% \g__hyp_AcroForm_CoFields_prop
+%% \g__hyp_AcroForm_Fields_prop
+%% \l__hyp_tmpa_seq
+%% \l__hyp_CheckmarkYes_tl
+%% \l__hyp_CheckmarkOff_tl
+%% \l__hyp_RadioYes_tl
+%% list of commands which probably will have to change
+%%   \Hy at EXPsetpdfborder
+%%   \Hy at EXPsetpdfhighlight
+%%   \Hy at EXPsetbordercolor
+%%   \hypupdateattribute
 \ProvidesFile{hgeneric-experimental.def}
   [2020/03/16 v0.5 %
   Hyperref driver for luaTeX]
@@ -232,7 +255,7 @@
 % \Hy at PutCatalog is used only in one place but we
 % we need this for the dvips/xetex route for the page labels.
 % we simply hard code this for now until hyperref.sty itself can be adapted ...
-\cs_new:Npn\__hyp_put_catalog:n #1
+\cs_new:Npn\__hyp_pagelabels_gput:n #1
   {
     \pdf_catalog_gput:nx {PageLabels}{<</Nums[\HyPL at Labels]>>}
   }
@@ -242,7 +265,7 @@
     \let\Hy at PutCatalog \use_none:n
   }
   {
-    \let\Hy at PutCatalog \__hyp_put_catalog:n
+    \let\Hy at PutCatalog \__hyp_pagelabels_gput:n
   }
 
 \legacy_if:nT { Hy at pdfpagelabels }
@@ -484,15 +507,15 @@
 
 \ExplSyntaxOn
 \newcommand\Hy at pstringDest{}
-\tl_new:N \__hyp_pdfstring_tmp_tl
+\tl_new:N \l__hyp_pdfstring_tmp_tl
 
 \Hy at WrapperDef\new at pdflink#1 % #1 is a destination name.
   {
     \mode_if_horizontal:T { \@savsf\spacefactor }
     \Hy at SaveLastskip      %defined in hyperref
     \Hy at VerboseAnchor{#1} %defined in hyperref, for debugging
-    \__hyp_pstringdef:Nx  \__hyp_pdfstring_tmp_tl { \HyperDestNameFilter{#1} } %
-    \exp_args:NV \pdf_destination:nf { \__hyp_pdfstring_tmp_tl } { \@pdfview } %
+    \__hyp_pstringdef:Nx  \l__hyp_pdfstring_tmp_tl { \HyperDestNameFilter{#1} } %
+    \exp_args:NV \pdf_destination:nf { \l__hyp_pdfstring_tmp_tl } { \@pdfview } %
     \Hy at RestoreLastskip   %defined in hyperref
     \mode_if_horizontal:T { \spacefactor\@savsf }
   }
@@ -510,10 +533,11 @@
 \tl_const:Nn \c__hyp_destname_undefined_tl {UNDEFINED}
 \tl_new:N \l__hyp_destname_tmpa_tl
 
-\def\find at pdflink#1#2
-  {%
+%\def\find at pdflink#1#2
+\cs_new_protected:Npn \__hyp_link_begin_goto:nw #1
+  {
     \mode_leave_vertical:
-    \protected at edef\l__hyp_destname_tmpa_tl {#2}
+    \protected at edef\l__hyp_destname_tmpa_tl { #1 }
     \tl_if_empty:NTF \l__hyp_destname_tmpa_tl
       {
         \msg_warning:nnx { hyp } { empty-destination-name } { \c__hyp_destname_undefined_tl }
@@ -569,7 +593,7 @@
 \cs_new_protected:Npn \hyper at linkstart #1 #2
   {
     \Hy at VerboseLinkStart{#1}{#2}% only for debug
-    \find at pdflink{link}{#2}% #1=color type (fix), #2=destination name
+    \__hyp_link_begin_goto:nw {#2}% #1=color type (fix), #2=destination name
   }
 
 % the endlink muss have the same type as the start?
@@ -582,7 +606,7 @@
 \def\hyper at link#1#2#3
  {
   \Hy at VerboseLinkStart{#1}{#2}
-  \find at pdflink{link}{#2}#3\Hy at xspace@end
+  \__hyp_link_begin_goto:nw {#2}#3\Hy at xspace@end
   \close at EXPpdflink { link }
 }
 \ExplSyntaxOff