[latex3-commits] [git/LaTeX3-latex3-pdfresources] master: remove support for citecolor from experimental driver (7968eb6)

[Ulrike Fischer]

Repository : https://github.com/latex3/pdfresources
On branch  : master
Link       : https://github.com/latex3/pdfresources/commit/7968eb6fb2e0629255a5bda1ca96811815ae6256

>---------------------------------------------------------------

commit 7968eb6fb2e0629255a5bda1ca96811815ae6256
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Tue Mar 17 19:02:57 2020 +0100

    remove support for citecolor from experimental driver


>---------------------------------------------------------------

7968eb6fb2e0629255a5bda1ca96811815ae6256
 hgeneric-experimental.def | 35 +++--------------------------------
 pdfresources.dtx          |  5 ++++-
 2 files changed, 7 insertions(+), 33 deletions(-)

diff --git a/hgeneric-experimental.def b/hgeneric-experimental.def
index 923cac8..add1b1f 100644
--- a/hgeneric-experimental.def
+++ b/hgeneric-experimental.def
@@ -436,7 +436,7 @@
   \fi
   \Hy at StartlinkName{}%
   \Hy at testname
-  \expandafter\Hy at colorlink\csname @#1color\endcsname
+  \expandafter\Hy at colorlink\csname @linkcolor\endcsname
 }
 
 \ExplSyntaxOn
@@ -479,22 +479,7 @@
 \cs_new_protected:Npn \hyper at linkstart #1 #2
   {
     \Hy at VerboseLinkStart{#1}{#2}% only for debug
-    % is this still needed or are the hooks handled elsewhere??
-    \tl_if_exist:cTF            % or test for blank??
-      { @#1bordercolor }
-      {
-        \hook_put:nnnn
-          { pdf }
-          { link_begin_link_attr }
-          { C }{ [\tl_use:c { @#1bordercolor }] } %do I need to expand?? seems not
-      }
-      {
-        \hook_remove:nnn
-          { pdf }
-          { link_begin_link_attr }
-          { C }
-      }
-    \find at pdflink{#1}{#2}% #1=color type
+    \find at pdflink{link}{#2}% #1=color type (fix), #2=destination name
   }
 
 % the endlink muss have the same type as the start?
@@ -507,21 +492,7 @@
 \def\hyper at link#1#2#3
  {
   \Hy at VerboseLinkStart{#1}{#2}
-  \tl_if_exist:cTF
-   { @#1bordercolor }
-   {
-    \hook_put:nnnn
-     { pdf }
-     { link_begin_link_attr }
-     { C }{ [\tl_use:c { @#1bordercolor }] } %do I need to expand?? seems not
-   }
-   {
-    \hook_remove:nnn
-     { pdf }
-     { link_begin_link_attr }
-     { C }
-   }
-  \find at pdflink{#1}{#2}#3\Hy at xspace@end
+  \find at pdflink{link}{#2}#3\Hy at xspace@end
   \close at EXPpdflink { link }
 }
 \ExplSyntaxOff
diff --git a/pdfresources.dtx b/pdfresources.dtx
index 7bb7d70..e92a852 100644
--- a/pdfresources.dtx
+++ b/pdfresources.dtx
@@ -2653,7 +2653,10 @@
 % all packages know which types they have to handle. It is stored in a constant
 % seq.
 % \begin{NOTE}{UF}
-% Perhaps a |cite| type will be useful at some time.
+% Perhaps a |cite| type will be useful at some time. -- Thinking more about it,
+% a |cite| type is not sensible. hyperref supports it, but it doesn't fit in.
+% Commands like cite, gls, acro, footnote and so one should locally change
+% linkcolor and linkbordercolor. 
 % Probably we will need some commands to add an attribute to all link types
 % at once.
 % hyperref commands for the various type: