[latex3-commits] [git/LaTeX3-latex3-pdfresources] reworking-annot: add bookmark warning (045fb52)

[Ulrike Fischer]

Repository : https://github.com/latex3/pdfresources
On branch  : reworking-annot
Link       : https://github.com/latex3/pdfresources/commit/045fb526c664061e113e3678b4f447ced3f101aa

>---------------------------------------------------------------

commit 045fb526c664061e113e3678b4f447ced3f101aa
Author: Ulrike Fischer <fischer at troubleshooting-tex.de>
Date:   Wed Dec 30 15:47:00 2020 +0100

    add bookmark warning


>---------------------------------------------------------------

045fb526c664061e113e3678b4f447ced3f101aa
 hgeneric-experimental.def | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/hgeneric-experimental.def b/hgeneric-experimental.def
index fec2628..602b84c 100644
--- a/hgeneric-experimental.def
+++ b/hgeneric-experimental.def
@@ -41,7 +41,7 @@
   [2020/12/26 v0.71 %
   Hyperref driver for luaTeX]
 
-\RequirePackage{xparse,etoolbox,l3color}
+\RequirePackage{etoolbox,l3color}
 \chardef\Hy at VersionChecked=1 %don't check the version!
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 \ExplSyntaxOn
@@ -185,19 +185,9 @@
   }
 
 
-
-%% I require the bookmark package to get rid of some of the bookmarks code.
-% but the testing code doesn't work.
-% !!!!!!!!!!!!!!!!!!!!! to do !!!!!!!!!!!!!!!!!!!!!
-%\Hy at AtEndOfPackage{% so that we are later than KOMA ...
-%\AtBeginDocument
-% {
-%  \ltx at ifpackageloaded{bookmark}
-%   {}
-%   {\msg_error:nn {hyp}{missing-bookmark-package}}
-% }}
-% booleans for the (some) option keys. As hyperref disables them it is okay to set them here,
-% hypersetup  can't interfere
+%% I require the bookmark package to get rid of some of the bookmarks code
+%% but load it explicitly for now, so let's have warning at least.
+\AddToHook{begindocument/end}{\ltx at ifpackageloaded{bookmark}{}{\msg_warning:nn {hyp}{missing-bookmark-package}}}
 
 %%%%%%%%%%%%%%%%
 % defaults, will perhaps need some sorting and be checked if they are sensible for all backends