[tlbuild] very minor makefile fixes

[Vincenzo Mantova]

Here we go. It appears I have accumulated quite a few papercuts, I should
have started this earlier!

The attached patches fix the following bugs, which can be triggered with
certain configure flags

   - bibtex-x should always check for kpathsea, even if bibtexu is disabled
   - harfbuzz should be checked for lua[jit]hbtex, not luatex[53]
   - ptexenc should include unicode-jp.h to work as system library
   - upweb symlinks should only be created when UPWEB is true (this patch
   is moderately annoying, because it causes lots of changes in Makefile.in)
   - fontconfig does not need to be checked if xetex is disabled (not
   causing problems per se, but why not)

and the following 'typos', which cause no issues in standard builds

   - mpfi has a typo in its dependencies
   - pplib should depend on zlib
   - the vendored xpdf library does not pass its own '--with-system-xpdf'
   test (the test calls a function that is not defined)


Other issues for which I am happy to send tiny patches, but make me nervous
about side effects I did not consider:

   - etex should depend on $(proglib) -- once you do that, you can move
   lib.a, libp.a to EXTRA_LIBRARIES and stop recursing into lib (this
   marginally improves parallel building)
   - the main configure script checks for kpathsea before giving
   KPSE_ALL_SYSTEM_FLAGS a chance to fill the relevant variables with
   pkg-config (and the test should be made identical to the one in texk/web2c/
   configure.ac)


Then there are some weird things for which I have no suggestions, all about
web2c.

   - web2c/configure.ac: the logic around PWEB, UPWEB is off: the current
   AS_IF is always false so PWEB, UPWEB always coincide with $enable_webprogs
   (which seems fine to me, it makes '--enable-web-progs' work independently
   of ptex)
   - web2c/configure.ac: WEB2C_DISABLE is called on 'luatex' and
   'luatex53', but it should be called on all lua[jit][hb]tex variants, I
   think?
   - hitex does not cross compile nicely, because it compile and runs
   himktables -- I figure this could be mentioned in 'Cross problems'
   - web2c/configure.ac has some counterintuitive test about
   $enable_omfonts and omegaware (you can trigger a build of otangle by
   *disabling* omfonts)


Best,
Vincenzo

On Sat, 8 Jun 2024 at 22:19, Norbert Preining <norbert at preining.info> wrote:

> > Is this the right place to send bug reports and/or patches to?
>
> Yes, please! Thanks a lot for looking into this.
>
> Best regards
>
> Norbert
>
> --
> PREINING Norbert                              https://www.preining.info
> arXiv / Cornell University   +   IFMGA Guide   +   TU Wien  +  TeX Live
> GPG: 0x860CDC13   fp: F7D8 A928 26E3 16A1 9FA0 ACF0 6CAC A448 860C DC13
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bibtex-x-kpathsea.patch
Type: application/octet-stream
Size: 1137 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0008.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: luatex-harfbuzz.patch
Type: application/octet-stream
Size: 1094 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0009.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pplib-zlib.patch
Type: application/octet-stream
Size: 2046 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0010.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ptexenc-unicode-jp-h.patch
Type: application/octet-stream
Size: 542 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0011.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: upweb-links.patch
Type: application/octet-stream
Size: 24278 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0012.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xetex-fontconfig.patch
Type: application/octet-stream
Size: 2043 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0013.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: xpdf-try-libxx.patch
Type: application/octet-stream
Size: 438 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0014.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mpfi-withenable.patch
Type: application/octet-stream
Size: 335 bytes
Desc: not available
URL: <https://tug.org/pipermail/tlbuild/attachments/20240609/e56ad1c7/attachment-0015.obj>