[tlbuild] Patch needed in source/utils/xindy

[Nelson H. F. Beebe]

I did a fresh build of TeX Live 2019 this morning on a newly installed
FreeBSD 13 on x86 VM, and encountered a problem that stopped the build
until I did a manual patch.

Specifically, the file source/utils/xindy/Makefile.in, from which is
generated the file source/Work/utils/xindy/Makefile, has this target:

	install-strip:
		if test -z '$(STRIP)'; then \
		  $(MAKE) $(AM_MAKEFLAGS) INSTALL_PROGRAM="$(INSTALL_STRIP_PROGRAM)" \
		    install_sh_PROGRAM="$(INSTALL_STRIP_PROGRAM)" INSTALL_STRIP_FLAG=-s \
		      install; \
		else \
		  $(MAKE) $(AM_MAKEFLAGS) INSTALL_PROGRAM="$(INSTALL_STRIP_PROGRAM)" \
		    install_sh_PROGRAM="$(INSTALL_STRIP_PROGRAM)" INSTALL_STRIP_FLAG=-s \
		    "INSTALL_PROGRAM_ENV=STRIPPROG='$(STRIP)'" install; \
		fi

The problem is that those commands generate this failing one-liner:

STRIPPROG='strip' /bin/sh /local/build/bare/texlive-20190805/source/build-aux/install-sh   \
    -c -s "/usr/local/lib/clisp/base/lisp.run"                                             \
    "/local/build/bare/texlive-20190805/source/inst/bin/i586-unknown-freebsd13.0/xindy.run"

It fails because the install-sh copies the vendor file lisp.run into
the TeX Live file xindy.run, and then applies the strip command to the
latter. On this system, the lisp.run file has protection -r-xr-xr-x,
so xindy.run gets the same protection, and the strip command dies
because it lacks permission to rewrite that file.

The Makefile depends on Makefile.in, which may depend on Makefile.am,
so I leave it to someone else to make a suitable repair.

On brief inspection, the fault seems to lie in
source/build-aux/install-sh, which does some checking of protections,
but apparently not enough.

My temporary fix was

	sudo -s chmod ug+w /usr/local/lib/clisp/base/lisp.run

and then rerun the top-level "make world", but that was only possible
because I own the machine, and have root access on it.

-------------------------------------------------------------------------------
- Nelson H. F. Beebe                    Tel: +1 801 581 5254                  -
- University of Utah                    FAX: +1 801 581 4148                  -
- Department of Mathematics, 110 LCB    Internet e-mail: beebe at math.utah.edu  -
- 155 S 1400 E RM 233                       beebe at acm.org  beebe at computer.org -
- Salt Lake City, UT 84112-0090, USA    URL: http://www.math.utah.edu/~beebe/ -
-------------------------------------------------------------------------------