[tlbuild] sparc-solaris builder?

[Mojca Miklavec]

On Wed, May 14, 2014 at 8:56 AM, Peter Breitenlohner wrote:
> On Tue, 13 May 2014, Mojca Miklavec wrote:
>
>> On Thu, Mar 20, 2014 at 10:43 AM, Peter Breitenlohner wrote:
>>>
>>> On Mon, 17 Mar 2014, Mojca Miklavec wrote:
>>>
>>>>> if I understand you correctly, you can compile everything except ICU
>>>>> without
>>>>> any special options and ICU with -std=gnu99 or -std=c99.
>>>>
>>>>
>>>> Yes.
>
>
>> Weird enough I'm still getting the following error(s):
>>
>> ...
>> generating dependency information for
>> /path/to/libs/icu/icu-53.1/source/common/umapfile.c
>> In file included from /usr/include/inttypes.h:20:0,
>>                 from
>> /path/to/libs/icu/icu-53.1/source/common/unicode/ptypes.h:80,
>>                 from
>> /path/to/libs/icu/icu-53.1/source/common/unicode/umachine.h:44,
>>                 from
>> /path/to/libs/icu/icu-53.1/source/common/unicode/utypes.h:36,
>>                 from
>> /path/to/libs/icu/icu-53.1/source/common/unicode/putil.h:27,
>>                 from
>> /path/to/libs/icu/icu-53.1/source/common/umapfile.c:22:
>>
>> /opt/csw/lib/gcc/sparc-sun-solaris2.10/4.9.0/include-fixed/sys/feature_tests.h:350:2:
>> error: #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001
>> applications
>>        require the use of c99"
>> #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001 applications
>> \
>>  ^
>> generating dependency information for
>> /path/to/libs/icu/icu-53.1/source/common/udatamem.c
>> ...
>>
>> but the build as a whole succeeds despite these errors being shown.
>
>
> It seems that the dependencies (for C files) are built with
>     @$(SHELL) -ec '$(GEN_DEPS.c) $<
> with GEN_DEPS.c defined in config/mh-solaris-gcc (and most other fragments)
> as
>     $(CC) -E -MM $(DEFS) $(CPPFLAGS)
> i.e., without using $(CFLAGS).
>
> Thus this step fails and probably creates empty or no dependency files.  The
> error messages are a pain, but otherwise everything should be OK.
>
> If you wish you could try to add $(CFLAGS) or -std=c99 to the definition of
> GEN_DEPS.c
> in config/mh-solaris-gcc and see if that helps.

Thank you very much. With this change the problem was solved:

> svn diff
Index: libs/icu/icu-53.1/source/config/mh-solaris-gcc
===================================================================
--- libs/icu/icu-53.1/source/config/mh-solaris-gcc      (revision 34022)
+++ libs/icu/icu-53.1/source/config/mh-solaris-gcc      (working copy)
@@ -9,7 +9,7 @@
 SHAREDLIBCPPFLAGS = -DPIC

 ## Commands to generate dependency files
-GEN_DEPS.c=    $(CC) -E -MM $(DEFS) $(CPPFLAGS)
+GEN_DEPS.c=    $(CC) $(CFLAGS) -E -MM $(DEFS) $(CPPFLAGS)
 GEN_DEPS.cc=   $(CXX) -E -MM $(DEFS) $(CPPFLAGS)

 ## These are the library specific LDFLAGS


OK, I only tested the following for now (and maybe the exact order of
arguments in the above patch was wrong).

~/tl/Work/libs/icu/icu-build/common > gmake
generating dependency information for
/path/to/libs/icu/icu-53.1/source/common/umapfile.c
In file included from /usr/include/inttypes.h:20:0,
                 from
/path/to/libs/icu/icu-53.1/source/common/unicode/ptypes.h:80,
                 from
/path/to/libs/icu/icu-53.1/source/common/unicode/umachine.h:44,
                 from
/path/to/libs/icu/icu-53.1/source/common/unicode/utypes.h:36,
                 from
/path/to/libs/icu/icu-53.1/source/common/unicode/putil.h:27,
                 from /path/to/libs/icu/icu-53.1/source/common/umapfile.c:22:
/opt/csw/lib/gcc/sparc-sun-solaris2.10/4.9.0/include-fixed/sys/feature_tests.h:350:2:
error: #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001
applications         require the use of c99"
 #error "Compiler or options invalid; UNIX 03 and POSIX.1-2001 applications \
  ^
gmake: Nothing to be done for 'all'.


# now add CFLAGS

~/tl/Work/libs/icu/icu-build/common > gmake
generating dependency information for
/path/to/libs/icu/icu-53.1/source/common/umapfile.c
gmake: Nothing to be done for 'all'.

Mojca