[tlbuild] Test suite failing in libs/paper

[Marc Baudoin]

Marc Baudoin <babafou at babafou.eu.org> écrit :
> Peter Breitenlohner <peb at mppmu.mpg.de> écrit :
> > 
> > The file utils/psutils/psutils.test (in the source tree) is an ordinary
> > shell script.  Running 'make check' executes in utils/psutils/ in the build
> > tree exports srcdir into the environment and runs this script, thus you can
> > easily repeat this manually.  The output appears in psutils.log whereas
> > test-suite.log contains a summary for all tests and the output of the failed
> > tests.
> 
> In the playnup.2 file (which is diffed against what the test is
> supposed to print), I have:
> 
> ./psnup:
> can't open input file playnup.ps
> 
> Indeed, there is no playnup.ps file to be found.

It looks like the psnup code is wrong.  getopt() specifies the -1
to -9 options need an optional argument (because they are
followed by a double colon) so they swallow the input file as
their argument and psnup believes playnup.ps is its input file.

The attached patch restores what seems to me is the right
behavior.
-------------- next part --------------
--- psnup.c	2013-10-25 14:33:38.000000000 +0200
+++ /tmp/psnup.c	2013-11-20 17:21:45.000000000 +0100
@@ -64,7 +64,7 @@
 
    while((opt =
           getopt(argc, argv,
-                 "qd::lrfcw:W:h:H:m:b:t:s:p:P:n:1::2::3::4::5::6::7::8::9::"))
+                 "qd::lrfcw:W:h:H:m:b:t:s:p:P:n:123456789"))
          != EOF) {
      switch(opt) {
      case 'q':	/* quiet */