[tlbuild] Build failure in libs/icu/

[Vladimir Volovich]

Hi Peter,

On Sun, 11 Oct 2009, Vladimir Volovich wrote:
> i see changes such as:
>
> -       echo "${srcdir}/configure" | sed 's,icu/dummy/,icu/icu-xetex/,' >$@
> +       d=$(srcdir); test "x$$d" = x. && d=../../icu/dummy; \
> +       echo "$$d/configure" | sed 's,icu/dummy/,icu/icu-xetex/,' >$@
>
> but it seems better to use $(abs_srcdir) in such cases? it is being set
> in Makefile.

 PB> why would that be so? Or in other words: what exactly would be your
 PB> replacement?

my guess would be

-       echo "${srcdir}/configure" | sed 's,icu/dummy/,icu/icu-xetex/,' >$@
+       echo "${top_srcdir}/configure" | sed 's,icu/dummy/,icu/icu-xetex/,' >$@

though i did not test.

tests such as

  test "x$srcdir" = x. && srcdir=../icu

or

  d=$(srcdir); test "x$$d" = x. && d=../../icu/dummy

look hackish, and suggest that one should use the absolute counterpart
of srcdir instead.

Best,
v.