[tlbuild] hashcode return type

Angelo Graziosi angelo.graziosi at alice.it
Mon Jun 8 11:14:09 CEST 2009


Karl Berry wrote:

> My "patch" is
> one line, string.cc:534 --
> -uint32_t
> +unsigned

Indeed. But in this case, in string.cc, you will have:

unsigned
String::hashcode(const char *begin, const char *end)
{
[...]
uint32_t hash = end - begin;
[other uint32_t declaration]
[...]
return hash;
}

which also looks confusing to me (formally, mismatch in return type).

Cheers,
Angelo.



More information about the tlbuild mailing list