pretest: error with tlmgr and lz4 backups

[Johannes Hielscher]

Am Sat, 2 Mar 2019 08:33:14 +0900
schrieb Norbert Preining <preining at logic.at>:

> On Fri, 01 Mar 2019, Karl Berry wrote:
> >       * Don't rely on a working --rm [for lz4], and delete the
> >         uncompressed backup tarball by a separate step after
> > compression  
> 
> svn r50190
> 
> hope it flies.

Yes. Thanks! Of course, the first iteration (infra update) still posed
the error, but the subsequent updates went fine, backups are in .tar.lz4
format.

A minor comment to the patch: Are we confident that unconditionally
deleting the uncompressed tarball doesn't hurt in any case? Or should
we rather test for the existence of the compressed file, too, i. e.:

Index: Master/tlpkg/TeXLive/TLPOBJ.pm
===================================================================
--- Master/tlpkg/TeXLive/TLPOBJ.pm      (Revision 50201)
+++ Master/tlpkg/TeXLive/TLPOBJ.pm      (Arbeitskopie)
@@ -736,9 +736,10 @@
         tlwarn("$0: Couldn't compress $destdir/$tarname\n");
         return (0,0, "");
       }
-      # make sure we remove the original tar since lc does not 
-      # automatically remove it
-      unlink("$destdir/$tarname") if (-r "$destdir/$tarname");
+      # make sure we remove the original tar since old lz4 versions
+      # cannot automatically delete it
+      unlink("$destdir/$tarname") if ((-r "$destdir/$tarname")
+                                   && (-r "$destdir/$containername"));
     } else {
       tlwarn("$0: Couldn't find $destdir/$tarname to run $compressor\n");
       return (0, 0, "");

?

Best,
Johannes

> 
> Norbert
> 
> --
> PREINING Norbert
> http://www.preining.info Accelia Inc.     +    JAIST     +    TeX
> Live     +    Debian Developer GPG: 0x860CDC13   fp: F7D8 A928 26E3
> 16A1 9FA0 ACF0 6CAC A448 860C DC13