[tex-live] Set HAVE_ICU_BUILTIN when building HarfBuzz

Khaled Hosny dr.khaled.hosny at gmail.com
Fri Oct 19 17:17:58 CEST 2018


Hi all,

Not sure if this is the right place to send such patches, so please let
me know if I should submit it somewhere else.

TeX Live’s build system builds ICU support for HarfBuzz in the main
library and not as separate library as HarfBuzz’s own build system does
by default. When ICU support is built in, HarfBuzz wants
HAVE_ICU_BUILTIN to be defined so it knows that and makes use of such
support, otherwise HarfBuzz clients would need to call
hb_buffer_set_unicode_funcs() manually. This does not affect XeTeX as it
already does this, but it helps me with my HarfBuzz in LuaTeX
experiments.

Regards,
Khaled

P.S. I didn’t include in this patch the changes to generated files that
result from calling reautoconf.
-------------- next part --------------
diff --git a/libs/harfbuzz/configure.ac b/libs/harfbuzz/configure.ac
index ebb17a1d..3ec67667 100644
--- a/libs/harfbuzz/configure.ac
+++ b/libs/harfbuzz/configure.ac
@@ -85,6 +85,7 @@ fi
 if :; then
   AC_DEFINE([HAVE_OT], 1, [Use native OpenType Layout backend])
   AC_DEFINE([HAVE_ICU], 1, [Use ICU library])
+  AC_DEFINE([HAVE_ICU_BUILTIN], 1, [ICU support is not a seperate library])
   AC_DEFINE([HAVE_GRAPHITE2], 1, [Use Graphite library])
 else
 dnl add all these to config.h.in but do not define them in config.h


More information about the tex-live mailing list