[tex-live] QA Notice: Package has poor programming practices

[Jonathan Kew]

On 4 May 2009, at 17:36, Karl Berry wrote:

> Hi Toralf,
>
>     * xetexdir/jpegimage.c:143: warning: incompatible implicit  
> declaration of
>    built-in function 'free'
>
> Evidently xetexdir/jpegimage.c does not do
> #include <stdlib.h>
>
> Jonathan, any reason not to simply add that line?

Not that I can think of.

> It does, bizarrely, #include <memory.h>, although I don't see bcopy  
> and
> the like being used.  <string.h> would be the standard header for the
> str* functions, for umpteen years now.  Even on BSD systems :).

Looks like some cleanup would be in order. Patches welcome! :)

JK