[tex-live] OK to update freetype2 source in TL?

[Jonathan Kew]

On 11 Jul 2006, at 5:46 pm, Vladimir Volovich wrote:

> Hi Jonathan,
>
> "JK" == Jonathan Kew writes:
>
>  JK> I'd like to update the freetype2 sources (currently 2.0.9) to the
>  JK> latest release (2.2.1),
> [...]
>  JK> Comments, suggestions, advice all welcomed....
>
> the best way seems to be to compare (using "diff -ruw") the current
> sources which are in TeX Live repository with the vanilla (official)
> 2.0.9 sources, and then apply any differences again to the official
> 2.2.1 sources.

The findings:

(1) The declaration of one internal Freetype function,  
FT_Render_Glyph_Internal, has been changed in TL to make the function  
public.

However, a recursive grep over the TL source tree doesn't find  
anything outside of freetype2 itself that actually uses this. Perhaps  
some tool used to call this but has been changed to use the public  
APIs instead. So I don't think it's necessary to apply this change  
any longer.

(2) There's the addition of __cdecl to several callback functions,  
and __cdecl and __declspec(dllexport) to public APIs.

I'm not sure about the status of these. As far as I'm aware,  
freetype2 is usable "out of the box" on Windows, and shouldn't  
require any changes to build with standard compilers (either gcc or  
Visual C++). I suspect these modifications were needed for older (16- 
bit?) compilers, but may be outdated now -- either not needed with  
current compilers, or provided by the standard freetype2  
configuration on Windows. I'd be reluctant to make changes like this  
to the standard freetype2 sources unless there is a confirmed need.

(3) There are added win32.mak, depend.mak, and freetype2.rc files in  
the TL copy.

I can add these to the new 2.2.1 subtree, and try to update the  
content where appropriate (e.g., version information in the .rc), but  
will not be able to check the correctness of the resulting files.


So I'd suggest that we update to unmodified freetype-2.2.1 sources,  
and add the files required to build in the tex-live context -- I  
presume that means the existing Windows-related .mak and .rc files.  
I'll also be needing to add withenable.ac and freetype2.ac, as this  
library will be used in the Unix (etc) builds of xetex. Any changes  
in the actual FT sources would only be reintroduced if shown to be  
necessary.

OK?

JK