texlive[73998] Build/source/texk/xdvik: comment about the known

[commits+karl at tug.org]

Revision: 73998
          https://tug.org/svn/texlive?view=revision&revision=73998
Author:   karl
Date:     2025-02-15 19:15:36 +0100 (Sat, 15 Feb 2025)
Log Message:
-----------
comment about the known problem of incompatible pointer types in the XawListChange call

Modified Paths:
--------------
    trunk/Build/source/texk/xdvik/ChangeLog
    trunk/Build/source/texk/xdvik/gui/pagesel.c

Modified: trunk/Build/source/texk/xdvik/ChangeLog
===================================================================
--- trunk/Build/source/texk/xdvik/ChangeLog	2025-02-15 06:31:05 UTC (rev 73997)
+++ trunk/Build/source/texk/xdvik/ChangeLog	2025-02-15 18:15:36 UTC (rev 73998)
@@ -1,3 +1,12 @@
+2025-02-15  Karl Berry  <karl at freefriends.org>
+
+	* gui/pagesel.c (xaw_update_list): put in comment about the known
+	problem of incompatible pointer types in the XawListChange call.
+	A configure test seems to be needed.
+	xdvi bug report: https://sourceforge.net/p/xdvi/bugs/406/
+	discussion of alternatives:
+	  https://tug.org/pipermail/tex-k/2024-February/004008.html
+
 2024-11-26  Sam James  <sam at gentoo.org>
 
 	* dvi-draw.c (lseek,pow): remove () declarations, incompatible

Modified: trunk/Build/source/texk/xdvik/gui/pagesel.c
===================================================================
--- trunk/Build/source/texk/xdvik/gui/pagesel.c	2025-02-15 06:31:05 UTC (rev 73997)
+++ trunk/Build/source/texk/xdvik/gui/pagesel.c	2025-02-15 18:15:36 UTC (rev 73998)
@@ -538,6 +538,18 @@
     button_width = get_panel_width() - 2 * (resource.btn_side_spacing + resource.btn_border_width);
     /* delete and re-create list */
     ASSERT(total_pages <= (int)page_info.index_size, "");
+
+    /* The following line causes a gcc incompatible-pointer-types error
+       on some system, due to lack and/or presence of const in the
+       XawListChange function parameter. Unfortunately different systems
+       evidently have different, and incompatible, types for that
+       parameter. Thus a cast to any single type will fail on some
+       systems. A configure test to determine the correct type for the
+       cast seems like the only robust solution? --karl, 15feb25.
+       xdvi bug report: https://sourceforge.net/p/xdvi/bugs/406/
+       discussion of alternatives:
+         https://tug.org/pipermail/tex-k/2024-February/004008.html
+    */
     XawListChange(LIST_WIDGET, page_info.page_labels, 0,
 		  MAX(button_width, pagelist_width), False);
     /* restore selected item */