texlive[50963] Build/source/libs: harfbuzz-2.4.0
commits+kakuto at tug.org
commits+kakuto at tug.org
Fri May 3 07:32:58 CEST 2019
Revision: 50963
http://tug.org/svn/texlive?view=revision&revision=50963
Author: kakuto
Date: 2019-05-03 07:32:57 +0200 (Fri, 03 May 2019)
Log Message:
-----------
harfbuzz-2.4.0
Modified Paths:
--------------
trunk/Build/source/libs/README
trunk/Build/source/libs/harfbuzz/ChangeLog
trunk/Build/source/libs/harfbuzz/TLpatches/ChangeLog
trunk/Build/source/libs/harfbuzz/TLpatches/TL-Changes
trunk/Build/source/libs/harfbuzz/configure
trunk/Build/source/libs/harfbuzz/harfbuzz-src/CMakeLists.txt
trunk/Build/source/libs/harfbuzz/harfbuzz-src/ChangeLog
trunk/Build/source/libs/harfbuzz/harfbuzz-src/Makefile.am
trunk/Build/source/libs/harfbuzz/harfbuzz-src/NEWS
trunk/Build/source/libs/harfbuzz/harfbuzz-src/configure.ac
trunk/Build/source/libs/harfbuzz/harfbuzz-src/gtk-doc.make
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/check-symbols.sh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/gen-indic-table.py
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/gen-use-table.py
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/gen-vowel-constraints.py
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-aat-layout-ankr-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-aat-layout-common.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-atomic.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-buffer.h
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-common.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-common.h
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-coretext.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-directwrite.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-directwrite.h
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-dsalgs.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-graphite2.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-machinery.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-map.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-null.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-cff-common.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-cff1-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-font.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-hdmx-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-hmtx-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-layout-common.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-layout-gsub-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-layout.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-layout.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-maxp-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-arabic-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-arabic.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-hangul.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-indic-machine.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-indic-machine.rl
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-indic-table.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-indic.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-indic.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-khmer-machine.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-khmer-machine.rl
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-khmer.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-myanmar.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-use-table.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-use.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex-vowel-constraints.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape-complex.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-shape.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-tag-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-tag.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ot-vorg-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-cff-common.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-cff-common.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-cff1.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-cff2.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-glyf.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-input.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-input.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-plan.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset-plan.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-subset.h
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-ucdn.cc
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb-unicode-emoji-table.hh
trunk/Build/source/libs/harfbuzz/harfbuzz-src/src/hb.hh
trunk/Build/source/libs/harfbuzz/version.ac
Removed Paths:
-------------
trunk/Build/source/libs/harfbuzz/TLpatches/patch-01-solaris
Modified: trunk/Build/source/libs/README
===================================================================
--- trunk/Build/source/libs/README 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/README 2019-05-03 05:32:57 UTC (rev 50963)
@@ -25,7 +25,7 @@
http://sourceforge.net/projects/silgraphite/files/graphite2/
(requires C++11)
-harfbuzz 2.3.1 - checked 31jan19
+harfbuzz 2.4.0 - checked 03may19
http://www.freedesktop.org/software/harfbuzz/release/
icu 63.1 - checked 8jan19
Modified: trunk/Build/source/libs/harfbuzz/ChangeLog
===================================================================
--- trunk/Build/source/libs/harfbuzz/ChangeLog 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/ChangeLog 2019-05-03 05:32:57 UTC (rev 50963)
@@ -1,3 +1,8 @@
+2019-05-03 Akira Kakuto <kakuto at w32tex.org>
+
+ Import harfbuzz-2.4.0.
+ * version.ac: Adjusted.
+
2019-01-31 Akira Kakuto <kakuto at w32tex.org>
Import harfbuzz-2.3.1.
Modified: trunk/Build/source/libs/harfbuzz/TLpatches/ChangeLog
===================================================================
--- trunk/Build/source/libs/harfbuzz/TLpatches/ChangeLog 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/TLpatches/ChangeLog 2019-05-03 05:32:57 UTC (rev 50963)
@@ -1,3 +1,9 @@
+2019-05-03 Akira Kakuto <kakuto at w32tex.org>
+
+ Imported harfbuzz-2.4.0 source tree from:
+ http://www.freedesktop.org/software/harfbuzz/release/
+ patch-01-solaris: Removed.
+
2019-02-01 Mojca Miklavec <mojca.miklavec.lists at gmail.com>
Upstream patch to fix build issue on Solaris
Modified: trunk/Build/source/libs/harfbuzz/TLpatches/TL-Changes
===================================================================
--- trunk/Build/source/libs/harfbuzz/TLpatches/TL-Changes 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/TLpatches/TL-Changes 2019-05-03 05:32:57 UTC (rev 50963)
@@ -1,4 +1,4 @@
-Changes applied to the harfbuzz-2.3.1/ tree as obtained from:
+Changes applied to the harfbuzz-2.4.0/ tree as obtained from:
http://www.freedesktop.org/software/harfbuzz/release/
Removed:
Deleted: trunk/Build/source/libs/harfbuzz/TLpatches/patch-01-solaris
===================================================================
--- trunk/Build/source/libs/harfbuzz/TLpatches/patch-01-solaris 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/TLpatches/patch-01-solaris 2019-05-03 05:32:57 UTC (rev 50963)
@@ -1,40 +0,0 @@
-https://github.com/harfbuzz/harfbuzz/commit/1e06282105a2d579aab32094cc7abc10ed231978
-
-diff --git a/src/hb-dsalgs.hh b/src/hb-dsalgs.hh
-index 6ccba158c..0da244f0a 100644
---- a/src/hb-dsalgs.hh
-+++ b/src/hb-dsalgs.hh
-@@ -299,24 +299,15 @@ hb_ceil_to_4 (unsigned int v)
- }
-
- template <typename T> struct hb_is_signed;
--template <> struct hb_is_signed<signed char> { enum { value = true }; };
--template <> struct hb_is_signed<signed short> { enum { value = true }; };
--template <> struct hb_is_signed<signed int> { enum { value = true }; };
--template <> struct hb_is_signed<signed long> { enum { value = true }; };
--template <> struct hb_is_signed<unsigned char> { enum { value = false }; };
--template <> struct hb_is_signed<unsigned short> { enum { value = false }; };
--template <> struct hb_is_signed<unsigned int> { enum { value = false }; };
--template <> struct hb_is_signed<unsigned long> { enum { value = false }; };
--/* We need to define hb_is_signed for the typedefs we use on pre-Visual
-- * Studio 2010 for the int8_t type, since __int8/__int64 is not considered
-- * the same as char/long. The previous lines will suffice for the other
-- * types, though. Note that somehow, unsigned __int8 is considered same
-- * as unsigned char.
-- * https://github.com/harfbuzz/harfbuzz/pull/1499
-- */
--#if defined(_MSC_VER) && (_MSC_VER < 1600)
--template <> struct hb_is_signed<__int8> { enum { value = true }; };
--#endif
-+/* https://github.com/harfbuzz/harfbuzz/issues/1535 */
-+template <> struct hb_is_signed<int8_t> { enum { value = true }; };
-+template <> struct hb_is_signed<int16_t> { enum { value = true }; };
-+template <> struct hb_is_signed<int32_t> { enum { value = true }; };
-+template <> struct hb_is_signed<int64_t> { enum { value = true }; };
-+template <> struct hb_is_signed<uint8_t> { enum { value = false }; };
-+template <> struct hb_is_signed<uint16_t> { enum { value = false }; };
-+template <> struct hb_is_signed<uint32_t> { enum { value = false }; };
-+template <> struct hb_is_signed<uint64_t> { enum { value = false }; };
-
- template <typename T> static inline bool
- hb_in_range (T u, T lo, T hi)
Modified: trunk/Build/source/libs/harfbuzz/configure
===================================================================
--- trunk/Build/source/libs/harfbuzz/configure 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/configure 2019-05-03 05:32:57 UTC (rev 50963)
@@ -1,6 +1,6 @@
#! /bin/sh
# Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.69 for harfbuzz (TeX Live) 2.3.1.
+# Generated by GNU Autoconf 2.69 for harfbuzz (TeX Live) 2.4.0.
#
# Report bugs to <tex-k at tug.org>.
#
@@ -580,8 +580,8 @@
# Identity of this package.
PACKAGE_NAME='harfbuzz (TeX Live)'
PACKAGE_TARNAME='harfbuzz--tex-live-'
-PACKAGE_VERSION='2.3.1'
-PACKAGE_STRING='harfbuzz (TeX Live) 2.3.1'
+PACKAGE_VERSION='2.4.0'
+PACKAGE_STRING='harfbuzz (TeX Live) 2.4.0'
PACKAGE_BUGREPORT='tex-k at tug.org'
PACKAGE_URL=''
@@ -1317,7 +1317,7 @@
# Omit some internal or obsolete options to make the list less imposing.
# This message is too long to be a string in the A/UX 3.1 sh.
cat <<_ACEOF
-\`configure' configures harfbuzz (TeX Live) 2.3.1 to adapt to many kinds of systems.
+\`configure' configures harfbuzz (TeX Live) 2.4.0 to adapt to many kinds of systems.
Usage: $0 [OPTION]... [VAR=VALUE]...
@@ -1388,7 +1388,7 @@
if test -n "$ac_init_help"; then
case $ac_init_help in
- short | recursive ) echo "Configuration of harfbuzz (TeX Live) 2.3.1:";;
+ short | recursive ) echo "Configuration of harfbuzz (TeX Live) 2.4.0:";;
esac
cat <<\_ACEOF
@@ -1495,7 +1495,7 @@
test -n "$ac_init_help" && exit $ac_status
if $ac_init_version; then
cat <<\_ACEOF
-harfbuzz (TeX Live) configure 2.3.1
+harfbuzz (TeX Live) configure 2.4.0
generated by GNU Autoconf 2.69
Copyright (C) 2012 Free Software Foundation, Inc.
@@ -2131,7 +2131,7 @@
This file contains any messages produced by compilers while
running configure, to aid debugging if configure makes a mistake.
-It was created by harfbuzz (TeX Live) $as_me 2.3.1, which was
+It was created by harfbuzz (TeX Live) $as_me 2.4.0, which was
generated by GNU Autoconf 2.69. Invocation command line was
$ $0 $@
@@ -4055,7 +4055,7 @@
# Define the identity of the package.
PACKAGE='harfbuzz--tex-live-'
- VERSION='2.3.1'
+ VERSION='2.4.0'
# Some tools Automake needs.
@@ -4248,9 +4248,9 @@
HB_VERSION_MAJOR=2
-HB_VERSION_MINOR=3
-HB_VERSION_MICRO=1
-HB_VERSION=2.3.1
+HB_VERSION_MINOR=4
+HB_VERSION_MICRO=0
+HB_VERSION=2.4.0
ac_ext=c
ac_cpp='$CPP $CPPFLAGS'
@@ -8155,7 +8155,7 @@
# report actual input values of CONFIG_FILES etc. instead of their
# values after options handling.
ac_log="
-This file was extended by harfbuzz (TeX Live) $as_me 2.3.1, which was
+This file was extended by harfbuzz (TeX Live) $as_me 2.4.0, which was
generated by GNU Autoconf 2.69. Invocation command line was
CONFIG_FILES = $CONFIG_FILES
@@ -8221,7 +8221,7 @@
cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
ac_cs_version="\\
-harfbuzz (TeX Live) config.status 2.3.1
+harfbuzz (TeX Live) config.status 2.4.0
configured by $0, generated by GNU Autoconf 2.69,
with options \\"\$ac_cs_config\\"
Modified: trunk/Build/source/libs/harfbuzz/harfbuzz-src/CMakeLists.txt
===================================================================
--- trunk/Build/source/libs/harfbuzz/harfbuzz-src/CMakeLists.txt 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/harfbuzz-src/CMakeLists.txt 2019-05-03 05:32:57 UTC (rev 50963)
@@ -842,18 +842,6 @@
endif ()
endif ()
-if (UNIX AND CMAKE_GENERATOR STREQUAL "Ninja")
- if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
- set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fcolor-diagnostics")
- set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fcolor-diagnostics")
- endif ()
- if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
- set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fdiagnostics-color")
- set (CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -fdiagnostics-color")
- endif ()
-endif ()
-
-
if (HB_BUILD_TESTS)
## src/ executables
foreach (prog main test test-would-substitute test-size-params test-buffer-serialize hb-ot-tag test-unicode-ranges)
Modified: trunk/Build/source/libs/harfbuzz/harfbuzz-src/ChangeLog
===================================================================
--- trunk/Build/source/libs/harfbuzz/harfbuzz-src/ChangeLog 2019-05-03 04:51:31 UTC (rev 50962)
+++ trunk/Build/source/libs/harfbuzz/harfbuzz-src/ChangeLog 2019-05-03 05:32:57 UTC (rev 50963)
@@ -1,9 +1,1361 @@
+commit d6fc1d49aa099104a889c96bc9087c21d8fc0960
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Mar 28 21:21:26 2019 -0700
+
+ 2.4.0
+
+ NEWS | 11 +++++++++++
+ configure.ac | 2 +-
+ src/hb-buffer.h | 2 +-
+ src/hb-version.h | 6 +++---
+ 4 files changed, 16 insertions(+), 5 deletions(-)
+
+commit d2db71fdc4764eecf8320cf465ee0e4254146b6e
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Mar 28 21:00:58 2019 -0700
+
+ Use internal bsearch() for language tags
+
+ Fixes https://github.com/harfbuzz/harfbuzz/pull/1639
+
+ src/hb-ot-tag.cc | 46 ++++++++++++++++++++++------------------------
+ 1 file changed, 22 insertions(+), 24 deletions(-)
+
+commit 21bb80ebf2e20025a196386cee8fd92dd1eb4597
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Mar 28 20:50:04 2019 -0700
+
+ [indic] Add back medial-consonant to grammar
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1592
+
+ src/hb-ot-shape-complex-indic-machine.hh | 1244 +++++++++++---------
+ src/hb-ot-shape-complex-indic-machine.rl | 5 +-
+ src/hb-ot-shape-complex-indic.cc | 2 +-
+ src/hb-ot-shape-complex-indic.hh | 6 +-
+ .../f75c4b05a0a4d67c1a808081ae3d74a9c66509e8.ttf | Bin 0 -> 1924 bytes
+ .../data/in-house/tests/indic-syllable.tests | 2 +
+ 6 files changed, 672 insertions(+), 587 deletions(-)
+
+commit 5ab6de7a6fbad4c4a954c2c81d216486a5a14f72
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Mar 28 20:23:12 2019 -0700
+
+ [khmer] Add trailing Coeng to syllable grammar
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1541
+
+ src/hb-ot-shape-complex-khmer-machine.hh | 248 ++++++++++-----------
+ src/hb-ot-shape-complex-khmer-machine.rl | 2 +-
+ .../ad01ab2ea1cb1a4d3a2783e2675112ef11ae6404.ttf | Bin 0 -> 1500 bytes
+ test/shaping/data/in-house/tests/khmer-misc.tests | 1 +
+ 4 files changed, 122 insertions(+), 129 deletions(-)
+
+commit 7360265e69a8cdaa9f993c36def2860a79cca49f
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Thu Mar 28 16:57:56 2019 -0700
+
+ [ci] Tweak macos and psvita bots (#1638)
+
+ * Add --with-graphite2 to macOS
+ * Add a dummy ragel script for psvita
+
+ .circleci/config.yml | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+commit a548d1da78b506cc6460fdde3715f6ef13ccad48
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Thu Mar 28 15:42:45 2019 -0700
+
+ [ci] Use only CircleCI for macOS (#1637)
+
+ .circleci/config.yml | 5 +++--
+ .travis.yml | 18 ------------------
+ 2 files changed, 3 insertions(+), 20 deletions(-)
+
+commit 160b4a2b01e925812fbf0e7db5bc9dcb90dc81cc
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Mar 28 13:44:38 2019 -0700
+
+ Fix shell syntax error
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1612
+
+ src/check-symbols.sh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 8665b9b0a24e4d46e486057d72c0486b9da16523
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Mar 28 11:11:52 2019 -0700
+
+ Comment
+
+ src/hb.hh | 1 +
+ 1 file changed, 1 insertion(+)
+
+commit a7eed7e41dba8e583a9c740a4ca7ddf53e77de63
+Author: punchcutter <zarijoscha at gmail.com>
+Date: Wed Mar 27 23:12:58 2019 -0700
+
+ Override USE category for Grantha and Tirhuta visargas to allow marks
+
+ src/gen-use-table.py | 3 ++-
+ src/hb-ot-shape-complex-use-table.cc | 4 ++--
+ 2 files changed, 4 insertions(+), 3 deletions(-)
+
+commit cf040c0fef4a049a75a5ec7972f518b9034bdc76
+Author: Egor Pugin <egor.pugin at gmail.com>
+Date: Thu Mar 28 19:06:12 2019 +0300
+
+ Disable unwanted C++ definitions for MSVC.
+
+ MSVC does not set __cplusplus to the latest standard and also it does not like redefining some keywords.
+
+ src/hb.hh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 717181c5943c13a682c719dce10bfc3d9cc47e6b
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Wed Mar 27 16:38:39 2019 +0430
+
+ [ci] remove ragel from psvita compile bot
+
+ .circleci/config.yml | 1 -
+ 1 file changed, 1 deletion(-)
+
+commit 08e36c5d8be22b3a7e31f33af9452372dafeacc0
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Wed Mar 27 16:21:47 2019 +0430
+
+ [ci] Don't install ragel on cmake build bot images
+
+ It is not needed anyway
+
+ .circleci/config.yml | 5 -----
+ 1 file changed, 5 deletions(-)
+
+commit ec2a5dc859b03ceb92518aa992e4e9c053b30534
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Tue Mar 26 16:18:03 2019 -0700
+
+ Use class templates for Null objects
+
+ This allows partial-instantiating custom Null object for template Lookup<T>.
+ Before, this had to be handcoded per instantiation. Apparently I missed
+ adding one for AAT::ankr.lookupTable, so it was getting the wrong (generic)
+ null for Lookup object, which is wrong and unsafe.
+
+ Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=944346
+
+ src/hb-aat-layout-common.hh | 14 ++++------
+ src/hb-null.hh | 31 +++++++++++++--------
+ ...case-minimized-harfbuzz_fuzzer-5748102301614080 | Bin 0 -> 213 bytes
+ 3 files changed, 24 insertions(+), 21 deletions(-)
+
+commit 96f12377942dbe1c6b1d0ffa7d626d99cb265443
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Tue Mar 26 16:17:45 2019 -0700
+
+ [aat] Add missing check to ankr table
+
+ Isn't absolutely needed. But helps.
+
+ src/hb-aat-layout-ankr-table.hh | 1 +
+ 1 file changed, 1 insertion(+)
+
+commit e5dfffb1ef610a982ed9878fbf3f9ee49cbc3a97
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Mon Mar 25 15:15:37 2019 -0700
+
+ [docs] Update
+
+ docs/harfbuzz-docs.xml | 1 +
+ 1 file changed, 1 insertion(+)
+
+commit 0dd3fdf9d227f9bd79f395078f8e58dcfc32d1bf
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Mon Mar 25 15:08:14 2019 -0700
+
+ Update ChangeLog generation
+
+ Let's see if I can make a release on Mac...
+
+ Makefile.am | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 2d9034491eca0a63db82d3801f05c067a5241b7d
+Author: Qunxin Liu <qxliu at google.com>
+Date: Tue Mar 26 10:37:24 2019 -0700
+
+ completely remove lines that are commented out
+
+ src/hb-subset-plan.cc | 6 ------
+ src/hb-subset-plan.hh | 3 ---
+ 2 files changed, 9 deletions(-)
+
+commit 3147133b6173487c26813a2a406aebd067b53fbf
+Author: Qunxin Liu <qxliu at google.com>
+Date: Tue Mar 26 09:15:56 2019 -0700
+
+ update arguments in_populate_gids_to_retain() and _create_old_gid_to_new_gid_map()
+ so they don't use deprecated variable
+
+ src/hb-subset-plan.cc | 36 ++++++++++++++++++------------------
+ 1 file changed, 18 insertions(+), 18 deletions(-)
+
+commit 79a6c258497e80be15245a7b576e34443d9f7bff
+Author: Qunxin Liu <qxliu at google.com>
+Date: Mon Mar 25 19:59:37 2019 -0700
+
+ try to remove deprecated variable from struct definition
+
+ src/hb-subset-plan.cc | 9 +++++----
+ src/hb-subset-plan.hh | 2 +-
+ 2 files changed, 6 insertions(+), 5 deletions(-)
+
+commit bcb4e505d6ffe33e3268a06698e75d6be0e64957
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Mar 15 13:46:25 2019 -0700
+
+ cff2 subset fuzzer issues (#1619)
+
+ * add check to FDArray::serialize
+
+ * add test files
+
+ * fix off by one
+
+ src/hb-ot-cff-common.hh | 1 +
+ ...z-testcase-minimized-hb-subset-fuzzer-5739000398086144 | Bin 0 -> 620 bytes
+ ...z-testcase-minimized-hb-subset-fuzzer-5760768497156096 | Bin 0 -> 210 bytes
+ ...z-testcase-minimized-hb-subset-fuzzer-5764268627066880 | Bin 0 -> 687 bytes
+ 4 files changed, 1 insertion(+)
+
+commit 8aaab78efcac81a05ec919be13792c98741ea1b5
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Thu Mar 14 16:49:42 2019 -0700
+
+ Allow zero length ranges in sanitization (#1617)
+
+ Fixes fvar table sanitization where there are no named instance
+ by allowing zero length ranges starting from Null() address.
+
+ Fixes #1607
+
+ src/hb-machinery.hh | 30 ++++++++++++++++--------------
+ test/api/fonts/Zycon.ttf | Bin 0 -> 21036 bytes
+ test/api/test-ot-face.c | 9 +++++++++
+ 3 files changed, 25 insertions(+), 14 deletions(-)
+
+commit b1dfb8c850f36d4065190a779a6e3342a5fbb593
+Author: Khaled Hosny <khaledhosny at eglug.org>
+Date: Thu Mar 14 21:41:25 2019 +0200
+
+ [ci] Cache FreeType build on Travis
+
+ .ci/build-freetype.sh | 17 +++++++++++++++++
+ .travis.yml | 18 ++++++++++++------
+ 2 files changed, 29 insertions(+), 6 deletions(-)
+
+commit 7de9f92ee9ced6f4c176459cf25f4ca931ca5ceb
+Author: David Corbett <corbett.dav at husky.neu.edu>
+Date: Tue Mar 12 19:30:47 2019 -0400
+
+ Categorize U+09FC as Consonant_Placeholder
+
+ src/hb-ot-shape-complex-indic.hh | 1 +
+ 1 file changed, 1 insertion(+)
+
+commit 8b1eaecd9485fe504af364db1537bb04852b265c
+Author: Khaled Hosny <khaledhosny at eglug.org>
+Date: Wed Mar 13 13:21:12 2019 +0200
+
+ [ci] Simplify and fix Travis CI macOS build
+
+ .travis.yml | 16 +++++++++-------
+ 1 file changed, 9 insertions(+), 7 deletions(-)
+
+commit e52ec3fc23c2d5a881849f047885e0423bd74740
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Mon Mar 11 18:09:51 2019 -0700
+
+ Remove redundant hb_ot_layout_lookup_would_substitute_fast
+
+ src/hb-ot-layout.cc | 13 -------------
+ src/hb-ot-layout.hh | 7 -------
+ src/hb-ot-shape-complex-indic.cc | 2 +-
+ src/hb-ot-shape-complex-khmer.cc | 2 +-
+ 4 files changed, 2 insertions(+), 22 deletions(-)
+
+commit c2442c90d6ecfaee987ed8ac6f93a9ac6b07c642
+Author: Khaled Hosny <khaledhosny at eglug.org>
+Date: Tue Mar 12 01:09:27 2019 +0200
+
+ [doc] Add placeholder since version for new flag
+
+ src/hb-buffer.h | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 8c42f03215097d7c1bae74db7e98315263d3e8a4
+Author: David Corbett <corbett.dav at husky.neu.edu>
+Date: Fri Mar 8 09:46:48 2019 -0500
+
+ Remove obsolete overrides from Indic/USE scripts
+
+ src/gen-indic-table.py | 4 ----
+ src/gen-use-table.py | 30 +++++++-----------------------
+ src/hb-ot-shape-complex-use-table.cc | 2 +-
+ 3 files changed, 8 insertions(+), 28 deletions(-)
+
+commit b38bab86229bc40d9cdf4819d6dc6aab444d0291
+Author: Eric Muller <emuller at amazon.com>
+Date: Tue Feb 12 11:41:16 2019 -0800
+
+ Update generation code for hb-ot-shape-complex-vowel-constraints.cc. Remove 'unlikely'
+
+ src/gen-vowel-constraints.py | 3 +++
+ src/hb-ot-shape-complex-vowel-constraints.cc | 2 +-
+ 2 files changed, 4 insertions(+), 1 deletion(-)
+
+commit 44a67ddeb878f7639b30d1884e38b1525aab4f4a
+Author: Eric Muller <emuller at amazon.com>
+Date: Sun Feb 10 04:31:41 2019 -0800
+
+ Fix coding style.
+
+ src/hb-ot-shape-complex-hangul.cc | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+commit 30d7c40f8ce9f47d733b1f43a93f20739772859e
+Author: Eric Muller <emuller at amazon.com>
+Date: Sat Feb 9 02:55:27 2019 -0800
+
+ Add a flag to hb_buffer_t to prevent the insertion of dotted circles on incorrect character sequences.
+
+ Current behavior unchanged if this flag is not set (and it isn't by default).
+
+ src/hb-buffer.h | 7 ++++++-
+ src/hb-ot-shape-complex-hangul.cc | 3 ++-
+ src/hb-ot-shape-complex-indic.cc | 3 +++
+ src/hb-ot-shape-complex-khmer.cc | 3 +++
+ src/hb-ot-shape-complex-myanmar.cc | 3 +++
+ src/hb-ot-shape-complex-use.cc | 3 +++
+ src/hb-ot-shape-complex-vowel-constraints.cc | 3 +++
+ src/hb-ot-shape.cc | 3 +++
+ 8 files changed, 26 insertions(+), 2 deletions(-)
+
+commit 8b6eb6cf465032d0ca747f4b75f6e9155082bc45
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Fri Mar 8 01:33:41 2019 +0330
+
+ Add a macOS 10.14.3 fonts tests (#1608)
+
+ .circleci/config.yml | 11 +++++++++++
+ test/shaping/data/in-house/tests/macos.tests | 19 +++++++++++++++++++
+ 2 files changed, 30 insertions(+)
+
+commit e723c04de1b3dcd96e6a70baf09e3ae2ddbbc0bf
+Author: David Corbett <corbett.dav at husky.neu.edu>
+Date: Wed Mar 6 12:37:25 2019 -0500
+
+ Update to Unicode 12.0.0
+
+ src/gen-use-table.py | 1 -
+ src/gen-vowel-constraints.py | 1 +
+ src/hb-common.h | 8 +
+ src/hb-ot-shape-complex-arabic-table.hh | 14 +-
+ src/hb-ot-shape-complex-indic-table.cc | 56 +-
+ src/hb-ot-shape-complex-use-table.cc | 49 +-
+ src/hb-ot-shape-complex-vowel-constraints.cc | 4 +-
+ src/hb-ot-shape-complex.hh | 3 +
+ src/hb-ot-tag-table.hh | 12 +-
+ src/hb-ucdn.cc | 4 +
+ src/hb-ucdn/ucdn.h | 11 +
+ src/hb-ucdn/ucdn_db.h | 2998 +++++++++++++-------------
+ src/hb-unicode-emoji-table.hh | 6 +-
+ 13 files changed, 1631 insertions(+), 1536 deletions(-)
+
+commit 2f125b0fa763c3be7d8d74489c027f7155607756
+Author: Adrian Wong <adrianwjw at gmail.com>
+Date: Wed Feb 13 21:04:46 2019 +1100
+
+ [indic] Remove superfluous ZWNJ check in final reorder of pre-base matras
+
+ src/hb-ot-shape-complex-indic.cc | 11 ++++++++---
+ 1 file changed, 8 insertions(+), 3 deletions(-)
+
+commit d936ad4582a0017cf88406372d7c08b9896beed6
+Author: Stephan Bergmann <sbergman at redhat.com>
+Date: Tue Mar 5 17:18:57 2019 +0100
+
+ Fix hb_atomic_* variants based on C++11 atomics
+
+ I stumbled over this when trying to upgrade the version of HarfBuzz used by
+ LibreOffice to 3.2.1 (see <https://gerrit.libreoffice.org/plugins/gitiles/core/
+ +/b7ddc514bff9bdf682abae537f990aa01dc2c0fb%5E!/> "Upgrade to latest
+ HarfBuzz 2.3.1"), where building with MSVC 2017 failed like
+
+ > c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2440: 'reinterpret_cast': cannot convert from 'const int *' to 'std::atomic<int> *'
+ > c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): note: Conversion loses qualifiers
+ > c:\cygwin\home\tdf\lode\jenkins\workspace\gerrit_windows\workdir\unpackedtarball\harfbuzz\src\hb-atomic.hh(272): error C2227: left of '->load' must point to class/struct/union/generic type
+
+ (see <https://ci.libreoffice.org/job/gerrit_windows/29916/>).
+
+ I added all the necessary "const" to make building of HarfBuzz 2.3.1 with
+ MSVC 2017 succeed for me. There may be more missing at least conceptually.
+
+ src/hb-atomic.hh | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+commit 731b13e4e9190a45e51f855f19e88869a7718d43
+Author: Martin Hosken <martin_hosken at sil.org>
+Date: Mon Mar 4 11:12:21 2019 +0700
+
+ Fix offset drift in graphite integration
+
+ src/hb-graphite2.cc | 35 +++++++++++++++++++----------------
+ 1 file changed, 19 insertions(+), 16 deletions(-)
+
+commit 8a25868e6a41a3d82782aadb3c7b744ad87d20ff
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Sat Mar 2 03:24:49 2019 +0330
+
+ Minor, remove .editorconfig hack
+
+ As vscode is going to support it soon
+
+ .editorconfig | 7 ++-----
+ 1 file changed, 2 insertions(+), 5 deletions(-)
+
+commit 4f37ab63de9705d7bf74ee75364747e41b7c06a1
+Author: Garret Rieger <grieger at google.com>
+Date: Thu Feb 28 17:25:05 2019 -0800
+
+ Make hb_subset_input_glyph_set () actually do something.
+
+ src/hb-subset-plan.cc | 3 +++
+ test/api/hb-subset-test.h | 11 ++++++++++-
+ test/api/test-subset-glyf.c | 24 ++++++++++++++++++++++++
+ 3 files changed, 37 insertions(+), 1 deletion(-)
+
+commit 45149eb34f9735b5d690a2a7956adb42b938c8d9
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Fri Feb 22 13:13:42 2019 +0330
+
+ [dwrite] hb_directwrite_face_create, a new API
+
+ It makes a hb_face_t from IDWriteFontFace, useful when using
+ DirectWrite facilities for font selection, loading and rendering
+ but using harfbuzz for shaping.
+
+ src/hb-directwrite.cc | 70 +++++++++++++++++++++++++++++++++++++++++++++++----
+ src/hb-directwrite.h | 5 +++-
+ 2 files changed, 69 insertions(+), 6 deletions(-)
+
+commit 45adc185260f0fa1fa86472aafb7f91f942c567e
+Author: David Corbett <corbett.dav at husky.neu.edu>
+Date: Mon Feb 18 22:30:40 2019 -0500
+
+ Fix or document unsupported font-feature-settings
+
+ src/hb-common.cc | 18 ++++++++++++------
+ util/options.cc | 3 ++-
+ 2 files changed, 14 insertions(+), 7 deletions(-)
+
+commit d66f7e14a0097d8ca54ad9824f7aa7daee6c7f72
+Author: Joël R. Langlois <joel.r.langlois at gmail.com>
+Date: Mon Feb 25 15:26:58 2019 -0500
+
+ Remove Forcing Diagnostic Colours from CMakeLists.txt (#1597)
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1596
+
+ CMakeLists.txt | 12 ------------
+ 1 file changed, 12 deletions(-)
+
+commit 93739242e1aab9b745d0ba3c22c33b4acaf9526c
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Wed Feb 20 13:23:12 2019 -0800
+
+ minor edit
+
+ src/hb-map.hh | 3 +--
+ 1 file changed, 1 insertion(+), 2 deletions(-)
+
+commit eebc21c8de08d58c806fcd3d0f3a5aedee867776
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Wed Feb 20 12:43:18 2019 -0800
+
+ fix crash in hb_map_t::clear()
+
+ in case called immediately after init()
+
+ src/hb-map.hh | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+commit a17ed8459ee1e01caf4761f682bcda821bc8e656
+Author: Khaled Hosny <khaledhosny at eglug.org>
+Date: Tue Feb 19 21:14:11 2019 +0200
+
+ [doc] Move hb_variation_t to hb-common section
+
+ docs/harfbuzz-sections.txt | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+commit 9caabc9cf898e1d66921f88890d5b7d46494dc90
+Author: Khaled Hosny <khaledhosny at eglug.org>
+Date: Tue Feb 19 19:27:28 2019 +0200
+
+ [doc] Move feature_t and its function to hb-common
+
+ It is rather confusing to have script, language etc, in hb-common section
+ while feature is in hb-shape section. I keep looking for it in hb-common
+ section then using the API index because I can’t find it there.
+
+ docs/harfbuzz-sections.txt | 10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+commit d29c8424c8bfa47c910d0e270f05b5c0a1f803a2
+Author: Evgeniy Reizner <razrfalcon at gmail.com>
+Date: Tue Feb 19 18:35:00 2019 +0200
+
+ Typo (#1588)
+
+ Fixed a small typo.
+ [skip ci]
+
+ src/hb-ot-font.cc | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 6bd4c082e49143d0631881645b81f999347257f8
+Author: Khaled Hosny <khaledhosny at eglug.org>
+Date: Tue Feb 19 02:23:58 2019 +0200
+
+ [doc] Document hb_feature_from_string() syntax
+
+ Copied and edited from the util option documentation. The docbook table
+ syntax is too verbose, but that is the best I can come up with.
+
+ src/hb-common.cc | 35 ++++++++++++++++++++++++++++++++++-
+ 1 file changed, 34 insertions(+), 1 deletion(-)
+
+commit 3da79dd5b92b89fbf062cbe591e6b1ba83083aec
+Merge: 50005501 d8a68728
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Fri Feb 15 15:54:51 2019 -0800
+
+ Merge pull request #1557 from harfbuzz/cff-more-arrayof-fixes
+
+ CFF more arrayof fixes
+
+commit 5000550183022db8c9cfef63a9ed90eb9f37764d
+Merge: 5c2bb1de 90c8bbf9
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Fri Feb 15 15:54:13 2019 -0800
+
+ Merge pull request #1583 from harfbuzz/cff-retain-gids
+
+ [subset] Implement --retain-gids with CFF/CFF2
+
+commit d8a68728a077a8c5fc8ceae19f2866cdc8b70baf
+Merge: 1cb1d5d7 5c2bb1de
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 15 14:48:10 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit 90c8bbf98747eb29687471da892b4a34a9236242
+Merge: 6f1dfd08 5c2bb1de
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 15 14:47:38 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit 5c2bb1de8de31fecf0dae2ef905b896e42d39f1d
+Author: Martin <44297768+TheRealMDoerr at users.noreply.github.com>
+Date: Fri Feb 15 19:23:46 2019 +0100
+
+ Support xlclang++ on AIX. (#1584)
+
+ src/hb-atomic.hh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 28f77361322886360743fdbffd388c9482cf4257
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Thu Feb 14 11:34:28 2019 -0800
+
+ [CI] Install more packages
+
+ Wish there was a way to streamline this :(.
+
+ .circleci/config.yml | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+commit 1cb1d5d7fb74e9f42dc8361dcdf669ed479d595d
+Merge: 8a568a88 d5287e1b
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Feb 14 10:09:19 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit 6f1dfd082cf79488ae6773e7d99172f13575668c
+Merge: b1dbc77f d5287e1b
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Feb 14 10:08:16 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit d5287e1ba40638be5d48178ce3d64557b622b01f
+Author: Behdad Esfahbod <behdad at fb.com>
+Date: Wed Feb 13 23:46:17 2019 -0800
+
+ [CI] Install wget on clang-O3-O0 bot
+
+ .circleci/config.yml | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 890d0ee77fecd6aa4f19b663bb2897735a0d4c0b
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Thu Feb 14 00:27:01 2019 +0330
+
+ Minor, use a meaningful naming in template parameter (#1582)
+
+ src/hb-ot-layout.hh | 6 +++---
+ 1 file changed, 3 insertions(+), 3 deletions(-)
+
+commit 8a568a8858b44a81ca43a82761a70bf8d53e7c26
+Merge: c83412e4 1e1d0e63
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Wed Feb 13 11:25:00 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit b1dbc77fa62a99047df539663cfd1e8778d2c907
+Merge: c3a3536c 1e1d0e63
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Wed Feb 13 11:24:38 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit 1e1d0e63df405730ed542ae1d729928623addf08
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Wed Feb 13 12:58:01 2019 +0330
+
+ Fix djgpp complains by tweaking templates (#1579)
+
+ For some reasons djgpp doesn't understand "unsigned int" can be same
+ with one of uint*_t anyway so lets do that for it explicitly.
+
+ Just to note, our CI's djgpp is based GCC 7.2.0 and isn't old.
+
+ src/hb-ot-layout.hh | 4 ++--
+ src/hb-ot-shape-complex-arabic.cc | 6 +++---
+ 2 files changed, 5 insertions(+), 5 deletions(-)
+
+commit c3a3536c9a00a989ebd83d52e67d06525ed669bc
+Merge: bc33c617 85a6d312
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Tue Feb 12 15:10:59 2019 -0800
+
+ Merge branch 'cff-retain-gids' of https://github.com/harfbuzz/harfbuzz into cff-retain-gids
+
+commit bc33c617b85988f4d81312e62a75f92601852c76
+Merge: c6af8461 fdfa3d29
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Tue Feb 12 15:10:50 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit c6af846178bba10af318bcea1e9ac5165ec2aea6
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Tue Feb 12 15:10:43 2019 -0800
+
+ tweaked --desubroutinize to remove hintmask only subrs
+
+ src/hb-subset-cff-common.hh | 26 ++++++++++++++++++++++++--
+ 1 file changed, 24 insertions(+), 2 deletions(-)
+
+commit 85a6d3121a26c9bcbec60d37b64643ff8dc97a0a
+Merge: d9ded069 fdfa3d29
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Mon Feb 11 14:25:21 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit c83412e4cec10f6f6f6ac38f202b3ce373da5daf
+Merge: 1239b6b2 fdfa3d29
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Mon Feb 11 14:16:25 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit fdfa3d29b7c347b5038f4f9148428c80dde462ae
+Author: Ken <21211439+kencu at users.noreply.github.com>
+Date: Sun Feb 10 23:46:05 2019 -0800
+
+ hb-coretext.cc: remove TARGET_OS_MAC from test (#1578)
+
+ it is always true when building on APPLE systems
+ and this file only builds on APPLE systems
+
+ src/hb-coretext.cc | 10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+commit f55e7bf5835c59e478d6a448327d53027c4e9f4a
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Sun Feb 10 01:08:05 2019 +0330
+
+ [ci] Install 'base-devel' on ArchLinux CI bot
+
+ .circleci/config.yml | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 8f4eb919bd0498e997852aa39656adc4c65b3f0e
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Sat Feb 9 16:58:02 2019 +0330
+
+ [ci] Install 'which' in ArchLinux bot
+
+ .circleci/config.yml | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 02294349618037f59b32834b49880ca75ed96261
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Sat Feb 9 16:33:28 2019 +0330
+
+ [ci] Speculative fix for Alpine and ArchLinux bots
+
+ .circleci/config.yml | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+commit d9ded069926bf46a5d8e5edbf5201c98044db78e
+Merge: a5e933eb 84694af7
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 8 14:44:20 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit a5e933eba08ff50ac3beb1055ae952ccc26d0af7
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 8 14:44:13 2019 -0800
+
+ Updated expected/cff-japanese fonts with retained FDs
+
+ ...gular.default.3042,3044,3046,3048,304A,304B.otf | Bin 6324 -> 6356 bytes
+ ...gular.default.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6568 -> 6564 bytes
+ .../SourceHanSans-Regular.default.61,63,65,6B.otf | Bin 5500 -> 5532 bytes
+ ...gular.default.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6780 -> 6780 bytes
+ .../SourceHanSans-Regular.default.660E.otf | Bin 5248 -> 5248 bytes
+ ...e-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 536352 -> 537992 bytes
+ ...e-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 690752 -> 692312 bytes
+ ...ular.desubroutinize-retain-gids.61,63,65,6B.otf | Bin 530004 -> 531624 bytes
+ ...e-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 690868 -> 692496 bytes
+ ...ans-Regular.desubroutinize-retain-gids.660E.otf | Bin 612212 -> 613836 bytes
+ ...esubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin 6248 -> 6272 bytes
+ ...esubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6432 -> 6456 bytes
+ ...eHanSans-Regular.desubroutinize.61,63,65,6B.otf | Bin 5428 -> 5460 bytes
+ ...esubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6552 -> 6572 bytes
+ .../SourceHanSans-Regular.desubroutinize.660E.otf | Bin 5196 -> 5224 bytes
+ ...e-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 536176 -> 537424 bytes
+ ...e-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 690500 -> 691692 bytes
+ ...ints-desubroutinize-retain-gids.61,63,65,6B.otf | Bin 529888 -> 531124 bytes
+ ...e-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 690564 -> 691808 bytes
+ ....drop-hints-desubroutinize-retain-gids.660E.otf | Bin 612108 -> 613348 bytes
+ ...s-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 536244 -> 537492 bytes
+ ...s-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 690596 -> 691788 bytes
+ ...-Regular.drop-hints-retain-gids.61,63,65,6B.otf | Bin 529928 -> 531164 bytes
+ ...-Regular.drop-hints-retain-gids.61,63,65,6B.ttx | 393879 ++++++++++++++++++
+ ...s-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 690768 -> 692008 bytes
+ ...HanSans-Regular.drop-hints-retain-gids.660E.otf | Bin 612128 -> 613368 bytes
+ ...ar.drop-hints.3042,3044,3046,3048,304A,304B.otf | Bin 6132 -> 6164 bytes
+ ...ar.drop-hints.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6304 -> 6300 bytes
+ ...ourceHanSans-Regular.drop-hints.61,63,65,6B.otf | Bin 5344 -> 5376 bytes
+ ...ar.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6472 -> 6472 bytes
+ .../SourceHanSans-Regular.drop-hints.660E.otf | Bin 5140 -> 5140 bytes
+ ...r.retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 536436 -> 538076 bytes
+ ...r.retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 690860 -> 692420 bytes
+ ...urceHanSans-Regular.retain-gids.61,63,65,6B.otf | Bin 530084 -> 531704 bytes
+ ...r.retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 691076 -> 692700 bytes
+ .../SourceHanSans-Regular.retain-gids.660E.otf | Bin 612236 -> 613860 bytes
+ 36 files changed, 393879 insertions(+)
+
+commit 84694af723bde07cf3231ed2d2e193123f5f73ed
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Fri Feb 8 15:30:17 2019 +0330
+
+ [ci] Disable the just added bot
+
+ Doesn't play well with CircleCI apparently
+
+ https://circleci.com/gh/harfbuzz/harfbuzz/74289
+
+ .circleci/config.yml | 19 ++++++++++---------
+ 1 file changed, 10 insertions(+), 9 deletions(-)
+
+commit 81ae4974e35aa8ca408abd6238eb768f5c948287
+Author: Ebrahim Byagowi <ebrahim at gnu.org>
+Date: Fri Feb 8 15:18:26 2019 +0330
+
+ [ci] Add a Void Linux bot
+
+ https://voidlinux.org/ is yet another and different distro written from scratch, thus completely eligible to have a bot here!
+
+ Seriously however not that useful yet however but I will try to overload it other tasks later, like our other bots.
+
+ No test yet also, couldn't install cairo-devel, will try to fix that later.
+
+ Their harfbuzz package source: https://github.com/void-linux/void-packages/blob/master/srcpkgs/harfbuzz/template
+
+ .circleci/config.yml | 11 ++++++++++-
+ 1 file changed, 10 insertions(+), 1 deletion(-)
+
+commit e2856c2d85eb0f6ce0c780d1889dc9bb05cdc433
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Feb 7 15:32:32 2019 -0800
+
+ retain FDSelect & FDArray with --retain-gids
+
+ so in sync with fonttools behavior
+
+ src/hb-subset-cff-common.cc | 12 ++++--------
+ .../SourceHanSans-Regular.41,4C2E.retaingids.otf | Bin 2604 -> 2736 bytes
+ 2 files changed, 4 insertions(+), 8 deletions(-)
+
+commit 1239b6b2b4430658aea78216a1dcc885724a7ab4
+Merge: 9f80eb01 126abca9
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Feb 7 10:29:40 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit a5fa76977b5bdf3bd40ede3cdd0da9c5546557a6
+Merge: 214d0b02 126abca9
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Feb 7 10:28:13 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit 214d0b024b49edd51974ff2c051535ae06de0709
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Feb 7 10:27:43 2019 -0800
+
+ minor change
+
+ src/hb-subset-cff-common.cc | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+commit 126abca98a954f7ec3374d0593fee25f78dc10f3
+Merge: 1e062821 7859decd
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Wed Feb 6 13:36:52 2019 -0800
+
+ Merge pull request #1571 from kencu/cleanostests
+
+ hb-coretext.cc: clean up macosx test
+
+commit 7859decdd02f65dfb3da07bd95742b14b4697638
+Author: Ken Cunningham <kencu at macports.org>
+Date: Tue Feb 5 20:26:49 2019 -0800
+
+ hb-coretext.cc: clean up macosx test
+
+ TARGET_OS_OSX was introduced only in late OS versions
+ so always returns as "0" on older systems.
+
+ if !TARGET_OS_IPHONE can work, as it returns as !0 on older
+ systems where TARGET_OS_IPHONE is not defined, but is not
+ specific
+
+ if TARGET_OS_MAC && !(defined(TARGET_OS_IPHONE) && TARGET_OS_IPHONE)
+ is both specific and accurate on all systems.
+
+ src/hb-coretext.cc | 10 +++++-----
+ 1 file changed, 5 insertions(+), 5 deletions(-)
+
+commit 9328354a83252a8d8d74fe424ab3894d398b0bd0
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Mon Feb 4 11:28:15 2019 -0800
+
+ separate CFF from TrueType in full font tests
+
+ ...eSansPro-Regular.default.1FC,21,41,20,62,63.otf | Bin
+ .../SourceSansPro-Regular.default.61,62,63.otf | Bin
+ ...ourceSansPro-Regular.default.D7,D8,D9,DA,DE.otf | Bin
+ ...subroutinize-retain-gids.1FC,21,41,20,62,63.otf | Bin
+ ...Regular.desubroutinize-retain-gids.61,62,63.otf | Bin
+ ...r.desubroutinize-retain-gids.D7,D8,D9,DA,DE.otf | Bin
+ ...o-Regular.desubroutinize.1FC,21,41,20,62,63.otf | Bin
+ ...urceSansPro-Regular.desubroutinize.61,62,63.otf | Bin
+ ...nsPro-Regular.desubroutinize.D7,D8,D9,DA,DE.otf | Bin
+ ...subroutinize-retain-gids.1FC,21,41,20,62,63.otf | Bin
+ ...p-hints-desubroutinize-retain-gids.61,62,63.otf | Bin
+ ...s-desubroutinize-retain-gids.D7,D8,D9,DA,DE.otf | Bin
+ ...rop-hints-desubroutinize.1FC,21,41,20,62,63.otf | Bin
+ ...-Regular.drop-hints-desubroutinize.61,62,63.otf | Bin
+ ...ar.drop-hints-desubroutinize.D7,D8,D9,DA,DE.otf | Bin
+ ...r.drop-hints-retain-gids.1FC,21,41,20,62,63.otf | Bin
+ ...Pro-Regular.drop-hints-retain-gids.61,62,63.otf | Bin
+ ...gular.drop-hints-retain-gids.D7,D8,D9,DA,DE.otf | Bin
+ ...nsPro-Regular.drop-hints.1FC,21,41,20,62,63.otf | Bin
+ .../SourceSansPro-Regular.drop-hints.61,62,63.otf | Bin
+ ...ceSansPro-Regular.drop-hints.D7,D8,D9,DA,DE.otf | Bin
+ ...sPro-Regular.retain-gids.1FC,21,41,20,62,63.otf | Bin
+ .../SourceSansPro-Regular.retain-gids.61,62,63.otf | Bin
+ ...eSansPro-Regular.retain-gids.D7,D8,D9,DA,DE.otf | Bin
+ ...gular.default.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...gular.default.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ .../SourceHanSans-Regular.default.61,63,65,6B.otf | Bin
+ ...gular.default.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ .../SourceHanSans-Regular.default.660E.otf | Bin
+ ...e-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...e-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...ular.desubroutinize-retain-gids.61,63,65,6B.otf | Bin
+ ...e-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ ...ans-Regular.desubroutinize-retain-gids.660E.otf | Bin
+ ...esubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...esubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...eHanSans-Regular.desubroutinize.61,63,65,6B.otf | Bin
+ ...esubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ .../SourceHanSans-Regular.desubroutinize.660E.otf | Bin
+ ...e-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...e-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...ints-desubroutinize-retain-gids.61,63,65,6B.otf | Bin
+ ...e-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ ....drop-hints-desubroutinize-retain-gids.660E.otf | Bin
+ ...esubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...esubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...gular.drop-hints-desubroutinize.61,63,65,6B.otf | Bin
+ ...esubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ ...Sans-Regular.drop-hints-desubroutinize.660E.otf | Bin
+ ...s-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...s-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...-Regular.drop-hints-retain-gids.61,63,65,6B.otf | Bin
+ ...s-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ ...HanSans-Regular.drop-hints-retain-gids.660E.otf | Bin
+ ...ar.drop-hints.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...ar.drop-hints.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...ourceHanSans-Regular.drop-hints.61,63,65,6B.otf | Bin
+ ...ar.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ .../SourceHanSans-Regular.drop-hints.660E.otf | Bin
+ ...r.retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin
+ ...r.retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin
+ ...urceHanSans-Regular.retain-gids.61,63,65,6B.otf | Bin
+ ...r.retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin
+ .../SourceHanSans-Regular.retain-gids.660E.otf | Bin
+ test/subset/data/tests/cff-full-font.tests | 18 +++++++++++++++++
+ test/subset/data/tests/cff-japanese.tests | 22 +++++++++++++++++++++
+ test/subset/data/tests/full-font.tests | 7 -------
+ test/subset/data/tests/japanese.tests | 7 -------
+ test/subset/subset_test_suite.py | 7 +------
+ 69 files changed, 41 insertions(+), 20 deletions(-)
+
+commit ec30a8a9acf7be9918a8a6bff41696127090173f
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 1 15:58:03 2019 -0800
+
+ removed unused test data
+
+ ...ts.desubroutinize-retain-gids.1FC,21,41,20,62,63.otf | Bin 15456 -> 0 bytes
+ ...r.drop-hints.desubroutinize-retain-gids.61,62,63.otf | Bin 13036 -> 0 bytes
+ ...-hints.desubroutinize-retain-gids.D7,D8,D9,DA,DE.otf | Bin 16656 -> 0 bytes
+ ...nsPro-Regular.drop-hints.desubroutinize.61,62,63.otf | Bin 3276 -> 0 bytes
+ ...-hints.desubroutinize.retain-gids.D7,D8,D9,DA,DE.otf | Bin 34560 -> 0 bytes
+ ...ro-Regular.drop-hints.retain-gids.D7,D8,D9,DA,DE.otf | Bin 34576 -> 0 bytes
+ 6 files changed, 0 insertions(+), 0 deletions(-)
+
+commit 30b781f20a8e386732f8e2858a22665d7af98061
+Merge: c1286265 1e062821
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 1 14:50:34 2019 -0800
+
+ Merge branch 'master' into cff-retain-gids
+
+commit c12862657f24b6c197e23d99a4edbdfcf3c90653
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Fri Feb 1 14:50:01 2019 -0800
+
+ added desubroutinize & retain-gids full test cases with CFF fonts
+
+ and CFF retain-gids fixes
+
+ src/hb-subset-cff1.cc | 44 +++++++++------------
+ .../SourceHanSans-Regular.41,4C2E.retaingids.otf | Bin 2600 -> 2604 bytes
+ ...subroutinize-retain-gids.1FC,21,41,20,62,63.otf | Bin 0 -> 33516 bytes
+ ...Regular.desubroutinize-retain-gids.61,62,63.otf | Bin 0 -> 31080 bytes
+ ...r.desubroutinize-retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 34708 bytes
+ ...subroutinize-retain-gids.1FC,21,41,20,62,63.otf | Bin 0 -> 33352 bytes
+ ...p-hints-desubroutinize-retain-gids.61,62,63.otf | Bin 0 -> 30956 bytes
+ ...s-desubroutinize-retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 34560 bytes
+ ...op-hints-desubroutinize.1FC,21,41,20,62,63.otf} | Bin
+ ...-Regular.drop-hints-desubroutinize.61,62,63.otf | Bin 0 -> 3288 bytes
+ ...r.drop-hints-desubroutinize.D7,D8,D9,DA,DE.otf} | Bin
+ ...r.drop-hints-retain-gids.1FC,21,41,20,62,63.otf | Bin 0 -> 33448 bytes
+ ...Pro-Regular.drop-hints-retain-gids.61,62,63.otf | Bin 0 -> 31028 bytes
+ ...gular.drop-hints-retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 34576 bytes
+ ...subroutinize-retain-gids.1FC,21,41,20,62,63.otf | Bin 0 -> 15456 bytes
+ ...p-hints.desubroutinize-retain-gids.61,62,63.otf | Bin 0 -> 13036 bytes
+ ...s.desubroutinize-retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 16656 bytes
+ ...s.desubroutinize.retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 34560 bytes
+ ...gular.drop-hints.retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 34576 bytes
+ ...sPro-Regular.retain-gids.1FC,21,41,20,62,63.otf | Bin 0 -> 33668 bytes
+ .../SourceSansPro-Regular.retain-gids.61,62,63.otf | Bin 0 -> 31180 bytes
+ ...eSansPro-Regular.retain-gids.D7,D8,D9,DA,DE.otf | Bin 0 -> 34724 bytes
+ ...e-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 536352 bytes
+ ...e-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 690752 bytes
+ ...ular.desubroutinize-retain-gids.61,63,65,6B.otf | Bin 0 -> 530004 bytes
+ ...e-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 690868 bytes
+ ...ans-Regular.desubroutinize-retain-gids.660E.otf | Bin 0 -> 612212 bytes
+ .../SourceHanSans-Regular.desubroutinize..otf | Bin 2340 -> 0 bytes
+ ...e-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 536176 bytes
+ ...e-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 690500 bytes
+ ...ints-desubroutinize-retain-gids.61,63,65,6B.otf | Bin 0 -> 529888 bytes
+ ...e-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 690564 bytes
+ ....drop-hints-desubroutinize-retain-gids.660E.otf | Bin 0 -> 612108 bytes
+ ...subroutinize.3042,3044,3046,3048,304A,304B.otf} | Bin 6076 -> 6096 bytes
+ ...subroutinize.3042,3044,3046,73E0,5EA6,8F38.otf} | Bin 6180 -> 6204 bytes
+ ...ular.drop-hints-desubroutinize.61,63,65,6B.otf} | Bin 5312 -> 5344 bytes
+ ...subroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf} | Bin 6248 -> 6268 bytes
+ ...ans-Regular.drop-hints-desubroutinize.660E.otf} | Bin 5140 -> 5120 bytes
+ ...s-retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 536244 bytes
+ ...s-retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 690596 bytes
+ ...-Regular.drop-hints-retain-gids.61,63,65,6B.otf | Bin 0 -> 529928 bytes
+ ...s-retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 690768 bytes
+ ...HanSans-Regular.drop-hints-retain-gids.660E.otf | Bin 0 -> 612128 bytes
+ ...eHanSans-Regular.drop-hints.desubroutinize..otf | Bin 2188 -> 0 bytes
+ ...r.retain-gids.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 536436 bytes
+ ...r.retain-gids.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 690860 bytes
+ ...urceHanSans-Regular.retain-gids.61,63,65,6B.otf | Bin 0 -> 530084 bytes
+ ...r.retain-gids.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 691076 bytes
+ .../SourceHanSans-Regular.retain-gids.660E.otf | Bin 0 -> 612236 bytes
+ .../data/profiles/desubroutinize-retain-gids.txt | 2 +
+ .../drop-hints-desubroutinize-retain-gids.txt | 3 ++
+ test/subset/data/tests/full-font.tests | 6 +++
+ test/subset/data/tests/japanese.tests | 6 +++
+ test/subset/subset_test_suite.py | 2 +-
+ 54 files changed, 36 insertions(+), 27 deletions(-)
+
+commit f2908b4d8f9b02ce06d3f648c3f08757797073b6
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Jan 31 14:16:37 2019 -0800
+
+ Implement subset --regain-gids option with CFF1/2
+
+ along with api tests & expected results
+
+ src/hb-subset-cff-common.cc | 17 +++-
+ src/hb-subset-cff-common.hh | 91 +++++++++++++--------
+ src/hb-subset-cff1.cc | 89 ++++++++++++--------
+ src/hb-subset-cff2.cc | 30 ++++---
+ test/api/fonts/AdobeVFPrototype.ac.retaingids.otf | Bin 0 -> 7000 bytes
+ .../SourceHanSans-Regular.41,4C2E.retaingids.otf | Bin 0 -> 2600 bytes
+ .../fonts/SourceSansPro-Regular.ac.retaingids.otf | Bin 0 -> 1708 bytes
+ test/api/test-subset-cff1.c | 48 +++++++++++
+ test/api/test-subset-cff2.c | 24 ++++++
+ 9 files changed, 217 insertions(+), 82 deletions(-)
+
+commit 1e06282105a2d579aab32094cc7abc10ed231978
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Jan 31 13:56:58 2019 -0800
+
+ Adjust hb_is_signed<>
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1535
+
+ src/hb-dsalgs.hh | 27 +++++++++------------------
+ 1 file changed, 9 insertions(+), 18 deletions(-)
+
+commit 21ea1c91529471c05e03b6db61df256f24fa23c1
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Thu Jan 31 13:49:18 2019 -0800
+
+ Remove stale comment
+
+ src/hb-dsalgs.hh | 5 -----
+ 1 file changed, 5 deletions(-)
+
+commit 9f80eb0177e527253818ad9171fc75fb565318cb
+Merge: b3799007 d14d2c20
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Jan 31 12:54:36 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit d14d2c20b05c5acf0a6f9c6dc36a7b8d8966153e
+Merge: acf5f0a3 dc04261a
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Wed Jan 30 18:36:57 2019 -0500
+
+ Merge pull request #1567 from googlefonts/fuzzer
+
+ [subset] Update the subset fuzzer to get options to use from test case.
+
+commit dc04261a5b8408bcfde16090ddf91568c3d8dae7
+Author: Garret Rieger <grieger at google.com>
+Date: Wed Jan 30 15:23:19 2019 -0800
+
+ [subset] Update the subset fuzzer to determine which options to use based on data in the fuzzing test case.
+ Add support for toggling retain_gids.
+
+ test/fuzzing/hb-subset-fuzzer.cc | 32 +++++++++++++++++++-------------
+ 1 file changed, 19 insertions(+), 13 deletions(-)
+
+commit acf5f0a3aff0e128509b0979f629edf0596fcee5
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Wed Jan 30 15:10:23 2019 -0800
+
+ [configure] Fix up
+
+ configure.ac | 11 +++++------
+ 1 file changed, 5 insertions(+), 6 deletions(-)
+
+commit 6b834c1c76b867ef32747202a755255d2f360f1e
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Wed Jan 30 15:06:22 2019 -0800
+
+ [configure] Print compiler version info in report
+
+ configure.ac | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+commit d983c529b66b530715e9c813c69e699b1d8029d3
+Merge: 55d1d7c8 e6ffcc59
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Wed Jan 30 17:17:59 2019 -0500
+
+ Merge pull request #1564 from googlefonts/retain_gids
+
+ [subset] Add --retain-gids option to the subsetter.
+
+commit 55d1d7c8bcd8d97c4e618e5dd21f13df50b10ce8
+Author: Behdad Esfahbod <behdad at behdad.org>
+Date: Wed Jan 30 13:54:15 2019 -0800
+
+ 2.3.1
+
+ NEWS | 7 +++++++
+ configure.ac | 2 +-
+ src/hb-version.h | 4 ++--
+ 3 files changed, 10 insertions(+), 3 deletions(-)
+
+commit e6ffcc5904ab88143cad0c7a7a4c990147af278b
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 18:12:19 2019 -0800
+
+ [subset] Add expected files for retain-gids integration tests.
+
+ ...oboto-Regular.abc.drop-hints-retain-gids.61,62,63.ttf | Bin 0 -> 924 bytes
+ .../Roboto-Regular.abc.drop-hints-retain-gids.61,63.ttf | Bin 0 -> 856 bytes
+ .../Roboto-Regular.abc.drop-hints-retain-gids.61.ttf | Bin 0 -> 744 bytes
+ .../Roboto-Regular.abc.drop-hints-retain-gids.62.ttf | Bin 0 -> 712 bytes
+ .../Roboto-Regular.abc.drop-hints-retain-gids.63.ttf | Bin 0 -> 716 bytes
+ .../basics/Roboto-Regular.abc.retain-gids.61,62,63.ttf | Bin 0 -> 2168 bytes
+ .../basics/Roboto-Regular.abc.retain-gids.61,63.ttf | Bin 0 -> 1996 bytes
+ .../basics/Roboto-Regular.abc.retain-gids.61.ttf | Bin 0 -> 1808 bytes
+ .../basics/Roboto-Regular.abc.retain-gids.62.ttf | Bin 0 -> 1756 bytes
+ .../basics/Roboto-Regular.abc.retain-gids.63.ttf | Bin 0 -> 1732 bytes
+ test/subset/data/profiles/retain-gids.txt | 1 -
+ 11 files changed, 1 deletion(-)
+
+commit 198859bb3702e45cb271dd51b7231f10d01576be
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 18:10:56 2019 -0800
+
+ [subset] For retain gids don't truncate glyphs past the highest requested subset glyph.
+
+ src/hb-subset-plan.cc | 8 +++++---
+ 1 file changed, 5 insertions(+), 3 deletions(-)
+
+commit 490d52f908aaa4722e71a4a682de20e94d89ad00
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 17:43:42 2019 -0800
+
+ [subset] Add retain-gids option to hb-subset executable.
+
+ util/hb-subset.cc | 1 +
+ util/options.cc | 1 +
+ util/options.hh | 2 ++
+ 3 files changed, 4 insertions(+)
+
+commit a903f9c228d1f3e8065f89de16e50027d6018e58
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 17:43:11 2019 -0800
+
+ [subset] Add some subsetting integration tests covering retain gids.
+
+ test/subset/data/profiles/drop-hints-retain-gids.txt | 2 ++
+ test/subset/data/profiles/retain-gids.txt | 2 ++
+ test/subset/data/tests/basics.tests | 2 ++
+ 3 files changed, 6 insertions(+)
+
+commit 05e99c86baa0e95c2bff1c87d601eaf022c9d1f8
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 17:05:04 2019 -0800
+
+ [subset] A few small fixes for the new subset plan api.
+
+ src/hb-ot-hdmx-table.hh | 6 +++---
+ src/hb-ot-hmtx-table.hh | 9 +++------
+ src/hb-subset.cc | 2 +-
+ 3 files changed, 7 insertions(+), 10 deletions(-)
+
+commit bdbe047d6ce3d8873c6740500d38d1b0c4e851f8
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 16:59:15 2019 -0800
+
+ [subset] Update hb-subset-plan.cc to match hb-subset-plan.hh.
+
+ src/hb-subset-plan.cc | 20 ++++++++++----------
+ src/hb-subset-plan.hh | 1 -
+ 2 files changed, 10 insertions(+), 11 deletions(-)
+
+commit 74c44ffebafe7758937d82524758be8bb4ecc4e2
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 16:53:01 2019 -0800
+
+ [subset] Update hb-subset-glyf.cc to use new hb-subset-plan API.
+
+ src/hb-subset-glyf.cc | 57 ++++++++++++++++++++-------------------------------
+ 1 file changed, 22 insertions(+), 35 deletions(-)
+
+commit 4842294b861b9fe322c811abef0ebb0553be2bf0
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 16:51:27 2019 -0800
+
+ [subset] Update gsub to use glyphset() method of subset plan.
+
+ src/hb-ot-layout-gsub-table.hh | 4 ++--
+ 1 file changed, 2 insertions(+), 2 deletions(-)
+
+commit 853b1f1aa5489b8439c41c30be77ed042c8c89e5
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 16:50:56 2019 -0800
+
+ [subset] Correct maxp num glyph's to use new subset plan method.
+
+ src/hb-ot-maxp-table.hh | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+commit 846e05a298bc088f2cd2fe53b75ca531916a56f8
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 16:50:20 2019 -0800
+
+ [subset] Re-add glyphs array to subset plan, with new name 'glyphs_deprecated'. Switch CFF subsetting to use it.
+
+ src/hb-subset-cff1.cc | 36 ++++++++++++++++++------------------
+ src/hb-subset-cff2.cc | 12 ++++++------
+ src/hb-subset-plan.hh | 3 +++
+ 3 files changed, 27 insertions(+), 24 deletions(-)
+
+commit 03e88eab5c0f8775ccffc0925532748140d93470
+Author: Garret Rieger <grieger at google.com>
+Date: Mon Jan 28 16:15:06 2019 -0800
+
+ Re-implement HMTX/VMTX subsetting. Update it to support glyph renumbering and simplify the implementation.
+
+ src/hb-ot-hmtx-table.hh | 99 +++++++++++++++++++++++++------------------------
+ src/hb-subset-plan.cc | 2 +-
+ src/hb-subset-plan.hh | 2 +-
+ 3 files changed, 53 insertions(+), 50 deletions(-)
+
+commit 925be2922348336335a96d84e606d4bdd9a11110
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 25 18:04:41 2019 -0800
+
+ Update hb-ot-vorg-table and hb-ot-layout-common to use the updated subset plan api.
+
+ src/hb-ot-layout-common.hh | 4 ++--
+ src/hb-ot-vorg-table.hh | 30 +++++++++++++++++++-----------
+ 2 files changed, 21 insertions(+), 13 deletions(-)
+
+commit 4af3be6ef8654ae05b331941e6e690ac197fd144
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 25 18:03:47 2019 -0800
+
+ Remove glyph array from subset plan, make num_glyphs and glyphset private.
+
+ src/hb-subset-plan.hh | 51 +++++++++++++++++++++++++++++++++++++++++----------
+ 1 file changed, 41 insertions(+), 10 deletions(-)
+
+commit 23f364429dc9350ee06146bdf0ff73d7035e1d71
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 18 18:33:21 2019 -0800
+
+ [subset] Fix hdmx subsetting when retain gids is enabled.
+
+ src/hb-ot-hdmx-table.hh | 19 +++++++++++--------
+ src/hb-subset-plan.cc | 10 ++++++++++
+ src/hb-subset-plan.hh | 16 +++++++++++++++-
+ 3 files changed, 36 insertions(+), 9 deletions(-)
+
+commit 2da1654aefbe4f8e5f1320f1c061adbf90963951
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 18 17:49:35 2019 -0800
+
+ [subset] Compute num_glyphs during subset plan construction.
+ Update maxp to use the correct num glyphs.
+
+ src/hb-ot-maxp-table.hh | 2 +-
+ src/hb-subset-glyf.cc | 6 +-----
+ src/hb-subset-plan.cc | 16 +++++++++++++---
+ src/hb-subset-plan.hh | 1 +
+ 4 files changed, 16 insertions(+), 9 deletions(-)
+
+commit ccc59dc6121e98ed8d610350b43218e540f61f25
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 18 17:36:32 2019 -0800
+
+ [subset] Add unit test for glyf subsetting and retain gids.
+
+ test/api/fonts/Roboto-Regular.ac.retaingids.ttf | Bin 0 -> 2284 bytes
+ test/api/test-subset-glyf.c | 26 ++++++++++++++++++++++++
+ 2 files changed, 26 insertions(+)
+
+commit 96b038f375bcfcfdf76c75200ca02758ea7a4ff6
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 18 16:41:08 2019 -0800
+
+ [subset] fix failure to init instruction ranges values for an invalid glyph.
+
+ src/hb-subset-glyf.cc | 8 ++++----
+ 1 file changed, 4 insertions(+), 4 deletions(-)
+
+commit 4b1ac3a2fa0a5842b5d45d287fe33e5050ffda3f
+Author: Garret Rieger <grieger at google.com>
+Date: Fri Jan 18 15:11:26 2019 -0800
+
+ [subset] Do some refactoring in hb-subset-glyf.cc.
+ - Extract code out into helper methods in several places.
+ - Bundle loca address, size and is short into a struct.
+
+ src/hb-subset-glyf.cc | 264 ++++++++++++++++++++++++++++----------------------
+ 1 file changed, 148 insertions(+), 116 deletions(-)
+
+commit b7f971884ed838636be85de216bf60ca4a28ccb9
+Author: Garret Rieger <grieger at google.com>
+Date: Thu Jan 17 18:55:56 2019 -0800
+
+ Add retain_gids option to subset input. Update glyf and loca handling to respect retain_gids.
+
+ src/hb-subset-glyf.cc | 39 ++++++++++++++++++++++++++++++---------
+ src/hb-subset-input.cc | 27 +++++++++++++++++++++++++++
+ src/hb-subset-input.hh | 1 +
+ src/hb-subset-plan.cc | 14 ++++++++++----
+ src/hb-subset.h | 6 ++++++
+ 5 files changed, 74 insertions(+), 13 deletions(-)
+
+commit b3799007554f2909170df941b07c72f7dc02dfcd
+Merge: c6856443 fe532923
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Tue Jan 29 12:19:57 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
commit fe532923101586e316b300d419a337d357cd93da
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Mon Jan 28 20:47:58 2019 -0500
[CI] Peg CircleCI badge link to master branch
-
+
[skip ci]
README.md | 2 +-
@@ -14,7 +1366,7 @@
Date: Mon Jan 28 20:43:43 2019 -0500
[ci] Peg build status badges to master branch
-
+
[skip ci]
README.md | 6 +++---
@@ -25,7 +1377,7 @@
Date: Mon Jan 28 20:38:15 2019 -0500
Switch README / README.md
-
+
[skip ci]
README | 19 +------------------
@@ -55,11 +1407,9 @@
Date: Mon Jan 28 14:09:59 2019 -0500
Fix warning
+
+ c:\projects\harfbuzz\src\hb-ot-color-cbdt-table.hh(59): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
- c:\projects\harfbuzz\src\hb-ot-color-cbdt-table.hh(59): warning C4146:
- unary minus operator applied to unsigned type, result still unsigned
- [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
-
src/hb-ot-color-cbdt-table.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -110,6 +1460,13 @@
test/shaping/data/in-house/tests/macos.tests | 2 ++
1 file changed, 2 insertions(+)
+commit c685644386d1c88d6df6e024e56d61c792d94418
+Merge: 0bd0a331 e970de48
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Jan 24 13:19:18 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
commit e970de48bcbdccd29350f331288c0a98f7846c16
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Jan 24 18:16:17 2019 +0100
@@ -124,11 +1481,10 @@
Date: Thu Jan 24 18:12:25 2019 +0100
[AAT] Use a ring buffer for ligature stack
-
- I think Apple does very similarly, but probably with a stack size
- of 16.
+
+ I think Apple does very similarly, but probably with a stack size of 16.
We do it with a stack size that is currently set to 64.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1531
src/hb-aat-layout-morx-table.hh | 15 ++++++---------
@@ -148,10 +1504,9 @@
Date: Thu Jan 24 18:01:07 2019 +0100
[AAT] Handle transition errors during machine operation
-
- Before we used to give up. Now, just ignore error and continue
- processing.
-
+
+ Before we used to give up. Now, just ignore error and continue processing.
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1531
src/hb-aat-layout-common.hh | 3 +--
@@ -159,6 +1514,13 @@
src/hb-aat-layout-morx-table.hh | 34 +++++++++++++---------------------
3 files changed, 21 insertions(+), 37 deletions(-)
+commit 0bd0a3311cfded5ffa4d9d488d404558cf65e8ed
+Merge: 12cd3171 f60282c5
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Thu Jan 24 08:53:28 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
commit e234bb6a428cd6c8ddf57eb078cd51b9d1f25ba8
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Jan 24 17:23:11 2019 +0100
@@ -176,8 +1538,7 @@
src/hb-aat-layout-common.hh | 12 ++++----
src/hb-aat-layout-kerx-table.hh | 38 +++++++++++------------
- src/hb-aat-layout-morx-table.hh | 68
- ++++++++++++++++++++---------------------
+ src/hb-aat-layout-morx-table.hh | 68 ++++++++++++++++++++---------------------
3 files changed, 59 insertions(+), 59 deletions(-)
commit 299eca0c3b28c99add006420bc667431d874fb2e
@@ -212,7 +1573,7 @@
Date: Thu Jan 24 16:29:09 2019 +0100
More pragma control
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=924848
src/hb.hh | 16 +++++++++++++++-
@@ -242,13 +1603,11 @@
Date: Thu Jan 24 16:08:33 2019 +0100
Form cluster for Emoji sub-region tag sequences
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1556
- src/hb-ot-shape.cc | 13
- +++++++++++++
- .../fonts/8d9c4b193808b8bde94389ba7831c1fc6f9e794e.ttf | Bin 0 ->
- 1548 bytes
+ src/hb-ot-shape.cc | 13 +++++++++++++
+ .../fonts/8d9c4b193808b8bde94389ba7831c1fc6f9e794e.ttf | Bin 0 -> 1548 bytes
test/shaping/data/in-house/tests/cluster.tests | 1 +
3 files changed, 14 insertions(+)
@@ -266,13 +1625,12 @@
Date: Thu Jan 24 12:08:23 2019 +0100
Adjust mark offsets when zeroing from fallback mark positioning code
-
+
Adjust tests.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1532
- src/hb-ot-shape-fallback.cc | 31
- +++++++++++++++-------
+ src/hb-ot-shape-fallback.cc | 31 +++++++++++++++-------
src/hb-ot-shape-fallback.hh | 3 ++-
src/hb-ot-shape.cc | 3 ++-
.../in-house/tests/arabic-fallback-shaping.tests | 2 +-
@@ -280,12 +1638,30 @@
.../data/in-house/tests/fallback-positioning.tests | 4 +--
6 files changed, 30 insertions(+), 15 deletions(-)
+commit 12cd3171ba3b84eff9f359778fabcab8f66ce36e
+Merge: 261a7421 36fb2b4d
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Wed Jan 23 14:05:42 2019 -0800
+
+ Merge branch 'master' into cff-more-arrayof-fixes
+
+commit 261a7421814d83f84d8def046b7108a245347461
+Author: Michiharu Ariza <ariza at adobe.com>
+Date: Wed Jan 23 14:04:29 2019 -0800
+
+ more rewriting with ArrayOf<>
+
+ CFF1 Encoding0, Encoding1, CFF1SuppEncData
+
+ src/hb-ot-cff1-table.hh | 51 +++++++++++++++++++++++--------------------------
+ 1 file changed, 24 insertions(+), 27 deletions(-)
+
commit 36fb2b4da9718a86978fa07c99ba4345f7ca9b4b
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Jan 23 20:53:57 2019 +0100
[AAT] In InsertionChain, set mark to previous-position if inserting
-
+
Fixes MORX-31
src/hb-aat-layout-morx-table.hh | 8 +++++---
@@ -335,12 +1711,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue Jan 22 16:30:07 2019 +0100
- Fix sign-compare error resulted from promoting unsigned integers to
- signed larger ints
+ Fix sign-compare error resulted from promoting unsigned integers to signed larger ints
+
+ Clang and gcc know not to warn in these cases, but not nonmainstream compilers
- Clang and gcc know not to warn in these cases, but not nonmainstream
- compilers
-
src/hb-subset-cff2.cc | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
@@ -400,24 +1774,18 @@
Date: Tue Jan 22 12:34:05 2019 +0100
Fix cast-align error
-
+
If compiler doesn't inline StructAtOffset, this was an error since we
only disable cast-align at call-site. So, move the cast out.
-
- ../src/hb-machinery.hh: In instantiation of 'const Type&
- StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
+
+ ../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:146:85: required from here
- ../src/hb-machinery.hh:63:12: error: cast from 'const char*' to
- 'const unsigned int*' increases required alignment of target type
- [-Werror=cast-align]
- { return * reinterpret_cast<const Type*> ((const char *) P +
- offset); }
+ ../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
+ { return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- ../src/hb-machinery.hh: In instantiation of 'Type&
- StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
+ ../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:147:79: required from here
- ../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned
- int*' increases required alignment of target type [-Werror=cast-align]
+ ../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -432,7 +1800,7 @@
Date: Tue Jan 22 12:29:05 2019 +0100
[CI] Remove gcc 4.2 bots
-
+
We don't support that version anymore.
.circleci/config.yml | 25 -------------------------
@@ -443,7 +1811,7 @@
Date: Tue Jan 22 12:15:23 2019 +0100
Convert all other enum class consts to static constexpr
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1553
src/hb-cff-interp-common.hh | 2 +-
@@ -460,7 +1828,7 @@
Date: Tue Jan 22 12:11:24 2019 +0100
Convert unsigned enum class consts to static constexpr
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
src/hb-aat-layout-common.hh | 6 +++---
@@ -477,7 +1845,7 @@
Date: Tue Jan 22 12:08:57 2019 +0100
Convert tag enum class consts to static constexpr
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
src/hb-aat-fdsc-table.hh | 2 +-
@@ -528,7 +1896,7 @@
Date: Tue Jan 22 12:07:43 2019 +0100
Convert boolean enum class consts to static constexpr
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1553
src/hb-aat-layout-common.hh | 4 ++--
@@ -592,12 +1960,9 @@
Remove wrongly added files
- test/api/test-ot-extents-cff | Bin 8574336 ->
- 0 bytes
- .../test-ot-extents-cff.dSYM/Contents/Info.plist | 20
- --------------------
- .../Contents/Resources/DWARF/test-ot-extents-cff | Bin 7650053 ->
- 0 bytes
+ test/api/test-ot-extents-cff | Bin 8574336 -> 0 bytes
+ .../test-ot-extents-cff.dSYM/Contents/Info.plist | 20 --------------------
+ .../Contents/Resources/DWARF/test-ot-extents-cff | Bin 7650053 -> 0 bytes
3 files changed, 20 deletions(-)
commit 380c3cffb9353083913a3bb505c2c62367613096
@@ -670,12 +2035,8 @@
Date: Sat Jan 19 09:20:46 2019 -0500
Fix sign compare warnings
-
- ../../third_party/harfbuzz-ng/src/src/hb-map.hh(56,45): warning:
- comparison of integers of different signs: 'const hb_codepoint_t'
- (aka 'const unsigned int') and 'hb_map_t::(anonymous enum
- at ../../third_party/harfbuzz-ng/src/src/hb-map.hh:169:3)'
- [-Wsign-compare]
+
+ ../../third_party/harfbuzz-ng/src/src/hb-map.hh(56,45): warning: comparison of integers of different signs: 'const hb_codepoint_t' (aka 'const unsigned int') and 'hb_map_t::(anonymous enum at ../../third_party/harfbuzz-ng/src/src/hb-map.hh:169:3)' [-Wsign-compare]
bool is_unused () const { return key == INVALID; }
src/hb-map.hh | 2 +-
@@ -687,7 +2048,7 @@
Date: Sat Jan 19 09:18:03 2019 -0500
Fix warning
-
+
warning: '_WIN64' is not defined, evaluates to 0 [-Wundef]
src/hb-dsalgs.hh | 4 ++--
@@ -737,7 +2098,7 @@
Date: Fri Jan 18 21:55:21 2019 +0330
[dwrite] Try to fix delete-non-virtual-dtor warnings
-
+
Fixes #1548 hopefully
src/hb-directwrite.cc | 4 ++--
@@ -759,7 +2120,7 @@
Date: Fri Jan 18 12:48:01 2019 -0500
Fix -Wundef errors with __GNUC__
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1549
src/hb-common.h | 4 ++--
@@ -771,16 +2132,13 @@
Date: Fri Jan 18 09:43:51 2019 -0800
init interp_env_t::hintmask_size
-
+
fixes issue #1547
src/hb-cff-interp-cs-common.hh | 1 +
- test/api/test-ot-extents-cff | Bin 0 ->
- 8574336 bytes
- .../test-ot-extents-cff.dSYM/Contents/Info.plist | 20
- ++++++++++++++++++++
- .../Contents/Resources/DWARF/test-ot-extents-cff | Bin 0 ->
- 7650053 bytes
+ test/api/test-ot-extents-cff | Bin 0 -> 8574336 bytes
+ .../test-ot-extents-cff.dSYM/Contents/Info.plist | 20 ++++++++++++++++++++
+ .../Contents/Resources/DWARF/test-ot-extents-cff | Bin 0 -> 7650053 bytes
4 files changed, 21 insertions(+)
commit 9b4e51b2e44d7dea026b1f9201d2f83277bab1cf
@@ -788,7 +2146,7 @@
Date: Fri Jan 18 12:23:02 2019 -0500
[pragma] Enable error -Wdelete-non-virtual-dtor
-
+
Currently fails directwrite backend.
src/hb.hh | 1 +
@@ -799,24 +2157,18 @@
Date: Fri Jan 18 12:22:07 2019 -0500
[directwrite] Fix error
-
- hb-directwrite.cc: In constructor 'TextAnalysis::TextAnalysis(const
- wchar_t*, uint32_t, const wchar_t*, DWRITE_READING_DIRECTION)':
- hb-directwrite.cc:489:18: error: 'TextAnalysis::mText' will be
- initialized after [-Werror=reorder]
+
+ hb-directwrite.cc: In constructor 'TextAnalysis::TextAnalysis(const wchar_t*, uint32_t, const wchar_t*, DWRITE_READING_DIRECTION)':
+ hb-directwrite.cc:489:18: error: 'TextAnalysis::mText' will be initialized after [-Werror=reorder]
const wchar_t* mText;
^~~~~
- hb-directwrite.cc:488:12: error: 'uint32_t
- TextAnalysis::mTextLength' [-Werror=reorder]
+ hb-directwrite.cc:488:12: error: 'uint32_t TextAnalysis::mTextLength' [-Werror=reorder]
uint32_t mTextLength;
^~~~~~~~~~~
- hb-directwrite.cc:282:3: error: when initialized here
- [-Werror=reorder]
+ hb-directwrite.cc:282:3: error: when initialized here [-Werror=reorder]
TextAnalysis (const wchar_t* text, uint32_t textLength,
^~~~~~~~~~~~
- hb-directwrite.cc: In function 'hb_bool_t
- _hb_directwrite_shape_full(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*,
- const hb_feature_t*, unsigned int, float)':
+ hb-directwrite.cc: In function 'hb_bool_t _hb_directwrite_shape_full(hb_shape_plan_t*, hb_font_t*, hb_buffer_t*, const hb_feature_t*, unsigned int, float)':
src/hb-directwrite.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -838,25 +2190,18 @@
Date: Fri Jan 18 10:03:43 2019 -0500
[pragma] Allow cast-align in hb-font.cc
-
- ../src/hb-machinery.hh: In instantiation of 'const Type&
- StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
+
+ ../src/hb-machinery.hh: In instantiation of 'const Type& StructAtOffset(const void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:144:85: required from here
- ../src/hb-machinery.hh:63:12: error: cast from 'const char*' to
- 'const unsigned int*' increases required alignment of target type
- [-Werror=cast-align]
- { return * reinterpret_cast<const Type*> ((const char *) P +
- offset); }
+ ../src/hb-machinery.hh:63:12: error: cast from 'const char*' to 'const unsigned int*' increases required alignment of target type [-Werror=cast-align]
+ { return * reinterpret_cast<const Type*> ((const char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- ../src/hb-machinery.hh: In instantiation of 'Type&
- StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
+ ../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = unsigned int]':
../src/hb-font.cc:145:79: required from here
- ../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned
- int*' increases required alignment of target type [-Werror=cast-align]
+ ../src/hb-machinery.hh:66:12: error: cast from 'char*' to 'unsigned int*' increases required alignment of target type [-Werror=cast-align]
{ return * reinterpret_cast<Type*> ((char *) P + offset); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- ../src/hb-machinery.hh: In instantiation of 'Type&
- StructAtOffset(void*, unsigned int) [with Type = int]':
+ ../src/hb-machinery.hh: In instantiation of 'Type& StructAtOffset(void*, unsigned int) [with Type = int]':
src/hb-font.cc | 5 +++++
1 file changed, 5 insertions(+)
@@ -885,8 +2230,7 @@
[pragma] Massage more
- src/hb.hh | 106
- ++++++++++++++++++++++++++++++++------------------------------
+ src/hb.hh | 106 ++++++++++++++++++++++++++++++++------------------------------
1 file changed, 55 insertions(+), 51 deletions(-)
commit 16e5ba85b1822ff9d2b2f85f45ddd44f1a05f4b1
@@ -903,11 +2247,10 @@
Date: Fri Jan 18 09:28:22 2019 -0500
[pragma] Reorg again
-
+
https://github.com/harfbuzz/harfbuzz/issues/1546
- src/hb.hh | 91
- ++++++++++++++++++++++++++++++++-------------------------------
+ src/hb.hh | 91 ++++++++++++++++++++++++++++++++-------------------------------
1 file changed, 46 insertions(+), 45 deletions(-)
commit c04272fac81cac48b6310182d58d54569117f298
@@ -915,7 +2258,7 @@
Date: Fri Jan 18 08:49:45 2019 -0500
[pragma] GCC diagnostic ignored "-Wunknown-warning-option"
-
+
Try at fixing https://github.com/harfbuzz/harfbuzz/issues/1546
src/hb.hh | 3 ++-
@@ -962,7 +2305,7 @@
Date: Thu Jan 17 19:12:07 2019 -0500
[ci] Remove unnecessary warning declarations
-
+
clang -Weverything still left to be ported to pragmas
.circleci/config.yml | 2 +-
@@ -1105,10 +2448,9 @@
Date: Thu Jan 17 16:07:27 2019 -0500
[ci] Remove -Werror from Travis
-
- hb-machinery.hh:111:37: warning: comparison of unsigned expression >=
- 0 is always true [-Wtype-limits]
-
+
+ hb-machinery.hh:111:37: warning: comparison of unsigned expression >= 0 is always true [-Wtype-limits]
+
Also ignore -Wtype-limits.
.travis.yml | 2 --
@@ -1169,10 +2511,9 @@
Date: Thu Jan 17 14:54:32 2019 -0500
[AAT] Fully sanitize ankr table at sanitize time
-
- Third try to fix access. Followup
- 6879efc2c1596d11a6a6ad296f80063b558d5e0f
-
+
+ Third try to fix access. Followup 6879efc2c1596d11a6a6ad296f80063b558d5e0f
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
@@ -1184,15 +2525,13 @@
Date: Thu Jan 17 14:06:37 2019 -0500
[AAT] Fix anchor bound checking, again
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12532
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=922303
src/hb-aat-layout-ankr-table.hh | 3 ++-
- ...zz-testcase-minimized-harfbuzz_fuzzer-5166320261529600 | Bin 0 ->
- 393 bytes
- ...zz-testcase-minimized-hb-shape-fuzzer-5667182741028864 | Bin 0 ->
- 407 bytes
+ ...zz-testcase-minimized-harfbuzz_fuzzer-5166320261529600 | Bin 0 -> 393 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5667182741028864 | Bin 0 -> 407 bytes
3 files changed, 2 insertions(+), 1 deletion(-)
commit a262eb3d0b7009aabd9e0beebc77e5c0a2a65548
@@ -1209,7 +2548,7 @@
Date: Tue Jan 15 13:58:19 2019 -0500
Improve overflow avoidance
-
+
Better fix for 480406cd3ef9e5ab8476ddfa04498bf23906c508
This way we behave the same on 32bit and 64bit archs.
@@ -1221,7 +2560,7 @@
Date: Mon Jan 14 18:23:17 2019 -0800
fix FDSelect fuzzing bug (#1539)
-
+
Rewrote struct FDSelect3_4.ranges as ArrayOf
Updated FDSelect3_4::sanitize () to call ranges.sanitize ()
nRanges now a function to return a reference to ranges.len
@@ -1235,7 +2574,7 @@
Date: Mon Jan 14 20:45:31 2019 -0500
Move _POSIX_SOURCE definition
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1308
src/hb-blob.cc | 9 +++++++++
@@ -1248,8 +2587,7 @@
[test] Add test for previous commit
- ...uzz-testcase-minimized-harfbuzz_fuzzer-5662548265009152 | Bin 0 ->
- 28 bytes
+ ...uzz-testcase-minimized-harfbuzz_fuzzer-5662548265009152 | Bin 0 -> 28 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 480406cd3ef9e5ab8476ddfa04498bf23906c508
@@ -1257,7 +2595,7 @@
Date: Mon Jan 14 15:27:34 2019 -0500
Fix assertion on address overflow
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=917031
src/hb-machinery.hh | 5 +++--
@@ -1268,12 +2606,11 @@
Date: Mon Jan 14 15:09:14 2019 -0500
[AAT] Fix mort ContextualSubtable offset access
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=12312
src/hb-aat-layout-morx-table.hh | 3 ++-
- ...zz-testcase-minimized-hb-shape-fuzzer-5631444412530688 | Bin 0 ->
- 336 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5631444412530688 | Bin 0 -> 336 bytes
2 files changed, 2 insertions(+), 1 deletion(-)
commit a3fa7d33360a58df5333dbbd121328e580f08849
@@ -1281,12 +2618,11 @@
Date: Mon Jan 14 14:37:36 2019 -0500
[AAT] Fix ankr table access
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=918340
src/hb-aat-layout-ankr-table.hh | 7 ++++---
- ...z-testcase-minimized-harfbuzz_fuzzer-5126525414014976 | Bin 0 ->
- 1141 bytes
+ ...z-testcase-minimized-harfbuzz_fuzzer-5126525414014976 | Bin 0 -> 1141 bytes
2 files changed, 4 insertions(+), 3 deletions(-)
commit 760303d411b1561533f8f08c7c15db331c71ece8
@@ -1303,10 +2639,10 @@
Date: Wed Jan 9 16:01:11 2019 +0330
Add an initial .clang-format config
-
+
There are things can be improved on clang-format side I guess before
the full assertion, but is the best we can get for now I guess.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1536
.clang-format | 38 ++++++++++++++++++++++++++++++++++++++
@@ -1317,10 +2653,9 @@
Date: Wed Jan 9 15:56:32 2019 +0330
Minor, hack .editorconfig for vscode use
+
+ As VSCode and Atom https://github.com/Microsoft/vscode/issues/44438 don't support it
- As VSCode and Atom https://github.com/Microsoft/vscode/issues/44438
- don't support it
-
.editorconfig | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
@@ -1329,7 +2664,7 @@
Date: Tue Jan 8 12:37:48 2019 -0800
fix leak in subset_enc_supp_codes (#1537)
-
+
oss-fuzz issue 12310
src/hb-subset-cff1.cc | 2 +-
@@ -1363,8 +2698,7 @@
Usermanual: small updates.
...anual-buffers-language-script-and-direction.xml | 7 +-
- docs/usermanual-clusters.xml | 279
- ++++++++++++++++-----
+ docs/usermanual-clusters.xml | 279 ++++++++++++++++-----
docs/usermanual-getting-started.xml | 91 ++++++-
docs/usermanual-install-harfbuzz.xml | 3 +-
docs/usermanual-shaping-concepts.xml | 11 +-
@@ -1375,20 +2709,15 @@
Date: Mon Dec 31 04:30:43 2018 +0100
CircleCI: Test for Python 3 syntax errors and undefined names (#1522)
-
+
Catch missing imports and errors like #1520 and #1521
-
- __E901,E999,F821,F822,F823__ are the "_showstopper_"
- [flake8](http://flake8.pycqa.org) issues that can halt the runtime
- with a SyntaxError, NameError, etc. Most other flake8 issues are
- merely "style violations" -- useful for readability but they do not
- effect runtime safety.
+
+ __E901,E999,F821,F822,F823__ are the "_showstopper_" [flake8](http://flake8.pycqa.org) issues that can halt the runtime with a SyntaxError, NameError, etc. Most other flake8 issues are merely "style violations" -- useful for readability but they do not effect runtime safety.
* F821: undefined name `name`
* F822: undefined name `name` in `__all__`
* F823: local variable name referenced before assignment
* E901: SyntaxError or IndentationError
- * E999: SyntaxError -- failed to compile a file into an Abstract
- Syntax Tree
+ * E999: SyntaxError -- failed to compile a file into an Abstract Syntax Tree
.circleci/config.yml | 3 ++-
src/gen-use-table.py | 4 +++-
@@ -1400,7 +2729,7 @@
Date: Sun Dec 30 11:27:42 2018 -0500
Fix automake warnings
-
+
[skip ci]
test/api/Makefile.am | 1 -
@@ -1421,11 +2750,9 @@
Date: Sun Dec 30 12:58:34 2018 +0100
Python 3 fixes to gen-os2-unicode-ranges.py (#1521)
+
+ In Python 3, __reload()__ was moved and __sys.setdefaultencoding()__ because the default is already utf-8. Also __Error()__ is an _undefined name_ and __Exception()__ creates a generic exception.
- In Python 3, __reload()__ was moved and __sys.setdefaultencoding()__
- because the default is already utf-8. Also __Error()__ is an
- _undefined name_ and __Exception()__ creates a generic exception.
-
src/gen-os2-unicode-ranges.py | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
@@ -1499,11 +2826,9 @@
Date: Thu Dec 27 17:56:22 2018 -0500
[vector] Remove static_array
-
- Was good idea, but with C++ types with constructor/destructor,
- was getting in
- the way as compiler was destructing those items where it was not
- desired.
+
+ Was good idea, but with C++ types with constructor/destructor, was getting in
+ the way as compiler was destructing those items where it was not desired.
Since C++ does not allow zero-sized arrays, just remove it...
src/hb-aat-map.hh | 4 ++--
@@ -1542,10 +2867,9 @@
Date: Mon Dec 24 11:31:04 2018 -0500
[vector] Change pre-alloced count from 8 to 2
+
+ I'm thinking about dropping it to zero, but that needs slight code changes.
- I'm thinking about dropping it to zero, but that needs slight code
- changes.
-
src/hb-vector.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -1625,42 +2949,41 @@
Date: Sat Dec 22 07:47:04 2018 -0800
CFF renaming (#1507)
-
+
* reimplement ByteStr as byte_str_t based on hb_ubytes_t
-
+
Unuse start_embed<ByteStr>
Also renamed SubByteStr to byte_str_ref_t
More renaming to come
-
+
* substr renamed to str_ref in line with its type byte_str_ref_t
-
+
* uncamelize non-table struct names
-
+
* uncamelized non-struct types OpCode etc
-
+
* add byte_str_t copy ctor
-
+
* test
-
+
* test2
-
+
* undo tests
-
+
* fix bot failure
-
+
* undo the previous change
-
+
* fixed tabs, added inline
-
+
* Revert "fixed tabs, added inline"
-
+
This reverts commit 21163c30e9d18759414f7fe2518628241599f039.
-
+
* fix tabs
src/hb-cff-interp-common.hh | 215 +++++++++++++++------------------
- src/hb-cff-interp-cs-common.hh | 250
- +++++++++++++++++++--------------------
+ src/hb-cff-interp-cs-common.hh | 250 +++++++++++++++++++--------------------
src/hb-cff-interp-dict-common.hh | 64 +++++-----
src/hb-cff1-interp-cs.hh | 26 ++--
src/hb-cff2-interp-cs.hh | 56 ++++-----
@@ -1670,10 +2993,8 @@
src/hb-ot-cff2-table.cc | 28 ++---
src/hb-ot-cff2-table.hh | 128 ++++++++++----------
src/hb-subset-cff-common.cc | 10 +-
- src/hb-subset-cff-common.hh | 232
- ++++++++++++++++++------------------
- src/hb-subset-cff1.cc | 244
- +++++++++++++++++++-------------------
+ src/hb-subset-cff-common.hh | 232 ++++++++++++++++++------------------
+ src/hb-subset-cff1.cc | 244 +++++++++++++++++++-------------------
src/hb-subset-cff2.cc | 100 ++++++++--------
14 files changed, 796 insertions(+), 819 deletions(-)
@@ -1719,34 +3040,18 @@
Date: Fri Dec 21 19:48:21 2018 -0500
[iter] Change operator[] operand to be signed
-
+
To fix older compilers again (this was the case in hb_array_t).
+
+ hb-ot-layout-common.hh:1353: note: candidate 2: operator[](T*, int) <built-in>
+ hb-ot-layout-common.hh:1354: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
+ hb-ot-layout-common.hh:1354: note: candidate 2: operator[](T*, int) <built-in>
+ hb-ot-layout-common.hh: In member function 'bool OT::ClassDef::serialize(hb_serialize_context_t*, hb_array_t<const OT::IntType<short unsigned int, 2u> >, hb_array_t<const OT::IntType<short unsigned int, 2u> >)':
+ hb-ot-layout-common.hh:1490: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter, Item>::operator[](unsigned int) const [with Iter = hb_array_t<const OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short unsigned int, 2u>]
+ hb-ot-layout-common.hh:1490: note: candidate 2: operator[](T*, int) <built-in>
- hb-ot-layout-common.hh:1353: note: candidate 2: operator[](T*,
- int) <built-in>
- hb-ot-layout-common.hh:1354: error: ISO C++ says that these are
- ambiguous, even though the worst conversion for the first is better
- than the worst conversion for the second:
- hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter,
- Item>::operator[](unsigned int) const [with Iter = hb_array_t<const
- OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short
- unsigned int, 2u>]
- hb-ot-layout-common.hh:1354: note: candidate 2: operator[](T*,
- int) <built-in>
- hb-ot-layout-common.hh: In member function 'bool
- OT::ClassDef::serialize(hb_serialize_context_t*, hb_array_t<const
- OT::IntType<short unsigned int, 2u> >, hb_array_t<const
- OT::IntType<short unsigned int, 2u> >)':
- hb-ot-layout-common.hh:1490: error: ISO C++ says that these are
- ambiguous, even though the worst conversion for the first is better
- than the worst conversion for the second:
- hb-iter.hh:63: note: candidate 1: Item& hb_iter_t<Iter,
- Item>::operator[](unsigned int) const [with Iter = hb_array_t<const
- OT::IntType<short unsigned int, 2u> >, Item = const OT::IntType<short
- unsigned int, 2u>]
- hb-ot-layout-common.hh:1490: note: candidate 2: operator[](T*,
- int) <built-in>
-
src/hb-iter.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -1755,11 +3060,10 @@
Date: Fri Dec 21 19:29:00 2018 -0500
[array] Port to hb_iter_t<>
-
+
hb_array_t is its own iterator...
- src/hb-array.hh | 75
- +++++++++++++++++++++++++--------------------------------
+ src/hb-array.hh | 75 +++++++++++++++++++++++++--------------------------------
src/hb-iter.hh | 5 ++--
2 files changed, 36 insertions(+), 44 deletions(-)
@@ -1782,8 +3086,7 @@
src/hb-aat-layout-feat-table.hh | 5 ++-
src/hb-aat-layout-lcar-table.hh | 2 +-
src/hb-aat-map.cc | 4 +--
- src/hb-array.hh | 72
- ++++++++++++++++++++---------------------
+ src/hb-array.hh | 72 ++++++++++++++++++++---------------------
src/hb-cff-interp-common.hh | 10 +++---
src/hb-cff2-interp-cs.hh | 6 ++--
src/hb-coretext.cc | 12 +++----
@@ -1881,7 +3184,7 @@
Date: Fri Dec 21 16:39:57 2018 -0500
[iter] Disallow copy-construction or assignment of hb_iter_t<>
-
+
Should only be done by subclass.
src/hb-iter.hh | 5 +++++
@@ -1910,7 +3213,7 @@
Date: Fri Dec 21 16:04:38 2018 -0500
[iter] Make hb_fill() take collection type, not iter
-
+
Starting to get the hang of when take which.
src/test-iter.cc | 6 +++---
@@ -1958,7 +3261,7 @@
Date: Fri Dec 21 15:12:55 2018 -0500
[array] Remove copy constructor
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1502
src/hb-array.hh | 1 -
@@ -1969,12 +3272,9 @@
Date: Fri Dec 21 15:08:06 2018 -0500
Fix bot
+
+ C:\projects\harfbuzz\src\hb-uniscribe.cc(709): error C2666: 'hb_vector_t<OPENTYPE_FEATURE_RECORD,8>::operator +': 3 overloads have similar conversions [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
- C:\projects\harfbuzz\src\hb-uniscribe.cc(709): error C2666:
- 'hb_vector_t<OPENTYPE_FEATURE_RECORD,8>::operator
- +': 3 overloads have similar conversions
- [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
-
src/hb-uniscribe.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -2020,7 +3320,7 @@
Date: Fri Dec 21 02:48:28 2018 -0500
[iter] Make hb_fill() and hb_copy() take iterators
-
+
I'm still going back and force...
src/test-iter.cc | 11 ++++-------
@@ -2099,8 +3399,7 @@
[iter] Sketch new iterator design
- src/hb-iter.hh | 154
- +++++++++++++++++++------------------------------------
+ src/hb-iter.hh | 154 +++++++++++++++++++------------------------------------
src/test-iter.cc | 16 ++++++
2 files changed, 69 insertions(+), 101 deletions(-)
@@ -2121,12 +3420,11 @@
Date: Fri Dec 21 00:08:05 2018 -0500
Revert "Remove unused hb-iter.hh"
-
+
This reverts commit 969ff3c7aadbe721cdd414488eb170433f10d00c.
src/Makefile.sources | 1 +
- src/hb-iter.hh | 146
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-iter.hh | 146 +++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-machinery.hh | 1 +
3 files changed, 148 insertions(+)
@@ -2176,7 +3474,7 @@
Date: Thu Dec 20 15:54:17 2018 -0500
[serializer] Add operator <<
-
+
Not sure if we are going to use it. But might incentivize us to.
src/hb-machinery.hh | 2 ++
@@ -2198,7 +3496,7 @@
Date: Thu Dec 20 12:26:30 2018 -0500
[serialize] Adjust ClassDef
-
+
[skip ci]
src/hb-ot-layout-common.hh | 32 ++++++++++++++++----------------
@@ -2209,9 +3507,9 @@
Date: Thu Dec 20 11:48:45 2018 -0500
Fix code on big-endian gcc / clang
-
+
Ouch! We need a bigendian bot...
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1498
src/hb-machinery.hh | 8 +++++++-
@@ -2240,31 +3538,27 @@
Date: Thu Dec 20 11:26:54 2018 +0800
Fix build on older Visual Studio versions (#1499)
-
+
* src/hb-cff-interp-dict-common.hh: Use ull for unsigned int64_t
-
+
The llu suffix does not work for older Visual Studio versions
(pre-2013), but ull works for all the compilers that we attempt to
support.
-
+
* test/api: Fix build on pre-C99 compilers
-
+
Ensure variables are declared at the top of the block.
-
+
* src/hb-dsalgs.hh: Add specialization for hb_is_signed<> for __int8
-
- Pre-Visual Studio 2010 does not consider __int8 (which is typedef'ed
- to
- int8_t) to be equivilant to signed char, so the compiler cannot
- find the
+
+ Pre-Visual Studio 2010 does not consider __int8 (which is typedef'ed to
+ int8_t) to be equivilant to signed char, so the compiler cannot find the
corresponding hb_is_signed<> specialization that is needed.
-
- The interesting thing is unsigned __int8 is considered to be
- equivilant
- to unsigned char, so as the other types (short, int, long) that
- we look
+
+ The interesting thing is unsigned __int8 is considered to be equivilant
+ to unsigned char, so as the other types (short, int, long) that we look
for here, so only the specialization for __int8 is added here.
-
+
This will fix builds on Visual Studio 2008 at least.
src/hb-cff-interp-dict-common.hh | 2 +-
@@ -2278,7 +3572,7 @@
Date: Wed Dec 19 21:05:00 2018 -0500
[sanitize] Use hb_static_size instead of ::static_size
-
+
https://github.com/harfbuzz/harfbuzz/issues/1496#issuecomment-448818112
src/hb-machinery.hh | 11 +++++------
@@ -2289,10 +3583,9 @@
Date: Wed Dec 19 21:18:30 2018 +0330
[test] Fix test-name-table.cc leak issue
+
+ Spotted it accidentally but wanted to see if is anything serious so went for fixing it
- Spotted it accidentally but wanted to see if is anything serious so
- went for fixing it
-
src/test-name-table.cc | 2 ++
1 file changed, 2 insertions(+)
@@ -2318,8 +3611,7 @@
src/hb-open-type.hh | 18 +-
src/hb-ot-cmap-table.hh | 3 +-
src/hb-ot-layout-common.hh | 104 ++++--------
- src/hb-ot-layout-gsub-table.hh | 257
- +++++++++++++----------------
+ src/hb-ot-layout-gsub-table.hh | 257 +++++++++++++----------------
src/hb-ot-shape-complex-arabic-fallback.hh | 23 +--
9 files changed, 170 insertions(+), 269 deletions(-)
@@ -2352,14 +3644,12 @@
Date: Mon Dec 17 22:43:00 2018 -0500
Remove unused hb-iter.hh
-
- The ideas there are all part of hb-array.hh now. To be determined
- how we
+
+ The ideas there are all part of hb-array.hh now. To be determined how we
want to use generic iterator patterns.
src/Makefile.sources | 1 -
- src/hb-iter.hh | 146
- ---------------------------------------------------
+ src/hb-iter.hh | 146 ---------------------------------------------------
src/hb-machinery.hh | 1 -
3 files changed, 148 deletions(-)
@@ -2368,10 +3658,9 @@
Date: Mon Dec 17 22:41:04 2018 -0500
[arrays] Minor tweaks to hb_supplier_t
+
+ I think I like to keep this hb_supplier_t thing separately from hb_array_t.
- I think I like to keep this hb_supplier_t thing separately from
- hb_array_t.
-
src/hb-array.hh | 5 +++++
1 file changed, 5 insertions(+)
@@ -2387,8 +3676,7 @@
src/hb-open-type.hh | 4 +-
src/hb-ot-cmap-table.hh | 2 +-
src/hb-ot-layout-common.hh | 34 ++++-----
- src/hb-ot-layout-gsub-table.hh | 108
- ++++++++++++++---------------
+ src/hb-ot-layout-gsub-table.hh | 108 ++++++++++++++---------------
src/hb-ot-shape-complex-arabic-fallback.hh | 14 ++--
8 files changed, 87 insertions(+), 87 deletions(-)
@@ -2406,7 +3694,7 @@
Date: Mon Dec 17 20:34:51 2018 -0500
Enable __builtin_* on clang
-
+
We'll see which old clang versions this breaks...
src/hb-dsalgs.hh | 6 +++---
@@ -2417,7 +3705,7 @@
Date: Mon Dec 17 20:23:26 2018 -0500
Add hb_addressof() and use it to fix bug after hb_bytes_t merge
-
+
We cannot take address hb_bytes_t direction. We need to use the
newly added hb_addressof(), ala std::addressof().
@@ -2430,7 +3718,7 @@
Date: Mon Dec 17 18:27:36 2018 -0500
Enable system extensions in hb.hh
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1491
configure.ac | 1 -
@@ -2451,7 +3739,7 @@
Date: Mon Dec 17 17:56:10 2018 -0500
Remove define GNU_SOURCE
-
+
Not needed. We get it in our config.h automatically thanks to
AC_USE_SYSTEM_EXTENSIONS. Let's see whose build it breaks...
If we end up putting it back, we should add other things from
@@ -2485,7 +3773,7 @@
Date: Mon Dec 17 21:31:43 2018 +0330
Lower coretext_aat shaper priority (#1488)
-
+
Related to https://github.com/harfbuzz/harfbuzz/issues/1478
src/hb-shaper-list.hh | 8 ++++----
@@ -2539,8 +3827,7 @@
src/hb-gobject-structs.cc | 2 +-
src/hb-icu.cc | 8 +--
src/hb-iter.hh | 15 ++--
- src/hb-machinery.hh | 150
- ++++++++++++++++-----------------------
+ src/hb-machinery.hh | 150 ++++++++++++++++-----------------------
src/hb-map.cc | 4 +-
src/hb-map.hh | 24 +++----
src/hb-mutex.hh | 10 +--
@@ -2641,7 +3928,7 @@
Date: Mon Dec 17 00:39:30 2018 -0500
[array] Add cast operator to add const to Type
-
+
In lieu of constructor removed in previous commit.
src/hb-array.hh | 1 +
@@ -2670,7 +3957,7 @@
Date: Mon Dec 17 00:09:06 2018 -0500
[array] Return Crap instead of Null if Type is not const
-
+
Ouch!
src/hb-array.hh | 2 +-
@@ -2701,8 +3988,7 @@
[array] Organize
- src/hb-array.hh | 75
- ++++++++++++++++++++++++++++++++++++---------------------
+ src/hb-array.hh | 75 ++++++++++++++++++++++++++++++++++++---------------------
1 file changed, 48 insertions(+), 27 deletions(-)
commit 84c1865821151d83a8798ae11ebba3329a12c560
@@ -2756,7 +4042,7 @@
Date: Sun Dec 16 23:33:03 2018 -0500
[arrays] Remove unnecessary constructor from Supplier<>
-
+
Looks like operator hb_array_t<> from vector works here. :)
src/hb-machinery.hh | 5 -----
@@ -2797,8 +4083,7 @@
[array] Remove custom hb_bytes_t implementation
- src/hb-array.hh | 67
- +++++++++++++++++--------------------------------
+ src/hb-array.hh | 67 +++++++++++++++++--------------------------------
src/hb-machinery.hh | 2 +-
src/hb-ot-name-table.hh | 8 +++---
src/hb-ot-name.cc | 10 ++++----
@@ -2832,8 +4117,7 @@
[array] Move hb_array_t and related types to hb-array.hh
src/Makefile.sources | 1 +
- src/hb-array.hh | 241
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-array.hh | 241 +++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-dsalgs.hh | 206 -------------------------------------------
src/hb-machinery.hh | 1 +
src/hb-vector.hh | 2 +-
@@ -2918,8 +4202,7 @@
src/hb-ot-hmtx-table.hh | 18 +-
src/hb-ot-kern-table.hh | 44 ++--
src/hb-ot-layout-base-table.hh | 104 +++++-----
- src/hb-ot-layout-common.hh | 425
- ++++++++++++++++++++-------------------
+ src/hb-ot-layout-common.hh | 425 ++++++++++++++++++++-------------------
src/hb-ot-layout-gdef-table.hh | 126 ++++++------
src/hb-ot-layout-gpos-table.hh | 209 +++++++++----------
src/hb-ot-layout-gsub-table.hh | 360 ++++++++++++++++-----------------
@@ -3018,8 +4301,7 @@
[subset] Implement for ClassDef
- src/hb-ot-layout-common.hh | 80
- ++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout-common.hh | 80 ++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout-gsub-table.hh | 8 ++---
2 files changed, 84 insertions(+), 4 deletions(-)
@@ -3049,8 +4331,7 @@
[serialize] Implement for ClassDefFormat2
- src/hb-ot-layout-common.hh | 50
- ++++++++++++++++++++++++++++++++++++++++++----
+ src/hb-ot-layout-common.hh | 50 ++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 46 insertions(+), 4 deletions(-)
commit c8b43cbe316b07507aece4dc769f38226cd706da
@@ -3076,23 +4357,20 @@
Date: Wed Dec 12 18:08:15 2018 -0800
[CFF] bad offset in Index (#1476)
-
+
* Update hb-ot-cff-common.hh
-
+
* fix bug
-
+
* bummer fix wasn't hit. refix
-
+
* additional sanity check
-
+
* Added test cases for oss-fuzz issues 11805, 11806
- src/hb-ot-cff-common.hh | 10
- ++++++++--
- ...clusterfuzz-testcase-hb-subset-fuzzer-5643036478930944 | Bin 0 ->
- 369 bytes
- ...clusterfuzz-testcase-hb-subset-fuzzer-5686186874503168 | Bin 0 ->
- 962 bytes
+ src/hb-ot-cff-common.hh | 10 ++++++++--
+ ...clusterfuzz-testcase-hb-subset-fuzzer-5643036478930944 | Bin 0 -> 369 bytes
+ ...clusterfuzz-testcase-hb-subset-fuzzer-5686186874503168 | Bin 0 -> 962 bytes
3 files changed, 8 insertions(+), 2 deletions(-)
commit bcb4ecaf68c7219e89a801352bfc6a682b1581ef
@@ -3100,18 +4378,17 @@
Date: Wed Dec 12 17:36:01 2018 -0800
[CFF] check out of range FD index (#1477)
-
+
* add fd index checks to subr subsetter
-
+
also added oss-fuzz test case
-
+
* undid SubrSubsetParam::is_valid
-
+
because already validated by SubrClosures.valid
src/hb-subset-cff-common.hh | 10 ++++++++++
- ...lusterfuzz-testcase-hb-subset-fuzzer-5762137968869376 | Bin 0 ->
- 2037 bytes
+ ...lusterfuzz-testcase-hb-subset-fuzzer-5762137968869376 | Bin 0 -> 2037 bytes
2 files changed, 10 insertions(+)
commit 3f8e7a98d3cc10fefe65b9638c8abdf3ebe152cb
@@ -3119,7 +4396,7 @@
Date: Wed Dec 12 11:32:57 2018 -0500
[util/hb-subset] Add --layout to keep GDEF/GSUB/GPOS
-
+
Will become default and option removed in the future.
util/hb-subset.cc | 1 +
@@ -3162,9 +4439,9 @@
Date: Wed Dec 12 09:44:30 2018 -0500
Revert "Minor fix re sanitize of Lookup subtables"
-
+
This reverts commit 7146718bef81492e13aede0a2801cda1da41ce35.
-
+
Fixing differently.
src/hb-ot-layout-common.hh | 4 +---
@@ -3182,8 +4459,7 @@
src/hb-aat-layout-trak-table.hh | 18 +--
src/hb-aat-layout.cc | 4 +-
src/hb-buffer.cc | 48 +++----
- src/hb-directwrite.cc | 297
- +++++++++++++++++++---------------------
+ src/hb-directwrite.cc | 297 +++++++++++++++++++---------------------
src/hb-dsalgs.hh | 5 +-
src/hb-map.hh | 20 +--
src/hb-ot-cmap-table.hh | 2 +-
@@ -3203,7 +4479,7 @@
Date: Wed Dec 12 12:44:06 2018 +0330
Merge pull request #1474 from fanc999/master.msvc
-
+
Few fixes for Visual Studio builds
commit 7146718bef81492e13aede0a2801cda1da41ce35
@@ -3211,7 +4487,7 @@
Date: Tue Dec 11 23:44:29 2018 -0500
Minor fix re sanitize of Lookup subtables
-
+
We were dereferencing Null pointers and trying to sanitize them,
which is not necessary...
@@ -3232,7 +4508,7 @@
Date: Tue Dec 11 22:53:58 2018 -0500
[subset] Map glyphs during SingleSubst subsetting
-
+
Ha!
src/hb-ot-layout-gsub-table.hh | 10 ++++++----
@@ -3271,24 +4547,22 @@
Date: Tue Dec 11 12:21:24 2018 -0800
[CFF] oss-fuzz issue 11690 ASSERT: substr.offset >= opStart (#1461)
-
+
* fix oss-fuzz 11690: substr.offset >= opStart
-
+
detect recursive subroutine call & handle as error
-
+
* fix build failure
-
+
* add minimized test case for oss-fuzz 11690
-
+
* removed asserts
src/hb-cff-interp-common.hh | 9 ++++-----
- src/hb-subset-cff-common.hh | 12
- ++++++++++--
+ src/hb-subset-cff-common.hh | 12 ++++++++++--
src/hb-subset-cff1.cc | 4 ++--
src/hb-subset-cff2.cc | 4 ++--
- ...testcase-minimized-hb-subset-fuzzer-5750420593442816 | Bin 0 ->
- 96091 bytes
+ ...testcase-minimized-hb-subset-fuzzer-5750420593442816 | Bin 0 -> 96091 bytes
5 files changed, 18 insertions(+), 11 deletions(-)
commit 333586245cb37668c8a29af17920474c09667f4b
@@ -3319,7 +4593,7 @@
Date: Tue Dec 11 13:38:05 2018 -0500
[ucdn] Fix header
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1470
src/hb-ucdn/ucdn.h | 4 +---
@@ -3339,7 +4613,7 @@
Date: Wed Dec 12 01:32:01 2018 +0800
test/api: Fix building on pre-C99 compilers
-
+
Ensure variables are declared at the top of the block.
test/api/hb-test.h | 3 ++-
@@ -3357,9 +4631,8 @@
Date: Wed Dec 12 01:23:53 2018 +0800
CMake: Fix Introspection builds
-
- We need to add -DHB_AAT_H and -DHB_AAT_H_IN to the flags that
- are passed
+
+ We need to add -DHB_AAT_H and -DHB_AAT_H_IN to the flags that are passed
to g-ir-scanner, so that introspection builds can proceed normally.
CMakeLists.txt | 2 ++
@@ -3389,14 +4662,13 @@
Date: Sat Dec 8 10:20:25 2018 +0330
Apply non-controversial parts of ot-style (#1464)
-
+
Things to be used in https://github.com/harfbuzz/harfbuzz/pull/1459
src/hb-aat-fdsc-table.hh | 29 +++++++++++++++++++++++++---
src/hb-aat-layout-common.hh | 1 +
src/hb-ot-head-table.hh | 13 +++++++++++++
- src/hb-ot-os2-table.hh | 46
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-os2-table.hh | 46 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-stat-table.hh | 38 ++++++++++++++++++-------------------
5 files changed, 105 insertions(+), 22 deletions(-)
@@ -3405,9 +4677,8 @@
Date: Fri Dec 7 20:49:39 2018 -0800
fix for issue #1447 (#1462)
-
- Added case for OpCode_BaseFontName. This opcode in spec but
- practically unused.
+
+ Added case for OpCode_BaseFontName. This opcode in spec but practically unused.
Added a comment for default case which can't be hit
src/hb-ot-cff1-table.hh | 6 ++++--
@@ -3427,11 +4698,11 @@
Date: Thu Dec 6 13:36:26 2018 -0800
[CFF] Refix oss-fuzz 11714: set_blends (PR #1458) (#1460)
-
+
* pass subarray of stack to set_blends
-
+
* get_subarray to return a value, not ref
-
+
* restored error check (with tweak)
src/hb-cff-interp-common.hh | 5 +++++
@@ -3443,7 +4714,7 @@
Date: Thu Dec 6 10:27:37 2018 -0800
Fix likely check
-
+
Ouch!
src/hb-cff-interp-dict-common.hh | 4 ++--
@@ -3483,7 +4754,7 @@
Date: Thu Dec 6 10:21:00 2018 +0330
Merge pull request #1458 from harfbuzz/cff-check-blends
-
+
[CFF] oss-fuzz issue 11714: set_blends
commit ae087d10c22249f3aec3239e4eac98a728f71f75
@@ -3492,8 +4763,7 @@
add minimized test case for oss-fuzz issue 11714
- ...-testcase-minimized-hb-subset-fuzzer-5710107829075968 | Bin 0 ->
- 3660 bytes
+ ...-testcase-minimized-hb-subset-fuzzer-5710107829075968 | Bin 0 -> 3660 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 1ccbdcf73bbc967f5f94c0bc7f7e869bd87d9fa0
@@ -3518,7 +4788,7 @@
Date: Thu Dec 6 08:33:44 2018 +0330
Merge pull request #1457 from harfbuzz/cff-varstore-sanitize
-
+
[CFF] oss-fuzz issue 11713 (CFF2VariationStore::serialize)
commit 6727c4b6f0356b08803b4d5cde608ec004e3533f
@@ -3527,7 +4797,7 @@
Date: Wed Dec 5 17:37:21 2018 -0800
Merge pull request #1456 from harfbuzz/cff-subr-sanitize
-
+
[CFF] fix oss-fuzz issue 11691 (BlendArg::set_blends)
commit 9d8f3b0dfbf39f5dfa25d52f47e8af6ad318eb17
@@ -3536,8 +4806,7 @@
add minimized test case for oss-fuzz issue 11713
- ...z-testcase-minimized-hb-subset-fuzzer-5660711141769216 | Bin 0 ->
- 383 bytes
+ ...z-testcase-minimized-hb-subset-fuzzer-5660711141769216 | Bin 0 -> 383 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit c31092ab34641072606f854408eb1bea18ed2507
@@ -3562,8 +4831,7 @@
add minimized test case for oss-fuzz issue 11691
- ...z-testcase-minimized-hb-shape-fuzzer-5686369209286656 | Bin 0 ->
- 2880 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5686369209286656 | Bin 0 -> 2880 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit d9dabc00e9278a346e85538212c126da7e610d55
@@ -3572,7 +4840,7 @@
Date: Wed Dec 5 15:39:34 2018 -0800
Merge pull request #1454 from harfbuzz/cff-fixbcd
-
+
[CFF] fix oss-fuzz issue 11674: parse_bcd
commit 81cfd3c775dbc470f57d7fe2775cc068ffa367b6
@@ -3581,7 +4849,7 @@
Date: Wed Dec 5 15:37:15 2018 -0800
Merge pull request #1455 from harfbuzz/cff-strinc_assert
-
+
[CFF] fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
commit 6dcfda92c17a7701479118751a8290246e9a3c05
@@ -3599,13 +4867,11 @@
Date: Wed Dec 5 12:51:18 2018 -0800
fix oss-fuzz issue 11675 (ASSERT: count <= str.len)
-
+
Also added an additional error check to avail ()
- src/hb-cff-interp-common.hh | 18
- ++++++++++++++++--
- ...stcase-minimized-hb-subset-fuzzer-5768186323009536 | Bin 0 ->
- 337 bytes
+ src/hb-cff-interp-common.hh | 18 ++++++++++++++++--
+ ...stcase-minimized-hb-subset-fuzzer-5768186323009536 | Bin 0 -> 337 bytes
2 files changed, 16 insertions(+), 2 deletions(-)
commit 010e2ddb384b5a721172fd7466aafec58dbf8063
@@ -3614,8 +4880,7 @@
minimized test case for oss-fuzz issue 11674
- ...zz-testcase-minimized-hb-subset-fuzzer-5672006905757696 | Bin 0 ->
- 73 bytes
+ ...zz-testcase-minimized-hb-subset-fuzzer-5672006905757696 | Bin 0 -> 73 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 2cb9d4c183afc838ecf2ba0d47814e9eaa6f09c6
@@ -3640,8 +4905,7 @@
[os2] Make newer table fields accessible (#1452)
- src/hb-ot-os2-table.hh | 88
- +++++++++++++++++++++++++++++++++++++-------------
+ src/hb-ot-os2-table.hh | 88 +++++++++++++++++++++++++++++++++++++-------------
1 file changed, 66 insertions(+), 22 deletions(-)
commit 5ab086ebb18112ef48bf6c913acc91b2009a9bed
@@ -3649,16 +4913,15 @@
Date: Wed Dec 5 14:17:37 2018 +0330
[fdsc] Implement the table parsing
-
+
Related to https://github.com/harfbuzz/harfbuzz/issues/1337
-
+
May used in addition to an API related to STAT.
-
+
Lots of Apple fonts have it.
src/Makefile.sources | 1 +
- src/hb-aat-fdsc-table.hh | 103
- +++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-fdsc-table.hh | 103 +++++++++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 1 +
3 files changed, 105 insertions(+)
@@ -3667,13 +4930,11 @@
Date: Wed Dec 5 13:51:14 2018 +0330
[gasp] Implement the table parsing
+
+ May or may not be used in https://github.com/harfbuzz/harfbuzz/pull/1432
- May or may not be used in
- https://github.com/harfbuzz/harfbuzz/pull/1432
-
src/Makefile.sources | 1 +
- src/hb-ot-gasp-table.hh | 84
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-gasp-table.hh | 84 +++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout.cc | 5 +--
3 files changed, 88 insertions(+), 2 deletions(-)
@@ -3683,7 +4944,7 @@
Date: Wed Dec 5 13:25:18 2018 +0330
Merge pull request #1449 from harfbuzz/cff-fixcharset
-
+
[CFF] fix for oss-fuzz 11657: Charset overrun
commit cf4b7db6b1e01c11d7a8a26d95cf947935a234a7
@@ -3692,7 +4953,7 @@
Date: Wed Dec 5 13:23:23 2018 +0330
Merge pull request #1448 from harfbuzz/cff-leak
-
+
[CFF] fix leak: oss-fuzz 11662
commit 620d1ef588c6ce25644891cfe4b9c20fd8a9d1db
@@ -3764,8 +5025,7 @@
check overflow & clamp
- src/hb-cff-interp-dict-common.hh | 36
- +++++++++++++++++++++++++++---------
+ src/hb-cff-interp-dict-common.hh | 36 +++++++++++++++++++++++++++---------
1 file changed, 27 insertions(+), 9 deletions(-)
commit 32cc46c75a5f163f254b7998ed9193d5bbc85e4b
@@ -3773,15 +5033,14 @@
Date: Tue Dec 4 21:32:34 2018 -0800
[CFF] fix oss-fuzz issue 11670: NULL dereference (#1450)
-
+
* guard against no subr access
-
+
* code tweak
-
+
* add minimized testcase for oss-fuzz 11670 (Null deference)
- src/hb-cff-interp-cs-common.hh | 22
- ++++++++++++++++-----
+ src/hb-cff-interp-cs-common.hh | 22 ++++++++++++++++-----
src/hb-ot-cff-common.hh | 2 +-
...ase-minimized-hb-subset-fuzzer-5672913680728064 | Bin 0 -> 861 bytes
3 files changed, 18 insertions(+), 6 deletions(-)
@@ -3792,8 +5051,7 @@
added minimized testcase for oss-fuzz issue 11657
- ...zz-testcase-minimized-hb-shape-fuzzer-5700264032468992 | Bin 0 ->
- 648 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5700264032468992 | Bin 0 -> 648 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit d3d2f32c6e85de1d7fbbb18afef356e09110e61c
@@ -3801,7 +5059,7 @@
Date: Tue Dec 4 13:51:26 2018 -0800
fix oss-fuzz 11657: buffer overrun
-
+
Check overrun in Charset1_2::get_glyph
src/hb-ot-cff1-table.hh | 10 ++++++----
@@ -3811,8 +5069,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Tue Dec 4 23:42:13 2018 +0330
- Reuse hb_aat_layout_has_* logic in coretext-aat detection logic
- (#1442)
+ Reuse hb_aat_layout_has_* logic in coretext-aat detection logic (#1442)
src/hb-coretext.cc | 16 ++--------------
1 file changed, 2 insertions(+), 14 deletions(-)
@@ -3840,8 +5097,7 @@
added minimized test case for oss-fuzz issue 11662
- ...testcase-minimized-hb-shape-fuzzer-5175735354916864 | Bin 0 ->
- 354461 bytes
+ ...testcase-minimized-hb-shape-fuzzer-5175735354916864 | Bin 0 -> 354461 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 0b952e6026c8be13d16d97f464034ee477e6282f
@@ -3860,7 +5116,7 @@
Date: Tue Dec 4 21:30:07 2018 +0330
Merge pull request #1444 from harfbuzz/cff-assert
-
+
removed assert, fixes https://github.com/harfbuzz/harfbuzz/issues/1443
commit 9473463f5c884fcb1de8a7ba7410da2601e6ffa8
@@ -3887,7 +5143,7 @@
Date: Tue Dec 4 04:14:13 2018 -0500
Merge pull request #1441 from harfbuzz/cff-doublenum
-
+
use double as CFF Number implementation
commit c48f53d30901dfc20b7432c2947e66642010dc4e
@@ -3906,12 +5162,9 @@
added minimized test cases
- ...zz-testcase-minimized-hb-shape-fuzzer-5647267827023872 | Bin 0 ->
- 655 bytes
- ...zz-testcase-minimized-hb-shape-fuzzer-5725855502827520 | Bin 0 ->
- 655 bytes
- ...zz-testcase-minimized-hb-shape-fuzzer-5736657639178240 | Bin 0 ->
- 459 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5647267827023872 | Bin 0 -> 655 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5725855502827520 | Bin 0 -> 655 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5736657639178240 | Bin 0 -> 459 bytes
3 files changed, 0 insertions(+), 0 deletions(-)
commit 5fff6ab0024547a8ac47723a0047f4b17416d6ce
@@ -3941,8 +5194,7 @@
Number to use double for all types
- src/hb-cff-interp-common.hh | 84
- +++++++--------------------------------------
+ src/hb-cff-interp-common.hh | 84 +++++++--------------------------------------
1 file changed, 13 insertions(+), 71 deletions(-)
commit 8c05b955eb4aa088b2b5df9b6415863486eaf59c
@@ -3951,7 +5203,7 @@
Date: Mon Dec 3 14:30:51 2018 -0500
Merge pull request #1439 from ebraminio/tracking
-
+
[aat] Expose hb_aat_layout_has_tracking API
commit 01f628cf5571b8b58108ab66cfc3e929c9840e31
@@ -3974,7 +5226,7 @@
Date: Mon Dec 3 10:41:37 2018 -0500
[aat] Expose a couple APIs
-
+
New API:
+hb_aat_layout_has_substitution()
+hb_aat_layout_has_positioning()
@@ -3990,13 +5242,12 @@
Date: Sun Dec 2 12:38:53 2018 -0500
[aat] Fix division sign fallout
-
+
Happened after 11d2f49af8f53340134c844173f4d8655b00dea3
since now nClasses is unsigned int...
src/hb-aat-layout-common.hh | 2 +-
- ...zz-testcase-minimized-hb-shape-fuzzer-5768046065483776 | Bin 0 ->
- 342 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5768046065483776 | Bin 0 -> 342 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
commit 2087f5a2a743380b36399ba8a2b4ff9e93890fcf
@@ -4017,8 +5268,7 @@
CMakeLists.txt | 12 +--
src/Makefile.am | 6 --
- src/Makefile.sources | 231
- ++++++++++++++++++++++++---------------------------
+ src/Makefile.sources | 231 ++++++++++++++++++++++++---------------------------
3 files changed, 111 insertions(+), 138 deletions(-)
commit 967a204ee92548163a0d19678a237dcaf3720c20
@@ -4035,7 +5285,7 @@
Date: Sat Dec 1 13:12:21 2018 -0500
New approach to change BigEndian casts to be int-sized
-
+
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
@@ -4056,9 +5306,9 @@
Date: Sat Dec 1 00:14:48 2018 -0500
Revert "Change BigEndian casts to be int-sized"
-
+
This reverts commit eb5ddd32bf4e458ca0af8d5784f8fd46485ad225.
-
+
Broke tests, badly. To be investigated and reenabled.
src/hb-open-type.hh | 16 ++++++++--------
@@ -4078,7 +5328,7 @@
Date: Sat Dec 1 00:03:01 2018 -0500
Change BigEndian casts to be int-sized
-
+
Fixes spurious warnings like:
Fixes https://github.com/harfbuzz/harfbuzz/issues/1436
@@ -4116,14 +5366,12 @@
src/hb-cff2-interp-cs.hh | 76 +++----
src/hb-ot-cff-common.hh | 128 +++++------
src/hb-ot-cff1-table.cc | 4 +-
- src/hb-ot-cff1-table.hh | 456
- +++++++++++++++++++--------------------
+ src/hb-ot-cff1-table.hh | 456 +++++++++++++++++++--------------------
src/hb-ot-cff2-table.cc | 4 +-
src/hb-ot-cff2-table.hh | 216 +++++++++----------
src/hb-subset-cff-common.cc | 76 +++----
src/hb-subset-cff-common.hh | 384 ++++++++++++++++-----------------
- src/hb-subset-cff1.cc | 416
- +++++++++++++++++------------------
+ src/hb-subset-cff1.cc | 416 +++++++++++++++++------------------
src/hb-subset-cff1.hh | 2 +-
src/hb-subset-cff2.cc | 240 ++++++++++-----------
src/hb-subset-cff2.hh | 2 +-
@@ -4164,8 +5412,7 @@
Remove generated files that were accidentally added by CFF2 branch
gtk-doc.make | 320 --
- m4/libtool.m4 | 8369
- -----------------------------------------------------
+ m4/libtool.m4 | 8369 -----------------------------------------------------
m4/ltoptions.m4 | 437 ---
m4/ltsugar.m4 | 124 -
m4/ltversion.m4 | 23 -
@@ -4178,7 +5425,7 @@
Date: Fri Nov 30 22:40:54 2018 -0500
Merge pull request #1113 from harfbuzz/cff-subset
-
+
CFF/CFF2 subsetter
commit 09096aa89f1944dff94a5518bce578eba8989e74
@@ -4186,9 +5433,9 @@
Date: Sat Dec 1 10:22:49 2018 +0700
Use nullptr instead of 0/NULL. (#1435)
-
+
* Use nullptr instead of 0/NULL.
-
+
* Update test-name-table.cc
src/hb-debug.hh | 2 +-
@@ -4221,7 +5468,7 @@
Date: Fri Nov 30 21:36:35 2018 -0500
Merge pull request #1433 from harfbuzz/overload-overload
-
+
Fix ambiguous overload errors with old compilers
commit fb059082138bf17a5a8616410d9a35f927f9fd85
@@ -4229,14 +5476,14 @@
Date: Fri Nov 30 20:45:40 2018 -0500
Revert ugly fixes
-
+
Now that we have 6daf45e0, revert cryptic hacks...
-
+
This reverts commit abd81ed4f5cbc5a94171747909bc6b77551cb929.
This reverts commit 9c6921c08c905a0cf45ba0182134e6ff910fac51.
This reverts commit d39760cabfe4007cefdfc45231e85e93fababac2.
This reverts commit fedd8e6c176dea85194693399e50243eb1c117c4.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1374
src/hb-aat-layout-morx-table.hh | 4 ++--
@@ -4253,11 +5500,11 @@
Date: Fri Nov 30 19:57:12 2018 -0500
Make operator [] take signed int
-
+
The built-in operator takes signed int. So, match it, such that
the built-in is never a better or equally-good match to our operator.
Fixes "ambiguous overload" errors from gcc 4.2 and VS 2008.
-
+
See https://github.com/harfbuzz/harfbuzz/issues/1374
src/hb-dsalgs.hh | 3 ++-
@@ -4326,15 +5573,12 @@
Date: Fri Nov 30 16:50:30 2018 -0500
One more.........
-
+
I wonder if there's something better to do about these :(.
-
+
In file included from hb-ot-color.cc:31:
- hb-ot-color-cpal-table.hh: In member function 'unsigned int
- OT::CPAL::get_size() const':
- hb-ot-color-cpal-table.hh:118: error: ISO C++ says that these are
- ambiguous, even though the worst conversion for the first is better
- than the worst conversion for the second:
+ hb-ot-color-cpal-table.hh: In member function 'unsigned int OT::CPAL::get_size() const':
+ hb-ot-color-cpal-table.hh:118: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
src/hb-ot-color-cpal-table.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -4344,16 +5588,11 @@
Date: Fri Nov 30 16:04:52 2018 -0500
One more....
+
+ hb-ot-vorg-table.hh:96: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-vector.hh:87: note: candidate 1: const Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) const [with Type = OT::VertOriginMetric, unsigned int PreallocedCount = 8u]
+ hb-ot-vorg-table.hh:96: note: candidate 2: operator[](const T*, int) <built-in>
- hb-ot-vorg-table.hh:96: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-vector.hh:87: note: candidate 1: const Type& hb_vector_t<Type,
- PreallocedCount>::operator[](unsigned int) const [with Type =
- OT::VertOriginMetric, unsigned int PreallocedCount = 8u]
- hb-ot-vorg-table.hh:96: note: candidate 2: operator[](const T*,
- int) <built-in>
-
src/hb-ot-vorg-table.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -4362,20 +5601,14 @@
Date: Fri Nov 30 15:55:30 2018 -0500
One more...
-
+
Sigh.
+
+ hb-ot-kern-table.hh: In member function 'int OT::KernSubTableFormat3<KernSubTableHeader>::get_kerning(hb_codepoint_t, hb_codepoint_t) const':
+ hb-ot-kern-table.hh:59: error: ambiguous overload for 'operator[]' in 'kernValue[kernIndex[i]]'
+ hb-ot-kern-table.hh:59: note: candidates are: operator[](T*, int) <built-in>
+ hb-dsalgs.hh:574: note: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::IntType<short int, 2u>]
- hb-ot-kern-table.hh: In member function 'int
- OT::KernSubTableFormat3<KernSubTableHeader>::get_kerning(hb_codepoint_t,
- hb_codepoint_t) const':
- hb-ot-kern-table.hh:59: error: ambiguous overload for 'operator[]'
- in 'kernValue[kernIndex[i]]'
- hb-ot-kern-table.hh:59: note: candidates are: operator[](T*, int)
- <built-in>
- hb-dsalgs.hh:574: note: Type&
- hb_array_t<Type>::operator[](unsigned int) const [with Type = const
- OT::IntType<short int, 2u>]
-
src/hb-ot-kern-table.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -4384,10 +5617,8 @@
Date: Fri Nov 30 15:16:57 2018 -0500
More...
-
- hb-ot-layout-gsubgpos.hh:1707: error: ISO C++ says that these are
- ambiguous, even though the worst conversion for the first is better
- than the worst conversion for the second:
+
+ hb-ot-layout-gsubgpos.hh:1707: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
...
src/hb-aat-layout-morx-table.hh | 4 ++--
@@ -4400,44 +5631,22 @@
Date: Fri Nov 30 12:52:21 2018 -0500
More weird fixes
-
+
In file included from hb-ot-name.cc:29:
- hb-ot-name-table.hh: In member function 'unsigned int
- OT::name::get_size() const':
- hb-ot-name-table.hh:157: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-open-type.hh:354: note: candidate 1: const Type&
- OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type
- = OT::NameRecord]
- hb-ot-name-table.hh:157: note: candidate 2: operator[](const T*,
- int) <built-in>
- hb-ot-name-table.hh: In member function 'void
- OT::name::accelerator_t::init(hb_face_t*)':
- hb-ot-name-table.hh:196: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-dsalgs.hh:574: note: candidate 1: Type&
- hb_array_t<Type>::operator[](unsigned int) const [with Type =
- const OT::NameRecord]
- hb-ot-name-table.hh:196: note: candidate 2: operator[](T*, int)
- <built-in>
- hb-ot-name-table.hh:197: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-dsalgs.hh:574: note: candidate 1: Type&
- hb_array_t<Type>::operator[](unsigned int) const [with Type =
- const OT::NameRecord]
- hb-ot-name-table.hh:197: note: candidate 2: operator[](T*, int)
- <built-in>
- hb-ot-name-table.hh:198: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-dsalgs.hh:574: note: candidate 1: Type&
- hb_array_t<Type>::operator[](unsigned int) const [with Type =
- const OT::NameRecord]
- hb-ot-name-table.hh:198: note: candidate 2: operator[](T*, int)
- <built-in>
+ hb-ot-name-table.hh: In member function 'unsigned int OT::name::get_size() const':
+ hb-ot-name-table.hh:157: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::NameRecord]
+ hb-ot-name-table.hh:157: note: candidate 2: operator[](const T*, int) <built-in>
+ hb-ot-name-table.hh: In member function 'void OT::name::accelerator_t::init(hb_face_t*)':
+ hb-ot-name-table.hh:196: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
+ hb-ot-name-table.hh:196: note: candidate 2: operator[](T*, int) <built-in>
+ hb-ot-name-table.hh:197: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
+ hb-ot-name-table.hh:197: note: candidate 2: operator[](T*, int) <built-in>
+ hb-ot-name-table.hh:198: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-dsalgs.hh:574: note: candidate 1: Type& hb_array_t<Type>::operator[](unsigned int) const [with Type = const OT::NameRecord]
+ hb-ot-name-table.hh:198: note: candidate 2: operator[](T*, int) <built-in>
make[4]: *** [libharfbuzz_la-hb-ot-name.lo] Error 1
make[3]: *** [all-recursive] Error 1
@@ -4456,64 +5665,29 @@
Date: Fri Nov 30 11:51:26 2018 -0500
Umm. Cryptic, yes
-
+
In file included from hb-face.cc:35:
- hb-ot-cmap-table.hh: In member function 'void
- OT::CmapSubtableFormat4::_compiles_assertion_on_line_388() const':
- hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-open-type.hh:354: note: candidate 1: const Type&
- OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type =
- OT::IntType<short unsigned int, 2u>]
- hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*,
- int) <built-in>
- hb-ot-cmap-table.hh: In member function 'void
- OT::CmapSubtableFormat4::_instance_assertion_on_line_388() const':
- hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous,
- even though the worst conversion for the first is better than the
- worst conversion for the second:
- hb-open-type.hh:354: note: candidate 1: const Type&
- OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type =
- OT::IntType<short unsigned int, 2u>]
- hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*,
- int) <built-in>
- hb-face.cc: In function 'hb_blob_t*
- _hb_face_builder_data_reference_blob(hb_face_builder_data_t*)':
- hb-face.cc:650: error: ISO C++ says that these are ambiguous, even
- though the worst conversion for the first is better than the worst
- conversion for the second:
- hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type,
- PreallocedCount>::operator[](unsigned int) [with Type =
- hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount
- = 32u]
+ hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_compiles_assertion_on_line_388() const':
+ hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>]
+ hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in>
+ hb-ot-cmap-table.hh: In member function 'void OT::CmapSubtableFormat4::_instance_assertion_on_line_388() const':
+ hb-ot-cmap-table.hh:388: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-open-type.hh:354: note: candidate 1: const Type& OT::UnsizedArrayOf<Type>::operator[](unsigned int) const [with Type = OT::IntType<short unsigned int, 2u>]
+ hb-ot-cmap-table.hh:388: note: candidate 2: operator[](const T*, int) <built-in>
+ hb-face.cc: In function 'hb_blob_t* _hb_face_builder_data_reference_blob(hb_face_builder_data_t*)':
+ hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:650: note: candidate 2: operator[](T*, int) <built-in>
- hb-face.cc:650: error: ISO C++ says that these are ambiguous, even
- though the worst conversion for the first is better than the worst
- conversion for the second:
- hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type,
- PreallocedCount>::operator[](unsigned int) [with Type =
- hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount
- = 32u]
- hb-face.cc:650: note: candidate 2: operator[](const T*, int)
- <built-in>
- hb-face.cc:651: error: ISO C++ says that these are ambiguous, even
- though the worst conversion for the first is better than the worst
- conversion for the second:
- hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type,
- PreallocedCount>::operator[](unsigned int) [with Type =
- hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount
- = 32u]
+ hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
+ hb-face.cc:650: note: candidate 2: operator[](const T*, int) <built-in>
+ hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:651: note: candidate 2: operator[](T*, int) <built-in>
- hb-face.cc:651: error: ISO C++ says that these are ambiguous, even
- though the worst conversion for the first is better than the worst
- conversion for the second:
- hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type,
- PreallocedCount>::operator[](unsigned int) [with Type =
- hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount
- = 32u]
- hb-face.cc:651: note: candidate 2: operator[](const T*, int)
- <built-in>
+ hb-face.cc:651: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
+ hb-face.cc:651: note: candidate 2: operator[](const T*, int) <built-in>
src/hb-face.cc | 4 ++--
src/hb-machinery.hh | 4 ++--
@@ -4524,14 +5698,9 @@
Date: Fri Nov 30 11:51:26 2018 -0500
Umm. Cryptic, yes
-
- hb-face.cc:650: error: ISO C++ says that these are ambiguous, even
- though the worst conversion for the first is better than the worst
- conversion for the second:
- hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type,
- PreallocedCount>::operator[](unsigned int) [with Type =
- hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount
- = 32u]
+
+ hb-face.cc:650: error: ISO C++ says that these are ambiguous, even though the worst conversion for the first is better than the worst conversion for the second:
+ hb-vector.hh:81: note: candidate 1: Type& hb_vector_t<Type, PreallocedCount>::operator[](unsigned int) [with Type = hb_face_builder_data_t::table_entry_t, unsigned int PreallocedCount = 32u]
hb-face.cc:650: note: candidate 2: operator[](T*, int) <built-in>
src/hb-face.cc | 4 ++--
@@ -4582,8 +5751,7 @@
src/Makefile.sources | 1 +
src/hb-deprecated.h | 61 +---------------------------
- src/hb-ot-deprecated.h | 106
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-deprecated.h | 106 +++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot.h | 1 +
4 files changed, 109 insertions(+), 60 deletions(-)
@@ -4611,11 +5779,10 @@
Date: Fri Nov 30 00:06:40 2018 +0330
[test][aat] Remove extra --shaper ot
-
+
As run-tests.py already adds it
- test/shaping/data/in-house/tests/macos.tests | 64
- ++++++++++++++--------------
+ test/shaping/data/in-house/tests/macos.tests | 64 ++++++++++++++--------------
1 file changed, 32 insertions(+), 32 deletions(-)
commit b65645bbafb3f1f9f956df3028cf4479a4bdc265
@@ -4624,8 +5791,7 @@
[ci] Re-enable llvm-gcc-4.2 bots (#1429)
- .circleci/config.yml | 48
- ++++++++++++++++++++++++------------------------
+ .circleci/config.yml | 48 ++++++++++++++++++++++++------------------------
1 file changed, 24 insertions(+), 24 deletions(-)
commit e7bd29ea11bd6301a332b471120a4a2cd8575d09
@@ -4642,7 +5808,7 @@
Date: Thu Nov 29 15:07:44 2018 -0500
[coretext] Fix compile
-
+
Fingers crossed.
src/hb-coretext.cc | 2 +-
@@ -4724,7 +5890,7 @@
Date: Thu Nov 29 14:34:44 2018 -0500
[vector] Make pointer cast explicit
-
+
Too bad this doesn't help MSVC 2008 build, as explicit operators are
C++11.
@@ -4750,10 +5916,8 @@
[test/text-rendering-tests] Update from upstream
- .../text-rendering-tests/fonts/TestGVAR-Composite-0.ttf | Bin 0 ->
- 3136 bytes
- .../fonts/TestGVAR-Composite-Missing.ttf | Bin 0 ->
- 2984 bytes
+ .../text-rendering-tests/fonts/TestGVAR-Composite-0.ttf | Bin 0 -> 3136 bytes
+ .../fonts/TestGVAR-Composite-Missing.ttf | Bin 0 -> 2984 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
commit 000d4b128eba58677acdc3b361829ff2f9a257b1
@@ -4761,7 +5925,7 @@
Date: Thu Nov 29 12:32:47 2018 -0500
Make shaper's override_features() override user features as well
-
+
The override_features is used to override features that are normally
discretionary features, but in a specific shaper are for various
reasons desired to be bolted on or off, because they've been used
@@ -4768,7 +5932,7 @@
for inherent shaping. As such, it makes sense that they also
override user features. Ie. if user turned 'liga' on, we don't
want Khmer shaping to become broken... Or turn 'clig' off...
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1310
src/hb-ot-shape.cc | 6 +++---
@@ -4779,7 +5943,7 @@
Date: Thu Nov 29 12:30:14 2018 -0500
[khmer] Move 'clig' to overrides
-
+
Prerequisite for https://github.com/harfbuzz/harfbuzz/issues/1310
src/hb-ot-shape-complex-khmer.cc | 15 +++++++++------
@@ -4790,9 +5954,9 @@
Date: Thu Nov 29 12:18:14 2018 -0500
Fix "typename outside template" issues
-
+
Nothing an extra template class wouldn't fix...
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1419
src/hb-null.hh | 25 +++++++++++++++++++------
@@ -4829,7 +5993,7 @@
Date: Thu Nov 29 10:39:18 2018 -0500
Merge pull request #1418 from gvictor/replace_icu_deprecated
-
+
Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
commit e0307de818ad1f70ef96938642bda61d7a62532a
@@ -4863,7 +6027,7 @@
Date: Wed Nov 28 17:21:57 2018 -0500
Merge pull request #1425 from mbutterick/patch-1
-
+
update simple shaping example (closes #298)
commit d3d0f15f7d20bedf7018fb2fb652f92ff4159bd7
@@ -4871,10 +6035,9 @@
Date: Wed Nov 28 13:46:12 2018 -0800
update simple shaping example (closes #298)
+
+ add call to `FT_Set_Char_Size`, otherwise default size remains at `0`, and glyph positions come back as `0` too
- add call to `FT_Set_Char_Size`, otherwise default size remains at
- `0`, and glyph positions come back as `0` too
-
docs/usermanual-getting-started.xml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -4883,9 +6046,8 @@
Date: Thu Nov 29 00:55:05 2018 +0330
[test][aat] Update expectency
-
- It is not visually noticeable but apparently affected by kern format2
- correct implementation.
+
+ It is not visually noticeable but apparently affected by kern format2 correct implementation.
I should've checked CoreText result which can't as CircleCI outage.
test/shaping/data/in-house/tests/macos.tests | 4 ++--
@@ -4898,8 +6060,7 @@
[test] Add test for format2 kern (#1423)
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/e39391c77a6321c2ac7a2d644de0396470cd4bfe.ttf | Bin 0 ->
- 34116 bytes
+ .../fonts/e39391c77a6321c2ac7a2d644de0396470cd4bfe.ttf | Bin 0 -> 34116 bytes
test/shaping/data/in-house/tests/kern-format2.tests | 3 +++
3 files changed, 4 insertions(+)
@@ -4925,7 +6086,7 @@
Date: Wed Nov 28 15:06:01 2018 -0500
[kern] Fix kern table Format2 offsetToIndex
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1421
src/hb-aat-layout-kerx-table.hh | 8 ++++++--
@@ -4957,8 +6118,7 @@
[test][aat] Add a test and make macOS runners faster (#1422)
.circleci/config.yml | 15 +++-----
- test/shaping/data/in-house/tests/macos.tests | 54
- ++++++++++++++--------------
+ test/shaping/data/in-house/tests/macos.tests | 54 ++++++++++++++--------------
2 files changed, 33 insertions(+), 36 deletions(-)
commit 987f4187722a05e3f360b85c66309a351fc5d6ad
@@ -4967,7 +6127,7 @@
Date: Tue Nov 27 17:40:32 2018 -0500
Merge pull request #1398 from Adenilson/bigInt01
-
+
Optimize harfbuzz big integer conversions
commit 4e2a03b6b6e0c0d1c4edea10dc1aae63eeb6c581
@@ -4984,21 +6144,19 @@
Date: Tue Nov 20 14:41:19 2018 -0800
Optimize harfbuzz big integer conversions
-
- Profiling showed that type conversions were adding considerable
- cycles in time
+
+ Profiling showed that type conversions were adding considerable cycles in time
spent doing text shaping.
-
- The idea is to optimize it using native processor instructions to
- help Blink
+
+ The idea is to optimize it using native processor instructions to help Blink
layout performance.
-
+
Doing further investigation revelead that compilers may not use the
proper instruction on ARM 32bits builds (i.e. REV16).
-
+
One way to insure that the generated ASM was ideal for both gcc/clang
was using __builtin_bswap16.
-
+
Added bonus is that we no longer need to test for CPU architecture.
src/hb-machinery.hh | 4 ++++
@@ -5009,10 +6167,10 @@
Date: Tue Nov 27 11:34:56 2018 +0000
Replace @Deprecated ICU API - USCRIPT_CODE_LIMIT
-
+
Use of the deprecated API USCRIPT_CODE_LIMIT prevents harfbuzz
using the ICU4C as a shared library.
-
+
The API has been replaced by u_getIntPropertyMaxValue(UCHAR_SCRIPT)
src/hb-icu.cc | 3 ++-
@@ -5023,10 +6181,9 @@
Date: Mon Nov 26 18:58:39 2018 +0330
[ci] Add .codecov.yml
-
- Similar to
- https://github.com/GoogleChrome/lighthouse/blob/master/.codecov.yml
-
+
+ Similar to https://github.com/GoogleChrome/lighthouse/blob/master/.codecov.yml
+
No strong preference on commenting, feel free to enable it again
.codecov.yml | 7 +++++++
@@ -5046,7 +6203,7 @@
Date: Sun Nov 25 16:51:22 2018 -0500
[aat] Ignore GSUB table of Muthu Foundry if they have morx table
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1410
src/hb-ot-layout-gpos-table.hh | 3 +++
@@ -5116,13 +6273,12 @@
Date: Sun Nov 25 01:14:40 2018 -0500
[aat.feat] Rework API and implementation
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/1346
docs/harfbuzz-docs.xml | 5 +++
docs/harfbuzz-sections.txt | 7 ++--
- src/hb-aat-layout-feat-table.hh | 89
- +++++++++++++++++++++++------------------
+ src/hb-aat-layout-feat-table.hh | 89 +++++++++++++++++++++++------------------
src/hb-aat-layout.cc | 80 ++++++++++++++++--------------------
src/hb-aat-layout.h | 32 +++++++++------
test/api/test-aat-layout.c | 58 ++++++++++++++-------------
@@ -5169,7 +6325,7 @@
Date: Sat Nov 24 10:46:56 2018 -0500
[AAT.feat] Use lsearch for looking up SettingName's
-
+
They are not sorted.
src/hb-aat-layout-feat-table.hh | 18 ++++++------------
@@ -5192,17 +6348,15 @@
Date: Fri Nov 23 14:05:11 2018 -0500
[aat] Move contents of hb-aat.h to hb-aat-layout.h
-
+
Since it was pages and pages...
src/Makefile.sources | 1 +
src/hb-aat-layout.cc | 1 -
- src/hb-aat-layout.h | 452
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout.h | 452 +++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.hh | 1 -
src/hb-aat-map.hh | 1 -
- src/hb-aat.h | 417
- +----------------------------------------------
+ src/hb-aat.h | 417 +----------------------------------------------
src/hb.hh | 2 +
7 files changed, 458 insertions(+), 417 deletions(-)
@@ -5215,8 +6369,7 @@
src/hb-aat-layout-feat-table.hh | 2 +-
src/hb-aat-layout-morx-table.hh | 4 +-
src/hb-aat-layout.cc | 150 ++++++------
- src/hb-aat.h | 502
- ++++++++++++++++++++--------------------
+ src/hb-aat.h | 502 ++++++++++++++++++++--------------------
test/api/test-aat-layout.c | 2 +-
5 files changed, 330 insertions(+), 330 deletions(-)
@@ -5251,8 +6404,7 @@
docs/harfbuzz-sections.txt | 6 +--
src/hb-aat-layout-feat-table.hh | 52 ++++++++++++------------
src/hb-aat-layout-morx-table.hh | 2 +-
- src/hb-aat-layout.cc | 88
- ++++++++++++++++++++---------------------
+ src/hb-aat-layout.cc | 88 ++++++++++++++++++++---------------------
src/hb-aat-layout.hh | 4 +-
src/hb-aat-map.cc | 2 +-
src/hb-aat-map.hh | 2 +-
@@ -5267,8 +6419,7 @@
[feat] Apply renamings and add documentation
docs/harfbuzz-sections.txt | 10 ++++++++++
- src/hb-aat-layout.cc | 44
- ++++++++++++++++++++++++++++++++++++++------
+ src/hb-aat-layout.cc | 44 ++++++++++++++++++++++++++++++++++++++------
src/hb-aat.h | 6 +++---
test/api/test-aat-layout.c | 28 ++++++++++++++--------------
4 files changed, 65 insertions(+), 23 deletions(-)
@@ -5292,8 +6443,7 @@
src/hb-aat-layout-feat-table.hh | 114 ++++---
src/hb-aat-layout.cc | 14 +-
- src/hb-aat.h | 673
- +++++++++++++++++-----------------------
+ src/hb-aat.h | 673 +++++++++++++++++-----------------------
test/api/test-aat-layout.c | 88 +++---
4 files changed, 423 insertions(+), 466 deletions(-)
@@ -5308,8 +6458,7 @@
src/hb-aat-layout-morx-table.hh | 2 +-
src/hb-aat-layout.cc | 104 ++++----
src/hb-aat-map.cc | 2 +-
- src/hb-aat.h | 533
- ++++++++++++----------------------------
+ src/hb-aat.h | 533 ++++++++++++----------------------------
src/hb-ot.h | 1 -
test/api/test-aat-layout.c | 84 +++----
8 files changed, 282 insertions(+), 528 deletions(-)
@@ -5322,8 +6471,7 @@
src/hb-aat-layout-morx-table.hh | 2 +-
src/hb-aat-layout.cc | 154 ++++-----
- src/hb-aat.h | 697
- ++++++++++++++++++++++++++++++++++++++--
+ src/hb-aat.h | 697 ++++++++++++++++++++++++++++++++++++++--
3 files changed, 752 insertions(+), 101 deletions(-)
commit fbad794bd2c574363a0c5c5fefabce764496f93c
@@ -5335,8 +6483,7 @@
src/hb-aat-layout-feat-table.hh | 36 +++++++++++++++++++++--------
src/hb-aat-layout.cc | 26 +++++++++++----------
src/hb-aat.h | 23 +++++++++++++++++--
- test/api/test-aat-layout.c | 51
- +++++++++++++++++++++++++++--------------
+ test/api/test-aat-layout.c | 51 +++++++++++++++++++++++++++--------------
4 files changed, 96 insertions(+), 40 deletions(-)
commit 7a0471aa356bcd062d31a59bdb19c335249116c7
@@ -5347,8 +6494,7 @@
src/hb-aat-layout-feat-table.hh | 20 ++---
src/hb-aat-layout-morx-table.hh | 10 +--
- src/hb-aat-layout.cc | 170
- ++++++++++++++++++++--------------------
+ src/hb-aat-layout.cc | 170 ++++++++++++++++++++--------------------
src/hb-aat-layout.hh | 6 +-
src/hb-aat-map.cc | 2 +-
src/hb-aat-map.hh | 4 +-
@@ -5415,7 +6561,7 @@
Date: Thu Nov 1 13:14:29 2018 +0330
[feat] Expose public API
-
+
* hb_aat_get_feature_settings
src/Makefile.sources | 1 +
@@ -5427,8 +6573,7 @@
src/hb-aat-map.hh | 5 ++-
src/hb-ot-face.hh | 1 +
test/api/Makefile.am | 1 +
- test/api/test-aat-layout.c | 89
- +++++++++++++++++++++++++++++++++++++++++
+ test/api/test-aat-layout.c | 89 +++++++++++++++++++++++++++++++++++++++++
test/api/test-c.c | 1 +
11 files changed, 278 insertions(+), 9 deletions(-)
@@ -5437,7 +6582,7 @@
Date: Sun Nov 25 00:30:08 2018 -0500
[test] Reorder test suites
-
+
aots is less interesting. Run text-rendering-tests before aots.
test/shaping/data/Makefile.am | 2 +-
@@ -5484,7 +6629,7 @@
Date: Sat Nov 24 23:38:06 2018 -0500
Add hb_sanitize_with_object_t
-
+
Context manager.
src/hb-machinery.hh | 17 +++++++++++++++++
@@ -5506,7 +6651,7 @@
Date: Sat Nov 24 23:12:28 2018 -0500
[aat] Skip terminator in VarSizedBinSearchArray<>
-
+
Fixes shaping with Apple Chancery on 10.13 again. In that font,
there was a terminator segment, that was tripping off sanitize().
@@ -5537,9 +6682,9 @@
Date: Sat Nov 24 22:16:59 2018 -0500
Revert "[aat.morx] Remove set_object() business"
-
+
This reverts commit ae8ed58a6e53441d9ccbf67afd8a00b815cde99e.
-
+
Apparently this broke Apple Chancery from OS X 10.12 :(.
Investigating...
@@ -5551,7 +6696,7 @@
Date: Sat Nov 24 22:16:53 2018 -0500
Revert "[aat.kerx] Remove kerx subtable boundary enforcement"
-
+
This reverts commit 15905a2a2998f7ddd964f920a4828602235d6b00.
src/hb-aat-layout-kerx-table.hh | 21 +++++++++++++++++++++
@@ -5562,7 +6707,7 @@
Date: Sat Nov 24 22:16:47 2018 -0500
Revert "[sanitize] Remove now-unused set_object() machinery"
-
+
This reverts commit bbdb6edb3e1cea4c5b7076c4f6b3e6998ae36dae.
src/hb-machinery.hh | 25 ++++++++++++++++++++++++-
@@ -5618,8 +6763,7 @@
test/shaping/data/in-house/Makefile.sources | 3 +--
.../data/in-house/tests/macos-10.12.6.tests | 11 ---------
.../data/in-house/tests/macos-10.13.6.tests | 13 -----------
- test/shaping/data/in-house/tests/macos.tests | 26
- ++++++++++++++++++++++
+ test/shaping/data/in-house/tests/macos.tests | 26 ++++++++++++++++++++++
4 files changed, 27 insertions(+), 26 deletions(-)
commit bbdb6edb3e1cea4c5b7076c4f6b3e6998ae36dae
@@ -5636,7 +6780,7 @@
Date: Sat Nov 24 17:14:39 2018 -0500
[aat.kerx] Remove kerx subtable boundary enforcement
-
+
Have not encountered fonts needing this, but same reasoning as
for morx (see previos commit.)
@@ -5648,12 +6792,12 @@
Date: Sat Nov 24 17:11:09 2018 -0500
[aat.morx] Remove set_object() business
-
+
With OS X 10.13 Apple Chancery fails to ligate if we limit each morx
sub-chain to its declared length. Perhaps their newer compiler does
object-sharing across sub-chains. Anyway, since that's a valid, if
unspecified, way to compile tables, remove enforcement.
-
+
Probably do the same with kern/kerx.
src/hb-aat-layout-morx-table.hh | 8 --------
@@ -5665,12 +6809,10 @@
Add 10.13.6 aat fonts tests and bot (#1409)
- .circleci/config.yml | 16
- ++++++++++++++--
+ .circleci/config.yml | 16 ++++++++++++++--
test/shaping/data/in-house/Makefile.sources | 3 ++-
.../in-house/tests/{macos.tests => macos-10.12.6.tests} | 2 --
- test/shaping/data/in-house/tests/macos-10.13.6.tests | 13
- +++++++++++++
+ test/shaping/data/in-house/tests/macos-10.13.6.tests | 13 +++++++++++++
4 files changed, 29 insertions(+), 5 deletions(-)
commit b7f7950e8fc4b9e229b466ac2453d57b8da9a5a6
@@ -5688,8 +6830,7 @@
[tests] Redo test runner logging a bit
- test/shaping/run-tests.py | 44
- +++++++++++++++++++++++---------------------
+ test/shaping/run-tests.py | 44 +++++++++++++++++++++++---------------------
1 file changed, 23 insertions(+), 21 deletions(-)
commit 5020affc3877d39377506245ecaf01a659eef82a
@@ -5706,7 +6847,7 @@
Date: Sat Nov 24 15:37:01 2018 -0500
[tests/shaping] Allow comments in test files
-
+
Line should start with "# ".
test/shaping/run-tests.py | 17 +++++++++++++++--
@@ -5718,8 +6859,7 @@
[tests] Rename
- test/shaping/data/in-house/Makefile.sources |
- 2 +-
+ test/shaping/data/in-house/Makefile.sources | 2 +-
test/shaping/data/in-house/tests/{macos-10.12.tests => macos.tests} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
@@ -5728,11 +6868,11 @@
Date: Sat Nov 24 14:52:34 2018 -0500
[morx/kerx] Fix sanitize regression
-
+
Broke in 8dcc1913a1670ede7b124f7b5b775d7ab8791386
-
+
If sanitizer is left with another object, it wouldn't work.
-
+
Better fix coming soon.
src/hb-aat-layout-kerx-table.hh | 6 +-----
@@ -5744,12 +6884,11 @@
Date: Sat Nov 24 20:49:21 2018 +0330
[test] Enable more of aots tests (#1408)
-
+
The ones commented out in this change should've be passed :/
a closer look is needed.
- test/shaping/data/aots/Makefile.sources | 76
- +++++++++++-----------
+ test/shaping/data/aots/Makefile.sources | 76 +++++++++++-----------
test/shaping/data/aots/hb-aots-tester.cpp | 1 +
test/shaping/data/aots/tests/classdef1_empty.tests | 2 +-
test/shaping/data/aots/tests/gsub3_1_simple.tests | 2 +-
@@ -5761,14 +6900,11 @@
Date: Sat Nov 24 20:07:24 2018 +0330
Add Adobe AOTS tests (#1395)
+
+ Annotated OpenType Specification or aots, https://github.com/adobe-type-tools/aots
+ provides a set of tests for OpenType specification, this change add those tests in addition
+ to modified version of their HarfBuzz test runner for generating harfbuzz project specific tests.
- Annotated OpenType Specification or aots,
- https://github.com/adobe-type-tools/aots
- provides a set of tests for OpenType specification, this change add
- those tests in addition
- to modified version of their HarfBuzz test runner for generating
- harfbuzz project specific tests.
-
configure.ac | 1 +
test/shaping/CMakeLists.txt | 13 +-
test/shaping/data/Makefile.am | 1 +
@@ -5978,8 +7114,7 @@
.../fonts/lookupflag_ignore_combination_f1.otf | Bin 0 -> 5408 bytes
.../aots/fonts/lookupflag_ignore_ligatures_f1.otf | Bin 0 -> 5320 bytes
.../data/aots/fonts/lookupflag_ignore_marks_f1.otf | Bin 0 -> 5288 bytes
- test/shaping/data/aots/hb-aots-tester.cpp | 343
- +++++++++++++++++++++
+ test/shaping/data/aots/hb-aots-tester.cpp | 343 +++++++++++++++++++++
test/shaping/data/aots/tests/classdef1.tests | 1 +
test/shaping/data/aots/tests/classdef1_empty.tests | 1 +
.../data/aots/tests/classdef1_multiple.tests | 1 +
@@ -6136,7 +7271,7 @@
Date: Sat Nov 24 10:06:13 2018 -0500
[arrays] Improve bfind() interface
-
+
Much more useful now. :)
src/hb-dsalgs.hh | 29 +++++++++++++++++++++++++----
@@ -6152,14 +7287,12 @@
Date: Sat Nov 24 09:49:21 2018 -0500
[fuzzing] Add tests for previous commit
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11526
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11522
- ...zz-testcase-minimized-hb-shape-fuzzer-5634620935110656 | Bin 0 ->
- 41 bytes
- ...zz-testcase-minimized-hb-shape-fuzzer-5716208469409792 | Bin 0 ->
- 243 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5634620935110656 | Bin 0 -> 41 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5716208469409792 | Bin 0 -> 243 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
commit 8dcc1913a1670ede7b124f7b5b775d7ab8791386
@@ -6235,8 +7368,7 @@
[arrays] Port SortedArrayOf.bsearch/bfind to hb_sorted_array_t's
src/hb-dsalgs.hh | 9 +++------
- src/hb-open-type.hh | 50
- ++++++++++----------------------------------------
+ src/hb-open-type.hh | 50 ++++++++++----------------------------------------
src/hb-vector.hh | 35 ++++++++++-------------------------
3 files changed, 23 insertions(+), 71 deletions(-)
@@ -6246,8 +7378,7 @@
[arrays] Port hb_vector_t.bsearch/bfind to (new) hb_sorted_array_t's
- src/hb-dsalgs.hh | 63
- +++++++++++++++++++++++++++++++++++++++++++++++++----
+ src/hb-dsalgs.hh | 63 +++++++++++++++++++++++++++++++++++++++++++++++++----
src/hb-open-type.hh | 12 ++++++----
src/hb-vector.hh | 57 +++++++++++++++++++-----------------------------
3 files changed, 89 insertions(+), 43 deletions(-)
@@ -6286,7 +7417,7 @@
Date: Sat Nov 24 00:58:44 2018 -0500
[arrays] Update ArrayOf.lsearch()
-
+
Currently unused apparently
src/hb-open-type.hh | 17 +++++++++++++----
@@ -6297,7 +7428,7 @@
Date: Sat Nov 24 00:53:19 2018 -0500
[arrays] Change argument type of cmp called by hb_vector_t.bsearch()
-
+
Towards consolidating all array bsearch/...
src/hb-aat-map.hh | 4 ++--
@@ -6310,11 +7441,9 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Thu Nov 15 17:40:21 2018 -0600
- Usermanual: clusters chapter; add brief grapheme definition and
- clarify monotonous cluster handling.
+ Usermanual: clusters chapter; add brief grapheme definition and clarify monotonous cluster handling.
- docs/usermanual-clusters.xml | 56
- ++++++++++++++++++++++++++++++--------------
+ docs/usermanual-clusters.xml | 56 ++++++++++++++++++++++++++++++--------------
1 file changed, 39 insertions(+), 17 deletions(-)
commit 939220e57da613e090d247aa1af2396c28370af4
@@ -6332,8 +7461,7 @@
Usermanual: expand clusters chapter.
- docs/usermanual-clusters.xml | 743
- +++++++++++++++++++++++++++----------------
+ docs/usermanual-clusters.xml | 743 +++++++++++++++++++++++++++----------------
1 file changed, 473 insertions(+), 270 deletions(-)
commit 30cb45b3eaacda15cc45435815cae3fd50e87557
@@ -6341,13 +7469,12 @@
Date: Sat Nov 24 00:35:31 2018 -0500
Change ArrayOf.bsearch() return semantics
-
+
Towards consolidating all array bsearch/...
src/hb-aat-layout-kerx-table.hh | 16 +++-------------
src/hb-open-file.hh | 12 ++++++++----
- src/hb-open-type.hh | 42
- ++++++++++++++++++++++++++++++++---------
+ src/hb-open-type.hh | 42 ++++++++++++++++++++++++++++++++---------
src/hb-ot-cmap-table.hh | 30 ++++++++++++-----------------
src/hb-ot-color-svg-table.hh | 3 +--
src/hb-ot-layout-common.hh | 29 +++++++++++-----------------
@@ -6477,7 +7604,7 @@
Date: Fri Nov 23 13:49:34 2018 -0500
Merge pull request #1407 from harfbuzz/at-sign
-
+
Don't canonicalize '@' to '-' in language tags
commit 018ba46e4d003a5dd0f6d2d899226129c4ef0c60
@@ -6485,7 +7612,7 @@
Date: Fri Nov 23 13:21:22 2018 -0500
Don't canonicalize '@' to '-' in language tags
-
+
Fixes #1406.
src/hb-common.cc | 2 +-
@@ -6506,9 +7633,9 @@
Date: Fri Nov 23 11:10:17 2018 -0500
[aat] Disable mark advance zeroing if kern table has state-machines
-
+
Geeza Pro for example, relies on that for fancy mark positioning.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1405
src/hb-aat-layout-kerx-table.hh | 15 +++++++++++++++
@@ -6533,13 +7660,11 @@
[aat] Add macOS specific tests (#1404)
- .circleci/config.yml | 46
- ++++++++++++++--------
+ .circleci/config.yml | 46 ++++++++++++++--------
test/shaping/CMakeLists.txt | 2 +
test/shaping/data/in-house/Makefile.sources | 1 +
test/shaping/data/in-house/tests/macos-10.12.tests | 10 +++++
- test/shaping/run-tests.py | 38
- ++++++++++++++----
+ test/shaping/run-tests.py | 38 ++++++++++++++----
5 files changed, 73 insertions(+), 24 deletions(-)
commit 22798e93c414a2655c757a6e41b300f67e04a9a3
@@ -6566,7 +7691,7 @@
Date: Thu Nov 22 22:39:12 2018 -0500
Merge pull request #1291 from harfbuzz/use-reordering
-
+
[use] Fix reordering
commit e4a4555d1e40dacdf72452805e9e6b6109627d63
@@ -6593,10 +7718,9 @@
Date: Thu Nov 22 22:12:36 2018 -0500
[sanitizer] Add reset_object(), make set_object() do bounds-check
+
+ Affects morx/kerx run-time only currently. Will adjust their sanitize next.
- Affects morx/kerx run-time only currently. Will adjust their
- sanitize next.
-
src/hb-aat-layout-kerx-table.hh | 1 +
src/hb-aat-layout-morx-table.hh | 1 +
src/hb-machinery.hh | 30 +++++++++++++++++++-----------
@@ -6607,13 +7731,12 @@
Date: Thu Nov 22 22:02:19 2018 -0500
[kerx] Make sure subtables are non-zero-length
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11400
src/hb-aat-layout-kerx-table.hh | 1 +
src/hb-aat-layout-morx-table.hh | 2 +-
- ...z-testcase-minimized-hb-shape-fuzzer-5722888989048832 | Bin 0 ->
- 3608 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5722888989048832 | Bin 0 -> 3608 bytes
3 files changed, 2 insertions(+), 1 deletion(-)
commit a9e0bdc35dfcbead7d4b6fa249d60ebedd7d43ca
@@ -6621,9 +7744,9 @@
Date: Thu Nov 22 21:30:04 2018 -0500
[GSUB] Don't flush glyphset during recursion in closure()
-
+
See comment.
-
+
Supercedes https://github.com/harfbuzz/harfbuzz/pull/1401
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11366
@@ -6636,8 +7759,7 @@
[subset] add fuzzer testcase.
- ...z-testcase-minimized-hb-subset-fuzzer-5067936541179904 | Bin 0 ->
- 172 bytes
+ ...z-testcase-minimized-hb-subset-fuzzer-5067936541179904 | Bin 0 -> 172 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit d0e81b2cc85d09d01905c5fc5b3382c25eaa3bb3
@@ -6654,7 +7776,7 @@
Date: Thu Nov 22 18:07:59 2018 -0500
Enforce requiring null_size even if min_size is 0
-
+
This concludes null-size enforcement changes
src/hb-null.hh | 2 +-
@@ -6674,7 +7796,7 @@
Date: Thu Nov 22 17:56:51 2018 -0500
[glyf] Don't mark structs UNBOUNDED
-
+
See comments.
src/hb-ot-glyf-table.hh | 8 ++++++--
@@ -6685,7 +7807,7 @@
Date: Thu Nov 22 17:53:29 2018 -0500
Mark UnsizedArrayOf<> as UNBOUNDED
-
+
Since min_size is 0, Null() still accepts this type.
src/hb-open-type.hh | 3 ++-
@@ -6714,9 +7836,8 @@
Date: Thu Nov 22 16:20:29 2018 -0500
[aat] Zero mark advances if decided so even if there's cross-kerning
-
- Cross-kerning can only take care of positioning vertically.
- It doesn't
+
+ Cross-kerning can only take care of positioning vertically. It doesn't
adjust mark advance...
src/hb-ot-shape.cc | 2 +-
@@ -6727,16 +7848,13 @@
Date: Thu Nov 22 15:52:29 2018 -0500
[aat] Tweak fallback positioning logic when applying morx
-
- Such that for Indic-like scripts (eg. Khmer), we don't do any
- fallback mark
- advance-zeroing / positioning, but we do for Latin, etc. Reuses
- preferences
+
+ Such that for Indic-like scripts (eg. Khmer), we don't do any fallback mark
+ advance-zeroing / positioning, but we do for Latin, etc. Reuses preferences
of our script-specific OpenType shapers for those.
-
+
Fixes regression: https://github.com/harfbuzz/harfbuzz/issues/1393
- Which means, fixes again:
- https://github.com/harfbuzz/harfbuzz/issues/1264
+ Which means, fixes again: https://github.com/harfbuzz/harfbuzz/issues/1264
While not regressing: https://github.com/harfbuzz/harfbuzz/issues/1357
src/hb-ot-shape.cc | 38 +++++++++++++++++++++++---------------
@@ -6757,7 +7875,7 @@
Date: Thu Nov 22 14:45:46 2018 -0500
[myanmar] If there's no GSUB table, pick myanmar shaper
-
+
Needed for morx+kern mark-zeroing interaction. All other scripts
work this way.
@@ -6769,7 +7887,7 @@
Date: Thu Nov 22 14:41:01 2018 -0500
[myanmar] Remove myanmar_old shaper
-
+
Over time it has become the same as default shaper. So, remove.
src/hb-ot-shape-complex-myanmar.cc | 21 ---------------------
@@ -6781,10 +7899,9 @@
Date: Thu Nov 22 01:53:36 2018 -0500
Fix spurious gcc warnings
+
+ ../../src/hb-null.hh:53:39: warning: enum constant in boolean context [-Wint-in-bool-context]
- ../../src/hb-null.hh:53:39: warning: enum constant in boolean context
- [-Wint-in-bool-context]
-
src/hb-null.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -6793,14 +7910,12 @@
Date: Thu Nov 22 01:49:12 2018 -0500
More
-
+
This makes more of the gcc spurious warning:
-
- ../../src/hb-null.hh:53:39: warning: enum constant in boolean context
- [-Wint-in-bool-context]
-
- But not going to let that defeat correct code. Type to switch
- to clang
+
+ ../../src/hb-null.hh:53:39: warning: enum constant in boolean context [-Wint-in-bool-context]
+
+ But not going to let that defeat correct code. Type to switch to clang
as my main compiler...
src/hb-blob.hh | 2 +-
@@ -6811,7 +7926,7 @@
Date: Thu Nov 22 01:44:27 2018 -0500
Fix up recent change
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1300
src/hb-null.hh | 12 +++++++++---
@@ -6842,9 +7957,9 @@
Date: Thu Nov 22 01:18:55 2018 -0500
Disallow taking Null() of unbounded structs
-
+
Not sure I've marked all such structs. To be done as we discover.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1300
src/hb-aat-layout-common.hh | 2 +-
@@ -6857,8 +7972,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Nov 22 01:10:22 2018 -0500
- Use Type::null_size for our structs in Null(), sizeof() for other
- types
+ Use Type::null_size for our structs in Null(), sizeof() for other types
src/hb-null.hh | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)
@@ -6877,7 +7991,7 @@
Date: Thu Nov 22 00:39:14 2018 -0500
Fix bots happy again, hopefully
-
+
So, our fallback static_assert cannot be had more than once per line
of source.
@@ -6889,9 +8003,9 @@
Date: Thu Nov 22 00:21:49 2018 -0500
Revert alignof() == 1 check
-
+
Bots not happy with using "this" inside assertion...
-
+
This reverts 2656644887e77a9d814bb12374af3c26b42fd935
src/hb-machinery.hh | 12 ++++--------
@@ -6969,7 +8083,7 @@
Date: Wed Nov 21 17:27:27 2018 -0500
Merge pull request #1400 from harfbuzz/sharada-sandhi-mark
-
+
Test U+111C9 SHARADA SANDHI MARK
commit 264439c6c308ac5f01c4ba4faf64daa2d642236a
@@ -6978,8 +8092,7 @@
Test U+111C9 SHARADA SANDHI MARK
- .../fonts/86cdd983c4e4c4d7f27dd405d6ceb7d4b9ed3d35.ttf | Bin 0 ->
- 968 bytes
+ .../fonts/86cdd983c4e4c4d7f27dd405d6ceb7d4b9ed3d35.ttf | Bin 0 -> 968 bytes
test/shaping/data/in-house/tests/use-syllable.tests | 1 +
2 files changed, 1 insertion(+)
@@ -6989,7 +8102,7 @@
Date: Wed Nov 21 16:12:32 2018 -0500
Merge pull request #1399 from harfbuzz/sharada-sandhi-mark
-
+
Fix USE categories for U+111C9 SHARADA SANDHI MARK
commit b89c7fd3dc505a958dd4b6acec0e0f8e57224fd8
@@ -6997,10 +8110,9 @@
Date: Wed Nov 21 12:32:48 2018 -0500
Allow defining HB_USE_ATEXIT to 0
+
+ That's better use of that value than requiring extra macro HB_NO_ATEXIT
- That's better use of that value than requiring extra macro
- HB_NO_ATEXIT
-
src/hb-common.cc | 10 +++++-----
src/hb-ft.cc | 12 ++++++------
src/hb-glib.cc | 6 +++---
@@ -7028,14 +8140,14 @@
Date: Tue Nov 20 20:40:55 2018 -0500
[var] Deprecated axis enumeration API and add new version
-
+
New version has axis flags.
-
+
New API:
+hb_ot_var_axis_info_t
+hb_ot_var_find_axis_info()
+hb_ot_var_get_axis_infos()
-
+
Deprecated API:
-HB_OT_VAR_NO_AXIS_INDEX
-hb_ot_var_axis_t
@@ -7044,8 +8156,7 @@
docs/harfbuzz-sections.txt | 14 +++---
src/hb-deprecated.h | 37 +++++++++++++++
- src/hb-ot-var-fvar-table.hh | 112
- ++++++++++++++++++++++++++++++++------------
+ src/hb-ot-var-fvar-table.hh | 112 ++++++++++++++++++++++++++++++++------------
src/hb-ot-var.cc | 43 ++++++++++++++---
src/hb-ot-var.h | 61 ++++++++++++------------
test/api/test-ot-face.c | 2 +-
@@ -7093,7 +8204,7 @@
Date: Tue Nov 20 16:29:30 2018 -0500
Merge pull request #1397 from harfbuzz/small-emoji-table
-
+
Shrink the emoji table by merging adjacent ranges
commit 82951182799772a642d32195dd87e6f0c116f545
@@ -7103,8 +8214,7 @@
Shrink the emoji table by merging adjacent ranges
src/gen-emoji-table.py | 13 +--
- src/hb-unicode-emoji-table.hh | 189
- ++++--------------------------------------
+ src/hb-unicode-emoji-table.hh | 189 ++++--------------------------------------
2 files changed, 23 insertions(+), 179 deletions(-)
commit be1828daaa1e1a72d971aed8d34fff54688d0f41
@@ -7112,7 +8222,7 @@
Date: Tue Nov 20 11:16:23 2018 -0500
[var] Fix type of coords returned
-
+
Ouch. Wonder how none of the bots caught the float->int truncation.
src/hb-ot-var-fvar-table.hh | 2 +-
@@ -7174,11 +8284,10 @@
Date: Sat Oct 20 15:02:26 2018 -0400
[use] Fix reordering
-
+
Fixes #1235.
- src/hb-ot-shape-complex-use.cc | 48
- ++++++++++++++-------
+ src/hb-ot-shape-complex-use.cc | 48 ++++++++++++++-------
src/hb.hh | 2 +
.../4afb0e8b9a86bb9bd73a1247de4e33fbe3c1fd93.ttf | Bin 0 -> 1824 bytes
test/shaping/data/in-house/tests/use.tests | 3 ++
@@ -7189,12 +8298,11 @@
Date: Mon Nov 19 14:27:19 2018 -0500
[fvar] Add named-instance API
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1241
docs/harfbuzz-sections.txt | 4 ++++
- src/hb-ot-var-fvar-table.hh | 55
- ++++++++++++++++++++++++++++++++++++++++++---
+ src/hb-ot-var-fvar-table.hh | 55 ++++++++++++++++++++++++++++++++++++++++++---
src/hb-ot-var.cc | 33 +++++++++++++++++++++++++++
src/hb-ot-var.h | 32 ++++++++++++++++++++++++++
4 files changed, 121 insertions(+), 3 deletions(-)
@@ -7241,9 +8349,9 @@
Date: Mon Nov 19 12:36:56 2018 -0500
[ot-var] Add hb_ot_var_axis_get_flags()
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1241
-
+
New API:
+hb_ot_var_axis_flags_t
+hb_ot_var_axis_get_flags
@@ -7260,10 +8368,9 @@
Date: Mon Nov 19 11:34:56 2018 -0500
[ot-var] Add flags
+
+ Unfortunate that we don't have room in hb_ot_var_axis_t to expose flags :(.
- Unfortunate that we don't have room in hb_ot_var_axis_t to expose
- flags :(.
-
src/hb-ot-var-fvar-table.hh | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
@@ -7317,13 +8424,12 @@
Date: Fri Nov 16 16:48:28 2018 -0800
Revert b4c61130324455bfd42095b01fa14ac901e441f1
-
- Was causing more trouble than it solved. We use unsigned for
- indexing,
+
+ Was causing more trouble than it solved. We use unsigned for indexing,
and it's not helpful to allow that wrapping to negative integers on
32bit machines. The only way we could work around it would have been
by accepting int64_t arg, but that's overkill.
-
+
Ignore the MSVC 2008 build issue. We don't support that compiler.
src/hb-open-type.hh | 17 ++++-------------
@@ -7334,16 +8440,13 @@
Date: Fri Nov 16 16:41:59 2018 -0800
Detect over/under-flow in UnsizedArray::operator[]
-
- Was causing bad substitutions in mort table because of
- WordOffsetToIndex()
- producing negative numbers that were cast to unsigned int and
- returned as
- large numbers (which was desirable, so they would be rejected),
- but then
+
+ Was causing bad substitutions in mort table because of WordOffsetToIndex()
+ producing negative numbers that were cast to unsigned int and returned as
+ large numbers (which was desirable, so they would be rejected), but then
they were cast to int when passed to this operator and acting as small
negative integers, which was bad...
-
+
Detect overflow. Ouch, however, now I see this still fails on 32-bit.
Guess I'm going to revert an earlier change.
@@ -7355,7 +8458,7 @@
Date: Fri Nov 16 16:11:02 2018 -0800
[aat] Fix mort shaping
-
+
Ouch!
src/hb-aat-layout.cc | 2 +-
@@ -7377,11 +8480,11 @@
Date: Fri Nov 16 15:04:41 2018 -0800
Fix vertical fallback space sign
-
+
Ouch!
-
+
Follow-up to cf203af8a33591c163b63dbdf0fd341bc4606190
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1343
src/hb-ot-shape-fallback.cc | 8 ++++----
@@ -7393,10 +8496,9 @@
Date: Fri Nov 16 14:46:40 2018 -0800
Don't apply GPOS if applying morx
-
- That's what Apple does, and it wouldn't degrade our OpenType
- performance.
-
+
+ That's what Apple does, and it wouldn't degrade our OpenType performance.
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1348
src/hb-ot-shape.cc | 2 +-
@@ -7407,7 +8509,7 @@
Date: Fri Nov 16 14:45:56 2018 -0800
Prefer morx table if GSUB is empty (no scripts)
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1348
src/hb-ot-shape.cc | 6 +++++-
@@ -7534,8 +8636,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Nov 16 02:29:13 2018 -0500
- [shaper] Rewrite shaper data code to be more template-driven than
- macro-driven
+ [shaper] Rewrite shaper data code to be more template-driven than macro-driven
src/hb-coretext.cc | 17 +++----
src/hb-directwrite.cc | 9 +---
@@ -7549,8 +8650,7 @@
src/hb-ot-shape.cc | 5 --
src/hb-shape-plan.cc | 4 +-
src/hb-shaper-impl.hh | 9 +---
- src/hb-shaper.hh | 117
- ++++++++++++++++++++++++++++++++---------------
+ src/hb-shaper.hh | 117 ++++++++++++++++++++++++++++++++---------------
src/hb-uniscribe.cc | 32 +++++--------
14 files changed, 127 insertions(+), 147 deletions(-)
@@ -7559,7 +8659,7 @@
Date: Fri Nov 16 02:02:24 2018 -0500
[hdmx] Fix bounds checking
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11351
src/hb-ot-hdmx-table.hh | 11 +++++------
@@ -7579,7 +8679,7 @@
Date: Fri Nov 16 01:48:26 2018 -0500
[subset] Remove invalid glyphs from glypset to retain
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/1388
src/hb-subset-plan.cc | 13 +++++++++++++
@@ -7590,31 +8690,20 @@
Date: Thu Nov 15 15:41:46 2018 -0800
use 2-byte offset instead of 4-byte for local subrs
-
- more than enough since local subrs immediately follow its
- corresponding private dict, as the result 2-byte redunction for each
- font dict with local subrs
+
+ more than enough since local subrs immediately follow its corresponding private dict, as the result 2-byte redunction for each font dict with local subrs
updated api test expected subset fonts accordingly
src/hb-subset-cff-common.hh | 4 ++--
- test/api/fonts/AdobeVFPrototype.abc.otf | Bin 7460 ->
- 7456 bytes
- test/api/fonts/AdobeVFPrototype.ac.nohints.otf | Bin 6780 ->
- 6780 bytes
- test/api/fonts/AdobeVFPrototype.ac.otf | Bin 6996 ->
- 6996 bytes
- .../fonts/SourceHanSans-Regular.41,4C2E.nohints.otf | Bin 2380 ->
- 2376 bytes
- test/api/fonts/SourceHanSans-Regular.41,4C2E.otf | Bin 2576 ->
- 2572 bytes
- test/api/fonts/SourceSansPro-Regular.abc.otf | Bin 1812 ->
- 1808 bytes
- test/api/fonts/SourceSansPro-Regular.ac.nohints.otf | Bin 1592 ->
- 1592 bytes
- test/api/fonts/SourceSansPro-Regular.ac.otf | Bin 1708 ->
- 1704 bytes
- test/api/fonts/cff1_seac.C0.otf | Bin 1604 ->
- 1600 bytes
+ test/api/fonts/AdobeVFPrototype.abc.otf | Bin 7460 -> 7456 bytes
+ test/api/fonts/AdobeVFPrototype.ac.nohints.otf | Bin 6780 -> 6780 bytes
+ test/api/fonts/AdobeVFPrototype.ac.otf | Bin 6996 -> 6996 bytes
+ .../fonts/SourceHanSans-Regular.41,4C2E.nohints.otf | Bin 2380 -> 2376 bytes
+ test/api/fonts/SourceHanSans-Regular.41,4C2E.otf | Bin 2576 -> 2572 bytes
+ test/api/fonts/SourceSansPro-Regular.abc.otf | Bin 1812 -> 1808 bytes
+ test/api/fonts/SourceSansPro-Regular.ac.nohints.otf | Bin 1592 -> 1592 bytes
+ test/api/fonts/SourceSansPro-Regular.ac.otf | Bin 1708 -> 1704 bytes
+ test/api/fonts/cff1_seac.C0.otf | Bin 1604 -> 1600 bytes
10 files changed, 2 insertions(+), 2 deletions(-)
commit 9d0231cfe7c404da3b5bc360ad76180a7aded62c
@@ -7637,8 +8726,7 @@
src/hb-open-type.hh | 70 ++++++------
src/hb-ot-cmap-table.hh | 182 +++++++++++++++----------------
- src/hb-ot-glyf-table.hh | 242
- ++++++++++++++++++++---------------------
+ src/hb-ot-glyf-table.hh | 242 ++++++++++++++++++++---------------------
src/hb-ot-hdmx-table.hh | 20 ++--
src/hb-ot-hmtx-table.hh | 14 +--
src/hb-ot-layout-common.hh | 77 ++++++-------
@@ -7726,8 +8814,7 @@
src/hb-aat-layout.hh | 6 +++---
src/hb-ot-layout.cc | 2 +-
src/hb-ot-layout.hh | 2 +-
- src/hb-ot-shape.cc | 44
- +++++++++++++++++++++++++++++---------------
+ src/hb-ot-shape.cc | 44 +++++++++++++++++++++++++++++---------------
src/hb-ot-shape.hh | 6 +++---
7 files changed, 43 insertions(+), 29 deletions(-)
@@ -7744,8 +8831,7 @@
Implemented seac for extents & subset along with API tests
- gtk-doc.make | 321
- +++++++++++++++++++++++++++++++++++++++-
+ gtk-doc.make | 321 +++++++++++++++++++++++++++++++++++++++-
src/hb-cff-interp-common.hh | 2 +-
src/hb-cff-interp-cs-common.hh | 7 +
src/hb-cff1-interp-cs.hh | 29 +++-
@@ -7768,8 +8854,7 @@
src/hb-ot-face.hh | 2 +
src/hb-ot-font.cc | 4 +-
src/hb-ot-hmtx-table.hh | 11 +-
- src/hb-ot-stat-table.hh | 280
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-stat-table.hh | 280 ++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 290 insertions(+), 8 deletions(-)
commit 48d16c2ab2b181c733accd4fd9730963e59b6323
@@ -7777,10 +8862,9 @@
Date: Wed Nov 14 09:56:30 2018 -0500
[hmtx] Fix signedness issue
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1248#issuecomment-438689499
- Fixes
- https://github.com/harfbuzz/harfbuzz/issues/1248#issuecomment-438689499
-
src/hb-ot-hmtx-table.hh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
@@ -7799,7 +8883,7 @@
Date: Wed Nov 14 08:29:17 2018 +0330
Merge pull request #1383 from punchcutter/master
-
+
Add test for https://github.com/harfbuzz/harfbuzz/issues/1379
commit e543e1a0858bb5d7384d82600a789d40b62d9821
@@ -7808,8 +8892,7 @@
Add Grantha test
- .../fonts/dcf774ca21062e7439f98658b18974ea8b956d0c.ttf | Bin 0 ->
- 2568 bytes
+ .../fonts/dcf774ca21062e7439f98658b18974ea8b956d0c.ttf | Bin 0 -> 2568 bytes
test/shaping/data/in-house/tests/use.tests | 1 +
2 files changed, 1 insertion(+)
@@ -7817,9 +8900,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue Nov 13 21:10:10 2018 -0500
- [aat] Disable fallback mark advance zeroing and positioning if
- morx applied
-
+ [aat] Disable fallback mark advance zeroing and positioning if morx applied
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1357
src/hb-ot-shape.cc | 4 ++--
@@ -7830,9 +8912,8 @@
Date: Tue Nov 13 20:48:46 2018 -0500
Don't retry creating again and again in lazy_loader if create failed
-
- Still does that if get_null() returns nullptr. Our shaper data
- objects
+
+ Still does that if get_null() returns nullptr. Our shaper data objects
are like that. Shrug.
src/hb-machinery.hh | 14 ++++++++++----
@@ -7844,7 +8925,7 @@
Date: Tue Nov 13 19:50:25 2018 -0500
Merge pull request #1382 from punchcutter/master
-
+
Change USE Category for Grantha Virama
commit 2092f595c7a4c591cace41cb99d31620fa6d5fa4
@@ -7853,7 +8934,7 @@
Date: Tue Nov 13 19:49:06 2018 -0500
Merge pull request #1380 from kbrow1i/cygwin
-
+
Don't use Win32 API on Cygwin
commit c565fc3fb3b14c02e30af28b9d4d4289b0d2e162
@@ -7894,7 +8975,7 @@
Date: Tue Nov 13 11:45:12 2018 -0500
Make atomic types' internal values non-mutable
-
+
This resulted from confusion previously...
src/hb-atomic.hh | 10 +++++-----
@@ -7917,7 +8998,7 @@
Date: Mon Nov 12 21:05:39 2018 -0500
Don't use Win32 API on Cygwin
-
+
Cygwin is a Posix platform to the extent possible. It should use the
Posix API except in special circumstances.
@@ -7942,12 +9023,11 @@
Date: Mon Nov 12 19:26:01 2018 -0500
[shape-plan] Implement fine-grained caching plans with user-features
-
+
Only tag, value, and global-ness of features are considered, not their
start/end offsets.
- src/hb-shape-plan.cc | 69
- ++++++++++++++++++++++++++++++----------------------
+ src/hb-shape-plan.cc | 69 ++++++++++++++++++++++++++++++----------------------
src/hb-shape-plan.hh | 17 ++-----------
2 files changed, 42 insertions(+), 44 deletions(-)
@@ -7955,8 +9035,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Mon Nov 12 18:48:10 2018 -0500
- [shape-plan] Cache shape plans with variations based on variation
- indices
+ [shape-plan] Cache shape plans with variations based on variation indices
src/hb-aat-map.cc | 4 +---
src/hb-aat-map.hh | 4 +---
@@ -7964,8 +9043,7 @@
src/hb-ot-map.hh | 6 +++---
src/hb-ot-shape.cc | 13 +++++--------
src/hb-ot-shape.hh | 28 +++++++++++++++++++++++---
- src/hb-shape-plan.cc | 55
- ++++------------------------------------------------
+ src/hb-shape-plan.cc | 55 ++++------------------------------------------------
src/hb-shape-plan.hh | 23 ++++++++++++++++++----
8 files changed, 63 insertions(+), 88 deletions(-)
@@ -7983,7 +9061,7 @@
Date: Mon Nov 12 18:05:02 2018 -0500
[shape-plan] Only use shape-plan key to initialize hb_ot_shape_plan_t
-
+
Such that we don't accidentally use info not in the cache key.
src/hb-ot-shape.cc | 25 +++++++++++--------------
@@ -8006,8 +9084,7 @@
[shape-plan] Refactor some more
- src/hb-shape-plan.cc | 147
- ++++++++++++++++++++++++++++-----------------------
+ src/hb-shape-plan.cc | 147 ++++++++++++++++++++++++++++-----------------------
src/hb-shape-plan.hh | 15 ++++++
2 files changed, 95 insertions(+), 67 deletions(-)
@@ -8025,11 +9102,10 @@
Date: Mon Nov 12 17:19:45 2018 -0500
[shape-plan] Turn hb_shape_plan_proposal_t into hb_shape_plan_key_t
-
+
And include it in hb_shape_plan_t itself.
- src/hb-shape-plan.cc | 206
- +++++++++++++++++++--------------------------------
+ src/hb-shape-plan.cc | 206 +++++++++++++++++++--------------------------------
src/hb-shape-plan.hh | 27 +++----
2 files changed, 92 insertions(+), 141 deletions(-)
@@ -8071,8 +9147,7 @@
[fuzzing] Add new test
- ...zz-testcase-minimized-hb-shape-fuzzer-5754863779053568 | Bin 0 ->
- 100 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5754863779053568 | Bin 0 -> 100 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 274f4c726f461f49f54a79557d63bf95d22903cf
@@ -8105,7 +9180,7 @@
Date: Mon Nov 12 14:11:29 2018 -0500
[kerx] Fix integer overflow in multiply
-
+
Fixes https://oss-fuzz.com/v2/testcase-detail/5754863779053568
src/hb-aat-layout-kerx-table.hh | 2 +-
@@ -8126,9 +9201,9 @@
Date: Mon Nov 12 13:21:14 2018 -0500
[fuzzing] Remove limited-edition build of libraries
-
+
Use normal, production, shared libraries.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1237
src/Makefile.am | 31 -------------------------------
@@ -8140,12 +9215,11 @@
Date: Mon Nov 12 13:01:22 2018 -0500
[kerx] Protect against stack underflow
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11367
src/hb-aat-layout-kerx-table.hh | 2 +-
- ...uzz-testcase-minimized-hb-shape-fuzzer-5691469793329152 | Bin 0 ->
- 69 bytes
+ ...uzz-testcase-minimized-hb-shape-fuzzer-5691469793329152 | Bin 0 -> 69 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
commit 41a8bc7fd9399def8f580b02627a77f3972cc0e9
@@ -8208,10 +9282,9 @@
Date: Sun Nov 11 22:08:48 2018 -0500
Add variation coords to shape_plan proposal
-
- This is the root cause of bug worked around in
- 19e77e01bc13f44138e1d50533327d314dd0a018.
-
+
+ This is the root cause of bug worked around in 19e77e01bc13f44138e1d50533327d314dd0a018.
+
Still no shape plan caching for variations though.
src/hb-shape-plan.cc | 2 ++
@@ -8231,7 +9304,7 @@
Date: Sun Nov 11 21:32:01 2018 -0500
Embed hb_ot_shape_plan_t into hb_shape_plan_t
-
+
No other shaper will need shape_plan_data, by definition. So, remove
abstraction layer and always create hb_ot_shape_plan_t as part of
hb_shape_plan_t.
@@ -8240,8 +9313,7 @@
src/hb-directwrite.cc | 21 ----------
src/hb-fallback-shape.cc | 22 -----------
src/hb-graphite2.cc | 22 -----------
- src/hb-ot-shape.cc | 99
- ++++++++++++++++++++++--------------------------
+ src/hb-ot-shape.cc | 99 ++++++++++++++++++++++--------------------------
src/hb-ot-shape.hh | 21 +++++-----
src/hb-shape-plan.cc | 22 ++++++-----
src/hb-shape-plan.hh | 3 +-
@@ -8296,12 +9368,11 @@
Date: Sun Nov 11 16:09:38 2018 -0500
Revert "Declare Null() constexpr"
-
+
This reverts commit 442a72d95ab1fb3a47b486d8d1eb68e909d0ffb8.
+
+ Doesn't make sense. No idea how my local compilers where happy with it!
- Doesn't make sense. No idea how my local compilers where happy
- with it!
-
src/hb-null.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -8328,7 +9399,7 @@
Date: Sun Nov 11 15:48:47 2018 -0500
Don't store to null object
-
+
Ouch :).
src/hb-machinery.hh | 9 ++++-----
@@ -8349,8 +9420,7 @@
[hdmx] Renames
- src/hb-ot-hdmx-table.hh | 46
- +++++++++++++++++++++++-----------------------
+ src/hb-ot-hdmx-table.hh | 46 +++++++++++++++++++++++-----------------------
1 file changed, 23 insertions(+), 23 deletions(-)
commit da6aa3b0333de3f2169a5cfcb33374e1b2fe346e
@@ -8387,7 +9457,7 @@
Date: Sun Nov 11 00:28:47 2018 -0500
[cmap] Port to hb_blob_ptr_t
-
+
Although didn't need it...
src/hb-ot-cmap-table.hh | 7 +++----
@@ -8398,7 +9468,7 @@
Date: Sun Nov 11 00:26:55 2018 -0500
[color] Port to hb_blob_ptr_t
-
+
Fix hb_blob_ptr_t::get_length () as well.
src/hb-blob.hh | 2 +-
@@ -8432,7 +9502,7 @@
Date: Sun Nov 11 00:15:08 2018 -0500
[shape-plan] Make null object all zeros
-
+
To remove custom null object next..
src/hb-shape-plan.cc | 8 ++++----
@@ -8454,10 +9524,10 @@
Date: Sun Nov 11 00:11:28 2018 -0500
[blob] Change null object memory mode to DUPLICATE
-
+
We never rely on that being equal to readonly. Just not being
writable. Maybe not even that given that the object is inert.
-
+
In prep for next commit, using default null pool.
src/hb-blob.cc | 2 +-
@@ -8468,9 +9538,8 @@
Date: Sat Nov 10 23:52:15 2018 -0500
Add hb_blob_ptr_t
-
- Use in a couple of places. Push to bots to see how many unhappy
- before
+
+ Use in a couple of places. Push to bots to see how many unhappy before
I convert the rest.
src/hb-blob.hh | 23 +++++++++++++++++++++++
@@ -8494,13 +9563,12 @@
Date: Sat Nov 10 21:13:13 2018 -0500
[kerx] Fix Format1 tupleKern sanitization
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11312
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11305
src/hb-aat-layout-kerx-table.hh | 6 +++---
- ...uzz-testcase-minimized-hb-shape-fuzzer-5629524117553152 | Bin 0 ->
- 93 bytes
+ ...uzz-testcase-minimized-hb-shape-fuzzer-5629524117553152 | Bin 0 -> 93 bytes
2 files changed, 3 insertions(+), 3 deletions(-)
commit f9e0552debc45afedd86c848484bcd169af62dc2
@@ -8536,9 +9604,9 @@
Date: Sat Nov 10 19:54:08 2018 -0500
Better fix for MSVC 2008
-
+
Follow up on b4c61130324455bfd42095b01fa14ac901e441f1
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1374
src/hb-machinery.hh | 8 ++++----
@@ -8560,7 +9628,7 @@
Date: Sat Nov 10 16:35:39 2018 -0500
Try fixing MSVC 2008 build
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1374
src/hb-open-type.hh | 12 ++++++++++--
@@ -8589,9 +9657,9 @@
Date: Sat Nov 10 15:54:33 2018 -0500
Revert back hb_bytes_t.cmp() to the scheme it was
-
+
But fix UBSan complaint.
-
+
There's nothing in hb_bytes_t that guarantees lexical ordering, and
ordering by length first is much faster.
@@ -8612,7 +9680,7 @@
Date: Sat Nov 10 15:38:48 2018 -0500
Fix hb_bytes_t.cmp()
-
+
Ouch!
src/hb-dsalgs.hh | 8 +++++---
@@ -8624,7 +9692,7 @@
Date: Sat Nov 10 15:35:12 2018 -0500
Merge pull request #1376 from ebraminio/minor
-
+
[colr/feat/trak] minor
commit 1d82b4761d0a2e2e0be002e8a6bfe060f7b6dec3
@@ -8643,15 +9711,13 @@
Date: Sat Nov 10 01:56:37 2018 -0500
[qsort] Fix O(N^2) behavior if all array elements are the same
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11327
-
+
Reported as https://github.com/noporpoise/sort_r/issues/7
- src/hb-dsalgs.hh | 15
- +++++++++++----
- ...-testcase-minimized-hb-shape-fuzzer-5634443633491968 | Bin 0 ->
- 41814 bytes
+ src/hb-dsalgs.hh | 15 +++++++++++----
+ ...-testcase-minimized-hb-shape-fuzzer-5634443633491968 | Bin 0 -> 41814 bytes
2 files changed, 11 insertions(+), 4 deletions(-)
commit b308aaccf0773e252880b9b887f3d3d1dec00168
@@ -8695,7 +9761,7 @@
Date: Fri Nov 9 08:59:18 2018 -0800
fixed vstem handling (lack thereof) in check_width
-
+
bug exposed by U+2261 equivalence in SourceCodePro-Regular.otf
src/hb-cff1-interp-cs.hh | 5 ++++-
@@ -8706,7 +9772,7 @@
Date: Fri Nov 9 10:01:50 2018 -0500
Fix a few MSVC 2008 warnings
-
+
https://github.com/harfbuzz/harfbuzz/issues/1374
src/hb-set.hh | 4 ++--
@@ -8719,7 +9785,7 @@
Date: Thu Nov 8 14:42:40 2018 -0500
Merge pull request #1358 from ebraminio/lcar
-
+
Hook AAT's lcar to _get_ligature_carets
commit b986fead0aee52d219ce85dd49c9109bfaf31801
@@ -8729,8 +9795,7 @@
Hook AAT's lcar to _get_ligature_carets
src/Makefile.sources | 1 +
- src/hb-aat-layout-lcar-table.hh | 92
- +++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-lcar-table.hh | 92 +++++++++++++++++++++++++++++++++++++
src/hb-ot-face.hh | 1 +
src/hb-ot-layout-gdef-table.hh | 6 +--
src/hb-ot-layout.cc | 17 ++++---
@@ -8756,8 +9821,7 @@
test/shaping/data/text-rendering-tests/DISABLED | 1 +
test/shaping/data/text-rendering-tests/Makefile.sources | 2 +-
- .../data/text-rendering-tests/tests/MORX-31.tests | 16
- ++++++++--------
+ .../data/text-rendering-tests/tests/MORX-31.tests | 16 ++++++++--------
3 files changed, 10 insertions(+), 9 deletions(-)
commit b989507fa6b36eb9950001d4e28f3946ffbe75f9
@@ -8791,12 +9855,11 @@
Date: Thu Nov 8 19:17:02 2018 +0330
[just] Initial table implementation (#1364)
-
+
A starting point, its sanitization is not tested however
src/Makefile.sources | 1 +
- src/hb-aat-layout-just-table.hh | 416
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-just-table.hh | 416 ++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 1 +
3 files changed, 418 insertions(+)
@@ -8806,8 +9869,7 @@
[aat] Support Lookup<OffsetTo<>>, needed by just and lcar (#1368)
- src/hb-aat-layout-common.hh | 57
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-common.hh | 57 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-open-type.hh | 11 +++++++++
2 files changed, 68 insertions(+)
@@ -8825,7 +9887,7 @@
Date: Wed Nov 7 21:58:04 2018 -0500
[aat] Ignore cross-stream offset of deleted-glyphs
-
+
I think it makes sense to accumulate it, but Ned tells me that's
what CoreText does.
@@ -8837,10 +9899,9 @@
Date: Wed Nov 7 17:58:45 2018 -0800
fixed ends_in_hint bug
-
+
subr ends in hint itself should be regarded as hint
- this flag should propagate to its caller if the call itself is at
- the end of the caller
+ this flag should propagate to its caller if the call itself is at the end of the caller
src/hb-subset-cff-common.hh | 15 +++++++++++++--
1 file changed, 13 insertions(+), 2 deletions(-)
@@ -8860,7 +9921,7 @@
Date: Wed Nov 7 18:40:48 2018 -0500
Merge pull request #1362 from harfbuzz/cross-kern
-
+
Vastly improve kern/kerx tables, including cross-stream "kerning"
commit b18a56a290bf5330e81019b33f15e6951dd86a8b
@@ -8891,11 +9952,10 @@
Date: Wed Nov 7 18:04:53 2018 -0500
[kern] Implement negative state numbers
-
+
Let the fuzzing bots rip this code apart...
- src/hb-aat-layout-common.hh | 90
- ++++++++++++++++++++++++++++++-----------
+ src/hb-aat-layout-common.hh | 90 ++++++++++++++++++++++++++++++-----------
src/hb-aat-layout-kerx-table.hh | 10 -----
2 files changed, 66 insertions(+), 34 deletions(-)
@@ -8904,9 +9964,8 @@
Date: Wed Nov 7 14:48:37 2018 -0800
implented no-desubroutinize with CFF2 along with API test
-
- replaced AdobeVFPrototype.abc.otf with a hinted (maually) &
- subroutinized copy
+
+ replaced AdobeVFPrototype.abc.otf with a hinted (maually) & subroutinized copy
replaced expected results as well
src/hb-cff-interp-dict-common.hh | 4 +-
@@ -8913,17 +9972,13 @@
src/hb-cff2-interp-cs.hh | 16 +-
src/hb-ot-cff-common.hh | 22 +--
src/hb-subset-cff-common.hh | 64 +++++---
- src/hb-subset-cff2.cc | 180
- ++++++++++++++++++---
+ src/hb-subset-cff2.cc | 180 ++++++++++++++++++---
test/api/fonts/AdobeVFPrototype.abc.nohints.otf | Bin 7800 -> 0 bytes
- test/api/fonts/AdobeVFPrototype.abc.otf | Bin 7800 ->
- 7460 bytes
- test/api/fonts/AdobeVFPrototype.ac.nohints.otf | Bin 7152 ->
- 6780 bytes
+ test/api/fonts/AdobeVFPrototype.abc.otf | Bin 7800 -> 7460 bytes
+ test/api/fonts/AdobeVFPrototype.ac.nohints.otf | Bin 7152 -> 6780 bytes
.../fonts/AdobeVFPrototype.ac.nosubrs.nohints.otf | Bin 0 -> 6844 bytes
test/api/fonts/AdobeVFPrototype.ac.nosubrs.otf | Bin 0 -> 7060 bytes
- test/api/fonts/AdobeVFPrototype.ac.otf | Bin 7336 ->
- 6996 bytes
+ test/api/fonts/AdobeVFPrototype.ac.otf | Bin 7336 -> 6996 bytes
test/api/test-subset-cff2.c | 51 +++++-
12 files changed, 271 insertions(+), 66 deletions(-)
@@ -8941,17 +9996,15 @@
Date: Wed Nov 7 17:19:21 2018 -0500
[aat] Remove deleted-glyhs after applying kerx/kern
-
+
Finally: Fixes https://github.com/harfbuzz/harfbuzz/issues/1356
-
+
Test case:
$ ./hb-shape GeezaPro.ttc -u U+0628,U+064A,U+064E,U+0651,U+0629
[u0629.final.tehMarbuta=4+713|u064e_u0651.shaddaFatha=1 at 0,-200+0|u064a.medial.yeh=1+656|u0628.initial.beh=0+656]
-
- The mark positioning (kern table CrossStream kerning) only works
- if deleted
- glyph (as result of ligation) is still in stream and pushed through
- the
+
+ The mark positioning (kern table CrossStream kerning) only works if deleted
+ glyph (as result of ligation) is still in stream and pushed through the
state machine.
src/hb-aat-layout-morx-table.hh | 16 -------
@@ -8960,8 +10013,7 @@
src/hb-ot-layout-gpos-table.hh | 6 +--
src/hb-ot-layout.cc | 60 +++++++++++++++++++++--
src/hb-ot-layout.hh | 23 +++++----
- src/hb-ot-shape.cc | 102
- ++++++++++++++--------------------------
+ src/hb-ot-shape.cc | 102 ++++++++++++++--------------------------
7 files changed, 142 insertions(+), 107 deletions(-)
commit 1909072235e59eb80f9169300279b65779b932a4
@@ -8977,12 +10029,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Nov 7 16:19:51 2018 -0500
- Disable fallback mark positioning if kern table has cross-stream
- kerning
+ Disable fallback mark positioning if kern table has cross-stream kerning
+
+ Happens even if the cross-stream kerning is for cursive attachment only. Oh well..
- Happens even if the cross-stream kerning is for cursive attachment
- only. Oh well..
-
src/hb-ot-layout.cc | 6 ++++++
src/hb-ot-layout.hh | 3 +++
src/hb-ot-shape.cc | 14 ++++++--------
@@ -8994,7 +10044,7 @@
Date: Wed Nov 7 16:07:22 2018 -0500
Don't apply both kerx and kern
-
+
Ouch!
src/hb-ot-shape.cc | 2 +-
@@ -9035,7 +10085,7 @@
Date: Wed Nov 7 15:44:40 2018 -0500
[kerx] Fix peculiar indexing that was needed previously
-
+
Not needed now that we use GPOS attachment for cursive kerx.
src/hb-aat-layout-kerx-table.hh | 20 +++++++-------------
@@ -9046,11 +10096,10 @@
Date: Wed Nov 7 15:40:55 2018 -0500
[GPOS] Only mark unsafe-to-break if kerning happened
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1365
- src/hb-ot-layout-gpos-table.hh | 56
- ++++++++++++++++++++++++------------------
+ src/hb-ot-layout-gpos-table.hh | 56 ++++++++++++++++++++++++------------------
1 file changed, 32 insertions(+), 24 deletions(-)
commit 501a364d9bb6c5828f9d660bae8b6e93b158b275
@@ -9067,12 +10116,11 @@
Date: Wed Nov 7 14:52:36 2018 -0500
[kerx] Implement CrossStream kerning for non-state-machine subtables
-
+
Untested.
src/hb-aat-layout-kerx-table.hh | 12 ++++++------
- src/hb-kern.hh | 43
- +++++++++++++++++++++++++++++------------
+ src/hb-kern.hh | 43 +++++++++++++++++++++++++++++------------
src/hb-ot-kern-table.hh | 4 ++--
3 files changed, 39 insertions(+), 20 deletions(-)
@@ -9081,7 +10129,7 @@
Date: Wed Nov 7 14:42:15 2018 -0500
[kerx] Disable backwards-kerning for non-state-machine tables
-
+
That's what the spec says for Backwards flag, only applicable to
formats 1 and 4.
@@ -9095,8 +10143,7 @@
[kerx] Use GPOS attachment facilities for CrossStream kerning
- src/hb-aat-layout-kerx-table.hh | 51
- ++++++++++++++++++++++++++++-------------
+ src/hb-aat-layout-kerx-table.hh | 51 ++++++++++++++++++++++++++++-------------
1 file changed, 35 insertions(+), 16 deletions(-)
commit e10a856eb24ae45e301c3ffa778caa4c0a995bb9
@@ -9105,8 +10152,7 @@
[kerx] Format
- src/hb-aat-layout-kerx-table.hh | 58
- ++++++++++++++++++++---------------------
+ src/hb-aat-layout-kerx-table.hh | 58 ++++++++++++++++++++---------------------
1 file changed, 28 insertions(+), 30 deletions(-)
commit 649cc3ef2773950b0b5884d9d1caf414aac888bf
@@ -9135,7 +10181,7 @@
Date: Wed Nov 7 13:51:17 2018 -0500
[kerx] Implement tupleKerning for Format1
-
+
Untested.
src/hb-aat-layout-kerx-table.hh | 7 +++----
@@ -9157,8 +10203,7 @@
[kern/kerx] Share KernTable, renamed to KerxTable
src/hb-aat-layout-kerx-table.hh | 77 ++++++++++++++++++++++--------
- src/hb-ot-kern-table.hh | 103
- ++--------------------------------------
+ src/hb-ot-kern-table.hh | 103 ++--------------------------------------
2 files changed, 61 insertions(+), 119 deletions(-)
commit c038f5be6b70b8edffc701dd3e4e3cd08d14e2f0
@@ -9177,8 +10222,7 @@
[kern/kerx] More towards sharing KernTable
src/hb-aat-layout-kerx-table.hh | 48 ++++++++++++++++++---------------
- src/hb-ot-kern-table.hh | 59
- ++++++++++++++++++++++++++++-------------
+ src/hb-ot-kern-table.hh | 59 ++++++++++++++++++++++++++++-------------
2 files changed, 67 insertions(+), 40 deletions(-)
commit 89ec095979bde94bd203ed2c394f6e40629e9e78
@@ -9205,8 +10249,7 @@
[kern] Move code
- src/hb-ot-kern-table.hh | 118
- +++++++++++++++++++++++++-----------------------
+ src/hb-ot-kern-table.hh | 118 +++++++++++++++++++++++++-----------------------
1 file changed, 62 insertions(+), 56 deletions(-)
commit 1ff300464a1075b8cd5311970afbbcf4bb3b6f3d
@@ -9262,12 +10305,11 @@
Date: Wed Nov 7 12:19:52 2018 -0500
[kern/kerx] Share Format2
-
+
This, enables Format2 for kern table, which was disabled before.
src/hb-aat-layout-kerx-table.hh | 6 ++++
- src/hb-ot-kern-table.hh | 73
- +----------------------------------------
+ src/hb-ot-kern-table.hh | 73 +----------------------------------------
2 files changed, 7 insertions(+), 72 deletions(-)
commit 8faec4e33486616fdc0d690ad80d4a38a73c8182
@@ -9336,8 +10378,7 @@
[kern/kerx] Share Format1 subtable
src/hb-aat-layout-kerx-table.hh | 9 +-
- src/hb-ot-kern-table.hh | 187
- +---------------------------------------
+ src/hb-ot-kern-table.hh | 187 +---------------------------------------
2 files changed, 4 insertions(+), 192 deletions(-)
commit a244190afa90ac253724a2ff23a3bdf0c507d0e6
@@ -9363,7 +10404,7 @@
Date: Wed Nov 7 11:21:09 2018 -0500
[kern/kerx] Enable crossStream kerning in vertical
-
+
CoreText doesn't, but no reason we shouldn't do.
src/hb-aat-layout-kerx-table.hh | 8 ++++----
@@ -9395,8 +10436,7 @@
[kerx] Towards sharing Format1
- src/hb-aat-layout-kerx-table.hh | 61
- +++++++++++++++++++++++++++++++----------
+ src/hb-aat-layout-kerx-table.hh | 61 +++++++++++++++++++++++++++++++----------
1 file changed, 47 insertions(+), 14 deletions(-)
commit e890753ebbf0d20c1c86796837918d530610df3b
@@ -9415,8 +10455,7 @@
[kern/kerx] Share Format0
src/hb-aat-layout-kerx-table.hh | 22 +++++++++++++-----
- src/hb-ot-kern-table.hh | 50
- ++++++-----------------------------------
+ src/hb-ot-kern-table.hh | 50 ++++++-----------------------------------
2 files changed, 23 insertions(+), 49 deletions(-)
commit c97dde5d55929df394fbe57c1ba1a725592c6732
@@ -9425,8 +10464,7 @@
[kern/kerx] Towards merge more
- src/hb-aat-layout-kerx-table.hh | 75
- ++++++++++++++++++++++++++++++-----------
+ src/hb-aat-layout-kerx-table.hh | 75 ++++++++++++++++++++++++++++++-----------
src/hb-kern.hh | 33 ------------------
src/hb-ot-kern-table.hh | 7 ++--
3 files changed, 58 insertions(+), 57 deletions(-)
@@ -9449,8 +10487,7 @@
src/Makefile.sources | 1 +
src/hb-aat-layout-kerx-table.hh | 5 +-
- src/hb-kern.hh | 153
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-kern.hh | 153 ++++++++++++++++++++++++++++++++++++++++
src/hb-ot-kern-table.hh | 115 +-----------------------------
src/hb-ot-shape-fallback.cc | 2 +-
5 files changed, 157 insertions(+), 119 deletions(-)
@@ -9461,8 +10498,7 @@
[kerx] Towards sharing subtables with kern
- src/hb-aat-layout-kerx-table.hh | 41
- +++++++++++++++++++++++------------------
+ src/hb-aat-layout-kerx-table.hh | 41 +++++++++++++++++++++++------------------
1 file changed, 23 insertions(+), 18 deletions(-)
commit befac337ca2c705e2cea60a9a92e40e0dbbc40aa
@@ -9470,7 +10506,7 @@
Date: Wed Nov 7 09:53:02 2018 -0500
[kern] Remove Override business
-
+
Not used in any fonts. Not well-specified when mixing kerning with
Cross-Stream positioning.
@@ -9482,7 +10518,7 @@
Date: Wed Nov 7 09:16:53 2018 -0500
[post] Return true on truncation
-
+
Client can check that buffer was completely filled out and reallocate.
src/hb-ot-post-table.hh | 7 +++----
@@ -9520,14 +10556,14 @@
Date: Wed Nov 7 13:19:36 2018 +0000
Use non-GRID-fitted values for metrics (#1363)
-
+
* Use non-GRID-fitted values for metrics
-
+
See freetype/src/base/ftobjs.c:ft_recompute_scaled_metrics() and
the usage of GRID_FIT_METRICS inside.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/1262
-
+
* Update hb-ft.cc
src/hb-ft.cc | 6 +++---
@@ -9538,9 +10574,9 @@
Date: Wed Nov 7 00:25:48 2018 -0500
[kern/kerx] Fix cursive joining
-
+
Tested with Waseem TTC:
-
+
$ hb-shape Waseem.ttc جحخج
[F1Jeem_R2=3 at 0,180+479|M1Khah_L2_R2=2 at 0,682+403|M1Hah_L2_R2=1 at 0,1184+403|I1Jeem_L2=0 at 0,1184+744]
@@ -9564,8 +10600,7 @@
[kerx] Adjust CrossStream kern to match 'kern' table
- src/hb-aat-layout-kerx-table.hh | 62
- +++++++++++++++++++++++++++++++----------
+ src/hb-aat-layout-kerx-table.hh | 62 +++++++++++++++++++++++++++++++----------
1 file changed, 48 insertions(+), 14 deletions(-)
commit 80a33b9ac351d81793f35a92e0255ffbf5ceb8b9
@@ -9573,10 +10608,9 @@
Date: Tue Nov 6 21:41:28 2018 -0500
[kern] More tweaks
+
+ Solves a mystery or two. I'm fairly confident this is what CoreText does now.
- Solves a mystery or two. I'm fairly confident this is what CoreText
- does now.
-
src/hb-ot-kern-table.hh | 40 ++++++++++++++++++++++------------------
1 file changed, 22 insertions(+), 18 deletions(-)
@@ -9585,7 +10619,7 @@
Date: Tue Nov 6 21:04:40 2018 -0500
[kern] Adjust some more
-
+
Getting closer. So many open questions still...
src/hb-ot-kern-table.hh | 36 ++++++++++++++++++++++--------------
@@ -9614,22 +10648,20 @@
Date: Tue Nov 6 18:35:58 2018 -0500
[kern] In Format1, adjust how kerning is done
-
+
In a series of kerns in one action, kern all but last glyph forward,
- and the last one backward. Seems to better match what CoreText
- is doing.
-
+ and the last one backward. Seems to better match what CoreText is doing.
+
Test cases, with GeezaPro Arabic:
-
+
$ ./hb-shape GeezaPro_10_10.ttc -u U+0631,U+0628
[u0628.beh=1+1415|u0631.reh=0 at -202,0+700]
-
+
$ ./hb-shape GeezaPro_10_10.ttc -u U+0628,U+064F
[u064f.damma=0 at 0,-250+-250|u0628.beh=0 at 250,0+1665]
+
+ In a later change, I'll make kern machine avoid producing negative kerns.
- In a later change, I'll make kern machine avoid producing negative
- kerns.
-
src/hb-ot-kern-table.hh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -9638,9 +10670,9 @@
Date: Tue Nov 6 17:16:04 2018 -0500
[kern] XXX Negate CrossKerning sign
-
+
Not sure why, but seems to better match GeezaPro Arabic w CoreText.
-
+
Quite possibly I'm doing something very wrong...
src/hb-ot-kern-table.hh | 3 ++-
@@ -9652,8 +10684,7 @@
[kern] Implement CrossStream kerning
- src/hb-aat-layout-kerx-table.hh | 75
- ++++++++++++++++++++++++++---------------
+ src/hb-aat-layout-kerx-table.hh | 75 ++++++++++++++++++++++++++---------------
src/hb-ot-kern-table.hh | 63 ++++++++++++++++++++++++++++------
2 files changed, 101 insertions(+), 37 deletions(-)
@@ -9662,7 +10693,7 @@
Date: Tue Nov 6 15:23:18 2018 -0500
[kern] Improve Format 2
-
+
Still disabled.
src/hb-aat-layout-common.hh | 20 +++++++++-----------
@@ -9738,8 +10769,7 @@
[kern] Refactor to include header in each subtable type
- src/hb-ot-kern-table.hh | 189
- +++++++++++++++++++++++-------------------------
+ src/hb-ot-kern-table.hh | 189 +++++++++++++++++++++++-------------------------
1 file changed, 91 insertions(+), 98 deletions(-)
commit b0da2cd0b9c1346b7cda5997fb799e895e34aace
@@ -9765,7 +10795,7 @@
Date: Tue Nov 6 18:10:56 2018 +0200
Another missing backlash
-
+
Did this ever work?
test/api/Makefile.am | 2 +-
@@ -9794,7 +10824,7 @@
Date: Tue Nov 6 10:49:19 2018 -0500
[util] Don't terminate string after a a 0 in -u
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1361
util/options.cc | 4 +++-
@@ -9861,7 +10891,7 @@
Date: Tue Nov 6 11:17:14 2018 +0330
Fix link issue of some of the bots
-
+
e.g. https://circleci.com/gh/harfbuzz/harfbuzz/52410
src/hb-ot-layout.cc | 2 +-
@@ -9872,7 +10902,7 @@
Date: Tue Nov 6 09:16:28 2018 +0330
[mort] Fix table detection logic
-
+
mort really needs some initial tests at least.
src/hb-aat-layout.cc | 2 +-
@@ -9903,7 +10933,7 @@
Date: Mon Nov 5 23:26:29 2018 -0500
[ot-layout] Simplify GSUB/GPOS access
-
+
This concludes simplifying table access to face->table.XXXX.
src/hb-ot-layout.cc | 31 +++++++++++++------------------
@@ -9975,11 +11005,10 @@
Date: Mon Nov 5 22:58:43 2018 -0500
[ot-face] Simplify table access
-
+
Yoohoo!
- src/hb-aat-layout.cc | 107
- ++++++++++-----------------------------------------
+ src/hb-aat-layout.cc | 107 ++++++++++-----------------------------------------
src/hb-ot-color.cc | 66 ++++++++-----------------------
src/hb-ot-layout.cc | 20 ++--------
src/hb-ot-math.cc | 47 ++++++++--------------
@@ -9992,7 +11021,7 @@
Date: Mon Nov 5 22:39:50 2018 -0500
[ot-face] Include hb-ot-face directly in hb_face_t
-
+
Simplifying access coming next.
src/hb-face.cc | 4 ++++
@@ -10040,8 +11069,7 @@
[fuzzing] Fuzz glyph-id etc in test-ot-face
- test/api/test-ot-face.c | 57
- +++++++++++++++++++++--------------------
+ test/api/test-ot-face.c | 57 +++++++++++++++++++++--------------------
test/fuzzing/hb-shape-fuzzer.cc | 19 +-------------
2 files changed, 30 insertions(+), 46 deletions(-)
@@ -10059,11 +11087,10 @@
Date: Mon Nov 5 13:45:12 2018 -0500
[cmap] Make null accelerator safe
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1146
- src/hb-ot-cmap-table.hh | 50
- ++++++++++++++++++++++++-------------------------
+ src/hb-ot-cmap-table.hh | 50 ++++++++++++++++++++++++-------------------------
1 file changed, 25 insertions(+), 25 deletions(-)
commit f6fc5574d3dae177a54b10195e0d1f368a74f768
@@ -10125,12 +11152,9 @@
Makefile.in | 954 --
aclocal.m4 | 1496 ---
ar-lib | 270 -
- autom4te.cache/output.0 | 23333
- ----------------------------------------------
- autom4te.cache/output.1 | 23333
- ----------------------------------------------
- autom4te.cache/output.2 | 23333
- ----------------------------------------------
+ autom4te.cache/output.0 | 23333 ----------------------------------------------
+ autom4te.cache/output.1 | 23333 ----------------------------------------------
+ autom4te.cache/output.2 | 23333 ----------------------------------------------
autom4te.cache/requests | 555 --
autom4te.cache/traces.0 | 3823 --------
autom4te.cache/traces.1 | 1229 ---
@@ -10142,8 +11166,7 @@
config.log | 1560 ----
config.status | 2420 -----
config.sub | 1807 ----
- configure | 23333
- ----------------------------------------------
+ configure | 23333 ----------------------------------------------
depcomp | 791 --
install-sh | 501 -
libtool | 11805 -----------------------
@@ -10184,76 +11207,43 @@
Date: Sun Nov 4 13:12:20 2018 -0800
added desubroutinize full font test profiles & expected fonts
+
+ modified subset_test_suite.py to apply desubroutinize profiles to CFF only (not to TT)
- modified subset_test_suite.py to apply desubroutinize profiles to
- CFF only (not to TT)
-
- ...urceSansPro-Regular.default.1FC,21,41,20,62,63.otf | Bin 3640 ->
- 3784 bytes
- .../SourceSansPro-Regular.default.61,62,63.otf | Bin 3400 ->
- 3496 bytes
- .../SourceSansPro-Regular.default.D7,D8,D9,DA,DE.otf | Bin 3596 ->
- 3612 bytes
- ...sPro-Regular.desubroutinize.1FC,21,41,20,62,63.otf | Bin 0 ->
- 3640 bytes
- .../SourceSansPro-Regular.desubroutinize.61,62,63.otf | Bin 0 ->
- 3400 bytes
- ...eSansPro-Regular.desubroutinize.D7,D8,D9,DA,DE.otf | Bin 0 ->
- 3596 bytes
- ...eSansPro-Regular.drop-hints.1FC,21,41,20,62,63.otf | Bin 3480 ->
- 3564 bytes
- .../SourceSansPro-Regular.drop-hints.61,62,63.otf | Bin 3276 ->
- 3340 bytes
- ...ourceSansPro-Regular.drop-hints.D7,D8,D9,DA,DE.otf | Bin 3448 ->
- 3464 bytes
- ...r.drop-hints.desubroutinize.1FC,21,41,20,62,63.otf | Bin 0 ->
- 3480 bytes
- ...Pro-Regular.drop-hints.desubroutinize.61,62,63.otf | Bin 0 ->
- 3276 bytes
- ...gular.drop-hints.desubroutinize.D7,D8,D9,DA,DE.otf | Bin 0 ->
- 3448 bytes
- ...-Regular.default.3042,3044,3046,3048,304A,304B.otf | Bin 6248 ->
- 6324 bytes
- ...-Regular.default.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6432 ->
- 6568 bytes
- .../SourceHanSans-Regular.default.61,63,65,6B.otf | Bin 5428 ->
- 5500 bytes
- ...-Regular.default.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6552 ->
- 6780 bytes
- .../japanese/SourceHanSans-Regular.default.660E.otf | Bin 5196 ->
- 5248 bytes
+ ...urceSansPro-Regular.default.1FC,21,41,20,62,63.otf | Bin 3640 -> 3784 bytes
+ .../SourceSansPro-Regular.default.61,62,63.otf | Bin 3400 -> 3496 bytes
+ .../SourceSansPro-Regular.default.D7,D8,D9,DA,DE.otf | Bin 3596 -> 3612 bytes
+ ...sPro-Regular.desubroutinize.1FC,21,41,20,62,63.otf | Bin 0 -> 3640 bytes
+ .../SourceSansPro-Regular.desubroutinize.61,62,63.otf | Bin 0 -> 3400 bytes
+ ...eSansPro-Regular.desubroutinize.D7,D8,D9,DA,DE.otf | Bin 0 -> 3596 bytes
+ ...eSansPro-Regular.drop-hints.1FC,21,41,20,62,63.otf | Bin 3480 -> 3564 bytes
+ .../SourceSansPro-Regular.drop-hints.61,62,63.otf | Bin 3276 -> 3340 bytes
+ ...ourceSansPro-Regular.drop-hints.D7,D8,D9,DA,DE.otf | Bin 3448 -> 3464 bytes
+ ...r.drop-hints.desubroutinize.1FC,21,41,20,62,63.otf | Bin 0 -> 3480 bytes
+ ...Pro-Regular.drop-hints.desubroutinize.61,62,63.otf | Bin 0 -> 3276 bytes
+ ...gular.drop-hints.desubroutinize.D7,D8,D9,DA,DE.otf | Bin 0 -> 3448 bytes
+ ...-Regular.default.3042,3044,3046,3048,304A,304B.otf | Bin 6248 -> 6324 bytes
+ ...-Regular.default.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6432 -> 6568 bytes
+ .../SourceHanSans-Regular.default.61,63,65,6B.otf | Bin 5428 -> 5500 bytes
+ ...-Regular.default.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6552 -> 6780 bytes
+ .../japanese/SourceHanSans-Regular.default.660E.otf | Bin 5196 -> 5248 bytes
....otf => SourceHanSans-Regular.desubroutinize..otf} | Bin
- ...r.desubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin 0 ->
- 6248 bytes
- ...r.desubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 ->
- 6432 bytes
- ...urceHanSans-Regular.desubroutinize.61,63,65,6B.otf | Bin 0 ->
- 5428 bytes
- ...r.desubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 ->
- 6552 bytes
- .../SourceHanSans-Regular.desubroutinize.660E.otf | Bin 0 ->
- 5196 bytes
- ...gular.drop-hints.3042,3044,3046,3048,304A,304B.otf | Bin 6076 ->
- 6132 bytes
- ...gular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6180 ->
- 6304 bytes
- .../SourceHanSans-Regular.drop-hints.61,63,65,6B.otf | Bin 5312 ->
- 5344 bytes
- ...gular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6248 ->
- 6472 bytes
- .../SourceHanSans-Regular.drop-hints.660E.otf | Bin 5088 ->
- 5140 bytes
+ ...r.desubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 6248 bytes
+ ...r.desubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 6432 bytes
+ ...urceHanSans-Regular.desubroutinize.61,63,65,6B.otf | Bin 0 -> 5428 bytes
+ ...r.desubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 6552 bytes
+ .../SourceHanSans-Regular.desubroutinize.660E.otf | Bin 0 -> 5196 bytes
+ ...gular.drop-hints.3042,3044,3046,3048,304A,304B.otf | Bin 6076 -> 6132 bytes
+ ...gular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 6180 -> 6304 bytes
+ .../SourceHanSans-Regular.drop-hints.61,63,65,6B.otf | Bin 5312 -> 5344 bytes
+ ...gular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 6248 -> 6472 bytes
+ .../SourceHanSans-Regular.drop-hints.660E.otf | Bin 5088 -> 5140 bytes
...rceHanSans-Regular.drop-hints.desubroutinize..otf} | Bin
- ...s.desubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin 0 ->
- 6076 bytes
- ...s.desubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 ->
- 6180 bytes
- ...-Regular.drop-hints.desubroutinize.61,63,65,6B.otf | Bin 0 ->
- 5312 bytes
- ...s.desubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 ->
- 6248 bytes
- ...HanSans-Regular.drop-hints.desubroutinize.660E.otf | Bin 0 ->
- 5140 bytes
+ ...s.desubroutinize.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 6076 bytes
+ ...s.desubroutinize.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 6180 bytes
+ ...-Regular.drop-hints.desubroutinize.61,63,65,6B.otf | Bin 0 -> 5312 bytes
+ ...s.desubroutinize.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 6248 bytes
+ ...HanSans-Regular.drop-hints.desubroutinize.660E.otf | Bin 0 -> 5140 bytes
test/subset/data/profiles/desubroutinize.txt | 1 +
.../data/profiles/drop-hints-desubroutinize.txt | 2 ++
test/subset/generate-expected-outputs.py | 1 -
@@ -10269,8 +11259,7 @@
src/hb-aat-layout-ankr-table.hh | 2 ++
src/hb-aat-layout-common.hh | 31 +++++++++---------------------
src/hb-aat-layout-kerx-table.hh | 16 ++++++++--------
- src/hb-aat-layout.cc | 42
- +++++++++++++++++++++++++++++++++++++++--
+ src/hb-aat-layout.cc | 42 +++++++++++++++++++++++++++++++++++++++--
src/hb-ot-kern-table.hh | 1 -
src/hb-static.cc | 1 -
6 files changed, 59 insertions(+), 34 deletions(-)
@@ -10280,7 +11269,7 @@
Date: Sun Nov 4 02:47:34 2018 -0500
[test] Call test-ot-face.c test from hb-shape-fuzzer
-
+
Should increase coverage...
test/api/test-ot-face.c | 28 ++++++++++++++++++----------
@@ -10302,7 +11291,7 @@
Date: Sun Nov 4 02:25:07 2018 -0500
Clean up buffer->swap_buffers() calls
-
+
That function checks for buffer->successful already. No need
to check at call site.
@@ -10323,15 +11312,13 @@
Date: Sat Nov 3 22:42:22 2018 -0700
CFF1 no-desubr fixes
-
- make sure charstring/subrs not ending with endchar/return handled
- correctly
+
+ make sure charstring/subrs not ending with endchar/return handled correctly
if no local subrs, skip serializing Subrs op in Private
misc fixes
src/hb-ot-cff-common.hh | 13 +++++++++-
- src/hb-subset-cff-common.hh | 59
- +++++++++++++++++++++++----------------------
+ src/hb-subset-cff-common.hh | 59 +++++++++++++++++++++++----------------------
src/hb-subset-cff1.cc | 27 +++++++++++++++------
3 files changed, 62 insertions(+), 37 deletions(-)
@@ -10358,9 +11345,9 @@
Date: Sat Nov 3 21:38:24 2018 -0400
Revert "Add operator char * to the naked array types as well"
-
+
This reverts commit db889c182ee5f54127285bfaab5bc94dafe46bda.
-
+
Was resulting in ambigious overloads...
src/hb-dsalgs.hh | 4 +---
@@ -10383,8 +11370,7 @@
[test] Add test for empty face
test/api/Makefile.am | 1 +
- test/api/test-ot-face.c | 94
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-ot-face.c | 94 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 95 insertions(+)
commit 1da4de7e7b71dfde734cb77ec6acb31f574585f2
@@ -10392,10 +11378,9 @@
Date: Sat Nov 3 15:41:29 2018 -0700
fix for subset fuzzer failure
+
+ A called subr must be freshly parsed or completely parsed. otherwise the prevoius parse must have terminated prematurely
- A called subr must be freshly parsed or completely parsed. otherwise
- the prevoius parse must have terminated prematurely
-
src/hb-subset-cff1.cc | 3 +++
1 file changed, 3 insertions(+)
@@ -10404,9 +11389,9 @@
Date: Sat Nov 3 16:15:30 2018 -0400
Fix null accelerator's
-
+
Fixes all except for cmap. To be done separately.
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1146
src/hb-ot-color-cbdt-table.hh | 10 ++--------
@@ -10452,7 +11437,7 @@
Date: Sat Nov 3 15:49:37 2018 -0400
[blob] Allow null parent in create_sub_blob()
-
+
Like font and unicode.
src/hb-blob.cc | 2 +-
@@ -10463,7 +11448,7 @@
Date: Sat Nov 3 15:24:14 2018 -0400
Add hb_nonnull_ptr_t
-
+
Towards fixing https://github.com/harfbuzz/harfbuzz/issues/1146
src/hb-null.hh | 28 ++++++++++++++++++++++++++++
@@ -10474,7 +11459,7 @@
Date: Sat Nov 3 15:14:57 2018 -0400
[kern] Third try fix access violation in Format3
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
src/hb-ot-kern-table.hh | 1 -
@@ -10485,7 +11470,7 @@
Date: Sat Nov 3 15:06:45 2018 -0400
[kern] Really fix access violation in Format3
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
src/hb-ot-kern-table.hh | 2 +-
@@ -10509,7 +11494,7 @@
Date: Sat Nov 3 14:58:54 2018 -0400
[kern] Fix access violation in Format3
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11245
src/hb-ot-kern-table.hh | 6 +++++-
@@ -10520,7 +11505,7 @@
Date: Sat Nov 3 14:51:38 2018 -0400
Port objects to use header.writable instead of immutable
-
+
Saves 4 or 8 bytes per object on 64bit archs.
src/hb-blob.cc | 12 ++++--------
@@ -10550,8 +11535,7 @@
[BASE] Improvements (#1347)
- src/hb-ot-layout-base-table.hh | 610
- ++++++++++++++++++-----------------------
+ src/hb-ot-layout-base-table.hh | 610 ++++++++++++++++++-----------------------
src/hb-ot-layout.cc | 65 ++++-
src/hb-ot-layout.h | 16 --
test/api/Makefile.am | 1 +
@@ -10565,8 +11549,7 @@
[fuzz] A new testcase
- ...uzz-testcase-minimized-hb-shape-fuzzer-5735679418433536 | Bin 0 ->
- 36 bytes
+ ...uzz-testcase-minimized-hb-shape-fuzzer-5735679418433536 | Bin 0 -> 36 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 34b06d994a79124963d2a7432d0ec945e72bfdbd
@@ -10577,8 +11560,7 @@
src/hb-ot-cff-common.hh | 2 +-
src/hb-subset-cff-common.cc | 6 +++---
- test/api/fonts/SourceHanSans-Regular.41,3041,4C2E.otf | Bin 2576 ->
- 3892 bytes
+ test/api/fonts/SourceHanSans-Regular.41,3041,4C2E.otf | Bin 2576 -> 3892 bytes
3 files changed, 4 insertions(+), 4 deletions(-)
commit 481fdfdc23f557400ad3aceeceeab07add78f005
@@ -10586,8 +11568,7 @@
Author: Michiharu Ariza <ariza at adobe.com>
Date: Fri Nov 2 15:28:09 2018 -0700
- Merge branch 'cff-subset' of https://github.com/harfbuzz/harfbuzz
- into cff-subset
+ Merge branch 'cff-subset' of https://github.com/harfbuzz/harfbuzz into cff-subset
commit 1bc710a8c94fbe08ca3a3e535c7b6597a57883df
Author: Michiharu Ariza <ariza at adobe.com>
@@ -10597,26 +11578,19 @@
src/hb-cff1-interp-cs.hh | 7 --
src/hb-ot-cff-common.hh | 56 ++++++----
- src/hb-subset-cff-common.hh | 100
- +++++++++--------
+ src/hb-subset-cff-common.hh | 100 +++++++++--------
src/hb-subset-cff1.cc | 53 ++++-----
- .../fonts/SourceHanSans-Regular.41,3041,4C2E.otf | Bin 3892 ->
- 2576 bytes
+ .../fonts/SourceHanSans-Regular.41,3041,4C2E.otf | Bin 3892 -> 2576 bytes
.../SourceHanSans-Regular.41,4C2E.nohints.otf | Bin 0 -> 2380 bytes
...urceHanSans-Regular.41,4C2E.nosubrs.nohints.otf | Bin 0 -> 2360 bytes
.../SourceHanSans-Regular.41,4C2E.nosubrs.otf | Bin 0 -> 2548 bytes
- test/api/fonts/SourceHanSans-Regular.41,4C2E.otf | Bin 2548 ->
- 2576 bytes
- test/api/fonts/SourceSansPro-Regular.abc.otf | Bin 3412 ->
- 1812 bytes
- .../api/fonts/SourceSansPro-Regular.ac.nohints.otf | Bin 3228 ->
- 1592 bytes
+ test/api/fonts/SourceHanSans-Regular.41,4C2E.otf | Bin 2548 -> 2576 bytes
+ test/api/fonts/SourceSansPro-Regular.abc.otf | Bin 3412 -> 1812 bytes
+ .../api/fonts/SourceSansPro-Regular.ac.nohints.otf | Bin 3228 -> 1592 bytes
.../SourceSansPro-Regular.ac.nosubrs.nohints.otf | Bin 0 -> 1540 bytes
.../api/fonts/SourceSansPro-Regular.ac.nosubrs.otf | Bin 0 -> 1632 bytes
- test/api/fonts/SourceSansPro-Regular.ac.otf | Bin 3332 ->
- 1708 bytes
- test/api/test-subset-cff1.c | 122
- +++++++++++++++++++++
+ test/api/fonts/SourceSansPro-Regular.ac.otf | Bin 3332 -> 1708 bytes
+ test/api/test-subset-cff1.c | 122 +++++++++++++++++++++
15 files changed, 232 insertions(+), 106 deletions(-)
commit 2c68f34bddbe506d0b22948562f2f59b9a5b6050
@@ -10624,7 +11598,7 @@
Date: Fri Nov 2 23:06:00 2018 +0200
[os2] Capitalize table tag and struct
-
+
Other tables follow the case of the OT tag, except this one.
src/hb-ot-hmtx-table.hh | 6 +++---
@@ -10637,14 +11611,13 @@
Date: Fri Nov 2 14:47:42 2018 -0400
[kern] Implement Format1
-
+
Also, implement backwards kerning for Format1 in kern and kerx.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1350
src/hb-aat-layout-kerx-table.hh | 11 +++-
- src/hb-ot-kern-table.hh | 127
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-kern-table.hh | 127 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 136 insertions(+), 2 deletions(-)
commit 46b3885c1a8ea3b85efbdd1704edcee385797c5d
@@ -10670,7 +11643,7 @@
Date: Fri Nov 2 13:57:41 2018 -0400
[kern] Minor
-
+
We like check_struct() more.
src/hb-ot-kern-table.hh | 5 +++--
@@ -10681,7 +11654,7 @@
Date: Fri Nov 2 13:47:33 2018 -0400
Remove pointer cast operators from ArrayOf<>
-
+
ArrayOf<>, unlike UnsizedArrayOf<>, has data before the array.
This was confusing. Remove.
@@ -10703,8 +11676,7 @@
[kern] Push apply loop to each subtable
- src/hb-ot-kern-table.hh | 153
- ++++++++++++++++++++++++++++++++++++++----------
+ src/hb-ot-kern-table.hh | 153 ++++++++++++++++++++++++++++++++++++++----------
src/hb-ot-layout.cc | 28 ++++++---
src/hb-ot-layout.hh | 8 ++-
src/hb-ot-shape.cc | 2 +-
@@ -10715,12 +11687,11 @@
Date: Fri Nov 2 12:47:55 2018 -0400
[kern] Remove accelerator
-
+
It wasn't doing anything.
src/hb-ot-face.hh | 2 +-
- src/hb-ot-kern-table.hh | 55
- ++++++++++++++-----------------------------------
+ src/hb-ot-kern-table.hh | 55 ++++++++++++++-----------------------------------
src/hb-ot-layout.cc | 4 ++--
3 files changed, 18 insertions(+), 43 deletions(-)
@@ -10758,11 +11729,10 @@
Date: Fri Nov 2 11:56:55 2018 -0400
[kern] Implement Format3
-
+
Untested.
- src/hb-ot-kern-table.hh | 51
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-kern-table.hh | 51 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
commit c6ef5dbd5c40cc8934756456221e080012a82530
@@ -10819,7 +11789,7 @@
Date: Thu Nov 1 17:25:23 2018 -0700
added hb_subset_input_set_desubroutinize API
-
+
hooked up with CFF1 subroutinizer
a renaming
@@ -10949,7 +11919,7 @@
Date: Wed Oct 31 22:30:34 2018 -0700
CFF1 no-desubroutinize + no-hinting
-
+
no-desubroutinize option is disabled for now
code cleanup (esp. CFF1 width handling)
bug fixes & renaming
@@ -10962,8 +11932,7 @@
src/hb-ot-cff-common.hh | 85 ++---
src/hb-ot-cff1-table.hh | 20 +-
src/hb-ot-cff2-table.hh | 25 +-
- src/hb-subset-cff-common.hh | 702
- ++++++++++++++++++++++++++++++++++++---
+ src/hb-subset-cff-common.hh | 702 ++++++++++++++++++++++++++++++++++++---
src/hb-subset-cff1.cc | 242 +++++++++++---
src/hb-subset-cff2.cc | 45 +--
src/hb-subset-input.hh | 1 +
@@ -10978,7 +11947,7 @@
Date: Wed Oct 31 19:05:53 2018 -0700
[aat] Implement 'aalt' mapping
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1160
src/hb-aat-map.cc | 8 ++++++++
@@ -10989,7 +11958,7 @@
Date: Wed Oct 31 19:00:11 2018 -0700
[aat] Add 'afrc' feature mapping
-
+
https://github.com/harfbuzz/harfbuzz/issues/1342#issuecomment-434829028
src/hb-aat-layout.cc | 1 +
@@ -11000,7 +11969,7 @@
Date: Wed Oct 31 18:51:45 2018 -0700
[aat] Fallback to old style "Letter Case" small caps
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1342
src/hb-aat-layout-morx-table.hh | 8 ++++++++
@@ -11020,11 +11989,10 @@
Date: Wed Oct 31 18:21:48 2018 -0700
Implement space fallback in vertical direction
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1343
- src/hb-ot-shape-fallback.cc | 36
- +++++++++++++++++++--------
+ src/hb-ot-shape-fallback.cc | 36 +++++++++++++++++++--------
test/shaping/data/in-house/tests/spaces.tests | 17 +++++++++++++
2 files changed, 42 insertions(+), 11 deletions(-)
@@ -11089,7 +12057,7 @@
Date: Wed Oct 31 13:19:42 2018 -0700
Improve blob->as<>
-
+
It's true that blob->as<> should only be called on null or sanitized
data. But this change is safe, so keep it.
@@ -11102,7 +12070,7 @@
Date: Wed Oct 31 10:42:49 2018 -0700
[set] Warning fix with gcc 8.1
-
+
https://github.com/harfbuzz/harfbuzz/pull/1334
src/hb-dsalgs.hh | 6 ++++--
@@ -11113,11 +12081,9 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Wed Oct 31 14:20:23 2018 +0330
- [ot-color-test] Remove the non-working exact strike size storing
- (#1339)
+ [ot-color-test] Remove the non-working exact strike size storing (#1339)
- src/test-ot-color.cc | 135
- +++++++++++++++++++++++----------------------------
+ src/test-ot-color.cc | 135 +++++++++++++++++++++++----------------------------
1 file changed, 62 insertions(+), 73 deletions(-)
commit 2e639c47c9d35ff7dc4dde21f744f9ee695a27f3
@@ -11143,10 +12109,10 @@
Date: Wed Oct 31 01:16:33 2018 -0700
[mort] Make ligatures work
-
+
./hb-shape Apple_Chancery_10_12.ttf "Th th ll te to tr fr fu fj"
[T_h=0+2308|space=2+569|t_h=3+1687|space=5+569|l_l=6+1108|space=8+569|t_e=9+1408|space=11+569|t_o=12+1531|space=14+569|t_r=15+1385|space=17+569|f_r=18+1432|space=20+569|f_u=21+1733|space=23+569|f_j=24+1098]
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1331
src/hb-aat-layout-morx-table.hh | 25 +++++++++++++++++--------
@@ -11158,8 +12124,7 @@
[mort] More Ligature work
- src/hb-aat-layout-morx-table.hh | 54
- ++++++++++++++++++++++++++++++-----------
+ src/hb-aat-layout-morx-table.hh | 54 ++++++++++++++++++++++++++++++-----------
1 file changed, 40 insertions(+), 14 deletions(-)
commit 431c6e496be56e441ee4b9b705f40a1246bdd0d6
@@ -11168,8 +12133,7 @@
[mort] Some Ligature work
- src/hb-aat-layout-morx-table.hh | 38
- +++++++++++++++++++++++++++++++-------
+ src/hb-aat-layout-morx-table.hh | 38 +++++++++++++++++++++++++++++++-------
1 file changed, 31 insertions(+), 7 deletions(-)
commit 28b68cffe4e5ebf82217ebf439f428431d672af3
@@ -11178,8 +12142,7 @@
[mort] Implement / adjust Contextual substitution
- src/hb-aat-layout-morx-table.hh | 70
- ++++++++++++++++++++++++++++++-----------
+ src/hb-aat-layout-morx-table.hh | 70 ++++++++++++++++++++++++++++++-----------
src/hb-open-type.hh | 7 +++++
2 files changed, 59 insertions(+), 18 deletions(-)
@@ -11234,8 +12197,7 @@
[mort] More massaging towards mort
- src/hb-aat-layout-morx-table.hh | 53
- +++++++++++++++++++++--------------------
+ src/hb-aat-layout-morx-table.hh | 53 +++++++++++++++++++++--------------------
1 file changed, 27 insertions(+), 26 deletions(-)
commit 2d9467340b1498ccc0cd47bf915b84ab12dfa025
@@ -11252,13 +12214,12 @@
Date: Tue Oct 30 19:26:16 2018 -0700
[mort] Make it compile / hook it up
-
+
Untested.
src/hb-aat-layout-common.hh | 11 +++++-----
src/hb-aat-layout-morx-table.hh | 2 +-
- src/hb-aat-layout.cc | 47
- ++++++++++++++++++++++++++---------------
+ src/hb-aat-layout.cc | 47 ++++++++++++++++++++++++++---------------
3 files changed, 36 insertions(+), 24 deletions(-)
commit 933babdc075c27fbcc1b726c3c9b2aa67338c6ad
@@ -11275,16 +12236,14 @@
Date: Tue Oct 30 18:41:34 2018 +0330
[mort] Bring back mort generalizations
-
- Started by reverting
- https://github.com/harfbuzz/harfbuzz/commit/1f1c85a5
-
+
+ Started by reverting https://github.com/harfbuzz/harfbuzz/commit/1f1c85a5
+
Just a starting point, if we agree even mort can come back.
src/hb-aat-layout-common.hh | 76 +++++++++++++++++++----
src/hb-aat-layout-kerx-table.hh | 17 ++---
- src/hb-aat-layout-morx-table.hh | 133
- ++++++++++++++++++++++++----------------
+ src/hb-aat-layout-morx-table.hh | 133 ++++++++++++++++++++++++----------------
src/hb-aat-layout.cc | 16 ++++-
src/hb-ot-face.hh | 1 +
5 files changed, 171 insertions(+), 72 deletions(-)
@@ -11294,7 +12253,7 @@
Date: Tue Oct 30 19:16:00 2018 -0700
Fix build
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1338
src/test-ot-color.cc | 2 +-
@@ -11315,8 +12274,7 @@
2.1.0
- NEWS | 81
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ NEWS | 81 ++++++++++++++++++++++++++++++++++++++++++++++++++
RELEASING.md | 3 +-
configure.ac | 2 +-
docs/harfbuzz-docs.xml | 1 +
@@ -11338,8 +12296,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Oct 30 11:29:58 2018 -0700
- [subset] Limit the number of scripts and langsys' that should be
- checked when collecting features.
+ [subset] Limit the number of scripts and langsys' that should be checked when collecting features.
src/hb-ot-layout-common.hh | 8 ++++++++
src/hb-ot-layout.cc | 11 ++++++++++-
@@ -11350,7 +12307,7 @@
Date: Tue Oct 30 14:04:09 2018 -0700
[name] Rename hb_name_id_t to hb_ot_name_id_t
-
+
https://github.com/harfbuzz/harfbuzz/pull/1254
docs/harfbuzz-sections.txt | 3 +-
@@ -11361,8 +12318,7 @@
src/hb-ot-layout.h | 28 ++++++-------
src/hb-ot-name-table.hh | 6 +--
src/hb-ot-name.cc | 38 ++++++++---------
- src/hb-ot-name.h | 98
- +++++++++++++++++++++----------------------
+ src/hb-ot-name.h | 98 +++++++++++++++++++++----------------------
test/api/test-ot-color.c | 30 ++++++-------
test/api/test-ot-name.c | 8 ++--
11 files changed, 139 insertions(+), 138 deletions(-)
@@ -11382,7 +12338,7 @@
Date: Tue Oct 30 13:16:07 2018 -0700
[CBDT] Implement Format18 get_extens
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1327
src/hb-ot-color-cbdt-table.hh | 10 +++++++++-
@@ -11394,8 +12350,7 @@
[CBDT] Bound checks in reference_png
- src/hb-ot-color-cbdt-table.hh | 57
- ++++++++++++++++++++++++++-----------------
+ src/hb-ot-color-cbdt-table.hh | 57 ++++++++++++++++++++++++++-----------------
1 file changed, 34 insertions(+), 23 deletions(-)
commit f236f790884d7b5c7afb73768724c360d4ea5212
@@ -11402,8 +12357,7 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Tue Oct 30 11:24:56 2018 -0500
- Docs Makefile: sync SGML list to harfbuzz-docs.xml include
- list. Hopefully fixes distcheck failure.
+ Docs Makefile: sync SGML list to harfbuzz-docs.xml include list. Hopefully fixes distcheck failure.
docs/Makefile.am | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
@@ -11419,8 +12373,7 @@
docs/usermanual-fonts-and-faces.xml | 8 +++++++-
docs/usermanual-getting-started.xml | 6 ++++++
docs/usermanual-glyph-information.xml | 8 +++++++-
- docs/usermanual-install-harfbuzz.xml | 20
- +++++++++++++++++---
+ docs/usermanual-install-harfbuzz.xml | 20 +++++++++++++++++---
docs/usermanual-opentype-features.xml | 8 +++++++-
docs/usermanual-shaping-concepts.xml | 6 ++++++
docs/usermanual-what-is-harfbuzz.xml | 12 +++++++-----
@@ -11430,8 +12383,7 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Mon Oct 29 16:42:59 2018 -0500
- Usermanual: update DTD in chapter XML to avoid HTML entity parsing
- errors.
+ Usermanual: update DTD in chapter XML to avoid HTML entity parsing errors.
docs/usermanual-what-is-harfbuzz.xml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
@@ -11452,7 +12404,7 @@
Date: Sat Oct 20 16:12:45 2018 +0100
Minor; rewording unsafe-to-break note.
-
+
Co-Authored-By: n8willis <nwillis at glyphography.com>
docs/usermanual-getting-started.xml | 2 +-
@@ -11463,7 +12415,7 @@
Date: Sat Oct 20 15:46:04 2018 +0100
Trivial; typo.
-
+
Co-Authored-By: n8willis <nwillis at glyphography.com>
docs/usermanual-what-is-harfbuzz.xml | 2 +-
@@ -11474,7 +12426,7 @@
Date: Sat Oct 20 15:45:24 2018 +0100
Minor; simplify example code
-
+
Co-Authored-By: n8willis <nwillis at glyphography.com>
docs/usermanual-getting-started.xml | 4 +++-
@@ -11485,7 +12437,7 @@
Date: Sat Oct 20 15:44:51 2018 +0100
Minor: simplify example code
-
+
Co-Authored-By: n8willis <nwillis at glyphography.com>
docs/usermanual-getting-started.xml | 2 +-
@@ -11496,7 +12448,7 @@
Date: Sat Oct 20 15:41:00 2018 +0100
Minor; drop 'OpenType' from sentence
-
+
Co-Authored-By: n8willis <nwillis at glyphography.com>
docs/usermanual-what-is-harfbuzz.xml | 2 +-
@@ -11516,7 +12468,7 @@
Date: Sat Oct 20 15:00:52 2018 +0100
Use 'glyphs' instead of 'text'
-
+
Co-Authored-By: n8willis <nwillis at glyphography.com>
docs/harfbuzz-docs.xml | 2 +-
@@ -11537,10 +12489,8 @@
Docs: rename Hello HarfBuzz to Getting Started.
- docs/harfbuzz-docs.xml |
- 2 +-
- docs/{usermanual-hello-harfbuzz.xml => usermanual-getting-started.xml}
- | 0
+ docs/harfbuzz-docs.xml | 2 +-
+ docs/{usermanual-hello-harfbuzz.xml => usermanual-getting-started.xml} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
commit 9e7efa3f47557a77852a15d89619787fd9933ed1
@@ -11547,11 +12497,9 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Tue Oct 16 17:46:03 2018 -0500
- Docs: usermanual, add API Overview to Hello HarfBuzz chapter. Start
- Terminology section.
+ Docs: usermanual, add API Overview to Hello HarfBuzz chapter. Start Terminology section.
- docs/usermanual-hello-harfbuzz.xml | 309
- +++++++++++++++++++++++++------------
+ docs/usermanual-hello-harfbuzz.xml | 309 +++++++++++++++++++++++++------------
1 file changed, 212 insertions(+), 97 deletions(-)
commit 3a27e8fb97f716c17b03e3a4a634a4900bcb6045
@@ -11561,8 +12509,7 @@
Docs: usermanual, add Shaping Concepts chapter.
docs/harfbuzz-docs.xml | 5 +-
- docs/usermanual-shaping-concepts.xml | 368
- +++++++++++++++++++++++++++++++++++
+ docs/usermanual-shaping-concepts.xml | 368 +++++++++++++++++++++++++++++++++++
2 files changed, 371 insertions(+), 2 deletions(-)
commit 9aa865dcc68ec207741e07ba3f7aacf4ac750c1c
@@ -11578,11 +12525,9 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Thu Oct 11 15:40:08 2018 -0500
- Docs: move harfbuzz-ng-vs-old discussion down below the TOC; put
- in note.
+ Docs: move harfbuzz-ng-vs-old discussion down below the TOC; put in note.
- docs/harfbuzz-docs.xml | 63
- ++++++++++++++++++++++++++++++++++----------------
+ docs/harfbuzz-docs.xml | 63 ++++++++++++++++++++++++++++++++++----------------
1 file changed, 43 insertions(+), 20 deletions(-)
commit 792af5d254fddcdc4292dffb76b81d65754e65a9
@@ -11591,8 +12536,7 @@
Docs: flesh out config options in Usermanual:Install chapter.
- docs/usermanual-install-harfbuzz.xml | 108
- +++++++++++++++++++++++++++--------
+ docs/usermanual-install-harfbuzz.xml | 108 +++++++++++++++++++++++++++--------
1 file changed, 85 insertions(+), 23 deletions(-)
commit 325e2745cfa55f9ef114ee8eeaf7bd8176743822
@@ -11599,11 +12543,9 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Wed Oct 10 17:01:21 2018 -0500
- Docs: add basic config-options section to Usermanual Installation
- chapter.
+ Docs: add basic config-options section to Usermanual Installation chapter.
- docs/usermanual-install-harfbuzz.xml | 132
- ++++++++++++++++++++++++++++++++++-
+ docs/usermanual-install-harfbuzz.xml | 132 ++++++++++++++++++++++++++++++++++-
1 file changed, 131 insertions(+), 1 deletion(-)
commit 97c1c46cd2241d77b531a582dd1a2432af976357
@@ -11610,11 +12552,9 @@
Author: Nathan Willis <nwillis at glyphography.com>
Date: Wed Oct 10 16:38:22 2018 -0500
- Docs: update and linearize build instructions; add installation
- overview material.
+ Docs: update and linearize build instructions; add installation overview material.
- docs/usermanual-install-harfbuzz.xml | 229
- ++++++++++++++++++++++++++++-------
+ docs/usermanual-install-harfbuzz.xml | 229 ++++++++++++++++++++++++++++-------
1 file changed, 188 insertions(+), 41 deletions(-)
commit 088755f9e654d2ec638dce0c68d523084b9eaf5a
@@ -11623,8 +12563,7 @@
Docs: update usermanual What Is HarfBuzz material.
- docs/usermanual-what-is-harfbuzz.xml | 220
- +++++++++++++++++++++++++++--------
+ docs/usermanual-what-is-harfbuzz.xml | 220 +++++++++++++++++++++++++++--------
1 file changed, 172 insertions(+), 48 deletions(-)
commit 0956ab41851d30f50c39c28730cf30ea0bbc5466
@@ -11633,10 +12572,8 @@
Docs: Move What-HarfBuzz-doesnt-do to Usermanual-what-is-HarfBuzz.
- docs/usermanual-hello-harfbuzz.xml | 98
- +++------------------------------
- docs/usermanual-what-is-harfbuzz.xml | 101
- +++++++++++++++++++++++++++++++++--
+ docs/usermanual-hello-harfbuzz.xml | 98 +++------------------------------
+ docs/usermanual-what-is-harfbuzz.xml | 101 +++++++++++++++++++++++++++++++++--
2 files changed, 104 insertions(+), 95 deletions(-)
commit fd270beedb331c4685e918f5a3ef5789a23ffaeb
@@ -11645,8 +12582,7 @@
Docs: Usermanual- What is HarfBuzz; add intro to shaping concepts.
- docs/usermanual-what-is-harfbuzz.xml | 51
- ++++++++++++++++++++++++++++++++++++
+ docs/usermanual-what-is-harfbuzz.xml | 51 ++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
commit d9fd92721002726c4aeaae9cc3a519a41f694e48
@@ -11655,8 +12591,7 @@
Docs: update Usermanual-What Is HarfBuzz.
- docs/usermanual-what-is-harfbuzz.xml | 199
- +++++++++++++++++++++++------------
+ docs/usermanual-what-is-harfbuzz.xml | 199 +++++++++++++++++++++++------------
1 file changed, 130 insertions(+), 69 deletions(-)
commit 0af3d176a64c0a57c7acb2a64ce8b9d08f449241
@@ -11664,12 +12599,11 @@
Date: Tue Oct 30 17:05:28 2018 +0200
[sbix] Fix memory leak in early return
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11210
src/hb-ot-color-sbix-table.hh | 3 +++
- ...zz-testcase-minimized-hb-shape-fuzzer-5768601332613120 | Bin 0 ->
- 108 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5768601332613120 | Bin 0 -> 108 bytes
2 files changed, 3 insertions(+)
commit edaa768253cfeb97d614537253f90d47aa93ff6f
@@ -11737,7 +12671,7 @@
Date: Tue Oct 30 00:51:43 2018 -0700
[test/shaping] Spawn one hb-shape per test file
-
+
Speeds up runnings in-house tests from over 20s to 2s.
test/shaping/run-tests.py | 32 ++++++++++++--------------------
@@ -11786,10 +12720,9 @@
Date: Mon Oct 29 23:21:14 2018 -0700
[set/map] Fix uninitialized memory
+
+ I keep forgetting that primitive types are NOT initialized during construction. :|
- I keep forgetting that primitive types are NOT initialized during
- construction. :|
-
src/hb-map.hh | 4 ++--
src/hb-object.hh | 1 +
src/hb-set.hh | 4 ++--
@@ -11849,7 +12782,7 @@
Date: Mon Oct 29 18:05:25 2018 -0700
Remove a few unnecessary hb_auto_t<>'s
-
+
See a85641446c30247c4e948263f0f8c1147ed4efb9
src/hb-coretext.cc | 8 ++++----
@@ -11867,9 +12800,9 @@
Date: Mon Oct 29 17:37:41 2018 -0700
[set/map/vector] Make constructable, but not copy or assignable
-
+
Disable copy/assign on them, as they shouldn't.
-
+
Make constructor / destructor call init_shallow/fini_shallow,
and make those idempotent. So, these three can be constructed
on stack now and no init/fini call is needed. As such,
@@ -11896,7 +12829,7 @@
Date: Mon Oct 29 15:58:44 2018 -0700
Remove HB_DISALLOW_COPY_AND_ASSIGN from hb_ot_shape_planner_t
-
+
It was arbitrary that this struct had it and not dozens of others.
src/hb-ot-shape.hh | 3 ---
@@ -11916,7 +12849,7 @@
Date: Mon Oct 29 15:16:52 2018 -0700
Try fixing older bots
-
+
Older C++ doesn't allow struct-with-constructor in union.
src/hb.hh | 13 ++++++++++++-
@@ -11936,12 +12869,12 @@
Date: Mon Oct 29 14:45:44 2018 -0700
Remove ASSERT_POD
-
+
Newer compilers / language allows structs with constructor in union.
So, this was not actually testing anything. Indeed, the recent
change in DISALLOW_COPY *is* making some of our types non-POD.
That broke some bots.
-
+
Just remove this since it wasn't doing much, and I'd rather have
DISALLOW_COPY.
@@ -11962,8 +12895,7 @@
src/hb-subset-input.hh | 1 -
src/hb-subset-plan.hh | 1 -
src/hb-unicode.hh | 1 -
- src/hb.hh | 26
- --------------------------
+ src/hb.hh | 26 --------------------------
18 files changed, 2 insertions(+), 60 deletions(-)
commit 6f0454e176efdb8b99c8aa59b5ad765ca455b8d6
@@ -11980,14 +12912,12 @@
Date: Mon Oct 29 11:25:35 2018 -0700
Make Array types uncopyable-unassignable
-
+
Finally! Catches hard-to-find errors like this:
-
- - const SortedArrayOf<SVGDocumentIndexEntry> docs =
- this+svgDocEntries;
- + const SortedArrayOf<SVGDocumentIndexEntry> &docs =
- this+svgDocEntries;
-
+
+ - const SortedArrayOf<SVGDocumentIndexEntry> docs = this+svgDocEntries;
+ + const SortedArrayOf<SVGDocumentIndexEntry> &docs = this+svgDocEntries;
+
We implement this for our array types. This, in turn, trickles down
into all types that embed the arrays. So, as long as we define all
open-ended structs in terms of Array types (all can be done using
@@ -12043,10 +12973,9 @@
Date: Mon Oct 29 12:34:33 2018 +0330
Merge pull request #1326 from ebraminio/test-ot-color
+
+ Revive and rename dump-emoji to test-ot-color but use public APIs instead
- Revive and rename dump-emoji to test-ot-color but use public APIs
- instead
-
commit 9c692e5b8d195d8e82538594d89865c609d708f3
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Mon Oct 29 11:36:11 2018 +0330
@@ -12054,8 +12983,7 @@
[test-ot-color] Use public APIs on the tool
src/Makefile.am | 9 +++
- src/test-ot-color.cc | 184
- +++++++++++++++++++++++++++++----------------------
+ src/test-ot-color.cc | 184 +++++++++++++++++++++++++++++----------------------
2 files changed, 113 insertions(+), 80 deletions(-)
commit fb525f8943b43fe241424c93461bee2b94af28e3
@@ -12073,8 +13001,7 @@
Revive dump-emoji
- src/dump-emoji.cc | 322
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/dump-emoji.cc | 322 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 322 insertions(+)
commit f10252b4b637b4aa0b74bb75963ae1e1a41b5b9f
@@ -12138,8 +13065,7 @@
[cbdt] Refactor get_strike()
- src/hb-ot-color-cbdt-table.hh | 39
- ++++++++++++++++-----------------------
+ src/hb-ot-color-cbdt-table.hh | 39 ++++++++++++++++-----------------------
src/hb-ot-color.cc | 2 +-
2 files changed, 17 insertions(+), 24 deletions(-)
@@ -12272,7 +13198,7 @@
Date: Sun Oct 28 15:44:40 2018 -0700
[sbix] Simplify ppem access
-
+
If struct members are simple and needed publicly, we make them public.
src/hb-ot-color-sbix-table.hh | 10 ++++------
@@ -12310,10 +13236,9 @@
Date: Sun Oct 28 15:33:12 2018 -0700
[sbix] Check glyph id before looking into unsafe array
+
+ That 'Z' at end of imageOffsetsZ is a reminder that you should check...
- That 'Z' at end of imageOffsetsZ is a reminder that you should
- check...
-
src/hb-ot-color-sbix-table.hh | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
@@ -12341,8 +13266,7 @@
[color] Remove more dump-emoji cruft
- src/hb-ot-color-cbdt-table.hh | 53
- -------------------------------------------
+ src/hb-ot-color-cbdt-table.hh | 53 -------------------------------------------
src/hb-ot-color-sbix-table.hh | 13 -----------
2 files changed, 66 deletions(-)
@@ -12353,8 +13277,7 @@
Remove dump-emoji
src/Makefile.am | 9 --
- src/dump-emoji.cc | 322
- ------------------------------------------
+ src/dump-emoji.cc | 322 ------------------------------------------
src/hb-ot-color-sbix-table.hh | 4 +-
3 files changed, 3 insertions(+), 332 deletions(-)
@@ -12438,8 +13361,7 @@
[sbix] Select best strike based on ppem
- src/hb-ot-color-sbix-table.hh | 50
- ++++++++++++++++++++++++-------------------
+ src/hb-ot-color-sbix-table.hh | 50 ++++++++++++++++++++++++-------------------
src/hb-ot-color.cc | 3 +--
src/hb-ot-font.cc | 2 +-
3 files changed, 30 insertions(+), 25 deletions(-)
@@ -12509,8 +13431,7 @@
[ot-color] Preparation for setting PNG width/height in extents
src/dump-emoji.cc | 7 +++---
- src/hb-ot-color-sbix-table.hh | 52
- +++++++++++++++++++++++++++++++++++--------
+ src/hb-ot-color-sbix-table.hh | 52 +++++++++++++++++++++++++++++++++++--------
src/hb-ot-color.cc | 14 +++++-------
src/hb-ot-font.cc | 7 +++++-
4 files changed, 59 insertions(+), 21 deletions(-)
@@ -12570,7 +13491,7 @@
Date: Sun Oct 28 08:26:30 2018 -0700
[name] Change hb_name_id_t back to unsigned int
-
+
https://github.com/harfbuzz/harfbuzz/commit/d941f66c75fe26f909b1ba248535cc372bbde851#commitcomment-31076011
docs/harfbuzz-sections.txt | 2 --
@@ -12597,7 +13518,7 @@
Date: Sat Oct 27 18:36:24 2018 -0700
[name] Make sure hb_name_id_t is int-sized
-
+
https://github.com/harfbuzz/harfbuzz/commit/d941f66c75fe26f909b1ba248535cc372bbde851#commitcomment-31068905
src/hb-ot-name.h | 4 +++-
@@ -12609,8 +13530,7 @@
[docs] Divide reference API into three chapters
- docs/harfbuzz-docs.xml | 213
- +++++++++++++------------------------------------
+ docs/harfbuzz-docs.xml | 213 +++++++++++++------------------------------------
1 file changed, 56 insertions(+), 157 deletions(-)
commit 1d40d72f291ed5e11850f8bd51a8562b57de1997
@@ -12642,7 +13562,7 @@
Date: Sat Oct 27 04:50:38 2018 -0700
[docs] Change section titles again
-
+
I think I like the uniform "hb-*" more.
src/hb-blob.cc | 2 +-
@@ -12675,7 +13595,7 @@
Date: Sat Oct 27 04:28:40 2018 -0700
[docs] Rename section titles to object names
-
+
More useful.
src/hb-blob.cc | 2 +-
@@ -12709,8 +13629,7 @@
src/Makefile.sources | 1 -
src/hb-graphite2.cc | 2 +-
src/hb-ot-layout.h | 42 ++++++++++++++++++++++++-
- src/hb-ot-tag.h | 78
- ----------------------------------------------
+ src/hb-ot-tag.h | 78 ----------------------------------------------
src/hb-ot.h | 1 -
src/hb-uniscribe.cc | 2 +-
8 files changed, 51 insertions(+), 96 deletions(-)
@@ -12722,8 +13641,7 @@
[docs] Fill in some sections
docs/harfbuzz-docs.xml | 20 ++++++--------
- docs/harfbuzz-sections.txt | 65
- +++++++++++++++++++---------------------------
+ docs/harfbuzz-sections.txt | 65 +++++++++++++++++++---------------------------
src/hb-blob.cc | 13 ++++++++++
src/hb-buffer.cc | 3 ++-
src/hb-common.cc | 23 ++++++++++++++++
@@ -12750,7 +13668,7 @@
Date: Sat Oct 27 15:04:43 2018 +0330
Merge pull request #1318 from ebraminio/png
-
+
Add a non-hooked _png _svg get emoji blob
commit 8180c37df0a856dbc3564c0aefd8b2acab8baf8a
@@ -12770,8 +13688,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Sat Oct 27 14:24:58 2018 +0330
- [ot-color/png] Try to get image blob from sbix first options.aat
- is set
+ [ot-color/png] Try to get image blob from sbix first options.aat is set
src/hb-ot-color.cc | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
@@ -12791,7 +13708,7 @@
Date: Sat Oct 27 03:18:45 2018 -0700
[docs] Fix hb_name_id_t
-
+
Yep, was not recognized without this patch!
src/hb-ot-name.h | 2 +-
@@ -12803,8 +13720,7 @@
[ot-color/png] Implement CBDT part
- src/hb-ot-color-cbdt-table.hh | 56
- +++++++++++++++++++++++++++++++++++++++----
+ src/hb-ot-color-cbdt-table.hh | 56 +++++++++++++++++++++++++++++++++++++++----
src/hb-ot-color.cc | 19 ++-------------
src/hb-ot-color.h | 4 ++++
test/api/test-ot-color.c | 25 ++++++++++++++++---
@@ -12824,9 +13740,9 @@
Date: Sat Oct 27 02:55:52 2018 -0700
[name] Make hb_name_id_t be the enum
-
+
This is like hb_script_t.
-
+
We had this exposed as unsigned int since 2.0.0 release in two APIs,
as well as hb_ot_layout_get_size_params() from earlier.
But since no one uses those (right?!), let's just fix this now.
@@ -12845,7 +13761,7 @@
Date: Sat Oct 27 02:49:32 2018 -0700
[name] Move HB_NAME_ID_INVALID into the enum
-
+
Don't know how to document anonymous enum members.
src/hb-ot-name.h | 6 +++---
@@ -12857,8 +13773,7 @@
[name] Move around
- src/hb-ot-name.h | 74
- ++++++++++++++++++++++++++++----------------------------
+ src/hb-ot-name.h | 74 ++++++++++++++++++++++++++++----------------------------
1 file changed, 37 insertions(+), 37 deletions(-)
commit 3b7e5f131383956e19642d28c938f1bc0d16295f
@@ -12866,10 +13781,9 @@
Date: Sat Oct 27 02:39:20 2018 -0700
[name] Rename hb_ot_name_get_names() to hb_ot_name_list_names()
+
+ And swap return value positions, so can be annotated for gobject-introspectin.
- And swap return value positions, so can be annotated for
- gobject-introspectin.
-
docs/harfbuzz-sections.txt | 2 +-
src/hb-ot-name.cc | 17 ++++++++---------
src/hb-ot-name.h | 6 +++---
@@ -12885,8 +13799,7 @@
src/hb-common.h | 30 +++++++++++++++++++++++++-
src/hb-ot-color.cc | 16 +++++++-------
src/hb-ot-layout.cc | 2 +-
- src/hb-ot-name.cc | 61
- ++++++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-name.cc | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++-
src/hb-ot-name.h | 15 +++++++++++++
5 files changed, 113 insertions(+), 11 deletions(-)
@@ -12914,7 +13827,7 @@
Date: Sat Oct 27 12:15:25 2018 +0330
[sbix] Set num_glyphs on accelerator
-
+
dump-emoji was broken without it
src/hb-ot-color-sbix-table.hh | 1 +
@@ -12949,8 +13862,7 @@
docs/harfbuzz-sections.txt | 2 +
src/dump-emoji.cc | 5 ++-
src/hb-ot-color-cbdt-table.hh | 27 ++++++++----
- src/hb-ot-color-sbix-table.hh | 98
- +++++++++++++++++++++++++++++++++++++------
+ src/hb-ot-color-sbix-table.hh | 98 +++++++++++++++++++++++++++++++++++++------
src/hb-ot-color.cc | 64 ++++++++++++++++++++++++++++
src/hb-ot-color.h | 9 ++++
test/api/test-ot-color.c | 32 ++++++++++++++
@@ -12961,7 +13873,7 @@
Date: Sat Oct 27 00:06:48 2018 -0700
Remove stale comment
-
+
Ugliness was fixed in 30eab97a0072fbc22d353082249e0e6e546cd86b
But yeah, my smell detector was working. Ugliness was buggy.
@@ -12974,8 +13886,7 @@
[docs] Hook up new symbols
- docs/harfbuzz-docs.xml | 46
- +++++++++++++++++++++++++++++++++++++++++-----
+ docs/harfbuzz-docs.xml | 46 +++++++++++++++++++++++++++++++++++++++++-----
docs/harfbuzz-sections.txt | 21 +++++++++++++++++++++
src/hb-ot-color.cc | 2 +-
3 files changed, 63 insertions(+), 6 deletions(-)
@@ -12985,7 +13896,7 @@
Date: Fri Oct 26 22:02:17 2018 -0700
[morx] Fix merge_cluster to end at last ligature component
-
+
Don't assume current position was a component in the ligature.
src/hb-aat-layout-morx-table.hh | 3 ++-
@@ -12996,9 +13907,9 @@
Date: Fri Oct 26 21:59:20 2018 -0700
[morx] Fix bailing out ligation at end-of-text
-
+
Check was after a move_to, which wouldn't work.
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11147
src/hb-aat-layout-morx-table.hh | 5 +++--
@@ -13009,9 +13920,9 @@
Date: Fri Oct 26 21:54:07 2018 -0700
Fix invalid memory read
-
+
Buffer might be relocated inside replace_glyphs().
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=895117
src/hb-ot-shape-normalize.cc | 3 ++-
@@ -13022,7 +13933,7 @@
Date: Fri Oct 26 21:21:18 2018 -0700
[indic] Fix infinite loop
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=863044
src/hb-ot-shape-complex-indic.cc | 2 +-
@@ -13033,11 +13944,11 @@
Date: Fri Oct 26 21:01:11 2018 -0700
Fix bunch of unused parameter warnings
-
+
Show up with gcc -O0.
-
+
There's a few more but those are functions that need to be filled in.
-
+
Maybe this is a lost battle...
src/gen-vowel-constraints.py | 4 ++--
@@ -13045,8 +13956,7 @@
src/hb-aat-layout-kerx-table.hh | 4 ++--
src/hb-aat-layout-morx-table.hh | 10 +++++-----
src/hb-face.cc | 2 +-
- src/hb-font.cc | 29
- ++++++++++++++--------------
+ src/hb-font.cc | 29 ++++++++++++++--------------
src/hb-graphite2.cc | 9 ++++++---
src/hb-machinery.hh | 4 ++--
src/hb-ot-color-cbdt-table.hh | 2 +-
@@ -13086,7 +13996,7 @@
Date: Fri Oct 26 20:31:14 2018 -0700
[fuzzing] Remove HB_NDEBUG
-
+
Not sure why it ever was added.
src/Makefile.am | 1 -
@@ -13098,8 +14008,7 @@
[fuzzing] Add more test
- ...z-testcase-minimized-harfbuzz_fuzzer-5659690013556736 | Bin 0 ->
- 2732 bytes
+ ...z-testcase-minimized-harfbuzz_fuzzer-5659690013556736 | Bin 0 -> 2732 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit c965eeadbc71943f2336a20dc16ac691c805b90e
@@ -13126,8 +14035,7 @@
[name] Fill out most missing language codes
- src/hb-ot-name-language.cc | 114
- +++++++++++++++++++++++----------------------
+ src/hb-ot-name-language.cc | 114 +++++++++++++++++++++++----------------------
1 file changed, 58 insertions(+), 56 deletions(-)
commit 622b014faf7bbe7a97f9aff959c434d1664c10d0
@@ -13176,8 +14084,7 @@
[name] Do record sanitization at run-time
- src/hb-dsalgs.hh | 62
- +++++++++++++++++++++++++++----------------------
+ src/hb-dsalgs.hh | 62 +++++++++++++++++++++++++++----------------------
src/hb-ot-name-table.hh | 22 +++++++++++-------
src/hb-ot-name.cc | 2 +-
3 files changed, 49 insertions(+), 37 deletions(-)
@@ -13198,8 +14105,7 @@
[name] Add src/test-name-table tool to show all font names
src/Makefile.am | 17 ++++++++-----
- src/test-name-table.cc | 67
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/test-name-table.cc | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 78 insertions(+), 6 deletions(-)
commit 7007bd9dff9f8eef3263f1b39327552ff1ebae3f
@@ -13208,8 +14114,7 @@
[name] Rebuild language list, include missing entries
- src/hb-ot-name-language.cc | 634
- ++++++++++++++++++++++++++-------------------
+ src/hb-ot-name-language.cc | 634 ++++++++++++++++++++++++++-------------------
1 file changed, 370 insertions(+), 264 deletions(-)
commit 68f172101c1228a7d669d71da1d0eeb96a10565e
@@ -13237,8 +14142,7 @@
[name] Add language mapping
src/Makefile.sources | 2 +
- src/hb-ot-name-language.cc | 349
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-name-language.cc | 349 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-name-language.hh | 40 ++++++
src/hb-ot-name-table.hh | 21 ++-
4 files changed, 399 insertions(+), 13 deletions(-)
@@ -13266,13 +14170,12 @@
Date: Tue Oct 23 20:51:53 2018 -0700
[name] Hook things up
-
+
Accept Mac Latin name entries as ASCII as well.
src/hb-ot-name-table.hh | 24 +++++++++++++++------
src/hb-ot-name.cc | 8 +++++--
- src/hb-utf.hh | 55
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-utf.hh | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 79 insertions(+), 8 deletions(-)
commit 69f5da0629f1e5a307fc49fe58490aa92d1bd0e2
@@ -13280,14 +14183,12 @@
Date: Tue Oct 23 20:30:40 2018 -0700
[name] More
-
- It assumes all names are encoded in UTF16-BE. Other than that,
- and not
+
+ It assumes all names are encoded in UTF16-BE. Other than that, and not
listing languages correctly, it's *supposed* to work.
src/hb-dsalgs.hh | 21 +++++++++++++++++++++
- src/hb-ot-name-table.hh | 37
- ++++++++++++++++++++++++++++++-------
+ src/hb-ot-name-table.hh | 37 ++++++++++++++++++++++++++++++-------
src/hb-ot-name.cc | 12 ++++++++----
src/hb-ot-os2-unicode-ranges.hh | 10 +++++-----
src/hb-unicode.cc | 8 ++++----
@@ -13311,8 +14212,7 @@
src/hb-ot-name.cc | 84 ++++++++++++++++++++++++++++++++++++------
src/hb-ot-name.h | 10 ++---
- src/hb-utf.hh | 107
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-utf.hh | 107 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 182 insertions(+), 19 deletions(-)
commit 84811a06a26508effe9f4a9eaf1be15297ecf0cb
@@ -13350,8 +14250,7 @@
[utf] Add UTF16-BE and UTF32-BE
src/hb-buffer.cc | 4 +--
- src/hb-utf.hh | 80
- ++++++++++++++++++++++++++++++++------------------------
+ src/hb-utf.hh | 80 ++++++++++++++++++++++++++++++++------------------------
2 files changed, 48 insertions(+), 36 deletions(-)
commit a826a8730f21ae996ae8f4d12c44dc18b9e8e933
@@ -13437,8 +14336,7 @@
[name] Finish accelerator sorting
- src/hb-ot-name-table.hh | 61
- +++++++++++++++++++++++++++++++++++++++++--------
+ src/hb-ot-name-table.hh | 61 +++++++++++++++++++++++++++++++++++++++++--------
src/hb-ot-name.h | 3 ++-
2 files changed, 53 insertions(+), 11 deletions(-)
@@ -13450,8 +14348,7 @@
src/hb-ot-face.cc | 1 +
src/hb-ot-face.hh | 7 +++---
- src/hb-ot-name-table.hh | 60
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-name-table.hh | 60 +++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-name.h | 3 +++
4 files changed, 68 insertions(+), 3 deletions(-)
@@ -13469,13 +14366,12 @@
Date: Fri Oct 26 15:40:12 2018 -0700
[indic/khmer/myanmar/use] Clarify clear_syllable
-
+
No logic change.
src/hb-ot-shape-complex-indic.cc | 3 ++-
src/hb-ot-shape-complex-khmer.cc | 4 +---
- src/hb-ot-shape-complex-myanmar.cc | 40
- ++++++++++++++++++--------------------
+ src/hb-ot-shape-complex-myanmar.cc | 40 ++++++++++++++++++--------------------
src/hb-ot-shape-complex-use.cc | 22 +++++++++++++++------
4 files changed, 38 insertions(+), 31 deletions(-)
@@ -13485,8 +14381,7 @@
[fuzz] Add a new testcase
- ...z-testcase-minimized-hb-shape-fuzzer-5658272078495744 | Bin 0 ->
- 2252 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5658272078495744 | Bin 0 -> 2252 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 30f18039b3c0e5748101f8934ae82aebfc5a83f7
@@ -13508,8 +14403,7 @@
[svg] Collapse SVGDocumentIndex into SVG
- src/hb-ot-color-svg-table.hh | 54
- +++++++++++++++-----------------------------
+ src/hb-ot-color-svg-table.hh | 54 +++++++++++++++-----------------------------
src/hb-ot-color.cc | 2 +-
test/api/test-ot-color.c | 2 +-
3 files changed, 20 insertions(+), 38 deletions(-)
@@ -13521,8 +14415,7 @@
[svg] Hide start_glyph and end_glyph from API
src/dump-emoji.cc | 21 ++++++++-------------
- src/hb-ot-color-svg-table.hh | 42
- ++++++++++++------------------------------
+ src/hb-ot-color-svg-table.hh | 42 ++++++++++++------------------------------
src/hb-ot-color.cc | 9 ++-------
src/hb-ot-color.h | 5 +----
test/api/test-ot-color.c | 11 ++---------
@@ -13533,7 +14426,7 @@
Date: Tue Oct 23 18:00:48 2018 +0330
[svg] Add public API
-
+
* hb_ot_color_has_svg
* hb_ot_color_glyph_svg_create_blob
@@ -13540,8 +14433,7 @@
src/dump-emoji.cc | 51 +++++++++++++++----------
src/hb-open-type.hh | 1 -
src/hb-ot-color-sbix-table.hh | 2 +
- src/hb-ot-color-svg-table.hh | 86
- ++++++++++++++++++++++++++++++++-----------
+ src/hb-ot-color-svg-table.hh | 86 ++++++++++++++++++++++++++++++++-----------
src/hb-ot-color.cc | 53 ++++++++++++++++++++++----
src/hb-ot-color.h | 13 +++++++
src/hb-ot-face.cc | 2 +
@@ -13555,7 +14447,7 @@
Date: Thu Oct 25 22:25:29 2018 -0700
[layout] Try to speed up collect_lookups some more
-
+
Barely made a dent :(.
src/hb-ot-layout-common.hh | 2 ++
@@ -13567,12 +14459,11 @@
Date: Thu Oct 25 21:42:19 2018 -0700
[layout] Memoize collect_features
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/1317
Fixes https://oss-fuzz.com/v2/testcase-detail/6543700493598720
- src/hb-ot-layout.cc | 55
- ++++++++++++++++++++++++++++++++++++++++++++++-------
+ src/hb-ot-layout.cc | 55 ++++++++++++++++++++++++++++++++++++++++++++++-------
1 file changed, 48 insertions(+), 7 deletions(-)
commit 84098b1639775aea5bf3f5d91fa6e657b612ce3a
@@ -13589,11 +14480,10 @@
Date: Thu Oct 25 21:26:08 2018 -0700
[layout] Add hb_collect_features_context_t
-
+
Towards https://github.com/harfbuzz/harfbuzz/pull/1317
- src/hb-ot-layout.cc | 66
- +++++++++++++++++++++++++++++------------------------
+ src/hb-ot-layout.cc | 66 +++++++++++++++++++++++++++++------------------------
1 file changed, 36 insertions(+), 30 deletions(-)
commit c237cdfcc74d33f77b2399b4d08228c2fcf50df5
@@ -13611,8 +14501,7 @@
[layout] More prep work to memoize collect_features() work
- src/hb-ot-layout.cc | 62
- ++++++++++++++++++++---------------------------------
+ src/hb-ot-layout.cc | 62 ++++++++++++++++++++---------------------------------
1 file changed, 23 insertions(+), 39 deletions(-)
commit e8e67503ff0a50eb10ad410d6a76a282ea494cf4
@@ -13620,12 +14509,11 @@
Date: Thu Oct 25 20:48:20 2018 -0700
[lookup] More prep work for memoizing collect_features
-
+
https://github.com/harfbuzz/harfbuzz/pull/1317
src/hb-ot-layout-common.hh | 2 ++
- src/hb-ot-layout.cc | 83
- +++++++++++++++++++++-------------------------
+ src/hb-ot-layout.cc | 83 +++++++++++++++++++++-------------------------
2 files changed, 40 insertions(+), 45 deletions(-)
commit 96828b97a8fc2c50721ce040bdde63c462908791
@@ -13633,7 +14521,7 @@
Date: Thu Oct 25 20:34:29 2018 -0700
[layout] Minor
-
+
We were returning the accelerator's lookup count. Returns table's.
They are the same except for OOM cases. Just shorter code.
@@ -13645,7 +14533,7 @@
Date: Thu Oct 25 20:32:05 2018 -0700
[layout] Fold one function inline
-
+
Preparation for fixing https://github.com/harfbuzz/harfbuzz/pull/1317
src/hb-ot-layout.cc | 22 +++-------------------
@@ -13656,9 +14544,9 @@
Date: Thu Oct 25 17:41:26 2018 -0700
[morx] Use deleted-glyph, instead of actual deletion, in Ligation
-
+
Closer to what CoreText does.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1302
src/hb-aat-layout-morx-table.hh | 3 +--
@@ -13687,7 +14575,7 @@
Date: Thu Oct 25 17:29:32 2018 -0700
[aat] Start adding support for DELETED-GLYPH
-
+
https://github.com/harfbuzz/harfbuzz/issues/1302
src/hb-aat-layout-common.hh | 2 ++
@@ -13698,7 +14586,7 @@
Date: Thu Oct 25 16:50:38 2018 -0700
[vector] Make it act more like pointer
-
+
Add pointer cast operator and plus operator.
src/hb-coretext.cc | 2 +-
@@ -13724,7 +14612,7 @@
Date: Thu Oct 25 16:35:36 2018 -0700
[set] Make array access more explicit
-
+
Follow up on 94e421abbfc7ede9aaf3c8d86bb0ff9992ea3123
src/hb-set.hh | 4 +++-
@@ -13753,11 +14641,10 @@
Date: Thu Oct 25 13:40:40 2018 -0700
dropped support of legacy CFF CharString ops
-
+
along with test & font
- src/hb-cff1-interp-cs.hh | 135
- +-------------------------------------
+ src/hb-cff1-interp-cs.hh | 135 +-------------------------------------
test/api/fonts/cff1_legacyops.otf | Bin 3104 -> 0 bytes
test/api/test-ot-extents-cff.c | 23 -------
3 files changed, 1 insertion(+), 157 deletions(-)
@@ -13776,7 +14663,7 @@
Date: Thu Oct 25 13:23:33 2018 -0700
[test] Rename some fonts
-
+
If we have duplicae font files in different directories, that would
break the oss-fuzz build currently. So, rename some to avoid
name class with text-rendering-test. Would be better to find
@@ -13787,8 +14674,7 @@
.../data/in-house/fonts/{TestTTC.ttc => TTC.ttc} | Bin
test/shaping/data/in-house/fonts/TestDFONT.dfont | Bin 3505 -> 0 bytes
test/shaping/data/in-house/tests/aat-morx.tests | 2 +-
- test/shaping/data/in-house/tests/aat-trak.tests | 22
- ++++++++++-----------
+ test/shaping/data/in-house/tests/aat-trak.tests | 22 ++++++++++-----------
test/shaping/data/in-house/tests/collections.tests | 12 +++++------
7 files changed, 18 insertions(+), 18 deletions(-)
@@ -13797,9 +14683,9 @@
Date: Thu Oct 25 13:19:34 2018 -0700
Fix possible overflow in bsearch impls
-
+
From bungeman.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/1314
src/hb-dsalgs.hh | 2 +-
@@ -13821,14 +14707,11 @@
Date: Thu Oct 25 13:44:27 2018 -0400
Remove some use of Crap in hb-set.
-
- When hb_set_t::page_for_insert needs to insert at the end of the
- page_map
+
+ When hb_set_t::page_for_insert needs to insert at the end of the page_map
it ends up evaluating '&page_map[i + 1]' which has hb_vector return an
- lvalue of a Crap so that nothing can be moved to its address. This
- turns
- into issues with ThreadSanitizer on Crap when two threads modify
- different
+ lvalue of a Crap so that nothing can be moved to its address. This turns
+ into issues with ThreadSanitizer on Crap when two threads modify different
hb_set_t instances. This can be avoided by using '&page_map[i] + 1'
instead.
@@ -13836,8 +14719,7 @@
1 file changed, 1 insertion(+), 1 deletion(-)
commit 2798ac1c28edc4ba6f2283784d1027393f588f8c
-Author: azure-pipelines[bot]
-<azure-pipelines[bot]@users.noreply.github.com>
+Author: azure-pipelines[bot] <azure-pipelines[bot]@users.noreply.github.com>
Date: Thu Oct 25 15:22:54 2018 +0000
Set up CI with Azure Pipelines
@@ -13850,7 +14732,7 @@
Date: Thu Oct 25 01:55:10 2018 +0200
[appveyor] Drop Cygwin builds again
-
+
They are so slow and we had only a couple of Cygwin build failure
reported in ~5 years.
@@ -13862,7 +14744,7 @@
Date: Wed Oct 24 22:58:22 2018 +0200
[appveyor] Limit make to three jobs
-
+
https://github.com/harfbuzz/harfbuzz/pull/1309#issuecomment-432778270
appveyor.yml | 4 ++--
@@ -13873,7 +14755,7 @@
Date: Wed Oct 24 16:46:07 2018 -0700
[vowel-constraints] Reset continuation on all dottedcircles
-
+
One of the was missed before. Not intentional.
src/gen-vowel-constraints.py | 9 +++++++--
@@ -13894,9 +14776,8 @@
Date: Wed Oct 24 11:23:21 2018 +0200
[appveyor] Do not update msys2
-
- Looks like AppVeyor has new enough packages for our needs. Cuts
- CI build
+
+ Looks like AppVeyor has new enough packages for our needs. Cuts CI build
time by 5 minutes.
appveyor.yml | 5 ++---
@@ -13925,11 +14806,11 @@
Date: Tue Oct 23 17:00:49 2018 -0700
[ot-font] Fix sign of ascent/descent
-
+
Some fonts, like msmincho, have positive number as descent
in vhea table. That's wrong. Just enforce sign on ascent/descent
when reading both horizontal and vertical metrics.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1248
src/hb-ot-hmtx-table.hh | 8 ++++----
@@ -13940,15 +14821,14 @@
Date: Tue Oct 23 16:46:10 2018 -0700
[morx] Fix cluster-merging when ligating
-
+
Only merge when actual ligature happened.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1305
src/hb-aat-layout-morx-table.hh | 7 ++++---
test/shaping/data/in-house/Makefile.sources | 1 +
- test/shaping/data/in-house/fonts/TestMORXTwentyeight.ttf | Bin 0 ->
- 2660 bytes
+ test/shaping/data/in-house/fonts/TestMORXTwentyeight.ttf | Bin 0 -> 2660 bytes
test/shaping/data/in-house/tests/aat-morx.tests | 1 +
4 files changed, 6 insertions(+), 3 deletions(-)
@@ -13980,8 +14860,7 @@
[aat] Fix up previous commit and add files
src/hb-aat-map.cc | 62 +++++++++++++++++++++++++++++++
- src/hb-aat-map.hh | 106
- +++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-map.hh | 106 +++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-map.cc | 1 +
src/hb-ot-shape.cc | 15 ++++++--
4 files changed, 181 insertions(+), 3 deletions(-)
@@ -13991,20 +14870,20 @@
Date: Tue Oct 23 14:14:03 2018 -0700
[aat] Allow enabling/disabling features
-
+
Only works at entire-buffer range, not sub-ranges.
-
+
Test with:
-
+
$ hb-shape Zapfino.dfont Zapfino
[Z_a_p_f_i_n_o=0+2333]
-
+
$ hb-shape Zapfino.dfont Zapfino --features=-dlig
[Z=0+416|a=1 at -21,0+264|p_f=2+433|i=4+181|n=5+261|o=6+250]
-
+
$ hb-shape Zapfino.dfont Zapfino --features=+dlig
[Z_a_p_f_i_n_o=0+2333]
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1303
src/Makefile.sources | 2 ++
@@ -14055,7 +14934,7 @@
Date: Tue Oct 23 03:10:56 2018 -0700
[trak] Allow disabling tracking for ranges of text
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1303
src/hb-aat-layout-trak-table.hh | 4 ++++
@@ -14078,9 +14957,8 @@
Date: Tue Oct 23 00:52:05 2018 +0330
Make tracking optout possible using 'trak' ot feature
-
- So '--features=-trak' or 'font-feature-settings: 'trak' 0;'
- can prevent
+
+ So '--features=-trak' or 'font-feature-settings: 'trak' 0;' can prevent
applying of tracking if used.
src/hb-ot-shape.cc | 10 +++++++---
@@ -14092,7 +14970,7 @@
Date: Tue Oct 23 02:51:42 2018 -0700
Touch up on previous commit
-
+
https://github.com/harfbuzz/harfbuzz/pull/1273
src/HBIndicVowelConstraints.txt | 97 ++++++
@@ -14101,10 +14979,8 @@
src/gen-vowel-constraints.py | 124 ++------
src/hb-ot-shape-complex-indic.cc | 10 +-
src/hb-ot-shape-complex-use.cc | 11 +-
- src/hb-ot-shape-complex-vowel-constraints.cc | 433
- ++++++++++++++++++++++++++
- src/hb-ot-shape-complex-vowel-constraints.hh | 447
- ++-------------------------
+ src/hb-ot-shape-complex-vowel-constraints.cc | 433 ++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-vowel-constraints.hh | 447 ++-------------------------
8 files changed, 606 insertions(+), 523 deletions(-)
commit 205737acdc268b1c90cf00bde2d2038519a8bf48
@@ -14118,8 +14994,7 @@
src/gen-vowel-constraints.py | 286 ++++++++++++++
src/hb-ot-shape-complex-indic.cc | 272 +------------
src/hb-ot-shape-complex-use.cc | 3 +-
- src/hb-ot-shape-complex-vowel-constraints.hh | 434
- +++++++++++++++++++++
+ src/hb-ot-shape-complex-vowel-constraints.hh | 434 +++++++++++++++++++++
test/shaping/README.md | 4 +-
.../46669c8860cbfea13562a6ca0d83130ee571137b.ttf | Bin 0 -> 7184 bytes
.../in-house/tests/use-vowel-letter-spoofing.tests | 94 +++++
@@ -14130,17 +15005,15 @@
Date: Tue Oct 23 02:19:32 2018 -0700
[VORG] Hook up to hb-ot-font's v_origin
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/544
-
+
Test added with NotoSansCJK, eg. with U+FF38.
src/hb-ot-face.cc | 1 -
- src/hb-ot-font.cc | 11
- +++++++++--
+ src/hb-ot-font.cc | 11 +++++++++--
src/hb-ot-vorg-table.hh | 6 ++++--
- .../fonts/4cbbc461be066fccc611dcc634af6e8cb2705537.ttf | Bin 0 ->
- 2808 bytes
+ .../fonts/4cbbc461be066fccc611dcc634af6e8cb2705537.ttf | Bin 0 -> 2808 bytes
test/shaping/data/in-house/tests/vertical.tests | 1 +
5 files changed, 14 insertions(+), 5 deletions(-)
@@ -14149,7 +15022,7 @@
Date: Tue Oct 23 02:09:42 2018 -0700
[VORG] Add get_y_origin()
-
+
Unhooked.
src/hb-ot-vorg-table.hh | 16 ++++++++++++++--
@@ -14160,14 +15033,13 @@
Date: Tue Oct 23 01:58:59 2018 -0700
[VORG] Add VORG table
-
+
Cherry-picked from cff-subset branch.
src/Makefile.sources | 1 +
src/hb-ot-face.cc | 1 +
src/hb-ot-face.hh | 1 +
- src/hb-ot-vorg-table.hh | 168
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-vorg-table.hh | 168 ++++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 171 insertions(+)
commit 531f9822b2e8a60f03c43d6f86ef9ed32c951f0e
@@ -14195,8 +15067,7 @@
[test/text-rendering-tests] Update from upstream
test/shaping/data/text-rendering-tests/Makefile.sources | 2 +-
- .../data/text-rendering-tests/fonts/TestTRAKOne.ttf | Bin 0 ->
- 1752 bytes
+ .../data/text-rendering-tests/fonts/TestTRAKOne.ttf | Bin 0 -> 1752 bytes
2 files changed, 1 insertion(+), 1 deletion(-)
commit 792071de4075cb9af0793f0d7c70da0780923bb6
@@ -14204,16 +15075,15 @@
Date: Mon Oct 22 23:38:34 2018 -0700
[morx] Leave ligature on stack after ligating
-
+
Test with Apple Color Emoji.ttf of ~66MB and following sequence:
-
- ./hb-shape Apple\ Color\ Emoji-old.ttf --font-funcs=ot -u
- U+1F468,200d,U+1F469,200d,U+1F467,200d,1f466
-
+
+ ./hb-shape Apple\ Color\ Emoji-old.ttf --font-funcs=ot -u U+1F468,200d,U+1F469,200d,U+1F467,200d,1f466
+
Should form full family if matching works correctly. It first makes
family of three, then makes family of four out of that and the last
two characters.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1292
src/hb-aat-layout-morx-table.hh | 1 -
@@ -14224,18 +15094,16 @@
Date: Tue Oct 23 09:23:48 2018 +0330
[ci] Disable llvm-gcc
-
- #define Null(Type) Null<typename hb_remove_const<typename
- hb_remove_reference<Type>::value>::value>()
-
+
+ #define Null(Type) Null<typename hb_remove_const<typename hb_remove_reference<Type>::value>::value>()
+
raises:
hb-blob.cc: In function 'hb_blob_t* hb_blob_get_empty()':
hb-blob.cc:194: error: using 'typename' outside of template
hb-blob.cc:194: error: using 'typename' outside of template
-
- Removing "typename"s fixes the issue but makes newer compiler fail
- apparently.
-
+
+ Removing "typename"s fixes the issue but makes newer compiler fail apparently.
+
Probably downstream can patch that locally till we get a solution.
.circleci/config.yml | 4 ++--
@@ -14256,7 +15124,7 @@
Date: Mon Oct 22 21:33:18 2018 -0700
Add hb_array<>() specialization for UnsizedArrayOf
-
+
Related https://github.com/harfbuzz/harfbuzz/issues/1301
src/hb-aat-layout-trak-table.hh | 2 +-
@@ -14270,9 +15138,9 @@
Date: Mon Oct 22 21:27:45 2018 -0700
Add hb_array<>()
-
+
Simplifies transient object creation.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1301
src/hb-aat-layout-trak-table.hh | 2 +-
@@ -14286,7 +15154,7 @@
Date: Mon Oct 22 21:22:25 2018 -0700
[color] Use Index for colorIdx
-
+
Doesn't matter, but matches the description.
src/hb-ot-color-colr-table.hh | 2 +-
@@ -14297,12 +15165,11 @@
Date: Mon Oct 22 21:18:27 2018 -0700
Remove const and references when binding Null()
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1299
+
+ Removes anomaly I was seeing in cpal table trying to use implicit Null(NameID).
- Removes anomaly I was seeing in cpal table trying to use implicit
- Null(NameID).
-
src/hb-atomic.hh | 5 +----
src/hb-common.cc | 2 +-
src/hb-ft.cc | 2 +-
@@ -14318,10 +15185,9 @@
Date: Mon Oct 22 18:20:57 2018 -0700
[color] Add HB_COLOR
-
+
Normally I would have added to_string / from_string like other types
- have. But since we don't use hb_color_t much, I'm not going to
- do that.
+ have. But since we don't use hb_color_t much, I'm not going to do that.
Although, if we did, we could use it in hb-view to parse colors...
src/hb-common.h | 14 +++++++++-----
@@ -14332,11 +15198,10 @@
Date: Mon Oct 22 16:55:12 2018 -0700
[color] Finish reviewing / revamping CPAL
-
+
Now to hb_color_t.
- src/hb-ot-color-cpal-table.hh | 52
- ++++++++++++++++++++++---------------------
+ src/hb-ot-color-cpal-table.hh | 52 ++++++++++++++++++++++---------------------
src/hb-ot-color.cc | 33 +++++----------------------
src/hb-ot-color.h | 10 ++++-----
3 files changed, 38 insertions(+), 57 deletions(-)
@@ -14365,8 +15230,7 @@
[color] Rely on CPALV1Tail Null object
- src/hb-ot-color-cpal-table.hh | 39
- ++++++++++++++-------------------------
+ src/hb-ot-color-cpal-table.hh | 39 ++++++++++++++-------------------------
1 file changed, 14 insertions(+), 25 deletions(-)
commit d7865107ea4664e04c03a1d79678cdcadc0d5ea5
@@ -14374,7 +15238,7 @@
Date: Mon Oct 22 16:18:34 2018 -0700
Remove const from hb_array_t details
-
+
Will come in through <T> if desired.
src/hb-aat-layout-trak-table.hh | 6 +++---
@@ -14387,14 +15251,13 @@
Date: Mon Oct 22 16:16:21 2018 -0700
[color] Use hb_array_t in CPAL
-
+
Doesn't work though, ouch :(. Need to figure out if it's unreasonable
to expect Null(T) inside hb_array_t<T> to see the later specialization
of Null for NameID.
src/hb-open-type.hh | 3 ++-
- src/hb-ot-color-cpal-table.hh | 47
- ++++++++++++++++++++++---------------------
+ src/hb-ot-color-cpal-table.hh | 47 ++++++++++++++++++++++---------------------
src/hb-static.cc | 1 +
3 files changed, 27 insertions(+), 24 deletions(-)
@@ -14403,7 +15266,7 @@
Date: Mon Oct 22 14:54:55 2018 -0700
[color] Check for null CPAL arrays
-
+
We cannot use a nullable offset here though.
src/hb-ot-color-cpal-table.hh | 12 ++++++------
@@ -14415,8 +15278,7 @@
[color] More CPAL rename
- src/hb-ot-color-cpal-table.hh | 104
- +++++++++++++++++++++---------------------
+ src/hb-ot-color-cpal-table.hh | 104 +++++++++++++++++++++---------------------
src/hb-ot-color.cc | 6 +--
2 files changed, 54 insertions(+), 56 deletions(-)
@@ -14489,8 +15351,7 @@
src/hb-ot-color.cc | 81 ++++++++++++++---------------
src/hb-ot-color.h | 26 +++++-----
- test/api/test-ot-color.c | 130
- +++++++++++++++++++++++------------------------
+ test/api/test-ot-color.c | 130 +++++++++++++++++++++++------------------------
3 files changed, 117 insertions(+), 120 deletions(-)
commit 3bf91bd2690cda34a7687ed5465dc4bb0672f2b6
@@ -14498,21 +15359,17 @@
Date: Mon Oct 22 12:40:38 2018 -0700
[color] Rewrite colr access
-
- COLR table has one function: return layers for a glyph, and we
- expose exactly
- that, so should just wire it through. Also use sub_array() for
- verifiable
+
+ COLR table has one function: return layers for a glyph, and we expose exactly
+ that, so should just wire it through. Also use sub_array() for verifiable
safety.
-
- Also, BaseGlyphRecord's null object is enough. We don't need to
- special-case
+
+ Also, BaseGlyphRecord's null object is enough. We don't need to special-case
the not-found.
src/hb-dsalgs.hh | 11 +++++++++
src/hb-open-type.hh | 2 +-
- src/hb-ot-color-colr-table.hh | 53
- +++++++++++++++++++++++--------------------
+ src/hb-ot-color-colr-table.hh | 53 +++++++++++++++++++++++--------------------
src/hb-ot-color.cc | 19 +---------------
4 files changed, 41 insertions(+), 44 deletions(-)
@@ -14521,7 +15378,7 @@
Date: Mon Oct 22 10:29:01 2018 -0700
[colr] Add hb_ot_color_layer_t
-
+
We never return parallel arrays from functions. That's inconvenient
and hard to bind.
@@ -14535,13 +15392,12 @@
Date: Sun Oct 21 19:23:11 2018 -0700
[color] Rename / reorder a bit
-
+
Implement has_data() for realz.
src/hb-ot-color-colr-table.hh | 2 ++
src/hb-ot-color-cpal-table.hh | 2 ++
- src/hb-ot-color.cc | 78
- ++++++++++++++++++++++++-------------------
+ src/hb-ot-color.cc | 78 ++++++++++++++++++++++++-------------------
src/hb-ot-color.h | 33 ++++++++++++------
test/api/test-ot-color.c | 30 ++++++++---------
5 files changed, 85 insertions(+), 60 deletions(-)
@@ -14568,7 +15424,7 @@
Date: Sun Oct 21 19:02:47 2018 -0700
[color] Rename "gid" to "glyph"
-
+
We don't expose "gid" in API.
src/hb-ot-color.cc | 12 ++++++------
@@ -14613,7 +15469,7 @@
Date: Sun Oct 21 17:42:51 2018 -0700
[colr] Move compare function into a static
-
+
Not sure if MSVC would be unhappy about this.
src/hb-ot-color-colr-table.hh | 16 ++++++++--------
@@ -14633,7 +15489,7 @@
Date: Sun Oct 21 17:39:39 2018 -0700
[colr] Move sanitize() to right place
-
+
Sanitize always comes just before data member definitions, so
it's easy to cross-check.
@@ -14645,7 +15501,7 @@
Date: Sun Oct 21 17:39:00 2018 -0700
[colr] Touch up a bit
-
+
When a struct is plain old data with no references, etc, it's okay
to mark its members public.
@@ -14701,8 +15557,7 @@
[CPAL] Add palette entry and enable palette flag API
src/hb-ot-color-cpal-table.hh | 66 +++++++++++++++----------
- src/hb-ot-color.cc | 109
- ++++++++++++++++++++++++------------------
+ src/hb-ot-color.cc | 109 ++++++++++++++++++++++++------------------
src/hb-ot-color.h | 23 +++++++++
test/api/test-ot-color.c | 35 ++++++++++++--
4 files changed, 158 insertions(+), 75 deletions(-)
@@ -14728,8 +15583,7 @@
src/dump-emoji.cc | 26 ++++----
src/hb-common.h | 12 ++++
src/hb-ot-color-cpal-table.hh | 37 +++++-------
- src/hb-ot-color.cc | 136
- +++++++++++++++++++++++++-----------------
+ src/hb-ot-color.cc | 136 +++++++++++++++++++++++++-----------------
src/hb-ot-color.h | 38 +++---------
test/api/test-ot-color.c | 101 +++++++++++++++----------------
6 files changed, 179 insertions(+), 171 deletions(-)
@@ -14781,8 +15635,7 @@
Make ot-color tests pass
- test/api/test-ot-color.c | 52
- ++++++++++++++++++++++++------------------------
+ test/api/test-ot-color.c | 52 ++++++++++++++++++++++++------------------------
1 file changed, 26 insertions(+), 26 deletions(-)
commit d4e928b1421c154adbda9b6e1f2cf804b21654cb
@@ -14792,8 +15645,7 @@
[color] Minimal API for COLR/CPAL
src/Makefile.sources | 1 +
- src/dump-emoji.cc | 114
- +++++++++++----------
+ src/dump-emoji.cc | 114 +++++++++++----------
src/hb-ot-color-colr-table.hh | 12 +--
src/hb-ot-color-cpal-table.hh | 51 +++------
src/hb-ot-color.cc | 87 +++++++++++-----
@@ -14811,8 +15663,7 @@
[fuzz] Add a found hb-subset testcase
- ...z-testcase-minimized-hb-subset-fuzzer-5725847365877760 | Bin 0 ->
- 880 bytes
+ ...z-testcase-minimized-hb-subset-fuzzer-5725847365877760 | Bin 0 -> 880 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 0ecddad7c5948ecd7879bc7507f8a7a2d99eee86
@@ -14829,13 +15680,12 @@
Date: Sun Oct 21 11:37:38 2018 +0330
[fuzz] Add more testcases
-
+
Fixed already but better to have anyway.
-
+
One didn't have minimized but it was only 164 B, so
- ...uzz-testcase-minimized-hb-shape-fuzzer-5706010589659136 | Bin 0 ->
- 52 bytes
+ ...uzz-testcase-minimized-hb-shape-fuzzer-5706010589659136 | Bin 0 -> 52 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 4fa94a3e39c21bc1dcdbbd5bda99bff1e1490b0e
@@ -14844,7 +15694,7 @@
Date: Sun Oct 21 11:36:41 2018 +0330
Merge pull request #1290 from ebraminio/testopenfont
-
+
[test] Unify font file opening across the tests
commit c110878cb61f5df99e9d97dda253f2987ddce58e
@@ -14874,8 +15724,7 @@
[fuzzing] Add more font
- .../clusterfuzz-testcase-hb-shape-fuzzer-5097734906839040 | Bin 0 ->
- 164 bytes
+ .../clusterfuzz-testcase-hb-shape-fuzzer-5097734906839040 | Bin 0 -> 164 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 1e39833ba8547c90a0a4ed7f265a6c4bc8eb8fe1
@@ -14910,7 +15759,7 @@
Date: Sat Oct 20 16:49:16 2018 -0700
[docs] Fix warning
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1260
src/hb-deprecated.h | 6 ------
@@ -14923,8 +15772,7 @@
[kerx] Implement tuple-kerning in Format0
- src/hb-aat-layout-kerx-table.hh | 44
- ++++++++++++++++++++++++++++-------------
+ src/hb-aat-layout-kerx-table.hh | 44 ++++++++++++++++++++++++++++-------------
1 file changed, 30 insertions(+), 14 deletions(-)
commit 0a3b7a0fb0734a66926dfda5d95d3cacea8890ce
@@ -14952,7 +15800,7 @@
Date: Sat Oct 20 12:09:41 2018 -0700
[kerx] Fix sanitize of KerxSubtableFormat2::array read
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11033
src/hb-aat-layout-kerx-table.hh | 5 +++--
@@ -14963,7 +15811,7 @@
Date: Sat Oct 20 12:04:51 2018 -0700
[aat] Fix LookupFormat10 sanitize
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11060
src/hb-aat-layout-common.hh | 2 +-
@@ -14983,7 +15831,7 @@
Date: Sat Oct 20 21:13:25 2018 +0330
[TODO] Remove BCP 47 language handling item
-
+
Closes https://github.com/harfbuzz/harfbuzz/issues/1286
TODO | 2 --
@@ -14995,10 +15843,8 @@
[fuzzing] Add new testcases
- .../clusterfuzz-testcase-hb-shape-fuzzer-5688420752424960 | Bin 0 ->
- 163 bytes
- ...zz-testcase-minimized-hb-shape-fuzzer-5688420752424960 | Bin 0 ->
- 69 bytes
+ .../clusterfuzz-testcase-hb-shape-fuzzer-5688420752424960 | Bin 0 -> 163 bytes
+ ...zz-testcase-minimized-hb-shape-fuzzer-5688420752424960 | Bin 0 -> 69 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
commit 1e55e21dea78aaaddc0715e7df96fd198ec8f78a
@@ -15007,7 +15853,7 @@
Date: Sat Oct 20 07:45:46 2018 +0330
Merge pull request #1283 from khaledhosny/cygwin
-
+
Cygwin fixes and CI build
commit 964ae32aac793540a49c44efab878592394d48db
@@ -15075,7 +15921,7 @@
Date: Fri Oct 19 19:12:33 2018 -0700
[font] Fix parallel funcs passing to eachover in infinite-loop
-
+
Fixes test just added.
src/hb-font.cc | 20 +++++++++++++-------
@@ -15087,11 +15933,10 @@
Date: Fri Oct 19 19:01:01 2018 -0700
[font] Add failing test amongst font-func parallels infinite-looping
-
+
Reported by Nona while updating Android to HarfBuzz 2.0.0.
- test/api/test-font.c | 64
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-font.c | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
commit d084719ff5a9e0e363bf352037f85b884bff11a7
@@ -15099,7 +15944,7 @@
Date: Sat Oct 20 00:18:36 2018 +0200
Add Cygwin CI build
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1274
appveyor.yml | 15 +++++++++++++++
@@ -15110,12 +15955,11 @@
Date: Fri Oct 19 16:06:54 2018 -0700
[kerx] Implement variation-kerning tables (without the variation part)
-
+
SFSNDisplay uses these. We just apply the default kern without
variations right now. But at least makes the default kern work.
- src/hb-aat-layout-kerx-table.hh | 37
- +++++++++++++++++++++++++++++--------
+ src/hb-aat-layout-kerx-table.hh | 37 +++++++++++++++++++++++++++++--------
1 file changed, 29 insertions(+), 8 deletions(-)
commit f7c0b4319c6f82f1e0020a0029469d8953a7a161
@@ -15125,8 +15969,7 @@
[aat] Implement LookupFormat10
src/hb-aat-layout-ankr-table.hh | 6 +++--
- src/hb-aat-layout-common.hh | 55
- ++++++++++++++++++++++++++++++++++++++---
+ src/hb-aat-layout-common.hh | 55 ++++++++++++++++++++++++++++++++++++++---
src/hb-machinery.hh | 4 +++
src/hb-open-type.hh | 3 +++
4 files changed, 63 insertions(+), 5 deletions(-)
@@ -15136,7 +15979,7 @@
Date: Fri Oct 19 22:21:39 2018 +0200
Use g_strdup instead of strdup
-
+
Cygwin does not seem to have strdup.
util/options.hh | 2 +-
@@ -15147,7 +15990,7 @@
Date: Fri Oct 19 22:04:56 2018 +0200
Use O_BINARY instead of _O_BINARY
-
+
Cygwin does not seem to have the later
src/hb-blob.cc | 6 +++---
@@ -15167,7 +16010,7 @@
Date: Fri Oct 19 11:15:35 2018 -0700
[RELEASING] Post-mortem
-
+
Re https://github.com/harfbuzz/harfbuzz/issues/1271
RELEASING.md | 5 ++++-
@@ -15196,7 +16039,7 @@
Date: Fri Oct 19 12:05:26 2018 +0330
Fix hb_map_is_empty logic
-
+
This needs reviewing
src/hb-map.hh | 2 +-
@@ -15211,8 +16054,7 @@
src/Makefile.am | 2 +-
test/api/Makefile.am | 6 ++-
- test/api/test-map.c | 114
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-map.c | 114 +++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 120 insertions(+), 2 deletions(-)
commit 8a5eba711069285e8d8b6d682eea0090256527bb
@@ -15257,10 +16099,9 @@
Date: Fri Oct 19 18:46:41 2018 +0330
[ci] Run valgrind on test/api
-
+
run-shape-fuzzer-tests.py automatically runs valgrind if see available
- but test/api runs it by request, we probably should normalize the
- approaches
+ but test/api runs it by request, we probably should normalize the approaches
later
.circleci/config.yml | 6 +++++-
@@ -15305,8 +16146,7 @@
Enable valgrind and dedicate a bot to it
.circleci/config.yml | 13 +++++++++++++
- test/fuzzing/run-shape-fuzzer-tests.py | 31
- +++++++++++++++++++++++++++++++
+ test/fuzzing/run-shape-fuzzer-tests.py | 31 +++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+)
commit bccd09d6c7baa99fdaccb8c5b3ff7e1834edd3bf
@@ -15315,8 +16155,7 @@
Minor, tweak spaces on hb-shape-fuzzer.cc
- test/fuzzing/hb-shape-fuzzer.cc | 42
- ++++++++++++++++++++---------------------
+ test/fuzzing/hb-shape-fuzzer.cc | 42 ++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
commit fbf665b307c8cc9f16f5897671bfdd8719a195b5
@@ -15325,32 +16164,19 @@
[fuzz] Add more found cases (#1275)
- ...clusterfuzz-testcase-hb-shape-fuzzer-5728971283496960 | Bin 0 ->
- 101 bytes
- ...terfuzz-testcase-minimized-hb-fuzzer-5713868010553344 | Bin 0 ->
- 370 bytes
- ...terfuzz-testcase-minimized-hb-fuzzer-6278851874258944 | Bin 0 ->
- 598 bytes
- ...z-testcase-minimized-hb-shape-fuzzer-5649959857160192 | Bin 0 ->
- 3608 bytes
- ...z-testcase-minimized-hb-shape-fuzzer-5664873493561344 | Bin 0 ->
- 400 bytes
- ...z-testcase-minimized-hb-shape-fuzzer-5762953198960640 | Bin 0 ->
- 62 bytes
- ...z-testcase-minimized-hb-shape-fuzzer-5764636557705216 | Bin 0 ->
- 2184 bytes
- ...-testcase-minimized-hb-subset-fuzzer-5690658895953920 | Bin 0 ->
- 2735 bytes
- ...-testcase-minimized-hb-subset-fuzzer-5695279609675776 | Bin 0 ->
- 135 bytes
- ...-testcase-minimized-hb-subset-fuzzer-5718215406125056 | Bin 0 ->
- 107 bytes
- ...-testcase-minimized-hb-subset-fuzzer-5743250149736448 | Bin 0 ->
- 103 bytes
- ...-testcase-minimized-hb-subset-fuzzer-5765071062958080 | Bin 0 ->
- 329 bytes
- ...ized-hb-subset-get-codepoints-fuzzer-5930139383758848 | Bin 0 ->
- 9410 bytes
+ ...clusterfuzz-testcase-hb-shape-fuzzer-5728971283496960 | Bin 0 -> 101 bytes
+ ...terfuzz-testcase-minimized-hb-fuzzer-5713868010553344 | Bin 0 -> 370 bytes
+ ...terfuzz-testcase-minimized-hb-fuzzer-6278851874258944 | Bin 0 -> 598 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5649959857160192 | Bin 0 -> 3608 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5664873493561344 | Bin 0 -> 400 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5762953198960640 | Bin 0 -> 62 bytes
+ ...z-testcase-minimized-hb-shape-fuzzer-5764636557705216 | Bin 0 -> 2184 bytes
+ ...-testcase-minimized-hb-subset-fuzzer-5690658895953920 | Bin 0 -> 2735 bytes
+ ...-testcase-minimized-hb-subset-fuzzer-5695279609675776 | Bin 0 -> 135 bytes
+ ...-testcase-minimized-hb-subset-fuzzer-5718215406125056 | Bin 0 -> 107 bytes
+ ...-testcase-minimized-hb-subset-fuzzer-5743250149736448 | Bin 0 -> 103 bytes
+ ...-testcase-minimized-hb-subset-fuzzer-5765071062958080 | Bin 0 -> 329 bytes
+ ...ized-hb-subset-get-codepoints-fuzzer-5930139383758848 | Bin 0 -> 9410 bytes
13 files changed, 0 insertions(+), 0 deletions(-)
commit 51fba41cc958ded3afc6c1e738895b0a81993e18
@@ -15375,12 +16201,11 @@
Date: Thu Oct 18 13:04:21 2018 -0700
implement flex ops for glyph extents/subset
-
+
also removed unused CSInterpEnv::move_[xy]_with_arg
fixed bug a width being left over on argStack with CFF1
- src/hb-cff-interp-cs-common.hh | 157
- +++++++++++++++++++++++++++++++++++------
+ src/hb-cff-interp-cs-common.hh | 157 +++++++++++++++++++++++++++++++++++------
src/hb-cff1-interp-cs.hh | 1 +
src/hb-subset-cff1.cc | 4 --
src/hb-subset-cff2.cc | 4 --
@@ -15392,8 +16217,7 @@
2.0.0
- NEWS | 68
- +++++++++++++++++++++++++++++++++++++++++++++++++++++
+ NEWS | 68 +++++++++++++++++++++++++++++++++++++++++++++++++++++
configure.ac | 2 +-
src/hb-buffer.cc | 4 ++--
src/hb-common.h | 4 ++--
@@ -15421,21 +16245,18 @@
Date: Thu Oct 18 11:06:37 2018 +0330
[ubsan] Use unsigned int instead enum where needed (#1270)
-
+
Actually the check is right,
-
+
On -myanmar.hh, on that particular switch, OT_C is indic_category_t
- but OT_D is myanmar_category_t so we are mixing the types in one
- variable.
-
- And on -arabic.cc, step can goes one number higher than step_t enum
- in the
+ but OT_D is myanmar_category_t so we are mixing the types in one variable.
+
+ And on -arabic.cc, step can goes one number higher than step_t enum in the
loop so we are actually using it as an unsinged int.
.circleci/config.yml | 2 +-
src/hb-ot-shape-complex-arabic.cc | 4 ++--
- src/hb-ot-shape-complex-myanmar.hh | 48
- +++++++++++++++++++-------------------
+ src/hb-ot-shape-complex-myanmar.hh | 48 +++++++++++++++++++-------------------
3 files changed, 27 insertions(+), 27 deletions(-)
commit 64df6b0b0f9d221e14811084f2412a01cf4deb46
@@ -15452,7 +16273,7 @@
Date: Wed Oct 17 23:06:53 2018 -0700
More warning fix
-
+
Okay, let's see if the gods are happy now...
src/hb-static.cc | 2 +-
@@ -15499,7 +16320,7 @@
Date: Wed Oct 17 22:34:16 2018 -0700
[aat] Fix sanitize slowdown
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=11034
src/hb-aat-layout-common.hh | 4 ++++
@@ -15511,15 +16332,12 @@
Date: Wed Oct 17 21:52:14 2018 -0700
Revert "[test] Remove not-fixed yet testcases (#1268)"
-
+
This reverts commit 191eef823fe95355425621f8e002dfe7fe632383.
- ...rfuzz-testcase-minimized-hb-fuzzer-4548492505645056 | Bin 0 ->
- 122 bytes
- ...rfuzz-testcase-minimized-hb-fuzzer-6210176798425088 | Bin 0 ->
- 1420 bytes
- ...testcase-minimized-hb-shape-fuzzer-5738888765636608 | Bin 0 ->
- 267731 bytes
+ ...rfuzz-testcase-minimized-hb-fuzzer-4548492505645056 | Bin 0 -> 122 bytes
+ ...rfuzz-testcase-minimized-hb-fuzzer-6210176798425088 | Bin 0 -> 1420 bytes
+ ...testcase-minimized-hb-shape-fuzzer-5738888765636608 | Bin 0 -> 267731 bytes
3 files changed, 0 insertions(+), 0 deletions(-)
commit af99b20dfddbca75e68f84c5aa465a54728990a6
@@ -15527,7 +16345,7 @@
Date: Thu Oct 18 08:35:20 2018 +0330
[ci/ubsan] Disable enum sanitization
-
+
Behdad apparently not interested on them
.circleci/config.yml | 2 +-
@@ -15538,7 +16356,7 @@
Date: Wed Oct 17 21:41:25 2018 -0700
[aat] Another try at fixing Lookup null objects...
-
+
Ugly as hell, and don't even understand why some bits are needed.
But the logic is sound.
@@ -15551,17 +16369,14 @@
Date: Thu Oct 18 08:04:18 2018 +0330
[test] Remove not-fixed yet testcases (#1268)
-
+
I added them but now that I think, it is a bad idea to have them as
fuzzing bots will find good seeds to tweak in order to find easy new
testcases which causes duplicated issues.
- ...rfuzz-testcase-minimized-hb-fuzzer-4548492505645056 | Bin 122 ->
- 0 bytes
- ...rfuzz-testcase-minimized-hb-fuzzer-6210176798425088 | Bin 1420 ->
- 0 bytes
- ...testcase-minimized-hb-shape-fuzzer-5738888765636608 | Bin 267731 ->
- 0 bytes
+ ...rfuzz-testcase-minimized-hb-fuzzer-4548492505645056 | Bin 122 -> 0 bytes
+ ...rfuzz-testcase-minimized-hb-fuzzer-6210176798425088 | Bin 1420 -> 0 bytes
+ ...testcase-minimized-hb-shape-fuzzer-5738888765636608 | Bin 267731 -> 0 bytes
3 files changed, 0 insertions(+), 0 deletions(-)
commit 392e1f4ddd7eb649e1a71755b9bcf6431739f98f
@@ -15570,8 +16385,7 @@
[test/shape-fuzzer] fail on timeout and ubsan errors (#1267)
- test/fuzzing/run-shape-fuzzer-tests.py | 38
- ++++++++++++++++++++++++++++++----
+ test/fuzzing/run-shape-fuzzer-tests.py | 38 ++++++++++++++++++++++++++++++----
1 file changed, 34 insertions(+), 4 deletions(-)
commit eeddda3ec6c28b411d33c74938ec6198c7f6888d
@@ -15579,7 +16393,7 @@
Date: Thu Oct 18 07:38:47 2018 +0330
[util] Better file-not-found error from hb-shape / hb-view
-
+
fixes #1266
util/options.cc | 2 +-
@@ -15591,10 +16405,8 @@
[fuzz] Add more new testcases
- ...testcase-minimized-hb-shape-fuzzer-5718464350650368 | Bin 0 ->
- 41 bytes
- ...testcase-minimized-hb-shape-fuzzer-5738888765636608 | Bin 0 ->
- 267731 bytes
+ ...testcase-minimized-hb-shape-fuzzer-5718464350650368 | Bin 0 -> 41 bytes
+ ...testcase-minimized-hb-shape-fuzzer-5738888765636608 | Bin 0 -> 267731 bytes
2 files changed, 0 insertions(+), 0 deletions(-)
commit fd282eb3285e6d20f77e8a3a7237b677433ccbb4
@@ -15603,8 +16415,7 @@
[fuzz] Add a new testcase
- .../clusterfuzz-testcase-hb-shape-fuzzer-5634395566768128 | Bin 0 ->
- 106 bytes
+ .../clusterfuzz-testcase-hb-shape-fuzzer-5634395566768128 | Bin 0 -> 106 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 9d42d70269b879e67f3c7724beab8e4cdbfc877a
@@ -15612,9 +16423,9 @@
Date: Wed Oct 17 17:55:47 2018 -0700
[trak] Fix calc
-
+
We were getting the first track record always. Ie. this line:
-
+
if (trackTable[i].get_track_value () == 0.f)
{
- trackTableEntry = &trackTable[0];
@@ -15621,12 +16432,11 @@
+ trackTableEntry = &trackTable[i];
break;
}
-
+
The rest is cleanup.
+
+ Fixes https://github.com/harfbuzz/harfbuzz/issues/1263 for the most part.
- Fixes https://github.com/harfbuzz/harfbuzz/issues/1263 for the
- most part.
-
src/hb-aat-layout-trak-table.hh | 17 ++++++++---------
1 file changed, 8 insertions(+), 9 deletions(-)
@@ -15636,22 +16446,14 @@
[fuzzing] Move fuzzing fonts from api/ here
- ...estcase-minimized-hb-subset-fuzzer-5521982557782016 | Bin 1228 ->
- 0 bytes
- ...estcase-minimized-hb-subset-fuzzer-5542653037903872 | Bin 160249 ->
- 0 bytes
- ...estcase-minimized-hb-subset-fuzzer-5609911946838016 | Bin 313 ->
- 0 bytes
- ...estcase-minimized-hb-subset-fuzzer-5670861909524480 | Bin 1298 ->
- 0 bytes
- ...estcase-minimized-hb-subset-fuzzer-5750092395970560 | Bin 72435 ->
- 0 bytes
- ...estcase-minimized-hb-subset-fuzzer-6651660668502016 | Bin 15229 ->
- 0 bytes
- ...ed-hb-subset-get-codepoints-fuzzer-5973295416475648 | Bin 109 ->
- 0 bytes
- ...ed-hb-subset-get-codepoints-fuzzer-6136125075750912 | Bin 65816 ->
- 0 bytes
+ ...estcase-minimized-hb-subset-fuzzer-5521982557782016 | Bin 1228 -> 0 bytes
+ ...estcase-minimized-hb-subset-fuzzer-5542653037903872 | Bin 160249 -> 0 bytes
+ ...estcase-minimized-hb-subset-fuzzer-5609911946838016 | Bin 313 -> 0 bytes
+ ...estcase-minimized-hb-subset-fuzzer-5670861909524480 | Bin 1298 -> 0 bytes
+ ...estcase-minimized-hb-subset-fuzzer-5750092395970560 | Bin 72435 -> 0 bytes
+ ...estcase-minimized-hb-subset-fuzzer-6651660668502016 | Bin 15229 -> 0 bytes
+ ...ed-hb-subset-get-codepoints-fuzzer-5973295416475648 | Bin 109 -> 0 bytes
+ ...ed-hb-subset-get-codepoints-fuzzer-6136125075750912 | Bin 65816 -> 0 bytes
test/api/test-subset-glyf.c | 2 +-
test/api/test-subset-hdmx.c | 4 ++--
test/api/test-subset-hmtx.c | 2 +-
@@ -15676,10 +16478,9 @@
Date: Tue Oct 16 18:35:03 2018 -0700
[buffer] Add an assert
+
+ See if it helps debugging https://bugs.chromium.org/p/chromium/issues/detail?id=895117
- See if it helps debugging
- https://bugs.chromium.org/p/chromium/issues/detail?id=895117
-
src/hb-buffer.cc | 2 ++
1 file changed, 2 insertions(+)
@@ -15688,11 +16489,10 @@
Date: Tue Oct 16 18:28:55 2018 -0700
[fuzzing] Delete blink fuzzed data
-
+
These are text, not font.
- ...minimized-blink_harfbuzz_shaper_fuzzer-5099655095123968 | Bin 88 ->
- 0 bytes
+ ...minimized-blink_harfbuzz_shaper_fuzzer-5099655095123968 | Bin 88 -> 0 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 25fe7e7e1031401d38db1efed360cd75ea7910b9
@@ -15709,12 +16509,10 @@
Date: Wed Oct 17 00:54:39 2018 +0100
"allow-none" annotation for "out" parameters
-
+
Fixes the following warnings:
- hb-ot-tag.cc:330: Warning: HarfBuzz: invalid "allow-none" annotation:
- only valid for pointer types and out parameters
- hb-ot-tag.cc:334: Warning: HarfBuzz: invalid "allow-none" annotation:
- only valid for pointer types and out parameters
+ hb-ot-tag.cc:330: Warning: HarfBuzz: invalid "allow-none" annotation: only valid for pointer types and out parameters
+ hb-ot-tag.cc:334: Warning: HarfBuzz: invalid "allow-none" annotation: only valid for pointer types and out parameters
src/hb-ot-tag.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -15733,7 +16531,7 @@
Date: Wed Oct 17 00:36:04 2018 +0100
typo in gobject annotation - "in/out" should be "inout"
-
+
"in/out" should be "inout"
src/hb-ot-layout.cc | 2 +-
@@ -15744,14 +16542,13 @@
Date: Tue Oct 16 16:39:29 2018 -0700
[fuzzing] Run tests against fuzzing fonts
-
+
Some disable.
test/fuzzing/run-shape-fuzzer-tests.py | 12 ++--
test/fuzzing/run-subset-fuzzer-tests.py | 35 ++++++-----
test/shaping/data/in-house/Makefile.sources | 1 -
- test/shaping/data/in-house/tests/fuzzed.tests | 84
- ---------------------------
+ test/shaping/data/in-house/tests/fuzzed.tests | 84 ---------------------------
4 files changed, 24 insertions(+), 108 deletions(-)
commit 7b37705fb579a39334be0618c6215c1b887bf9fc
@@ -15800,8 +16597,7 @@
.../fonts/b9e2aaa0d75fcef6971ec3a96d806ba4a6b31fe2.ttf | Bin
.../fonts/e88c339237f52d21e01c55f01b9c1b4cc14a0467.ttf | Bin
.../fonts/fab39d60d758cb586db5a504f218442cd1395725.ttf | Bin
- test/shaping/data/in-house/tests/fuzzed.tests | 16
- ----------------
+ test/shaping/data/in-house/tests/fuzzed.tests | 16 ----------------
17 files changed, 16 deletions(-)
commit 1487173dcf4137fb210b15d9a869aa1f0c626d15
@@ -15810,20 +16606,13 @@
[fuzzing] Delete duplicate fonts
- .../233c1e252e737ca79e03a9fd56b71aaa4a230f2b.ttf | Bin 1048576 ->
- 0 bytes
- .../243798dd281c1c77c065958e1ff467420faa9bde.ttf | Bin 225 ->
- 0 bytes
- .../9d8a94a67932a3ab75a596fc8b5c6d0392ca9e49.ttf | Bin 4545 ->
- 0 bytes
- .../b6acef662e0beb8d5fcf5b61c6b0ca69537b7402.ttf | Bin 3301 ->
- 0 bytes
- .../bbf4a308c402f0678c3e82844892a4da2ebe598f.ttf | Bin 204 ->
- 0 bytes
- .../dd9f0c7c7c36f75a18be0cab1cddf8f3ab0f366b.ttf | Bin 2786 ->
- 0 bytes
- .../ef2511f215aa3ca847cbfffbf861793b42170875.ttf | Bin 1152 ->
- 0 bytes
+ .../233c1e252e737ca79e03a9fd56b71aaa4a230f2b.ttf | Bin 1048576 -> 0 bytes
+ .../243798dd281c1c77c065958e1ff467420faa9bde.ttf | Bin 225 -> 0 bytes
+ .../9d8a94a67932a3ab75a596fc8b5c6d0392ca9e49.ttf | Bin 4545 -> 0 bytes
+ .../b6acef662e0beb8d5fcf5b61c6b0ca69537b7402.ttf | Bin 3301 -> 0 bytes
+ .../bbf4a308c402f0678c3e82844892a4da2ebe598f.ttf | Bin 204 -> 0 bytes
+ .../dd9f0c7c7c36f75a18be0cab1cddf8f3ab0f366b.ttf | Bin 2786 -> 0 bytes
+ .../ef2511f215aa3ca847cbfffbf861793b42170875.ttf | Bin 1152 -> 0 bytes
test/shaping/data/in-house/tests/fuzzed.tests | 7 -------
8 files changed, 7 deletions(-)
@@ -15841,7 +16630,7 @@
Date: Tue Oct 16 16:24:03 2018 -0700
[gpos] Protect mark attachment against out-of-bounds
-
+
Not sure how can happen, but does...
src/hb-ot-layout-gpos-table.hh | 14 ++++++++++----
@@ -15853,12 +16642,9 @@
[fuzzing] Add more tests
- .../fuzzing/fonts/clusterfuzz-testcase-6107935408390144 | Bin 0 ->
- 16800 bytes
- ...-testcase-minimized-harfbuzz_fuzzer-5973566991106048 | Bin 0 ->
- 4047 bytes
- ...-testcase-minimized-hb-shape-fuzzer-5633985665826816 | Bin 0 ->
- 73 bytes
+ .../fuzzing/fonts/clusterfuzz-testcase-6107935408390144 | Bin 0 -> 16800 bytes
+ ...-testcase-minimized-harfbuzz_fuzzer-5973566991106048 | Bin 0 -> 4047 bytes
+ ...-testcase-minimized-hb-shape-fuzzer-5633985665826816 | Bin 0 -> 73 bytes
3 files changed, 0 insertions(+), 0 deletions(-)
commit 12cbe195ae65656dbc9e32b4d50696bc4223136b
@@ -15875,9 +16661,9 @@
Date: Tue Oct 16 15:40:44 2018 -0700
[aat] Make sure Lookup offset is never nulled
-
+
It has unbounded size...
-
+
Fixes https://oss-fuzz.com/v2/testcase-detail/5718889451749376
src/hb-aat-layout-ankr-table.hh | 2 +-
@@ -15911,21 +16697,14 @@
[fuzzing] Add more clusterfuzz tests I had lying around
- .../fonts/clusterfuzz-testcase-5517117891805184 | Bin 0 ->
- 178 bytes
- ...sterfuzz-testcase-hb-shape-fuzzer-5746142327865344 | Bin 0 ->
- 219 bytes
- ...sterfuzz-testcase-hb-shape-fuzzer-5750379279548416 | Bin 0 ->
- 317 bytes
- .../clusterfuzz-testcase-minimized-4884742786777088 | Bin 0 ->
- 393 bytes
+ .../fonts/clusterfuzz-testcase-5517117891805184 | Bin 0 -> 178 bytes
+ ...sterfuzz-testcase-hb-shape-fuzzer-5746142327865344 | Bin 0 -> 219 bytes
+ ...sterfuzz-testcase-hb-shape-fuzzer-5750379279548416 | Bin 0 -> 317 bytes
+ .../clusterfuzz-testcase-minimized-4884742786777088 | Bin 0 -> 393 bytes
.../clusterfuzz-testcase-minimized-5255344882188288 | Bin 0 -> 65 bytes
- .../clusterfuzz-testcase-minimized-5720051798769664 | Bin 0 ->
- 1048576 bytes
- .../clusterfuzz-testcase-minimized-5924299061854208 | Bin 0 ->
- 2786 bytes
- .../clusterfuzz-testcase-minimized-6460279560863744 | Bin 0 ->
- 589 bytes
+ .../clusterfuzz-testcase-minimized-5720051798769664 | Bin 0 -> 1048576 bytes
+ .../clusterfuzz-testcase-minimized-5924299061854208 | Bin 0 -> 2786 bytes
+ .../clusterfuzz-testcase-minimized-6460279560863744 | Bin 0 -> 589 bytes
...ized-blink_harfbuzz_shaper_fuzzer-5099655095123968 | Bin 0 -> 88 bytes
...estcase-minimized-hb-shape-fuzzer-5650286710882304 | Bin 0 -> 76 bytes
...stcase-minimized-hb-shape-fuzzer-5672261407735808} | Bin
@@ -15939,10 +16718,8 @@
test/fuzzing/Makefile.am | 1 +
...clusterfuzz-testcase-hb-fuzzer-4666056377368576 | Bin 0 -> 1152 bytes
- ...clusterfuzz-testcase-hb-fuzzer-5662671558934528 | Bin 0 -> 242272
- bytes
- ...clusterfuzz-testcase-hb-fuzzer-6243458541944832 | Bin 0 -> 370187
- bytes
+ ...clusterfuzz-testcase-hb-fuzzer-5662671558934528 | Bin 0 -> 242272 bytes
+ ...clusterfuzz-testcase-hb-fuzzer-6243458541944832 | Bin 0 -> 370187 bytes
...clusterfuzz-testcase-hb-fuzzer-6303297511096320 | Bin 0 -> 4545 bytes
...clusterfuzz-testcase-hb-fuzzer-6696647723581440 | Bin 0 -> 3266 bytes
...z-testcase-minimized-hb-fuzzer-4523479581851648 | Bin 0 -> 322 bytes
@@ -15955,8 +16732,7 @@
...z-testcase-minimized-hb-fuzzer-4827735151083520 | Bin 0 -> 1384 bytes
...z-testcase-minimized-hb-fuzzer-4841745322868736 | Bin 0 -> 660 bytes
...z-testcase-minimized-hb-fuzzer-4884742786777088 | Bin 0 -> 393 bytes
- ...z-testcase-minimized-hb-fuzzer-5216838347653120 | Bin 0 -> 157600
- bytes
+ ...z-testcase-minimized-hb-fuzzer-5216838347653120 | Bin 0 -> 157600 bytes
...z-testcase-minimized-hb-fuzzer-5255344882188288 | Bin 0 -> 65 bytes
...z-testcase-minimized-hb-fuzzer-5294584596791296 | Bin 0 -> 1602 bytes
...z-testcase-minimized-hb-fuzzer-5303930168803328 | Bin 0 -> 7321 bytes
@@ -15966,8 +16742,7 @@
...z-testcase-minimized-hb-fuzzer-5617496443846656 | Bin 0 -> 195 bytes
...z-testcase-minimized-hb-fuzzer-5672141338968064 | Bin 0 -> 176 bytes
...z-testcase-minimized-hb-fuzzer-5700697074958336 | Bin 0 -> 878 bytes
- ...z-testcase-minimized-hb-fuzzer-5720051798769664 | Bin 0 -> 1048576
- bytes
+ ...z-testcase-minimized-hb-fuzzer-5720051798769664 | Bin 0 -> 1048576 bytes
...z-testcase-minimized-hb-fuzzer-5924299061854208 | Bin 0 -> 2786 bytes
...z-testcase-minimized-hb-fuzzer-6023178755244032 | Bin 0 -> 2261 bytes
...z-testcase-minimized-hb-fuzzer-6111685556305920 | Bin 0 -> 586 bytes
@@ -16004,26 +16779,20 @@
...case-minimized-hb-shape-fuzzer-5740171484463104 | Bin 0 -> 186 bytes
...case-minimized-hb-shape-fuzzer-5750379279548416 | Bin 0 -> 219 bytes
...case-minimized-hb-shape-fuzzer-5762490181353472 | Bin 0 -> 101 bytes
- ...ase-minimized-hb-subset-fuzzer-5359635656605696 | Bin 0 -> 393270
- bytes
+ ...ase-minimized-hb-subset-fuzzer-5359635656605696 | Bin 0 -> 393270 bytes
...ase-minimized-hb-subset-fuzzer-5521982557782016 | Bin 0 -> 1228 bytes
- ...ase-minimized-hb-subset-fuzzer-5542653037903872 | Bin 0 -> 160249
- bytes
+ ...ase-minimized-hb-subset-fuzzer-5542653037903872 | Bin 0 -> 160249 bytes
...ase-minimized-hb-subset-fuzzer-5609911946838016 | Bin 0 -> 313 bytes
...ase-minimized-hb-subset-fuzzer-5629878397829120 | Bin 0 -> 3746 bytes
...ase-minimized-hb-subset-fuzzer-5651059347816448 | Bin 0 -> 2648 bytes
- ...ase-minimized-hb-subset-fuzzer-5669437462544384 | Bin 0 -> 284427
- bytes
+ ...ase-minimized-hb-subset-fuzzer-5669437462544384 | Bin 0 -> 284427 bytes
...ase-minimized-hb-subset-fuzzer-5670861909524480 | Bin 0 -> 1298 bytes
...ase-minimized-hb-subset-fuzzer-5696607199166464 | Bin 0 -> 28 bytes
- ...ase-minimized-hb-subset-fuzzer-5711951464759296 | Bin 0 -> 284521
- bytes
- ...ase-minimized-hb-subset-fuzzer-5747265633779712 | Bin 0 -> 177090
- bytes
+ ...ase-minimized-hb-subset-fuzzer-5711951464759296 | Bin 0 -> 284521 bytes
+ ...ase-minimized-hb-subset-fuzzer-5747265633779712 | Bin 0 -> 177090 bytes
...ase-minimized-hb-subset-fuzzer-5750092395970560 | Bin 0 -> 72435 bytes
...ase-minimized-hb-subset-fuzzer-5758598970343424 | Bin 0 -> 64 bytes
- ...ase-minimized-hb-subset-fuzzer-6543700493598720 | Bin 0 -> 138425
- bytes
+ ...ase-minimized-hb-subset-fuzzer-6543700493598720 | Bin 0 -> 138425 bytes
...ase-minimized-hb-subset-fuzzer-6651660668502016 | Bin 0 -> 15229 bytes
...b-subset-get-codepoints-fuzzer-5203067375976448 | Bin 0 -> 16310 bytes
...b-subset-get-codepoints-fuzzer-5630904853069824 | Bin 0 -> 580 bytes
@@ -16033,8 +16802,7 @@
...b-subset-get-codepoints-fuzzer-6136125075750912 | Bin 0 -> 65816 bytes
...b-subset-get-codepoints-fuzzer-6394290358976512 | Bin 0 -> 1868 bytes
test/fuzzing/run-shape-fuzzer-tests.py | 4 +
- test/shaping/data/in-house/tests/fuzzed.tests | 84
- +++++++++++++++++++++
+ test/shaping/data/in-house/tests/fuzzed.tests | 84 +++++++++++++++++++++
87 files changed, 89 insertions(+)
commit 2137582c9696b6e38d70b4a0d4199b315c9fd4ce
@@ -16042,13 +16810,11 @@
Date: Tue Oct 16 14:46:07 2018 -0700
[morx] Reword ligation
-
- Still fails MORX-41. Am talking to Sascha to better understand
- what CoreText
+
+ Still fails MORX-41. Am talking to Sascha to better understand what CoreText
is doing.
- src/hb-aat-layout-morx-table.hh | 25
- ++++++++++++----------
+ src/hb-aat-layout-morx-table.hh | 25 ++++++++++++----------
test/shaping/data/text-rendering-tests/DISABLED | 2 ++
.../data/text-rendering-tests/Makefile.sources | 2 +-
3 files changed, 17 insertions(+), 12 deletions(-)
@@ -16069,8 +16835,7 @@
[test/text-rendering-tests] Update from upstream
test/shaping/data/text-rendering-tests/Makefile.sources | 1 +
- .../text-rendering-tests/fonts/TestMORXFourtyone.ttf | Bin 0 ->
- 2248 bytes
+ .../text-rendering-tests/fonts/TestMORXFourtyone.ttf | Bin 0 -> 2248 bytes
.../data/text-rendering-tests/tests/MORX-41.tests | 4 ++++
3 files changed, 5 insertions(+)
@@ -16079,10 +16844,10 @@
Date: Tue Oct 16 13:32:52 2018 -0700
Revert "[vector] Simplify Sort" and "More of the same"
-
+
This reverts commit de0b9a466490c2c13d6ec6f59d5122b0a87d3180.
This reverts commit 921f0e6ec722940a1e37660e1291aa69f9f39db8.
-
+
Annnnd, revert. MSVC doesn't like it.
src/hb-vector.hh | 11 ++++++++---
@@ -16093,7 +16858,7 @@
Date: Tue Oct 16 13:24:29 2018 -0700
[kern] Scale kern pairs before applying
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1255
Fixes https://github.com/harfbuzz/harfbuzz/issues/1252
@@ -16115,7 +16880,7 @@
Date: Mon Oct 15 22:19:17 2018 -0700
[vector] Simplify sort
-
+
Hopefully this fits fine with SFINAE with all our compilers.
src/hb-vector.hh | 7 +------
@@ -16130,8 +16895,7 @@
test/api/CMakeLists.txt | 2 +-
test/api/Makefile.am | 2 +-
test/api/test-multithread.c | 6 ++-
- test/api/{test-ot-nameid.c => test-ot-name.c} | 58
- ++++++++++++++-------------
+ test/api/{test-ot-nameid.c => test-ot-name.c} | 58 ++++++++++++++-------------
4 files changed, 36 insertions(+), 32 deletions(-)
commit 42b75dc3a701b13665115e2a234bfa5dedafef3f
@@ -16148,7 +16912,7 @@
Date: Mon Oct 15 21:16:58 2018 -0700
[kerx] Fix Format6 sanitize
-
+
Fixes https://oss-fuzz.com/v2/testcase-detail/5650286710882304
src/hb-aat-layout-kerx-table.hh | 21 +++++++++++----------
@@ -16159,7 +16923,7 @@
Date: Mon Oct 15 19:46:45 2018 -0700
[CBDT] Fix more offsetting
-
+
Fixes https://oss-fuzz.com/v2/testcase-detail/5750379279548416
src/hb-ot-color-cbdt-table.hh | 7 ++++---
@@ -16186,7 +16950,7 @@
Date: Mon Oct 15 11:15:54 2018 -0700
[morx] Another end-of-text corner case
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10990
src/hb-aat-layout-morx-table.hh | 2 ++
@@ -16233,12 +16997,11 @@
Date: Mon Oct 15 01:09:05 2018 -0700
[ot-font] Implement TrueType v_origin
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/537
src/hb-ot-font.cc | 31 +++++++++++++++++-
- src/hb-ot-hmtx-table.hh | 43
- ++++++++++++++++---------
+ src/hb-ot-hmtx-table.hh | 43 ++++++++++++++++---------
test/shaping/data/in-house/tests/vertical.tests | 2 +-
3 files changed, 59 insertions(+), 17 deletions(-)
@@ -16256,9 +17019,9 @@
Date: Sun Oct 14 21:32:09 2018 -0700
[CBDT] Fix more offsetting issues
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/960
-
+
dump-emoji still segfaults. Needs debugging.
src/hb-ot-color-cbdt-table.hh | 28 +++++++++++++++-------------
@@ -16269,7 +17032,7 @@
Date: Sun Oct 14 21:08:42 2018 -0700
[CBDT] Fix offset handling
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/960
src/hb-ot-color-cbdt-table.hh | 2 +-
@@ -16298,7 +17061,7 @@
Date: Sun Oct 14 19:39:31 2018 -0700
[morx] Handle end-of-text conditions in Insertion
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10955
src/hb-aat-layout-morx-table.hh | 8 ++++----
@@ -16309,7 +17072,7 @@
Date: Sun Oct 14 19:36:46 2018 -0700
[buffer] Fix output_glyph at end of buffer
-
+
Part of https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10955
src/hb-buffer.hh | 5 ++++-
@@ -16338,7 +17101,7 @@
Date: Sun Oct 14 15:20:50 2018 -0700
Ignore signed-integer-overflow while kerning
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1247
src/hb-ot-kern-table.hh | 1 +
@@ -16350,7 +17113,7 @@
Date: Sun Oct 14 14:56:32 2018 -0700
[kerx] Fix Format1 sanitize
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10948
src/hb-aat-layout-kerx-table.hh | 10 +++++-----
@@ -16391,8 +17154,7 @@
[aat] Finish off massaging table
- src/hb-aat-layout.cc | 163
- +++++++++++++++++++++++++--------------------------
+ src/hb-aat-layout.cc | 163 +++++++++++++++++++++++++--------------------------
1 file changed, 81 insertions(+), 82 deletions(-)
commit e0c5e0d91bbc0c8b2bb547ba5cb118989affc617
@@ -16400,14 +17162,12 @@
Date: Sat Oct 13 18:37:14 2018 -0400
[aat] WIP remove feature mapping here from hb-coretext
+
+ Need to map enum values to numerics since we don't have CoreText headers.
- Need to map enum values to numerics since we don't have CoreText
- headers.
-
src/hb-aat-layout.cc | 94 +++++++++++++++++++++++++
src/hb-aat-layout.hh | 22 ++++++
- src/hb-coretext.cc | 189
- +--------------------------------------------------
+ src/hb-coretext.cc | 189 +--------------------------------------------------
3 files changed, 117 insertions(+), 188 deletions(-)
commit cb057749131826dd89bc3b92527116a974ae3bbe
@@ -16433,10 +17193,9 @@
Date: Sat Oct 13 13:36:27 2018 -0400
[kerx] Fix-up previous commit
+
+ A "&" was missing. Go back to using pointers that are less error-prone.
- A "&" was missing. Go back to using pointers that are less
- error-prone.
-
src/hb-aat-layout-kerx-table.hh | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
@@ -16462,8 +17221,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Sat Oct 13 11:48:49 2018 -0400
- [kerx] Use sanitizer.get_num_glyphs() instead of
- face->get_num_glyphs()
+ [kerx] Use sanitizer.get_num_glyphs() instead of face->get_num_glyphs()
src/hb-aat-layout-kerx-table.hh | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
@@ -16482,10 +17240,10 @@
Date: Sat Oct 13 09:47:51 2018 -0400
[hangul] Fix use-after-free issue
-
+
out_info might have moved since we copied it's position into local
info var.
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=894937
src/hb-ot-shape-complex-hangul.cc | 16 +++++++++-------
@@ -16501,8 +17259,7 @@
src/hb-ot-cmap-table.hh | 4 +-
src/hb-ot-layout-common.hh | 4 +-
src/hb-ot-layout-gsubgpos.hh | 8 +--
- src/hb-ot-layout.cc | 127
- +++++++++++++++++++------------------------
+ src/hb-ot-layout.cc | 127 +++++++++++++++++++------------------------
src/hb-ot-layout.h | 25 +++++----
src/hb-ot-math-table.hh | 8 +--
src/hb-ot-name.h | 1 -
@@ -16514,7 +17271,7 @@
Date: Fri Oct 12 14:14:21 2018 -0700
from encode_int removed assert hit by fuzzer
-
+
clamp the value instead
src/hb-subset-cff-common.hh | 5 ++++-
@@ -16525,7 +17282,7 @@
Date: Fri Oct 12 16:05:56 2018 -0400
Touch up new API
-
+
New API:
+hb_ot_layout_feature_get_name_ids()
+hb_ot_layout_feature_get_characters()
@@ -16540,9 +17297,9 @@
Date: Fri Oct 12 15:52:31 2018 -0400
Add hb-ot-name.h
-
+
Actual name-fetching API to come later.
-
+
New API:
hb_name_id_t
HB_NAME_ID_INVALID
@@ -16550,8 +17307,7 @@
src/Makefile.sources | 1 +
src/hb-ot-layout-common.hh | 2 +-
src/hb-ot-layout.h | 12 ++---------
- src/hb-ot-name.h | 54
- ++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-name.h | 54 ++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot.h | 1 +
5 files changed, 59 insertions(+), 11 deletions(-)
@@ -16560,20 +17316,17 @@
Date: Fri Oct 12 03:00:59 2018 +0330
Add two APIs for getting stylistic set labels
-
+
* hb_ot_layout_feature_get_characters
* hb_ot_layout_feature_get_name_ids
-
- However HarfBuzz currently doesn't expose an API for retrieving
- the actual
- information associated with NameId from the `name` table and that
- should be
+
+ However HarfBuzz currently doesn't expose an API for retrieving the actual
+ information associated with NameId from the `name` table and that should be
done separately.
docs/harfbuzz-sections.txt | 2 +
src/hb-ot-layout-common.hh | 14 +++++
- src/hb-ot-layout.cc | 133
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout.cc | 133 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout.h | 29 ++++++++++
test/api/CMakeLists.txt | 2 +
test/api/Makefile.am | 1 +
@@ -16586,13 +17339,11 @@
Date: Thu Oct 11 21:37:45 2018 -0400
[sanitize] Reorder condition to silence bogus gcc warning
-
+
Was givin a dozen of:
-
- ../../src/hb-machinery.hh: In member function ‘bool
- AAT::ankr::sanitize(hb_sanitize_context_t*) const’:
- ../../src/hb-machinery.hh:307:23: warning: missed loop optimization,
- the loop counter may overflow [-Wunsafe-loop-optimizations]
+
+ ../../src/hb-machinery.hh: In member function ‘bool AAT::ankr::sanitize(hb_sanitize_context_t*) const’:
+ ../../src/hb-machinery.hh:307:23: warning: missed loop optimization, the loop counter may overflow [-Wunsafe-loop-optimizations]
bool ok = --this->max_ops > 0 &&
~~~~~~~~~~~~~~~~~~~~~~
this->start <= p &&
@@ -16601,9 +17352,8 @@
~~~~~~~~~~~~~~~^~
(unsigned int) (this->end - p) >= len;
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-
- I believe those are bogus, but this silences them and does not
- introduce
+
+ I believe those are bogus, but this silences them and does not introduce
logic issues I believe.
src/hb-machinery.hh | 6 +++---
@@ -16634,7 +17384,7 @@
Date: Thu Oct 11 21:18:20 2018 -0400
Always compile deprecated symbols
-
+
We haven't been keeping this updated. So, while we don't expose the
symbols in the headers if HB_DISABLE_DEPRECATED is defined, we still
always build them.
@@ -16654,11 +17404,10 @@
Date: Fri Oct 12 02:16:07 2018 -0700
overhauled error handling in CFF interpreter
-
+
minimized "if (error) return false" idiom
- src/hb-cff-interp-common.hh | 138
- +++++++++++++++++++++++----------------
+ src/hb-cff-interp-common.hh | 138 +++++++++++++++++++++++----------------
src/hb-cff-interp-cs-common.hh | 43 ++++++------
src/hb-cff-interp-dict-common.hh | 72 +++++++++++---------
src/hb-cff1-interp-cs.hh | 72 +++++++++++---------
@@ -16690,14 +17439,13 @@
Date: Thu Oct 11 20:45:00 2018 -0400
Attach CursivePositioning backwards, not forward
-
+
This is how Uniscribe does it. So, adjust. This is only relevant
to fonts that apply cursive positioning from a contextual lookup.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1181
- src/hb-ot-layout-gpos-table.hh | 20
- ++++++++++----------
+ src/hb-ot-layout-gpos-table.hh | 20 ++++++++++----------
.../9fc3e6960b3520e5304033ef5fd540285f72f14d.ttf | Bin 0 -> 2380 bytes
.../data/in-house/tests/cursive-positioning.tests | 1 +
3 files changed, 11 insertions(+), 10 deletions(-)
@@ -16707,14 +17455,13 @@
Date: Thu Oct 11 20:20:00 2018 -0400
[myanmar] Implement Zawgyi shaper
-
+
Enabled if script tag 'Qaag' is passed to HarfBuzz. Disables mark
advance-zeroing and fallback mark-positioning.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1162
- src/hb-ot-shape-complex-myanmar.cc | 22
- +++++++++++++++++++++
+ src/hb-ot-shape-complex-myanmar.cc | 22 +++++++++++++++++++++
src/hb-ot-shape-complex.hh | 5 +++++
src/hb.hh | 8 ++++++++
test/shaping/data/in-house/Makefile.sources | 1 +
@@ -16756,8 +17503,7 @@
[test] Add test for USE indic3
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/3c96e7a303c58475a8c750bf4289bbe73784f37d.ttf | Bin 0 ->
- 3364 bytes
+ .../fonts/3c96e7a303c58475a8c750bf4289bbe73784f37d.ttf | Bin 0 -> 3364 bytes
test/shaping/data/in-house/tests/use-indic3.tests | 1 +
3 files changed, 2 insertions(+)
@@ -16775,7 +17521,7 @@
Date: Thu Oct 11 17:51:21 2018 -0400
Pass indic3 tags to USE shaper
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/539
src/hb-ot-shape-complex.hh | 6 ++++--
@@ -16809,8 +17555,7 @@
test/fuzzing/Makefile.am | 16 ----------------
test/fuzzing/hb-subset-fuzzer.cc | 5 +++++
- test/fuzzing/hb-subset-get-codepoints-fuzzer.cc | 23
- -----------------------
+ test/fuzzing/hb-subset-get-codepoints-fuzzer.cc | 23 -----------------------
3 files changed, 5 insertions(+), 39 deletions(-)
commit 2c824d3644e16643c2bbe85fb88f9fb6fed53ce7
@@ -16818,13 +17563,12 @@
Date: Thu Oct 11 16:41:01 2018 -0400
[aat] Fix two wrongs that made a right before!
-
+
Unfortunately our static asserts (DEFINE_SIZE_STATIC) don't actually
fail when used in templates, thanks to SFINAE. Le sighs.
+
+ Probably fixes https://oss-fuzz.com/v2/testcase-detail/5740171484463104
- Probably fixes
- https://oss-fuzz.com/v2/testcase-detail/5740171484463104
-
src/hb-aat-layout-common.hh | 4 ++--
src/hb-open-type.hh | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
@@ -16834,7 +17578,7 @@
Date: Thu Oct 11 15:56:17 2018 -0400
[aat] Fix mul overflow
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=10897
src/hb-aat-layout-common.hh | 11 ++++++++---
@@ -16856,7 +17600,7 @@
Date: Thu Oct 11 15:14:18 2018 -0400
[arabic] Update to latest UTR#53
-
+
From Lorna Evans: "That was a new character added to Unicode 11.0"
src/hb-ot-shape-complex-arabic.cc | 1 +
@@ -16868,8 +17612,7 @@
[test] Fix use of deprecated symbols
- test/api/test-ot-tag.c | 60
- ++++++++++++++++++++++++++++++++++++++------------
+ test/api/test-ot-tag.c | 60 ++++++++++++++++++++++++++++++++++++++------------
1 file changed, 46 insertions(+), 14 deletions(-)
commit ca37172ee3908bac12cc3d97768b95ae571530d2
@@ -16904,10 +17647,9 @@
Date: Thu Oct 11 14:25:48 2018 -0400
[graphite] Fix deva/dev2 resolution
+
+ See https://github.com/harfbuzz/harfbuzz/pull/730#issuecomment-428277800
- See
- https://github.com/harfbuzz/harfbuzz/pull/730#issuecomment-428277800
-
src/hb-graphite2.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -16916,13 +17658,12 @@
Date: Thu Oct 11 14:16:55 2018 -0400
Add doc stubs for recently added API
-
- Thanks to David Corbett who revamped our script and language
- processing
+
+ Thanks to David Corbett who revamped our script and language processing
and implemented full BCP 47 support.
-
+
https://github.com/harfbuzz/harfbuzz/pull/730
-
+
New API:
+hb_ot_layout_table_select_script()
+hb_ot_layout_script_select_language()
@@ -16930,7 +17671,7 @@
+HB_OT_MAX_TAGS_PER_LANGUAGE
+hb_ot_tags_from_script_and_language()
+hb_ot_tags_to_script_and_language()
-
+
Deprecated API:
-hb_ot_layout_table_choose_script()
-hb_ot_layout_script_find_language()
@@ -16958,9 +17699,8 @@
Date: Mon Sep 10 13:15:00 2018 -0400
Increase HB_OT_MAX_TAGS_PER_SCRIPT to 3
-
- No script has 3 tags yet, but the plan is for the Indic scripts
- to each
+
+ No script has 3 tags yet, but the plan is for the Indic scripts to each
get a third tag someday.
src/hb-ot-tag.h | 2 +-
@@ -16984,8 +17724,7 @@
docs/harfbuzz-sections.txt | 3 +-
src/hb-ot-map.cc | 2 +-
- src/hb-ot-tag.cc | 75
- ++++++++++++++++++++++++++++++++++++++++------
+ src/hb-ot-tag.cc | 75 ++++++++++++++++++++++++++++++++++++++++------
src/hb-ot-tag.h | 18 +++++++----
test/api/test-ot-tag.c | 33 ++++++++++++++++++--
5 files changed, 112 insertions(+), 19 deletions(-)
@@ -16995,14 +17734,12 @@
Date: Thu Jul 19 13:48:07 2018 -0400
Switch on the first char of a complex language tag
-
- This results in a tenfold speed-up for the common case of tags
- that are
+
+ This results in a tenfold speed-up for the common case of tags that are
not complex, in the sense of `hb_ot_tags_from_complex_language`.
src/gen-tag-table.py | 171 ++++--
- src/hb-ot-tag-table.hh | 1580
- ++++++++++++++++++++++++------------------------
+ src/hb-ot-tag-table.hh | 1580 ++++++++++++++++++++++++------------------------
2 files changed, 922 insertions(+), 829 deletions(-)
commit a754d44195021603306af2a296d06187eda95409
@@ -17010,19 +17747,16 @@
Date: Mon Jul 16 21:14:48 2018 -0400
Map Quechua languages to closest ones with tags
-
+
OpenType only officially maps four ISO 639 codes to Quechua languages,
- but prior versions of HarfBuzz also mapped qu to 'QUZ '. Because qu
- is a
+ but prior versions of HarfBuzz also mapped qu to 'QUZ '. Because qu is a
macrolanguage, the mapping now applies to all individual Quechua
- languages. OpenType calls 'QUZ ' "Quechua", but it really corresponds
- to
+ languages. OpenType calls 'QUZ ' "Quechua", but it really corresponds to
Cusco Quechua, so the individual Quechua languages should not all
necessarily be mapped to it.
src/gen-tag-table.py | 32 ++++++++++++++++++++++++++
- src/hb-ot-tag-table.hh | 62
- +++++++++++++++++++++++++++-----------------------
+ src/hb-ot-tag-table.hh | 62 +++++++++++++++++++++++++++-----------------------
2 files changed, 65 insertions(+), 29 deletions(-)
commit 65d01f77552a5102ee114d9917fd2ecf091a35c3
@@ -17030,16 +17764,13 @@
Date: Thu Jan 18 16:33:39 2018 -0500
Test deprecated tag fallback in a font
-
+
The font supports the deprecated tag 'DHV ' instead of 'DIV '. dv is
mapped to 'DIV ' and 'DHV ', in that order. The test specifies
- `--language=dv`, demonstrating that if a font does not support
- the first
- OpenType tag mapped to a BCP 47 tag, it will fall back to the
- next tag.
+ `--language=dv`, demonstrating that if a font does not support the first
+ OpenType tag mapped to a BCP 47 tag, it will fall back to the next tag.
- .../fonts/d3129450fafe5e5c98cfc25a4e71809b1b4d2855.ttf | Bin 0 ->
- 956 bytes
+ .../fonts/d3129450fafe5e5c98cfc25a4e71809b1b4d2855.ttf | Bin 0 -> 956 bytes
test/shaping/data/in-house/tests/language-tags.tests | 1 +
2 files changed, 1 insertion(+)
@@ -17048,12 +17779,11 @@
Date: Sat Jan 20 15:53:09 2018 -0500
Match extlang subtags
-
+
If the second subtag of a BCP 47 tag is three letters long, it denotes
- an extended language. The tag converter ignores the language
- subtag and
+ an extended language. The tag converter ignores the language subtag and
uses the extended language instead.
-
+
There are some grandfathered exceptions, which are handled earlier.
src/gen-tag-table.py | 2 +-
@@ -17067,9 +17797,8 @@
Date: Fri Dec 8 22:45:52 2017 -0500
Autogenerate the BCP 47 to OpenType mappings
-
- The new script, gen-tag-table.py, generates `ot_languages`
- automatically
+
+ The new script, gen-tag-table.py, generates `ot_languages` automatically
from the [OpenType language system tag registry][ot] and the [IANA
Language Subtag Registry][bcp47] with some manual modifications. If an
OpenType tag maps to a BCP 47 macrolanguage, all the macrolanguage's
@@ -17076,35 +17805,28 @@
individual languages are mapped to the same OpenType tag, except for
individual languages with their own OpenType mappings. Deprecated
BCP 47 tags are canonicalized.
-
- [ot]:
- https://docs.microsoft.com/en-us/typography/opentype/spec/languagetags
- [bcp47]:
- https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
-
+
+ [ot]: https://docs.microsoft.com/en-us/typography/opentype/spec/languagetags
+ [bcp47]: https://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
+
Some OpenType tags correspond to multiple ISO 639 codes. The mapping
- from ISO 639 codes lists OpenType tags in priority order, such
- that more
+ from ISO 639 codes lists OpenType tags in priority order, such that more
specific or more likely tags appear first.
-
- Some OpenType tags have no corresponding ISO 639 code in the
- registry so
- their mappings use BCP 47 subtags besides the language. For example,
- any
- BCP 47 tag with a fonipa variant subtag is mapped to 'IPPH', and
- 'IPPH'
+
+ Some OpenType tags have no corresponding ISO 639 code in the registry so
+ their mappings use BCP 47 subtags besides the language. For example, any
+ BCP 47 tag with a fonipa variant subtag is mapped to 'IPPH', and 'IPPH'
is mapped back to und-fonipa.
-
- Other OpenType tags have no corresponding ISO 639 code because it
- is not
+
+ Other OpenType tags have no corresponding ISO 639 code because it is not
clear what they are for. HarfBuzz just ignores these tags.
-
+
One such ignored tag is 'ZHP ' (Chinese Phonetic). It probably means
zh-Latn. However, it is used in Microsoft JhengHei and Microsoft YaHei
with the script tag 'hani', implying that it is not a romanization
scheme after all. It would be simple enough to add this mapping to
gen-tag-table.py once a definitive mapping is determined.
-
+
The manual modifications are mainly either obvious mappings that the
OpenType registry omits or mappings for compatibility with previous
versions of HarfBuzz. Some of the old mappings were discarded, though,
@@ -17111,13 +17833,10 @@
for homophonous language names. For example, OpenType maps 'KUI ' to
kxu; previous versions of HarfBuzz also mapped it to kvd, because kvd
and kxu both happen to be called "Kui".
-
- gen-tag-table.py also generates a function to convert multi-subtag
- tags
- like el-polyton and zh-HK to OpenType tags, replacing
- `ot_languages_zh`
- and the hard-coded list of special cases in
- `hb_ot_tags_from_language`.
+
+ gen-tag-table.py also generates a function to convert multi-subtag tags
+ like el-polyton and zh-HK to OpenType tags, replacing `ot_languages_zh`
+ and the hard-coded list of special cases in `hb_ot_tags_from_language`.
It also generates a function to convert OpenType tags to BCP 47,
replacing the hard-coded list of special cases in
`hb_ot_tag_to_language`.
@@ -17125,8 +17844,7 @@
src/Makefile.am | 9 +-
src/Makefile.sources | 1 +
src/gen-tag-table.py | 1013 ++++++++++++++++++++++++
- src/hb-ot-tag-table.hh | 1997
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-tag-table.hh | 1997 ++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-tag.cc | 842 +-------------------
src/hb-ot-tag.h | 2 +-
test/api/test-ot-tag.c | 66 +-
@@ -17137,13 +17855,13 @@
Date: Fri Dec 29 20:19:05 2017 +0800
Deprecate obsolete functions
-
+
`hb_ot_tags` replaces `hb_ot_tags_from_script` and
`hb_ot_tag_from_language`.
-
+
`hb_ot_layout_table_select_script` replaces
`hb_ot_layout_table_choose_script`.
-
+
`hb_ot_layout_script_select_language` replaces
`hb_ot_layout_script_find_language`.
@@ -17158,30 +17876,27 @@
Date: Fri Dec 8 11:21:14 2017 -0500
Refactor the selection of script and language tags
-
+
The old hb-ot-tag.cc functions, `hb_ot_tags_from_script` and
`hb_ot_tag_from_language`, are now wrappers around a new function:
`hb_ot_tags`. It converts a script and a language to arrays of script
- tags and language tags. This will make it easier to add new script
- tags
+ tags and language tags. This will make it easier to add new script tags
to scripts, like 'dev3'. It also allows for language fallback chains;
nothing produces more than one language yet though.
-
+
Where the old functions return the default tags 'DFLT' and 'dflt',
`hb_ot_tags` returns an empty array. The caller is responsible for
using the default tag in that case.
-
+
The new function also adds a new private use subtag syntax for script
overrides: "x-hbscabcd" requests a script tag of 'abcd'.
-
- The old hb-ot-layout.cc functions,`hb_ot_layout_table_choose_script`
- and
+
+ The old hb-ot-layout.cc functions,`hb_ot_layout_table_choose_script` and
`hb_ot_layout_script_find_language` are now wrappers around the new
functions `hb_ot_layout_table_select_script` and
- `hb_ot_layout_script_select_language`. They are essentially the
- same as
+ `hb_ot_layout_script_select_language`. They are essentially the same as
the old ones plus a tag count parameter.
-
+
Closes #495.
docs/harfbuzz-sections.txt | 5 +
@@ -17188,8 +17903,7 @@
src/hb-ot-layout.cc | 43 +-
src/hb-ot-layout.h | 16 +
src/hb-ot-map.cc | 13 +-
- src/hb-ot-tag.cc | 1639
- ++++++++++++++++++++++++--------------------
+ src/hb-ot-tag.cc | 1639 ++++++++++++++++++++++++--------------------
src/hb-ot-tag.h | 11 +
test/api/test-ot-tag.c | 107 +++
7 files changed, 1070 insertions(+), 764 deletions(-)
@@ -17199,11 +17913,9 @@
Date: Thu Dec 28 22:59:29 2017 +0800
Replace "ISO 639" with "BCP 47"
-
- `hb_language_from_string` accepts not only ISO 639 but also BCP
- 47. Not
- all ISO 639 codes are valid BCP 47 tags but the function does
- not accept
+
+ `hb_language_from_string` accepts not only ISO 639 but also BCP 47. Not
+ all ISO 639 codes are valid BCP 47 tags but the function does not accept
overlong language subtags anyway.
src/hb-buffer.cc | 2 +-
@@ -17222,21 +17934,15 @@
Date: Thu Oct 11 10:53:44 2018 -0700
Replaced CFF1 J subset font for better coverage
-
+
in api test-ot-extents-cff
- test/api/fonts/SourceHanSans-Regular.41,3041,4C2E.otf | Bin 0 ->
- 3892 bytes
- test/api/fonts/SourceHanSans-Regular.41,3041,4E9D.otf | Bin 5864 ->
- 0 bytes
- test/api/fonts/SourceHanSans-Regular.41,4C2E.otf | Bin 0 ->
- 2548 bytes
- test/api/fonts/SourceHanSans-Regular.41,4E9D.otf | Bin 5500 ->
- 0 bytes
- test/api/test-ot-extents-cff.c | 15
- +++++++++++++++
- test/api/test-subset-cff1.c | 18
- +++++++++---------
+ test/api/fonts/SourceHanSans-Regular.41,3041,4C2E.otf | Bin 0 -> 3892 bytes
+ test/api/fonts/SourceHanSans-Regular.41,3041,4E9D.otf | Bin 5864 -> 0 bytes
+ test/api/fonts/SourceHanSans-Regular.41,4C2E.otf | Bin 0 -> 2548 bytes
+ test/api/fonts/SourceHanSans-Regular.41,4E9D.otf | Bin 5500 -> 0 bytes
+ test/api/test-ot-extents-cff.c | 15 +++++++++++++++
+ test/api/test-subset-cff1.c | 18 +++++++++---------
6 files changed, 24 insertions(+), 9 deletions(-)
commit 0b9d60e1a1c4b7867ac907bbd7c004191a14e697
@@ -17244,7 +17950,7 @@
Date: Thu Oct 11 13:26:58 2018 -0400
[aat] Apply kerx if GPOS kern was not applied
-
+
Ned tells me this is what Apple does.
src/hb-ot-shape.cc | 18 ++++++++----------
@@ -17276,11 +17982,10 @@
Date: Thu Oct 11 11:25:07 2018 -0400
[trak] Implement extrapolation
-
+
This concludes trak, as well as AAT shaping support!
- src/hb-aat-layout-trak-table.hh | 39
- ++++++++++++++++++++-------------------
+ src/hb-aat-layout-trak-table.hh | 39 ++++++++++++++++++++-------------------
1 file changed, 20 insertions(+), 19 deletions(-)
commit d6a12dba6da6262fd9e5d8397b46ac8516136cae
@@ -17288,7 +17993,7 @@
Date: Thu Oct 11 11:10:06 2018 -0400
[trak] Fix, and hook up
-
+
Works beautifully! Test coming.
src/hb-aat-layout-common.hh | 4 ++--
@@ -17330,7 +18035,7 @@
Date: Thu Oct 11 10:22:01 2018 -0400
[trak] Only adjust around first glyph
-
+
Assumes graphemes only have one base glyph.
src/hb-aat-layout-trak-table.hh | 12 ++++++------
@@ -17342,8 +18047,7 @@
[trak] Clean up
- src/hb-aat-layout-trak-table.hh | 67
- +++++++++++++++++++++++------------------
+ src/hb-aat-layout-trak-table.hh | 67 +++++++++++++++++++++++------------------
1 file changed, 37 insertions(+), 30 deletions(-)
commit fbbd926dba163d9a2a6a62f380951f03363c2b14
@@ -17351,9 +18055,9 @@
Date: Thu Oct 11 01:22:29 2018 -0400
[kerx] Implement Format4 action_type=1 contour-point-based attachment
-
+
Untested.
-
+
This concludes kerx table support!
src/hb-aat-layout-kerx-table.hh | 17 ++++++++++++++++-
@@ -17364,7 +18068,7 @@
Date: Thu Oct 11 01:17:57 2018 -0400
[kerx] Implement Format4 action_type=2 coordinate-based attachment
-
+
Untested.
src/hb-aat-layout-kerx-table.hh | 21 ++++++++++++---------
@@ -17375,9 +18079,9 @@
Date: Thu Oct 11 01:14:18 2018 -0400
[kerx] Implement Format4 'ankr'-based mark attachment
-
+
Tested with Kannada MN:
-
+
$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0CCD,0C95,0CD6
[kn_ka.vattu=0+230|kn_ai_length_mark=1 at 326,0+607]
@@ -17402,11 +18106,10 @@
Date: Thu Oct 11 00:12:49 2018 -0400
[kerx] Flesh out Format4
-
+
Doesn't apply actions yet.
- src/hb-aat-layout-kerx-table.hh | 122
- ++++++++++++++++++++++++++++++++++++++--
+ src/hb-aat-layout-kerx-table.hh | 122 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 118 insertions(+), 4 deletions(-)
commit 947962a287d9aca2cb509c11f44cb5150aa6daf1
@@ -17459,16 +18162,15 @@
Date: Wed Oct 10 21:46:58 2018 -0400
[kerx] Make Format1 work
-
+
Tested using Kannada MN:
-
+
$ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD
[kn_ka.virama=0+1299|kn_ka.vattu=0+115|_blank=0 at -115,0+385]
-
- $ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD
- --features=-kern
+
+ $ HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CCd,C95,CCD --features=-kern
[kn_ka.virama=0+1799|kn_ka.vattu=0+230|_blank=0+0]
-
+
I don't see the GPOS table in the font do the same. ¯\_(ツ)_/¯
src/hb-aat-layout-kerx-table.hh | 15 ++++++++++-----
@@ -17489,8 +18191,7 @@
src/hb-cff2-interp-cs.hh | 12 +++++-----
test/api/fonts/AdobeVFPrototype_vsindex.otf | Bin 0 -> 7036 bytes
- test/api/test-ot-extents-cff.c | 33
- ++++++++++++++++++++++++++++
+ test/api/test-ot-extents-cff.c | 33 ++++++++++++++++++++++++++++
3 files changed, 40 insertions(+), 5 deletions(-)
commit 504cb68fc972c7f606bf9fc62015376382f78f45
@@ -17497,11 +18198,9 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Oct 10 21:29:46 2018 -0400
- Disable mark advance zeroing as well as mark fallback positioning
- if doing kerx
+ Disable mark advance zeroing as well as mark fallback positioning if doing kerx
- src/hb-ot-shape.cc | 50
- ++++++++++++++++++++++++++------------------------
+ src/hb-ot-shape.cc | 50 ++++++++++++++++++++++++++------------------------
1 file changed, 26 insertions(+), 24 deletions(-)
commit 84967537966a76297c89460d95e7336f1bfc332d
@@ -17509,11 +18208,10 @@
Date: Wed Oct 10 21:18:37 2018 -0400
[kerx] Implement Format1
-
+
Untested.
- src/hb-aat-layout-kerx-table.hh | 62
- +++++++++++++++++++++++++++++++++--------
+ src/hb-aat-layout-kerx-table.hh | 62 +++++++++++++++++++++++++++++++++--------
src/hb-aat-layout-morx-table.hh | 2 +-
2 files changed, 52 insertions(+), 12 deletions(-)
@@ -17541,8 +18239,7 @@
[kerx] Start fleshing out Format1
- src/hb-aat-layout-kerx-table.hh | 59
- +++++++++++++++++++++++++++++++++++------
+ src/hb-aat-layout-kerx-table.hh | 59 +++++++++++++++++++++++++++++++++++------
src/hb-aat-layout-morx-table.hh | 2 +-
2 files changed, 52 insertions(+), 9 deletions(-)
@@ -17551,13 +18248,11 @@
Date: Wed Oct 10 20:10:20 2018 -0400
[kerx] Implement Format6
-
- Untested. The only Apple font shipping with this format is San
- Francisco fonts
+
+ Untested. The only Apple font shipping with this format is San Francisco fonts
that use this for their kerx variation tables, which we don't support.
- src/hb-aat-layout-kerx-table.hh | 73
- +++++++++++++++++++++++++++++++++--------
+ src/hb-aat-layout-kerx-table.hh | 73 +++++++++++++++++++++++++++++++++--------
1 file changed, 60 insertions(+), 13 deletions(-)
commit c9a2ce9e05f91730a2150b9214dc6a49f31555c1
@@ -17575,8 +18270,7 @@
[kerx] Start fleshing out Format6
- src/hb-aat-layout-kerx-table.hh | 42
- ++++++++++++++++++++++++++++++++---------
+ src/hb-aat-layout-kerx-table.hh | 42 ++++++++++++++++++++++++++++++++---------
src/hb-open-type.hh | 3 +++
2 files changed, 36 insertions(+), 9 deletions(-)
@@ -17594,26 +18288,22 @@
Date: Wed Oct 10 19:11:30 2018 -0400
[kerx] No-op
-
+
Tested that Format0 works with Kannada MN font:
-
- $ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc
- -u 0C95,0CC2
+
+ $ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
[kn_ka=0+1000|kn_matra_uu=0 at -30,0+1345]
-
- $ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u
- 0C95,0CC2 --features=-kern
+
+ $ make -j5 lib -s && HB_OPTIONS=aat ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2 --features=-kern
[kn_ka=0+1030|kn_matra_uu=0+1375]
-
- Note that GPOS does the same with 'dist' feature, and applies the
- whole difference to the
+
+ Note that GPOS does the same with 'dist' feature, and applies the whole difference to the
same glyph:
-
+
$ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
[kn_ka=0+970|kn_matra_uu=0+1375]
-
- $ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2
- --features=-dist
+
+ $ make -j5 lib -s && ./hb-shape Kannada\ MN.ttc -u 0C95,0CC2 --features=-dist
[kn_ka=0+1030|kn_matra_uu=0+1375]
src/hb-aat-layout-kerx-table.hh | 4 +---
@@ -17642,20 +18332,18 @@
Date: Wed Oct 10 18:14:41 2018 -0400
[kern/kerx] Fix offset base
-
+
Disable kern Format2.
-
- Fix kerx Format2. Manually tested this with Tamil MN font and
- it works:
-
+
+ Fix kerx Format2. Manually tested this with Tamil MN font and it works:
+
$ HB_OPTIONS=aat ./hb-shape Tamil\ MN.ttc -u 0B94,0B95
[tgv_au=0+3435|tgc_ka=1 at -75,0+1517]
-
+
HB_OPTIONS=aat ./hb-shape Tamil\ MN.ttc -u 0B94,0B95 --features=-kern
[tgv_au=0+3510|tgc_ka=1+1592]
- src/hb-aat-layout-kerx-table.hh | 73
- +++++++++++++++++++++++++----------------
+ src/hb-aat-layout-kerx-table.hh | 73 +++++++++++++++++++++++++----------------
src/hb-ot-kern-table.hh | 7 ++++
2 files changed, 52 insertions(+), 28 deletions(-)
@@ -17675,7 +18363,7 @@
Date: Wed Oct 10 17:44:46 2018 -0400
Allow HB_OPTIONS=aat to prefer AAT tables over OT
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/322
src/hb-common.cc | 23 +++++++++++++++++++++--
@@ -17697,7 +18385,7 @@
Date: Wed Oct 10 16:32:35 2018 -0400
Remove HAVE_OT
-
+
We never tested compiling without it. Just kill it. We always build
our own shaper.
@@ -17729,13 +18417,12 @@
Date: Wed Oct 10 12:07:49 2018 -0400
Add per-subtable set-digests
-
+
This speeds up Roboto shaping by ~10%. I was hoping for more.
Still, good defense against lookups with many subtables.
src/hb-null.hh | 2 +-
- src/hb-ot-layout-gsubgpos.hh | 108
- +++++++++++++++++++++++--------------------
+ src/hb-ot-layout-gsubgpos.hh | 108 +++++++++++++++++++++++--------------------
2 files changed, 59 insertions(+), 51 deletions(-)
commit e78549edfb4df617128a5f5ddd12692f1d0af4bf
@@ -17776,12 +18463,11 @@
Date: Wed Oct 10 11:36:28 2018 -0400
Move code
-
+
In preparation to move add per-subtable set digests...
src/hb-ot-layout-gsubgpos.hh | 50 ++++++++++++++++++++++++++++++++++++++
- src/hb-ot-layout.cc | 57
- ++++----------------------------------------
+ src/hb-ot-layout.cc | 57 ++++----------------------------------------
2 files changed, 54 insertions(+), 53 deletions(-)
commit a03850a3567d532c3a4d7655aa71bfe73dfb0e33
@@ -17789,7 +18475,7 @@
Date: Wed Oct 10 10:57:28 2018 -0400
Fix GPOS/kern interaction
-
+
Oops. Was checking for kern feature in GSUB, not GPOS.
src/hb-ot-shape.cc | 2 +-
@@ -17800,11 +18486,10 @@
Date: Wed Oct 10 10:49:45 2018 -0400
More rewriting plan compile
-
+
Hopefully more clear.
- src/hb-ot-shape.cc | 55
- ++++++++++++++++++++++++++++++++++++++----------------
+ src/hb-ot-shape.cc | 55 ++++++++++++++++++++++++++++++++++++++----------------
src/hb-ot-shape.hh | 1 -
2 files changed, 39 insertions(+), 17 deletions(-)
@@ -17843,7 +18528,7 @@
Date: Wed Oct 10 10:16:09 2018 -0400
Apply TT or fallback kerning when GPOS does not have kern feature
-
+
Previously we only did if there was no GPOS whatsoever. This applies
to Arial, Times New Roman, etc in Win7. Was not kerning before. It
is now.
@@ -17867,8 +18552,7 @@
[circleci] Add an iOS bot (#1233)
.circleci/config.yml | 12 +++++
- CMakeLists.txt | 140
- ++++++++++++++++++++++++++++++++-------------------
+ CMakeLists.txt | 140 ++++++++++++++++++++++++++++++++-------------------
2 files changed, 100 insertions(+), 52 deletions(-)
commit c06a5dff0b0f8d1c5aba53bcfd7fb0b680f1ca92
@@ -17883,7 +18567,7 @@
Date: Tue Oct 9 21:59:36 2018 -0700
added cff1_legacyops.otf as test-ot-extents-cff test case
-
+
fixed roll operator bugs uncovered by the test
src/hb-cff-interp-common.hh | 4 ++--
@@ -17925,9 +18609,9 @@
Date: Tue Oct 9 23:17:32 2018 -0400
[aat] Fixup recent commit
-
+
For 329f2401082011007d9ce12b15ce0225cd267c57
-
+
max_ops is signed.
src/hb-aat-layout-common.hh | 2 +-
@@ -17949,7 +18633,7 @@
Date: Tue Oct 9 23:02:53 2018 -0400
[aat] Set embedded sanitizer max ops really high
-
+
Since we consume it legitimately during shaping.
src/hb-aat-layout-common.hh | 1 +
@@ -17989,7 +18673,7 @@
Date: Tue Oct 9 22:49:33 2018 -0400
[kerx] Implement Format2 apply()
-
+
Still, not hooked.
src/hb-aat-layout-kerx-table.hh | 5 +----
@@ -18028,7 +18712,7 @@
Date: Tue Oct 9 22:35:22 2018 -0400
[kerx] Implement Format0 apply()
-
+
Not hooked up to be called yet.
src/hb-aat-layout-common.hh | 6 ++++--
@@ -18070,12 +18754,11 @@
Date: Tue Oct 9 16:24:50 2018 -0400
[ft] Use mutex to lock access to FT_Face
-
- Makes our FT-backed hb_font_t safe to use from multiple threads.
- Still,
+
+ Makes our FT-backed hb_font_t safe to use from multiple threads. Still,
the underlying FT_Face should NOT be used from other threads by client
or other libraries.
-
+
Maybe I add a lock()/unlock() public API ala PangoFT2 and cairo-ft.
Maybe not.
@@ -18107,12 +18790,10 @@
Date: Tue Oct 9 15:39:51 2018 -0400
Install ot-funcs on newly created funcs
+
+ **Finally**! Casual users can stop caring about font-funcs completely now,
+ like they haven't been needing to care re unicode-funcs for a few years.
- **Finally**! Casual users can stop caring about font-funcs
- completely now,
- like they haven't been needing to care re unicode-funcs for a
- few years.
-
src/hb-font.cc | 39 ++++++++++++++++++++++++++-------------
1 file changed, 26 insertions(+), 13 deletions(-)
@@ -18121,15 +18802,12 @@
Date: Tue Oct 9 15:12:09 2018 -0400
[ot-font] Don't pre-load cmap table
-
- Now that we have get_h_advances() and get_nominal_glyphs()
- implemented, the
- overhead of doing a proper atomic load would be once per run, NOT
- once per
+
+ Now that we have get_h_advances() and get_nominal_glyphs() implemented, the
+ overhead of doing a proper atomic load would be once per run, NOT once per
glyph. So, no need to pre-load the tables to avoid that overhead.
-
- As such, hb_ot_font_set_funcs() has become really cheap.
- Can *finally* make
+
+ As such, hb_ot_font_set_funcs() has become really cheap. Can *finally* make
it be default font functions on all newly created fonts!
src/hb-ot-font.cc | 9 +++------
@@ -18140,47 +18818,40 @@
Date: Tue Oct 9 15:07:04 2018 -0400
[ot/ft] Implement get_nominal_glyphs() callback
-
- Some more measurable speedup. The recent commits' speedups are
- as follows:
-
+
+ Some more measurable speedup. The recent commits' speedups are as follows:
+
Testing with Roboto, ****when disabling kern and liga****:
-
+
Before:
-
+
FT --features=-kern,-liga
user↦ 0m0.521s
-
+
OT --features=-liga,-kern
user↦ 0m0.568s
-
+
After:
-
+
FT --features=-liga,-kern
user↦ 0m0.428s
-
+
OT --features=-liga,-kern
user↦ 0m0.470s
-
+
So, 17% speedup.
-
- Note that FT callbacks are faster than OT these days since we added
- an advance
- cache to FT. I don't think the difference is enough to justify
- adding a cache
+
+ Note that FT callbacks are faster than OT these days since we added an advance
+ cache to FT. I don't think the difference is enough to justify adding a cache
to OT.
-
- When not disabling kern, the thing is three times slower, so the
- speedups
- are three times less impressive... Still, 5% not bad for a codebase
- that I
+
+ When not disabling kern, the thing is three times slower, so the speedups
+ are three times less impressive... Still, 5% not bad for a codebase that I
otherwise thought is optimized out.
-
+
Note that, because of this and other optimiztions in our main shaper,
- disabling kern and liga, the OT shaper is now *faster* than the
- fallback
- shaper. So, that's my recommendation to clients that need the
- absolute
+ disabling kern and liga, the OT shaper is now *faster* than the fallback
+ shaper. So, that's my recommendation to clients that need the absolute
fastest...
src/hb-ft.cc | 26 ++++++++++++++++++++++++++
@@ -18192,9 +18863,8 @@
Date: Tue Oct 9 14:50:57 2018 -0400
Call get_nominal_glyphs() for runs of simple clusters at a time
-
- Even without FT or OT font funcs implementing get_nominal_glyphs(),
- there's measurable
+
+ Even without FT or OT font funcs implementing get_nominal_glyphs(), there's measurable
speedup.
src/hb-buffer.hh | 20 +++++++++++++++++++-
@@ -18208,8 +18878,7 @@
Whitespace
src/hb-font.hh | 2 +-
- src/hb-ot-shape-normalize.cc | 52
- ++++++++++++++++++++++++--------------------
+ src/hb-ot-shape-normalize.cc | 52 ++++++++++++++++++++++++--------------------
2 files changed, 29 insertions(+), 25 deletions(-)
commit 30c114ffec335770452e60729224b1634586c5b0
@@ -18217,11 +18886,10 @@
Date: Tue Oct 9 14:37:08 2018 -0400
Avoid sort and recompose stages if all clusters simple
-
+
Even has measurable speedup...
- src/hb-ot-shape-normalize.cc | 52
- ++++++++++++++++++++++++--------------------
+ src/hb-ot-shape-normalize.cc | 52 ++++++++++++++++++++++++--------------------
1 file changed, 29 insertions(+), 23 deletions(-)
commit 9f79365c3b183278d14352ba6241c7d4ec274984
@@ -18229,17 +18897,13 @@
Date: Tue Oct 9 14:36:25 2018 -0400
Fix warning
-
+
How come this one is not generated by clang everything bot?!
-
- ../../../test/api/test-multithread.c:37:26: warning: initialization
- discards ‘const’ qualifier from pointer target type
- [-Wdiscarded-qualifiers]
+
+ ../../../test/api/test-multithread.c:37:26: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
static char *font_path = "fonts/Inconsolata-Regular.abc.ttf";
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
- ../../../test/api/test-multithread.c:38:21: warning: initialization
- discards ‘const’ qualifier from pointer target type
- [-Wdiscarded-qualifiers]
+ ../../../test/api/test-multithread.c:38:21: warning: initialization discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers]
test/api/test-multithread.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -18258,7 +18922,7 @@
Date: Tue Oct 9 14:12:59 2018 -0400
Inline decompose_cluster
-
+
Towards separating the common case into its own loop.
src/hb-ot-shape-normalize.cc | 14 ++++----------
@@ -18276,7 +18940,7 @@
Date: Tue Oct 9 09:23:51 2018 -0400
[font] Add get_nominal_glyphs() callback (note the plural)
-
+
Unused as of now. To be wired up to normalizer, which would remove
overhead and allow hb-ot-font initialization to become a no-op, so
we can enable it by default.
@@ -18303,9 +18967,8 @@
Date: Wed Jul 25 18:26:10 2018 +0800
test/api/test-subset-*.c: Fix build on pre-C99
-
- Ensure that we have the variables at the beginning of the block.
- These
+
+ Ensure that we have the variables at the beginning of the block. These
are the only fixes that we need for building HarfBuzz on older
compilers.
@@ -18323,13 +18986,13 @@
Date: Wed Jul 25 18:12:34 2018 +0800
builds: Fix and clean up MSVC DLL builds
-
+
Instead of passing a CFLAG/CXXFLAG to define HB_EXTERN, define it
directly in src/hb.hh as __declspec(dllexport) extern when we are
building HarfBuzz as DLLs on Visual Studio. Define HB_INTERNAL
as nothing without defining HB_NO_VISIBILITY when building HarfBuzz as
DLLs to avoid linker errors on Visual Studio builds.
-
+
Also "install" harfbuzz-subset.dll into $(PREFIX)\bin as the
hb-subset utility will depend on that DLL at runtime, when HarfBuzz is
built as DLLs. Since it consists of private APIs that are subject to
@@ -18354,8 +19017,7 @@
Try fixing older bots
- src/hb-ot-shape-fallback.cc | 42
- +++++++++++++++++++++---------------------
+ src/hb-ot-shape-fallback.cc | 42 +++++++++++++++++++++---------------------
1 file changed, 21 insertions(+), 21 deletions(-)
commit bee93e269711a3eda4e7d762b730522564fe6e87
@@ -18363,7 +19025,7 @@
Date: Tue Oct 9 08:01:49 2018 -0400
Add const to get_*_advances API
-
+
Ouch!
src/hb-font.cc | 10 +++++-----
@@ -18438,8 +19100,7 @@
src/hb-glib.cc | 31 +-----------------------------
src/hb-icu.cc | 33 +-------------------------------
src/hb-ucdn.cc | 8 +-------
- test/api/test-unicode.c | 51
- -------------------------------------------------
+ test/api/test-unicode.c | 51 -------------------------------------------------
4 files changed, 3 insertions(+), 120 deletions(-)
commit eed737f6726d3408191a4e64592805b70d8bb247
@@ -18451,8 +19112,7 @@
src/hb-glib.cc | 8 +------
src/hb-icu.cc | 19 +--------------
src/hb-ucdn.cc | 9 +------
- test/api/test-unicode.c | 64
- -------------------------------------------------
+ test/api/test-unicode.c | 64 -------------------------------------------------
4 files changed, 3 insertions(+), 97 deletions(-)
commit 47030b1855f04c0d75899ffb6f5021fea3c19b90
@@ -18490,11 +19150,9 @@
Deprecate font kern API
docs/harfbuzz-sections.txt | 16 +++++++-------
- src/hb-deprecated.h | 54
- ++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-deprecated.h | 54 ++++++++++++++++++++++++++++++++++++++++++++++
src/hb-font.cc | 3 +++
- src/hb-font.h | 51
- -------------------------------------------
+ src/hb-font.h | 51 -------------------------------------------
4 files changed, 65 insertions(+), 59 deletions(-)
commit a51958819fcf51ade3f8eb38001e680a419ebbba
@@ -18501,14 +19159,12 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Mon Oct 8 23:57:45 2018 -0400
- Apply TrueType/OpenType kern table when GPOS kern feature is not
- available
-
+ Apply TrueType/OpenType kern table when GPOS kern feature is not available
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/250
src/hb-ot-kern-table.hh | 24 +++++++++++--------
- src/hb-ot-layout.cc | 57
- ++++++++++++++++++++-------------------------
+ src/hb-ot-layout.cc | 57 ++++++++++++++++++++-------------------------
src/hb-ot-layout.hh | 13 +++++++++++
src/hb-ot-shape-fallback.cc | 4 ++--
src/hb-ot-shape.cc | 10 +++++---
@@ -18544,10 +19200,8 @@
[kern] Abstract away kerning machine
src/hb-font.hh | 2 +-
- src/hb-ot-kern-table.hh | 71
- +++++++++++++++++++++++++++++++++++++++++++++
- src/hb-ot-shape-fallback.cc | 67
- +++++++++++-------------------------------
+ src/hb-ot-kern-table.hh | 71 +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-fallback.cc | 67 +++++++++++-------------------------------
3 files changed, 89 insertions(+), 51 deletions(-)
commit fb4f43838154a77912a9fc3437110c81e9d34aac
@@ -18555,7 +19209,7 @@
Date: Mon Oct 8 22:44:16 2018 -0400
Add HB_DEPRECATED
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1232
src/hb-common.h | 9 +++++++++
@@ -18578,8 +19232,7 @@
Deprecate decompose_compatibility stuff
docs/harfbuzz-sections.txt | 7 +++---
- src/hb-deprecated.h | 63
- ++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-deprecated.h | 63 ++++++++++++++++++++++++++++++++++++++++++++++
src/hb-unicode.h | 47 ----------------------------------
3 files changed, 67 insertions(+), 50 deletions(-)
@@ -18616,7 +19269,7 @@
Date: Mon Oct 8 15:05:36 2018 -0700
added CFF2 get_extents
-
+
added source hb-ot-cff2-table.cc
augmented VariationData to return scalars
misc bug fixes, renaming, cleanup
@@ -18623,13 +19276,11 @@
src/Makefile.sources | 2 +
src/hb-cff-interp-common.hh | 37 ++++++-----
- src/hb-cff-interp-cs-common.hh | 134
- +++++++++++++++++++-------------------
+ src/hb-cff-interp-cs-common.hh | 134 +++++++++++++++++++-------------------
src/hb-cff-interp-dict-common.hh | 6 +-
src/hb-cff2-interp-cs.hh | 102 ++++++++++++++++++++++++-----
src/hb-ot-cff1-table.hh | 4 +-
- src/hb-ot-cff2-table.cc | 135
- +++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-cff2-table.cc | 135 +++++++++++++++++++++++++++++++++++++++
src/hb-ot-cff2-table.hh | 71 ++++++++++++--------
src/hb-ot-face.cc | 1 +
src/hb-ot-face.hh | 1 +
@@ -18693,8 +19344,7 @@
[kerx] Clean up Format2
- src/hb-aat-layout-kerx-table.hh | 48
- ++++++++---------------------------------
+ src/hb-aat-layout-kerx-table.hh | 48 ++++++++---------------------------------
1 file changed, 9 insertions(+), 39 deletions(-)
commit 8aa83d97f9e7f63e2fcb4ae965b75a39961c7d87
@@ -18702,14 +19352,13 @@
Date: Sun Oct 7 22:43:59 2018 -0400
[kern/kerx] Fix Format2 offsetting
-
+
"The values in the right class table are stored pre-multiplied by the
number of bytes in a single kerning value, and the values in the left
class table are stored pre-multiplied by the number of bytes in one
row. This eliminates needing to multiply the row and column values
together to determine the location of the kerning value. The array can
- be indexed by doing the right- and left-hand class mappings,
- adding the
+ be indexed by doing the right- and left-hand class mappings, adding the
class values to the address of the array, and fetching the kerning
value to which the new address points."
@@ -18723,8 +19372,7 @@
[kerx] Clean up Format0
- src/hb-aat-layout-kerx-table.hh | 48
- +++++++++++------------------------------
+ src/hb-aat-layout-kerx-table.hh | 48 +++++++++++------------------------------
1 file changed, 12 insertions(+), 36 deletions(-)
commit 4c3b19d52ec7a1fa46f8d0971e377a7d29b87e27
@@ -18742,10 +19390,8 @@
Move code
- src/hb-aat-layout-common.hh | 105
- --------------------------------------------
- src/hb-open-type.hh | 105
- +++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-aat-layout-common.hh | 105 --------------------------------------------
+ src/hb-open-type.hh | 105 +++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 104 insertions(+), 106 deletions(-)
commit 3515c8b187e2316dcf3abaefc84917b09449d485
@@ -18762,19 +19408,19 @@
Date: Sun Oct 7 20:46:11 2018 -0400
Rename invisible_codepoint to invisible_glyph in API
-
+
Deleted recently added API:
hb_buffer_set_invisible_codepoint()
hb_buffer_get_invisible_codepoint()
-
+
hb-shape / hb-view --invisible-codepoint
-
+
New API:
hb_buffer_set_invisible_glyph()
hb_buffer_get_invisible_glyph()
-
+
hb-shape / hb-view --invisible-glyph
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1216
docs/harfbuzz-sections.txt | 4 ++--
@@ -18789,11 +19435,10 @@
Date: Sun Oct 7 20:36:46 2018 -0400
Revert "[morx] Fix MORX-35"
-
+
This reverts commit f62f6e90ad1f1a83f77771ad65ee1ffb79470a8a.
- src/hb-aat-layout-morx-table.hh | 14
- +++++---------
+ src/hb-aat-layout-morx-table.hh | 14 +++++---------
test/shaping/data/text-rendering-tests/DISABLED | 3 +++
test/shaping/data/text-rendering-tests/Makefile.sources | 2 +-
3 files changed, 9 insertions(+), 10 deletions(-)
@@ -18803,7 +19448,7 @@
Date: Sun Oct 7 20:35:06 2018 -0400
[buffer] Improve shift_forward()
-
+
"Improve" is a strong word in this case though, I understand.
src/hb-buffer.cc | 16 +++++++++++++---
@@ -18814,11 +19459,10 @@
Date: Sun Oct 7 18:06:53 2018 -0400
[morx] Fix MORX-35
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1224
- src/hb-aat-layout-morx-table.hh | 14
- ++++++++++----
+ src/hb-aat-layout-morx-table.hh | 14 ++++++++++----
test/shaping/data/text-rendering-tests/DISABLED | 3 ---
test/shaping/data/text-rendering-tests/Makefile.sources | 2 +-
3 files changed, 11 insertions(+), 8 deletions(-)
@@ -18828,9 +19472,8 @@
Date: Sun Oct 7 18:52:12 2018 -0400
Remove some code
-
- We use scratch-flags to short-circuit this function. No need for
- previous
+
+ We use scratch-flags to short-circuit this function. No need for previous
early loop.
src/hb-ot-shape.cc | 16 +++-------------
@@ -18843,14 +19486,10 @@
[test/text-rendering-tests] Update from upstream
test/shaping/data/text-rendering-tests/Makefile.sources | 6 +++++-
- .../data/text-rendering-tests/fonts/TestMORXForty.ttf | Bin 0 ->
- 2408 bytes
- .../text-rendering-tests/fonts/TestMORXThirtyeight.ttf | Bin 0 ->
- 2444 bytes
- .../text-rendering-tests/fonts/TestMORXThirtynine.ttf | Bin 0 ->
- 2436 bytes
- .../text-rendering-tests/fonts/TestMORXThirtyseven.ttf | Bin 0 ->
- 2444 bytes
+ .../data/text-rendering-tests/fonts/TestMORXForty.ttf | Bin 0 -> 2408 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtyeight.ttf | Bin 0 -> 2444 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtynine.ttf | Bin 0 -> 2436 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtyseven.ttf | Bin 0 -> 2444 bytes
.../data/text-rendering-tests/tests/MORX-35.tests | 4 ++--
.../data/text-rendering-tests/tests/MORX-37.tests | 4 ++++
.../data/text-rendering-tests/tests/MORX-38.tests | 4 ++++
@@ -18864,8 +19503,7 @@
[kerx] Clean up kerx and KerxTable structures
- src/hb-aat-layout-kerx-table.hh | 169
- ++++++++++++++++++++++++++--------------
+ src/hb-aat-layout-kerx-table.hh | 169 ++++++++++++++++++++++++++--------------
src/hb-aat-layout-morx-table.hh | 2 +-
2 files changed, 113 insertions(+), 58 deletions(-)
@@ -18874,18 +19512,17 @@
Date: Sun Oct 7 18:41:52 2018 +0200
Add API for setting invisible-codepoint
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1216
-
+
New API:
hb_buffer_set_invisible_codepoint()
hb_buffer_get_invisible_codepoint()
-
+
hb-shape / hb-view --invisible-codepoint
docs/harfbuzz-sections.txt | 2 ++
- src/hb-buffer.cc | 42
- ++++++++++++++++++++++++++++++++++++++++++
+ src/hb-buffer.cc | 42 ++++++++++++++++++++++++++++++++++++++++++
src/hb-buffer.h | 7 +++++++
src/hb-buffer.hh | 1 +
src/hb-ot-shape.cc | 8 ++++----
@@ -18898,10 +19535,10 @@
Date: Sun Oct 7 18:23:45 2018 +0200
[ot-font] Load hmtx/vmtx lazily
-
+
Since we have get_*_advanes() API now, the overhead is once per shape,
not once per glyph.
-
+
Only cmap is warmed-up at set_funcs() time now.
src/hb-ot-font.cc | 26 +++++++++++++-------------
@@ -18930,7 +19567,7 @@
Date: Sun Oct 7 16:31:33 2018 +0200
[coretext] Fix OS X check
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1230
src/hb-coretext.cc | 4 ++--
@@ -18956,8 +19593,7 @@
src/hb-ot-shape.hh | 5 ++
src/hb-set.hh | 4 +-
src/hb-subset.cc | 2 +-
- src/hb-vector.hh | 100
- ++++++++++++++-------
+ src/hb-vector.hh | 100 ++++++++++++++-------
test/shaping/data/text-rendering-tests/DISABLED | 35 +-------
.../data/text-rendering-tests/Makefile.sources | 18 ++--
.../data/text-rendering-tests/extract-tests.py | 18 +++-
@@ -19020,7 +19656,7 @@
Date: Fri Oct 5 18:39:48 2018 +0200
[vector] Make hb_vector_t relocatable / nestable
-
+
Ugly, but...
Fixes https://github.com/harfbuzz/harfbuzz/issues/1227
@@ -19030,8 +19666,7 @@
src/hb-ot-post-table.hh | 2 +-
src/hb-set.hh | 4 +--
src/hb-subset.cc | 2 +-
- src/hb-vector.hh | 94
- +++++++++++++++++++++++++++++++------------------
+ src/hb-vector.hh | 94 +++++++++++++++++++++++++++++++------------------
7 files changed, 66 insertions(+), 42 deletions(-)
commit 5469d80707d32c733b1c60f79ab2f217e879de55
@@ -19048,9 +19683,9 @@
Date: Fri Oct 5 18:14:13 2018 +0200
[morx] Fix memory access issue
-
+
If buffer was enlarged, info was being outdated.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1225
src/hb-aat-layout-common.hh | 4 +---
@@ -19064,10 +19699,8 @@
test/shaping/data/text-rendering-tests/DISABLED | 3 +++
test/shaping/data/text-rendering-tests/Makefile.sources | 2 ++
- .../text-rendering-tests/fonts/TestMORXThirtyfive.ttf | Bin 0 ->
- 1968 bytes
- .../text-rendering-tests/fonts/TestMORXThirtysix.ttf | Bin 0 ->
- 1836 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtyfive.ttf | Bin 0 -> 1968 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtysix.ttf | Bin 0 -> 1836 bytes
.../data/text-rendering-tests/tests/MORX-35.tests | 2 ++
.../data/text-rendering-tests/tests/MORX-36.tests | 1 +
6 files changed, 8 insertions(+)
@@ -19077,13 +19710,11 @@
Date: Fri Oct 5 02:49:29 2018 +0200
Change vendor features from Harf/Buzz to HARF/BUZZ
-
+
https://github.com/harfbuzz/harfbuzz/commit/a01194aaf4c15160330b4042066263b2c963b658#commitcomment-30772041
-
- "The tag space of tags consisting of four uppercase letters (A-Z)
- with no punctuation,
- spaces, or numbers, is reserved as a vendor space. Font vendors may
- use such tags to
+
+ "The tag space of tags consisting of four uppercase letters (A-Z) with no punctuation,
+ spaces, or numbers, is reserved as a vendor space. Font vendors may use such tags to
identify private features."
src/hb-ot-shape.cc | 4 ++--
@@ -19106,8 +19737,7 @@
added CFF glyph extents API test
test/api/Makefile.am | 1 +
- test/api/test-ot-extents-cff.c | 65
- ++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-ot-extents-cff.c | 65 ++++++++++++++++++++++++++++++++++++++++++
2 files changed, 66 insertions(+)
commit 0222d57c357c775f25866653700b9dcb7d5bb807
@@ -19142,11 +19772,9 @@
Date: Thu Oct 4 16:23:42 2018 +0200
[test] Choose 'ot' shaper specifically
-
- Now that we added morx support, our OS X bot is running them through
- CoreText
- and failing (with a DoS / infinite loop no less!). Always run
- tests through
+
+ Now that we added morx support, our OS X bot is running them through CoreText
+ and failing (with a DoS / infinite loop no less!). Always run tests through
our own shaper.
test/shaping/run-tests.py | 2 +-
@@ -19166,9 +19794,8 @@
Date: Thu Oct 4 13:00:37 2018 +0200
Enable two OpenType features, 'Harf' and 'Buzz'
-
- One early, before script-specific features, one late, after.
- Allows font
+
+ One early, before script-specific features, one late, after. Allows font
developers to detect us and behave differently if needed.
src/hb-ot-shape.cc | 4 ++++
@@ -19181,23 +19808,17 @@
[test/text-rendering-tests] Update from upstream
test/shaping/data/text-rendering-tests/Makefile.sources | 6 +++++-
- test/shaping/data/text-rendering-tests/extract-tests.py | 12
- ++++++++++++
- .../data/text-rendering-tests/fonts/TestGSUBThree.ttf | Bin 0 ->
- 1504 bytes
- .../text-rendering-tests/fonts/TestMORXThirtyfour.ttf | Bin 0 ->
- 3608 bytes
- .../text-rendering-tests/fonts/TestMORXThirtythree.ttf | Bin 0 ->
- 1520 bytes
- .../text-rendering-tests/fonts/TestMORXTwentyfour.ttf | Bin 0 ->
- 1828 bytes
+ test/shaping/data/text-rendering-tests/extract-tests.py | 12 ++++++++++++
+ .../data/text-rendering-tests/fonts/TestGSUBThree.ttf | Bin 0 -> 1504 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtyfour.ttf | Bin 0 -> 3608 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtythree.ttf | Bin 0 -> 1520 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentyfour.ttf | Bin 0 -> 1828 bytes
.../shaping/data/text-rendering-tests/tests/GSUB-3.tests | 1 +
.../data/text-rendering-tests/tests/MORX-24.tests | 1 +
.../data/text-rendering-tests/tests/MORX-32.tests | 8 ++++----
.../data/text-rendering-tests/tests/MORX-33.tests | 3 +++
.../data/text-rendering-tests/tests/MORX-34.tests | 1 +
- test/shaping/run-tests.py | 15
- +++++++++------
+ test/shaping/run-tests.py | 15 +++++++++------
12 files changed, 36 insertions(+), 11 deletions(-)
commit 6ff8a8a10b62a54a87d53b0af66ccaba5d58b107
@@ -19217,8 +19838,7 @@
src/hb-ot-shape.cc | 23 ++++++++++++----
src/hb-ot-shape.hh | 5 ++++
- test/shaping/data/text-rendering-tests/DISABLED | 32
- ----------------------
+ test/shaping/data/text-rendering-tests/DISABLED | 32 ----------------------
.../data/text-rendering-tests/Makefile.sources | 14 +++++-----
4 files changed, 29 insertions(+), 45 deletions(-)
@@ -19238,49 +19858,33 @@
Date: Thu Oct 4 09:17:08 2018 +0200
Minor: Fix autoconf warning
-
+
Before this change, autoconf was emitting the following warnings:
-
+
```
- configure.ac:22: warning: AC_COMPILE_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_COMPILE_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_RUN_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_RUN_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_COMPILE_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_COMPILE_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_RUN_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_RUN_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_COMPILE_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_COMPILE_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_RUN_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_RUN_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_COMPILE_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_COMPILE_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
- configure.ac:22: warning: AC_RUN_IFELSE was called before
- AC_USE_SYSTEM_EXTENSIONS
- ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is
- expanded from...
+ configure.ac:22: warning: AC_RUN_IFELSE was called before AC_USE_SYSTEM_EXTENSIONS
+ ../../lib/autoconf/specific.m4:368: AC_USE_SYSTEM_EXTENSIONS is expanded from...
configure.ac:22: the top level
```
@@ -19292,7 +19896,7 @@
Date: Thu Oct 4 09:24:08 2018 +0200
[morx] Only insert glyphs at mark when a mark has been set before
-
+
This reverts commit f4072e8cb81072cd6d51a2607efedb76c02e7db1.
https://github.com/harfbuzz/harfbuzz/issues/1195
@@ -19364,8 +19968,7 @@
Add emoji test for recent work
test/shaping/data/in-house/Makefile.sources | 2 +-
- .../fonts/3cf6f8ac6d647473a43a3100e7494b202b2cfafe.ttf | Bin 0 ->
- 16596 bytes
+ .../fonts/3cf6f8ac6d647473a43a3100e7494b202b2cfafe.ttf | Bin 0 -> 16596 bytes
test/shaping/data/in-house/tests/emoji-flag-tags.tests | 2 --
test/shaping/data/in-house/tests/emoji.tests | 4 ++++
4 files changed, 5 insertions(+), 3 deletions(-)
@@ -19375,7 +19978,7 @@
Date: Wed Oct 3 22:49:02 2018 +0330
[ci] Delete azure-pipelines
-
+
End of experiment, we might get back to it later
azure-pipelines.yml | 10 ----------
@@ -19397,7 +20000,7 @@
Date: Wed Oct 3 21:11:13 2018 +0200
Unbreak Fitzpatrick
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1159
src/hb-ot-layout.hh | 2 +-
@@ -19408,13 +20011,11 @@
Date: Wed Oct 3 21:02:16 2018 +0200
Rewrite grapheme-formation in terms of new work
+
+ Also, don't attach ZWNJ to previous cluster. Closer to Unicode graphemes.
- Also, don't attach ZWNJ to previous cluster. Closer to Unicode
- graphemes.
-
src/hb-coretext.cc | 2 +-
- src/hb-ot-shape.cc | 48
- ++++++----------------
+ src/hb-ot-shape.cc | 48 ++++++----------------
.../in-house/tests/indic-joiner-candrabindu.tests | 2 +-
.../data/in-house/tests/indic-joiners.tests | 6 +--
4 files changed, 18 insertions(+), 40 deletions(-)
@@ -19434,12 +20035,9 @@
[test] Split a test
- .../fonts/4d4206e30b2dbf1c1ef492a8eae1c9e7829ebad8.ttf | Bin 0 ->
- 51924 bytes
- .../fonts/bb29ce50df2bdba2d10726427c6b7609bf460e04.ttf | Bin 74856 ->
- 0 bytes
- .../in-house/tests/mongolian-variation-selector.tests | 17
- ++++++++++++++++-
+ .../fonts/4d4206e30b2dbf1c1ef492a8eae1c9e7829ebad8.ttf | Bin 0 -> 51924 bytes
+ .../fonts/bb29ce50df2bdba2d10726427c6b7609bf460e04.ttf | Bin 74856 -> 0 bytes
+ .../in-house/tests/mongolian-variation-selector.tests | 17 ++++++++++++++++-
3 files changed, 16 insertions(+), 1 deletion(-)
commit ba813aab0909375af0c8f8e0c34595680c2762a4
@@ -19485,8 +20083,7 @@
[buffer] Inline some more
src/hb-buffer.cc | 44 --------------------------------------------
- src/hb-buffer.hh | 52
- ++++++++++++++++++++++++++++++++++++++++++++--------
+ src/hb-buffer.hh | 52 ++++++++++++++++++++++++++++++++++++++++++++--------
2 files changed, 44 insertions(+), 52 deletions(-)
commit 6f39c22029867c6d00cf70d7df242a28ca8f12bc
@@ -19512,13 +20109,12 @@
Date: Wed Oct 3 19:44:15 2018 +0200
[emoji] Mark emoji contination sequences as continuation
-
+
This adds a new grapheme bit. Not used yet.
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1159
- src/hb-ot-layout.hh | 83
- +++++++++++++++++++++++++----------------------------
+ src/hb-ot-layout.hh | 83 +++++++++++++++++++++++++----------------------------
src/hb-ot-shape.cc | 24 ++++++++++++++++
src/hb-unicode.hh | 5 ----
3 files changed, 63 insertions(+), 49 deletions(-)
@@ -19537,23 +20133,20 @@
Date: Wed Oct 3 21:26:58 2018 +0330
[test] Use an in-repo font for test-multithread (#1218)
+
+ As Khaled's suggestion, hard-coded font paths was only for my own testing.
- As Khaled's suggestion, hard-coded font paths was only for my own
- testing.
-
test/api/hb-subset-test.h | 13 +++++++++----
- test/api/test-multithread.c | 41
- ++++++++++++++++++++++++++---------------
+ test/api/test-multithread.c | 41 ++++++++++++++++++++++++++---------------
test/fuzzing/main.cc | 6 ++++++
3 files changed, 41 insertions(+), 19 deletions(-)
commit fde9b8852d7cd6224afeffcfe363f4b445ab1ece
-Author: azure-pipelines[bot]
-<azure-pipelines[bot]@users.noreply.github.com>
+Author: azure-pipelines[bot] <azure-pipelines[bot]@users.noreply.github.com>
Date: Wed Oct 3 17:47:05 2018 +0000
[ci] Add a test Azure Pipelines Linux bot
-
+
Related #1219
azure-pipelines.yml | 10 ++++++++++
@@ -19591,9 +20184,9 @@
Date: Wed Oct 3 17:46:48 2018 +0200
[emoji] Add emoji Extended_Pictographic table and function
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1159
-
+
.
src/Makefile.am | 12 +-
@@ -19600,8 +20193,7 @@
src/gen-emoji-table.py | 64 ++++++++++
src/hb-ot-os2-table.hh | 2 +-
src/hb-ot-os2-unicode-ranges.hh | 6 +-
- src/hb-unicode-emoji-table.hh | 269
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-unicode-emoji-table.hh | 269 ++++++++++++++++++++++++++++++++++++++++
src/hb-unicode.cc | 16 +++
src/hb-unicode.hh | 37 +++++-
7 files changed, 398 insertions(+), 8 deletions(-)
@@ -19613,8 +20205,7 @@
[os2] Minor rename/shuffle
...unicode-ranges.py => gen-os2-unicode-ranges.py} | 2 +-
- src/hb-ot-os2-unicode-ranges.hh | 45
- +++++++++++-----------
+ src/hb-ot-os2-unicode-ranges.hh | 45 +++++++++++-----------
2 files changed, 24 insertions(+), 23 deletions(-)
commit 7a1ab0464d3ee1ca5c9b31215fbffb8601ae860d
@@ -19622,7 +20213,7 @@
Date: Wed Oct 3 23:22:43 2018 +0800
Fix test-multithread build on FreeBSD (#1217)
-
+
Add the default font path used by FreeBSD ports.
test/api/test-multithread.c | 2 ++
@@ -19633,29 +20224,27 @@
Date: Wed Oct 3 14:44:25 2018 +0200
[indic] Disallow vowel mark combinations that spoof other vowel marks
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1019
-
+
New numbers:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707261 out of 707394 tests passed. 133 failed (0.0188014%)
GUJARATI: 366353 out of 366457 tests passed. 104 failed (0.0283799%)
GURMUKHI: 60729 out of 60747 tests passed. 18 failed (0.0296311%)
KANNADA: 951300 out of 951913 tests passed. 613 failed (0.0643966%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42327 out of 42329 tests passed. 2 failed (0.00472489%)
SINHALA: 271596 out of 271847 tests passed. 251 failed (0.0923313%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
-
+
Devanagari regressed because Uniscribe doesn't enforce the full set.
-
+
Tests added with the *-vowel-letters.txt files in tree and Noto fonts.
- src/hb-ot-shape-complex-indic.cc | 256
- ++++++++++++++++++++-
+ src/hb-ot-shape-complex-indic.cc | 256 ++++++++++++++++++++-
test/shaping/data/in-house/Makefile.sources | 1 +
.../03e3f463c3a985bc42096620cc415342818454fb.ttf | Bin 0 -> 2904 bytes
.../1a5face3fcbd929d228235c2f72bbd6f8eb37424.ttf | Bin 0 -> 8188 bytes
@@ -19683,10 +20272,8 @@
Typo
- .../{bengali-vowel-leters.txt => bengali-vowel-letters.txt}
- | 0
- .../{gujarati-vowel-letter.txt => gujarati-vowel-letters.txt}
- | 0
+ .../{bengali-vowel-leters.txt => bengali-vowel-letters.txt} | 0
+ .../{gujarati-vowel-letter.txt => gujarati-vowel-letters.txt} | 0
2 files changed, 0 insertions(+), 0 deletions(-)
commit 0dd9101fd0ddff80fff10ba98e93523aed95c8f5
@@ -19712,10 +20299,9 @@
Date: Wed Oct 3 07:11:22 2018 +0800
Missing colon for gobject annotation
+
+ There should be a colon separating "(transfer full)" and the rest. Warned by g-ir-scanner.
- There should be a colon separating "(transfer full)" and the
- rest. Warned by g-ir-scanner.
-
src/hb-face.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -19724,12 +20310,11 @@
Date: Wed Oct 3 12:29:56 2018 +0200
[use] Add Halant_Or_Vowel_Modifier category
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1102
src/gen-use-table.py | 7 +-
- src/hb-ot-shape-complex-use-machine.hh | 518
- +++++++++++----------
+ src/hb-ot-shape-complex-use-machine.hh | 518 +++++++++++----------
src/hb-ot-shape-complex-use-machine.rl | 9 +-
src/hb-ot-shape-complex-use-table.cc | 4 +-
src/hb-ot-shape-complex-use.hh | 5 +-
@@ -19763,10 +20348,8 @@
build/test/api/.libs/test-collect-unicodes | Bin 14336 -> 0 bytes
build/test/api/.libs/test-multithread | Bin 10936 -> 0 bytes
- build/test/api/test-collect-unicodes | 210
- -----------------------------
- build/test/api/test-multithread | 210
- -----------------------------
+ build/test/api/test-collect-unicodes | 210 -----------------------------
+ build/test/api/test-multithread | 210 -----------------------------
4 files changed, 420 deletions(-)
commit 51d5bf4ca2ebb9b8aa3b2777781e328fb93ceea7
@@ -19797,11 +20380,10 @@
Date: Tue Oct 2 13:45:14 2018 -0700
redefine OpCodes as define instead of enum
-
+
in order to eradicate duplicate enum warnings
- src/hb-cff-interp-common.hh | 348
- ++++++++++++++++++++++----------------------
+ src/hb-cff-interp-common.hh | 348 ++++++++++++++++++++++----------------------
1 file changed, 174 insertions(+), 174 deletions(-)
commit 9cdd70b344b9dc34a29aeca79028cbb5d949ca1d
@@ -19816,7 +20398,7 @@
Date: Tue Oct 2 21:39:19 2018 +0330
[circleci] Fix some of warnings from clang-everything bot (#1211)
-
+
* -Wshift-sign-overflow
* -Wmissing-prototypes
@@ -19833,11 +20415,10 @@
Date: Tue Oct 2 18:56:20 2018 +0200
[tests] Allow test-runner to ignore shaping output
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1212
- test/shaping/data/in-house/tests/fuzzed.tests | 46
- +++++++++++++--------------
+ test/shaping/data/in-house/tests/fuzzed.tests | 46 +++++++++++++--------------
test/shaping/run-tests.py | 2 +-
2 files changed, 24 insertions(+), 24 deletions(-)
@@ -19848,8 +20429,7 @@
[tibetan] Remove unused Tibetan shaper
src/Makefile.sources | 1 -
- src/hb-ot-shape-complex-tibetan.cc | 63
- --------------------------------------
+ src/hb-ot-shape-complex-tibetan.cc | 63 --------------------------------------
src/hb-ot-shape-complex.hh | 1 -
3 files changed, 65 deletions(-)
@@ -19858,17 +20438,16 @@
Date: Tue Oct 2 18:43:29 2018 +0200
[tibetan] Route Tibetan through USE
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/933
https://github.com/harfbuzz/harfbuzz/issues/1012
-
+
Tibetan failures go from 0 to 2:
-
+
TIBETAN: 208467 out of 208469 tests passed. 2 failed (0.000959375%)
src/gen-use-table.py | 30 ++++++++++------
- src/hb-ot-shape-complex-use-table.cc | 70
- ++++++++++++++++++++++--------------
+ src/hb-ot-shape-complex-use-table.cc | 70 ++++++++++++++++++++++--------------
src/hb-ot-shape-complex.hh | 8 +----
3 files changed, 65 insertions(+), 43 deletions(-)
@@ -19887,11 +20466,10 @@
Date: Tue Oct 2 17:49:06 2018 +0200
[indic/use] Factor common expressions in ragel machine
-
+
No machine change.
- src/hb-ot-shape-complex-indic-machine.hh | 46
- ++++++++++++++++----------------
+ src/hb-ot-shape-complex-indic-machine.hh | 46 ++++++++++++++++----------------
src/hb-ot-shape-complex-indic-machine.rl | 10 ++++---
src/hb-ot-shape-complex-use-machine.hh | 38 +++++++++++++-------------
src/hb-ot-shape-complex-use-machine.rl | 20 +++++++-------
@@ -19902,7 +20480,7 @@
Date: Tue Oct 2 17:46:27 2018 +0200
[indic] Minor flip grammar around
-
+
No behavior change.
src/hb-ot-shape-complex-indic-machine.rl | 2 +-
@@ -19916,8 +20494,7 @@
[indic] Add some confusable sequences from Unicode Standard
.../script-bengali/bengali-vowel-leters.txt | 3 ++
- .../devanagari-atomic-consonants.txt | 33
- ++++++++++++++++++++++
+ .../devanagari-atomic-consonants.txt | 33 ++++++++++++++++++++++
.../script-devanagari/devanagari-vowel-letters.txt | 17 +++++++++++
.../script-gujarati/gujarati-vowel-letter.txt | 8 ++++++
.../script-gurmukhi/gurmukhi-vowel-letters.txt | 9 ++++++
@@ -19948,7 +20525,7 @@
Date: Tue Oct 2 16:05:26 2018 +0200
Treat a base+mark... ligature as base, not ligature
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/746
src/hb-ot-layout-gsubgpos.hh | 22 +++++++++++++++-------
@@ -19992,13 +20569,12 @@
Date: Tue Oct 2 14:40:14 2018 +0200
Disable joiner-skipping when looking back for base to attach mark to
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1189
src/hb-ot-shape.cc | 5 ++++-
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/641ca9d7808b01cafa9a666c13811c9b56eb9c52.ttf | Bin 0 ->
- 11492 bytes
+ .../fonts/641ca9d7808b01cafa9a666c13811c9b56eb9c52.ttf | Bin 0 -> 11492 bytes
.../data/in-house/tests/arabic-mark-attach.tests | 1 +
4 files changed, 6 insertions(+), 1 deletion(-)
@@ -20010,8 +20586,7 @@
src/hb-buffer.hh | 3 +--
src/hb-ot-layout.hh | 12 ++----------
- src/hb-ot-shape-complex-arabic.cc | 41
- ++++++---------------------------------
+ src/hb-ot-shape-complex-arabic.cc | 41 ++++++---------------------------------
3 files changed, 9 insertions(+), 47 deletions(-)
commit 48c513fec978819927535bc86b43be74315f746c
@@ -20061,8 +20636,7 @@
Rename
src/hb-ot-face.cc | 20 +++++++-------
- src/hb-ot-face.hh | 78
- +++++++++++++++++++++++++++----------------------------
+ src/hb-ot-face.hh | 78 +++++++++++++++++++++++++++----------------------------
2 files changed, 49 insertions(+), 49 deletions(-)
commit 10b6c7c63870fa04cd8adcf9f38644c2a799db8a
@@ -20104,7 +20678,7 @@
Date: Tue Oct 2 08:25:29 2018 +0200
Skip BOM in the Python sample file
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1208
src/sample.py | 6 +++---
@@ -20115,7 +20689,7 @@
Date: Tue Oct 2 06:43:06 2018 +0100
Missing "out" indicator (#1209)
-
+
Missing "out" indicator. Affect gobject introspection.
src/hb-font.cc | 2 +-
@@ -20148,13 +20722,11 @@
Date: Mon Oct 1 20:05:00 2018 +0200
[indic] Remove Consonant_Medial from grammar and code
-
- The only Indic CM is U+0A75 GURMUKHI SIGN YAKASH, which Uniscribe
- doesn't treat
+
+ The only Indic CM is U+0A75 GURMUKHI SIGN YAKASH, which Uniscribe doesn't treat
specially, and font designers design for that. So, do the same.
- src/hb-ot-shape-complex-indic-machine.hh | 1244
- ++++++++++++++----------------
+ src/hb-ot-shape-complex-indic-machine.hh | 1244 ++++++++++++++----------------
src/hb-ot-shape-complex-indic-machine.rl | 10 +-
src/hb-ot-shape-complex-indic.cc | 2 +-
src/hb-ot-shape-complex-indic.hh | 6 +-
@@ -20165,13 +20737,12 @@
Date: Mon Oct 1 19:35:48 2018 +0200
[khmer] Add mark-ordering tests
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/667
test/shaping/data/in-house/Makefile.sources | 2 ++
.../b6031119874ae9ff1dd65383a335e361c0962220.ttf | Bin 0 -> 2564 bytes
- .../data/in-house/tests/khmer-mark-order.tests | 25
- +++++++++++++++++++++
+ .../data/in-house/tests/khmer-mark-order.tests | 25 +++++++++++++++++++++
3 files changed, 27 insertions(+)
commit 51436547162a18e88144e7125ad6ce4a69a08d4b
@@ -20179,23 +20750,20 @@
Date: Mon Oct 1 19:09:58 2018 +0200
[khmer] Rewrite grammar completely
-
- Based on experimenting with Uniscribe to extract grammar and
- categories.
-
+
+ Based on experimenting with Uniscribe to extract grammar and categories.
+
Failures down from 44 to 35:
-
+
KHMER: 299089 out of 299124 tests passed. 35 failed (0.0117008%)
-
- We still don't enforce the one-matra rule pre-decomposition,
- but enforce
+
+ We still don't enforce the one-matra rule pre-decomposition, but enforce
an order and one-matra-per-position post-decomposition.
-
+
https://github.com/harfbuzz/harfbuzz/issues/667
src/hb-ot-shape-complex-indic.hh | 2 +-
- src/hb-ot-shape-complex-khmer-machine.hh | 300
- ++++++++++++++++++++-----------
+ src/hb-ot-shape-complex-khmer-machine.hh | 300 ++++++++++++++++++++-----------
src/hb-ot-shape-complex-khmer-machine.rl | 42 +++--
src/hb-ot-shape-complex-khmer.cc | 4 +-
src/hb-ot-shape-complex-khmer.hh | 99 +++++-----
@@ -20231,7 +20799,7 @@
Date: Mon Oct 1 15:01:04 2018 +0200
[use] Disable automatic ZWJ for 'akhn' feature
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/746
src/hb-ot-shape-complex-use.cc | 2 +-
@@ -20242,7 +20810,7 @@
Date: Mon Oct 1 12:45:06 2018 +0200
[use] Change categories for Left_And_* matras
-
+
These are only relevant to Sinhala, because they decompose in other
cases. The USE spec categorizes them all as VPst. No idea why we
weren't following that before.
@@ -20265,7 +20833,7 @@
Date: Mon Oct 1 12:10:00 2018 +0200
[morx] Break out if buffer gets into error
-
+
Was getting stuck not making progress somehow.
src/hb-aat-layout-common.hh | 2 ++
@@ -20277,7 +20845,7 @@
Date: Mon Oct 1 11:34:20 2018 +0200
[cache] Fix cache coherency corner-case
-
+
If key_bits+value_bits-cache_bits==32 then -1 is ambiguous...
src/hb-cache.hh | 6 ++++--
@@ -20288,7 +20856,7 @@
Date: Mon Oct 1 09:40:29 2018 +0330
[circleci] Couple of fixes (#1200)
-
+
* Raise error on warnings on -everything
* Enable fontconfig to two bots
* Fix msan bot now that all of its real complain are gone
@@ -20333,9 +20901,9 @@
Date: Sun Sep 30 18:25:58 2018 +0200
Revert "Fix glib-mkenum warning"
-
+
This reverts commit 247756a7d89008ee6a7d1171dc07ba22454c6034.
-
+
Was wrong. Right fix coming.
src/hb-buffer.h | 2 ++
@@ -20356,7 +20924,7 @@
Date: Sun Sep 30 18:19:54 2018 +0200
Change _HB_SCRIPT_MAX_VALUE from 0xFFFFFFFF to 0x7FFFFFFF
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/504
src/hb-common.h | 8 +++++---
@@ -20392,7 +20960,7 @@
Date: Sun Sep 30 17:48:55 2018 +0200
Fix bug introduced in 9b0b40b3c1ac8155c80ed5dc976228f4d3ec7e1f
-
+
Also discovered by msan bot.
src/hb-ot-shape-fallback.cc | 2 +-
@@ -20403,7 +20971,7 @@
Date: Sun Sep 30 13:10:54 2018 +0200
Fix glib-mkenum warning
-
+
GEN hb-gobject-enums.h
WARNING: Failed to parse "/*< private >*/" in ../../src/hb-buffer.h
@@ -20460,17 +21028,14 @@
Date: Sun Sep 30 12:23:01 2018 +0200
[util] Remove unneeded virtual
-
+
clang warning:
-
- ../../util/options.hh:72:13: warning: destination for this 'memset'
- call is a pointer to dynamic class
- 'option_parser_t'; vtable pointer will be overwritten
- [-Wdynamic-class-memaccess]
+
+ ../../util/options.hh:72:13: warning: destination for this 'memset' call is a pointer to dynamic class
+ 'option_parser_t'; vtable pointer will be overwritten [-Wdynamic-class-memaccess]
memset (this, 0, sizeof (*this));
~~~~~~ ^
- ../../util/options.hh:72:13: note: explicitly cast the pointer to
- silence this warning
+ ../../util/options.hh:72:13: note: explicitly cast the pointer to silence this warning
memset (this, 0, sizeof (*this));
^
(void*)
@@ -20501,29 +21066,26 @@
Date: Sun Sep 30 05:49:08 2018 -0400
[util] Use HB_FALLTHROUGH
-
+
Sure, gcc knows to warn about this as well:
-
- ../../util/options.cc:175:17: warning: this statement may fall through
- [-Wimplicit-fallthrough=]
+
+ ../../util/options.cc:175:17: warning: this statement may fall through [-Wimplicit-fallthrough=]
case 1: m.r = m.t;
~~~~^~~~~
../../util/options.cc:176:5: note: here
case 2: m.b = m.t;
^~~~
-
+
But HOLY SMOKES, look at clang -Weverything bot message:
-
- options.cc:176:5: warning: unannotated fall-through between switch
- labels [-Wimplicit-fallthrough]
+
+ options.cc:176:5: warning: unannotated fall-through between switch labels [-Wimplicit-fallthrough]
case 2: m.b = m.t;
^
- options.cc:176:5: note: insert 'HB_FALLTHROUGH;' to silence this
- warning
+ options.cc:176:5: note: insert 'HB_FALLTHROUGH;' to silence this warning
case 2: m.b = m.t;
^
HB_FALLTHROUGH;
-
+
Right, it's telling me to insert "HB_FALLTHROUGH;" there!!!!!!!!!
util/options.cc | 10 +++++-----
@@ -20534,13 +21096,11 @@
Date: Sun Sep 30 05:47:36 2018 -0400
[util] Mark var static
-
+
From clang -Weverything bot:
+
+ options.cc:39:3: warning: no previous extern declaration for non-static variable 'supported_font_funcs' [-Wmissing-variable-declarations]
- options.cc:39:3: warning: no previous extern declaration
- for non-static variable 'supported_font_funcs'
- [-Wmissing-variable-declarations]
-
util/options.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -20549,11 +21109,10 @@
Date: Sun Sep 30 05:46:20 2018 -0400
[util] Add empty virtual destructor to option_group_t
-
+
From clang -Weverything bot:
-
- ./options.hh:57:8: warning: 'option_group_t' has virtual functions
- but non-virtual destructor [-Wnon-virtual-dtor]
+
+ ./options.hh:57:8: warning: 'option_group_t' has virtual functions but non-virtual destructor [-Wnon-virtual-dtor]
struct option_group_t
^
@@ -20565,23 +21124,20 @@
Date: Sun Sep 30 05:43:22 2018 -0400
[indic/khmer] Remove use of global constructors
-
+
Alternative woul have been to resurrect F_COMBINE that I removed in
70136a78cb9eda244767f8e8a3d30d0f3c569d01
-
- But this does it for now. I'm not sure why check-static-inits.sh
- didn't
+
+ But this does it for now. I'm not sure why check-static-inits.sh didn't
catch this before. Clang -Weverything bot did:
-
+
CXX libharfbuzz_la-hb-ot-shape-complex-indic.lo
- hb-ot-shape-complex-indic.cc:99:1: warning: declaration requires a
- global constructor [-Wglobal-constructors]
+ hb-ot-shape-complex-indic.cc:99:1: warning: declaration requires a global constructor [-Wglobal-constructors]
indic_features[] =
^
1 warning generated.
CXX libharfbuzz_la-hb-ot-shape-complex-khmer.lo
- hb-ot-shape-complex-khmer.cc:36:1: warning: declaration requires a
- global constructor [-Wglobal-constructors]
+ hb-ot-shape-complex-khmer.cc:36:1: warning: declaration requires a global constructor [-Wglobal-constructors]
khmer_features[] =
^
1 warning generated.
@@ -20596,29 +21152,22 @@
Date: Sun Sep 30 05:34:30 2018 -0400
Tweak HB_TAG and HB_UNTAG
-
- uint32_t was getting promoted to signed int, which is not what
- we wanted...
-
+
+ uint32_t was getting promoted to signed int, which is not what we wanted...
+
Wow, clang has become good at generating warnings...
-
- ../../src/hb-common.h:349:29: warning: signed shift result
- (0xFF000000) sets the sign bit of the shift expression's type ('int')
- and becomes negative [-Wshift-sign-overflow]
- _HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*<
- skip >*/
+
+ ../../src/hb-common.h:349:29: warning: signed shift result (0xFF000000) sets the sign bit of the shift expression's type ('int') and becomes negative [-Wshift-sign-overflow]
+ _HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*< skip >*/
^~~~~~~~~~
../../src/hb-common.h:93:20: note: expanded from macro 'HB_TAG_MAX'
define HB_TAG_MAX HB_TAG(0xff,0xff,0xff,0xff)
^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/hb-common.h:89:57: note: expanded from macro 'HB_TAG'
- define HB_TAG(c1,c2,c3,c4)
- ((hb_tag_t)((((uint8_t)(c1))<<24)|(((uint8_t)(c2))<<16)|(((uint8_t)(c3))<<8)|((uint8_t)(c4))))
+ define HB_TAG(c1,c2,c3,c4) ((hb_tag_t)((((uint8_t)(c1))<<24)|(((uint8_t)(c2))<<16)|(((uint8_t)(c3))<<8)|((uint8_t)(c4))))
~~~~~~~~~~~~~~~^ ~~
- ../../src/hb-common.h:349:3: warning: ISO C restricts enumerator
- values to range of 'int' (4294967295 is too large) [-Wpedantic]
- _HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*<
- skip >*/
+ ../../src/hb-common.h:349:3: warning: ISO C restricts enumerator values to range of 'int' (4294967295 is too large) [-Wpedantic]
+ _HB_SCRIPT_MAX_VALUE = HB_TAG_MAX, /*< skip >*/
^ ~~~~~~~~~~
src/hb-common.h | 4 ++--
@@ -20629,7 +21178,7 @@
Date: Sun Sep 30 05:27:39 2018 -0400
[font] Make *_advance() fallback to *_advances
-
+
And remove redundant implementations.
src/hb-font.cc | 12 ++++++++++++
@@ -20653,7 +21202,7 @@
Date: Sun Sep 30 03:49:52 2018 -0400
Document setlocale() threadsafety issue
-
+
"Fixes" //github.com/harfbuzz/harfbuzz/issues/1191
src/hb-buffer.cc | 2 ++
@@ -20710,7 +21259,7 @@
Date: Sat Sep 29 03:10:13 2018 +0330
[circleci] Improve clang-everything bot log, more to come
-
+
#1196
.circleci/config.yml | 2 +-
@@ -20730,10 +21279,9 @@
Date: Sat Sep 29 01:57:50 2018 +0330
[ci] Another try on fixing mingw bots
+
+ Per https://github.com/Alexpux/MSYS2-packages/issues/163#issuecomment-73555971
- Per
- https://github.com/Alexpux/MSYS2-packages/issues/163#issuecomment-73555971
-
appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -20742,7 +21290,7 @@
Date: Fri Sep 28 20:53:48 2018 +0330
[tests] Don't try to get glyph names on failures
-
+
As it may cause a race unrelated to the issue actually happened
test/api/test-multithread.c | 4 ++--
@@ -20753,7 +21301,7 @@
Date: Fri Sep 28 20:47:21 2018 +0330
[ci] Trying to fix mingw bot
-
+
As https://github.com/Alexpux/MSYS2-packages/issues/702
appveyor.yml | 2 +-
@@ -20764,7 +21312,7 @@
Date: Fri Sep 28 11:06:49 2018 -0400
Fix pthread fail for real
-
+
Using a hack...
test/api/Makefile.am | 4 +++-
@@ -20784,13 +21332,11 @@
Date: Fri Sep 28 10:14:23 2018 -0400
[morx] Remove mark_set from Insertion
-
- text-rendering-tests test MORX-32 shows that for Insertion, an unset
- mark is treated
- as mark set at 0. This is unlike the Reordering lookup where un
- unset mark performs
+
+ text-rendering-tests test MORX-32 shows that for Insertion, an unset mark is treated
+ as mark set at 0. This is unlike the Reordering lookup where un unset mark performs
nothing.
-
+
Fixes MORX-32.
src/hb-aat-layout-morx-table.hh | 7 +------
@@ -20801,7 +21347,7 @@
Date: Fri Sep 28 10:00:07 2018 -0400
[morx] unsafe-to-break in Insertion
-
+
Makes MORX-29, MORX-30, MORX-31 pass.
src/hb-aat-layout-morx-table.hh | 2 ++
@@ -20815,12 +21361,9 @@
test/shaping/data/text-rendering-tests/DISABLED | 4 ++++
test/shaping/data/text-rendering-tests/Makefile.sources | 4 ++++
- .../text-rendering-tests/fonts/TestMORXThirtyone.ttf | Bin 0 ->
- 2964 bytes
- .../text-rendering-tests/fonts/TestMORXThirtytwo.ttf | Bin 0 ->
- 2948 bytes
- .../text-rendering-tests/fonts/TestMORXTwentynine.ttf | Bin 0 ->
- 3012 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtyone.ttf | Bin 0 -> 2964 bytes
+ .../text-rendering-tests/fonts/TestMORXThirtytwo.ttf | Bin 0 -> 2948 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentynine.ttf | Bin 0 -> 3012 bytes
.../data/text-rendering-tests/tests/MORX-29.tests | 4 ++++
.../data/text-rendering-tests/tests/MORX-30.tests | 4 ++++
.../data/text-rendering-tests/tests/MORX-31.tests | 8 ++++++++
@@ -20878,8 +21421,7 @@
test-multithread, check the results on every iteration (#1194)
- test/api/test-multithread.c | 59
- ++++++++++++++++++++++++---------------------
+ test/api/test-multithread.c | 59 ++++++++++++++++++++++++---------------------
1 file changed, 32 insertions(+), 27 deletions(-)
commit dbc3070a15290310bb5aade11d04eb24fe958094
@@ -20914,7 +21456,7 @@
Date: Thu Sep 27 16:54:23 2018 -0400
[cache] Use atomic writes in clear()
-
+
To help TSan.
src/hb-cache.hh | 5 ++++-
@@ -20925,9 +21467,8 @@
Date: Thu Sep 27 16:33:49 2018 +0200
Fix infinite loop when walking up the directory hierarchy (#1183)
-
- A single find_package(harfbuzz) line in user code resulted in
- this loop
+
+ A single find_package(harfbuzz) line in user code resulted in this loop
getting stuck when _harfbuzz_libdir_iter became "/".
src/harfbuzz-config.cmake.in | 4 ++++
@@ -20956,7 +21497,7 @@
Date: Wed Sep 26 16:30:26 2018 -0700
Added CFF1 J font subset to api test
-
+
Also fixed FDSelect3_4::get_fd
Fixed test_subset_cff1_strip_hints (wrong font names!)
@@ -20963,8 +21504,7 @@
src/hb-ot-cff-common.hh | 2 +-
.../fonts/SourceHanSans-Regular.41,3041,4E9D.otf | Bin 0 -> 5864 bytes
test/api/fonts/SourceHanSans-Regular.41,4E9D.otf | Bin 0 -> 5500 bytes
- test/api/test-subset-cff1.c | 25
- +++++++++++++++++++--
+ test/api/test-subset-cff1.c | 25 +++++++++++++++++++--
4 files changed, 24 insertions(+), 3 deletions(-)
commit 662f7d7e8bfa77b21ffa05e853f61dda993dcc8a
@@ -20972,7 +21512,7 @@
Date: Wed Sep 26 18:42:37 2018 -0400
[arabic] Do the joiner-flipping only for rlig feature
-
+
See comment.
src/hb-ot-shape-complex-arabic.cc | 24 +++++++++++++++++++-----
@@ -21010,8 +21550,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Thu Sep 27 00:08:06 2018 +0330
- [ci] Compile freetype on tsan and put sanitizer flags on correct
- places (#1188)
+ [ci] Compile freetype on tsan and put sanitizer flags on correct places (#1188)
.circleci/config.yml | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
@@ -21052,11 +21591,10 @@
Date: Wed Sep 26 15:02:21 2018 -0400
Fix test-multithread and increase num_threads to 30
-
+
What were you thinking? ;)
- test/api/test-multithread.c | 56
- +++++++++++++++++++++------------------------
+ test/api/test-multithread.c | 56 +++++++++++++++++++++------------------------
1 file changed, 26 insertions(+), 30 deletions(-)
commit 8bb73dad7f3279e1f1362cf9a137504e8ef08985
@@ -21066,8 +21604,7 @@
Add a multithreaded test (#1184)
test/api/Makefile.am | 6 ++
- test/api/test-multithread.c | 146
- ++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-multithread.c | 146 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 152 insertions(+)
commit 04caf11608d2db13eb6ed2ecc3d406e284b4c13c
@@ -21075,7 +21612,7 @@
Date: Wed Sep 26 12:13:47 2018 -0400
[hb-view] Change subpixel bits from 8 to 6
-
+
To match FreeType units, such that FreeType gets correct size from us.
This matters more now that we allow setting --ft-load-flags.
@@ -21087,7 +21624,7 @@
Date: Tue Sep 25 12:47:37 2018 -0400
Fix iOS build
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/1179
src/hb-coretext.cc | 4 ++--
@@ -21107,7 +21644,7 @@
Date: Mon Sep 24 22:49:44 2018 -0700
fixed memory leaks
-
+
in CFF1 & CFF2 accelerators, VORG subsetter
src/hb-ot-cff1-table.hh | 2 ++
@@ -21128,10 +21665,8 @@
test/api/fonts/SourceSansPro-Regular.abc.otf | Bin 0 -> 3412 bytes
.../api/fonts/SourceSansPro-Regular.ac.nohints.otf | Bin 0 -> 3228 bytes
test/api/fonts/SourceSansPro-Regular.ac.otf | Bin 0 -> 3332 bytes
- test/api/test-subset-cff1.c | 104
- +++++++++++++++++++++
- test/api/test-subset-cff2.c | 104
- +++++++++++++++++++++
+ test/api/test-subset-cff1.c | 104 +++++++++++++++++++++
+ test/api/test-subset-cff2.c | 104 +++++++++++++++++++++
9 files changed, 212 insertions(+)
commit 8282e881b51363811078bce53fad6aa5b41f7b41
@@ -21139,7 +21674,7 @@
Date: Mon Sep 24 19:43:01 2018 -0400
Disable msan bot again
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1175
.circleci/config.yml | 2 +-
@@ -21179,9 +21714,8 @@
Date: Mon Sep 24 18:03:34 2018 -0400
Remove F_COMBINE
-
- Now I wonder if any bots will be unhappy we calling | in static
- const initializations...
+
+ Now I wonder if any bots will be unhappy we calling | in static const initializations...
Or would that cost runtime init? Our tests don't detect any..
src/hb-ot-map.hh | 2 --
@@ -21214,8 +21748,7 @@
src/hb-ot-map.hh | 15 ++++++++++-
src/hb-ot-shape-complex-hangul.cc | 2 +-
- src/hb-ot-shape-complex-indic.cc | 52
- +++++++++++++++-----------------------
+ src/hb-ot-shape-complex-indic.cc | 52 +++++++++++++++-----------------------
src/hb-ot-shape-complex-khmer.cc | 38 ++++++++++------------------
src/hb-ot-shape-complex-myanmar.cc | 2 +-
5 files changed, 51 insertions(+), 58 deletions(-)
@@ -21224,11 +21757,9 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Tue Sep 25 01:00:32 2018 +0330
- [circleci] Update sanitizer bots with newer clang and Ubuntu version
- (#1176)
+ [circleci] Update sanitizer bots with newer clang and Ubuntu version (#1176)
- .circleci/config.yml | 48
- ++++++++++++++++++++++++++++++++----------------
+ .circleci/config.yml | 48 ++++++++++++++++++++++++++++++++----------------
1 file changed, 32 insertions(+), 16 deletions(-)
commit 12b8baa7653741ba13a89cd40f1f36b8bac11666
@@ -21235,8 +21766,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Mon Sep 24 17:22:39 2018 -0400
- [msan] Enable again to get a build log, and try to play with
- suppressions
+ [msan] Enable again to get a build log, and try to play with suppressions
.circleci/config.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -21271,7 +21801,7 @@
Date: Mon Sep 24 13:04:48 2018 -0400
[check-symbols.sh] Allow weak objects "V"
-
+
ubsan generates these.
src/check-symbols.sh | 2 +-
@@ -21282,9 +21812,9 @@
Date: Mon Sep 24 13:01:35 2018 -0400
Link API test programs with C++ linker
-
+
Needed to make ubsan work.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1174
test/api/Makefile.am | 2 ++
@@ -21295,7 +21825,7 @@
Date: Mon Sep 24 12:52:42 2018 -0400
[msan] Add MSAN_OPTIONS=exitcode=42
-
+
Default exit value is 77, which causes autotools to "skip" test.
.circleci/config.yml | 2 +-
@@ -21306,7 +21836,7 @@
Date: Mon Sep 24 12:43:29 2018 -0400
[circleci] Disable msan and ubsan builds
-
+
https://github.com/harfbuzz/harfbuzz/issues/1174
https://github.com/harfbuzz/harfbuzz/issues/1175
@@ -21318,7 +21848,7 @@
Date: Mon Sep 24 11:52:22 2018 -0400
Ignore weak symbols in check-symbols.sh
-
+
Some clang versions leave a std::round(float) weak symbol around...
src/check-symbols.sh | 2 +-
@@ -21329,7 +21859,7 @@
Date: Mon Sep 24 10:43:06 2018 -0400
[docs] A few improvements
-
+
If we wrote just this much every day...
src/hb-buffer.cc | 4 ++++
@@ -21351,9 +21881,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Mon Sep 24 09:56:18 2018 -0400
- Revert change that would decompose text if GPOS mark feature is
- available
-
+ Revert change that would decompose text if GPOS mark feature is available
+
https://github.com/harfbuzz/harfbuzz/issues/653#issuecomment-423905920
src/hb-ot-shape-normalize.cc | 4 +++-
@@ -21364,7 +21893,7 @@
Date: Mon Sep 24 09:54:37 2018 -0400
Fix normalization
-
+
https://github.com/harfbuzz/harfbuzz/commit/62d1e0852a5549a1b510ad46a4b89f12730bb708#commitcomment-30613091
src/hb-ot-shape-normalize.cc | 1 -
@@ -21375,9 +21904,9 @@
Date: Sun Sep 23 22:33:38 2018 -0400
Simplify ZWJ-skipping a bit
-
+
Towards disabling ZWJ-skipping in certain GPOS contexts.
-
+
Part of https://github.com/flutter/flutter/issues/16886
src/hb-ot-layout-gsubgpos.hh | 6 +++---
@@ -21392,7 +21921,7 @@
Date: Sun Sep 23 22:00:34 2018 -0400
Reinit skippy iters when auto_zwj / auto_zwnj change
-
+
Ouch. How did we not hit this bug before...
src/hb-ot-layout-gsubgpos.hh | 17 +++++++++--------
@@ -21403,12 +21932,11 @@
Date: Sun Sep 23 21:32:18 2018 -0400
Prefer decomposed form if font has GPOS mark feature
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/653
src/hb-ot-shape-complex-hebrew.cc | 2 +-
- src/hb-ot-shape-normalize.cc | 126
- ++++++++++++++++++++------------------
+ src/hb-ot-shape-normalize.cc | 126 ++++++++++++++++++++------------------
src/hb-ot-shape-normalize.hh | 7 ++-
3 files changed, 72 insertions(+), 63 deletions(-)
@@ -21417,9 +21945,9 @@
Date: Sun Sep 23 19:12:52 2018 -0400
[ot-font] Fix leak
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1171
-
+
I'm glad we have leak-detector bots now.
src/hb-ot-post-table.hh | 1 +
@@ -21431,8 +21959,7 @@
Add bots with address- and thread-sanitizer
- .circleci/config.yml | 52
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ .circleci/config.yml | 52 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
commit 24dd6c1a9d8d571c30dce4d39c1975b1d1cedc2a
@@ -21450,7 +21977,7 @@
Date: Sat Sep 22 16:41:56 2018 +0200
[test] Fix printing subprocess error messages
-
+
Decode the string as Python 3 returns bytes string, and also don’t
assume that it ends with a new line.
@@ -21462,7 +21989,7 @@
Date: Sat Sep 22 17:24:03 2018 +0330
Fix test-subset-* leak issues
-
+
See also https://github.com/harfbuzz/harfbuzz/pull/1169
test/api/hb-subset-test.h | 12 +++++++++---
@@ -21473,7 +22000,7 @@
Date: Sat Sep 22 17:05:52 2018 +0330
Fix test-ot-math leak issue
-
+
See also https://github.com/harfbuzz/harfbuzz/pull/1169
test/api/test-ot-math.c | 4 ++++
@@ -21484,7 +22011,7 @@
Date: Sat Sep 22 16:49:23 2018 +0330
Fix test-set leak issue
-
+
See also https://github.com/harfbuzz/harfbuzz/pull/1169
test/api/test-set.c | 1 +
@@ -21495,7 +22022,7 @@
Date: Sat Sep 22 16:45:31 2018 +0330
Fix test-font leak issue
-
+
See also https://github.com/harfbuzz/harfbuzz/pull/1169
test/api/test-font.c | 1 +
@@ -21506,7 +22033,7 @@
Date: Fri Sep 21 12:16:36 2018 -0700
fixed subroutinized CFF2 flattening
-
+
and some code cleanup
src/hb-cff-interp-common.hh | 2 +-
@@ -21519,11 +22046,9 @@
Date: Thu Sep 20 10:31:06 2018 -0700
Added desubroutinize option to generate-expected-outputs.py
-
+
Currently hb-subset always desubroutinizes CFF fonts.
- Note that even with this option fonttools won't generate the expected
- subset CFF fonts. They were manually created & tweaked to match
- hb-subset output.
+ Note that even with this option fonttools won't generate the expected subset CFF fonts. They were manually created & tweaked to match hb-subset output.
test/subset/generate-expected-outputs.py | 1 +
1 file changed, 1 insertion(+)
@@ -21533,12 +22058,11 @@
Date: Thu Sep 20 09:45:43 2018 -0700
Added VORG struct and its subsetter
-
+
new file: hb-ot-vorg-table.hh
src/Makefile.sources | 1 +
- src/hb-ot-vorg-table.hh | 163
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-vorg-table.hh | 163 ++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset.cc | 5 +-
3 files changed, 168 insertions(+), 1 deletion(-)
@@ -21556,38 +22080,23 @@
Date: Wed Sep 19 17:00:10 2018 -0700
Added SourceHanSans-Regular for CFF subset test
+
+ Disabled FDSelect serialization to format 0 for compatibility with fonttools
- Disabled FDSelect serialization to format 0 for compatibility with
- fonttools
-
- src/hb-subset-cff-common.cc | 16
- +++++++++++++---
- .../japanese/SourceHanSans-Regular.default..otf | Bin 0 ->
- 2340 bytes
- ...Regular.default.3042,3044,3046,3048,304A,304B.otf | Bin 0 ->
- 6248 bytes
- ...Regular.default.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 ->
- 6432 bytes
- .../SourceHanSans-Regular.default.61,63,65,6B.otf | Bin 0 ->
- 5428 bytes
- ...Regular.default.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 ->
- 6552 bytes
- .../japanese/SourceHanSans-Regular.default.660E.otf | Bin 0 ->
- 5196 bytes
- .../japanese/SourceHanSans-Regular.drop-hints..otf | Bin 0 ->
- 2188 bytes
- ...ular.drop-hints.3042,3044,3046,3048,304A,304B.otf | Bin 0 ->
- 6076 bytes
- ...ular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 ->
- 6180 bytes
- .../SourceHanSans-Regular.drop-hints.61,63,65,6B.otf | Bin 0 ->
- 5312 bytes
- ...ular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 ->
- 6248 bytes
- .../SourceHanSans-Regular.drop-hints.660E.otf | Bin 0 ->
- 5088 bytes
- test/subset/data/fonts/SourceHanSans-Regular.otf | Bin 0 ->
- 16427580 bytes
+ src/hb-subset-cff-common.cc | 16 +++++++++++++---
+ .../japanese/SourceHanSans-Regular.default..otf | Bin 0 -> 2340 bytes
+ ...Regular.default.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 6248 bytes
+ ...Regular.default.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 6432 bytes
+ .../SourceHanSans-Regular.default.61,63,65,6B.otf | Bin 0 -> 5428 bytes
+ ...Regular.default.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 6552 bytes
+ .../japanese/SourceHanSans-Regular.default.660E.otf | Bin 0 -> 5196 bytes
+ .../japanese/SourceHanSans-Regular.drop-hints..otf | Bin 0 -> 2188 bytes
+ ...ular.drop-hints.3042,3044,3046,3048,304A,304B.otf | Bin 0 -> 6076 bytes
+ ...ular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.otf | Bin 0 -> 6180 bytes
+ .../SourceHanSans-Regular.drop-hints.61,63,65,6B.otf | Bin 0 -> 5312 bytes
+ ...ular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.otf | Bin 0 -> 6248 bytes
+ .../SourceHanSans-Regular.drop-hints.660E.otf | Bin 0 -> 5088 bytes
+ test/subset/data/fonts/SourceHanSans-Regular.otf | Bin 0 -> 16427580 bytes
test/subset/data/tests/japanese.tests | 1 +
15 files changed, 14 insertions(+), 3 deletions(-)
@@ -21614,15 +22123,14 @@
Date: Wed Sep 19 16:46:41 2018 -0400
[morx] Implement forward/backward processing
-
+
We reverse too many times. Can be optimized. But I doubt many fonts
use reverse lookups, so doesn't matter.
-
+
Other than not applying user features, this completes morx table
implementation.
- src/hb-aat-layout-morx-table.hh | 40
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-morx-table.hh | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)
commit 3bccd62196b5dff70d446c3fe053b1b47bb9c19e
@@ -21639,7 +22147,7 @@
Date: Wed Sep 19 16:02:56 2018 -0400
[morx] Improve buffer position in Insertion w DontAdvance and wo
-
+
Just speculation. Needs tests to determine which is correct behavior.
src/hb-aat-layout-morx-table.hh | 23 ++++++++++++++++++-----
@@ -21650,7 +22158,7 @@
Date: Tue Sep 18 17:24:30 2018 -0700
fixed char widths & standard Encoding in subset CFF
-
+
also merged flush_n_args to flush_args into one
takes start index of the arguments on stack instead of count
@@ -21666,24 +22174,16 @@
Date: Tue Sep 18 15:53:37 2018 -0700
Added SourceSansPro-Regular along as CFF full-font test case
+
+ derived "expected" subset fonts from fonttools then manually tweaked further so they resemble hb-subset output
- derived "expected" subset fonts from fonttools then manually tweaked
- further so they resemble hb-subset output
-
- ...ourceSansPro-Regular.default.1FC,21,41,20,62,63.otf | Bin 0 ->
- 3640 bytes
- .../SourceSansPro-Regular.default.61,62,63.otf | Bin 0 ->
- 3400 bytes
- .../SourceSansPro-Regular.default.D7,D8,D9,DA,DE.otf | Bin 0 ->
- 3596 bytes
- ...ceSansPro-Regular.drop-hints.1FC,21,41,20,62,63.otf | Bin 0 ->
- 3480 bytes
- .../SourceSansPro-Regular.drop-hints.61,62,63.otf | Bin 0 ->
- 3276 bytes
- ...SourceSansPro-Regular.drop-hints.D7,D8,D9,DA,DE.otf | Bin 0 ->
- 3448 bytes
- test/subset/data/fonts/SourceSansPro-Regular.otf | Bin 0 ->
- 220852 bytes
+ ...ourceSansPro-Regular.default.1FC,21,41,20,62,63.otf | Bin 0 -> 3640 bytes
+ .../SourceSansPro-Regular.default.61,62,63.otf | Bin 0 -> 3400 bytes
+ .../SourceSansPro-Regular.default.D7,D8,D9,DA,DE.otf | Bin 0 -> 3596 bytes
+ ...ceSansPro-Regular.drop-hints.1FC,21,41,20,62,63.otf | Bin 0 -> 3480 bytes
+ .../SourceSansPro-Regular.drop-hints.61,62,63.otf | Bin 0 -> 3276 bytes
+ ...SourceSansPro-Regular.drop-hints.D7,D8,D9,DA,DE.otf | Bin 0 -> 3448 bytes
+ test/subset/data/fonts/SourceSansPro-Regular.otf | Bin 0 -> 220852 bytes
test/subset/data/tests/full-font.tests | 1 +
test/subset/run-tests.py | 4 ++--
test/subset/subset_test_suite.py | 5 +++++
@@ -21694,7 +22194,7 @@
Date: Mon Sep 17 15:34:39 2018 -0700
include curve control points in extents
-
+
this makes results consistent with FT
also optimized handling of path end points
@@ -21751,8 +22251,7 @@
[morx] Implement InsertionChain
- src/hb-aat-layout-morx-table.hh | 87
- ++++++++++++++++-------------------------
+ src/hb-aat-layout-morx-table.hh | 87 ++++++++++++++++-------------------------
1 file changed, 33 insertions(+), 54 deletions(-)
commit c0c85b852d37dad75eeef473e6dd3ec91a3b559b
@@ -21760,14 +22259,12 @@
Date: Mon Sep 17 11:14:56 2018 -0700
implemented get_glyph_extents with CFF1
-
- Implemented path operators in a new struct PathProc hooked up
- to CSOpSet
+
+ Implemented path operators in a new struct PathProc hooked up to CSOpSet
Added current point to CSInterpEnv
src/hb-cff-interp-common.hh | 86 ++++++++-
- src/hb-cff-interp-cs-common.hh | 425
- +++++++++++++++++++++++++++++++++++++++--
+ src/hb-cff-interp-cs-common.hh | 425 +++++++++++++++++++++++++++++++++++++++--
src/hb-cff1-interp-cs.hh | 18 +-
src/hb-cff2-interp-cs.hh | 10 +-
src/hb-null.hh | 2 +-
@@ -21794,10 +22291,9 @@
Date: Mon Sep 17 10:33:34 2018 +0200
Fix installation of cmake config when building with cmake (#1161)
-
+
When building with the auto tools, the manually mantained
- harfbuzz-config.cmake is installed. When building with cmake, we
- can use
+ harfbuzz-config.cmake is installed. When building with cmake, we can use
cmake to generate the correct config files for us and install them.
CMakeLists.txt | 5 +++++
@@ -21808,11 +22304,10 @@
Date: Sun Sep 16 19:33:48 2018 +0200
Revert forcing use of single-parameter static_assert()
-
- Some clang versions define static_assert as a macro apparently,
- so we cannot
+
+ Some clang versions define static_assert as a macro apparently, so we cannot
redefine it...
-
+
This reverts commit 94bfea0ce6a7b4d5641c198d50751748a353df11.
This reverts commit 4e62627831e7457ed60ff87712570065b14b200a.
@@ -21837,8 +22332,7 @@
src/hb-set-digest.hh | 4 ++--
src/hb-set.hh | 6 +++---
src/hb-uniscribe.cc | 2 +-
- src/hb.hh | 34
- +++++++++++++-----------------
+ src/hb.hh | 34 +++++++++++++-----------------
util/options.cc | 3 ++-
23 files changed, 58 insertions(+), 61 deletions(-)
@@ -21865,7 +22359,7 @@
Date: Sun Sep 16 18:11:46 2018 +0200
Fix bots
-
+
"Unused private member" warning turned error. ugh.
src/hb-aat-layout-morx-table.hh | 2 ++
@@ -21876,7 +22370,7 @@
Date: Sun Sep 16 18:09:36 2018 +0200
Enforce single-param static_assert() only
-
+
So we don't accidentally break it again.
src/hb-atomic.hh | 4 ++--
@@ -21900,8 +22394,7 @@
src/hb-set-digest.hh | 4 ++--
src/hb-set.hh | 6 +++---
src/hb-uniscribe.cc | 2 +-
- src/hb.hh | 34
- +++++++++++++++++-------------
+ src/hb.hh | 34 +++++++++++++++++-------------
22 files changed, 60 insertions(+), 56 deletions(-)
commit f1a86e1e6f3906f33fc89de694a4bbbc3e40d2bc
@@ -21927,19 +22420,15 @@
Date: Sat Sep 15 19:43:33 2018 +0200
Disallow null-enabled offsets to unsized structures...
-
+
...like UnsizedArrayOf<>.
-
- This fixes a class of crasher bugs, mostly with color and AAT tables.
- We
- cannot use nullable offsets to varsized data that does not declare
- min_size,
- because it's nost safe to use our fixed-size null pool for types
- that have
+
+ This fixes a class of crasher bugs, mostly with color and AAT tables. We
+ cannot use nullable offsets to varsized data that does not declare min_size,
+ because it's nost safe to use our fixed-size null pool for types that have
their size external. So, use non_null'able offsets for these.
-
- A further enhancement would be to make use of min_size in Null<>
- itself.
+
+ A further enhancement would be to make use of min_size in Null<> itself.
Will try that after.
src/hb-aat-layout-common.hh | 8 ++++----
@@ -21961,7 +22450,7 @@
Date: Sat Sep 15 18:31:14 2018 +0200
[morx] Respect default feature settings
-
+
Does NOT apply user-selected features. But at least now enables
correct subtables.
@@ -21983,8 +22472,7 @@
[morx] Add stub for InsertionChain
- src/hb-aat-layout-morx-table.hh | 209
- ++++++++++++++++++++++++++++++++++++++--
+ src/hb-aat-layout-morx-table.hh | 209 ++++++++++++++++++++++++++++++++++++++--
1 file changed, 200 insertions(+), 9 deletions(-)
commit f8ccb545c47abe8f0f4ed318ff7b5bf176913893
@@ -21992,9 +22480,8 @@
Date: Fri Sep 14 18:59:53 2018 +0200
[dfont] Disable null-processsing for offsets
-
- An offset to unsized arrayis not safe to be redirected to our
- fixed-sized
+
+ An offset to unsized arrayis not safe to be redirected to our fixed-sized
null pool. Plus, we want to reject, not repair, bad-looking dfonts.
src/hb-open-file.hh | 8 ++++----
@@ -22034,7 +22521,7 @@
Date: Fri Sep 14 11:31:33 2018 +0200
[aat] Add enums for pre-defined state and classes
-
+
Not sure how I didn't add before...
src/hb-aat-layout-common.hh | 19 ++++++++++++++++---
@@ -22061,7 +22548,7 @@
Date: Thu Sep 13 20:35:21 2018 +0200
[dfont] Also check dataLen range in sanitize
-
+
Just to disagree with myself re being done with this code...
src/hb-open-file.hh | 1 +
@@ -22072,22 +22559,16 @@
Date: Thu Sep 13 20:30:04 2018 +0200
[dfont] Solve the mystery +2 offset thing!
-
- Previously, ResourceForkHeader was defined as 30 bytes, having the
- typeCountM1 as last member.
- There was a mysterious offset-by-2 in the code, derived from FontTools
- and JDK code this was
+
+ Previously, ResourceForkHeader was defined as 30 bytes, having the typeCountM1 as last member.
+ There was a mysterious offset-by-2 in the code, derived from FontTools and JDK code this was
ported from.
-
- In testing, I observed that typeListZ offset is actually 28.
- Suggesting that the typeCountM1
- does NOT actually belong to ResourceForkHeader, but belongs to the
- array itself. Adjusting for
- that resolves the mystery +2 offset hack, so everything is clean
- and good now.
-
- This, concludes my dfont hacking. The code looks great now, and
- I'm happy to leave it.
+
+ In testing, I observed that typeListZ offset is actually 28. Suggesting that the typeCountM1
+ does NOT actually belong to ResourceForkHeader, but belongs to the array itself. Adjusting for
+ that resolves the mystery +2 offset hack, so everything is clean and good now.
+
+ This, concludes my dfont hacking. The code looks great now, and I'm happy to leave it.
Fuzzers might disagree though, we will see!
src/hb-open-file.hh | 30 ++++++++++++------------------
@@ -22099,7 +22580,7 @@
Date: Thu Sep 13 20:21:54 2018 +0200
Rename HeadlessArrayOf::len to lenP1
-
+
So it doesn't accidentally match our templates, etc.
src/hb-open-type.hh | 14 +++++++-------
@@ -22132,8 +22613,7 @@
[dfont] Push methods further down
- src/hb-open-file.hh | 58
- ++++++++++++++++++++++++++++++-----------------------
+ src/hb-open-file.hh | 58 ++++++++++++++++++++++++++++++-----------------------
1 file changed, 33 insertions(+), 25 deletions(-)
commit 8c9bdcc1feeab321a642bdaac50b716e48ce4263
@@ -22169,7 +22649,7 @@
Date: Thu Sep 13 18:47:53 2018 +0200
[dfont] Make test pass
-
+
Offset 0 is not null in this context.
src/hb-open-file.hh | 2 +-
@@ -22208,12 +22688,11 @@
Date: Thu Sep 13 16:49:26 2018 +0200
[dfont] Clean up sanitize()
-
+
I don't think I broke anything. Fuzzers will let me know..
src/hb-dsalgs.hh | 8 ++++
- src/hb-open-file.hh | 122
- ++++++++++++++++++++++++----------------------------
+ src/hb-open-file.hh | 122 ++++++++++++++++++++++++----------------------------
2 files changed, 64 insertions(+), 66 deletions(-)
commit 361fc2686152ad8c0ebaf19e0522e0fc58ba3953
@@ -22257,7 +22736,7 @@
Date: Wed Sep 12 17:23:08 2018 -0700
fixed hb_plan_subset_cff_fdselect
-
+
FDSelect3/4 sentinel size wasn't taken into account
src/hb-subset-cff-common.cc | 4 ++--
@@ -22271,8 +22750,7 @@
src/hb-ot-cff-common.hh | 6 ++++
src/hb-ot-cff1-table.hh | 6 ----
- src/hb-subset-cff-common.cc | 68
- ++++++++++++++++++++++++++-------------------
+ src/hb-subset-cff-common.cc | 68 ++++++++++++++++++++++++++-------------------
src/hb-subset-cff-common.hh | 10 +++----
src/hb-subset-cff1.cc | 12 ++++----
src/hb-subset-cff2.cc | 12 ++++----
@@ -22283,7 +22761,7 @@
Date: Wed Sep 12 13:22:19 2018 -0700
fixed bugs in Charset serialization
-
+
also some code cleanup
src/hb-ot-cff1-table.hh | 4 ++--
@@ -22295,7 +22773,7 @@
Date: Tue Sep 11 22:41:50 2018 -0700
fixed name mixup in Remap::reset
-
+
it was causing inconsistent Strings Index subset results
src/hb-ot-cff-common.hh | 4 ++--
@@ -22306,7 +22784,7 @@
Date: Tue Sep 11 16:47:55 2018 -0700
misc bug fixes
-
+
Added OpCode_FontMatrix to TopDictOpSet (yet to parse values)
fixed a wrong assert in encode_int
@@ -22340,8 +22818,7 @@
make parse_bcd locale free
- src/hb-cff-interp-dict-common.hh | 92
- +++++++++++++++++++++++++++++-----------
+ src/hb-cff-interp-dict-common.hh | 92 +++++++++++++++++++++++++++++-----------
1 file changed, 68 insertions(+), 24 deletions(-)
commit bb38d0f66388ec37ee9b0e81176d60c66fc17a19
@@ -22351,8 +22828,7 @@
Implement parse_bcd
src/hb-cff-interp-common.hh | 15 --------------
- src/hb-cff-interp-dict-common.hh | 44
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-cff-interp-dict-common.hh | 44 ++++++++++++++++++++++++++++++++++++++++
2 files changed, 44 insertions(+), 15 deletions(-)
commit 45e564a51917475ef6481825a6efb5b99bf1912e
@@ -22368,8 +22844,7 @@
[dfont] Some renaming, plus add link to reference doc
- src/hb-open-file.hh | 79
- ++++++++++++++++++++++++-----------------------------
+ src/hb-open-file.hh | 79 ++++++++++++++++++++++++-----------------------------
1 file changed, 35 insertions(+), 44 deletions(-)
commit 4134ec1307bbaff24972e238bc5e4a403cd3f1c1
@@ -22395,13 +22870,11 @@
Date: Tue Sep 11 17:18:21 2018 +0200
[dfont] Fix test expecatation and minor touch up
-
- I have no way to authoritatively know, but looks like test font only
- has one
+
+ I have no way to authoritatively know, but looks like test font only has one
face. So, adjust test expectation instead.
- src/hb-open-file.hh | 18
- ++++++------------
+ src/hb-open-file.hh | 18 ++++++------------
test/shaping/data/in-house/tests/collections.tests | 2 +-
2 files changed, 7 insertions(+), 13 deletions(-)
@@ -22422,7 +22895,7 @@
Date: Tue Sep 11 16:41:26 2018 +0200
[dfont] Re-enable and fix offset handling
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/1085
src/hb-face.cc | 5 +++--
@@ -22452,15 +22925,13 @@
Date: Tue Sep 11 14:35:26 2018 +0200
[ft] Cache advances
-
- I decided to always use the cache, instead of my previous sketch
- direction
- that was to only allocate and use cache if fast advances are not
- available.
+
+ I decided to always use the cache, instead of my previous sketch direction
+ that was to only allocate and use cache if fast advances are not available.
The cache is a mere 1kb, so just use it...
-
+
TODO: Invalidate cache on font size change.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/651
Fixes https://github.com/harfbuzz/harfbuzz/pull/1082
@@ -22473,9 +22944,9 @@
Date: Tue Sep 11 14:21:15 2018 +0200
[util] Add --ft-load-flags
-
+
Useful for performance testing.
-
+
Not hooked to cairo yet. Just changes shaping, not rasterization.
util/helper-cairo.cc | 2 +-
@@ -22488,7 +22959,7 @@
Date: Tue Sep 11 14:11:10 2018 +0200
[util] Add -n shorthand for --num-iterations
-
+
Meh.
util/options.cc | 2 +-
@@ -22499,7 +22970,7 @@
Date: Tue Sep 11 14:05:16 2018 +0200
[ft] Towards caching slow get_h_advance results
-
+
Related to https://github.com/harfbuzz/harfbuzz/pull/1082
src/hb-ft.cc | 24 ++++++++++++++++++++----
@@ -22520,8 +22991,7 @@
[ot-font] Rename
- src/hb-ot-font.cc | 74
- +++++++++++++++++++++++++++----------------------------
+ src/hb-ot-font.cc | 74 +++++++++++++++++++++++++++----------------------------
1 file changed, 37 insertions(+), 37 deletions(-)
commit d8a67dac2a673138bb4d41cd7eab97c9ee987958
@@ -22547,14 +23017,13 @@
Date: Tue Sep 11 12:02:34 2018 +0200
Revert "Remove unused hb_cache_t"
-
+
This reverts commit 473b17af4d421f4ce7ac18c769731bb2aa4088f8.
-
+
Updates to recent changes.
src/Makefile.sources | 1 +
- src/hb-cache.hh | 75
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-cache.hh | 75 ++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ft.cc | 1 +
3 files changed, 77 insertions(+)
@@ -22583,9 +23052,9 @@
Date: Mon Sep 10 22:37:19 2018 +0200
Make --features rand=1 available to the user
-
+
Use rand=255 to mean "randomize".
-
+
Part of https://github.com/harfbuzz/harfbuzz/pull/803
src/hb-ot-layout-gsub-table.hh | 11 ++++-------
@@ -22600,7 +23069,7 @@
Date: Mon Sep 10 16:36:05 2018 +0200
Respect user's wish if they set rand feature manually
-
+
Except if the set it to 1, which would mean "randomize"... Ugly.
src/hb-ot-layout-gsub-table.hh | 30 ++++++++++++++++--------------
@@ -22636,8 +23105,7 @@
Test 'rand'
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/5bb74492f5e0ffa1fbb72e4c881be035120b6513.ttf | Bin 0 ->
- 1352 bytes
+ .../fonts/5bb74492f5e0ffa1fbb72e4c881be035120b6513.ttf | Bin 0 -> 1352 bytes
test/shaping/data/in-house/tests/rand.tests | 3 +++
3 files changed, 4 insertions(+)
@@ -22646,9 +23114,8 @@
Date: Fri Jan 26 21:36:15 2018 -0500
Allow requesting a specific glyph for 'rand'
-
- Randomization only happens by default. If the user specifies a
- value for
+
+ Randomization only happens by default. If the user specifies a value for
'rand', that value is respected.
src/hb-ot-map.cc | 3 ++-
@@ -22676,8 +23143,7 @@
fix build attempt
- src/hb-ot-cff1-table.hh | 70
- ++++++++++++++++++++++++-------------------------
+ src/hb-ot-cff1-table.hh | 70 ++++++++++++++++++++++++-------------------------
src/hb-subset-cff1.cc | 16 +++++------
2 files changed, 43 insertions(+), 43 deletions(-)
@@ -22696,12 +23162,9 @@
Removed unused subr subset code
- src/hb-subset-cff-common.hh | 98
- ++-------------------------------------------
- src/hb-subset-cff1.cc | 92
- +++++-------------------------------------
- src/hb-subset-cff2.cc | 90
- ++++-------------------------------------
+ src/hb-subset-cff-common.hh | 98 ++-------------------------------------------
+ src/hb-subset-cff1.cc | 92 +++++-------------------------------------
+ src/hb-subset-cff2.cc | 90 ++++-------------------------------------
3 files changed, 22 insertions(+), 258 deletions(-)
commit becd84aa2f2902ea9d2d1677b28945e103a68816
@@ -22709,9 +23172,9 @@
Date: Tue Sep 11 01:26:18 2018 +0200
Add HB_FEATURE_GLOBAL_START/END
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1141
-
+
New API:
HB_FEATURE_GLOBAL_START
HB_FEATURE_GLOBAL_END
@@ -22767,7 +23230,7 @@
Date: Mon Sep 10 16:00:20 2018 -0700
subset CFF1 String Index
-
+
Repurposed FDMap as Remap then subclassed for remapping SIDs
misc code cleanup
@@ -22778,8 +23241,7 @@
src/hb-ot-cff2-table.hh | 12 +-
src/hb-subset-cff-common.cc | 24 +--
src/hb-subset-cff-common.hh | 20 ++-
- src/hb-subset-cff1.cc | 334
- ++++++++++++++++++++++++++++++++-------
+ src/hb-subset-cff1.cc | 334 ++++++++++++++++++++++++++++++++-------
src/hb-subset-cff2.cc | 8 +-
9 files changed, 565 insertions(+), 194 deletions(-)
@@ -22788,7 +23250,7 @@
Date: Mon Sep 10 23:18:07 2018 +0200
Simplify sanitize->check_array()
-
+
Fix a bug in CBDT sanitize, and redundant check in avar.
src/hb-aat-layout-common.hh | 10 ++++------
@@ -22813,11 +23275,10 @@
Date: Mon Sep 10 23:02:24 2018 +0200
Port some VAR arrays to UnsizedArrayOf<>
-
+
Fix avar sanitize().
- src/hb-ot-layout-gsubgpos.hh | 59
- +++++++++++++++++++++++---------------------
+ src/hb-ot-layout-gsubgpos.hh | 59 +++++++++++++++++++++++---------------------
src/hb-ot-var-avar-table.hh | 10 +++++---
src/hb-ot-var-fvar-table.hh | 7 +++---
src/hb-ot-var-hvar-table.hh | 9 ++++---
@@ -22838,7 +23299,7 @@
Date: Mon Sep 10 18:19:37 2018 +0200
Unbreak HB_OPTIONS
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1154
src/hb-debug.hh | 3 +++
@@ -22849,29 +23310,27 @@
Date: Mon Sep 10 17:38:19 2018 +0200
[indic] Do NOT allow matra after Halant,ZWJ
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/556
-
+
Devanagari regresses 12 tests, and Gujarati 2. See:
-
+
https://github.com/harfbuzz/harfbuzz/issues/556#issuecomment-419957472
-
+
New numbers:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707299 out of 707394 tests passed. 95 failed (0.0134296%)
GUJARATI: 366353 out of 366457 tests passed. 104 failed (0.0283799%)
GURMUKHI: 60729 out of 60747 tests passed. 18 failed (0.0296311%)
KANNADA: 951300 out of 951913 tests passed. 613 failed (0.0643966%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42327 out of 42329 tests passed. 2 failed (0.00472489%)
SINHALA: 271596 out of 271847 tests passed. 251 failed (0.0923313%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
- src/hb-ot-shape-complex-indic-machine.hh | 1688
- ++++++++++++++----------------
+ src/hb-ot-shape-complex-indic-machine.hh | 1688 ++++++++++++++----------------
src/hb-ot-shape-complex-indic-machine.rl | 2 +-
2 files changed, 784 insertions(+), 906 deletions(-)
@@ -22880,7 +23339,7 @@
Date: Mon Sep 10 15:45:32 2018 +0200
Fix sanitize or Context Rule
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1110
src/hb-ot-layout-gsubgpos.hh | 2 +-
@@ -22891,7 +23350,7 @@
Date: Mon Sep 10 13:56:28 2018 +0200
Revert "[subset] Disable GSUB/GPOS subsetting for now"
-
+
This reverts commit 616fd34a69bb69bc35c7e4ea939e71c3ea2e92cb.
src/hb-subset.cc | 4 ++--
@@ -22915,7 +23374,7 @@
Date: Mon Sep 10 11:19:49 2018 +0200
[subset] Disable GSUB/GPOS subsetting for now
-
+
So I can get a release out. I haven't debugged those yet, and they
are producing bad tables.
@@ -22927,7 +23386,7 @@
Date: Mon Sep 10 11:05:33 2018 +0200
[atomic] Fix pointer type passed to InterlockedExchangeAdd()
-
+
John Emmas reported on mailing list that build with MSVC is failing.
Not sure why bots don't catch it, but this should fix.
@@ -22939,24 +23398,19 @@
Date: Fri Sep 7 15:02:57 2018 -0400
Use enum instead of "static const" in class scope
-
+
Technically, static const needs an out-of-class definition. Eg:
-
+
CXXLD libharfbuzz-subset.la
Undefined symbols for architecture x86_64:
"OT::FeatureVariationRecord::min_size", referenced from:
- bool OT::GSUBGPOS::subset<OT::PosLookup>(hb_subset_context_t*)
- constin libharfbuzz_subset_la-hb-subset.o
- bool OT::GSUBGPOS::subset<OT::SubstLookup>(hb_subset_context_t*)
- constin libharfbuzz_subset_la-hb-subset.o
+ bool OT::GSUBGPOS::subset<OT::PosLookup>(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
+ bool OT::GSUBGPOS::subset<OT::SubstLookup>(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
"OT::Record<OT::LangSys>::min_size", referenced from:
- OT::Script::subset(hb_subset_context_t*) constin
- libharfbuzz_subset_la-hb-subset.o
+ OT::Script::subset(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
"OT::IntType<unsigned short, 2u>::min_size", referenced from:
- OT::Script::subset(hb_subset_context_t*) constin
- libharfbuzz_subset_la-hb-subset.o
- OT::RecordListOf<OT::Feature>::subset(hb_subset_context_t*)
- const in libharfbuzz_subset_la-hb-subset.o
+ OT::Script::subset(hb_subset_context_t*) constin libharfbuzz_subset_la-hb-subset.o
+ OT::RecordListOf<OT::Feature>::subset(hb_subset_context_t*) const in libharfbuzz_subset_la-hb-subset.o
ld: symbol(s) not found for architecture x86_64
collect2: ld returned 1 exit status
make[4]: *** [libharfbuzz-subset.la] Error 1
@@ -23013,7 +23467,7 @@
Date: Thu Sep 6 18:26:13 2018 -0700
fix build attempt ^2
-
+
Added hb-ot-cff1-table.cc to hb-subset sources
Deleted unused variable (charset)
@@ -23026,7 +23480,7 @@
Date: Thu Sep 6 17:56:05 2018 -0700
fix build attempt
-
+
Added HB_INTERNAL to static funtion declarations
src/hb-ot-cff1-table.hh | 8 ++++----
@@ -23037,7 +23491,7 @@
Date: Thu Sep 6 17:28:15 2018 -0700
subset CFF1 Encoding & Charset
-
+
fixed misc Charset bugs
added source file hb-ot-cff1.table.cc
renamed things for clarity & consistency
@@ -23046,8 +23500,7 @@
src/hb-cff-interp-dict-common.hh | 15 +-
src/hb-ot-cff-common.hh | 34 ++--
src/hb-ot-cff1-table.cc | 130 +++++++++++++
- src/hb-ot-cff1-table.hh | 403
- ++++++++++++++++++++++++++++++++-------
+ src/hb-ot-cff1-table.hh | 403 ++++++++++++++++++++++++++++++++-------
src/hb-ot-cff2-table.hh | 24 +--
src/hb-subset-cff1.cc | 247 ++++++++++++++++++++----
src/hb-subset-cff2.cc | 30 +--
@@ -23062,8 +23515,7 @@
src/hb-ot-hdmx-table.hh | 14 ++++++++++----
test/api/fonts/Roboto-Regular.multihdmx.a.ttf | Bin 0 -> 2052 bytes
test/api/fonts/Roboto-Regular.multihdmx.abc.ttf | Bin 0 -> 2468 bytes
- test/api/test-subset-hdmx.c | 20
- ++++++++++++++++++++
+ test/api/test-subset-hdmx.c | 20 ++++++++++++++++++++
4 files changed, 30 insertions(+), 4 deletions(-)
commit 1e6599f59680c81356b2e9ddddb61252490337a0
@@ -23081,12 +23533,11 @@
Date: Wed Sep 5 16:24:28 2018 -0700
[subset] Hook up GSUB/GPOS, but still disabled
-
+
They are still in the drop list.
src/hb-ot-hdmx-table.hh | 3 +-
- src/hb-subset.cc | 75
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset.cc | 75 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 77 insertions(+), 1 deletion(-)
commit 0d160d5ff5158fd4190201becd652c8f28ef4430
@@ -23097,8 +23548,7 @@
src/hb-machinery.hh | 2 ++
src/hb-null.hh | 43 +++++++++++++++++++-----------
- src/hb-ot-layout-gsub-table.hh | 59
- +++++++++++++++++++++++++++++++++++-------
+ src/hb-ot-layout-gsub-table.hh | 59 +++++++++++++++++++++++++++++++++++-------
src/hb-vector.hh | 2 ++
4 files changed, 81 insertions(+), 25 deletions(-)
@@ -23107,7 +23557,7 @@
Date: Tue Sep 4 11:29:15 2018 -0700
fix build by untemplatizing DictOpSet & DictVal
-
+
as they aren't instantiated with BlendArg (yet)
src/hb-cff-interp-dict-common.hh | 21 +++++++++------------
@@ -23122,16 +23572,13 @@
Date: Tue Sep 4 10:25:21 2018 -0700
Drop hints from CFF2 charstrings
-
- Templatized ArgStack so it may store the default value along with
- blend deltas as BlendArg while parsing blend operator arguments in
- CFF2 charstring
+
+ Templatized ArgStack so it may store the default value along with blend deltas as BlendArg while parsing blend operator arguments in CFF2 charstring
Added get_region_count() method to VarRegionList & VariationStore
src/hb-cff-interp-common.hh | 67 +++++++++++++++++++++++++++------
src/hb-cff1-interp-cs.hh | 5 ++-
- src/hb-cff2-interp-cs.hh | 91
- +++++++++++++++++++++++++++++++++++++++------
+ src/hb-cff2-interp-cs.hh | 91 +++++++++++++++++++++++++++++++++++++++------
src/hb-ot-cff2-table.hh | 22 ++++++-----
src/hb-ot-layout-common.hh | 6 +++
src/hb-subset-cff-common.hh | 60 ++++++++++++++++--------------
@@ -23144,7 +23591,7 @@
Date: Mon Sep 3 18:54:32 2018 -0700
[subset] Keep glyph set in plan
-
+
Should remove the vector version at some point...
src/hb-subset-plan.cc | 19 ++++++++++---------
@@ -23156,7 +23603,7 @@
Date: Mon Sep 3 18:23:23 2018 -0700
[subset] Towards subsetting SingleSubstFormat1
-
+
Why does subset plan not have a hb_set_t of glyphs?
src/hb-machinery.hh | 10 +++++++++-
@@ -23170,8 +23617,7 @@
[subset] Wire up subset() call down to subtables
src/hb-ot-layout-common.hh | 36 +++++++++++++++++++++++
- src/hb-ot-layout-gpos-table.hh | 67
- +++++++++++++++++++++++++++++++++++++++---
+ src/hb-ot-layout-gpos-table.hh | 67 +++++++++++++++++++++++++++++++++++++++---
src/hb-ot-layout-gsub-table.hh | 54 ++++++++++++++++++++++++++++------
src/hb-ot-layout-gsubgpos.hh | 42 ++++++++++++++++++++++++++
4 files changed, 186 insertions(+), 13 deletions(-)
@@ -23182,8 +23628,7 @@
Templatize Lookup::sanitize()
- src/hb-ot-layout-common.hh | 40
- ++++++++++++++++++++++++++++------------
+ src/hb-ot-layout-common.hh | 40 ++++++++++++++++++++++++++++------------
src/hb-ot-layout-gpos-table.hh | 7 ++-----
src/hb-ot-layout-gsub-table.hh | 25 +++----------------------
3 files changed, 33 insertions(+), 39 deletions(-)
@@ -23195,8 +23640,7 @@
[subset] More
src/hb-ot-layout-gpos-table.hh | 10 +++++----
- src/hb-ot-layout-gsub-table.hh | 48
- +++++++++++++++++++++---------------------
+ src/hb-ot-layout-gsub-table.hh | 48 +++++++++++++++++++++---------------------
src/hb-ot-layout-gsubgpos.hh | 22 +++++++++++++------
3 files changed, 45 insertions(+), 35 deletions(-)
@@ -23216,7 +23660,7 @@
Date: Mon Sep 3 16:37:17 2018 -0700
[subset] Fix serialize_subset() calls
-
+
Ouch.
src/hb-open-type.hh | 2 +-
@@ -23234,8 +23678,7 @@
src/hb-ot-layout-common.hh | 77 +++++++++--
src/hb-ot-layout-gpos-table.hh | 103 ++++++++++----
src/hb-ot-layout-gsub-table.hh | 205 +++++++++++++++++++--------
- src/hb-ot-layout-gsubgpos.hh | 306
- ++++++++++++++++++++++++++++++++---------
+ src/hb-ot-layout-gsubgpos.hh | 306 ++++++++++++++++++++++++++++++++---------
4 files changed, 528 insertions(+), 163 deletions(-)
commit 61ce62e55455bb0d6c9db3b076676ab18e51d449
@@ -23243,7 +23686,7 @@
Date: Sun Sep 2 17:00:27 2018 -0700
[subset] Minor
-
+
Remove Lookup::subset().
src/hb-ot-layout-common.hh | 11 -----------
@@ -23255,14 +23698,13 @@
Date: Sat Sep 1 18:34:50 2018 -0700
[subset] Towards GSUB/GPOS subsetting
-
+
Add subset() call for GSUBGPOS struct and its dependencies.
Not hooked up anywhere.
src/hb-machinery.hh | 10 ++++--
src/hb-open-type.hh | 25 ++++++++++++-
- src/hb-ot-layout-common.hh | 80
- +++++++++++++++++++++++++++++++++++-------
+ src/hb-ot-layout-common.hh | 80 +++++++++++++++++++++++++++++++++++-------
src/hb-ot-layout-gdef-table.hh | 33 ++++++++++-------
src/hb-ot-layout-gsub-table.hh | 11 ++++--
src/hb-ot-layout-gsubgpos.hh | 19 ++++++++++
@@ -23282,9 +23724,8 @@
Date: Fri Aug 31 16:46:35 2018 -0700
[subset] De-templatize hb_subset_context_t
-
- We're going to (finally) use virtual methods for
- hb_serialize_context_t
+
+ We're going to (finally) use virtual methods for hb_serialize_context_t
customization, so don't need to carry a Serializer template variable
around... Simplifies code.
@@ -23327,15 +23768,13 @@
templatized ArgStack as a prep to store blends
- src/hb-cff-interp-common.hh | 46
- +++++++++++++++++++++---------------
+ src/hb-cff-interp-common.hh | 46 +++++++++++++++++++++---------------
src/hb-cff-interp-cs-common.hh | 41 ++++++++++++++++++--------------
src/hb-cff-interp-dict-common.hh | 35 ++++++++++++++++-----------
src/hb-cff1-interp-cs.hh | 15 +++++++-----
src/hb-cff2-interp-cs.hh | 14 +++++++----
src/hb-ot-cff1-table.hh | 32 ++++++++++++-------------
- src/hb-ot-cff2-table.hh | 51
- ++++++++++++++++++++++++++--------------
+ src/hb-ot-cff2-table.hh | 51 ++++++++++++++++++++++++++--------------
src/hb-subset-cff-common.hh | 4 ++--
src/hb-subset-cff1.cc | 1 -
src/hb-subset-cff2.cc | 2 +-
@@ -23346,12 +23785,11 @@
Date: Fri Aug 31 13:28:16 2018 -0700
drop hints from CFF1 charstrings
-
+
renamed confusing Stack.size to Stack.count
src/hb-cff-interp-common.hh | 43 +++++++-----
- src/hb-cff-interp-cs-common.hh | 140
- +++++++++++++++++----------------------
+ src/hb-cff-interp-cs-common.hh | 140 +++++++++++++++++----------------------
src/hb-cff-interp-dict-common.hh | 4 +-
src/hb-cff1-interp-cs.hh | 14 ++--
src/hb-cff2-interp-cs.hh | 18 ++---
@@ -23377,8 +23815,7 @@
src/hb-ot-post-table.hh | 2 +-
src/hb-subset-glyf.cc | 1 -
src/hb-subset-glyf.hh | 2 +-
- src/hb-subset-input.hh | 57
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset-input.hh | 57 +++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset-plan.cc | 3 +--
src/hb-subset-plan.hh | 2 +-
src/hb-subset.cc | 3 +--
@@ -23403,8 +23840,7 @@
src/hb-cff-interp-cs-common.hh | 20 +++++++++++++++++++-
src/hb-subset-cff-common.hh | 18 ++++++++++++++----
src/hb-subset-cff1.cc | 35 ++++++++++++++++++++++------------
- src/hb-subset-cff2.cc | 43
- ++++++++++++++++++++++++++----------------
+ src/hb-subset-cff2.cc | 43 ++++++++++++++++++++++++++----------------
4 files changed, 83 insertions(+), 33 deletions(-)
commit a23b892fe6cc4859a30edc7ffc003ab7624aa5f0
@@ -23413,8 +23849,7 @@
Shuffle
- src/hb-machinery.hh | 62
- +++++++++++++++++++++++++++--------------------------
+ src/hb-machinery.hh | 62 +++++++++++++++++++++++++++--------------------------
1 file changed, 32 insertions(+), 30 deletions(-)
commit 93fe0faaee45b8fb646f7aa33620105c62193885
@@ -23423,8 +23858,7 @@
[subset] Clean up hb_subset_input_t API
- src/hb-subset-input.cc | 44
- +++++++++++++++++++---------------------
+ src/hb-subset-input.cc | 44 +++++++++++++++++++---------------------
src/hb-subset-plan.cc | 4 ++--
src/hb-subset-plan.hh | 10 ++++-----
src/hb-subset.cc | 2 +-
@@ -23440,15 +23874,13 @@
Date: Wed Aug 29 18:18:18 2018 -0700
CFF2 subroutine flattner
+
+ Factored out CFF1 & CFF2 common subsetting code in hb-subset-cff-common.hh
- Factored out CFF1 & CFF2 common subsetting code in
- hb-subset-cff-common.hh
-
src/hb-cff2-interp-cs.hh | 34 +++++--
src/hb-subset-cff-common.hh | 154 +++++++++++++++++++++++++++++
src/hb-subset-cff1.cc | 135 +++-----------------------
- src/hb-subset-cff2.cc | 229
- ++++++++++++++++++--------------------------
+ src/hb-subset-cff2.cc | 229 ++++++++++++++++++--------------------------
4 files changed, 285 insertions(+), 267 deletions(-)
commit d237ce71810045ee400c52740cd8ab6e1113aada
@@ -23465,7 +23897,7 @@
Date: Wed Aug 29 18:09:55 2018 -0700
[subset] Remove unused hb_subset_profile_t
-
+
We might reintroduce it later, but for now remove, as it was unused.
Some things that should have been in this object (drop_hints, etc)
are already in hb_subset_input_t. So, for now, keep everything there.
@@ -23472,8 +23904,7 @@
src/hb-subset-plan.cc | 3 +--
src/hb-subset-plan.hh | 1 -
- src/hb-subset.cc | 39
- +++------------------------------------
+ src/hb-subset.cc | 39 +++------------------------------------
src/hb-subset.h | 16 +---------------
test/api/hb-subset-test.h | 4 +---
test/api/test-subset-hdmx.c | 8 ++------
@@ -23488,7 +23919,7 @@
Date: Wed Aug 29 16:38:04 2018 -0700
[ot-font] Clean up cmap with gid=0
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1145
src/hb-ot-cmap-table.hh | 25 +++++++++++++++----------
@@ -23499,13 +23930,10 @@
Date: Wed Aug 29 22:37:39 2018 +0100
Delete pkg.m4
+
+ pkg.m4 is provided by pkg-config, which is a requirement to build, and this copy is ancient. Delete it to avoid it being used instead of the host copy.
- pkg.m4 is provided by pkg-config, which is a requirement to build,
- and this copy is ancient. Delete it to avoid it being used instead
- of the host copy.
-
- m4/pkg.m4 | 157
- --------------------------------------------------------------
+ m4/pkg.m4 | 157 --------------------------------------------------------------
1 file changed, 157 deletions(-)
commit b95bf075d7b62baf7d6fa1d8f0d1f16fad934975
@@ -23536,7 +23964,7 @@
Date: Wed Aug 29 13:26:17 2018 -0700
Merge branch 'master' into cff-subset
-
+
Renamed cff "private" source/headers without the suffix
commit 0ad081ec324e734cfca60d4d2c36a1be5bc8a067
@@ -23553,16 +23981,13 @@
Date: Wed Aug 29 12:14:30 2018 -0700
Subroutine flattener for CFF1
-
- Subr-flattened charstrings are temporarily re-encoded in ByteStrBuff
- during "plan" phase, then copied to hb_serialize_context_t during
- "write" phase
-
+
+ Subr-flattened charstrings are temporarily re-encoded in ByteStrBuff during "plan" phase, then copied to hb_serialize_context_t during "write" phase
+
CSOpSet may callback opcode processing "virtual" functions via CRTP
+
+ Numer struct may store a value as fixed optionally in addition to int and float
- Numer struct may store a value as fixed optionally in addition to
- int and float
-
src/hb-cff-interp-common-private.hh | 53 ++++++++++--
src/hb-cff-interp-cs-common-private.hh | 109 ++++++++++++++++++-----
src/hb-cff1-interp-cs.hh | 35 +++++---
@@ -23569,8 +23994,7 @@
src/hb-cff2-interp-cs.hh | 14 +--
src/hb-ot-cff-common-private.hh | 10 +--
src/hb-subset-cff-common-private.hh | 102 +++++++++++++++++++++-
- src/hb-subset-cff1.cc | 152
- ++++++++++++++++++++++-----------
+ src/hb-subset-cff1.cc | 152 ++++++++++++++++++++++-----------
src/hb-subset-cff2.cc | 7 +-
8 files changed, 372 insertions(+), 110 deletions(-)
@@ -23579,7 +24003,7 @@
Date: Tue Aug 28 18:27:41 2018 -0700
Don't declare extern symbols as inline
-
+
clang -O3 was completely removing _get_gdef(), causing link
failure when needed from another compilation unit. Surprisingly,
"extern inline" didn't fix it.
@@ -23610,7 +24034,7 @@
Date: Tue Aug 28 11:02:00 2018 -0700
Explicitly pass reference in hb_auto_t constructor
-
+
Fixes clang bots as well as fuzzer issue.
src/hb-dsalgs.hh | 9 ++++++++-
@@ -23637,7 +24061,7 @@
Date: Sun Aug 26 15:11:24 2018 -0700
Free up hb-ot-face.hh from includes
-
+
There might be a better way to do this, but I couldn't find...
src/hb-face.cc | 1 +
@@ -23693,8 +24117,7 @@
[GDEF] Move code around
src/hb-ot-layout-gdef-table.hh | 118 +-----------------------------------
- src/hb-ot-layout.cc | 134
- ++++++++++++++++++++++++++++++++++++++---
+ src/hb-ot-layout.cc | 134 ++++++++++++++++++++++++++++++++++++++---
src/hb-ot-layout.hh | 14 +----
3 files changed, 128 insertions(+), 138 deletions(-)
@@ -23703,7 +24126,7 @@
Date: Sun Aug 26 01:30:52 2018 -0700
Add template keyword
-
+
I swear I have no idea why this is needed, but it is...
src/hb-ot-layout-gsubgpos.hh | 2 +-
@@ -23726,8 +24149,7 @@
src/hb-ot-face.cc | 108 ----------------------------------
src/hb-ot-face.hh | 2 +-
- src/hb-ot-layout-gdef-table.hh | 129
- +++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout-gdef-table.hh | 129 +++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout.cc | 14 ++++-
src/hb-ot-layout.hh | 5 +-
5 files changed, 147 insertions(+), 111 deletions(-)
@@ -23736,12 +24158,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Sun Aug 26 01:15:47 2018 -0700
- [ot-face] Unify GSUB/GPOS accelerators in the table accelerator
- framework
+ [ot-face] Unify GSUB/GPOS accelerators in the table accelerator framework
src/hb-aat-layout.cc | 4 +---
- src/hb-ot-face.cc | 40
- ++--------------------------------------
+ src/hb-ot-face.cc | 40 ++--------------------------------------
src/hb-ot-face.hh | 25 +++++++++++--------------
src/hb-ot-layout-gpos-table.hh | 2 +-
src/hb-ot-layout-gsub-table.hh | 6 +++---
@@ -23774,8 +24194,7 @@
src/hb-machinery.hh | 4 ++--
src/hb-ot-cmap-table.hh | 3 ++-
src/hb-ot-face.cc | 6 +++--
- src/hb-ot-face.hh | 58
- +++++++++++++------------------------------------
+ src/hb-ot-face.hh | 58 +++++++++++++------------------------------------
src/hb-ot-font.cc | 6 ++---
5 files changed, 26 insertions(+), 51 deletions(-)
@@ -23807,8 +24226,7 @@
src/hb-ot-cmap-table.hh | 1 +
src/hb-ot-face.cc | 2 ++
src/hb-ot-face.hh | 55 +++++++++++++++++++++++++++-----
- src/hb-ot-font.cc | 75
- ++++----------------------------------------
+ src/hb-ot-font.cc | 75 ++++----------------------------------------
src/hb-ot-layout-gsubgpos.hh | 1 +
src/hb-ot-layout.hh | 1 -
6 files changed, 58 insertions(+), 77 deletions(-)
@@ -23829,8 +24247,7 @@
[ot-font] Make everything (cmap/metrics) lazy
src/hb-machinery.hh | 5 +++++
- src/hb-ot-font.cc | 51
- ++++++++++++++++++++++++++-------------------------
+ src/hb-ot-font.cc | 51 ++++++++++++++++++++++++++-------------------------
2 files changed, 31 insertions(+), 25 deletions(-)
commit 62fc54725a3863473829f3a3748c9336e4dc0787
@@ -23838,7 +24255,7 @@
Date: Sat Aug 25 23:15:52 2018 -0700
[ot-font] Fallback vertical advance to UPEM
-
+
Used to be ascent+descent. Whatever. This is more convenient for
upcoming changes.
@@ -23853,8 +24270,7 @@
Add hb-ot-face.cc/hh
src/Makefile.sources | 2 +
- src/hb-ot-face.cc | 206
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-face.cc | 206 +++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-face.hh | 144 +++++++++++++++++++++++++++++++++++
src/hb-ot-layout.cc | 172 ------------------------------------------
src/hb-ot-layout.hh | 108 +--------------------------
@@ -23867,7 +24283,7 @@
Date: Sat Aug 25 22:44:39 2018 -0700
[face] Introduce character-map API
-
+
New API:
+hb_face_collect_unicodes
+hb_face_collect_variation_selectors
@@ -23874,11 +24290,9 @@
+hb_face_collect_variation_unicodes
docs/harfbuzz-sections.txt | 3 ++
- src/hb-face.cc | 61
- ++++++++++++++++++++++++-
+ src/hb-face.cc | 61 ++++++++++++++++++++++++-
src/hb-face.h | 19 ++++++++
- src/hb-subset.cc | 53
- ---------------------
+ src/hb-subset.cc | 53 ---------------------
src/hb-subset.h | 15 ------
test/api/test-subset-codepoints.c | 6 +--
test/fuzzing/hb-subset-get-codepoints-fuzzer.cc | 2 +-
@@ -23898,11 +24312,10 @@
Date: Sat Aug 25 22:36:36 2018 -0700
Rename hb-*private.hh to hb-*.hh
-
+
Sorry for the noise, downstream custom builders. Please adjust.
- src/Makefile.sources | 75
- +++++++++++-----------
+ src/Makefile.sources | 75 +++++++++++-----------
src/check-includes.sh | 8 +--
src/dump-indic-data.cc | 2 +-
src/dump-khmer-data.cc | 2 +-
@@ -24077,7 +24490,7 @@
Date: Sat Aug 25 22:07:17 2018 -0700
[unicode] Add HB_UNICODE_MAX
-
+
New API:
HB_UNICODE_MAX
@@ -24110,8 +24523,7 @@
Use new hb_auto_t<> constructor with Coverage::Iter
- src/hb-ot-layout-common-private.hh | 65
- ++++++++++++++++++++++++--------------
+ src/hb-ot-layout-common-private.hh | 65 ++++++++++++++++++++++++--------------
src/hb-ot-layout-gsub-table.hh | 30 ++++++------------
2 files changed, 52 insertions(+), 43 deletions(-)
@@ -24120,7 +24532,7 @@
Date: Sat Aug 25 21:08:15 2018 -0700
Add 1-param passthrough constructor to hb_auto_t<>
-
+
And use.
src/hb-dsalgs.hh | 1 +
@@ -24141,11 +24553,10 @@
Date: Sat Aug 25 16:11:26 2018 -0700
[cmap Add hb_subset_collect_variation_unicodes()
-
+
To be moved to hb-face.h later.
- src/hb-ot-cmap-table.hh | 59
- +++++++++++++++++++++++++++++++++++++++++--------
+ src/hb-ot-cmap-table.hh | 59 +++++++++++++++++++++++++++++++++++++++++--------
src/hb-subset.cc | 25 ++++++++++++++++++++-
src/hb-subset.h | 10 +++++++--
3 files changed, 82 insertions(+), 12 deletions(-)
@@ -24155,7 +24566,7 @@
Date: Sat Aug 25 15:56:07 2018 -0700
[cmap] Add hb_subset_collect_variation_selectors()
-
+
To be moved to hb-face later.
src/hb-ot-cmap-table.hh | 20 ++++++++++++++++----
@@ -24188,8 +24599,7 @@
[cmap] Factor out find_best_subtable
- src/hb-ot-cmap-table.hh | 52
- +++++++++++++++++++++++++++++--------------------
+ src/hb-ot-cmap-table.hh | 52 +++++++++++++++++++++++++++++--------------------
1 file changed, 31 insertions(+), 21 deletions(-)
commit b41c43b4e112bfa38fef35694842f242c28a7da2
@@ -24198,8 +24608,7 @@
Minor
- src/hb-ot-cmap-table.hh | 48
- ++++++++++++++++++++++++++----------------------
+ src/hb-ot-cmap-table.hh | 48 ++++++++++++++++++++++++++----------------------
1 file changed, 26 insertions(+), 22 deletions(-)
commit 7d382fa276f44b7b163e98d434cc79f958bf87fb
@@ -24216,11 +24625,10 @@
Date: Sat Aug 25 09:33:30 2018 -0700
[cmap] Simplify collect_unicodes()
-
+
Don't use accelerator (almost). Hooks up Format13 as well.
- src/hb-ot-cmap-table.hh | 52
- +++++++++++++++++++++++++++----------------------
+ src/hb-ot-cmap-table.hh | 52 +++++++++++++++++++++++++++----------------------
1 file changed, 29 insertions(+), 23 deletions(-)
commit d60c465627d76fcfbeb37d6b8f9382f3b84ace6e
@@ -24229,8 +24637,7 @@
Rename get_all_codepoints() to collect_unicodes()
- src/hb-ot-cmap-table.hh | 26
- ++++++++++++-------------
+ src/hb-ot-cmap-table.hh | 26 ++++++++++++-------------
src/hb-subset.cc | 6 +++---
src/hb-subset.h | 4 ++--
test/api/test-subset-codepoints.c | 18 ++++++++---------
@@ -24242,7 +24649,7 @@
Date: Sat Aug 25 08:44:18 2018 -0700
[ot-font] Return char-not-found if mapped to gid 0
-
+
OpenType cmap table can use gid=0 to mean "not covered" to produce
more optimized cmap subtables. Return false from get_nominal_glyph()
for those. hb-ft already does this.
@@ -24255,14 +24662,13 @@
Date: Sat Aug 25 08:18:53 2018 -0700
Add face-builder
-
+
New API:
+hb_face_builder_create
+hb_face_builder_add_table
docs/harfbuzz-sections.txt | 5 +-
- src/hb-face.cc | 149
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-face.cc | 149 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-face.h | 14 +++++
src/hb-subset-plan.cc | 2 +-
src/hb-subset-plan.hh | 2 +-
@@ -24285,8 +24691,7 @@
[sanitize] Document how sanitize machinery works
- src/hb-machinery-private.hh | 62
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-machinery-private.hh | 62 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 62 insertions(+)
commit 142ac5a6be6088771e0ee4b135ba753c80036a9a
@@ -24311,8 +24716,7 @@
src/hb-ot-layout-gsub-table.hh | 8 ++-
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
src/hb-ot-layout-private.hh | 12 ++---
- src/hb-ot-layout.cc | 100
- +++++++++++++++++------------------
+ src/hb-ot-layout.cc | 100 +++++++++++++++++------------------
src/hb-ot-math.cc | 2 +-
src/hb-ot-shape.cc | 5 +-
src/hb-ot-var.cc | 4 +-
@@ -24344,10 +24748,8 @@
drop hints from CFF & CFF2 Private
src/hb-cff-interp-dict-common-private.hh | 24 ++++++++++++++
- src/hb-subset-cff1.cc | 53
- +++++++++++++++++++++++++++---
- src/hb-subset-cff2.cc | 55
- +++++++++++++++++++++++++++++---
+ src/hb-subset-cff1.cc | 53 +++++++++++++++++++++++++++---
+ src/hb-subset-cff2.cc | 55 +++++++++++++++++++++++++++++---
3 files changed, 123 insertions(+), 9 deletions(-)
commit cef75ea41a513a612a683bced27ced31761204b5
@@ -24355,7 +24757,7 @@
Date: Fri Aug 17 13:13:18 2018 -0700
Added CFF2 Subr nullifier
-
+
along with CFF2 charstring interpreter
factored out common code between CFF1 & CFF2 to CSInterpreter
moved fetch_op from Interpreter to InterpEnv
@@ -24363,12 +24765,10 @@
src/Makefile.sources | 1 +
src/hb-cff-interp-common-private.hh | 44 +++++++--------
- src/hb-cff-interp-cs-common-private.hh | 95
- +++++++++++++++++++++++++++++--
+ src/hb-cff-interp-cs-common-private.hh | 95 +++++++++++++++++++++++++++++--
src/hb-cff-interp-dict-common-private.hh | 3 +-
src/hb-cff1-interp-cs.hh | 82 ---------------------------
- src/hb-cff2-interp-cs.hh | 97
- ++++++++++++++++++++++++++++++++
+ src/hb-cff2-interp-cs.hh | 97 ++++++++++++++++++++++++++++++++
src/hb-ot-cff-common-private.hh | 4 ++
src/hb-ot-cff2-table.hh | 7 ++-
src/hb-subset-cff1.cc | 1 +
@@ -24380,11 +24780,10 @@
Date: Thu Aug 16 08:03:46 2018 -0700
renamed CFF::Index to CFF::CFFIndex
-
+
to avoid confusion with OT::Index
- src/hb-ot-cff-common-private.hh | 38
- +++++++++++++++++++-------------------
+ src/hb-ot-cff-common-private.hh | 38 +++++++++++++++++++-------------------
src/hb-ot-cff1-table.hh | 4 ++--
src/hb-ot-cff2-table.hh | 2 +-
src/hb-subset-cff2.cc | 4 ++--
@@ -24404,7 +24803,7 @@
Date: Thu Aug 16 00:25:57 2018 -0700
renamed OT::cff to OT::cff1 for consistency
-
+
along with HB_OT_TAG_cff1
src/hb-ot-cff1-table.hh | 14 +++++++-------
@@ -24417,14 +24816,13 @@
Date: Thu Aug 16 00:13:09 2018 -0700
renamed CFF version 1 structs and sources to CFF1 from CFF
-
+
"CFF" is used for shared structs & sources between CFF1 & CFF2
except OT:cff is for CFF version 1 table
src/Makefile.sources | 8 +-
src/{hb-cff-interp-cs.hh => hb-cff1-interp-cs.hh} | 22 ++--
- src/{hb-ot-cff-table.hh => hb-ot-cff1-table.hh} | 150
- +++++++++++-----------
+ src/{hb-ot-cff-table.hh => hb-ot-cff1-table.hh} | 150 +++++++++++-----------
src/hb-ot-font.cc | 2 +-
src/{hb-subset-cff.cc => hb-subset-cff1.cc} | 86 ++++++-------
src/{hb-subset-cff.hh => hb-subset-cff1.hh} | 8 +-
@@ -24514,27 +24912,23 @@
Date: Wed Aug 15 12:00:19 2018 -0700
CFF Subrs subsetting
-
+
Unreferenced subroutines are nullified (not removed) in a subset font
-
- Separate Interpreter struct from hb-ot-cff-common-private.hh in a
- set of four header files, augmented for CharString (CS):
+
+ Separate Interpreter struct from hb-ot-cff-common-private.hh in a set of four header files, augmented for CharString (CS):
hb-cff-interp-common-private.hh
hb-cff-interp-dict-common-private.hh
hb-cff-interp-cs-common-private.hh
hb-cff-interp-cs.hh
+
+ Interpreter runtime is separated off as a new struct InterpEnv sub-classed differently for Dict and CharString (CS)
- Interpreter runtime is separated off as a new struct InterpEnv
- sub-classed differently for Dict and CharString (CS)
-
src/Makefile.sources | 8 +-
- src/hb-cff-interp-common-private.hh | 581
- +++++++++++++++++++++++++++++++
+ src/hb-cff-interp-common-private.hh | 581 +++++++++++++++++++++++++++++++
src/hb-cff-interp-cs-common-private.hh | 174 +++++++++
src/hb-cff-interp-cs.hh | 282 +++++++++++++++
src/hb-cff-interp-dict-common-private.hh | 183 ++++++++++
- src/hb-ot-cff-common-private.hh | 562
- ++----------------------------
+ src/hb-ot-cff-common-private.hh | 562 ++----------------------------
src/hb-ot-cff-table.hh | 165 ++++-----
src/hb-ot-cff2-table.hh | 147 ++++----
src/hb-subset-cff-common-private.hh | 83 +++++
@@ -24547,7 +24941,7 @@
Date: Tue Aug 14 14:47:20 2018 -0700
Add guard around free_static_C_locale
-
+
Add HB_USE_ATEXIT guard around free_static_C_locale missed by previous
commit.
@@ -24559,7 +24953,7 @@
Date: Tue Aug 14 13:50:24 2018 -0700
Guard free_static function definitions with macro
-
+
Add HB_USE_ATEXIT macros around free_static function definitions to
avoid unused function compiler warnings/errors.
@@ -24596,17 +24990,16 @@
Date: Mon Aug 13 10:30:41 2018 -0700
Don't add reference in get_unicode_funcs() functions
-
+
Users don't expect a new reference returned from a get() function.
- Indeed, all users of that API I foud where NOT destroying the
- reference.
+ Indeed, all users of that API I foud where NOT destroying the reference.
Just change the implementations to NOT return a reference.
-
+
This applies to the following APIs:
hb_unicode_funcs_get_default()
hb_glib_get_unicode_funcs()
hb_icu_get_unicode_funcs()
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1134
src/hb-buffer.cc | 3 +--
@@ -24620,11 +25013,10 @@
Date: Sun Aug 12 18:20:53 2018 -0700
[uniscribe] Use lazy loader
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1129
- src/hb-uniscribe.cc | 56
- +++++++++++++++++++++++++++--------------------------
+ src/hb-uniscribe.cc | 56 +++++++++++++++++++++++++++--------------------------
1 file changed, 29 insertions(+), 27 deletions(-)
commit 266368993625e0cfb6eef9188f8b9aa29fb97391
@@ -24651,8 +25043,7 @@
[lazy] Use for C_locale
- src/hb-common.cc | 60
- ++++++++++++++++++++++++++++----------------------------
+ src/hb-common.cc | 60 ++++++++++++++++++++++++++++----------------------------
1 file changed, 30 insertions(+), 30 deletions(-)
commit 747d2564e6bdcc15cf6a197e543fb732924159c5
@@ -24662,8 +25053,7 @@
[lazy] Port more
src/hb-machinery-private.hh | 1 -
- src/hb-shaper.cc | 78
- ++++++++++++++++++++-------------------------
+ src/hb-shaper.cc | 78 ++++++++++++++++++++-------------------------
src/hb-uniscribe.cc | 3 +-
3 files changed, 37 insertions(+), 45 deletions(-)
@@ -24688,8 +25078,7 @@
[lazy] Port more to it
- src/hb-shape.cc | 75
- +++++++++++++++++++++++++++++----------------------------
+ src/hb-shape.cc | 75 +++++++++++++++++++++++++++++----------------------------
1 file changed, 38 insertions(+), 37 deletions(-)
commit 6901090945d7e16102f3a2b168465434032b9a09
@@ -24699,8 +25088,7 @@
[lazy] Make hb_lazy_loader_t<> more usable
src/hb-ft.cc | 7 +++---
- src/hb-machinery-private.hh | 57
- +++++++++++++++++++++++++++------------------
+ src/hb-machinery-private.hh | 57 +++++++++++++++++++++++++++------------------
2 files changed, 37 insertions(+), 27 deletions(-)
commit bb905e9afcc3eb28a22ba78c09e661a814d04c1f
@@ -24727,10 +25115,9 @@
Date: Sun Aug 12 16:30:39 2018 -0700
[icu] Use get_relaxed for normalizer access
+
+ We've had the proper barriers already. No need for more with every access.
- We've had the proper barriers already. No need for more with
- every access.
-
src/hb-icu.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -24749,8 +25136,7 @@
[lazy] Use for ft_library
- src/hb-ft.cc | 61
- ++++++++++++++++++++++-----------------------
+ src/hb-ft.cc | 61 ++++++++++++++++++++++-----------------------
src/hb-glib.cc | 2 +-
src/hb-icu.cc | 2 +-
src/hb-machinery-private.hh | 2 +-
@@ -24778,8 +25164,7 @@
[ot/ft] Port font_funcs statis to lazy-loader
- src/hb-ft.cc | 56
- ++++++++++++++++++++++-----------------------
+ src/hb-ft.cc | 56 ++++++++++++++++++++++-----------------------
src/hb-machinery-private.hh | 14 ++++++++++++
src/hb-ot-font.cc | 49 +++++++++++++++++----------------------
3 files changed, 62 insertions(+), 57 deletions(-)
@@ -24791,8 +25176,7 @@
[ucdn/glib/icu] Port unicode_funcs statics to lazy-loader
src/hb-glib.cc | 50 ++++++++++++++++++--------------------
- src/hb-icu.cc | 59
- ++++++++++++++++-----------------------------
+ src/hb-icu.cc | 59 ++++++++++++++++-----------------------------
src/hb-machinery-private.hh | 28 ++++++++++++++++-----
src/hb-ucdn.cc | 51 +++++++++++++++++----------------------
4 files changed, 88 insertions(+), 100 deletions(-)
@@ -24812,8 +25196,7 @@
[lazy] More
- src/hb-machinery-private.hh | 45
- +++++++++++++++++++++++++++++++++++++--------
+ src/hb-machinery-private.hh | 45 +++++++++++++++++++++++++++++++++++++--------
1 file changed, 37 insertions(+), 8 deletions(-)
commit 5abdf5eebadf9a4fbd50c1a893c9654de74d22ac
@@ -24822,8 +25205,7 @@
[lazy] More shuffle
- src/hb-machinery-private.hh | 80
- +++++++++++++++++++--------------------------
+ src/hb-machinery-private.hh | 80 +++++++++++++++++++--------------------------
1 file changed, 34 insertions(+), 46 deletions(-)
commit 5d9863be6ecf873033cbab732207dd420f3866e7
@@ -24841,7 +25223,7 @@
Date: Sun Aug 12 12:21:56 2018 -0700
Add explicit_operator
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1127
src/hb-iter-private.hh | 2 +-
@@ -24887,7 +25269,7 @@
Date: Fri Aug 10 12:55:22 2018 -0700
fixed inclusion of excluded Private & local Subrs
-
+
It was bloating a multi-FD subset font unnecessarily
defined a wrapper struct FDMap for fdmap
@@ -24894,10 +25276,8 @@
src/hb-ot-cff-common-private.hh | 34 ++++++++++++++++++++-----
src/hb-subset-cff-common-private.cc | 6 ++---
src/hb-subset-cff-common-private.hh | 4 +--
- src/hb-subset-cff.cc | 48
- +++++++++++++++++++----------------
- src/hb-subset-cff2.cc | 50
- ++++++++++++++++++++-----------------
+ src/hb-subset-cff.cc | 48 +++++++++++++++++++----------------
+ src/hb-subset-cff2.cc | 50 ++++++++++++++++++++-----------------
5 files changed, 87 insertions(+), 55 deletions(-)
commit 64c541226457907ec1801a5766050ee64feb67e8
@@ -24905,7 +25285,7 @@
Date: Fri Aug 10 11:07:07 2018 -0700
Added CFF support
-
+
Added sources hb-ot-cff-table.hh, hb-subset-cff.cc & hh
Templatized Index because CFF uses 16-bit count while CFF2 uses 32-bit
Misc code cleanup & bug fixes
@@ -24912,8 +25292,7 @@
src/Makefile.sources | 9 +-
src/hb-ot-cff-common-private.hh | 477 ++++++++++++-------
- src/hb-ot-cff-table.hh | 919
- ++++++++++++++++++++++++++++++++++++
+ src/hb-ot-cff-table.hh | 919 ++++++++++++++++++++++++++++++++++++
src/hb-ot-cff2-table.hh | 235 ++++-----
src/hb-ot-font.cc | 1 +
src/hb-subset-cff-common-private.cc | 6 +-
@@ -24947,12 +25326,12 @@
Date: Thu Aug 9 00:56:28 2018 -0700
Revert "[iter] Make operator bool explicit"
-
+
This reverts commit 66920a6bace7c54c8166c4ed938b6ffc5fabcf2b.
-
+
Some of our bots (Oracle Studio and Apple gcc 4.2) do not allow
explicit except for constructors.
-
+
https://github.com/harfbuzz/harfbuzz/issues/1127
src/hb-iter-private.hh | 2 +-
@@ -24973,7 +25352,7 @@
Date: Thu Aug 9 00:28:40 2018 -0700
Fix lazy_loader fini()
-
+
Was creating object even if wasn't there.
src/hb-machinery-private.hh | 2 +-
@@ -24984,9 +25363,9 @@
Date: Thu Aug 9 00:22:37 2018 -0700
[atomic] Add hb_atomic_ptr_t<> and port all uses
-
+
Found and fixed a couple bugs.
-
+
Found a couple multithreading issues. Marked them with "XXX-MT-bug".
src/hb-atomic-private.hh | 34 +++++++++++++++++++++++++++++++---
@@ -25027,7 +25406,7 @@
Date: Wed Aug 8 22:45:49 2018 -0700
[atomic] Unify typedef
-
+
Removes volatile from fallback implementation. That was handwavy
anyway.
@@ -25039,7 +25418,7 @@
Date: Wed Aug 8 22:43:53 2018 -0700
[atomic] Change Mac atomic int type to int
-
+
If ever int is not 32bit, we'll fix this...
src/hb-atomic-private.hh | 2 +-
@@ -25089,7 +25468,7 @@
Date: Wed Aug 8 21:42:18 2018 -0700
Fix assertion failure
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1476334
src/hb-machinery-private.hh | 3 ++-
@@ -25113,7 +25492,7 @@
Date: Tue Aug 7 09:52:06 2018 -0700
Add +hb_font_get_glyph_advances_for_direction
-
+
New API:
+hb_font_get_glyph_advances_for_direction
@@ -25128,7 +25507,7 @@
Date: Tue Aug 7 09:47:00 2018 -0700
Actually add hb_font_get_glyph_[hv]_advances
-
+
New API:
+hb_font_get_glyph_h_advances
+hb_font_get_glyph_v_advances
@@ -25160,17 +25539,17 @@
Date: Mon Aug 6 15:32:13 2018 -0700
[iter] Make operator bool explicit
-
+
We would need to write:
-
+
for (Iter<T> it (...); bool (t); t++)
-
+
instead of:
-
+
for (Iter<T> it (...); t; t++)
-
+
But I think it's an improvement in code readability in the long term.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1127
src/hb-iter-private.hh | 2 +-
@@ -25208,17 +25587,14 @@
Date: Mon Aug 6 10:04:53 2018 -0700
subset FDSelect and FDArray
+
+ Added a set of sources hb-subset-cff-common-private.cc & .hh for FDSelect subseting code.
+ Added FDSelect format 4 (CFF2 only) support. Shared its implementation with format 3 as a template.
- Added a set of sources hb-subset-cff-common-private.cc & .hh for
- FDSelect subseting code.
- Added FDSelect format 4 (CFF2 only) support. Shared its implementation
- with format 3 as a template.
-
src/Makefile.sources | 2 +
src/hb-ot-cff-common-private.hh | 130 ++++++++++++++++-------
src/hb-ot-cff2-table.hh | 71 ++++++++++++-
- src/hb-subset-cff-common-private.cc | 200
- ++++++++++++++++++++++++++++++++++++
+ src/hb-subset-cff-common-private.cc | 200 ++++++++++++++++++++++++++++++++++++
src/hb-subset-cff-common-private.hh | 54 ++++++++++
src/hb-subset-cff2.cc | 71 ++++++++++---
6 files changed, 476 insertions(+), 52 deletions(-)
@@ -25228,7 +25604,7 @@
Date: Mon Aug 6 09:45:17 2018 -0700
Add batch advance width callback function
-
+
New API:
+hb_font_funcs_set_glyph_h_advances_func
+hb_font_funcs_set_glyph_v_advances_func
@@ -25239,8 +25615,7 @@
docs/harfbuzz-sections.txt | 6 +
src/hb-font-private.hh | 41 +++++--
- src/hb-font.cc | 299
- +++++++++++++++++++++++++++------------------
+ src/hb-font.cc | 299 +++++++++++++++++++++++++++------------------
src/hb-font.h | 53 ++++++--
src/hb-ot-shape.cc | 3 +-
5 files changed, 255 insertions(+), 147 deletions(-)
@@ -25282,7 +25657,7 @@
Date: Mon Aug 6 06:17:48 2018 -0700
Port _nil objects to Null() machinery
-
+
Finally, unified!
src/hb-blob-private.hh | 1 +
@@ -25292,8 +25667,7 @@
src/hb-face-private.hh | 6 +--
src/hb-face.cc | 5 ++-
src/hb-font-private.hh | 10 +++--
- src/hb-font.cc | 66
- ++++++++++++++++--------------
+ src/hb-font.cc | 66 ++++++++++++++++--------------
src/hb-null.hh | 11 ++++-
src/hb-ot-shape-complex-arabic-fallback.hh | 11 +++--
src/hb-shape-plan-private.hh | 1 +
@@ -25308,8 +25682,7 @@
[BASE] Rename horzi/vert to h/v
- src/hb-ot-layout-base-table.hh | 68
- +++++++++++++++++++++---------------------
+ src/hb-ot-layout-base-table.hh | 68 +++++++++++++++++++++---------------------
1 file changed, 34 insertions(+), 34 deletions(-)
commit da48aca1be89efbb8b3ca4471f542aa54aff17c4
@@ -25317,12 +25690,11 @@
Date: Mon Aug 6 05:52:12 2018 -0700
[BASE] Misc fixes
-
+
The code was badly broken. In better shape now, but still, needs
a full review before ever working.
- src/hb-ot-layout-base-table.hh | 163
- +++++++++++++++++------------------------
+ src/hb-ot-layout-base-table.hh | 163 +++++++++++++++++------------------------
1 file changed, 68 insertions(+), 95 deletions(-)
commit f9cfa5cb0e70203279e74fb6adb0cd4570238ff8
@@ -25341,8 +25713,7 @@
Move Null system to hb-null.hh
src/Makefile.sources | 1 +
- src/hb-null.hh | 97
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-null.hh | 97 ++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-private.hh | 65 +----------------------------------
3 files changed, 99 insertions(+), 64 deletions(-)
@@ -25381,8 +25752,7 @@
Move hb_vector_t to hb-vector-private.hh
src/Makefile.sources | 1 +
- src/hb-dsalgs.hh | 297
- -----------------------------------------------
+ src/hb-dsalgs.hh | 297 -----------------------------------------------
src/hb-object-private.hh | 109 ++++++++++++++++-
src/hb-vector-private.hh | 239 ++++++++++++++++++++++++++++++++++++++
4 files changed, 346 insertions(+), 300 deletions(-)
@@ -25394,8 +25764,7 @@
Move some more code around
src/hb-dsalgs.hh | 43 +++++++++++++++++++++++++++++++++++++++++++
- src/hb-private.hh | 51
- +--------------------------------------------------
+ src/hb-private.hh | 51 +--------------------------------------------------
2 files changed, 44 insertions(+), 50 deletions(-)
commit 92806ee055c8efb68fcbe9e1750ce2532a1f8ab3
@@ -25403,7 +25772,7 @@
Date: Sun Aug 5 21:41:52 2018 -0700
Move null data definitions to hb-static.cc
-
+
Also remove " " null data for Tag. Just use zeroes.
src/hb-open-type-private.hh | 3 +--
@@ -25454,7 +25823,7 @@
Date: Fri Aug 3 17:03:32 2018 -0700
[ot] Add misc tables to tables_t
-
+
Most unused.
src/hb-ot-layout-private.hh | 36 ++++++++++++++++++++++--------------
@@ -25483,8 +25852,7 @@
src/hb-ot-layout-gpos-table.hh | 4 ++--
src/hb-ot-layout-gsub-table.hh | 4 ++--
src/hb-ot-layout-private.hh | 7 ++----
- src/hb-ot-layout.cc | 49
- +++++++++++++++++++-----------------------
+ src/hb-ot-layout.cc | 49 +++++++++++++++++++-----------------------
5 files changed, 30 insertions(+), 40 deletions(-)
commit f73d2775cf649d148ace7c2593da9666d60fc1be
@@ -25492,11 +25860,10 @@
Date: Fri Aug 3 16:34:25 2018 -0700
[ot] More shuffling
-
+
Misc. table loading now properly automated.
- src/hb-ot-layout-private.hh | 67
- +++++++++++++++++++++++++++++----------------
+ src/hb-ot-layout-private.hh | 67 +++++++++++++++++++++++++++++----------------
src/hb-ot-layout.cc | 25 +++++++++++------
src/hb-ot-math.cc | 2 +-
3 files changed, 61 insertions(+), 33 deletions(-)
@@ -25530,17 +25897,14 @@
Date: Fri Aug 3 14:35:09 2018 -0700
Removed parsed hint fields from CFF2PrivateDictValues
-
- Instead moved & stored uniformly in values vector (renamed from
- opstrs)
- This should be fine as we aren't likely going to use them as hints
- after all
+
+ Instead moved & stored uniformly in values vector (renamed from opstrs)
+ This should be fine as we aren't likely going to use them as hints after all
Templatized DictValues whether to parse them out
For subsetter, they aren't parsed
src/hb-ot-cff-common-private.hh | 113 ++++++++++++++----------
- src/hb-ot-cff2-table.hh | 185
- ++++++++++++----------------------------
+ src/hb-ot-cff2-table.hh | 185 ++++++++++++----------------------------
src/hb-subset-cff2.cc | 2 +-
3 files changed, 120 insertions(+), 180 deletions(-)
@@ -25550,8 +25914,7 @@
[ot] Move code around
- src/hb-ot-layout.cc | 211
- ++++++++++++++++++++++++++--------------------------
+ src/hb-ot-layout.cc | 211 ++++++++++++++++++++++++++--------------------------
1 file changed, 106 insertions(+), 105 deletions(-)
commit 5e718a751efdda89511c9f30238b500125193499
@@ -25559,11 +25922,10 @@
Date: Thu Aug 2 23:04:42 2018 -0700
[ot] Use switch for checking for blacklisted GDEF tables
-
+
Faster / more compact code.
- src/hb-ot-layout.cc | 107
- +++++++++++++++++++++++++++++-----------------------
+ src/hb-ot-layout.cc | 107 +++++++++++++++++++++++++++++-----------------------
1 file changed, 59 insertions(+), 48 deletions(-)
commit b5cdf5280d5b00df5356cc5c3236844ca0576bd0
@@ -25570,9 +25932,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Aug 2 22:56:42 2018 -0700
- [ot] In GDEF blacklisting logic, remove the glyph index check
- for Times
-
+ [ot] In GDEF blacklisting logic, remove the glyph index check for Times
+
Just blacklist based on table sizes like we do for other fonts.
src/hb-ot-layout.cc | 12 ------------
@@ -25591,14 +25952,12 @@
Author: Michiharu Ariza <ariza at adobe.com>
Date: Thu Aug 2 16:28:10 2018 -0700
- templatized CFF2 accelerator for lean Private dict interpretting
- for subset
-
+ templatized CFF2 accelerator for lean Private dict interpretting for subset
+
also fixed local subrs serialization
src/hb-ot-cff-common-private.hh | 8 ++-
- src/hb-ot-cff2-table.hh | 119
- ++++++++++++++++++++++++++++++++--------
+ src/hb-ot-cff2-table.hh | 119 ++++++++++++++++++++++++++++++++--------
src/hb-subset-cff2.cc | 13 +++--
3 files changed, 109 insertions(+), 31 deletions(-)
@@ -25719,8 +26078,7 @@
Reduce storage by sharing face amongst lazy_loaders
- src/hb-machinery-private.hh | 113
- ++++++++++++++++++++++++--------------------
+ src/hb-machinery-private.hh | 113 ++++++++++++++++++++++++--------------------
src/hb-ot-font.cc | 19 ++++----
src/hb-ot-layout-private.hh | 11 +++--
src/hb-ot-layout.cc | 9 ++--
@@ -25732,8 +26090,7 @@
Internal templatization of lazy-loaders
- src/hb-machinery-private.hh | 74
- ++++++++++++++++++++-------------------------
+ src/hb-machinery-private.hh | 74 ++++++++++++++++++++-------------------------
1 file changed, 32 insertions(+), 42 deletions(-)
commit ed7b2e58fc9afb547656cf28eb4a253d989de43c
@@ -25782,8 +26139,7 @@
Rename
- src/hb-coretext.cc | 46
- +++++++++++++++++++++++-----------------------
+ src/hb-coretext.cc | 46 +++++++++++++++++++++++-----------------------
src/hb-directwrite.cc | 28 ++++++++++++++--------------
src/hb-fallback-shape.cc | 24 ++++++++++++------------
src/hb-graphite2.cc | 26 +++++++++++++-------------
@@ -25816,7 +26172,7 @@
Date: Wed Aug 1 16:32:27 2018 -0700
fixed Index::serialize
-
+
The bug was causing CharString of the last glyph corrupt
src/hb-ot-cff-common-private.hh | 4 +++-
@@ -25827,7 +26183,7 @@
Date: Wed Aug 1 16:06:52 2018 -0700
fixed CFF2VariationStore::serialize
-
+
also get_size
src/hb-ot-cff2-table.hh | 7 ++++---
@@ -25851,8 +26207,7 @@
[atomic] Fix Solaris ones to add proper barriers
- src/hb-atomic-private.hh | 52
- +++++++++++++++++++++++++++++++++---------------
+ src/hb-atomic-private.hh | 52 +++++++++++++++++++++++++++++++++---------------
1 file changed, 36 insertions(+), 16 deletions(-)
commit 19dfaa351568887a74cee2c46d6acfcc3fa718ff
@@ -25905,17 +26260,15 @@
Date: Wed Aug 1 11:30:38 2018 -0700
Implemented hb_subset_cff2
-
+
Added serialize functions to CFF2 structs
Fixed issues & bugs & code cleanup
Now subsetting CFF2 table outputs something
- src/hb-ot-cff-common-private.hh | 428
- +++++++++++++++++++++++++++++++++++-----
+ src/hb-ot-cff-common-private.hh | 428 +++++++++++++++++++++++++++++++++++-----
src/hb-ot-cff2-table.hh | 237 +++++++++++++++++-----
src/hb-private.hh | 2 +-
- src/hb-subset-cff2.cc | 392
- +++++++++++++++++++++++++++++++-----
+ src/hb-subset-cff2.cc | 392 +++++++++++++++++++++++++++++++-----
4 files changed, 914 insertions(+), 145 deletions(-)
commit 1a7fed631880fff8a947ebec9c7427efff581916
@@ -25922,15 +26275,13 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Wed Aug 1 12:15:44 2018 +0430
- Revert "Add a new API, hb_ot_layout_get_feature_name_ids (#976)"
- (#1121)
-
+ Revert "Add a new API, hb_ot_layout_get_feature_name_ids (#976)" (#1121)
+
This reverts commit 0c1b287b72e91e0898d75acb5d5acf1c6b9a7498.
docs/harfbuzz-sections.txt | 1 -
src/hb-ot-layout-common-private.hh | 14 -------
- src/hb-ot-layout.cc | 86
- --------------------------------------
+ src/hb-ot-layout.cc | 86 --------------------------------------
src/hb-ot-layout.h | 8 ----
4 files changed, 109 deletions(-)
@@ -25957,7 +26308,7 @@
Date: Tue Jul 31 23:01:05 2018 -0700
[atomic] On IBM, use light-weight sync for everything
-
+
lwsync() is a full read/write-barrier. That's all we need, never
need sync(). I'm not sure why an isync() was used in fetch_and_add,
but since that's a read-modify-write, I just changed it to have
@@ -25971,7 +26322,7 @@
Date: Tue Jul 31 23:00:15 2018 -0700
[atomic] Add XXX items around Solaris ops
-
+
Since add_int and cas are both read-modify-write, I wonder if we
also need a barrier after them.
@@ -25983,19 +26334,18 @@
Date: Tue Jul 31 22:51:38 2018 -0700
[atomic] Fix get() impl
-
- Originally, glib's atomic_get was implemented as "memory_barrier;
- load".
+
+ Originally, glib's atomic_get was implemented as "memory_barrier; load".
I copied this into cairo, fontconfig, and harfbuzz. However, that's
wrong. Correct way is "load; memory_barrier". The details are long
and hard to fully grasp. Best to read:
-
+
https://www.kernel.org/doc/Documentation/memory-barriers.txt
-
+
Also see my report against GNOME:
-
+
https://gitlab.gnome.org/GNOME/glib/issues/1449
-
+
Note that this is irrelevant if C++11-like atomic ops are available.
src/hb-atomic-private.hh | 28 +++++++++++++++++-----------
@@ -26027,13 +26377,12 @@
Date: Tue Jul 31 21:05:51 2018 -0700
[atomic] Add get_relaxed / set_relaxed
-
+
To help TSan and be more "correct".
src/hb-atomic-private.hh | 37 ++++++++++++++++++++++-------------
src/hb-common.cc | 4 ++--
- src/hb-debug.hh | 42
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-debug.hh | 42 ++++++++++++++++++++++++++++++++++++++++
src/hb-object-private.hh | 12 ++++++------
src/hb-ot-shape-complex-indic.cc | 22 +++++++++++----------
src/hb-private.hh | 28 ---------------------------
@@ -26044,7 +26393,7 @@
Date: Tue Jul 31 19:33:37 2018 -0700
[atomic] Use CONSUME, not ACQUIRE, memory-order for get()
-
+
Although, all implementations just elevate that to ACQUIRE.
But requirement for us is just CONSUME.
@@ -26056,14 +26405,14 @@
Date: Tue Jul 31 19:29:49 2018 -0700
Revert "[atomic] Make pointer get op relaxed instead of acquire"
-
+
This reverts commit b1e5650c67266dc158f22355fed206cd1c413f70.
-
+
After lots of head-scratching and finally finding the only truly
readable source to be the good old:
-
+
https://www.kernel.org/doc/Documentation/memory-barriers.txt
-
+
I've convinced myself that we need consume memory-ordering on get().
The location of memory-barrier in a load should be after, not before
the load. That needs fixing. I'll do that separately.
@@ -26076,12 +26425,10 @@
Date: Tue Jul 31 17:44:02 2018 -0700
[subset] limit the max codepoint value to the unicode limit.
- When collecting all codepoints in the cmap avoid using large amount
- of memory for fonts that declare coverage over all 32 bit integers.
+ When collecting all codepoints in the cmap avoid using large amount of memory for fonts that declare coverage over all 32 bit integers.
src/hb-ot-cmap-table.hh | 9 +++++++--
- ...mized-hb-subset-get-codepoints-fuzzer-5973295416475648 | Bin 0 ->
- 109 bytes
+ ...mized-hb-subset-get-codepoints-fuzzer-5973295416475648 | Bin 0 -> 109 bytes
2 files changed, 7 insertions(+), 2 deletions(-)
commit 7278d9df3093a87f99cec9b4cea38bd688c5d020
@@ -26092,8 +26439,7 @@
Add the fuzzer test case for feature collection timeout.
docs/harfbuzz-sections.txt | 1 +
- ...estcase-minimized-hb-subset-fuzzer-5542653037903872 | Bin 0 ->
- 160249 bytes
+ ...estcase-minimized-hb-subset-fuzzer-5542653037903872 | Bin 0 -> 160249 bytes
2 files changed, 1 insertion(+)
commit 89733755a48feef0a663e1ea7b8294949581ce7e
@@ -26104,8 +26450,7 @@
This is much faster then calling a bunch of individual add()'s.
src/hb-ot-layout-common-private.hh | 7 +++++++
- src/hb-ot-layout.cc | 40
- +++++++++++++++++++-------------------
+ src/hb-ot-layout.cc | 40 +++++++++++++++++++-------------------
2 files changed, 27 insertions(+), 20 deletions(-)
commit 7d92bef9c5afb319d125f60b0fce4763afeaa686
@@ -26114,8 +26459,7 @@
[subset] collect features first, then use those to collect lookups.
- src/hb-ot-layout.cc | 148
- +++++++++++++++++++++++++---------------------------
+ src/hb-ot-layout.cc | 148 +++++++++++++++++++++++++---------------------------
src/hb-ot-layout.h | 7 +++
2 files changed, 78 insertions(+), 77 deletions(-)
@@ -26124,16 +26468,15 @@
Date: Tue Jul 31 15:27:29 2018 -0700
[indic] Flip default logic for double-halants in old-school
-
+
Oriya went down from 9 to 2.
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707311 out of 707394 tests passed. 83 failed (0.0117332%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
GURMUKHI: 60729 out of 60747 tests passed. 18 failed (0.0296311%)
KANNADA: 951300 out of 951913 tests passed. 613 failed (0.0643966%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
MYANMAR: 1115830 out of 1123883 tests passed. 8053 failed (0.716534%)
ORIYA: 42327 out of 42329 tests passed. 2 failed (0.00472489%)
SINHALA: 271596 out of 271847 tests passed. 251 failed (0.0923313%)
@@ -26148,13 +26491,11 @@
Date: Tue Jul 31 15:19:32 2018 -0700
[indic] Allow double-halant in old-spec Devanagari
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1071
- src/hb-ot-shape-complex-indic.cc | 18
- ++++++++++++------
- .../b722a7d09e60421f3efbc706ad348ab47b88567b.ttf | Bin 0 ->
- 4672 bytes
+ src/hb-ot-shape-complex-indic.cc | 18 ++++++++++++------
+ .../b722a7d09e60421f3efbc706ad348ab47b88567b.ttf | Bin 0 -> 4672 bytes
test/shaping/data/in-house/tests/indic-old-spec.tests | 2 ++
3 files changed, 14 insertions(+), 6 deletions(-)
@@ -26163,7 +26504,7 @@
Date: Tue Jul 31 14:20:31 2018 -0700
[test] Add Khmer tests, with NotoSansKhmer-Regular.ttf
-
+
Note that there's minor positioning differences, and ONE reordering
difference between what we get for these and what Uniscribe gets.
Probably same as what's described in commit message for
@@ -26170,8 +26511,7 @@
1a96cc825dc9c8e3b6eef1403fe0864a1cfc0245
.../3998336402905b8be8301ef7f47cf7e050cbb1bd.ttf | Bin 0 -> 24392 bytes
- test/shaping/data/in-house/tests/khmer-misc.tests | 89
- +++++++++++++++++++++
+ test/shaping/data/in-house/tests/khmer-misc.tests | 89 +++++++++++++++++++++
2 files changed, 89 insertions(+)
commit 5772edc0ea8f697c6123e439c5d0c3e813ebeb45
@@ -26189,8 +26529,7 @@
[test] Add Khmer test texts from recent bugs
- test/shaping/texts/in-house/shaper-khmer/misc.txt | 66
- +++++++++++++++++++++++
+ test/shaping/texts/in-house/shaper-khmer/misc.txt | 66 +++++++++++++++++++++++
1 file changed, 66 insertions(+)
commit df26a32c8fd22cbd486e2a1014d30b9f38f51cd1
@@ -26199,354 +26538,180 @@
[test] Move things around for shaper updates
- .../texts/in-house/shaper-indic/{indic => }/script-assamese/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-assamese/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-assamese/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-assamese/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-assamese/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../script-assamese/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt
- | 0
- .../{indic => }/script-assamese/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-bengali/misc/misc.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-bengali/misc/reph.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-bengali/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-bengali/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-bengali/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-bengali/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../script-bengali/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-bengali/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../script-bengali/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt
- | 0
- .../{indic => }/script-bengali/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../shaper-indic/{indic => }/script-devanagari/misc/dottedcircle.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-devanagari/misc/eyelash.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-devanagari/misc/joiners.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-devanagari/misc/misc.txt
- | 0
- .../shaper-indic/{indic => }/script-devanagari/misc/spec-deviations.txt
- | 0
- .../shaper-indic/{indic => }/script-devanagari/misc/tricky-reordering.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-devanagari/utrrs/LICENSE
- | 0
- .../in-house/shaper-indic/{indic => }/script-devanagari/utrrs/README
- | 0
- .../in-house/shaper-indic/{indic => }/script-devanagari/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalConsonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../codepoint/IndicFontFeatureCodepoint-DevnagariSpecificAddition.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-GenericPunctuation.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-devanagari/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../script-devanagari/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt
- | 0
- .../{indic => }/script-devanagari/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gujarati/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gujarati/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gujarati/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-gujarati/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-gujarati/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../script-gujarati/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt
- | 0
- .../{indic => }/script-gujarati/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/misc/misc.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-gurmukhi/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-GurmukhiSpecific.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-gurmukhi/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../script-gurmukhi/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt
- | 0
- .../{indic => }/script-gurmukhi/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-kannada/misc/misc.txt
- | 0
- .../shaper-indic/{indic => }/script-kannada/misc/right-matras.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-kannada/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-kannada/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-kannada/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalConsonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-kannada/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../script-kannada/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-kannada/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../{indic => }/script-kannada/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-malayalam/misc/cibu.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-malayalam/misc/dot-reph.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-malayalam/misc/misc.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-malayalam/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-malayalam/utrrs/README
- | 0
- .../in-house/shaper-indic/{indic => }/script-malayalam/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-malayalam/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../{indic => }/script-malayalam/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-oriya/misc/bindu.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-oriya/misc/misc.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-oriya/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-oriya/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-oriya/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalConsonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../script-oriya/utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-oriya/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-OriyaSpecific.txt
- | 0
- .../script-oriya/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../{indic => }/script-oriya/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../in-house/shaper-indic/{indic => }/script-sinhala/misc/extensive.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-sinhala/misc/misc.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-sinhala/misc/reph.txt
- | 0
- .../shaper-indic/{indic => }/script-sinhala/misc/split-matras.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-sinhala/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-sinhala/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-sinhala/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Punctuation.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../{indic => }/script-sinhala/utrrs/gpos/IndicFontFeatureGPOS.txt
- | 0
- .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Conjunct.txt
- | 0
- .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Rakaaraansaya.txt
- | 0
- .../{indic => }/script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Repaya.txt
- | 0
- .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Special-Cases.txt
- | 0
- .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-TouchingLetters.txt
- | 0
- .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Yansaya.txt
- | 0
- .../{indic => }/script-sinhala/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-tamil/misc/misc.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-tamil/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-tamil/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-tamil/utrrs/SOURCES
- | 0
- .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-CurrencySymbols.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Numerics.txt
- | 0
- .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Symbols.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-TamilSymbol.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-tamil/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../script-tamil/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt
- | 0
- .../{indic => }/script-tamil/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-telugu/misc/misc.txt
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-telugu/utrrs/LICENSE
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-telugu/utrrs/README
- | 0
- .../texts/in-house/shaper-indic/{indic => }/script-telugu/utrrs/SOURCES
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt
- | 0
- .../script-telugu/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt
- | 0
- .../script-telugu/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt
- | 0
- .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt
- | 0
- .../script-telugu/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt
- | 0
- .../{indic => }/script-telugu/utrrs/gsub/IndicFontFeatureGSUB.txt
- | 0
- .../south-east-asian/script-khmer/misc => shaper-khmer}/misc.txt
- | 0
- .../script-khmer/misc => shaper-khmer}/other-marks-invalid.txt
- | 0
- .../south-east-asian/script-khmer/misc => shaper-khmer}/other-marks.txt
- | 0
- .../south-east-asian => shaper-use}/script-javanese/misc.txt
- | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-assamese/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-assamese/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-assamese/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-assamese/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-assamese/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../script-assamese/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt | 0
+ .../{indic => }/script-assamese/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-bengali/misc/misc.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-bengali/misc/reph.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-bengali/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-bengali/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-bengali/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-bengali/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../script-bengali/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-bengali/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../script-bengali/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt | 0
+ .../{indic => }/script-bengali/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../shaper-indic/{indic => }/script-devanagari/misc/dottedcircle.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-devanagari/misc/eyelash.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-devanagari/misc/joiners.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-devanagari/misc/misc.txt | 0
+ .../shaper-indic/{indic => }/script-devanagari/misc/spec-deviations.txt | 0
+ .../shaper-indic/{indic => }/script-devanagari/misc/tricky-reordering.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-devanagari/utrrs/LICENSE | 0
+ .../in-house/shaper-indic/{indic => }/script-devanagari/utrrs/README | 0
+ .../in-house/shaper-indic/{indic => }/script-devanagari/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalConsonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../codepoint/IndicFontFeatureCodepoint-DevnagariSpecificAddition.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-GenericPunctuation.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-devanagari/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../script-devanagari/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt | 0
+ .../{indic => }/script-devanagari/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gujarati/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gujarati/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gujarati/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-gujarati/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-gujarati/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../script-gujarati/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt | 0
+ .../{indic => }/script-gujarati/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/misc/misc.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-gurmukhi/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-gurmukhi/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-GurmukhiSpecific.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-gurmukhi/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../script-gurmukhi/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt | 0
+ .../{indic => }/script-gurmukhi/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-kannada/misc/misc.txt | 0
+ .../shaper-indic/{indic => }/script-kannada/misc/right-matras.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-kannada/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-kannada/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-kannada/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalConsonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-kannada/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../script-kannada/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-kannada/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../{indic => }/script-kannada/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-malayalam/misc/cibu.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-malayalam/misc/dot-reph.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-malayalam/misc/misc.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-malayalam/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-malayalam/utrrs/README | 0
+ .../in-house/shaper-indic/{indic => }/script-malayalam/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-malayalam/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../{indic => }/script-malayalam/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-oriya/misc/bindu.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-oriya/misc/misc.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-oriya/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-oriya/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-oriya/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalConsonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../script-oriya/utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-oriya/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-OriyaSpecific.txt | 0
+ .../script-oriya/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../{indic => }/script-oriya/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../in-house/shaper-indic/{indic => }/script-sinhala/misc/extensive.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-sinhala/misc/misc.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-sinhala/misc/reph.txt | 0
+ .../shaper-indic/{indic => }/script-sinhala/misc/split-matras.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-sinhala/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-sinhala/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-sinhala/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Punctuation.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../{indic => }/script-sinhala/utrrs/gpos/IndicFontFeatureGPOS.txt | 0
+ .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Conjunct.txt | 0
+ .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Rakaaraansaya.txt | 0
+ .../{indic => }/script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Repaya.txt | 0
+ .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Special-Cases.txt | 0
+ .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-TouchingLetters.txt | 0
+ .../script-sinhala/utrrs/gsub/IndicFontFeatureGSUB-Yansaya.txt | 0
+ .../{indic => }/script-sinhala/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-tamil/misc/misc.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-tamil/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-tamil/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-tamil/utrrs/SOURCES | 0
+ .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-CurrencySymbols.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Numerics.txt | 0
+ .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../script-tamil/utrrs/codepoint/IndicFontFeatureCodepoint-Symbols.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-TamilSymbol.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-tamil/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../script-tamil/utrrs/gpos/IndicFontFeatureGPOS-BelowBase.txt | 0
+ .../{indic => }/script-tamil/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-telugu/misc/misc.txt | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-telugu/utrrs/LICENSE | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-telugu/utrrs/README | 0
+ .../texts/in-house/shaper-indic/{indic => }/script-telugu/utrrs/SOURCES | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-AdditionalVowels.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-Consonants.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-DependentVowels.txt | 0
+ .../script-telugu/utrrs/codepoint/IndicFontFeatureCodepoint-Digits.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-IndependentVowels.txt | 0
+ .../script-telugu/utrrs/codepoint/IndicFontFeatureCodepoint-Reserved.txt | 0
+ .../utrrs/codepoint/IndicFontFeatureCodepoint-VariousSigns.txt | 0
+ .../script-telugu/utrrs/gpos/IndicFontFeatureGPOS-AboveBase.txt | 0
+ .../{indic => }/script-telugu/utrrs/gsub/IndicFontFeatureGSUB.txt | 0
+ .../south-east-asian/script-khmer/misc => shaper-khmer}/misc.txt | 0
+ .../script-khmer/misc => shaper-khmer}/other-marks-invalid.txt | 0
+ .../south-east-asian/script-khmer/misc => shaper-khmer}/other-marks.txt | 0
+ .../south-east-asian => shaper-use}/script-javanese/misc.txt | 0
174 files changed, 0 insertions(+), 0 deletions(-)
commit 6ddd669e205cf2c1c3b0a362330b686386f68519
@@ -26554,7 +26719,7 @@
Date: Tue Jul 31 13:38:07 2018 -0700
[khmer] Clear syllables before presentation features
-
+
Probably not what Uniscribe does, but good idea?
src/hb-ot-shape-complex-khmer.cc | 3 +--
@@ -26565,14 +26730,14 @@
Date: Tue Jul 31 13:35:10 2018 -0700
[khmer] Revert previous change, and remove pauses
-
+
This makes test suite happy again (at 44) while fixing the sequences
we were fixing, which were the following with KhmerUI.ttf:
-
+
U+1789,U+17BC
U+1789,U+17D2,U+1789
U+1789,U+17D2,U+1789,U+17BC
-
+
Fixes rest of https://github.com/harfbuzz/harfbuzz/issues/974
src/hb-ot-shape-complex-khmer.cc | 23 ++++++++++-------------
@@ -26583,7 +26748,7 @@
Date: Tue Jul 31 12:49:02 2018 -0700
[khmer] Apply ccmp after basic features
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/974
src/hb-ot-shape-complex-khmer.cc | 22 +++++++++++++++++-----
@@ -26594,7 +26759,7 @@
Date: Tue Jul 31 11:45:32 2018 -0700
[khmer] Rewrite most of shaper to better follow spec
-
+
Khmer spec has only one reordering phase, and only simple prebase
matra and Coeng-Ro reordering. Implement that. Specifically,
this was done to address recognizing different orders of the matra
@@ -26602,22 +26767,21 @@
reordered differently from Uniscribe. Not clear if that's intended
or a bug in Uniscribe. The following two sequences render the same
in Uniscribe whereas we reorder them differently:
-
+
U+17A0,U+17D2,U+179A,U+17C2
U+17A0,U+17C2,U+17D2,U+179A
-
+
For that reason, our test suite numbers regressed slightly. Used
to be at 34 for fails, now at:
-
+
KHMER: 299080 out of 299124 tests passed. 44 failed (0.0147096%)
-
+
But generally a good change, and removed lots of code.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1026
src/hb-ot-shape-complex-indic-private.hh | 4 +-
- src/hb-ot-shape-complex-khmer.cc | 460
- ++++---------------------------
+ src/hb-ot-shape-complex-khmer.cc | 460 ++++---------------------------
src/hb-ot-shape-complex-private.hh | 13 -
3 files changed, 64 insertions(+), 413 deletions(-)
@@ -26644,7 +26808,7 @@
Date: Tue Jul 31 01:02:31 2018 -0700
[atomic] Make pointer get op relaxed instead of acquire
-
+
We only use it before cmpexch, so relaxed is fine and faster for
common case.
@@ -26656,7 +26820,7 @@
Date: Mon Jul 30 17:03:06 2018 -0700
[serialize] Increase stage count from 8 to 32
-
+
Indic shaper uses many stages. Now we are provably not limiting
functionality whereas the previous limit of 8 was assuming real-world
practices.
@@ -26687,12 +26851,11 @@
Date: Mon Jul 30 14:28:40 2018 -0700
Added sanitize functions & calls
-
+
Added sanitize functions to FDSelect
Added satnitize calls for FDSelect, VariationStore, FDArray, TopDict
- src/hb-ot-cff-common-private.hh | 67
- ++++++++++++++++++++++++++++++++---------
+ src/hb-ot-cff-common-private.hh | 67 ++++++++++++++++++++++++++++++++---------
src/hb-ot-cff2-table.hh | 26 +++++++++++-----
src/hb-subset-cff2.cc | 2 +-
3 files changed, 72 insertions(+), 23 deletions(-)
@@ -26708,11 +26871,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Jul 26 17:42:02 2018 -0700
- [subset] During lookup collection remember the features we've
- already processed.
+ [subset] During lookup collection remember the features we've already processed.
- src/hb-ot-layout.cc | 26
- +++++++++++++++++----
+ src/hb-ot-layout.cc | 26 +++++++++++++++++----
...ase-minimized-hb-subset-fuzzer-5670861909524480 | Bin 0 -> 1298 bytes
...b-subset-get-codepoints-fuzzer-6136125075750912 | Bin 0 -> 65816 bytes
3 files changed, 21 insertions(+), 5 deletions(-)
@@ -26761,12 +26922,11 @@
Date: Wed Jul 25 17:07:17 2018 -0700
Add hb-iter-private.hh
-
+
Unused so far.
src/Makefile.sources | 1 +
- src/hb-iter-private.hh | 147
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-iter-private.hh | 147 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-machinery-private.hh | 1 +
3 files changed, 149 insertions(+)
@@ -26777,10 +26937,8 @@
Move some code from hb-open-type-private.hh to hb-machinery-private.hh
src/Makefile.sources | 1 +
- src/hb-machinery-private.hh | 702
- ++++++++++++++++++++++++++++++++++++++++++++
- src/hb-open-type-private.hh | 669
- +----------------------------------------
+ src/hb-machinery-private.hh | 702 ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-open-type-private.hh | 669 +----------------------------------------
3 files changed, 706 insertions(+), 666 deletions(-)
commit 6b11fea99716e22522b563d919ef7c72fe9a3c45
@@ -26824,7 +26982,7 @@
Date: Tue Jul 24 09:43:27 2018 -0700
[closure] Separate in and out glyphs
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1107
src/hb-ot-layout-gsub-table.hh | 26 ++++++++++++++++++--------
@@ -26847,7 +27005,7 @@
Date: Mon Jul 23 15:01:39 2018 -0700
Fix visibility on mingw32
-
+
Should fix bots again.
src/hb-private.hh | 6 +++++-
@@ -26868,7 +27026,7 @@
Date: Mon Jul 23 13:24:26 2018 -0700
One more visibility trick
-
+
Should fix Windows build again.
src/hb-common.cc | 9 +++++++++
@@ -26906,7 +27064,7 @@
Date: Mon Jul 23 11:46:46 2018 -0700
Set num glyphs on sanitizer reference_table()
-
+
Move out-of-class definitions of two methods to hb-static so they
are accessible in libharfbuzz-subset.
@@ -26996,14 +27154,12 @@
Date: Sun Jul 22 22:24:31 2018 -0700
Add sanitizer reference_table, also fix clang build
-
+
Clang is being really peculiar. Fix with:
+
+ - inline hb_blob_t *sanitize (hb_blob_t *blob) { return c->sanitize<Type> (blob); }
+ + inline hb_blob_t *sanitize (hb_blob_t *blob) { return c[0].template/*clang idiosyncrasy*/sanitize_blob<Type> (blob); }
- - inline hb_blob_t *sanitize (hb_blob_t *blob) { return
- c->sanitize<Type> (blob); }
- + inline hb_blob_t *sanitize (hb_blob_t *blob) { return
- c[0].template/*clang idiosyncrasy*/sanitize_blob<Type> (blob); }
-
src/hb-open-type-private.hh | 10 ++++++++--
src/hb-ot-post-table.hh | 2 +-
src/hb-subset-glyf.cc | 2 +-
@@ -27015,13 +27171,12 @@
Date: Fri Apr 13 18:45:37 2018 -0400
Order Chakma split vowels in accordance with NFC
-
+
Fixes #1105.
src/gen-use-table.py | 10 ++++++++++
src/hb-ot-shape-complex-use-table.cc | 4 ++--
- src/hb-ot-shape-complex-use.cc | 21
- +--------------------
+ src/hb-ot-shape-complex-use.cc | 21 +--------------------
.../2a670df15b73a5dc75a5cc491bde5ac93c5077dc.ttf | Bin 0 -> 1344 bytes
test/shaping/data/in-house/tests/use.tests | 5 +++++
5 files changed, 18 insertions(+), 22 deletions(-)
@@ -27031,22 +27186,18 @@
Date: Sat Jul 21 21:14:48 2018 +0430
Add a new API, hb_ot_layout_get_feature_name_ids (#976)
-
+
This new API returns cvXX and ssXX related NameId, things like
- featUiLabelNameId, featUiTooltipTextNameId, sampleTextNameId,
- ... of cvXX
+ featUiLabelNameId, featUiTooltipTextNameId, sampleTextNameId, ... of cvXX
and UINameId of ssXX, in a unified way.
-
- However HarfBuzz currently doesn't expose an API for retrieving
- the actual
- information associated with NameId from the `name` table and that
- should be
+
+ However HarfBuzz currently doesn't expose an API for retrieving the actual
+ information associated with NameId from the `name` table and that should be
done separately.
docs/harfbuzz-sections.txt | 1 +
src/hb-ot-layout-common-private.hh | 14 +++++++
- src/hb-ot-layout.cc | 86
- ++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout.cc | 86 ++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout.h | 8 ++++
4 files changed, 109 insertions(+)
@@ -27055,13 +27206,12 @@
Date: Wed Jul 18 14:17:52 2018 -0700
first push of CFF/CFF2 work
-
+
Index, Dict structs
hooked up to hb-subset (takes CFF2, outputs empty CFF2)
src/Makefile.sources | 4 +
- src/hb-ot-cff-common-private.hh | 475
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-cff-common-private.hh | 475 ++++++++++++++++++++++++++++++++++++++++
src/hb-ot-cff2-table.hh | 386 ++++++++++++++++++++++++++++++++
src/hb-ot-font.cc | 2 +
src/hb-subset-cff2.cc | 121 ++++++++++
@@ -27074,14 +27224,13 @@
Date: Tue Jul 17 23:29:16 2018 +0430
Remove dump-fon (#1100)
-
+
It had interesting stuffs like EXE parsing and
big-endian parsers but added in an attempt to find
a solution for #681 which later found not related.
src/Makefile.am | 4 -
- src/dump-fon.cc | 555
- --------------------------------------------------------
+ src/dump-fon.cc | 555 --------------------------------------------------------
2 files changed, 559 deletions(-)
commit d5cd47a69c40966b4d5b5aed87dd7ac6f070c37a
@@ -27089,14 +27238,12 @@
Date: Tue Jul 17 22:32:37 2018 +0430
Remove AAT's gcid/fmtx (#1099)
-
+
We are not going to use them, at least in the foreseeable future
src/Makefile.sources | 2 --
- src/hb-aat-fmtx-table.hh | 67
- --------------------------------------------
- src/hb-aat-gcid-table.hh | 73
- ------------------------------------------------
+ src/hb-aat-fmtx-table.hh | 67 --------------------------------------------
+ src/hb-aat-gcid-table.hh | 73 ------------------------------------------------
src/hb-aat-layout.cc | 2 --
4 files changed, 144 deletions(-)
@@ -27114,7 +27261,7 @@
Date: Tue Jul 17 19:09:03 2018 +0200
Remove TODO that is not gonna be done
-
+
Previously the idea was to cache sanitize results externally (think,
in Fontconfig) and avoid resanitizing every time. That's, not a good
idea.
@@ -27129,8 +27276,7 @@
Move sanitizer code around a bit
src/hb-aat-layout-common-private.hh | 4 +-
- src/hb-open-type-private.hh | 95
- ++++++++++++++++++++-----------------
+ src/hb-open-type-private.hh | 95 ++++++++++++++++++++-----------------
src/hb-ot-color-sbix-table.hh | 12 ++---
src/hb-ot-layout-common-private.hh | 3 --
4 files changed, 58 insertions(+), 56 deletions(-)
@@ -27140,12 +27286,10 @@
Date: Tue Jul 17 18:14:45 2018 +0200
[aat] Update for blob changes
+
+ Also, uncomment code again, just "if (0)" it out, so it doesn't get stale again.
- Also, uncomment code again, just "if (0)" it out, so it doesn't get
- stale again.
-
- src/hb-aat-layout.cc | 58
- ++-------------------------------------------
+ src/hb-aat-layout.cc | 58 ++-------------------------------------------
src/hb-open-type-private.hh | 27 +++++++++++++--------
src/hb-ot-layout-private.hh | 1 +
src/hb-ot-layout.cc | 2 ++
@@ -27168,7 +27312,7 @@
Date: Tue Jul 17 10:57:01 2018 +0200
Reland "Implement C++11-style GCC builtin atomic ops"
-
+
Fixed the crasher in it.
src/hb-atomic-private.hh | 22 +++++++++++++++++++---
@@ -27190,9 +27334,9 @@
Date: Tue Jul 17 10:50:01 2018 +0200
Revert "Implement C++11-style GCC builtin atomic ops"
-
+
This reverts commit 21fa170f0bfb0109c506ed17f5aff8b062564ffa.
-
+
Is crashing. Oops.
src/hb-atomic-private.hh | 22 +++-------------------
@@ -27204,7 +27348,7 @@
Date: Mon Jul 16 17:58:02 2018 +0200
Implement C++11-style GCC builtin atomic ops
-
+
Hopefully fixes bots.
src/hb-atomic-private.hh | 22 +++++++++++++++++++---
@@ -27225,7 +27369,7 @@
Date: Mon Jul 16 15:41:09 2018 +0200
Implement C++11 <atomic> operations
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/345
src/hb-atomic-private.hh | 27 ++++++++++++++++++++++++---
@@ -27239,7 +27383,7 @@
Date: Mon Jul 16 14:42:43 2018 +0200
Merge pull request #1094 from anthrotype/fix-appveyor-msys2
-
+
appveyor.yml: try updating msys2 to fix failing mingw-w64-x86_64 build
commit 269eb45650be66901627da7f1014339065a948a5
@@ -27246,9 +27390,8 @@
Author: Cosimo Lupo <cosimo at anthrotype.com>
Date: Mon Jul 16 14:14:42 2018 +0200
- appveyor.yml: try only updating msys2 core, not the rest of the
- packages
-
+ appveyor.yml: try only updating msys2 core, not the rest of the packages
+
maybe it'll get a bit faster
appveyor.yml | 1 -
@@ -27259,7 +27402,7 @@
Date: Mon Jul 16 12:57:27 2018 +0200
appveyor.yml: pass --needed option to pacman
-
+
so it won't attempt reinstalling packages which are already installed
appveyor.yml | 2 +-
@@ -27270,7 +27413,7 @@
Date: Mon Jul 16 12:41:59 2018 +0200
appveyor.yml: try updating msys2 to fix failing mingw-w64-x86_64 build
-
+
https://github.com/harfbuzz/harfbuzz/pull/1093#issuecomment-405201903
https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/job/ky7lao1ii1bi7ew4#L71
@@ -27282,7 +27425,7 @@
Date: Wed Jul 11 17:27:23 2018 +0200
Move _hb_alignof later again
-
+
It uses constexpr...
src/hb-private.hh | 26 +++++++++++++-------------
@@ -27304,8 +27447,7 @@
Align NullPool and CrapPool to HB_VECTOR_SIZE
src/hb-dsalgs.hh | 3 +--
- src/hb-private.hh | 64
- ++++++++++++++++++++++++++++++++-----------------------
+ src/hb-private.hh | 64 ++++++++++++++++++++++++++++++++-----------------------
src/hb-static.cc | 4 ++--
3 files changed, 40 insertions(+), 31 deletions(-)
@@ -27373,10 +27515,8 @@
Move more stuff from hb-private.hh to hb-dsalgs.hh
src/hb-debug.hh | 1 +
- src/hb-dsalgs.hh | 237
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
- src/hb-private.hh | 246
- +-----------------------------------------------------
+ src/hb-dsalgs.hh | 237 ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-private.hh | 246 +-----------------------------------------------------
3 files changed, 240 insertions(+), 244 deletions(-)
commit f477765661c196ac17b2c86731881a3da36a5ae6
@@ -27385,10 +27525,8 @@
Move more stuff to hb-dsalgs.hh
- src/hb-dsalgs.hh | 83
- +++++++++++++++++++++++++++++++++++++++++++++++++++++++
- src/hb-private.hh | 81
- -----------------------------------------------------
+ src/hb-dsalgs.hh | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-private.hh | 81 -----------------------------------------------------
2 files changed, 83 insertions(+), 81 deletions(-)
commit be7f664f723fb4e7bcf15c1c2b7c6bec46f90393
@@ -27470,10 +27608,8 @@
Move hb_vector_t and hb_lockable_set_t to hb-dsalgs.hh
- src/hb-dsalgs.hh | 311
- +++++++++++++++++++++++++++++++++++++++++++++++++++++
- src/hb-private.hh | 315
- ------------------------------------------------------
+ src/hb-dsalgs.hh | 311 +++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-private.hh | 315 ------------------------------------------------------
2 files changed, 311 insertions(+), 315 deletions(-)
commit 9e53b083295ad910a87e778ebd16cbe69ebe2130
@@ -27481,15 +27617,13 @@
Date: Tue Jul 10 14:03:58 2018 +0200
Move hb_stable_sort to hb-dsalgs.hh
-
+
Also, include hb-dsalgs.hh from end of hb-pricate.hh
- src/hb-dsalgs.hh | 51
- +++++++++++++++++++++++++++++++++++++++++
+ src/hb-dsalgs.hh | 51 +++++++++++++++++++++++++++++++++++++++++
src/hb-ot-os2-unicode-ranges.hh | 1 -
src/hb-ot-post-table.hh | 1 -
- src/hb-private.hh | 51
- ++---------------------------------------
+ src/hb-private.hh | 51 ++---------------------------------------
4 files changed, 53 insertions(+), 51 deletions(-)
commit 39f11d8e72c6b2568f3b70847c6c9d1f374cd49c
@@ -27506,7 +27640,7 @@
Date: Tue Jul 10 13:47:41 2018 +0200
Fix syntax
-
+
Oops.
src/hb-private.hh | 2 +-
@@ -27527,7 +27661,7 @@
Date: Tue Jul 10 13:16:52 2018 +0200
Always compile (but not use) alignof() and round() fallback codes
-
+
Catches compile-errors in them better.
src/hb-private.hh | 23 ++++++++++++-----------
@@ -27566,17 +27700,15 @@
Date: Mon Jul 9 20:24:22 2018 +0200
Merge pull request #1091 from anthrotype/fix-gen-def-py
+
+ gen-def.py: pass headers as arguments so that msys2 can convert posix paths
- gen-def.py: pass headers as arguments so that msys2 can convert
- posix paths
-
commit 53f73409a91241765ae6a0cadf7600676988b6af
Author: Cosimo Lupo <cosimo at anthrotype.com>
Date: Mon Jul 9 18:54:23 2018 +0100
- CMakeLists.txt: don't pass header args as single space-separated
- string
-
+ CMakeLists.txt: don't pass header args as single space-separated string
+
let python's parse command-line args as usual
CMakeLists.txt | 3 +--
@@ -27586,8 +27718,7 @@
Author: Cosimo Lupo <cosimo at anthrotype.com>
Date: Mon Jul 9 18:48:20 2018 +0100
- CMakeLists.txt: pass headers as arguments to gen-def.py; call using
- PYTHON_EXECUTABLE
+ CMakeLists.txt: pass headers as arguments to gen-def.py; call using PYTHON_EXECUTABLE
CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -27605,28 +27736,21 @@
Author: Cosimo Lupo <cosimo at anthrotype.com>
Date: Mon Jul 9 18:11:29 2018 +0100
- gen-def.py: pass headers as arguments so that msys2 can convert
- posix paths
-
- When one is not using the msys2 python, the header files that are
- passed in as environment
+ gen-def.py: pass headers as arguments so that msys2 can convert posix paths
+
+ When one is not using the msys2 python, the header files that are passed in as environment
variable cannot be found.
-
+
https://ci.appveyor.com/project/fonttools/ttfautohint-py/build/1.0.65/job/rkremny4jjid9nl2#L803
-
- This is because msys2 shell and make use POSIX paths
- (e.g. /c/Users/clupo/...)
- whereas non-msys2 python.exe uses native Windows paths
- (e.g. C:\Users\clupo\...).
-
- Msys2 will automatically convert command line arguments (but not
- environment variables) from
- POSIX to Windows paths when calling a native win32 executable,
- so we pass the header paths
+
+ This is because msys2 shell and make use POSIX paths (e.g. /c/Users/clupo/...)
+ whereas non-msys2 python.exe uses native Windows paths (e.g. C:\Users\clupo\...).
+
+ Msys2 will automatically convert command line arguments (but not environment variables) from
+ POSIX to Windows paths when calling a native win32 executable, so we pass the header paths
as arguments instead of environment variables.
-
- This way the gen-def.py script can support both mingw python running
- in an MSYS2 shell, and
+
+ This way the gen-def.py script can support both mingw python running in an MSYS2 shell, and
native win32 python.
src/gen-def.py | 12 +++++++++---
@@ -27637,7 +27761,7 @@
Date: Fri Jul 6 15:47:03 2018 -0400
Do not enforce a native direction of LTR for Runic
-
+
Fixes #481
src/hb-common.cc | 1 +
@@ -27648,7 +27772,7 @@
Date: Sat Jul 7 11:08:17 2018 -0400
Regenerate the USE table for Grantha and Bhaiksuki (#1090)
-
+
Completes #1037 and fixes #1035.
src/hb-ot-shape-complex-use-table.cc | 4 ++--
@@ -27659,11 +27783,11 @@
Date: Thu Jul 5 14:04:13 2018 +0430
Disable vectorization
-
+
Disable vectorization for now. To correctly use them, we should
use posix_memalign() to allocate them. Otherwise, can cause
misaligned access.
-
+
https://bugs.chromium.org/p/chromium/issues/detail?id=860184
src/hb-private.hh | 12 ++++++++++++
@@ -27674,11 +27798,9 @@
Date: Thu Jul 5 14:03:48 2018 +0430
Fix warning
+
+ ../../src/hb-ot-layout-gsubgpos-private.hh:391:18: warning: missed loop optimization, the loop counter may overflow [-Wunsafe-loop-optimizations]
- ../../src/hb-ot-layout-gsubgpos-private.hh:391:18: warning:
- missed loop optimization, the loop counter may overflow
- [-Wunsafe-loop-optimizations]
-
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -27705,31 +27827,24 @@
Date: Tue Jul 3 14:29:25 2018 +0430
[indic] Adjust left-matra repositioning and Halant,ZWJ sequence
-
+
From the new code (first paragraph is from the OT Devanagari spec.):
-
+
/* o Reorder matras:
*
- * If a pre-base matra character had been reordered before
- applying basic
- * features, the glyph can be moved closer to the main consonant
- based on
- * whether half-forms had been formed. Actual position for
- the matra is
- * defined as “after last standalone halant glyph, after
- initial matra
- * position and before the main consonant”. If ZWJ or ZWNJ
- follow this
+ * If a pre-base matra character had been reordered before applying basic
+ * features, the glyph can be moved closer to the main consonant based on
+ * whether half-forms had been formed. Actual position for the matra is
+ * defined as “after last standalone halant glyph, after initial matra
+ * position and before the main consonant”. If ZWJ or ZWNJ follow this
* halant, position is moved after it.
*
* IMPLEMENTATION NOTES:
*
- * It looks like the last sentence is wrong. Testing, with Windows
- 7 Uniscribe
+ * It looks like the last sentence is wrong. Testing, with Windows 7 Uniscribe
* and Devanagari shows that the behavior is best described as:
*
- * "If ZWJ follows this halant, matra is NOT repositioned after
- this halant.
+ * "If ZWJ follows this halant, matra is NOT repositioned after this halant.
* If ZWNJ follows this halant, position is moved after it."
*
* Test case, with Adobe Devanagari or Nirmala UI:
@@ -27739,13 +27854,12 @@
*
* U+091F,U+094D,U+200D,U+092F,U+093F
* (Matra does NOT move, stays to the left.)
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1070
-
+
Test case added with Adobe Devanagari.
- src/hb-ot-shape-complex-indic.cc | 37
- +++++++++++++++++++++
+ src/hb-ot-shape-complex-indic.cc | 37 +++++++++++++++++++++
.../8116e5d8fedfbec74e45dc350d2416d810bed8c4.ttf | Bin 0 -> 4364 bytes
.../data/in-house/tests/indic-joiners.tests | 4 +++
3 files changed, 41 insertions(+)
@@ -27775,11 +27889,11 @@
Date: Tue Jul 3 12:38:21 2018 +0430
Disable .dfont code for now
-
+
The get_table imple was wrong, as table offsets in a dfont are
relative to the resource. We were treating them as relative to
the big blob itself. To be fixed.
-
+
Part of https://github.com/harfbuzz/harfbuzz/pull/1085
src/hb-open-file-private.hh | 6 +++---
@@ -27790,7 +27904,7 @@
Date: Sun Jul 1 15:32:43 2018 +0430
Fix trak table apply logic
-
+
In collaboration with Behdad
src/hb-aat-layout-trak-table.hh | 4 ++--
@@ -27802,8 +27916,7 @@
Support dfont font files (#949)
- src/hb-open-file-private.hh | 196
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-open-file-private.hh | 196 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-open-type-private.hh | 1 +
src/main.cc | 3 +
3 files changed, 200 insertions(+)
@@ -27812,8 +27925,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Sun Jul 1 01:54:14 2018 +0430
- Improve nommap naming and use C style comments on create_from_file
- (#1084)
+ Improve nommap naming and use C style comments on create_from_file (#1084)
.circleci/config.yml | 2 +-
src/hb-blob.cc | 16 ++++++++--------
@@ -27824,23 +27936,19 @@
Date: Sat Jun 30 15:59:25 2018 +0430
Adjust MarkBasePos heuristic in presence of MultipleSubst
-
+
From the issue:
- "In this font, the virama,ya first forms a ligature, then decomposes
- back to
+ "In this font, the virama,ya first forms a ligature, then decomposes back to
virama,ya. This causes those two to be marked parts of a MultipleSubst
- sequence. When attaching the matra, we look for the first of the
- MultipleSubst
- sequence because that's where we attach to (because of eg #740). In
- this case,
- the first glyph in the MultipleSubst sequence is a mark, so we skip
- it and
+ sequence. When attaching the matra, we look for the first of the MultipleSubst
+ sequence because that's where we attach to (because of eg #740). In this case,
+ the first glyph in the MultipleSubst sequence is a mark, so we skip it and
attach to the base char before it."
-
+
Font in question is Nirmala UI from Windows 10. Test sequence:
-
+
U+0926,U+094D,U+092F,U+0941
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1020
src/hb-ot-layout-gpos-table.hh | 5 ++++-
@@ -27851,7 +27959,7 @@
Date: Sat Jun 30 12:28:03 2018 +0430
[indic] Tweak for old-spec Bengali and halant-ya-halant
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1073
src/hb-ot-shape-complex-indic.cc | 13 ++++++++++---
@@ -27861,8 +27969,7 @@
Author: punchcutter <zarijoscha at gmail.com>
Date: Sun Jun 24 22:54:57 2018 -0700
- Rebase and update USE overrides for Bhaiksuki Gap Fillers and
- Grantha Anusvara
+ Rebase and update USE overrides for Bhaiksuki Gap Fillers and Grantha Anusvara
src/gen-use-table.py | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
@@ -27872,10 +27979,10 @@
Date: Sat Jun 30 09:16:54 2018 +0430
[khmer] Fix infinite-loop in cluster merging
-
+
Indic shaper already had this check. We removed it when forking
Khmer shaper by mistake.
-
+
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1464623
src/hb-ot-shape-complex-khmer.cc | 31 +++++++++++++++++--------------
@@ -27886,7 +27993,7 @@
Date: Thu Jun 28 14:32:36 2018 +0430
armcc compatibility, don't use EINTR if doesn't exist
-
+
Fixes #1081
src/hb-blob.cc | 2 ++
@@ -27897,7 +28004,7 @@
Date: Thu Jun 28 13:22:21 2018 +0430
Minor on hb_blob_create_from_file, reuse ferror result
-
+
Oops
src/hb-blob.cc | 2 +-
@@ -27926,7 +28033,7 @@
Date: Wed Jun 27 14:13:26 2018 +0430
Minor touches on hb_blob_create_from_file (#1079)
-
+
* Handle EINTR on fallback reader
* Increase fallback reader limitation size limitation to 2 << 28
* Ensure _O_BINARY does exist if MMAP is used on Windows
@@ -27940,7 +28047,7 @@
Date: Tue Jun 26 18:00:58 2018 -0400
Make round() fallback portable to systems that do have round()
-
+
Makes compiling without HAVE_ROUND on systems that do have it work.
src/hb-private.hh | 3 ++-
@@ -27951,10 +28058,9 @@
Date: Tue Jun 26 10:46:10 2018 +0430
Minor on hb_blob_create_from_file
+
+ Add one more "unlikely" annotation and use explicit nullptr check for more consistency.
- Add one more "unlikely" annotation and use explicit nullptr check
- for more consistency.
-
src/hb-blob.cc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -27964,8 +28070,7 @@
[subset] Add fuzzer test case that caused a timeout to the corpus.
- ...testcase-minimized-hb-subset-fuzzer-5750092395970560 | Bin 0 ->
- 72435 bytes
+ ...testcase-minimized-hb-subset-fuzzer-5750092395970560 | Bin 0 -> 72435 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 35ce8f31d37cf7c2a1f8265d36ba4c2c9a3efb2c
@@ -27973,15 +28078,13 @@
Date: Mon Jun 25 22:23:43 2018 +0430
Unify our pipe reader with the fallback reader (#1068)
-
- And assign one bot to use the path always using NOMMAPFILEREADER
- token.
-
+
+ And assign one bot to use the path always using NOMMAPFILEREADER token.
+
It's limited to 200mb so no more fun with using /dev/zero on hb-view!
.circleci/config.yml | 6 +-
- src/hb-blob.cc | 152
- ++++++++++++++++++++++-----------------------------
+ src/hb-blob.cc | 152 ++++++++++++++++++++++-----------------------------
2 files changed, 68 insertions(+), 90 deletions(-)
commit f57804a8a596e88843ddc8b88afac7526349b89b
@@ -27990,8 +28093,7 @@
Resolve ttx absolute path before use (#1075)
- test/subset/run-tests.py | 101
- ++++++++++++++++++++++++++---------------------
+ test/subset/run-tests.py | 101 ++++++++++++++++++++++++++---------------------
1 file changed, 57 insertions(+), 44 deletions(-)
commit 159ddb872986f121818e816d2ea75d271075ba1f
@@ -28008,10 +28110,10 @@
Date: Sat Jun 23 10:32:28 2018 -0400
In Coverage iterator, bail out if table smells
-
+
In particular, if CoverageFormat2 has unsorted ranges, bail out.
Otherwise, 64k ranges of each 64k glyphs can DoS closure() method.
-
+
We can do the same for CoverageFormat1, but that one does not expose
the quadratic behavior, so, fine.
@@ -28023,17 +28125,14 @@
Date: Mon Jun 18 20:35:40 2018 +0430
Support pipe and friends on hb_blob_create_from_file (#1061)
-
- With this hb-view/hb-shape support pipes and possibly socket and
- named pipe
+
+ With this hb-view/hb-shape support pipes and possibly socket and named pipe
also, anything fails just on mmap.
-
+
We can later do the same for Windows also.
-
- This however reveals two issues, the fact most of our bots don't
- have HAVE_MMAP and using
- this instead the other fread/fopen reader can make failure on CI. I
- should look at them separately
+
+ This however reveals two issues, the fact most of our bots don't have HAVE_MMAP and using
+ this instead the other fread/fopen reader can make failure on CI. I should look at them separately
this change however is very low risk I believe.
src/hb-blob.cc | 44 +++++++++++++++++++++++++++++++++++++++++++-
@@ -28044,12 +28143,9 @@
Date: Mon Jun 18 19:59:33 2018 +0430
Revert file blob sanitization and index checking (#1062)
-
- As
- https://github.com/harfbuzz/harfbuzz/pull/1059#issuecomment-397912812
- we
- like to still work with blobs that harfbuzz itself can't handle
- directly that are failing sanitization
+
+ As https://github.com/harfbuzz/harfbuzz/pull/1059#issuecomment-397912812 we
+ like to still work with blobs that harfbuzz itself can't handle directly that are failing sanitization
currently apparently.
util/options.cc | 12 ++----------
@@ -28060,9 +28156,8 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Sun Jun 17 17:04:55 2018 +0430
- Verbose fail when something is wrong with hb-shape/hb-view input
- font file (#1059)
-
+ Verbose fail when something is wrong with hb-shape/hb-view input font file (#1059)
+
This checks if the blob isn't empty and uses `hb_face_count`
to see if the font file passes the simple font file sanitization
so can detect if the input is actually a font and checks also
@@ -28076,20 +28171,20 @@
Date: Sun Jun 17 16:49:34 2018 +0430
Fix reading fonts from stdin (#1060)
-
+
We were passing the font path directly to freetype so rendering
was broken when we are getting the font from stdin.
-
+
This fixes it by using FT_New_Memory_Face instead.
-
+
This fixes:
* build/util/hb-view /dev/stdin text < font.ttf
* build/util/hb-view - text < font.ttf
* cat font.ttf | build/util/hb-view - text
-
+
but doesn't work on
* cat font.ttf | build/util/hb-view /dev/stdin text
-
+
which I will try to fix separately.
util/helper-cairo.cc | 14 ++++++++++----
@@ -28123,12 +28218,11 @@
Date: Tue Jun 12 19:20:20 2018 -0400
Move hb-version.h generation to Makefile
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/864
+
+ Unfortunately 1.7.7 and 1.8.0 went out with the wrong hb-version.h contents.
- Unfortunately 1.7.7 and 1.8.0 went out with the wrong hb-version.h
- contents.
-
configure.ac | 1 -
src/Makefile.am | 21 ++++++++++++++++-----
src/hb-version.h | 6 +++---
@@ -28139,7 +28233,7 @@
Date: Tue Jun 12 18:24:54 2018 -0400
[subset] Remove HB_SUBSET_BUILTIN
-
+
Just include hb-static.cc in libharfbuzz-subset.so source list as
well. Those building it built-in will include hb-static.cc once
already. No need for any gymnastics.
@@ -28208,7 +28302,7 @@
Date: Mon Jun 11 20:55:14 2018 -0700
[hb-set] Don't shrink vectors until after processing their contents.
-
+
Fixes #1054.
src/hb-set-private.hh | 10 +++++++---
@@ -28219,10 +28313,9 @@
Date: Mon Jun 11 03:47:43 2018 +0430
Fetch the updated dwrite_1.h header from a better place
+
+ Following to https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/1.0.1693/job/mfkjdhcdykjuqdfc
- Following to
- https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/1.0.1693/job/mfkjdhcdykjuqdfc
-
appveyor.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -28231,7 +28324,7 @@
Date: Sun Jun 10 17:22:38 2018 -0400
More fixes for SunStudio 12.6 build
-
+
Followup to https://github.com/harfbuzz/harfbuzz/pull/1053
src/hb-ft.cc | 8 ++++----
@@ -28275,8 +28368,7 @@
test/api/fonts/Roboto-Regular.gsub.fi.ttf | Bin 0 -> 2652 bytes
test/api/fonts/Roboto-Regular.gsub.fil.ttf | Bin 0 -> 3228 bytes
test/api/fonts/Roboto-Regular.nogsub.fi.ttf | Bin 0 -> 1856 bytes
- test/api/test-subset-glyf.c | 52
- ++++++++++++++++++++++++++++
+ test/api/test-subset-glyf.c | 52 ++++++++++++++++++++++++++++
4 files changed, 52 insertions(+)
commit 37eab27be3b88079614f66e484c700bb2d40af10
@@ -28316,8 +28408,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Jun 6 16:02:51 2018 -0700
- [subset] add a new closure call to hb-ot-layout that can compute
- the closure over multiple lookups.
+ [subset] add a new closure call to hb-ot-layout that can compute the closure over multiple lookups.
src/hb-ot-layout.cc | 26 ++++++++++++++++++++++++++
src/hb-ot-layout.h | 6 ++++++
@@ -28329,7 +28420,7 @@
Date: Wed Jun 6 16:46:50 2018 -0700
[set] Add is_subset
-
+
New API:
+hb_set_is_subset()
@@ -28365,7 +28456,7 @@
Date: Wed Jun 6 15:23:35 2018 -0700
Compiler gymnastics
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/630
src/hb-private.hh | 3 +++
@@ -28376,18 +28467,15 @@
Date: Wed Jun 6 14:55:30 2018 -0700
Move prime_for back into map
-
- This was causing problem on systems without visibility when map
- was used
+
+ This was causing problem on systems without visibility when map was used
from both libharfbuzz and libharfbuzz-subset. Sigh.
-
+
https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/1.0.1669/job/dey47nmff0770vp3
- src/hb-map-private.hh | 53
- ++++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-map-private.hh | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++-
src/hb-private.hh | 3 ---
- src/hb-static.cc | 51
- -------------------------------------------------
+ src/hb-static.cc | 51 -------------------------------------------------
3 files changed, 52 insertions(+), 55 deletions(-)
commit a2a1484ef93d5b5c3748b15219eca669d866b0a9
@@ -28395,9 +28483,8 @@
Date: Wed Jun 6 12:57:28 2018 -0400
Convert Consonant_Initial_Postfixed to CONS_FINAL
-
- Consonant_Initial_Postfixed was split off of
- Consonant_Succeeding_Repha,
+
+ Consonant_Initial_Postfixed was split off of Consonant_Succeeding_Repha,
so it should correspond to the same USE class, CONS_FINAL.
src/gen-use-table.py | 5 +++--
@@ -28419,12 +28506,11 @@
Date: Tue Jun 5 17:59:31 2018 -0700
[ucdn] Update to Unicode 11
-
+
https://github.com/grigorig/ucdn/issues/19
src/hb-ucdn.cc | 7 +
- src/hb-ucdn/ucdn_db.h | 2754
- ++++++++++++++++++++++++++-----------------------
+ src/hb-ucdn/ucdn_db.h | 2754 ++++++++++++++++++++++++++-----------------------
2 files changed, 1479 insertions(+), 1282 deletions(-)
commit 060e6b4a13a4224de885214d374b079610224123
@@ -28432,7 +28518,7 @@
Date: Tue Jun 5 17:31:46 2018 -0700
Update to Unicode 11.0.0
-
+
UCDN is not updated yet.
src/gen-use-table.py | 13 +++--
@@ -28442,8 +28528,7 @@
src/hb-ot-shape-complex-indic-table.cc | 77 ++++++++++++++-------------
src/hb-ot-shape-complex-private.hh | 9 ++++
src/hb-ot-shape-complex-use-machine.rl | 2 +-
- src/hb-ot-shape-complex-use-table.cc | 94
- +++++++++++++++++++++------------
+ src/hb-ot-shape-complex-use-table.cc | 94 +++++++++++++++++++++------------
8 files changed, 170 insertions(+), 84 deletions(-)
commit 105a3b5e2d2ff228cdc1fbe8618f6c8fdfdabe9e
@@ -28484,7 +28569,7 @@
Date: Mon Jun 4 16:47:45 2018 -0700
[khmer] Fix Coeng vs Halant confusion
-
+
Test suite results are unchanged (34).
src/hb-ot-shape-complex-khmer.cc | 6 +++---
@@ -28495,7 +28580,7 @@
Date: Tue Jun 5 22:50:53 2018 +0430
Fix hb_face_count build issue
-
+
I should've rebased #1002 before the merge, my bad
src/hb-face.cc | 2 +-
@@ -28506,16 +28591,15 @@
Date: Tue Jun 5 18:56:26 2018 +0430
Add hb_face_count, a new API (#1002)
-
+
Simply, it returns the number of faces on a font blob.
-
+
To be used on hb-sanitizer tool but other clients also
can benefit from it.
TODO | 2 -
docs/harfbuzz-sections.txt | 1 +
- src/hb-face.cc | 95
- ++++++++++++++++++++++++++++------------------
+ src/hb-face.cc | 95 ++++++++++++++++++++++++++++------------------
src/hb-face.h | 4 ++
4 files changed, 64 insertions(+), 38 deletions(-)
@@ -28524,17 +28608,16 @@
Date: Mon Jun 4 15:40:43 2018 -0700
[sinhala] Move reph to after post-consonants
-
+
Apparently this changed between Win 7 and Win 10.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/967
-
+
To be continued in https://github.com/harfbuzz/harfbuzz/issues/1044
src/hb-ot-shape-complex-indic.cc | 2 +-
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/5af5361ed4d1e8305780b100e1730cb09132f8d1.ttf | Bin 0 ->
- 3152 bytes
+ .../fonts/5af5361ed4d1e8305780b100e1730cb09132f8d1.ttf | Bin 0 -> 3152 bytes
test/shaping/data/in-house/tests/sinhala.tests | 1 +
4 files changed, 3 insertions(+), 1 deletion(-)
@@ -28543,7 +28626,7 @@
Date: Mon Jun 4 15:38:05 2018 -0700
[test] Fix record-test to use gids not glyph-names
-
+
as those might not match what FontTools think of the glyphs if font
does NOT have glyph names.
@@ -28555,11 +28638,10 @@
Date: Sat Jun 2 20:30:09 2018 -0700
Remove DISALLOW_* from vector, set, and map
-
- Some of the build bots, still fail on this. I suppose mine pass
- because
+
+ Some of the build bots, still fail on this. I suppose mine pass because
I enable C++11...
-
+
Anyway, remove these again.
src/hb-map-private.hh | 3 ---
@@ -28573,7 +28655,7 @@
Date: Sat Jun 2 15:30:59 2018 -0700
Fix fallout from 975bdd5ef562e37655067b703b2b9ca7481f4985
-
+
Ouch!
src/hb-ot-map-private.hh | 40 ++++++++++++++++++++++------------------
@@ -28624,7 +28706,7 @@
Date: Fri Jun 1 17:32:07 2018 -0700
Another attempt at making every compiler happy...
-
+
Sigh.
src/hb-private.hh | 6 +++---
@@ -28636,11 +28718,9 @@
[map] Move prime_for to hb-static
- src/hb-map-private.hh | 53
- +--------------------------------------------------
+ src/hb-map-private.hh | 53 +--------------------------------------------------
src/hb-private.hh | 2 ++
- src/hb-static.cc | 51
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-static.cc | 51 +++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 54 insertions(+), 52 deletions(-)
commit 33d6f46bbbb4fdee110f1cb024a37ed2e46e5e22
@@ -28666,11 +28746,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu May 31 16:47:39 2018 -0700
- [subset] Have the subset fuzzer pull the text string to subset to
- from the end of the fuzzer provided data.
+ [subset] Have the subset fuzzer pull the text string to subset to from the end of the fuzzer provided data.
- test/fuzzing/hb-subset-fuzzer.cc | 54
- +++++++++++++++++++++++++---------------
+ test/fuzzing/hb-subset-fuzzer.cc | 54 +++++++++++++++++++++++++---------------
1 file changed, 34 insertions(+), 20 deletions(-)
commit bb6f4adac70a161505953414aa85ba78cd993c65
@@ -28687,9 +28765,9 @@
Date: Fri Jun 1 16:07:55 2018 -0700
Revert "Remove HB_DISALLOW_COPY_AND_ASSIGN"
-
+
This reverts commit ff92de766bf775bfdd3a01bda94de699180ff86a.
-
+
Revert that and remove ASSERT_POD. Let's see which bots are
unhappy with this configuration...
@@ -28724,11 +28802,10 @@
Date: Thu May 31 20:03:00 2018 -0700
Rename in_error to !successful
-
+
Towards possibly using Null pool for some nil objects.
- src/hb-buffer-deserialize-json.hh | 758
- +++++++++++++++++------------------
+ src/hb-buffer-deserialize-json.hh | 758 +++++++++++++++++------------------
src/hb-buffer-deserialize-json.rl | 2 +-
src/hb-buffer-deserialize-text.hh | 510 +++++++++++------------
src/hb-buffer-deserialize-text.rl | 2 +-
@@ -28755,7 +28832,7 @@
Date: Thu May 31 19:52:16 2018 -0700
Fix a whitespace inconsistency
-
+
Null() and Crap() are only places that there's no space before '('...
src/dump-fon.cc | 12 ++++++------
@@ -28778,7 +28855,7 @@
Date: Thu May 31 19:28:04 2018 -0700
Use 0 as inert object reference value instead of -1
-
+
Towards using Null object for nil objects.
src/hb-object-private.hh | 2 +-
@@ -28789,7 +28866,7 @@
Date: Thu May 31 17:58:40 2018 -0700
Add const OffsetTo<> dereference
-
+
Unused, but now that we have CrapPool, implement it.
src/hb-open-type-private.hh | 6 ++++++
@@ -28800,13 +28877,11 @@
Date: Thu May 31 12:27:31 2018 +0430
Fix symbol export issue of prime_mod on Alpine bot
-
- Apparently our gcc-6.4.0 on Alpine Linux distribution doesn't like
- defining static const
+
+ Apparently our gcc-6.4.0 on Alpine Linux distribution doesn't like defining static const
inside a method, lets put that on outside the classes.
- src/hb-map-private.hh | 89
- ++++++++++++++++++++++++++-------------------------
+ src/hb-map-private.hh | 89 ++++++++++++++++++++++++++-------------------------
1 file changed, 45 insertions(+), 44 deletions(-)
commit 54800f8322e8ab106d801fc332b7e813c58138ac
@@ -28814,7 +28889,7 @@
Date: Wed May 30 16:26:50 2018 -0700
[map] Mark prime_for HB_INTERNAL
-
+
Trying to see if it fixes gcc-4.2 bots.
src/hb-map-private.hh | 2 +-
@@ -28843,8 +28918,7 @@
src/hb-ot-os2-table.hh | 35 +++--------
src/hb-ot-post-table.hh | 2 +-
src/hb-subset-glyf.cc | 9 ++-
- src/hb-subset-plan.cc | 159
- ++++++++++++++++--------------------------------
+ src/hb-subset-plan.cc | 159 ++++++++++++++++--------------------------------
src/hb-subset-plan.hh | 68 +++++++++++++--------
src/hb-subset.cc | 2 +-
11 files changed, 139 insertions(+), 188 deletions(-)
@@ -28854,7 +28928,7 @@
Date: Wed May 30 14:02:49 2018 -0700
[map] Fix size calculation
-
+
Don't know why I thought I should subtract one there...
src/hb-map-private.hh | 2 +-
@@ -28865,15 +28939,11 @@
Date: Tue May 29 18:48:45 2018 -0700
Remove HB_DISALLOW_COPY_AND_ASSIGN
-
+
llvm-gcc-4.2 bot had this problem:
- hb-private.hh:812: error: initializer specified for non-virtual method
- 'void hb_vector_t<Type, StaticSize>::operator=(const hb_vector_t<Type,
- StaticSize>&) [with Type = hb_user_data_array_t::hb_user_data_item_t,
- unsigned int StaticSize = 1u]'
-
- Removing the delete didn't work with a constructor. So, remove
- constructor.
+ hb-private.hh:812: error: initializer specified for non-virtual method 'void hb_vector_t<Type, StaticSize>::operator=(const hb_vector_t<Type, StaticSize>&) [with Type = hb_user_data_array_t::hb_user_data_item_t, unsigned int StaticSize = 1u]'
+
+ Removing the delete didn't work with a constructor. So, remove constructor.
Just disallow assignment. Still better than nothing.
src/hb-map-private.hh | 2 +-
@@ -28896,13 +28966,11 @@
Date: Tue May 29 18:21:55 2018 -0700
Disable use of thread_local
-
+
Clang build was failing with:
-
- /usr/bin/ld: .libs/libharfbuzz_la-hb-blob.o: relocation R_X86_64_PC32
- against undefined hidden symbol `_ZTH12_hb_CrapPool' can not be used
- when making a shared object
-
+
+ /usr/bin/ld: .libs/libharfbuzz_la-hb-blob.o: relocation R_X86_64_PC32 against undefined hidden symbol `_ZTH12_hb_CrapPool' can not be used when making a shared object
+
Instead of fighting it, just disable use of it.
src/hb-private.hh | 4 ++--
@@ -28924,10 +28992,8 @@
[map] Move prime_mod to header to avoid linkage issues in subset.so
- src/hb-map-private.hh | 53
- +++++++++++++++++++++++++++++++++++++++++++++++++--
- src/hb-map.cc | 52
- --------------------------------------------------
+ src/hb-map-private.hh | 53 +++++++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-map.cc | 52 --------------------------------------------------
2 files changed, 51 insertions(+), 54 deletions(-)
commit 6baebc5d559e15c7903a81f21be08b45537e7903
@@ -29029,7 +29095,7 @@
Date: Tue May 29 16:45:06 2018 -0700
Revert "[map] Return bool from set()"
-
+
This reverts commit face7cf55d4895ffca314c8448c0a749a26cc182.
src/hb-map-private.hh | 7 +++----
@@ -29040,7 +29106,7 @@
Date: Tue May 29 16:44:55 2018 -0700
Revert "[map] Make hb_map_set() return bool"
-
+
This reverts commit 7bf1980146cfc081b06264ac367b23ae9397adf1.
src/hb-map.cc | 4 ++--
@@ -29080,13 +29146,12 @@
Date: Tue May 29 16:28:48 2018 -0700
[map] First try at implementing an integer-to-integer hashmap
-
+
Fully untested.
src/Makefile.sources | 3 +
src/hb-map-private.hh | 180 ++++++++++++++++++++++++++++++++
- src/hb-map.cc | 279
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-map.cc | 279 ++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-map.h | 110 ++++++++++++++++++++
src/hb.h | 1 +
5 files changed, 573 insertions(+)
@@ -29096,7 +29161,7 @@
Date: Sat May 26 23:50:10 2018 +0430
[blob] Use MAP_NORESERVE if available (#1039)
-
+
MAP_NORESERVE is not available on macOS for example so set the flag
to zero if not defined on the headers.
@@ -29145,10 +29210,9 @@
Date: Thu May 24 14:09:04 2018 -0700
Fix Uniscribe build
-
+
If a pointer type was passed to Null(), reinterpret_cast<> was
- complaining about qualifiers being removed. Turns out I need the
- const on
+ complaining about qualifiers being removed. Turns out I need the const on
the other side of "Type" to fix that. Also remove unused const from
NullPool type.
@@ -29174,7 +29238,7 @@
Date: Thu May 24 11:46:57 2018 -0700
Mark CrapPool thread_local
-
+
Not sure if I like to keep it. For now, aim for correctness.
src/dump-emoji.cc | 2 +-
@@ -29190,7 +29254,7 @@
Date: Thu May 24 11:33:15 2018 -0700
Add CrapPool
-
+
Common Regoin for Access Protection. Like the NullPool, but writable.
src/dump-emoji.cc | 1 +
@@ -29208,8 +29272,7 @@
Move code around
- src/hb-private.hh | 91
- ++++++++++++++++++++++++++++++-------------------------
+ src/hb-private.hh | 91 ++++++++++++++++++++++++++++++-------------------------
1 file changed, 49 insertions(+), 42 deletions(-)
commit 65aeabd62275b37c6bb6715f3341e45625f4ba6e
@@ -29217,7 +29280,7 @@
Date: Wed May 23 16:15:28 2018 -0700
Add hb_vector_t::push(const Type &v)
-
+
Makes for cleaner code.
src/hb-coretext.cc | 3 +--
@@ -29232,10 +29295,9 @@
Date: Wed May 23 13:37:57 2018 +0430
[ci] Revive the SunCC bot
-
+
* Adds libnsl to the bot as it is now needed apparently
- * Disables hb-icu, apparently the newer ICU itself is not compatible
- with SunCC
+ * Disables hb-icu, apparently the newer ICU itself is not compatible with SunCC
.circleci/config.yml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -29245,7 +29307,7 @@
Date: Tue May 22 22:00:05 2018 -0700
Actually enable vectorized operations
-
+
Fixup for previous commit. Was accidentally turned off.
src/hb-private.hh | 2 +-
@@ -29256,7 +29318,7 @@
Date: Tue May 22 21:36:07 2018 -0700
Another try at smart vectorization
-
+
Make clang happy. Also, don't use anonymous union.
src/hb-private.hh | 36 +++++++++++++++++++++++++-----------
@@ -29267,7 +29329,7 @@
Date: Tue May 22 21:06:22 2018 -0700
Try enabling vectorization smartly
-
+
We'll see if this sticks to the bots.
src/hb-private.hh | 25 +++++++++++++++++--------
@@ -29291,12 +29353,9 @@
test/shaping/data/text-rendering-tests/DISABLED | 2 ++
test/shaping/data/text-rendering-tests/Makefile.sources | 2 ++
- .../text-rendering-tests/fonts/TestMORXTwentyeight.ttf | Bin 0 ->
- 2660 bytes
- .../text-rendering-tests/fonts/TestMORXTwentyseven.ttf | Bin 0 ->
- 2432 bytes
- .../data/text-rendering-tests/fonts/TestShapeKndaV3.ttf | Bin 0 ->
- 89400 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentyeight.ttf | Bin 0 -> 2660 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentyseven.ttf | Bin 0 -> 2432 bytes
+ .../data/text-rendering-tests/fonts/TestShapeKndaV3.ttf | Bin 0 -> 89400 bytes
.../data/text-rendering-tests/tests/MORX-27.tests | 3 +++
.../data/text-rendering-tests/tests/MORX-28.tests | 5 +++++
7 files changed, 12 insertions(+)
@@ -29306,11 +29365,9 @@
Date: Fri May 11 22:44:44 2018 +0430
Minor, make CreateFile compatible with the disabled writable flag
-
- "writable" is not in use and probably we can go in the reverse
- direction
- and remove the flags that are useful for enabled writable, this
- is just
+
+ "writable" is not in use and probably we can go in the reverse direction
+ and remove the flags that are useful for enabled writable, this is just
for the sake of completeness however.
src/hb-blob.cc | 5 +++--
@@ -29321,7 +29378,7 @@
Date: Fri May 11 14:36:41 2018 +0430
Remove unnecessary headers and definitions of hb-blob (#1028)
-
+
It removes io.h and other polyfills which we no longer need as 7e76d74
src/hb-blob.cc | 22 ++++------------------
@@ -29332,24 +29389,23 @@
Date: Fri May 11 13:40:33 2018 +0430
Make hb_blob_create_from_file more portable (#1027)
-
+
This makes it compatible with ARMCC which I had access in
a collaboration with @imgtec, thanks!
-
+
Basically hb_blob_create_from_file features three code paths,
mmap, Win32 and fallback.
-
+
We had fallback implementation even before this but it was relied
to "open" which is not available on some environments. This change
improved the situtation by using only fopen and friends for
fallback path.
-
+
Interestingly we could use "open" on Windows but in fact it was
emulated by MSVCRT so I've completely split that from Unix path
now that we have a distinct path for fallback path also.
- src/hb-blob.cc | 64
- +++++++++++++++++++++++++++++++++++++++-------------------
+ src/hb-blob.cc | 64 +++++++++++++++++++++++++++++++++++++++-------------------
1 file changed, 43 insertions(+), 21 deletions(-)
commit e99d75ea9c4fe1f64d7f8408093741a682ed5243
@@ -29366,7 +29422,7 @@
Date: Wed May 9 15:27:17 2018 -0700
Reinstante DEFINE_NULL_DATA
-
+
Seems like I messed up; buffer overrun got reported.
src/hb-open-type-private.hh | 2 ++
@@ -29378,9 +29434,8 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Wed May 9 23:24:17 2018 +0430
- Use arrayZ on hb-coretext and hb-uniscribe and fix macOS/Win bots
- (#1024)
-
+ Use arrayZ on hb-coretext and hb-uniscribe and fix macOS/Win bots (#1024)
+
Following to 63f57f4
src/hb-coretext.cc | 2 +-
@@ -29402,8 +29457,7 @@
src/hb-ot-color-cbdt-table.hh | 10 +++---
src/hb-ot-layout-common-private.hh | 12 +++----
src/hb-ot-layout-gsub-table.hh | 16 ++++-----
- src/hb-ot-layout-gsubgpos-private.hh | 64
- ++++++++++++++++++------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 64 ++++++++++++++++++------------------
src/hb-ot-post-table.hh | 4 +--
src/hb-ot-var-avar-table.hh | 26 +++++++--------
src/hb-private.hh | 54 +++++++++++++++---------------
@@ -29416,7 +29470,7 @@
Date: Tue May 8 16:42:45 2018 -0700
Use UnsizedArrayOf<> in one place where [VAR] was used
-
+
Trying to see how many can converted meaningfully.
src/hb-ot-layout-common-private.hh | 10 +++++-----
@@ -29428,7 +29482,7 @@
Date: Tue May 8 15:21:09 2018 -0700
Merge pull request #1018 from googlefonts/cmap4
-
+
[subset] Add cmap format 4 subsetting.
commit 2a2e28e701319b4053a5c95f06c68f859e4ce99b
@@ -29466,8 +29520,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue May 8 02:47:42 2018 -0700
- Always lock blob in sanitize. Remove blob->lock_as() in favor of
- blob->lock()
+ Always lock blob in sanitize. Remove blob->lock_as() in favor of blob->lock()
src/dump-emoji.cc | 4 ++--
src/dump-fon.cc | 2 +-
@@ -29522,8 +29575,7 @@
src/dump-emoji.cc | 6 ++---
src/dump-fon.cc | 14 +++++------
src/hb-aat-layout.cc | 8 +++----
- src/hb-open-type-private.hh | 48
- +++-----------------------------------
+ src/hb-open-type-private.hh | 48 +++-----------------------------------
src/hb-ot-cmap-table.hh | 4 ++--
src/hb-ot-color.cc | 4 ++--
src/hb-ot-layout-common-private.hh | 13 ++++++++---
@@ -29560,9 +29612,8 @@
Date: Tue May 8 01:47:05 2018 -0700
Allocate user-data-array on the heap
-
- This saves each object allocation 72 bytes. Now object overhead
- is just
+
+ This saves each object allocation 72 bytes. Now object overhead is just
16 bytes (on x86) instead of 88 bytes. Neat.
src/hb-object-private.hh | 36 ++++++++++++++++++++++++++++--------
@@ -29573,11 +29624,10 @@
Date: Tue May 8 01:28:19 2018 -0700
Oops
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1023
- src/hb-blob-private.hh | 77
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-blob-private.hh | 77 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
commit f673cfbd64d0c9d97123500a7b851b9cfc09deb3
@@ -29585,9 +29635,9 @@
Date: Mon May 7 13:58:32 2018 -0700
Support scripts that are written both LTR and RTL
-
+
Right now only Old Italic is marked as such.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/1000
src/hb-buffer.cc | 4 ++++
@@ -29595,8 +29645,7 @@
src/hb-ot-shape.cc | 7 +++++--
test/api/test-common.c | 1 +
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/73e84dac2fc6a2d1bc9250d1414353661088937d.ttf | Bin 0 ->
- 1136 bytes
+ .../fonts/73e84dac2fc6a2d1bc9250d1414353661088937d.ttf | Bin 0 -> 1136 bytes
test/shaping/data/in-house/tests/none-directional.tests | 3 +++
7 files changed, 20 insertions(+), 2 deletions(-)
@@ -29615,8 +29664,7 @@
Move some blob functions to methods
- src/hb-blob.cc | 80
- +++++++++++++++++++++++++---------------------------------
+ src/hb-blob.cc | 80 +++++++++++++++++++++++++---------------------------------
1 file changed, 34 insertions(+), 46 deletions(-)
commit 5c64d61475f15d7f8de8993a52639735b2bcf750
@@ -29624,7 +29672,7 @@
Date: Thu May 3 21:10:57 2018 -0400
Add hb-blob-private.hh
-
+
Towards making blob more memory-allocation-friendly
src/Makefile.sources | 1 +
@@ -29636,10 +29684,9 @@
Date: Thu May 3 21:03:27 2018 -0400
[ot-layout] Remove unused members
+
+ We should hang those off somewhere else. For now, the unused ones can go.
- We should hang those off somewhere else. For now, the unused ones
- can go.
-
src/hb-aat-layout-common-private.hh | 2 +-
src/hb-aat-layout.cc | 6 ++++++
src/hb-ot-layout-private.hh | 6 ------
@@ -29651,10 +29698,9 @@
Date: Tue May 8 01:05:15 2018 +0430
Set inline hidden flag only on shared library building
+
+ To avoid need of CMP0063 which is not available on older CMake versions
- To avoid need of CMP0063 which is not available on older CMake
- versions
-
CMakeLists.txt | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
@@ -29680,8 +29726,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu May 3 13:00:19 2018 -0700
- [subset] Switch to a non-log using implementation of caculating
- searchRangeZ, entrySelectorZ, and rangeShiftZ in cmap4.
+ [subset] Switch to a non-log using implementation of caculating searchRangeZ, entrySelectorZ, and rangeShiftZ in cmap4.
src/hb-ot-cmap-table.hh | 12 +++++-------
1 file changed, 5 insertions(+), 7 deletions(-)
@@ -29690,31 +29735,19 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu May 3 11:22:51 2018 -0700
- [subset] Updated expected files for japanese subset integration
- tests to include cmap4.
+ [subset] Updated expected files for japanese subset integration tests to include cmap4.
- ...gular.default.3042,3044,3046,3048,304A,304B.ttf | Bin 3032 ->
- 3112 bytes
- ...gular.default.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 3268 ->
- 3356 bytes
- .../Mplus1p-Regular.default.61,63,65,6B.ttf | Bin 2584 ->
- 2656 bytes
- ...gular.default.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 3564 ->
- 3652 bytes
- .../japanese/Mplus1p-Regular.default.660E.ttf | Bin 2348 ->
- 2396 bytes
- ...ar.drop-hints.3042,3044,3046,3048,304A,304B.ttf | Bin 2304 ->
- 2384 bytes
- ...ar.drop-hints.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 2540 ->
- 2628 bytes
- .../Mplus1p-Regular.drop-hints.61,63,65,6B.ttf | Bin 1856 ->
- 1928 bytes
- ...ar.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 2836 ->
- 2924 bytes
- .../japanese/Mplus1p-Regular.drop-hints.660E.ttf | Bin 1620 ->
- 1668 bytes
- test/subset/data/fonts/Mplus1p-Regular.ttf | Bin 1758820 ->
- 1757292 bytes
+ ...gular.default.3042,3044,3046,3048,304A,304B.ttf | Bin 3032 -> 3112 bytes
+ ...gular.default.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 3268 -> 3356 bytes
+ .../Mplus1p-Regular.default.61,63,65,6B.ttf | Bin 2584 -> 2656 bytes
+ ...gular.default.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 3564 -> 3652 bytes
+ .../japanese/Mplus1p-Regular.default.660E.ttf | Bin 2348 -> 2396 bytes
+ ...ar.drop-hints.3042,3044,3046,3048,304A,304B.ttf | Bin 2304 -> 2384 bytes
+ ...ar.drop-hints.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 2540 -> 2628 bytes
+ .../Mplus1p-Regular.drop-hints.61,63,65,6B.ttf | Bin 1856 -> 1928 bytes
+ ...ar.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 2836 -> 2924 bytes
+ .../japanese/Mplus1p-Regular.drop-hints.660E.ttf | Bin 1620 -> 1668 bytes
+ test/subset/data/fonts/Mplus1p-Regular.ttf | Bin 1758820 -> 1757292 bytes
11 files changed, 0 insertions(+), 0 deletions(-)
commit 79479273170275447042aa50912acee74bbacdf6
@@ -29721,41 +29754,24 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu May 3 11:18:02 2018 -0700
- [subset] Update expected files for subset integration tests to
- include cmap4.
+ [subset] Update expected files for subset integration tests to include cmap4.
- .../basics/Roboto-Regular.abc.default.61,62,63.ttf | Bin 2120 ->
- 2168 bytes
- .../basics/Roboto-Regular.abc.default.61,63.ttf | Bin 1932 ->
- 1988 bytes
- .../expected/basics/Roboto-Regular.abc.default.61.ttf | Bin 1744 ->
- 1792 bytes
- .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1692 ->
- 1740 bytes
- .../expected/basics/Roboto-Regular.abc.default.63.ttf | Bin 1668 ->
- 1716 bytes
- .../basics/Roboto-Regular.abc.drop-hints.61,62,63.ttf | Bin 876 ->
- 924 bytes
- .../basics/Roboto-Regular.abc.drop-hints.61,63.ttf | Bin 792 ->
- 848 bytes
- .../basics/Roboto-Regular.abc.drop-hints.61.ttf | Bin 684 ->
- 732 bytes
- .../basics/Roboto-Regular.abc.drop-hints.62.ttf | Bin 652 ->
- 700 bytes
- .../basics/Roboto-Regular.abc.drop-hints.63.ttf | Bin 656 ->
- 704 bytes
- .../Roboto-Regular.default.1FC,21,41,20,62,63.ttf | Bin 3700 ->
- 3772 bytes
- .../full-font/Roboto-Regular.default.61,62,63.ttf | Bin 3320 ->
- 3368 bytes
- .../Roboto-Regular.default.D7,D8,D9,DA,DE.ttf | Bin 3668 ->
- 3732 bytes
- .../Roboto-Regular.drop-hints.1FC,21,41,20,62,63.ttf | Bin 2152 ->
- 2224 bytes
- .../full-font/Roboto-Regular.drop-hints.61,62,63.ttf | Bin 1968 ->
- 2016 bytes
- .../Roboto-Regular.drop-hints.D7,D8,D9,DA,DE.ttf | Bin 2188 ->
- 2252 bytes
+ .../basics/Roboto-Regular.abc.default.61,62,63.ttf | Bin 2120 -> 2168 bytes
+ .../basics/Roboto-Regular.abc.default.61,63.ttf | Bin 1932 -> 1988 bytes
+ .../expected/basics/Roboto-Regular.abc.default.61.ttf | Bin 1744 -> 1792 bytes
+ .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1692 -> 1740 bytes
+ .../expected/basics/Roboto-Regular.abc.default.63.ttf | Bin 1668 -> 1716 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.61,62,63.ttf | Bin 876 -> 924 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.61,63.ttf | Bin 792 -> 848 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.61.ttf | Bin 684 -> 732 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.62.ttf | Bin 652 -> 700 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.63.ttf | Bin 656 -> 704 bytes
+ .../Roboto-Regular.default.1FC,21,41,20,62,63.ttf | Bin 3700 -> 3772 bytes
+ .../full-font/Roboto-Regular.default.61,62,63.ttf | Bin 3320 -> 3368 bytes
+ .../Roboto-Regular.default.D7,D8,D9,DA,DE.ttf | Bin 3668 -> 3732 bytes
+ .../Roboto-Regular.drop-hints.1FC,21,41,20,62,63.ttf | Bin 2152 -> 2224 bytes
+ .../full-font/Roboto-Regular.drop-hints.61,62,63.ttf | Bin 1968 -> 2016 bytes
+ .../Roboto-Regular.drop-hints.D7,D8,D9,DA,DE.ttf | Bin 2188 -> 2252 bytes
16 files changed, 0 insertions(+), 0 deletions(-)
commit a8e7f9b958dcb4e00226f78d0ff83f031bc1323d
@@ -29772,8 +29788,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu May 3 10:53:20 2018 -0700
- [subset] Write out a format 4, plat 0 encoding record to match
- fontTools.
+ [subset] Write out a format 4, plat 0 encoding record to match fontTools.
src/hb-ot-cmap-table.hh | 24 +++++++++++++++---------
test/api/test-subset-cmap.c | 2 +-
@@ -29785,8 +29800,7 @@
[subset] A few bug fixes for cmap format 4 subsetting.
- src/hb-ot-cmap-table.hh | 57
- ++++++++++++++++++++++++++++---------------------
+ src/hb-ot-cmap-table.hh | 57 ++++++++++++++++++++++++++++---------------------
1 file changed, 33 insertions(+), 24 deletions(-)
commit 81ea75f5c860ef682184bd2c9d0ff8b48251e3ce
@@ -29822,8 +29836,7 @@
[subset] WIP cmap format 4 subsetting.
- src/hb-ot-cmap-table.hh | 104
- ++++++++++++++++++++++++++++++++++++++++--------
+ src/hb-ot-cmap-table.hh | 104 ++++++++++++++++++++++++++++++++++++++++--------
1 file changed, 88 insertions(+), 16 deletions(-)
commit 0053d13283458996372f04bd501001d450523605
@@ -29830,11 +29843,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed May 2 15:42:43 2018 -0700
- [subset] Refactor cmap subsetting to make it possible to add support
- for more sub tables.
+ [subset] Refactor cmap subsetting to make it possible to add support for more sub tables.
- src/hb-ot-cmap-table.hh | 161
- ++++++++++++++++++++++++++++++------------------
+ src/hb-ot-cmap-table.hh | 161 ++++++++++++++++++++++++++++++------------------
1 file changed, 102 insertions(+), 59 deletions(-)
commit 03b27548123756dfd9988a8fc74bc78733fb2c44
@@ -29841,8 +29852,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed May 2 15:42:08 2018 -0700
- [subset] Add const to the hb_subset_plan_t input to a couple functions
- in hb-subset-plan.
+ [subset] Add const to the hb_subset_plan_t input to a couple functions in hb-subset-plan.
src/hb-subset-plan.cc | 4 ++--
src/hb-subset-plan.hh | 18 +++++++++---------
@@ -29853,7 +29863,7 @@
Date: Wed May 2 14:59:14 2018 -0400
Rename some X-terminated members to Z-terminated
-
+
X-terminated means don't access this, it's not located correctly.
Z-terminated means this is a C array with no bound checking.
@@ -29869,7 +29879,7 @@
Date: Wed May 2 12:56:21 2018 -0400
[set] Fix init/fini of set on the stack to call object init/fini
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1017
src/hb-set-private.hh | 14 ++++++++++++--
@@ -29881,7 +29891,7 @@
Date: Tue May 1 19:09:00 2018 -0400
Remove hb_auto_array_t
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1017
src/hb-coretext.cc | 8 ++++----
@@ -29896,7 +29906,7 @@
Date: Tue May 1 19:07:04 2018 -0400
s/hb_prealloced_array_t/hb_vector_t/g
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1017
src/hb-ot-cmap-table.hh | 6 +++---
@@ -29917,7 +29927,7 @@
Date: Tue May 1 19:05:58 2018 -0400
Add hb_auto_t
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1017
src/hb-private.hh | 11 ++++++++---
@@ -29928,7 +29938,7 @@
Date: Tue May 1 19:01:25 2018 -0400
s/finish/fini
-
+
For consistency.
src/hb-common.cc | 8 ++++----
@@ -29961,7 +29971,7 @@
Date: Tue May 1 18:27:41 2018 -0400
[set] Cache population
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/1017
src/hb-set-private.hh | 24 +++++++++++++++++++++++-
@@ -29973,10 +29983,9 @@
Date: Sat Apr 28 20:29:13 2018 +0200
[subset] Do not compare ttx progress output in the tests
+
+ Suppress progress messages of ttx. This avoids comparing this output to the reference file which lets the test fail.
- Suppress progress messages of ttx. This avoids comparing this output
- to the reference file which lets the test fail.
-
test/subset/run-tests.py | 1 +
1 file changed, 1 insertion(+)
@@ -29994,13 +30003,12 @@
Date: Fri Apr 13 12:43:29 2018 +0430
Don't decompose Bengali Rra and Rha
-
+
Fixes #779 and follow up to b01d9b3d90e892341ee4463f2eda4600850b97d8
src/hb-ot-shape-complex-indic.cc | 3 +++
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/932ad5132c2761297c74e9976fe25b08e5ffa10b.ttf | Bin 0 ->
- 22980 bytes
+ .../fonts/932ad5132c2761297c74e9976fe25b08e5ffa10b.ttf | Bin 0 -> 22980 bytes
test/shaping/data/in-house/tests/indic-decompose.tests | 1 +
4 files changed, 5 insertions(+)
@@ -30009,7 +30017,7 @@
Date: Wed Apr 25 16:44:04 2018 +0430
Minor, improve file reading failing condition comment
-
+
https://bugzilla.gnome.org/show_bug.cgi?id=659212 for more context
src/hb-blob.cc | 3 ++-
@@ -30019,8 +30027,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Tue Apr 24 09:04:15 2018 +0430
- Minor, re-add unused mark to some of ragel defined state machines
- (#1005)
+ Minor, re-add unused mark to some of ragel defined state machines (#1005)
src/hb-ot-shape-complex-indic-machine.hh | 2 +-
src/hb-ot-shape-complex-indic-machine.rl | 2 +-
@@ -30037,7 +30044,7 @@
Date: Tue Apr 24 08:11:13 2018 +0430
Minor, re-add unused mark for two TRACE_ macros
-
+
To revive Travis CI bot
src/hb-debug.hh | 4 ++--
@@ -30114,8 +30121,7 @@
[aat/kerx] Minor (#1003)
- src/hb-aat-layout-kerx-table.hh | 46
- +++++++++++++++++++++--------------------
+ src/hb-aat-layout-kerx-table.hh | 46 +++++++++++++++++++++--------------------
1 file changed, 24 insertions(+), 22 deletions(-)
commit ce17340b23d96f543cd88e400e631bdb5656331c
@@ -30128,8 +30134,7 @@
docs/harfbuzz-sections.txt | 1 +
src/dump-emoji.cc | 33 +----------
src/dump-fon.cc | 11 +---
- src/hb-blob.cc | 131
- ++++++++++++++++++++++++++++++++++++++++---
+ src/hb-blob.cc | 131 ++++++++++++++++++++++++++++++++++++++++---
src/hb-blob.h | 2 +
src/main.cc | 26 +--------
src/test-buffer-serialize.cc | 42 +-------------
@@ -30147,13 +30152,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Apr 19 15:30:35 2018 -0700
- [subset] Check instruction offsets in glyph to ensure they are
- in bounds.
+ [subset] Check instruction offsets in glyph to ensure they are in bounds.
src/hb-ot-glyf-table.hh | 18 ++++++++++--
.../oom-ccc61c92d589f895174cdef6ff2e3b20e9999a1a | Bin 0 -> 63302 bytes
- test/api/test-subset-glyf.c | 31
- +++++++++++++++++++++
+ test/api/test-subset-glyf.c | 31 +++++++++++++++++++++
3 files changed, 47 insertions(+), 2 deletions(-)
commit 3c97614598ecd0bbccb2c90a8e0e99f010952b76
@@ -30160,8 +30163,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Apr 19 13:39:57 2018 -0700
- [subset] In subset fuzzer run through drop hints and keep hints
- pathways.
+ [subset] In subset fuzzer run through drop hints and keep hints pathways.
test/fuzzing/hb-subset-fuzzer.cc | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
@@ -30171,9 +30173,9 @@
Date: Thu Apr 19 23:41:37 2018 +0300
[util] Check all specified shapers are known (#993)
-
+
A bit brute force and requires all shapers to be known, not just one.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/956
util/options.cc | 22 ++++++++++++++++++++--
@@ -30185,10 +30187,8 @@
[subset] Add integration tests for cmap breakge.
- .../full-font/Roboto-Regular.default.D7,D8,D9,DA,DE.ttf | Bin 0 ->
- 3668 bytes
- .../Roboto-Regular.drop-hints.D7,D8,D9,DA,DE.ttf | Bin 0 ->
- 2188 bytes
+ .../full-font/Roboto-Regular.default.D7,D8,D9,DA,DE.ttf | Bin 0 -> 3668 bytes
+ .../Roboto-Regular.drop-hints.D7,D8,D9,DA,DE.ttf | Bin 0 -> 2188 bytes
test/subset/data/tests/full-font.tests | 1 +
3 files changed, 1 insertion(+)
@@ -30199,8 +30199,7 @@
[subset] Add a test for previous cmap breakage.
test/api/fonts/Roboto-Regular.D7,D8,D9,DA,DE.ttf | Bin 0 -> 2972 bytes
- test/api/test-subset-cmap.c | 23
- +++++++++++++++++++++++
+ test/api/test-subset-cmap.c | 23 +++++++++++++++++++++++
2 files changed, 23 insertions(+)
commit 5e318e09ba590eef7b7ec047d7857f7f1eb7d787
@@ -30208,8 +30207,7 @@
Date: Wed Apr 18 17:13:37 2018 -0700
[subset] Fix broken cmap creation.
- It was ignoring the restriction that gids must be consecutive to be
- placed into a single group.
+ It was ignoring the restriction that gids must be consecutive to be placed into a single group.
src/hb-ot-cmap-table.hh | 23 ++++++++++++++++-------
1 file changed, 16 insertions(+), 7 deletions(-)
@@ -30257,13 +30255,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Apr 17 08:21:22 2018 -0600
- [subset] add a fuzzer target for subset_get_all_codepoints
- method. (#987)
+ [subset] add a fuzzer target for subset_get_all_codepoints method. (#987)
test/fuzzing/CMakeLists.txt | 7 ++++++-
test/fuzzing/Makefile.am | 16 ++++++++++++++++
- test/fuzzing/hb-subset-get-codepoints-fuzzer.cc | 24
- ++++++++++++++++++++++++
+ test/fuzzing/hb-subset-get-codepoints-fuzzer.cc | 24 ++++++++++++++++++++++++
test/fuzzing/run-subset-fuzzer-tests.py | 19 ++++++++++++++++++-
4 files changed, 64 insertions(+), 2 deletions(-)
@@ -30280,13 +30276,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Apr 17 07:00:23 2018 -0600
- [subset] Add implementation of cmap format 12 codepoint
- listing. (#988)
+ [subset] Add implementation of cmap format 12 codepoint listing. (#988)
src/hb-ot-cmap-table.hh | 21 +++++++++++-
test/api/fonts/Roboto-Regular.abc.format12.ttf | Bin 0 -> 2412 bytes
- test/api/test-subset-codepoints.c | 44
- +++++++++++++++++++++++++
+ test/api/test-subset-codepoints.c | 44 +++++++++++++++++++++++++
3 files changed, 64 insertions(+), 1 deletion(-)
commit 6771e79bcc2166b5c03ca615d271c8508d692416
@@ -30294,10 +30288,9 @@
Date: Tue Apr 17 09:36:52 2018 +0430
Add pre-opentype font pages detection code (#986)
+
+ As Khaled's finding on #981 this is the way Uniscribe detects those fonts. This is its detection part.
- As Khaled's finding on #981 this is the way Uniscribe detects those
- fonts. This is its detection part.
-
src/hb-ot-os2-table.hh | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
@@ -30306,11 +30299,9 @@
Date: Tue Apr 17 09:13:35 2018 +0430
Make some of implicit header uses explicit (#989)
-
- Splitted from #950 and #986 IIRC Chromium had a policy about this
- encouraging it,
- not sure about automated way to detect and add them but for now lets
- have the needed
+
+ Splitted from #950 and #986 IIRC Chromium had a policy about this encouraging it,
+ not sure about automated way to detect and add them but for now lets have the needed
ones of them.
src/hb-aat-layout-morx-table.hh | 1 +
@@ -30326,10 +30317,9 @@
Date: Tue Apr 17 09:13:03 2018 +0430
Add round to F2DOT14 inner store setter (#990)
+
+ It uses floor implicitly without it but explicit use of round will be more correct.
- It uses floor implicitly without it but explicit use of round will
- be more correct.
-
src/hb-open-type-private.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -30337,8 +30327,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Apr 16 15:09:27 2018 -0700
- [subset] Don't assume the last segment in cmap 4 can be skipped,
- actually check it.
+ [subset] Don't assume the last segment in cmap 4 can be skipped, actually check it.
src/hb-ot-cmap-table.hh | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
@@ -30347,9 +30336,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Apr 10 15:40:24 2018 -0700
- [subset] sketch out support for a call that lists all codepoints
- present in a font. Implement support for it in format 4 cmap sub
- table.
+ [subset] sketch out support for a call that lists all codepoints present in a font. Implement support for it in format 4 cmap sub table.
src/hb-ot-cmap-table.hh | 37 ++++++++++++++--
src/hb-subset.cc | 14 ++++++
@@ -30356,8 +30343,7 @@
src/hb-subset.h | 5 ++-
test/api/Makefile.am | 2 +
test/api/fonts/Roboto-Regular.abc.format4.ttf | Bin 0 -> 2424 bytes
- test/api/test-subset-codepoints.c | 59
- ++++++++++++++++++++++++++
+ test/api/test-subset-codepoints.c | 59 ++++++++++++++++++++++++++
6 files changed, 113 insertions(+), 4 deletions(-)
commit aef96e246cb695c4c83b8b6daed06a0d14fe1d32
@@ -30366,8 +30352,7 @@
Further improvements on dump-fon (#985)
- src/dump-fon.cc | 153
- +++++++++++++++++++++++++++++++++++++++++++++-----------
+ src/dump-fon.cc | 153 +++++++++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 123 insertions(+), 30 deletions(-)
commit 67dfb1937b703b3f1dc45251f4f884abf35c8576
@@ -30377,8 +30362,7 @@
Add dump-fon, a prototype on how to work with .fon/.fnt files (#981)
src/Makefile.am | 4 +
- src/dump-fon.cc | 475
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/dump-fon.cc | 475 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 479 insertions(+)
commit ce99dd04de830c8426af14c11dbee45f8bcc9e60
@@ -30407,7 +30391,7 @@
Date: Fri Apr 13 23:19:19 2018 +0430
Merge pull request #979 from ebraminio/msvc05
-
+
Reinstate support for Visual Studio 2005
commit 8f4c12308a8d9e61922fb352e913acae46b28a88
@@ -30426,7 +30410,7 @@
Date: Thu Apr 12 14:17:03 2018 +0430
Always enable atexit on Android (#971)
-
+
Obviously one can use a newer NDK for building an updated HarfBuzz
instead that now pretty old version however I am concerned if that
version checking is working with clang that is used with the newer
@@ -30565,8 +30549,7 @@
src/hb-open-type-private.hh | 1 -
src/hb-ot-color-cbdt-table.hh | 10 +++++-----
src/hb-ot-color-cpal-table.hh | 4 ++--
- src/hb-ot-color-sbix-table.hh | 41
- ++++++++++++++++++++---------------------
+ src/hb-ot-color-sbix-table.hh | 41 ++++++++++++++++++++---------------------
src/hb-ot-color-svg-table.hh | 37 +++++++++++++++++++------------------
5 files changed, 46 insertions(+), 47 deletions(-)
@@ -30586,8 +30569,7 @@
[colr/cpal] Improvements and add a sample renderer (#927)
src/Makefile.am | 13 ++-
- src/dump-emoji.cc | 181
- +++++++++++++++++++++++++++++++++++++++---
+ src/dump-emoji.cc | 181 +++++++++++++++++++++++++++++++++++++++---
src/hb-ot-color-colr-table.hh | 43 +++++++++-
src/hb-ot-color-cpal-table.hh | 70 +++++++++-------
4 files changed, 259 insertions(+), 48 deletions(-)
@@ -30597,10 +30579,9 @@
Date: Tue Apr 10 00:51:57 2018 +0430
[ci] Don't fail on brew warnings
+
+ Not the best fix but it works and we don't care about brew warnings, so
- Not the best fix but it works and we don't care about brew warnings,
- so
-
.travis.yml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -30620,8 +30601,7 @@
[aat] Further improvements on feat (#948)
src/Makefile.sources | 2 +-
- ...t-feat-table.hh => hb-aat-layout-feat-table.hh} | 48
- +++++++++++-----------
+ ...t-feat-table.hh => hb-aat-layout-feat-table.hh} | 48 +++++++++++-----------
src/hb-aat-layout.cc | 2 +-
3 files changed, 25 insertions(+), 27 deletions(-)
@@ -30641,8 +30621,7 @@
[aat] Implement feat table parsing (#947)
src/Makefile.sources | 3 +-
- src/hb-aat-feat-table.hh | 122
- +++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-feat-table.hh | 122 +++++++++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 1 +
3 files changed, 125 insertions(+), 1 deletion(-)
@@ -30651,7 +30630,7 @@
Date: Sat Mar 31 12:15:50 2018 +0200
Another try at fixing linker issue
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/880
configure.ac | 11 +++++++++--
@@ -30676,8 +30655,7 @@
[aat] Implement gcid table parsing (#944)
src/Makefile.sources | 1 +
- src/hb-aat-gcid-table.hh | 73
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-gcid-table.hh | 73 ++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 1 +
3 files changed, 75 insertions(+)
@@ -30688,8 +30666,7 @@
[aat] Implement bsln table parsing (#943)
src/Makefile.sources | 1 +
- src/hb-aat-layout-bsln-table.hh | 156
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-bsln-table.hh | 156 ++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 3 +-
3 files changed, 159 insertions(+), 1 deletion(-)
@@ -30699,8 +30676,7 @@
Make atexit callbacks threadsafe (#930)
- src/hb-common.cc | 60
- +++++++++++++++++++++++++++++------------------------
+ src/hb-common.cc | 60 +++++++++++++++++++++++++++++------------------------
src/hb-ft.cc | 44 ++++++++++++++++++++++++---------------
src/hb-glib.cc | 7 ++++++-
src/hb-icu.cc | 7 ++++++-
@@ -30751,8 +30727,7 @@
Make more gen-* scripts py3 compatible (#940)
src/Makefile.am | 2 +-
- src/gen-arabic-table.py | 163
- +++++++++++----------
+ src/gen-arabic-table.py | 163 +++++++++++----------
src/gen-def.py | 2 +-
src/gen-indic-table.py | 120 +++++++--------
src/gen-unicode-ranges.py | 8 +-
@@ -30775,8 +30750,7 @@
Makefile.am | 3 ++-
README.python => README.python.md | 12 +++++++++---
- README.wine.md | 40
- +++++++++++++++++++++++++++++++++++++++
+ README.wine.md | 40 +++++++++++++++++++++++++++++++++++++++
RELEASING.md | 25 +++++++++++++-----------
4 files changed, 65 insertions(+), 15 deletions(-)
@@ -30785,7 +30759,7 @@
Date: Wed Mar 28 15:33:51 2018 -0700
[atexit] Make hb_languate_item_t *langs freeing threadsafe
-
+
Part of https://github.com/harfbuzz/harfbuzz/issues/923
src/hb-common.cc | 15 ++++++++++-----
@@ -30796,7 +30770,7 @@
Date: Wed Mar 28 14:06:58 2018 -0700
Fix one UBSan warning
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/935
src/hb-font-private.hh | 6 +++++-
@@ -30807,7 +30781,7 @@
Date: Wed Mar 28 13:38:51 2018 -0700
[uniscribe] Fixup for previous commit
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/934
src/hb-uniscribe.cc | 5 +++--
@@ -30818,13 +30792,12 @@
Date: Wed Mar 28 10:44:52 2018 -0700
[uniscribe] Fix assertion fail in checksum calc
-
- Program:
- Z:\Users\ebrahim\Desktop\harfbuzz\winbuild\util\.libs\hb-shape.exe
+
+ Program: Z:\Users\ebrahim\Desktop\harfbuzz\winbuild\util\.libs\hb-shape.exe
File: ../../src/hb-open-type-private.hh, Line 769
-
+
Expression: 0 == (Length & 3)
-
+
abnormal program termination
src/hb-uniscribe.cc | 2 +-
@@ -30836,8 +30809,7 @@
Make gen-use-table.py py3 compatible (#932)
- src/gen-use-table.py | 105
- ++++++++++++++++++++++++++-------------------------
+ src/gen-use-table.py | 105 ++++++++++++++++++++++++++-------------------------
1 file changed, 53 insertions(+), 52 deletions(-)
commit 1c3372786c503f3f9108971dfa8956e4cb95f65d
@@ -30844,13 +30816,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Mar 27 10:42:19 2018 -0700
- [subset] fix infinite loop bug in looping through tables for
- subsetting.
+ [subset] fix infinite loop bug in looping through tables for subsetting.
src/hb-subset.cc | 2 +-
...ase-minimized-hb-subset-fuzzer-5521982557782016 | Bin 0 -> 1228 bytes
- test/api/test-subset.c | 23
- +++++++++++++++++++++
+ test/api/test-subset.c | 23 +++++++++++++++++++++
3 files changed, 24 insertions(+), 1 deletion(-)
commit 8fd55422c3fa2279991d93875d912fca4ee89cf5
@@ -30858,14 +30828,12 @@
Date: Tue Mar 27 16:57:09 2018 +0430
Implement an internal emojis dumper tool (#909)
+
+ Later to be expanded to a more general tool but for now it only supports CBDT, SVG and CBDT.
- Later to be expanded to a more general tool but for now it only
- supports CBDT, SVG and CBDT.
-
CMakeLists.txt | 2 +-
src/Makefile.am | 4 ++
- src/dump-emoji.cc | 141
- ++++++++++++++++++++++++++++++++++++++++++
+ src/dump-emoji.cc | 141 ++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-color-cbdt-table.hh | 71 +++++++++++++++++++++
src/hb-ot-color-sbix-table.hh | 79 ++++++++++++++---------
src/hb-ot-color-svg-table.hh | 56 ++++++++++++-----
@@ -30885,16 +30853,15 @@
Date: Mon Mar 26 20:56:56 2018 -0600
[subset] Couple of fixes for fuzzer discovered issues. (#924)
-
- * [subset] sanitize individual DeviceRecord's as part of hdmx
- sanitization.
-
+
+ * [subset] sanitize individual DeviceRecord's as part of hdmx sanitization.
+
* [subset] Fix out of bounds read with non-two byte align glyphs.
-
+
* [subset] Just use size_device_record >= DeviceRecord::min_size.
-
+
* [subset] Add TODO.
-
+
* [subset] Re-order checks in hdmx sanitize.
src/hb-ot-hdmx-table.hh | 1 +
@@ -30902,8 +30869,7 @@
src/hb-subset.cc | 6 +++++-
...ase-minimized-hb-subset-fuzzer-5609911946838016 | Bin 0 -> 313 bytes
...ase-minimized-hb-subset-fuzzer-6651660668502016 | Bin 0 -> 15229 bytes
- test/api/test-subset-hdmx.c | 23
- +++++++++++++++++++++
+ test/api/test-subset-hdmx.c | 23 +++++++++++++++++++++
6 files changed, 32 insertions(+), 4 deletions(-)
commit 6f46883f5b74b206a3b77246891ab2ac57a27c4e
@@ -30929,7 +30895,7 @@
Date: Mon Mar 26 15:09:54 2018 -0700
Fix previous commit
-
+
Automake has this stupid behavior where if your Makefile.am has
syntactic error, it can get to a state that make succeeds but just
ignores broken Makefile.am. Ouch.
@@ -30942,12 +30908,11 @@
Date: Mon Mar 26 14:26:45 2018 -0700
Try fixing linking again
-
- Before 1.7.5, we were setting -fno-exceptions etc on CXXFLAGS. In
- 1.7.6
+
+ Before 1.7.5, we were setting -fno-exceptions etc on CXXFLAGS. In 1.7.6
we set it as CPPFLAGS. Try fixing. Also, I'm fairly sure it's safe to
set these unconditionally.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/880 (or so I hope)
src/Makefile.am | 19 +++++++------------
@@ -30959,7 +30924,7 @@
Date: Mon Mar 26 14:09:29 2018 -0700
Add HB_SUBSET_BUILTIN
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/865
src/hb-subset.cc | 2 +-
@@ -31013,8 +30978,7 @@
src/Makefile.sources | 2 ++
src/hb-aat-layout-fmtx-table.hh | 6 ++--
src/hb-aat-layout-kerx-table.hh | 4 +--
- src/hb-aat-layout-ltag-table.hh | 80
- +++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-ltag-table.hh | 80 +++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout-morx-table.hh | 4 +--
src/hb-aat-layout-trak-table.hh | 4 +--
src/hb-aat-layout.cc | 3 +-
@@ -31026,8 +30990,7 @@
[aat/fmtx] Implement the table parsing (#910)
- src/hb-aat-layout-fmtx-table.hh | 67
- +++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-fmtx-table.hh | 67 +++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout-trak-table.hh | 4 +--
src/hb-aat-layout.cc | 1 +
3 files changed, 70 insertions(+), 2 deletions(-)
@@ -31048,8 +31011,7 @@
[dwrite] minor
src/dev-run.sh | 5 ++-
- src/hb-directwrite.cc | 118
- ++++++++++++++++++++------------------------------
+ src/hb-directwrite.cc | 118 ++++++++++++++++++++------------------------------
2 files changed, 50 insertions(+), 73 deletions(-)
commit ebccd019749e24e6c045518ee1ffbfc947744204
@@ -31057,7 +31019,7 @@
Date: Sat Mar 24 17:51:55 2018 -0700
More ULL fixes
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/901
src/hb-private.hh | 12 ++++++------
@@ -31068,7 +31030,7 @@
Date: Sat Mar 24 14:12:12 2018 -0700
Define uint64_t constants with ULL suffix
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/901
src/hb-private.hh | 2 +-
@@ -31079,12 +31041,12 @@
Date: Mon Mar 12 13:33:03 2018 +0800
hb-private.hh: Add fallback implementation for round()
-
+
For pre-C99 compilers that do not support round(), we need to have a
simplistic implementation for it, when it is not detected during build
configuration, either via CMake or autotools, by using floor() and
ceil(), which are provided in the pre-C99 compilers.
-
+
Please see discussion at commit 86a0ac2 for more details for re-adding
this patch.
@@ -31096,7 +31058,7 @@
Date: Fri Mar 23 19:38:11 2018 +0000
Policy 0063 must be enabled to have hidden inline visibility... (#900)
-
+
...on static builds.
CMakeLists.txt | 2 ++
@@ -31120,8 +31082,7 @@
[dwrite] Replace rest of 'malloc/free's with 'new/delete' (#897)
- src/hb-directwrite.cc | 251
- +++++++++++++++++++++++++-------------------------
+ src/hb-directwrite.cc | 251 +++++++++++++++++++++++++-------------------------
1 file changed, 127 insertions(+), 124 deletions(-)
commit 3f55e0e74680c246819233a7250df612821698d7
@@ -31128,8 +31089,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Mar 20 17:36:52 2018 -0700
- [subset] Check for the Null table and not nullptr to detect failure
- to find a table in glyf accelerator.
+ [subset] Check for the Null table and not nullptr to detect failure to find a table in glyf accelerator.
src/hb-ot-glyf-table.hh | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
@@ -31147,12 +31107,10 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Mar 20 16:55:42 2018 -0700
- [subset] don't use pointers returned from push after array has
- resized in hb-subset-glyf.cc
+ [subset] don't use pointers returned from push after array has resized in hb-subset-glyf.cc
src/hb-subset-glyf.cc | 9 +++++++--
- .../crash-b577db318b30f2851828a4c9ef97cb30678b1b54 | Bin 0 ->
- 22473 bytes
+ .../crash-b577db318b30f2851828a4c9ef97cb30678b1b54 | Bin 0 -> 22473 bytes
2 files changed, 7 insertions(+), 2 deletions(-)
commit 3531efdb4c641ef543ea0686fef9289307d52096
@@ -31161,8 +31119,7 @@
[subset] Fixed out of bounds read when subsetting hdmx.
- src/hb-ot-hdmx-table.hh | 30
- ++++++++++++++++-----
+ src/hb-ot-hdmx-table.hh | 30 ++++++++++++++++-----
.../crash-ccc61c92d589f895174cdef6ff2e3b20e9999a1a | Bin 0 -> 63302 bytes
test/api/test-subset-hdmx.c | 23 ++++++++++++++++
3 files changed, 47 insertions(+), 6 deletions(-)
@@ -31171,13 +31128,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Mar 20 13:00:49 2018 -0700
- [subset] Disable glyf accelerator_t methods if it didn't successfully
- init.
+ [subset] Disable glyf accelerator_t methods if it didn't successfully init.
src/hb-ot-glyf-table.hh | 7 ++++++-
.../crash-4b60576767ee4d9fe1cc10959d89baf73d4e8249 | Bin 0 -> 3140 bytes
- test/api/test-subset.c | 23
- +++++++++++++++++++++
+ test/api/test-subset.c | 23 +++++++++++++++++++++
3 files changed, 29 insertions(+), 1 deletion(-)
commit 7251181b56af564e2a9444f002f8ac03f98c7ee3
@@ -31189,8 +31144,7 @@
src/hb-subset.cc | 1 +
test/api/Makefile.am | 1 +
.../oom-6ef8c96d3710262511bcc730dce9c00e722cb653 | Bin 0 -> 24233 bytes
- test/api/test-subset.c | 62
- +++++++++++++++++++++
+ test/api/test-subset.c | 62 +++++++++++++++++++++
4 files changed, 64 insertions(+)
commit 1a94804d35d533d39849d21a177039c4cbfade98
@@ -31210,8 +31164,7 @@
[subset] Add a test demonstrating a seg fault while subsetting hmtx.
.../crash-e4e0bb1458a91b692eba492c907ae1f94e635480 | Bin 0 -> 63302 bytes
- test/api/test-subset-hmtx.c | 22
- +++++++++++++++++++++
+ test/api/test-subset-hmtx.c | 22 +++++++++++++++++++++
2 files changed, 22 insertions(+)
commit b5c7d6cffc2098dafa06822b28a5fd4f6218b60c
@@ -31248,12 +31201,10 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Fri Mar 16 22:45:09 2018 +0330
- Do feature test before adding -Bsymbolic-functions, autotools part
- (#892)
+ Do feature test before adding -Bsymbolic-functions, autotools part (#892)
configure.ac | 2 +-
- m4/ax_check_link_flag.m4 | 74
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ m4/ax_check_link_flag.m4 | 74 ++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 75 insertions(+), 1 deletion(-)
commit d68f00e4d8b061f56d3bd46d5ed1bc51406a4f1a
@@ -31270,7 +31221,7 @@
Date: Fri Mar 16 22:39:58 2018 +0330
[cmake] Don't hide symbols by default (#891)
-
+
But keep use of cmake idiomatic way of making inlines hidden
CMakeLists.txt | 17 ++---------------
@@ -31280,8 +31231,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Mar 15 18:27:01 2018 -0700
- [subset] Test not linking libharfbuzz-subset-fuzzing into
- hb-subset-fuzzer.
+ [subset] Test not linking libharfbuzz-subset-fuzzing into hb-subset-fuzzer.
test/fuzzing/Makefile.am | 2 +-
test/fuzzing/hb-subset-fuzzer.cc | 2 ++
@@ -31328,8 +31278,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Mar 15 16:12:00 2018 -0700
- [subset] Fix run-shape-fuzzer-tests.py. It was generating incorrect
- paths for input fonts.
+ [subset] Fix run-shape-fuzzer-tests.py. It was generating incorrect paths for input fonts.
test/fuzzing/run-shape-fuzzer-tests.py | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
@@ -31350,13 +31299,10 @@
[subset] Rename hb-fuzzer -> hb-shape-fuzzer.
- test/fuzzing/CMakeLists.txt | 16
- ++++++++--------
- test/fuzzing/Makefile.am | 16
- ++++++++--------
+ test/fuzzing/CMakeLists.txt | 16 ++++++++--------
+ test/fuzzing/Makefile.am | 16 ++++++++--------
test/fuzzing/{hb-fuzzer.cc => hb-shape-fuzzer.cc} | 0
- .../{run-fuzzer-tests.py => run-shape-fuzzer-tests.py} | 12
- ++++++------
+ .../{run-fuzzer-tests.py => run-shape-fuzzer-tests.py} | 12 ++++++------
4 files changed, 22 insertions(+), 22 deletions(-)
commit 1e9bd6d5ff0af0189b6398c5e13cff11ee70762b
@@ -31372,13 +31318,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Mar 14 19:15:33 2018 -0700
- [subset] Add a test runner for hb-subset-fuzzer and cmake build
- config.
+ [subset] Add a test runner for hb-subset-fuzzer and cmake build config.
test/fuzzing/CMakeLists.txt | 9 +++++++++
test/fuzzing/Makefile.am | 3 ++-
- test/fuzzing/run-subset-fuzzer-tests.py | 31
- +++++++++++++++++++++++++++++++
+ test/fuzzing/run-subset-fuzzer-tests.py | 31 +++++++++++++++++++++++++++++++
3 files changed, 42 insertions(+), 1 deletion(-)
commit aa9612d35f59f7f269fba4797c8da491844c56ec
@@ -31408,8 +31352,7 @@
src/Makefile.am | 24 +++++++++++++++++++++++-
test/fuzzing/Makefile.am | 15 +++++++++++++++
- test/fuzzing/hb-subset-fuzzer.cc | 37
- +++++++++++++++++++++++++++++++++++++
+ test/fuzzing/hb-subset-fuzzer.cc | 37 +++++++++++++++++++++++++++++++++++++
3 files changed, 75 insertions(+), 1 deletion(-)
commit 127096e4748d6381339342fc2750dd540e815fa5
@@ -31417,9 +31360,9 @@
Date: Thu Mar 15 13:23:27 2018 -0700
[util] Remove line buffering
-
+
Something weird seems to be going on. Just kill it.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/888
configure.ac | 2 +-
@@ -31431,7 +31374,7 @@
Date: Thu Mar 15 09:05:22 2018 -0700
Remove extra stdbool includes
-
+
They are handled in our common header.
test/api/test-subset-post.c | 2 --
@@ -31456,8 +31399,7 @@
[color/COLR] Simplify
- src/hb-ot-color-colr-table.hh | 48
- +++----------------------------------------
+ src/hb-ot-color-colr-table.hh | 48 +++----------------------------------------
1 file changed, 3 insertions(+), 45 deletions(-)
commit 6418ae4e8a3f4681cb4e7d54c589562930bc0678
@@ -31466,10 +31408,8 @@
[color/COLR] Clean up
- src/hb-aat-layout-common-private.hh | 84
- -------------------------------------
- src/hb-open-type-private.hh | 84
- +++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-common-private.hh | 84 -------------------------------------
+ src/hb-open-type-private.hh | 84 +++++++++++++++++++++++++++++++++++++
src/hb-ot-color-colr-table.hh | 30 ++++++-------
3 files changed, 99 insertions(+), 99 deletions(-)
@@ -31478,10 +31418,9 @@
Date: Wed Mar 14 16:08:12 2018 +0100
[color/COLR] Fix bad sanitize
+
+ Bad bad bad bad code. Don't do that. If compiler's not happy, understand why.
- Bad bad bad bad code. Don't do that. If compiler's not happy,
- understand why.
-
src/hb-ot-color-colr-table.hh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -31500,8 +31439,7 @@
[color/cbdt] Clean up
- src/hb-ot-color-cbdt-table.hh | 112
- ++++++++++++++++++++----------------------
+ src/hb-ot-color-cbdt-table.hh | 112 ++++++++++++++++++++----------------------
1 file changed, 54 insertions(+), 58 deletions(-)
commit 86a0ac284fc4c2ce96354bfdf32878b6db5c77bd
@@ -31509,14 +31447,12 @@
Date: Wed Mar 14 15:51:33 2018 +0100
Revert "hb-private.hh: Add fallback implementation for round()"
-
+
This reverts commit b9dcbb1f8312d8606b230f75594d40b7d4087004.
+
+ This is gross. Should be only done if a specific macro is defined. Not the other way
+ around. This fails my build as autotools companions where not added anyway.
- This is gross. Should be only done if a specific macro is defined. Not
- the other way
- around. This fails my build as autotools companions where not
- added anyway.
-
src/hb-private.hh | 13 -------------
1 file changed, 13 deletions(-)
@@ -31526,7 +31462,7 @@
Date: Thu Mar 15 11:40:52 2018 +0330
Merge pull request #886 from madig/only-export-visible-symbols
-
+
CMake: hide symbols by default on non-MSVC, define export attribute
commit 22de9bf56d80dbf6a13a06beafd21711bdab78af
@@ -31534,7 +31470,7 @@
Date: Wed Mar 14 10:29:24 2018 +0000
Enable implicit symbol hiding for all libraries, static and shared
-
+
This covers all built libraries now and both static and shared builds.
CMakeLists.txt | 35 +++++++++++++++++++++++------------
@@ -31563,7 +31499,7 @@
Date: Wed Mar 14 00:50:32 2018 +0000
CMake: hide symbols by default on non-MSVC, define export attribute
-
+
This change makes sure that non-MSVC builds using CMake properly hide
non-exported functions.
@@ -31576,7 +31512,7 @@
Date: Wed Mar 14 02:54:07 2018 +0330
Merge pull request #877 from fanc999/master.msvc
-
+
Fix CMake builds on Windows, MSVC in particular
commit 7c43adab6deb9302a24cc857c4aaa9b6b62215d2
@@ -31584,9 +31520,8 @@
Date: Mon Mar 12 16:43:53 2018 +0800
CMake: Fix utility program installation
-
- Put in the utility program that was missed in installation by
- replacing
+
+ Put in the utility program that was missed in installation by replacing
the one that was duplicated.
CMakeLists.txt | 2 +-
@@ -31597,12 +31532,10 @@
Date: Mon Mar 12 16:23:57 2018 +0800
CMake: Fix introspection on Windows
-
+
The list of source files to pass to g-ir-scanner is becoming too
- long for Windows, as Windows imposes a 8192-character limit for
- command
- lines, so we need to first transform that list into a listings
- file, and
+ long for Windows, as Windows imposes a 8192-character limit for command
+ lines, so we need to first transform that list into a listings file, and
then use the --filelist option for g-ir-scanner to build the
introspection files.
@@ -31614,11 +31547,11 @@
Date: Mon Mar 12 13:48:55 2018 +0800
test/api: Fix building subset tests
-
+
Include stdbool.h in hb-setset-test.h instead of in the individual
sources, if it is found; otherwise use a simplistic fallback for it if
it is not found.
-
+
Also declare variables at the top of the block, to build on pre-C99
compiliers.
@@ -31635,7 +31568,7 @@
Date: Mon Mar 12 13:38:01 2018 +0800
CMake: Fix running tests on Windows
-
+
For the API tests, output the test programs at $(TOP_BUILDDIR) so that
the freshly-built DLLs will be available for the test programs. For
those that are run through the Python wrapper scripts, use
@@ -31653,9 +31586,8 @@
Date: Mon Mar 12 13:33:03 2018 +0800
hb-private.hh: Add fallback implementation for round()
-
- Add a simplistic round() implementation for our purposes, used
- when the
+
+ Add a simplistic round() implementation for our purposes, used when the
compiler does not support round() directly.
src/hb-private.hh | 13 +++++++++++++
@@ -31666,16 +31598,13 @@
Date: Mon Mar 12 13:27:38 2018 +0800
configure.ac/CMake: Check for round() and stdbool.h
-
- Not all the compilers that HarfBuzz is buildable on supports round()
- and
- has the header stdbool.h, so we check for them and define HAVE_ROUND
- and
+
+ Not all the compilers that HarfBuzz is buildable on supports round() and
+ has the header stdbool.h, so we check for them and define HAVE_ROUND and
HAVE_STDBOOL_H repsectively in our CFLAGS so that we include them only
when they are found, or use fallback implementations when necessary.
-
- Also include FindPythonInterp earlier as we need PYTHON_EXECUTABLE
- to be
+
+ Also include FindPythonInterp earlier as we need PYTHON_EXECUTABLE to be
set for running the tests.
CMakeLists.txt | 12 ++++++++++--
@@ -31697,8 +31626,7 @@
[sbix] Clean up
- src/hb-ot-color-sbix-table.hh | 70
- +++++++++++++++++++++++--------------------
+ src/hb-ot-color-sbix-table.hh | 70 +++++++++++++++++++++++--------------------
1 file changed, 37 insertions(+), 33 deletions(-)
commit 218fa7166e9626f2036d08882854a86d753e4192
@@ -31708,8 +31636,7 @@
[ot-color] SVG table implementation (#874)
src/Makefile.sources | 3 +-
- src/hb-ot-color-svg-table.hh | 111
- +++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-color-svg-table.hh | 111 +++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout.cc | 1 +
3 files changed, 114 insertions(+), 1 deletion(-)
@@ -31720,8 +31647,7 @@
[ot-color] sbix table implementation (#870)
src/Makefile.sources | 1 +
- src/hb-ot-color-sbix-table.hh | 128
- ++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-color-sbix-table.hh | 128 ++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout.cc | 1 +
3 files changed, 130 insertions(+)
@@ -31740,7 +31666,7 @@
Date: Fri Mar 9 12:06:52 2018 -0700
Merge pull request #872 from googlefonts/drop-tables
-
+
[subset] Drop the same tables by default as fontTools does.
commit 9206762bbd4033e97d6d35ef1cce1b7940fbc935
@@ -31748,7 +31674,7 @@
Date: Fri Mar 9 15:43:03 2018 +0330
Make subset test runner compatible with py3
-
+
Fixes #873
test/subset/run-tests.py | 4 ++--
@@ -31759,7 +31685,7 @@
Date: Fri Mar 9 15:25:59 2018 +0330
[ci] Enable subset tests on ArchLinux to test
-
+
This makes ArchLinux bots fail, a starting point to #873
.circleci/config.yml | 7 ++++---
@@ -31780,7 +31706,7 @@
Date: Thu Mar 8 15:50:25 2018 -0700
Merge pull request #871 from googlefonts/mplus
-
+
[subset] Add a Japanese font to the subset integration tests.
commit 8548fa152241d6c5b020146f97aac15934ba0065
@@ -31789,26 +31715,16 @@
[subset] Drop cmap 12, platform 0 tables from Mplus1p expected files.
- ...-Regular.default.3042,3044,3046,3048,304A,304B.ttf | Bin 3040 ->
- 3032 bytes
- ...-Regular.default.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 3276 ->
- 3268 bytes
- .../japanese/Mplus1p-Regular.default.61,63,65,6B.ttf | Bin 2592 ->
- 2584 bytes
- ...-Regular.default.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 3572 ->
- 3564 bytes
- .../japanese/Mplus1p-Regular.default.660E.ttf | Bin 2356 ->
- 2348 bytes
- ...gular.drop-hints.3042,3044,3046,3048,304A,304B.ttf | Bin 2312 ->
- 2304 bytes
- ...gular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 2548 ->
- 2540 bytes
- .../Mplus1p-Regular.drop-hints.61,63,65,6B.ttf | Bin 1864 ->
- 1856 bytes
- ...gular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 2844 ->
- 2836 bytes
- .../japanese/Mplus1p-Regular.drop-hints.660E.ttf | Bin 1628 ->
- 1620 bytes
+ ...-Regular.default.3042,3044,3046,3048,304A,304B.ttf | Bin 3040 -> 3032 bytes
+ ...-Regular.default.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 3276 -> 3268 bytes
+ .../japanese/Mplus1p-Regular.default.61,63,65,6B.ttf | Bin 2592 -> 2584 bytes
+ ...-Regular.default.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 3572 -> 3564 bytes
+ .../japanese/Mplus1p-Regular.default.660E.ttf | Bin 2356 -> 2348 bytes
+ ...gular.drop-hints.3042,3044,3046,3048,304A,304B.ttf | Bin 2312 -> 2304 bytes
+ ...gular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 2548 -> 2540 bytes
+ .../Mplus1p-Regular.drop-hints.61,63,65,6B.ttf | Bin 1864 -> 1856 bytes
+ ...gular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 2844 -> 2836 bytes
+ .../japanese/Mplus1p-Regular.drop-hints.660E.ttf | Bin 1628 -> 1620 bytes
10 files changed, 0 insertions(+), 0 deletions(-)
commit 9b00b9a10d5fdfd2d9deb1b0e847695797b7e09b
@@ -31815,8 +31731,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Mar 6 17:47:40 2018 -0800
- [subset] Fix deadlock waiting for process output in subset test
- runner.
+ [subset] Fix deadlock waiting for process output in subset test runner.
test/subset/run-tests.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
@@ -31838,30 +31753,18 @@
test/subset/data/Makefile.am | 1 +
test/subset/data/Makefile.sources | 1 +
- ...-Regular.default.3042,3044,3046,3048,304A,304B.ttf | Bin 0 ->
- 3040 bytes
- ...-Regular.default.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 0 ->
- 3276 bytes
- .../japanese/Mplus1p-Regular.default.61,63,65,6B.ttf | Bin 0 ->
- 2592 bytes
- ...-Regular.default.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 0 ->
- 3572 bytes
- .../japanese/Mplus1p-Regular.default.660E.ttf | Bin 0 ->
- 2356 bytes
- ...gular.drop-hints.3042,3044,3046,3048,304A,304B.ttf | Bin 0 ->
- 2312 bytes
- ...gular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 0 ->
- 2548 bytes
- .../Mplus1p-Regular.drop-hints.61,63,65,6B.ttf | Bin 0 ->
- 1864 bytes
- ...gular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 0 ->
- 2844 bytes
- .../japanese/Mplus1p-Regular.drop-hints.660E.ttf | Bin 0 ->
- 1628 bytes
- test/subset/data/fonts/Mplus1p-Regular.ttf | Bin 0 ->
- 1758820 bytes
- test/subset/data/tests/japanese.tests | 16
- ++++++++++++++++
+ ...-Regular.default.3042,3044,3046,3048,304A,304B.ttf | Bin 0 -> 3040 bytes
+ ...-Regular.default.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 0 -> 3276 bytes
+ .../japanese/Mplus1p-Regular.default.61,63,65,6B.ttf | Bin 0 -> 2592 bytes
+ ...-Regular.default.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 0 -> 3572 bytes
+ .../japanese/Mplus1p-Regular.default.660E.ttf | Bin 0 -> 2356 bytes
+ ...gular.drop-hints.3042,3044,3046,3048,304A,304B.ttf | Bin 0 -> 2312 bytes
+ ...gular.drop-hints.3042,3044,3046,73E0,5EA6,8F38.ttf | Bin 0 -> 2548 bytes
+ .../Mplus1p-Regular.drop-hints.61,63,65,6B.ttf | Bin 0 -> 1864 bytes
+ ...gular.drop-hints.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 0 -> 2844 bytes
+ .../japanese/Mplus1p-Regular.drop-hints.660E.ttf | Bin 0 -> 1628 bytes
+ test/subset/data/fonts/Mplus1p-Regular.ttf | Bin 0 -> 1758820 bytes
+ test/subset/data/tests/japanese.tests | 16 ++++++++++++++++
14 files changed, 18 insertions(+)
commit 2ebf4c69b18452caa0c871aebec9785e80348166
@@ -31870,7 +31773,7 @@
Date: Thu Mar 8 14:41:59 2018 -0700
Merge pull request #868 from googlefonts/post
-
+
[subset] Drop glyph names from post when subsetting.
commit 869ccac5ab69060f2db2893014b5538539fd4f45
@@ -31877,8 +31780,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Mar 8 11:06:49 2018 -0800
- [subset] use create_sub_blob instead of manually copying the post
- table.
+ [subset] use create_sub_blob instead of manually copying the post table.
src/hb-ot-post-table.hh | 20 +++++++-------------
1 file changed, 7 insertions(+), 13 deletions(-)
@@ -31890,10 +31792,8 @@
[subset] Unit test to check that post subsetting drops glyph names.
test/api/Makefile.am | 2 +
- ...lus1p-Regular.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 3572 ->
- 3724 bytes
- test/api/test-subset-post.c | 61
- +++++++++++++++++++++
+ ...lus1p-Regular.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 3572 -> 3724 bytes
+ test/api/test-subset-post.c | 61 +++++++++++++++++++++
3 files changed, 63 insertions(+)
commit dd107699938740e261948e4b525fa0ad501beb03
@@ -31912,7 +31812,7 @@
Date: Wed Mar 7 12:36:00 2018 -0700
Merge pull request #867 from googlefonts/vmtx
-
+
[subset] Add vmtx subsetting.
commit 362f28240683fde395ff52f4fc1216fbc7131452
@@ -31952,8 +31852,7 @@
test/api/Makefile.am | 2 +
...lus1p-Regular.660E,6975,73E0,5EA6,8F38,6E05.ttf | Bin 0 -> 3572 bytes
test/api/fonts/Mplus1p-Regular.660E.ttf | Bin 0 -> 2356 bytes
- test/api/test-subset-vmtx.c | 100
- +++++++++++++++++++++
+ test/api/test-subset-vmtx.c | 100 +++++++++++++++++++++
4 files changed, 102 insertions(+)
commit 0e8f9430c83c076993a0c7a320713bb484051343
@@ -32009,13 +31908,12 @@
Date: Wed Mar 7 15:51:42 2018 +0100
Remove hb-ot-color.h
-
+
So I can make a release.
src/Makefile.sources | 1 -
src/hb-ot-color-cpal-table.hh | 48 +++++++++++++++++++++++++
- src/hb-ot-color.h | 81
- -------------------------------------------
+ src/hb-ot-color.h | 81 -------------------------------------------
src/hb-ot.h | 1 -
4 files changed, 48 insertions(+), 83 deletions(-)
@@ -32024,12 +31922,11 @@
Date: Wed Mar 7 15:31:15 2018 +0100
[ot] Remove hb-ot-base.h
-
+
BASE table API will go into hb-ot-layout.h.
src/Makefile.sources | 1 -
- src/hb-ot-base.h | 56
- ------------------------------------------
+ src/hb-ot-base.h | 56 ------------------------------------------
src/hb-ot-layout-base-table.hh | 1 -
src/hb-ot-layout.h | 16 ++++++++++++
src/hb-ot.h | 1 -
@@ -32040,9 +31937,9 @@
Date: Wed Mar 7 10:49:26 2018 +0100
[set] Fix algebra
-
+
Was totally b0rked. Ouch!
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/863
src/hb-set-private.hh | 20 +++++++++++++++++---
@@ -32053,9 +31950,9 @@
Date: Wed Mar 7 09:55:22 2018 +0100
[set] Minor
-
+
In preparation to fix https://github.com/harfbuzz/harfbuzz/issues/863
-
+
Binary operations are sets are completely broken. Ouch.
src/hb-set-private.hh | 21 ++++++++++++++-------
@@ -32103,13 +32000,12 @@
Date: Tue Mar 6 16:41:08 2018 +0330
[ot-color] Further improvements on COLR/CPAL implementation (#859)
-
+
* Implemented a bsearch on get_base_glyph_record
* Made get_color_record_argb actually work
src/hb-ot-color-colr-table.hh | 35 ++++++++++++++-----------
- src/hb-ot-color-cpal-table.hh | 59
- +++++++++++++++----------------------------
+ src/hb-ot-color-cpal-table.hh | 59 +++++++++++++++----------------------------
src/hb-ot-color.h | 12 ++-------
3 files changed, 42 insertions(+), 64 deletions(-)
@@ -32212,8 +32108,7 @@
Enable coverage test on autotools (#857)
configure.ac | 1 +
- m4/ax_code_coverage.m4 | 264
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ m4/ax_code_coverage.m4 | 264 +++++++++++++++++++++++++++++++++++++++++++++++++
src/Makefile.am | 6 +-
3 files changed, 269 insertions(+), 2 deletions(-)
@@ -32236,8 +32131,7 @@
[COLR/CPAL] Provide enough helper for rasterization (#855)
- src/hb-ot-colr-table.hh | 47
- ++++++++++++++++++++++++++++++++++++++++++++---
+ src/hb-ot-colr-table.hh | 47 ++++++++++++++++++++++++++++++++++++++++++++---
src/hb-ot-cpal-table.hh | 18 +++++++++++++++---
2 files changed, 59 insertions(+), 6 deletions(-)
@@ -32246,9 +32140,8 @@
Date: Sat Mar 3 01:05:59 2018 +0330
[COLR] Revert previous sanitization on the table
-
- That sanitization wasn't right, firstLayerIndex is an index from
- beginning of the Layer Records
+
+ That sanitization wasn't right, firstLayerIndex is an index from beginning of the Layer Records
not the table itself.
src/hb-ot-colr-table.hh | 23 ++++++-----------------
@@ -32269,8 +32162,7 @@
[aat/kerx] Make parsing of the table actually work (#850)
- src/hb-aat-layout-kerx-table.hh | 298
- +++++++++++++++++-----------------------
+ src/hb-aat-layout-kerx-table.hh | 298 +++++++++++++++++-----------------------
1 file changed, 124 insertions(+), 174 deletions(-)
commit a570edcde2f89e59b5ccd4867a8c0eed084bf35d
@@ -32296,11 +32188,10 @@
Date: Wed Feb 28 16:31:46 2018 -0800
[test] Add test suite for Brahmi Number Joiners
-
+
https://github.com/harfbuzz/harfbuzz/pull/660
- .../fonts/1ed7e9064f008f62de6ff0207bb4dd29409597a5.ttf | Bin 0 ->
- 2768 bytes
+ .../fonts/1ed7e9064f008f62de6ff0207bb4dd29409597a5.ttf | Bin 0 -> 2768 bytes
test/shaping/data/in-house/tests/use-syllable.tests | 1 +
test/shaping/record-test.sh | 2 +-
3 files changed, 2 insertions(+), 1 deletion(-)
@@ -32309,8 +32200,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Feb 28 15:44:00 2018 -0800
- [subset] In subset integration test pass output through ots-sanitize
- if present.
+ [subset] In subset integration test pass output through ots-sanitize if present.
test/subset/run-tests.py | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
@@ -32321,7 +32211,7 @@
Date: Wed Feb 28 13:52:29 2018 -0800
Merge pull request #845 from googlefonts/drophints
-
+
[subset] drop hints from composites
commit b3f1a045a8b86747afce6bc154f2a166ea678efb
@@ -32347,7 +32237,7 @@
Date: Wed Feb 28 15:43:23 2018 +0330
Use old project location of coverity
-
+
https://github.com/harfbuzz/harfbuzz/commit/8089711a61687d565f207c56d3d2b658f514d7ab#commitcomment-27835452
.travis.yml | 4 ++--
@@ -32359,7 +32249,7 @@
Date: Wed Feb 28 13:30:17 2018 +0330
Merge pull request #847 from ebraminio/colr
-
+
[colr] Implement
commit f671f7f0a8caa7b5763e00146e1ec4b9a7258227
@@ -32371,8 +32261,7 @@
src/Makefile.sources | 1 +
src/hb-ot-color.cc | 9 +++++
src/hb-ot-color.h | 9 -----
- src/hb-ot-colr-table.hh | 98
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-colr-table.hh | 98 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-cpal-table.hh | 6 +--
src/hb-ot-layout-private.hh | 6 ++-
src/hb-ot-layout.cc | 11 +++--
@@ -32384,7 +32273,7 @@
Date: Wed Feb 28 12:05:49 2018 +0330
Merge pull request #841 from ebraminio/color
-
+
Support CPAL table
commit 0eec33154a418fba97a08be7169b59e748b7e785
@@ -32393,8 +32282,7 @@
[cmake] cleanup (#846)
- CMakeLists.txt | 70
- ++++++++++++++++++++-----------------------------
+ CMakeLists.txt | 70 ++++++++++++++++++++-----------------------------
test/api/CMakeLists.txt | 2 +-
2 files changed, 30 insertions(+), 42 deletions(-)
@@ -32408,8 +32296,7 @@
src/Makefile.am | 1 -
src/hb-ot-color.cc | 70 +++----------
src/hb-ot-color.h | 31 +++---
- src/hb-ot-cpal-table.hh | 116
- +++++++++++++++------
+ src/hb-ot-cpal-table.hh | 116 +++++++++++++++------
src/hb-ot-layout-private.hh | 3 +-
src/hb-ot-layout.cc | 5 +-
test/api/hb-test.h | 2 +
@@ -32422,8 +32309,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Tue Feb 27 20:51:12 2018 -0800
- [subset] remove WE_HAVE_INSTRUCTIONS from composites when dropping
- hints
+ [subset] remove WE_HAVE_INSTRUCTIONS from composites when dropping hints
src/hb-subset-glyf.cc | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
@@ -32435,8 +32321,7 @@
[subset] update the test file for composite, fix an offset calculation
src/hb-ot-glyf-table.hh | 2 +-
- test/api/fonts/Roboto-Regular.components.1fc.nohints.ttf | Bin 0 ->
- 932 bytes
+ test/api/fonts/Roboto-Regular.components.1fc.nohints.ttf | Bin 0 -> 932 bytes
test/api/test-subset-glyf.c | 5 ++---
3 files changed, 3 insertions(+), 4 deletions(-)
@@ -32445,8 +32330,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Tue Feb 27 17:25:32 2018 -0800
- Merge branch 'expand-tests' of github.com:googlefonts/harfbuzz
- into drophints
+ Merge branch 'expand-tests' of github.com:googlefonts/harfbuzz into drophints
commit 904dd7beea756fd7429fad36f5c37321aedb4e81
Author: Garret Rieger <grieger at google.com>
@@ -32454,10 +32338,8 @@
[subset] Add drop hinting profile to full-font.tests
- .../Roboto-Regular.drop-hints.1FC,21,41,20,62,63.ttf | Bin 0 ->
- 2152 bytes
- .../full-font/Roboto-Regular.drop-hints.61,62,63.ttf | Bin 0 ->
- 1968 bytes
+ .../Roboto-Regular.drop-hints.1FC,21,41,20,62,63.ttf | Bin 0 -> 2152 bytes
+ .../full-font/Roboto-Regular.drop-hints.61,62,63.ttf | Bin 0 -> 1968 bytes
test/subset/data/tests/full-font.tests | 1 +
3 files changed, 1 insertion(+)
@@ -32467,16 +32349,11 @@
[subset] Add a drop hints profile to basics.tests
- .../basics/Roboto-Regular.abc.drop-hints.61,62,63.ttf | Bin 0 ->
- 876 bytes
- .../basics/Roboto-Regular.abc.drop-hints.61,63.ttf | Bin 0 ->
- 792 bytes
- .../expected/basics/Roboto-Regular.abc.drop-hints.61.ttf | Bin 0 ->
- 684 bytes
- .../expected/basics/Roboto-Regular.abc.drop-hints.62.ttf | Bin 0 ->
- 652 bytes
- .../expected/basics/Roboto-Regular.abc.drop-hints.63.ttf | Bin 0 ->
- 656 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.61,62,63.ttf | Bin 0 -> 876 bytes
+ .../basics/Roboto-Regular.abc.drop-hints.61,63.ttf | Bin 0 -> 792 bytes
+ .../expected/basics/Roboto-Regular.abc.drop-hints.61.ttf | Bin 0 -> 684 bytes
+ .../expected/basics/Roboto-Regular.abc.drop-hints.62.ttf | Bin 0 -> 652 bytes
+ .../expected/basics/Roboto-Regular.abc.drop-hints.63.ttf | Bin 0 -> 656 bytes
test/subset/data/profiles/drop-hints.txt | 1 +
test/subset/data/tests/basics.tests | 1 +
7 files changed, 2 insertions(+)
@@ -32485,8 +32362,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Feb 27 13:15:40 2018 -0800
- [subset] apply subset profiles (flags) to the subset integration
- tests.
+ [subset] apply subset profiles (flags) to the subset integration tests.
test/subset/generate-expected-outputs.py | 27 ++++++++++++++-------------
test/subset/run-tests.py | 3 ++-
@@ -32509,12 +32385,9 @@
[subset] Add subset integration tests using the full roboto font.
test/subset/data/Makefile.sources | 1 +
- .../Roboto-Regular.default.1FC,21,41,20,62,63.ttf | Bin 0 ->
- 3700 bytes
- .../full-font/Roboto-Regular.default.61,62,63.ttf | Bin 0 ->
- 3320 bytes
- test/subset/data/fonts/Roboto-Regular.ttf | Bin 0 ->
- 171676 bytes
+ .../Roboto-Regular.default.1FC,21,41,20,62,63.ttf | Bin 0 -> 3700 bytes
+ .../full-font/Roboto-Regular.default.61,62,63.ttf | Bin 0 -> 3320 bytes
+ test/subset/data/fonts/Roboto-Regular.ttf | Bin 0 -> 171676 bytes
test/subset/data/tests/full-font.tests | 10 ++++++++++
test/subset/generate-expected-outputs.py | 12 ++++++++----
6 files changed, 19 insertions(+), 4 deletions(-)
@@ -32525,14 +32398,10 @@
[subset] Add some more variations of the basic test.
- .../basics/Roboto-Regular.abc.default.61,62,63.ttf | Bin 0 ->
- 2120 bytes
- .../expected/basics/Roboto-Regular.abc.default.61,63.ttf | Bin 0 ->
- 1932 bytes
- .../expected/basics/Roboto-Regular.abc.default.61.ttf | Bin 0 ->
- 1744 bytes
- .../expected/basics/Roboto-Regular.abc.default.63.ttf | Bin 0 ->
- 1668 bytes
+ .../basics/Roboto-Regular.abc.default.61,62,63.ttf | Bin 0 -> 2120 bytes
+ .../expected/basics/Roboto-Regular.abc.default.61,63.ttf | Bin 0 -> 1932 bytes
+ .../expected/basics/Roboto-Regular.abc.default.61.ttf | Bin 0 -> 1744 bytes
+ .../expected/basics/Roboto-Regular.abc.default.63.ttf | Bin 0 -> 1668 bytes
test/subset/data/tests/basics.tests | 4 ++++
5 files changed, 4 insertions(+)
@@ -32552,7 +32421,7 @@
Date: Tue Feb 27 17:06:27 2018 -0700
Merge pull request #842 from googlefonts/maxp
-
+
[subset] when dropping hints, clear hint related fields in maxp.
commit 921b65cbc29f0c2c9c13e9fb272dafe4c8a14591
@@ -32577,11 +32446,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Feb 27 14:11:36 2018 -0800
- [subset] Add maxpV1Tail instead of defining a struct inside maxp
- for v1 data.
+ [subset] Add maxpV1Tail instead of defining a struct inside maxp for v1 data.
- src/hb-ot-maxp-table.hh | 81
- ++++++++++++++++++++++++++++++-------------------
+ src/hb-ot-maxp-table.hh | 81 ++++++++++++++++++++++++++++++-------------------
1 file changed, 49 insertions(+), 32 deletions(-)
commit f14d1b64c2d148ffdec95c17adbee3f185d5d436
@@ -32590,8 +32457,7 @@
[subset] when dropping hints, clear hint related fields in maxp.
- src/hb-ot-maxp-table.hh | 43
- ++++++++++++++++++++++++++++++++++++++++---
+ src/hb-ot-maxp-table.hh | 43 ++++++++++++++++++++++++++++++++++++++++---
test/api/test-subset-glyf.c | 30 +++++++++++++++++++++++-------
2 files changed, 63 insertions(+), 10 deletions(-)
@@ -32601,8 +32467,7 @@
[BASE] More
- src/hb-ot-layout-base-table.hh | 153
- ++++-------------------------------------
+ src/hb-ot-layout-base-table.hh | 153 ++++-------------------------------------
1 file changed, 12 insertions(+), 141 deletions(-)
commit 7a70c20fec6ece9e729dc2634e2896a8d8eb9962
@@ -32611,8 +32476,7 @@
[BASE] Clean up first 29%
- src/hb-ot-layout-base-table.hh | 262
- +++++++++++++++++++----------------------
+ src/hb-ot-layout-base-table.hh | 262 +++++++++++++++++++----------------------
src/hb-ot-layout-gsub-table.hh | 2 +-
2 files changed, 125 insertions(+), 139 deletions(-)
@@ -32629,7 +32493,7 @@
Date: Tue Feb 27 11:41:12 2018 +0330
Merge pull request #838 from harfbuzz/BASE
-
+
BASE table
commit 0ad8c663e0b4602e2a413e77a8158bf8a46755d5
@@ -32640,8 +32504,7 @@
src/hb-ot-base.h | 4 ++--
src/hb-ot-layout-base-table.hh | 20 +++++++++---------
- src/hb-ot-layout.cc | 48
- ++++++++++++++++++++----------------------
+ src/hb-ot-layout.cc | 48 ++++++++++++++++++++----------------------
3 files changed, 35 insertions(+), 37 deletions(-)
commit 4a1d51ef15a423706406f784a146078073147885
@@ -32650,7 +32513,7 @@
Date: Mon Feb 26 20:23:41 2018 -0800
Merge pull request #818 from googlefonts/drophints
-
+
[subset] Drop hints
commit 903771b6c7689b9eee9a11bac128c42f39833b2e
@@ -32657,8 +32520,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Mon Feb 26 19:50:06 2018 -0800
- [subset] clearer name for trim() and better comment about composite
- handling, per review feedback
+ [subset] clearer name for trim() and better comment about composite handling, per review feedback
src/hb-ot-glyf-table.hh | 8 +++++---
src/hb-subset-glyf.cc | 17 ++++++++---------
@@ -32670,7 +32532,7 @@
Date: Mon Feb 26 19:24:18 2018 -0700
Merge pull request #840 from googlefonts/os2
-
+
[subset] During os2 subsetting update ulUnicodeRange[]c
commit 44dc36dd82fc948a15e2ad0d605eb4a466b3553d
@@ -32706,8 +32568,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 26 17:47:10 2018 -0800
- [subset] Move util/generated-unicode-ranges.py to
- src/gen-unicode-ranges.py
+ [subset] Move util/generated-unicode-ranges.py to src/gen-unicode-ranges.py
util/generate-unicode-ranges.py => src/gen-unicode-ranges.py | 0
1 file changed, 0 insertions(+), 0 deletions(-)
@@ -32762,11 +32623,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 26 15:59:32 2018 -0800
- [subset] Add python util that was used to generated
- hb-ot-os2-unicode-ranges.hh
+ [subset] Add python util that was used to generated hb-ot-os2-unicode-ranges.hh
- util/generate-unicode-ranges.py | 50
- +++++++++++++++++++++++++++++++++++++++++
+ util/generate-unicode-ranges.py | 50 +++++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
commit f757757eda5f00a89a156e3427bdf8c4313611ef
@@ -32797,10 +32656,8 @@
src/Makefile.sources | 1 -
src/hb-ot-os2-table.hh | 23 ++++-
- src/hb-ot-os2-unicode-ranges.cc | 221
- ++--------------------------------------
- src/hb-ot-os2-unicode-ranges.hh | 210
- +++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-os2-unicode-ranges.cc | 221 ++--------------------------------------
+ src/hb-ot-os2-unicode-ranges.hh | 210 +++++++++++++++++++++++++++++++++++++-
4 files changed, 236 insertions(+), 219 deletions(-)
commit a570142d0c6d819feeeeb9e209fc90a33c1c2b48
@@ -32807,13 +32664,11 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 26 15:20:23 2018 -0800
- [subset] Move hb-ot-os2-unicode-ranges into a cc file with a helper
- methods and tests.
+ [subset] Move hb-ot-os2-unicode-ranges into a cc file with a helper methods and tests.
src/Makefile.am | 9 +-
src/Makefile.sources | 2 +
- src/hb-ot-os2-unicode-ranges.cc | 279
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-os2-unicode-ranges.cc | 279 ++++++++++++++++++++++++++++++++++++++++
src/hb-ot-os2-unicode-ranges.hh | 189 +--------------------------
4 files changed, 292 insertions(+), 187 deletions(-)
@@ -32823,8 +32678,7 @@
[subset] Add hb-ot-os2-unicode-ranges.hh, a map of os2 unicode ranges.
- src/hb-ot-os2-unicode-ranges.hh | 220
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-os2-unicode-ranges.hh | 220 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 220 insertions(+)
commit 6c844ae8e89f52f5f40eace66bb987544fc316e3
@@ -32860,9 +32714,8 @@
Date: Mon Feb 26 01:04:16 2018 -0800
[aat/ankr] Minor
-
- DEFINE_SIZE_MIN is to be used only in rare cases. For fixed-size
- structs
+
+ DEFINE_SIZE_MIN is to be used only in rare cases. For fixed-size structs
we want DEFINE_SIZE_STATIC.
src/hb-aat-layout-ankr-table.hh | 2 +-
@@ -32892,8 +32745,7 @@
[aat/trak] Simplify sanitize()
- src/hb-aat-layout-trak-table.hh | 67
- ++++++++++-------------------------------
+ src/hb-aat-layout-trak-table.hh | 67 ++++++++++-------------------------------
1 file changed, 16 insertions(+), 51 deletions(-)
commit f0bc6c0992c4302ae1a20f155ad256bfa331087c
@@ -32901,10 +32753,10 @@
Date: Mon Feb 26 00:18:17 2018 -0800
[aat/trak] Clean up
-
+
We always just used "unsigned int" for counter values. There's
no use for uint16_t outside of a struct.
-
+
Also, no need for explict casting where implicit does.
src/hb-aat-layout-trak-table.hh | 12 ++++++------
@@ -32917,8 +32769,7 @@
[aat] trak sanitization
src/dev-run.sh | 4 +-
- src/hb-aat-layout-trak-table.hh | 95
- ++++++++++++++++++++++++++++++++---------
+ src/hb-aat-layout-trak-table.hh | 95 ++++++++++++++++++++++++++++++++---------
src/hb-aat-layout.cc | 2 +-
util/options.hh | 2 +-
4 files changed, 78 insertions(+), 25 deletions(-)
@@ -32928,7 +32779,7 @@
Date: Mon Feb 26 11:29:48 2018 +0330
[aat] minor
-
+
Ops, this was done for testing
src/hb-aat-layout-ankr-table.hh | 2 +-
@@ -32949,11 +32800,10 @@
Date: Sun Feb 25 18:54:52 2018 -0800
[aat/trak] Minor
-
+
Maybe we should make DEFINE_* make structs uncopyable.
- src/hb-aat-layout-trak-table.hh | 56
- +++++++++++++++++++++++------------------
+ src/hb-aat-layout-trak-table.hh | 56 +++++++++++++++++++++++------------------
1 file changed, 32 insertions(+), 24 deletions(-)
commit ae14dd0fb0a176f6f0143690907b51626999d248
@@ -32963,8 +32813,7 @@
[aat] Implement ankr
src/Makefile.sources | 3 +-
- src/hb-aat-layout-ankr-table.hh | 86
- +++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-ankr-table.hh | 86 +++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout-kerx-table.hh | 2 +-
src/hb-aat-layout.cc | 37 +++++++++++++-----
src/hb-ot-layout-private.hh | 6 ++-
@@ -32979,8 +32828,7 @@
src/Makefile.sources | 1 -
src/hb-ot-base.cc | 58 -----------------------
- src/hb-ot-layout-base-table.hh | 103
- ++++++++++++++++++++++++++++-------------
+ src/hb-ot-layout-base-table.hh | 103 ++++++++++++++++++++++++++++-------------
src/hb-ot-layout.cc | 34 ++++++++++++++
src/hb-ot-layout.h | 1 +
5 files changed, 105 insertions(+), 92 deletions(-)
@@ -33006,7 +32854,7 @@
Date: Sat Feb 24 00:44:07 2018 +0200
Workaround for old automake on Travis Linux images
-
+
https://github.com/harfbuzz/harfbuzz/pull/821#issuecomment-368116538
.ci/fail.sh | 10 ++++++++--
@@ -33031,8 +32879,7 @@
src/hb-aat-layout-kerx-table.hh | 7 ++++
src/hb-aat-layout-private.hh | 3 ++
- src/hb-aat-layout-trak-table.hh | 78
- +++++++++++++++++++++++++++++++++++++++--
+ src/hb-aat-layout-trak-table.hh | 78 +++++++++++++++++++++++++++++++++++++++--
src/hb-aat-layout.cc | 46 ++++++++++++++++++++++++
src/hb-open-type-private.hh | 4 +--
src/hb-ot-layout-private.hh | 22 ++++++++++++
@@ -33049,8 +32896,7 @@
CMakeLists.txt | 36 ++++++++++++++--------------
src/Makefile.am | 8 +++----
src/Makefile.sources | 3 ---
- src/hb-version.h | 66
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-version.h | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 87 insertions(+), 26 deletions(-)
commit 5267520e078ed413df78f3a6781fd5370b6da63a
@@ -33077,8 +32923,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Fri Feb 23 17:53:26 2018 -0800
- Merge branch 'master' of https://github.com/harfbuzz/harfbuzz into
- drophints
+ Merge branch 'master' of https://github.com/harfbuzz/harfbuzz into drophints
commit 1454d82a9d3d9a47901b3d92ff7f2c05c596c0d5
Author: Rod Sheeter <rsheeter at google.com>
@@ -33094,8 +32939,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Fri Feb 23 17:43:00 2018 -0800
- [subset] zero glyf and loca memory before writing so pads are
- clean. Test just the part of maxp we care about
+ [subset] zero glyf and loca memory before writing so pads are clean. Test just the part of maxp we care about
src/hb-ot-glyf-table.hh | 6 +++---
src/hb-subset-glyf.cc | 4 ++--
@@ -33108,7 +32952,7 @@
Date: Fri Feb 23 18:33:25 2018 -0700
Merge pull request #829 from googlefonts/test-checksum
-
+
[subset] Caclculate head table checksum adjustment
commit dc5c7927e75ea09461e46fe6e56897091b4b4f00
@@ -33116,12 +32960,11 @@
Date: Fri Feb 23 16:42:06 2018 -0800
[subset] Caclculate head table checksum adjustment
-
+
Test still fails, because we do not serialize tables in the same
order that fonttools subsetter does.
- src/hb-open-file-private.hh | 51
- ++++++++++++++++++++++++++++++++++-----------
+ src/hb-open-file-private.hh | 51 ++++++++++++++++++++++++++++++++++-----------
src/hb-ot-head-table.hh | 2 ++
src/hb-subset.cc | 2 ++
3 files changed, 43 insertions(+), 12 deletions(-)
@@ -33132,7 +32975,7 @@
Date: Fri Feb 23 17:59:08 2018 -0700
Merge pull request #828 from googlefonts/mem-fixes
-
+
[subset] Fix several memory leaks in subsetting.
commit ec2538c8803be254b6e09ca0ea724b07c35126da
@@ -33207,8 +33050,7 @@
configure.ac | 2 ++
src/Makefile.am | 4 ++-
- src/harfbuzz-config.cmake.in | 82
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/harfbuzz-config.cmake.in | 82 ++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 87 insertions(+), 1 deletion(-)
commit e0939d811f1fdeda9c5763e7e53887b3d3cb21eb
@@ -33216,18 +33058,17 @@
Date: Fri Feb 23 13:19:34 2018 -0800
Clean up check-defs and check-symbols (#821)
-
+
Also, call c++filt on their results.
-
+
Also build and fix and check harfbuzz-gobject.def
-
+
Also changes harfbuzz-gobject to distribute generated enum sources.
CMakeLists.txt | 3 +--
src/Makefile.am | 33 ++++++++++++++++------------
src/Makefile.sources | 9 +++++---
- src/check-defs.sh | 52
- ---------------------------------------------
+ src/check-defs.sh | 52 ---------------------------------------------
src/check-symbols.sh | 30 ++++++++++++++++++++------
src/hb-gobject-enums.h.tmpl | 3 ++-
src/hb-gobject-structs.h | 45 ++++++++++++++++++++++++++-------------
@@ -33239,8 +33080,7 @@
[subset] clone trim logic from fonttools glyf handling
- src/hb-ot-glyf-table.hh | 92
- ++++++++++++++++++++++++++-
+ src/hb-ot-glyf-table.hh | 92 ++++++++++++++++++++++++++-
src/hb-subset-glyf.cc | 26 ++++----
src/hb-subset-plan.cc | 3 +
src/hb-subset.cc | 13 ++--
@@ -33255,7 +33095,7 @@
Date: Fri Feb 23 12:32:18 2018 -0700
Merge pull request #823 from googlefonts/hdmx
-
+
[subset] Add hdmx subsetting.
commit e15e41ef12e146333e355defef8db210378b5be0
@@ -33271,11 +33111,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 22 18:38:44 2018 -0800
- [subset] Update expected files for subsetting integration test to
- not include cmap 4.
+ [subset] Update expected files for subsetting integration test to not include cmap 4.
- .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1740 ->
- 1692 bytes
+ .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1740 -> 1692 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit a88504c601ac95601730bd602861c13e5ac4fdd8
@@ -33282,11 +33120,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 22 14:28:18 2018 -0800
- [subset] Fix checksum clearning in subset test diff. Add an updated
- expected file (has cmap4 restored).
+ [subset] Fix checksum clearning in subset test diff. Add an updated expected file (has cmap4 restored).
- .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1692 ->
- 1740 bytes
+ .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1692 -> 1740 bytes
test/subset/run-tests.py | 7 +++++--
2 files changed, 5 insertions(+), 2 deletions(-)
@@ -33294,8 +33130,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 22 14:07:52 2018 -0800
- [subset] Don't compare actual to itself in Fix
- test/subset/run-tests. Print a diff on failure.
+ [subset] Don't compare actual to itself in Fix test/subset/run-tests. Print a diff on failure.
test/subset/run-tests.py | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
@@ -33323,11 +33158,10 @@
Date: Fri Feb 23 10:34:26 2018 -0800
[hdmx] Move DeviceRecord to toplevel again
-
+
More readable.
- src/hb-ot-hdmx-table.hh | 112
- ++++++++++++++++++++++++------------------------
+ src/hb-ot-hdmx-table.hh | 112 ++++++++++++++++++++++++------------------------
1 file changed, 57 insertions(+), 55 deletions(-)
commit 96d7805a9235443972c6b6c5cd9502283c8836e9
@@ -33373,8 +33207,7 @@
[subset] Add a unit test for hdmx subsetting.
test/api/Makefile.am | 2 ++
- test/api/test-subset-hdmx.c | 81
- +++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-subset-hdmx.c | 81 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 83 insertions(+)
commit aa4aa2353c52f86fd56446de6b7ff86a9e990b9c
@@ -33392,8 +33225,7 @@
[subset] Move DeviceRecord inside of hdmx.
- src/hb-ot-hdmx-table.hh | 98
- +++++++++++++++++++++++++------------------------
+ src/hb-ot-hdmx-table.hh | 98 +++++++++++++++++++++++++------------------------
1 file changed, 50 insertions(+), 48 deletions(-)
commit 6704cded65985b2de262bdd3bb0887929e5a3b0b
@@ -33418,8 +33250,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Feb 21 15:36:09 2018 -0800
- [subset] When serializing a DeviceRecord in hdmx pad to make 32
- bit aligned.
+ [subset] When serializing a DeviceRecord in hdmx pad to make 32 bit aligned.
src/hb-ot-hdmx-table.hh | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
@@ -33430,8 +33261,7 @@
[subset] Begin implementing serialize for hdmx.
- src/hb-ot-hdmx-table.hh | 79
- +++++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-hdmx-table.hh | 79 +++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 77 insertions(+), 2 deletions(-)
commit fe42862ab30d17483a1d0c2e2b1d859d01bbaff1
@@ -33441,8 +33271,7 @@
[subset] Sketch out a basic hb-ot-hdmx.hh.
src/Makefile.sources | 1 +
- src/hb-ot-hdmx-table.hh | 77
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-hdmx-table.hh | 77 +++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset.cc | 1 +
3 files changed, 79 insertions(+)
@@ -33478,13 +33307,10 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Wed Feb 21 22:23:05 2018 -0800
- [subset] sketch out dropping in-glyf instructions. Sometimes yields
- differnet size glyphs than fonttools, possibly due to padding not
- being corrected
+ [subset] sketch out dropping in-glyf instructions. Sometimes yields differnet size glyphs than fonttools, possibly due to padding not being corrected
src/hb-ot-glyf-table.hh | 45 ++++++++++++++++
- src/hb-subset-glyf.cc | 78
- +++++++++++++++++++++------
+ src/hb-subset-glyf.cc | 78 +++++++++++++++++++++------
src/hb-subset-input.cc | 6 +++
src/hb-subset.h | 2 +
test/api/fonts/Roboto-Regular.ac.nohints.ttf | Bin 0 -> 1128 bytes
@@ -33509,11 +33335,10 @@
Date: Wed Feb 21 14:38:02 2018 -0800
Add two more ragel-generated headers
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/817
- src/hb-buffer-deserialize-json.hh | 643
- ++++++++++++++++++++++++++++++++++++++
+ src/hb-buffer-deserialize-json.hh | 643 ++++++++++++++++++++++++++++++++++++++
src/hb-buffer-deserialize-text.hh | 571 +++++++++++++++++++++++++++++++++
2 files changed, 1214 insertions(+)
@@ -33521,8 +33346,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Wed Feb 21 11:19:18 2018 -0800
- [subset] drop hint tables if so flagged. Still need to dump glyf
- instructions.
+ [subset] drop hint tables if so flagged. Still need to dump glyf instructions.
src/hb-subset-plan.cc | 1 +
src/hb-subset-plan.hh | 2 ++
@@ -33538,7 +33362,7 @@
Date: Wed Feb 21 22:13:58 2018 +0330
Add .editorconfig (#810)
-
+
More information: http://editorconfig.org/
.editorconfig | 18 ++++++++++++++++++
@@ -33579,8 +33403,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Feb 20 18:13:41 2018 -0800
- [subset] fix calculation of range shiftz. Should be 16 * len -
- searchRange not 16 * (len - searchRange).
+ [subset] fix calculation of range shiftz. Should be 16 * len - searchRange not 16 * (len - searchRange).
src/hb-open-type-private.hh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
@@ -33589,8 +33412,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Feb 20 17:36:54 2018 -0800
- [subset] Reverse table order for font serialization to match what
- OTS expects.
+ [subset] Reverse table order for font serialization to match what OTS expects.
src/hb-open-file-private.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -33599,8 +33421,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Tue Feb 20 16:48:52 2018 -0800
- [subset] sanity check glyph data writes during glyph subsetting to
- ensure they are inbounds.
+ [subset] sanity check glyph data writes during glyph subsetting to ensure they are inbounds.
src/hb-subset-glyf.cc | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
@@ -33611,8 +33432,7 @@
[subset] Sanity check that loca writes are inbounds.
- src/hb-subset-glyf.cc | 55
- ++++++++++++++++++++++++++++++++++++++-------------
+ src/hb-subset-glyf.cc | 55 ++++++++++++++++++++++++++++++++++++++-------------
1 file changed, 41 insertions(+), 14 deletions(-)
commit 73e20ec6e9ad86bea023fc8b6fc10287889ed048
@@ -33621,7 +33441,7 @@
Date: Tue Feb 20 17:34:59 2018 -0700
Merge pull request #812 from googlefonts/cleanup
-
+
Clean up of glyf subsetting.
commit 6ae4013f2e53d6496507a58b715298fee4eadcee
@@ -33638,20 +33458,18 @@
Date: Tue Feb 20 14:34:16 2018 -0800
Add Ragel-generated files to git
-
+
I know it's bad form; I know I've said no to this multiple times...
- But this is part of an experiment to see if we can make rolling
- HarfBuzz
+ But this is part of an experiment to see if we can make rolling HarfBuzz
into Chrome much faster. That will give us a lot more testing exposure
that currently Chrome does.
-
+
Doing this while those files are still considered ignored by our
gitignore rules; will see how that flies.
autogen.sh | 10 +-
src/Makefile.am | 3 +-
- src/hb-ot-shape-complex-indic-machine.hh | 1319
- ++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-indic-machine.hh | 1319 ++++++++++++++++++++++++++++
src/hb-ot-shape-complex-khmer-machine.hh | 294 +++++++
src/hb-ot-shape-complex-myanmar-machine.hh | 413 +++++++++
src/hb-ot-shape-complex-use-machine.hh | 502 +++++++++++
@@ -33673,10 +33491,8 @@
[subset] Move glyf subsetting code into hb-ot-glyf-table.hh
- src/hb-ot-glyf-table.hh | 49
- +++++++++++++++++++++++++++++++++++++++++++++++-
- src/hb-subset.cc | 50
- +------------------------------------------------
+ src/hb-ot-glyf-table.hh | 49 +++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-subset.cc | 50 +------------------------------------------------
2 files changed, 49 insertions(+), 50 deletions(-)
commit d1f16fce963092404bf0b59e449a3215ca031b54
@@ -33684,11 +33500,10 @@
Date: Tue Feb 20 10:32:09 2018 -0800
Don't use %zu
-
- Some of our bots / compilers don't like it. Wasn't caught by bots
- because this
+
+ Some of our bots / compilers don't like it. Wasn't caught by bots because this
is only in debug code.
-
+
https://github.com/harfbuzz/harfbuzz/pull/809/commits/825ad378e0f0e6e6bb690894a0d5d25f198be21b
src/hb-ot-cmap-table.hh | 2 +-
@@ -33717,7 +33532,7 @@
Date: Tue Feb 20 10:26:07 2018 +0200
Use %zu format specifier for size_t to fix cross platform build
-
+
Fixes Chromium Android builds, compare
https://ci.chromium.org/buildbot/tryserver.chromium.android/linux_android_rel_ng/491787
@@ -33740,8 +33555,7 @@
[aat] First dig on 'trak'
src/Makefile.sources | 3 +-
- src/hb-aat-layout-trak-table.hh | 100
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-trak-table.hh | 100 ++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 3 +-
src/hb-ot-layout-private.hh | 6 ++-
4 files changed, 108 insertions(+), 4 deletions(-)
@@ -33798,7 +33612,7 @@
Date: Mon Feb 19 11:06:13 2018 +0330
Test debug builds on ArchLinux bot
-
+
Fixes #805
.circleci/config.yml | 6 +++---
@@ -33809,14 +33623,12 @@
Date: Sun Feb 18 17:28:53 2018 -0800
Limit how much work sanitize() can do
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6022
src/Makefile.am | 2 ++
- src/hb-open-type-private.hh | 16
- ++++++++++++++--
- .../233c1e252e737ca79e03a9fd56b71aaa4a230f2b.ttf | Bin 0 ->
- 1048576 bytes
+ src/hb-open-type-private.hh | 16 ++++++++++++++--
+ .../233c1e252e737ca79e03a9fd56b71aaa4a230f2b.ttf | Bin 0 -> 1048576 bytes
test/shaping/data/in-house/tests/fuzzed.tests | 1 +
4 files changed, 17 insertions(+), 2 deletions(-)
@@ -33834,7 +33646,7 @@
Date: Sun Feb 18 16:27:59 2018 -0800
Fix debug build
-
+
Context needs to be called 'c'. The TRACE_* rely on that.
src/hb-ot-cmap-table.hh | 22 +++++++++++-----------
@@ -33863,10 +33675,10 @@
Date: Sun Feb 18 15:57:09 2018 -0800
Readjust mark attachment heuristic a bit more
-
+
Previously adjusted logic could fail if nothing around was ligated,
and something moved. This should take care of that.
-
+
CC https://github.com/harfbuzz/harfbuzz/issues/740
src/hb-ot-layout-gpos-table.hh | 5 ++++-
@@ -33878,8 +33690,7 @@
[test] Add test for https://github.com/harfbuzz/harfbuzz/issues/740
- .../fonts/573d3a3177c9a8646e94c8a0d7b224334340946a.ttf | Bin 0 ->
- 5680 bytes
+ .../fonts/573d3a3177c9a8646e94c8a0d7b224334340946a.ttf | Bin 0 -> 5680 bytes
test/shaping/data/in-house/tests/use.tests | 1 +
2 files changed, 1 insertion(+)
@@ -33890,8 +33701,7 @@
[aat] First dig on 'kerx' (#704)
src/Makefile.sources | 1 +
- src/hb-aat-layout-kerx-table.hh | 377
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-kerx-table.hh | 377 ++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 1 +
src/hb-ot-layout-private.hh | 2 +
4 files changed, 381 insertions(+)
@@ -33902,7 +33712,7 @@
Date: Sun Feb 18 14:04:33 2018 -0800
Merge pull request #796 from ebraminio/dev-run
-
+
Add a continuous builder using fswatch
commit e91644786bf7c278e75962b851d5d47011ff175c
@@ -33939,7 +33749,7 @@
Date: Sun Feb 18 23:25:15 2018 +0330
Another attempt on fixing coverity
-
+
I hope I am in a correct direction at least
.travis.yml | 5 ++---
@@ -33951,7 +33761,7 @@
Date: Sun Feb 18 11:35:51 2018 -0800
Merge pull request #800 from harfbuzz/bitops
-
+
Optimize set through optimized bit operations
commit 97a71102153d28982297a190739c7d82e76b109e
@@ -33959,7 +33769,7 @@
Date: Sun Feb 18 10:50:24 2018 -0800
Fix BitScanForward() usage
-
+
Should fix Win64 bot.
src/hb-private.hh | 4 ++--
@@ -33977,7 +33787,7 @@
Date: Fri Feb 16 12:08:55 2018 -0500
Do not mark the first glyph as unsafe to break
-
+
Fixes #791.
src/hb-buffer-private.hh | 3 +--
@@ -34019,11 +33829,10 @@
Date: Fri Feb 16 16:58:17 2018 -0800
Misc fixes
-
+
Should bring bag djgpp bot.
- src/hb-ot-os2-table.hh | 54
- +++++++++++++++++++++++++-------------------------
+ src/hb-ot-os2-table.hh | 54 +++++++++++++++++++++++++-------------------------
src/hb-subset-plan.cc | 16 +++++++--------
2 files changed, 34 insertions(+), 36 deletions(-)
@@ -34035,8 +33844,7 @@
.../api/fonts/Roboto-Regular.components.subset.ttf | Bin 0 -> 2052 bytes
test/api/fonts/Roboto-Regular.components.ttf | Bin 0 -> 2572 bytes
- test/api/test-subset-glyf.c | 21
- +++++++++++++++++++++
+ test/api/test-subset-glyf.c | 21 +++++++++++++++++++++
3 files changed, 21 insertions(+)
commit c36d015b0e9c363431cd9d228b776ad419fde474
@@ -34052,8 +33860,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 16 17:01:00 2018 -0700
- [subset] Add support for updating reference gids in components to
- their new values.
+ [subset] Add support for updating reference gids in components to their new values.
src/hb-subset-glyf.cc | 38 +++++++++++++++++++++++++++++++++-----
1 file changed, 33 insertions(+), 5 deletions(-)
@@ -34062,11 +33869,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 16 16:56:15 2018 -0700
- [subset] Refactor composite glyf iteration code into an Iterator
- outside of the accelerator.
+ [subset] Refactor composite glyf iteration code into an Iterator outside of the accelerator.
- src/hb-ot-glyf-table.hh | 110
- +++++++++++++++++++++++++-----------------------
+ src/hb-ot-glyf-table.hh | 110 +++++++++++++++++++++++++-----------------------
src/hb-subset-plan.cc | 6 +--
2 files changed, 60 insertions(+), 56 deletions(-)
@@ -34074,8 +33879,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 16 15:20:14 2018 -0700
- [subset] Use gids_to_retain_sorted to produce old gid -> new gid
- mapping since it now has the more complete set.
+ [subset] Use gids_to_retain_sorted to produce old gid -> new gid mapping since it now has the more complete set.
src/hb-subset-plan.cc | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
@@ -34094,8 +33898,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 16 11:20:38 2018 -0700
- [subset] add constant to get_composite and in_table methods in
- hb-ot-glyf-table
+ [subset] add constant to get_composite and in_table methods in hb-ot-glyf-table
src/hb-ot-glyf-table.hh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -34113,11 +33916,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 15 14:03:34 2018 -0800
- [subset] add helper methods to glyf accelerator for reading composite
- glyph information.
+ [subset] add helper methods to glyf accelerator for reading composite glyph information.
- src/hb-ot-glyf-table.hh | 115
- ++++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-glyf-table.hh | 115 ++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 112 insertions(+), 3 deletions(-)
commit cd11107bb44ac719709e10264e9e6ba6a1cfae0c
@@ -34125,7 +33926,7 @@
Date: Fri Feb 16 18:28:58 2018 -0800
Another bitops fallback fix
-
+
I'm confident that all bugs are hashed out now.
src/hb-private.hh | 4 ++--
@@ -34146,8 +33947,7 @@
[set] Implement iteration using bitop intrinsics
- src/hb-set-private.hh | 55
- ++++++++++++++++++---------------------------------
+ src/hb-set-private.hh | 55 ++++++++++++++++++---------------------------------
1 file changed, 19 insertions(+), 36 deletions(-)
commit 6a91a2eb04951f6e33706c2b8e9cd987b429fce9
@@ -34183,8 +33983,7 @@
Flesh out other bit ops some more for 128bit as well
- src/hb-private.hh | 165
- +++++++++++++++++++++++++++++++++++++++++-------------
+ src/hb-private.hh | 165 +++++++++++++++++++++++++++++++++++++++++-------------
1 file changed, 126 insertions(+), 39 deletions(-)
commit 864a2dddae9eb1303c59d0d3717fce307a72a524
@@ -34192,7 +33991,7 @@
Date: Fri Feb 16 14:21:40 2018 -0800
Clean up bit functions
-
+
Compile all code-paths possible, to better catch errors.
Also enable MSVC ones on mingw which seems to support them.
@@ -34204,14 +34003,13 @@
Date: Fri Feb 16 16:06:17 2018 -0800
Improve _hb_popcount()
-
+
Support 128bit type.
configure.ac | 3 ++-
src/hb-ot-layout-gpos-table.hh | 2 +-
src/hb-ot-map.cc | 2 +-
- src/hb-private.hh | 61
- +++++++++++++++++++++++++++---------------
+ src/hb-private.hh | 61 +++++++++++++++++++++++++++---------------
4 files changed, 44 insertions(+), 24 deletions(-)
commit 7b5ce7404716a17f91ff86d374c7b76ee7ce3247
@@ -34230,10 +34028,9 @@
Date: Fri Feb 16 15:36:20 2018 -0800
Enable C99 if available
+
+ Hopefully we can now mix-and-match code and declaration in the C test files.
- Hopefully we can now mix-and-match code and declaration in the C
- test files.
-
configure.ac | 1 +
1 file changed, 1 insertion(+)
@@ -34243,7 +34040,7 @@
Date: Fri Feb 16 15:27:29 2018 -0800
Merge pull request #792 from googlefonts/master
-
+
Support more tables in subsetter
commit 882a3bf4abcdac60414db41d54dbbb7d2368c908
@@ -34271,10 +34068,9 @@
Date: Fri Feb 16 21:45:08 2018 +0300
Remove checking macros __OPTIMIZE__ for MSVC
+
+ Visual C++ compiler doesn't define macros __OPTIMIZE__ when optimizations enabled
- Visual C++ compiler doesn't define macros __OPTIMIZE__ when
- optimizations enabled
-
src/hb-private.hh | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
@@ -34411,7 +34207,7 @@
Date: Thu Feb 15 02:52:15 2018 +0200
Move collect_logs to .ci dir
-
+
Next to other CI scripts.
.collect_logs => .ci/collect-logs.sh | 0
@@ -34435,8 +34231,7 @@
[subset] cmap space bracket
- src/hb-ot-cmap-table.hh | 72
- ++++++++++++++++++++++++-------------------------
+ src/hb-ot-cmap-table.hh | 72 ++++++++++++++++++++++++-------------------------
1 file changed, 36 insertions(+), 36 deletions(-)
commit e158739bfb9e5d60989e179fcc8744f3125e2067
@@ -34488,8 +34283,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Feb 14 18:43:53 2018 -0800
- [test] Reinstate
- test/shaping/data/in-house/tests/myanmar-syllable.tests
+ [test] Reinstate test/shaping/data/in-house/tests/myanmar-syllable.tests
test/shaping/data/in-house/tests/myanmar-syllable.tests | 1 +
1 file changed, 1 insertion(+)
@@ -34505,11 +34299,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Feb 14 17:00:18 2018 -0800
- [subset] Don't fail on different checksum adjustment in subsetting
- tests.
+ [subset] Don't fail on different checksum adjustment in subsetting tests.
- .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1740 ->
- 1692 bytes
+ .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1740 -> 1692 bytes
test/subset/run-tests.py | 8 ++++++++
2 files changed, 8 insertions(+)
@@ -34526,8 +34318,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Feb 14 16:05:39 2018 -0800
- [subset] Add missing face reference in hb-subset-plan plus ensure
- all struct members are cleaned up on destroy.
+ [subset] Add missing face reference in hb-subset-plan plus ensure all struct members are cleaned up on destroy.
src/hb-subset-plan.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
@@ -34536,8 +34327,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Feb 14 16:01:08 2018 -0800
- [subset] In hb-subset-test use hb_set_union instead of manually
- copying set.
+ [subset] In hb-subset-test use hb_set_union instead of manually copying set.
test/api/hb-subset-test.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
@@ -34566,11 +34356,10 @@
Date: Wed Feb 14 15:46:27 2018 -0800
Another linker tweaking
-
+
Trying to fix this warning:
- cc1: warning: command line option ‘-fno-threadsafe-statics’ is
- valid for C++/ObjC++ but not for C
-
+ cc1: warning: command line option ‘-fno-threadsafe-statics’ is valid for C++/ObjC++ but not for C
+
Let's see what the clang bots think of it.
src/Makefile.am | 4 ++--
@@ -34581,7 +34370,7 @@
Date: Wed Feb 14 15:44:48 2018 -0800
[set] Tune size again
-
+
Switch from a 128+64 hierarchy, to 32+32. New page size is 1024.
This should make set iteration faster, without affecting other op
performances much.
@@ -34623,8 +34412,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Wed Feb 14 15:20:43 2018 -0800
- [subset] Use a supplier instead of memcpy and fix a few unnecessary
- {}s for cmap
+ [subset] Use a supplier instead of memcpy and fix a few unnecessary {}s for cmap
src/hb-ot-cmap-table.hh | 24 ++++++------------------
1 file changed, 6 insertions(+), 18 deletions(-)
@@ -34655,8 +34443,7 @@
src/hb-ot-cmap-table.hh | 19 +--
src/hb-ot-hhea-table.hh | 6 +-
- src/hb-ot-hmtx-table.hh | 163
- ++++++++++++++++++---
+ src/hb-ot-hmtx-table.hh | 163 ++++++++++++++++++---
src/hb-ot-maxp-table.hh | 8 +-
src/hb-ot-os2-table.hh | 8 +-
src/hb-subset-glyf.cc | 5 +-
@@ -34672,8 +34459,7 @@
test/api/fonts/Inconsolata-Regular.ac.ttf | Bin 0 -> 4940 bytes
test/api/fonts/Inconsolata-Regular.ac.widerc.ttf | Bin 0 -> 4944 bytes
test/api/fonts/README | 2 +
- test/api/test-subset-hmtx.c | 164
- ++++++++++++++++++++++
+ test/api/test-subset-hmtx.c | 164 ++++++++++++++++++++++
19 files changed, 422 insertions(+), 79 deletions(-)
commit 20022575c658b29796db80c387641309d0c49586
@@ -34680,8 +34466,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Thu Feb 15 01:15:39 2018 +0330
- Redirect email notifications to another mailing list dedicated for
- this (#790)
+ Redirect email notifications to another mailing list dedicated for this (#790)
.travis.yml | 4 ++--
appveyor.yml | 5 +++++
@@ -34749,7 +34534,7 @@
Date: Wed Feb 14 10:55:25 2018 -0800
[subset] Allow linking to libstdc++
-
+
We want to use it.
src/Makefile.am | 2 +-
@@ -34775,11 +34560,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 12 18:15:58 2018 -0800
- [subset] Drop GSUB, GDEF, GPOS, and DSIG from subsetter expected
- test outputs.
+ [subset] Drop GSUB, GDEF, GPOS, and DSIG from subsetter expected test outputs.
- .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 2460 ->
- 1740 bytes
+ .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 2460 -> 1740 bytes
test/subset/generate-expected-outputs.py | 1 +
2 files changed, 1 insertion(+)
@@ -34811,8 +34594,7 @@
test/api/Makefile.am | 2 ++
test/api/fonts/Roboto-Regular.b.ttf | Bin 0 -> 1996 bytes
- test/api/test-subset-os2.c | 59
- ++++++++++++++++++++++++++++++++++++
+ test/api/test-subset-os2.c | 59 ++++++++++++++++++++++++++++++++++++
3 files changed, 61 insertions(+)
commit 343dfe89655683966836e44afb4fd32c47377844
@@ -34828,8 +34610,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 12 17:31:01 2018 -0800
- [subset] Correct usFirstCharIndex and usLastCharIndex in OS2 table
- when subsetting.
+ [subset] Correct usFirstCharIndex and usLastCharIndex in OS2 table when subsetting.
src/hb-ot-os2-table.hh | 45 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset.cc | 16 ++++++++++------
@@ -34849,14 +34630,13 @@
Date: Wed Feb 14 01:00:10 2018 -0800
[set] Add backwards iterator
-
+
New API:
- hb_set_previous()
- hb_set_previous_range()
docs/harfbuzz-sections.txt | 2 ++
- src/hb-set-private.hh | 79
- +++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-set-private.hh | 79 +++++++++++++++++++++++++++++++++++++++++++++-
src/hb-set.cc | 49 +++++++++++++++++++++++++++-
src/hb-set.h | 19 ++++++++---
test/api/test-set.c | 53 +++++++++++++++++++++++++++++--
@@ -34876,7 +34656,7 @@
Date: Tue Feb 13 22:12:36 2018 -0800
Add hb_blob_copy_writable_or_fail()
-
+
New API:
- hb_blob_copy_writable_or_fail()
@@ -34890,7 +34670,7 @@
Date: Tue Feb 13 22:07:12 2018 -0800
[subset] Rename constructor to hb_subset_input_create_or_fail()
-
+
To signify that unlike rest of library, returns nullptr on failure.
src/hb-subset-input.cc | 6 ++----
@@ -34907,8 +34687,7 @@
[use] Add dump-use-data
src/Makefile.am | 4 ++++
- src/dump-use-data.cc | 38
- ++++++++++++++++++++++++++++++++++
+ src/dump-use-data.cc | 38 ++++++++++++++++++++++++++++++++++
src/gen-use-table.py | 2 +-
src/hb-ot-shape-complex-use-private.hh | 2 +-
src/hb-ot-shape-complex-use-table.cc | 2 +-
@@ -34924,8 +34703,7 @@
src/Makefile.am | 4 +
src/Makefile.sources | 1 +
src/dump-khmer-data.cc | 43 +++++++++++
- src/hb-ot-shape-complex-khmer-private.hh | 124
- +++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-khmer-private.hh | 124 +++++++++++++++++++++++++++++++
src/hb-ot-shape-complex-khmer.cc | 98 +-----------------------
5 files changed, 173 insertions(+), 97 deletions(-)
@@ -34939,8 +34717,7 @@
src/Makefile.sources | 1 +
src/dump-myanmar-data.cc | 43 ++++++++
src/hb-ot-shape-complex-indic-private.hh | 8 +-
- src/hb-ot-shape-complex-myanmar-private.hh | 171
- +++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-myanmar-private.hh | 171 +++++++++++++++++++++++++++++
src/hb-ot-shape-complex-myanmar.cc | 138 +----------------------
6 files changed, 225 insertions(+), 140 deletions(-)
@@ -34949,7 +34726,7 @@
Date: Tue Feb 13 21:23:38 2018 -0800
[indic] Rename print-indic-table to dump-indic-data
-
+
Makes more sense given what this prints, err, dumps.
src/Makefile.am | 8 ++++----
@@ -34961,11 +34738,10 @@
Date: Tue Feb 13 21:22:47 2018 -0800
[indic] Explicitly number indic_position_t
-
+
So it's easier to cross-reference from output of print-indic-table.
- src/hb-ot-shape-complex-indic-private.hh | 32
- ++++++++++++++++----------------
+ src/hb-ot-shape-complex-indic-private.hh | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
commit 8634846a0a1049c42ea84ca34402957c981b4c73
@@ -34983,11 +34759,9 @@
[indic] Share some copy/pasta code
- src/hb-ot-shape-complex-indic-private.hh | 29
- +++++++++++++++++++++++++++--
+ src/hb-ot-shape-complex-indic-private.hh | 29 +++++++++++++++++++++++++++--
src/hb-ot-shape-complex-indic.cc | 27 ---------------------------
- src/hb-ot-shape-complex-khmer.cc | 30
- ++++++++----------------------
+ src/hb-ot-shape-complex-khmer.cc | 30 ++++++++----------------------
src/hb-ot-shape-complex-myanmar.cc | 19 ++-----------------
4 files changed, 37 insertions(+), 68 deletions(-)
@@ -34998,10 +34772,8 @@
[indic] Add print-indic-table
src/Makefile.am | 14 ++-
- src/hb-ot-shape-complex-indic-private.hh | 185
- ++++++++++++++++++++++++++++++
- src/hb-ot-shape-complex-indic.cc | 187
- -------------------------------
+ src/hb-ot-shape-complex-indic-private.hh | 185 ++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-indic.cc | 187 -------------------------------
src/print-indic-table.cc | 43 +++++++
4 files changed, 239 insertions(+), 190 deletions(-)
@@ -35010,7 +34782,7 @@
Date: Tue Feb 13 16:35:30 2018 -0800
[subset] Fix loca offsets
-
+
Was writing source font's offsets. Ouch.
src/hb-subset-glyf.cc | 30 +++++++++++-------------------
@@ -35021,12 +34793,11 @@
Date: Tue Feb 13 14:02:59 2018 -0800
Another tweak at libstdc++ things
-
+
To fix this warning:
+
+ cc1: warning: command line option ‘-fno-threadsafe-statics’ is valid for C++/ObjC++ but not for C
- cc1: warning: command line option ‘-fno-threadsafe-statics’ is
- valid for C++/ObjC++ but not for C
-
src/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
@@ -35057,8 +34828,7 @@
src/Makefile.sources | 1 +
src/hb-face.h | 1 -
src/hb-set.cc | 14 +++---
- src/hb-subset-input.cc | 109
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset-input.cc | 109 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset-plan.cc | 2 +-
src/hb-subset-private.hh | 11 ++++-
src/hb-subset.cc | 40 ++--------------
@@ -35073,7 +34843,7 @@
Date: Tue Feb 13 13:39:50 2018 -0800
Disable threadsafe static's for all libraries
-
+
Even in libharfbuzz-subset, we still will handle our own threadsafety
for statics.
@@ -35103,7 +34873,7 @@
Date: Mon Feb 12 18:51:10 2018 -0800
[subset] Allocate bulk memory with malloc(), not calloc()
-
+
We use calloc() to allocate simple structs and set them to zero.
For bulk memory, use malloc() that doesn't zero.
@@ -35115,7 +34885,7 @@
Date: Mon Feb 12 18:48:51 2018 -0800
Use hb_face_get_upem() instead of face->get_upem()
-
+
Such that hmtx accelerator can be used from libharfbuzz-subset.
src/hb-ot-cbdt-table.hh | 2 +-
@@ -35127,7 +34897,7 @@
Date: Mon Feb 12 18:43:42 2018 -0800
[subset] Remove unreachable code
-
+
sanitizer.sanitize never return nullptr.
src/hb-subset.cc | 4 ----
@@ -35138,9 +34908,9 @@
Date: Mon Feb 12 18:41:36 2018 -0800
Allow libharfbuzz-subset to link to libstdc++
-
+
We want to use it instead of reinventing hashmap...
-
+
Also, don't change linker for ICU since libicu also uses libstdc++.
src/Makefile.am | 2 --
@@ -35185,8 +34955,7 @@
.../Roboto-Regular.abc.cmap-format12-only.ttf | Bin 0 -> 2412 bytes
.../fonts/Roboto-Regular.ac.cmap-format12-only.ttf | Bin 0 -> 2212 bytes
test/api/hb-subset-test.h | 3 +-
- test/api/test-subset-cmap.c | 82
- +++++++++++++++++++++
+ test/api/test-subset-cmap.c | 82 +++++++++++++++++++++
test/api/test-subset-glyf.c | 5 +-
.../data/in-house/tests/myanmar-syllable.tests | 1 -
8 files changed, 87 insertions(+), 7 deletions(-)
@@ -35216,13 +34985,10 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 12 13:40:42 2018 -0800
- [subset] Remove test-subset, testing is planned to be done at the
- table level here with test/subset covering the complete subsetting
- operation.
+ [subset] Remove test-subset, testing is planned to be done at the table level here with test/subset covering the complete subsetting operation.
test/api/Makefile.am | 1 -
- test/api/test-subset.c | 73
- --------------------------------------------------
+ test/api/test-subset.c | 73 --------------------------------------------------
2 files changed, 74 deletions(-)
commit 4cdd1b16c99f2681eb11d626c4408eebcc1672be
@@ -35238,11 +35004,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 12 13:35:17 2018 -0800
- [subset] re-enable test-subset-glyf. Refactor to use common functions
- in hb-subset-test.h
+ [subset] re-enable test-subset-glyf. Refactor to use common functions in hb-subset-test.h
- test/api/test-subset-glyf.c | 109
- +++++++++++---------------------------------
+ test/api/test-subset-glyf.c | 109 +++++++++++---------------------------------
1 file changed, 27 insertions(+), 82 deletions(-)
commit d8d8bd8405ec0db781c4c2bbb7ebd6ff520b3c2d
@@ -35249,12 +35013,10 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 12 13:33:55 2018 -0800
- [subset] Add some helper functions for writing tests around
- subsetting.
+ [subset] Add some helper functions for writing tests around subsetting.
test/api/Makefile.am | 2 +-
- test/api/hb-subset-test.h | 123
- ++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/hb-subset-test.h | 123 ++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 124 insertions(+), 1 deletion(-)
commit e8318188c0e53a267a01c45b0fc8d29ad775738a
@@ -35261,8 +35023,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 12 11:38:28 2018 -0800
- [subset] Fix loca generation, was previously writing the original
- glyph starting offset.
+ [subset] Fix loca generation, was previously writing the original glyph starting offset.
src/hb-subset-glyf.cc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
@@ -35272,7 +35033,7 @@
Date: Mon Feb 12 16:45:36 2018 +0200
Rename --with-stdcpp → --with-libstdc++
-
+
Also improve wording a bit and fix make check in --with-libstdc++=yes.
configure.ac | 11 ++++++-----
@@ -35356,8 +35117,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Mon Feb 12 17:20:12 2018 +0330
- Fix symbol exporting issue on msys2 and ✅ bringing all the bots
- (#781)
+ Fix symbol exporting issue on msys2 and ✅ bringing all the bots (#781)
src/Makefile.am | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
@@ -35426,13 +35186,12 @@
Date: Sun Feb 11 19:12:52 2018 -0800
Remove linker selection from hb-ucdn
-
- Since this is a convenience library, it's not actually linked. Or
- so I think.
+
+ Since this is a convenience library, it's not actually linked. Or so I think.
Hoping this might fix this Appveyor failure:
-
+
https://ci.appveyor.com/project/harfbuzz/harfbuzz/build/job/9884jyb5vryja9pw
-
+
Making all in hb-ucdn
make[4]: Entering directory '/c/projects/harfbuzz/src/hb-ucdn'
CC libhb_ucdn_la-ucdn.lo
@@ -35465,7 +35224,7 @@
Date: Sun Feb 11 18:28:10 2018 -0800
Add Sun compiler to no-visibility as well
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/776
src/hb-private.hh | 2 +-
@@ -35485,7 +35244,7 @@
Date: Sun Feb 11 18:24:22 2018 -0800
Another try at fixing multiple-defintion of NullPool
-
+
This one might do it...
src/hb-open-type-private.hh | 6 +++++-
@@ -35505,7 +35264,7 @@
Date: Sun Feb 11 19:46:06 2018 -0600
[subset] Another fixup
-
+
I broke this in c31fcf4c58d96eb7d9781a986991b1a79ac7be44
src/hb-ot-cmap-table.hh | 2 +-
@@ -35517,7 +35276,7 @@
Date: Sun Feb 11 19:34:05 2018 -0600
Try at fixing multiple-definition of NullPool
-
+
If we don't have visibility, make NullPool static.
src/hb-open-type-private.hh | 8 +++++++-
@@ -35530,7 +35289,7 @@
Date: Sun Feb 11 19:01:44 2018 -0600
[subset] Use auto_array_t where it does make sense
-
+
Better fix for https://github.com/harfbuzz/harfbuzz/pull/775
src/hb-subset-plan.cc | 3 +--
@@ -35578,7 +35337,7 @@
Date: Sat Feb 10 21:50:26 2018 -0600
[gpos] Adjust mark attachment heuristic
-
+
Hopefully it...
fixes https://github.com/harfbuzz/harfbuzz/issues/740
@@ -35648,7 +35407,7 @@
Date: Sat Feb 10 15:40:03 2018 -0600
More fixes
-
+
test-subset-glyf still failing. No idea why :(
src/hb-subset.cc | 3 +--
@@ -35660,7 +35419,7 @@
Date: Sat Feb 10 15:17:28 2018 -0600
Fix more build issues
-
+
Hopefully most bots come back with this...
src/check-libstdc++.sh | 5 +++--
@@ -35686,9 +35445,8 @@
Date: Sat Feb 10 14:20:10 2018 -0600
[subset] Replace auto_array with prealloced_array
-
- auto_array has constructor/destructor. Cannot be used in POD object,
- as the clang
+
+ auto_array has constructor/destructor. Cannot be used in POD object, as the clang
bots all noticed...
src/hb-ot-cmap-table.hh | 8 ++++----
@@ -35788,9 +35546,9 @@
Date: Sat Feb 10 12:45:28 2018 -0600
[util] Use setlinebuf() if present
-
+
To work around mysterious bug on OS X.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/727
configure.ac | 6 ++----
@@ -35810,8 +35568,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 9 18:41:21 2018 -0800
- In glyf subsetting add suport for writing out a short loca table
- when possible.
+ In glyf subsetting add suport for writing out a short loca table when possible.
src/hb-subset-glyf.cc | 42 +++++++++++++++++++++++++++++++++---------
1 file changed, 33 insertions(+), 9 deletions(-)
@@ -35822,8 +35579,7 @@
First pass at building a cmap
- src/hb-ot-cmap-table.hh | 103
- ++++++++++++++++++++++++++++++++++++++++++++----
+ src/hb-ot-cmap-table.hh | 103 ++++++++++++++++++++++++++++++++++++++++++++----
src/hb-subset.cc | 37 +++++++++--------
2 files changed, 115 insertions(+), 25 deletions(-)
@@ -35849,8 +35605,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 9 16:22:09 2018 -0800
- Keep a second set of glyph ids in subset plan which is sorted by
- glyph id and always has gid 0
+ Keep a second set of glyph ids in subset plan which is sorted by glyph id and always has gid 0
src/hb-subset-glyf.cc | 2 +-
src/hb-subset-plan.cc | 34 +++++++++++++++++++++++++---------
@@ -35863,8 +35618,7 @@
Formatting for hb-subset-plan.
- src/hb-subset-plan.cc | 51
- +++++++++++++++++++++++++++------------------------
+ src/hb-subset-plan.cc | 51 +++++++++++++++++++++++++++------------------------
1 file changed, 27 insertions(+), 24 deletions(-)
commit 8cef3a61995317d3a5724221108647d7e66fe24a
@@ -35872,10 +35626,10 @@
Date: Fri Feb 9 16:04:23 2018 -0600
Try fixing build with Sun Studio
-
+
Trying to fix:
https://circleci.com/gh/harfbuzz/harfbuzz/6635
-
+
Also part of:
https://github.com/harfbuzz/harfbuzz/issues/630
@@ -35886,8 +35640,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Feb 9 13:54:43 2018 -0800
- Return empty face on hb_subset failure instead of null. Plus some
- minor cleanups for _add_head_and_set_loca_version
+ Return empty face on hb_subset failure instead of null. Plus some minor cleanups for _add_head_and_set_loca_version
src/hb-subset.cc | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
@@ -35915,14 +35668,9 @@
Date: Thu Feb 1 13:31:25 2018 -0500
Documentation for HB_GLYPH_FLAG_UNSAFE_TO_BREAK.
+
+ HB_GLYPH_FLAG_UNSAFE_TO_BREAK means that the glyph with this flag is somehow affected by the previous logical glyph (the previous index in the buffer if ltr and the next index if the buffer is rtl). If these two glyphs are separated by a break (line or otherwise) then the underlying text should be re-shaped on both sides up to corresponding position in the text of some glyph not marked with this flag.
- HB_GLYPH_FLAG_UNSAFE_TO_BREAK means that the glyph with this flag is
- somehow affected by the previous logical glyph (the previous index
- in the buffer if ltr and the next index if the buffer is rtl). If
- these two glyphs are separated by a break (line or otherwise) then the
- underlying text should be re-shaped on both sides up to corresponding
- position in the text of some glyph not marked with this flag.
-
src/hb-buffer.h | 6 ++++++
1 file changed, 6 insertions(+)
@@ -35952,8 +35700,7 @@
[test/text-rendering-tests] Update from upstream
- .../text-rendering-tests/fonts/TestMORXTwentysix.ttf | Bin 3260 ->
- 3252 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentysix.ttf | Bin 3260 -> 3252 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 1cd98d05e07498653ba60a68b6342d1a90429eba
@@ -35960,8 +35707,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Thu Feb 8 19:39:57 2018 -0800
- Create the groups for a cmap format12. Does not yet build the
- actual table.
+ Create the groups for a cmap format12. Does not yet build the actual table.
src/hb-ot-cmap-table.hh | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
@@ -35970,14 +35716,12 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Thu Feb 8 19:22:47 2018 -0800
- capture codepoints sorted so we can use them for cmap later. one
- day we will have a map
+ capture codepoints sorted so we can use them for cmap later. one day we will have a map
src/hb-ot-cmap-table.hh | 14 ---------
src/hb-private.hh | 61 +++++++++++++++++++++++++---------------
src/hb-subset-glyf.cc | 16 +++++------
- src/hb-subset-plan.cc | 75
- ++++++++++++++++++++++++++++++++++---------------
+ src/hb-subset-plan.cc | 75 ++++++++++++++++++++++++++++++++++---------------
src/hb-subset-plan.hh | 8 ++++--
src/hb-subset.cc | 29 ++++++++++++-------
6 files changed, 123 insertions(+), 80 deletions(-)
@@ -36013,8 +35757,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 8 18:32:24 2018 -0800
- Add an extra entry to the end of the loca table to identify the end
- of the last glyph's data.
+ Add an extra entry to the end of the loca table to identify the end of the last glyph's data.
src/hb-subset-glyf.cc | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
@@ -36026,8 +35769,7 @@
Apply per table subsetting while building the new face in hb_subset.
src/hb-subset-glyf.cc | 1 +
- src/hb-subset.cc | 105
- ++++++++++++++++++++++++++++++--------------------
+ src/hb-subset.cc | 105 ++++++++++++++++++++++++++++++--------------------
2 files changed, 65 insertions(+), 41 deletions(-)
commit 3e81832432a1cae0dc28242bb6ff279753effd27
@@ -36093,8 +35835,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 8 15:11:15 2018 -0800
- Fix include gaurds and include order in hb-subset-glyf and
- hb-subset-plan
+ Fix include gaurds and include order in hb-subset-glyf and hb-subset-plan
src/hb-subset-glyf.hh | 6 ++++--
src/hb-subset-plan.cc | 2 +-
@@ -36133,9 +35874,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Thu Feb 8 11:30:36 2018 -0800
- In the hb-subset to fontTools comparison, use ttx to compare the
- fonts. This allows for some binary differences such as re-ordered
- tables.
+ In the hb-subset to fontTools comparison, use ttx to compare the fonts. This allows for some binary differences such as re-ordered tables.
test/subset/run-tests.py | 21 ++++++++++++++-------
1 file changed, 14 insertions(+), 7 deletions(-)
@@ -36146,8 +35885,7 @@
Implement basic loca (long version only) subsetting.
- src/hb-subset-glyf.cc | 66
- +++++++++++++++++++++++++++++++++++----------------
+ src/hb-subset-glyf.cc | 66 +++++++++++++++++++++++++++++++++++----------------
1 file changed, 46 insertions(+), 20 deletions(-)
commit f9c665fed1347f7af6d36ba129f9d174f4ac54dc
@@ -36165,8 +35903,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Feb 7 16:47:31 2018 -0800
- Comment out failing assert in test-subset-glyf for now. Should be
- re-enabled once hb_subset is writing out a new face.
+ Comment out failing assert in test-subset-glyf for now. Should be re-enabled once hb_subset is writing out a new face.
test/api/test-subset-glyf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
@@ -36180,8 +35917,7 @@
test/api/Makefile.am | 4 +
test/api/fonts/Roboto-Regular.abc.ttf | Bin 0 -> 2460 bytes
test/api/fonts/Roboto-Regular.ac.ttf | Bin 0 -> 2268 bytes
- test/api/test-subset-glyf.c | 134
- ++++++++++++++++++++++++++++++++++
+ test/api/test-subset-glyf.c | 134 ++++++++++++++++++++++++++++++++++
4 files changed, 138 insertions(+)
commit 217ed5e3c885532fa8b332cc0d0f9cb4eef32e2b
@@ -36208,8 +35944,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Wed Feb 7 15:59:36 2018 -0800
- sketch a subset<T> and call it for cmap. Add subset to cmap, albeit
- not working even for the msot basic case just yet
+ sketch a subset<T> and call it for cmap. Add subset to cmap, albeit not working even for the msot basic case just yet
src/hb-ot-cmap-table.hh | 18 ++++++++++++++++--
src/hb-subset.cc | 30 ++++++++++++++++++++++++++++++
@@ -36220,7 +35955,7 @@
Date: Thu Feb 8 17:22:07 2018 -0600
Fix overflow in space fallback shaping
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=657466
src/hb-ot-shape-fallback.cc | 2 +-
@@ -36231,7 +35966,7 @@
Date: Thu Feb 8 17:14:52 2018 -0600
Avoid undefined-behavior in fallback mark positioning
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=5584
src/hb-ot-shape-fallback.cc | 11 ++++++-----
@@ -36274,10 +36009,8 @@
test/shaping/data/text-rendering-tests/DISABLED | 2 ++
test/shaping/data/text-rendering-tests/Makefile.sources | 2 ++
- .../text-rendering-tests/fonts/TestMORXTwentyfive.ttf | Bin 0 ->
- 3260 bytes
- .../text-rendering-tests/fonts/TestMORXTwentysix.ttf | Bin 0 ->
- 3260 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentyfive.ttf | Bin 0 -> 3260 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentysix.ttf | Bin 0 -> 3260 bytes
.../data/text-rendering-tests/tests/MORX-25.tests | 9 +++++++++
.../data/text-rendering-tests/tests/MORX-26.tests | 2 ++
6 files changed, 15 insertions(+)
@@ -36334,14 +36067,12 @@
[subset] Assemble font
- src/hb-open-file-private.hh | 50
- +++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-open-file-private.hh | 50 +++++++++++++++++++++++++++++++++++++++++++-
src/hb-open-type-private.hh | 33 +++++++++++++++++++++++------
src/hb-ot-map-private.hh | 10 ++++-----
src/hb-private.hh | 20 +++++++++++-------
src/hb-set-private.hh | 8 +++----
- src/hb-subset.cc | 51
- +++++++++++++++++++++++++++++++++++++++------
+ src/hb-subset.cc | 51 +++++++++++++++++++++++++++++++++++++++------
test/api/test-subset.c | 9 ++++++--
7 files changed, 150 insertions(+), 31 deletions(-)
@@ -36350,7 +36081,7 @@
Date: Wed Feb 7 18:07:45 2018 -0600
[set] Respect stride
-
+
Ouch!
src/hb-set-private.hh | 4 ++--
@@ -36379,10 +36110,9 @@
Date: Wed Feb 7 16:44:52 2018 -0600
[subset] Create new face and copy all tables to it
+
+ test-subset fails now because subset-face does not know how to compile itself.
- test-subset fails now because subset-face does not know how to
- compile itself.
-
src/hb-subset.cc | 37 ++++++++++++++++++++++++++-----------
1 file changed, 26 insertions(+), 11 deletions(-)
@@ -36392,8 +36122,7 @@
Refactor subset glyf to remove multiple calls to glyf.fini()
- src/hb-subset-glyf.cc | 52
- +++++++++++++++++++++++++++++----------------------
+ src/hb-subset-glyf.cc | 52 +++++++++++++++++++++++++++++----------------------
1 file changed, 30 insertions(+), 22 deletions(-)
commit 0a5d1440f829f07454592adde9dd3aa93ad74442
@@ -36402,8 +36131,7 @@
Add implementation of glyf subsetting.
- src/hb-subset-glyf.cc | 81
- +++++++++++++++++++++++++++++++++++++++++++++++----
+ src/hb-subset-glyf.cc | 81 +++++++++++++++++++++++++++++++++++++++++++++++----
1 file changed, 76 insertions(+), 5 deletions(-)
commit 05d65baa1bb64664ba838993fd35f3899d52eb8d
@@ -36420,7 +36148,7 @@
Date: Wed Feb 7 14:09:56 2018 -0600
Fix two undefined-behavior issues
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/761
Fixes https://github.com/harfbuzz/harfbuzz/issues/762
@@ -36453,13 +36181,12 @@
Date: Wed Feb 7 13:47:35 2018 -0500
[subset] Add hb_subset_face
-
+
It's a hb_face_t that has add_table() and in the future knows how to
compile itself into a font blob.
src/hb-private.hh | 9 ++++++
- src/hb-subset.cc | 88
- +++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset.cc | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 97 insertions(+)
commit af02812fc51812a7e2265a1100bbca1a5bf8af45
@@ -36471,8 +36198,7 @@
src/hb-subset-plan.cc | 12 ++++++++---
src/hb-subset-plan.hh | 2 +-
src/hb-subset-private.hh | 10 ----------
- src/hb-subset.cc | 52
- ++++++++----------------------------------------
+ src/hb-subset.cc | 52 ++++++++----------------------------------------
src/hb-subset.h | 25 ++++++-----------------
test/api/test-subset.c | 9 +++++----
util/hb-subset.cc | 12 ++++++-----
@@ -36483,10 +36209,9 @@
Date: Wed Feb 7 12:44:35 2018 -0500
Remove NullPool visibility hack
-
+
We keep a separate private NullPool in libharfbuzz-subset.so
- This can fire back later since now there are two separate null
- objects,
+ This can fire back later since now there are two separate null objects,
and comparisons to the null pool can be confused. Something to deal
with when it comes up. Ouch!
@@ -36498,8 +36223,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Wed Feb 7 09:37:06 2018 -0800
- glyph ids to retain should most likely keep the glyph id not the
- codepoint
+ glyph ids to retain should most likely keep the glyph id not the codepoint
src/hb-subset-plan.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -36577,8 +36301,7 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Tue Feb 6 16:58:35 2018 -0800
- Resolve codepoints:glyph ids. Does not compile; undefined reference
- to OT::_hb_NullPool
+ Resolve codepoints:glyph ids. Does not compile; undefined reference to OT::_hb_NullPool
src/hb-subset-plan.cc | 25 +++++++++++++++++++------
src/hb-subset-plan.hh | 2 +-
@@ -36623,8 +36346,7 @@
Make hb-subset-plan private.
src/Makefile.sources | 2 +-
- src/hb-subset-plan.cc | 27
- ++++++++++++++++-----------
+ src/hb-subset-plan.cc | 27 ++++++++++++++++-----------
src/{hb-subset-plan.h => hb-subset-plan.hh} | 22 +++++++++++++---------
3 files changed, 30 insertions(+), 21 deletions(-)
@@ -36659,8 +36381,7 @@
Add a basic sketch of hb-subset-plan.
src/Makefile.sources | 2 ++
- src/hb-subset-plan.cc | 72
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset-plan.cc | 72 +++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset-plan.h | 49 +++++++++++++++++++++++++++++++++++
3 files changed, 123 insertions(+)
@@ -36679,7 +36400,7 @@
Date: Tue Feb 6 20:40:42 2018 +0330
[test] Fix test-subset on old distros (#758)
-
+
https://developer.gnome.org/glib/stable/glib-Testing.html#g-assert-cmpmem
test/api/test-subset.c | 4 ++++
@@ -36690,7 +36411,7 @@
Date: Tue Feb 6 11:48:04 2018 -0500
[aat] Adjust unsafe-to-break logic some more
-
+
I believe I'm happy with it now.
src/hb-aat-layout-common-private.hh | 8 ++++----
@@ -36710,7 +36431,7 @@
Date: Tue Feb 6 10:20:48 2018 -0500
[buffer] Tweak diff re glyph_flags again
-
+
We expect the buffer to have no flags that the reference doesn't...
Meh. Makes MORX tests pass now. Need to better define the behavior.
@@ -36740,7 +36461,7 @@
Date: Mon Feb 5 19:51:09 2018 -0500
Fix fallthrough compiler warning with gcc >= 7
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/755
src/hb-private.hh | 3 +++
@@ -36770,7 +36491,7 @@
Date: Mon Feb 5 15:35:13 2018 -0800
Merge pull request #754 from googlefonts/master
-
+
Fix build for subsetting code.
commit 2ea228935d41b55fed45b7423b69bc15b42e3abc
@@ -36786,8 +36507,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 5 14:35:32 2018 -0800
- Switch to fopen() instead of open() in subset test. open wasn't
- compiling on windows.
+ Switch to fopen() instead of open() in subset test. open wasn't compiling on windows.
util/hb-subset.cc | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
@@ -36796,8 +36516,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Mon Feb 5 11:12:33 2018 -0800
- Rename HB_SUBSET_sources -> HB_SUBSET_CLI_sources to match what
- cmake is looking for.
+ Rename HB_SUBSET_sources -> HB_SUBSET_CLI_sources to match what cmake is looking for.
util/Makefile.am | 3 +--
util/Makefile.sources | 2 +-
@@ -36849,10 +36568,9 @@
Date: Sun Feb 4 20:01:35 2018 -0500
Merge pull request #745 from googlefonts/master
+
+ Interface for hb_subset, skeleton for the hb-subset cli, and basic testing rigging.
- Interface for hb_subset, skeleton for the hb-subset cli, and basic
- testing rigging.
-
commit 3615f344ec00059972d8ce75522022b5294764a7
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Sun Feb 4 17:19:58 2018 -0500
@@ -36861,8 +36579,7 @@
test/shaping/data/text-rendering-tests/DISABLED | 1 +
test/shaping/data/text-rendering-tests/Makefile.sources | 3 ++-
- .../text-rendering-tests/fonts/TestMORXTwentythree.ttf | Bin 0 ->
- 1836 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentythree.ttf | Bin 0 -> 1836 bytes
.../data/text-rendering-tests/tests/MORX-23.tests | 1 +
4 files changed, 4 insertions(+), 1 deletion(-)
@@ -36871,21 +36588,20 @@
Date: Sun Feb 4 14:58:02 2018 -0500
[aat] Fix unsafe-to-break
-
+
At any position, if state is not zero, mark unsafe-to-break before,
unless we can reason it safe.
-
+
At any position, if there's an action entry for end-of-text, mark
unsafe to break.
-
+
Also changes buffer diff impl to allow for flag differences as long
as the buffer glyph flags are superset of reference glyph flags.
-
+
With this, all MORX tests pass.
src/hb-aat-layout-common-private.hh | 31 +++++++++++++++++++++++++------
- src/hb-aat-layout-morx-table.hh | 35
- +++++++++++++++++++++++------------
+ src/hb-aat-layout-morx-table.hh | 35 +++++++++++++++++++++++------------
src/hb-buffer.cc | 2 +-
3 files changed, 49 insertions(+), 19 deletions(-)
@@ -36895,8 +36611,7 @@
Actually call hb_subset
- util/hb-subset.cc | 51
- ++++++++++++++++++++++++++++++++++-----------------
+ util/hb-subset.cc | 51 ++++++++++++++++++++++++++++++++++-----------------
1 file changed, 34 insertions(+), 17 deletions(-)
commit 7b01761adef6f64f1139b30c985aa5f52314073a
@@ -36948,8 +36663,7 @@
test/subset/run-tests.py | 15 +++---
util/Makefile.sources | 3 ++
- util/hb-subset.cc | 131
- +++++++++++++++++++++++++----------------------
+ util/hb-subset.cc | 131 +++++++++++++++++++++++++----------------------
3 files changed, 82 insertions(+), 67 deletions(-)
commit ede84ffa426edb950c4ec4f89833c85475a1c64f
@@ -37011,11 +36725,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Jan 31 14:53:09 2018 -0800
- Add a basic implementation of hb-subset to enable compilation of
- test-subset.
+ Add a basic implementation of hb-subset to enable compilation of test-subset.
- src/hb-subset.cc | 146
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset.cc | 146 +++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-subset.h | 5 +-
test/api/Makefile.am | 1 +
test/api/test-subset.c | 12 ++--
@@ -37025,11 +36737,9 @@
Author: Garret Rieger <grieger at google.com>
Date: Wed Jan 31 11:32:23 2018 -0800
- Make the expected output for subsetting basics test be equal to the
- input file for now.
+ Make the expected output for subsetting basics test be equal to the input file for now.
- .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1996 ->
- 2460 bytes
+ .../expected/basics/Roboto-Regular.abc.default.62.ttf | Bin 1996 -> 2460 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit b59c08eb045db2b6c952de81510b8159a4f72fb1
@@ -37038,8 +36748,7 @@
Add the beginning of a unit test for hb-subset
- test/api/test-subset.c | 67
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-subset.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
commit e9d154ac8ddd2712a34c53c95a17e469f95e5b30
@@ -37046,12 +36755,10 @@
Author: Rod Sheeter <rsheeter at google.com>
Date: Tue Jan 30 19:27:11 2018 -0800
- tweak test failure output. write to a temp file not stdout. test
- still fails because expected is not just an identical copy of input
+ tweak test failure output. write to a temp file not stdout. test still fails because expected is not just an identical copy of input
test/subset/run-tests.py | 41 +++++++++++++++++++++++++++----------
- util/hb-subset.cc | 53
- +++++++++++++++++++++++++++++++++---------------
+ util/hb-subset.cc | 53 +++++++++++++++++++++++++++++++++---------------
2 files changed, 67 insertions(+), 27 deletions(-)
commit cf403e1a53381f293aceac5cdbe031bbb2a7af77
@@ -37110,8 +36817,7 @@
WIP test runner for subset tests.
- test/subset/run-tests.py | 64
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ test/subset/run-tests.py | 64 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 64 insertions(+)
commit cc46cd88a1b84b02694fa6d88c4286e93336f096
@@ -37118,8 +36824,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Jan 26 14:25:39 2018 -0800
- In generate-expected-outputs read the test definition with utf8
- encoding.
+ In generate-expected-outputs read the test definition with utf8 encoding.
test/subset/generate-expected-outputs.py | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -37128,8 +36833,7 @@
Author: Garret Rieger <grieger at google.com>
Date: Fri Jan 26 13:57:48 2018 -0800
- Add basic directory structure for subsetter integration tests. Plus
- a utility for generating expected output files.
+ Add basic directory structure for subsetter integration tests. Plus a utility for generating expected output files.
.../basics/Roboto-Regular.abc.default.62.ttf | Bin 0 -> 1996 bytes
test/subset/data/fonts/Roboto-Regular.abc.ttf | Bin 0 -> 2460 bytes
@@ -37136,8 +36840,7 @@
test/subset/data/profiles/default.txt | 0
test/subset/data/tests/basics.txt | 8 ++
test/subset/generate-expected-outputs.py | 40 ++++++++++
- test/subset/subset_test_suite.py | 82
- +++++++++++++++++++++
+ test/subset/subset_test_suite.py | 82 +++++++++++++++++++++
6 files changed, 130 insertions(+)
commit 9ccb8366f603a9e4a7a3c3f96420a19d4f6fb390
@@ -37149,8 +36852,7 @@
src/Makefile.am | 2 ++
src/Makefile.sources | 4 +++
src/hb-subset.cc | 0
- src/hb-subset.h | 88
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-subset.h | 88 +++++++++++++++++++++++++++++++++++++++++++++++++++
util/Makefile.am | 3 ++
util/Makefile.sources | 4 +++
util/hb-subset.cc | 61 +++++++++++++++++++++++++++++++++++
@@ -37161,9 +36863,9 @@
Date: Sun Feb 4 14:45:02 2018 -0500
[aat] More adjustment to ContextualSubtable
-
+
See comment.
-
+
With this, MORX-20 passes if I turn --verify off. Our unsafe-to-break
logic is currently broken in presence of end-of-text actions. That's,
ugh, extra work to fix. Let me try...
@@ -37194,7 +36896,7 @@
Date: Sun Feb 4 12:38:18 2018 -0500
[configure] Fix wording
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/741
configure.ac | 4 ++--
@@ -37205,7 +36907,7 @@
Date: Fri Feb 2 16:08:50 2018 -0500
[aat] In ContextualSubtable, mark mark after substituting mark
-
+
Fixes MORX-21.
src/hb-aat-layout-morx-table.hh | 16 ++++++++--------
@@ -37216,7 +36918,7 @@
Date: Fri Feb 2 15:53:25 2018 -0500
[aat] Fix ContextualSubtable sanitization
-
+
Fixes MORX-18, MORX-19, and MORX-22.
src/hb-aat-layout-morx-table.hh | 6 ++++--
@@ -37227,11 +36929,10 @@
Date: Sun Feb 4 12:05:12 2018 +0200
Correctly show documentation build status
-
- Correctly show if building documentation is enabled or not in
- configure
+
+ Correctly show if building documentation is enabled or not in configure
summary.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/741
configure.ac | 2 +-
@@ -37242,7 +36943,7 @@
Date: Sun Feb 4 01:26:57 2018 +0700
Enable use of atexit() on macOS and related platforms.
-
+
The atexit() man page indicates that this is expected to behave
in the expected way on unloading of shared libraries.
@@ -37279,8 +36980,7 @@
src/hb-ot-shape-complex-myanmar.cc | 5 +++++
test/shaping/README.md | 10 +++++-----
test/shaping/data/in-house/Makefile.sources | 1 +
- .../fonts/af3086380b743099c54a3b11b96766039ea62fcd.ttf | Bin 0 ->
- 1536 bytes
+ .../fonts/af3086380b743099c54a3b11b96766039ea62fcd.ttf | Bin 0 -> 1536 bytes
test/shaping/data/in-house/tests/myanmar-syllable.tests | 1 +
6 files changed, 13 insertions(+), 6 deletions(-)
@@ -37324,7 +37024,7 @@
Date: Wed Jan 31 22:24:51 2018 +0700
[ot-layout] Fix nullptr dereference.
-
+
If the `calloc` for `gsub_accels` or `gpos_accels` fails, then the
unlikely branch afterwards can be taken, which frees up the
`hb_ot_layout_t`, but since those fields can now be `nullptr`, then
@@ -37338,10 +37038,10 @@
Date: Wed Jan 31 20:24:27 2018 +0700
[coretext] Fix memory leaks.
-
+
In `reference_table`, if the data is empty and we return early,
we still need to release the data object.
-
+
In `hb_coretext_shape`, there two edge cases where an early
return should release the attributed string.
@@ -37373,14 +37073,13 @@
Date: Tue Jan 30 10:58:44 2018 -0800
[aat] Limit number of DontAdvance transitions
-
+
Remove the faulty loop-detection logic. Use max-ops for breaking
out of infinite loops or heavy work.
-
+
https://twitter.com/behdadesfahbod/status/958065026262183936
- src/hb-aat-layout-common-private.hh | 33
- ++-------------------------------
+ src/hb-aat-layout-common-private.hh | 33 ++-------------------------------
1 file changed, 2 insertions(+), 31 deletions(-)
commit e00743b47d25a2487b7f232a514a042e2962a089
@@ -37391,18 +37090,12 @@
test/shaping/data/text-rendering-tests/DISABLED | 7 +++++++
test/shaping/data/text-rendering-tests/Makefile.sources | 7 +++++++
- .../data/text-rendering-tests/fonts/TestMORXEighteen.ttf | Bin 0 ->
- 3256 bytes
- .../text-rendering-tests/fonts/TestMORXSeventeen.ttf | Bin 0 ->
- 1788 bytes
- .../data/text-rendering-tests/fonts/TestMORXSixteen.ttf | Bin 0 ->
- 1812 bytes
- .../data/text-rendering-tests/fonts/TestMORXTwenty.ttf | Bin 0 ->
- 3232 bytes
- .../text-rendering-tests/fonts/TestMORXTwentyone.ttf | Bin 0 ->
- 3244 bytes
- .../text-rendering-tests/fonts/TestMORXTwentytwo.ttf | Bin 0 ->
- 3256 bytes
+ .../data/text-rendering-tests/fonts/TestMORXEighteen.ttf | Bin 0 -> 3256 bytes
+ .../text-rendering-tests/fonts/TestMORXSeventeen.ttf | Bin 0 -> 1788 bytes
+ .../data/text-rendering-tests/fonts/TestMORXSixteen.ttf | Bin 0 -> 1812 bytes
+ .../data/text-rendering-tests/fonts/TestMORXTwenty.ttf | Bin 0 -> 3232 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentyone.ttf | Bin 0 -> 3244 bytes
+ .../text-rendering-tests/fonts/TestMORXTwentytwo.ttf | Bin 0 -> 3256 bytes
.../data/text-rendering-tests/tests/MORX-14.tests | 1 +
.../data/text-rendering-tests/tests/MORX-16.tests | 1 +
.../data/text-rendering-tests/tests/MORX-17.tests | 1 +
@@ -37446,7 +37139,7 @@
Date: Fri Jan 26 18:14:05 2018 -0800
Misc warning fixes
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/712
src/hb-ot-layout-gsubgpos-private.hh | 9 ++++-----
@@ -37459,9 +37152,9 @@
Date: Fri Jan 26 13:38:06 2018 -0500
Use KernSubTableFormat2::rightClassTable
-
+
Issue originally reported at http://cppfiles.com/chromium.txt .
-
+
This fixes what appears to be a copy - paste issue which causes both
KernSubTableFormat2::rightClassTable and the 'right' argument to
KernSubTableFormat2::get_kerning to go unused.
@@ -37533,10 +37226,9 @@
Date: Fri Jan 19 18:36:39 2018 -0800
[aat] Fix Ligature matching
+
+ I hope... Makes "ffi" work with Zapfino. I'm not sure if doing it correctly though...
- I hope... Makes "ffi" work with Zapfino. I'm not sure if doing it
- correctly though...
-
src/hb-aat-layout-morx-table.hh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -37554,12 +37246,11 @@
Date: Fri Jan 19 18:08:56 2018 -0800
[aat] Implement LigatureSubtable
-
+
We form the Zapfino ligature now. Yay! No further testing done.
src/hb-aat-layout-common-private.hh | 25 ++++++---
- src/hb-aat-layout-morx-table.hh | 108
- +++++++++++++++++++++++++++++++++---
+ src/hb-aat-layout-morx-table.hh | 108 +++++++++++++++++++++++++++++++++---
2 files changed, 115 insertions(+), 18 deletions(-)
commit f07ce661a2056965c573c99bdb721c065563ea7b
@@ -37567,7 +37258,7 @@
Date: Fri Jan 19 16:52:01 2018 -0800
[aat] Embed a sanitizer context in hb_aat_apply_context_t
-
+
For run-time checking.
src/hb-aat-layout-common-private.hh | 22 ++++++++++++++++------
@@ -37598,8 +37289,7 @@
src/hb-aat-layout.cc | 2 +-
src/hb-ot-layout-gpos-table.hh | 48 ++++++++++++-------------
src/hb-ot-layout-gsub-table.hh | 24 ++++++-------
- src/hb-ot-layout-gsubgpos-private.hh | 58
- +++++++++++++++---------------
+ src/hb-ot-layout-gsubgpos-private.hh | 58 +++++++++++++++---------------
src/hb-ot-layout-private.hh | 4 +--
src/hb-ot-layout.cc | 16 ++++-----
src/hb-ot-shape-complex-arabic-fallback.hh | 2 +-
@@ -37631,13 +37321,13 @@
Date: Thu Jan 18 22:49:40 2018 +0100
hb-common.cc: Hatran script is right-to-left (#714)
-
+
"Hatran is written from right to left horizontally"
-
+
http://www.unicode.org/L2/L2012/12312-n4324-hatran.pdf
-
+
This ancient script was added with Unicode 8.0.
-
+
Also this spreadsheet (referenced in an inline comment in the
source code) has it as RTL: http://goo.gl/x9ilM
@@ -37648,8 +37338,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Fri Jan 19 01:12:31 2018 +0330
- Improve avoiding C++ linkage, definition creation and cmake tests
- (#710)
+ Improve avoiding C++ linkage, definition creation and cmake tests (#710)
.circleci/config.yml | 4 ++--
CMakeLists.txt | 46 ++++++++++++++++++++++++++--------------------
@@ -37683,7 +37372,7 @@
Date: Wed Jan 17 09:47:50 2018 -0800
Typo
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/711
util/options.cc | 2 +-
@@ -37722,7 +37411,7 @@
Date: Mon Jan 15 20:46:58 2018 -0500
Disable MORX-13/14
-
+
Really, need better way to catch these :(.
test/shaping/data/text-rendering-tests/DISABLED | 2 ++
@@ -37734,7 +37423,7 @@
Date: Mon Jan 15 20:44:10 2018 -0500
Disallow sanitize recursing into Extension subtables multiple times
-
+
Fixes https://oss-fuzz.com/v2/testcase-detail/5216838347653120
which is a stack overflow, not by way of infinite recursion, just
being deep. That's disallowed anyway, so catch it as it happens,
@@ -37779,8 +37468,7 @@
[aat] Towards implementing LigatureSubtable
- src/hb-aat-layout-morx-table.hh | 61
- +++++++++++++++++++++++++++++++++++++++--
+ src/hb-aat-layout-morx-table.hh | 61 +++++++++++++++++++++++++++++++++++++++--
1 file changed, 58 insertions(+), 3 deletions(-)
commit c9e12a2b9b34d73d37def2261a5c1a7ef20b8349
@@ -37799,10 +37487,8 @@
[test/text-rendering-tests] Update from upstream
test/shaping/data/text-rendering-tests/Makefile.sources | 2 ++
- .../data/text-rendering-tests/fonts/TestMORXFourteen.ttf | Bin 0 ->
- 1816 bytes
- .../data/text-rendering-tests/fonts/TestMORXThirteen.ttf | Bin 0 ->
- 1820 bytes
+ .../data/text-rendering-tests/fonts/TestMORXFourteen.ttf | Bin 0 -> 1816 bytes
+ .../data/text-rendering-tests/fonts/TestMORXThirteen.ttf | Bin 0 -> 1820 bytes
.../data/text-rendering-tests/tests/MORX-13.tests | 1 +
.../data/text-rendering-tests/tests/MORX-14.tests | 1 +
5 files changed, 4 insertions(+)
@@ -37812,9 +37498,8 @@
Date: Fri Jan 12 12:04:53 2018 +0100
[aat] Fix some struct sizes
-
- I hate it that with my compiler at least, it doesn't catch totally
- uncompilable
+
+ I hate it that with my compiler at least, it doesn't catch totally uncompilable
statements in templates if they are not used...
src/hb-aat-layout-common-private.hh | 2 +-
@@ -37845,7 +37530,7 @@
Date: Fri Jan 12 11:31:20 2018 +0100
[aat] Fix symbol visibility
-
+
Not sure why only one of the bots sees this as visible...
src/hb-aat-layout-morx-table.hh | 2 +-
@@ -37885,8 +37570,7 @@
[aat] Detect infinite-loops in state machine
- src/hb-aat-layout-common-private.hh | 36
- +++++++++++++++++++++++++++++-------
+ src/hb-aat-layout-common-private.hh | 36 +++++++++++++++++++++++++++++-------
1 file changed, 29 insertions(+), 7 deletions(-)
commit d514f1480cffb81850ef212155c66ee9e0383350
@@ -37921,7 +37605,7 @@
Date: Fri Jan 12 09:46:38 2018 +0100
Disable C++11
-
+
To better catch errors locally.
configure.ac | 2 +-
@@ -37932,9 +37616,8 @@
Date: Fri Jan 12 09:45:42 2018 +0100
[aat] Fix more builds
-
- Maybe I should disable C++11 detection such that my compiler also
- catches
+
+ Maybe I should disable C++11 detection such that my compiler also catches
these. Doesn't look like we can switch to it for a while anyway...
src/hb-aat-layout-common-private.hh | 2 +-
@@ -37955,7 +37638,7 @@
Date: Fri Jan 12 15:33:16 2018 +0800
Update _POSIX_C_SOURCE to the latest version
-
+
Defining _POSIX_C_SOURCE to an old version on FreeBSD can cause C99 to
be disabled in libc.
@@ -37968,8 +37651,7 @@
[aat] Port RearrangementSubtable to StateTableDriver
- src/hb-aat-layout-morx-table.hh | 91
- ++++++++++++++++++++---------------------
+ src/hb-aat-layout-morx-table.hh | 91 ++++++++++++++++++++---------------------
1 file changed, 44 insertions(+), 47 deletions(-)
commit 117cfe7bb7cef682eb151b94f1eb12363ba3af67
@@ -37979,8 +37661,7 @@
[aat] Add StateTableDriver and convert ContextualSubtable to it
src/hb-aat-layout-common-private.hh | 51 ++++++++++++++++++++
- src/hb-aat-layout-morx-table.hh | 93
- ++++++++++++++++++-------------------
+ src/hb-aat-layout-morx-table.hh | 93 ++++++++++++++++++-------------------
2 files changed, 95 insertions(+), 49 deletions(-)
commit 0d39ac224c680b1f0134b58e78391497fbe47370
@@ -37997,7 +37678,7 @@
Date: Thu Jan 11 22:46:19 2018 +0100
[test] Disable MORX-12
-
+
Ouch. I need a better workflow for this.
test/shaping/data/text-rendering-tests/Makefile.sources | 1 -
@@ -38008,12 +37689,11 @@
Date: Thu Jan 11 22:43:57 2018 +0100
[aat] Remove 'mort' support
-
+
It's dead, Jim!
src/hb-aat-layout-common-private.hh | 55 +++++-----------
- src/hb-aat-layout-morx-table.hh | 122
- ++++++++++--------------------------
+ src/hb-aat-layout-morx-table.hh | 122 ++++++++++--------------------------
2 files changed, 46 insertions(+), 131 deletions(-)
commit 7e2fed6d73f89986e5777028cdcd24e3baf2f86c
@@ -38021,10 +37701,10 @@
Date: Thu Jan 11 19:25:21 2018 +0100
[aat] Allow DontAdvance
-
+
Apparently CoreText does allow these. To be done: detect infinite
loops.
-
+
Fixes MORX-12 test.
src/hb-aat-layout-morx-table.hh | 4 ++--
@@ -38038,8 +37718,7 @@
test/shaping/data/text-rendering-tests/DISABLED | 1 +
test/shaping/data/text-rendering-tests/Makefile.sources | 2 ++
- .../data/text-rendering-tests/fonts/TestMORXTwelve.ttf | Bin 0 ->
- 2200 bytes
+ .../data/text-rendering-tests/fonts/TestMORXTwelve.ttf | Bin 0 -> 2200 bytes
.../data/text-rendering-tests/tests/MORX-12.tests | 3 +++
4 files changed, 6 insertions(+)
@@ -38050,8 +37729,7 @@
[aat] Sanitize ContextualSubtable
src/hb-aat-layout-common-private.hh | 23 +++++++++++++++++++----
- src/hb-aat-layout-morx-table.hh | 34
- ++++++++++++++++++++++++----------
+ src/hb-aat-layout-morx-table.hh | 34 ++++++++++++++++++++++++----------
2 files changed, 43 insertions(+), 14 deletions(-)
commit 9b82aa19d812e70b7fade4b7669a9ce27855951e
@@ -38069,8 +37747,7 @@
[aat] Sanitize StateTable
- src/hb-aat-layout-common-private.hh | 43
- ++++++++++++++++++++++++++++++++++---
+ src/hb-aat-layout-common-private.hh | 43 ++++++++++++++++++++++++++++++++++---
1 file changed, 40 insertions(+), 3 deletions(-)
commit 0e3b3379a04a67a22e44e17d6bf849359f4fca68
@@ -38096,7 +37773,7 @@
Date: Thu Jan 11 17:57:46 2018 +0100
[buffer] Fix compiler warnings
-
+
line 323: Warning: info hides hb_buffer_t::info
...
@@ -38108,14 +37785,12 @@
Date: Thu Jan 11 17:41:34 2018 +0100
[aat] Make bots happy
-
- Don't know why this is not caught by my compiler. Looks like clang
- catches it
+
+ Don't know why this is not caught by my compiler. Looks like clang catches it
while gcc doesn't.
-
+
In file included from ../src/hb-aat-layout-morx-table.hh:31:
- ../src/hb-aat-layout-common-private.hh:523:30: error: no member named
- 'static_size' in 'AAT::ContextualSubtable<AAT::MorxTypes>::EntryData'
+ ../src/hb-aat-layout-common-private.hh:523:30: error: no member named 'static_size' in 'AAT::ContextualSubtable<AAT::MorxTypes>::EntryData'
DEFINE_SIZE_STATIC (4 + T::static_size);
~~~^
@@ -38126,9 +37801,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Jan 11 15:23:24 2018 +0100
- [aat] In NoncontextualSubtable, handle MarkLast with end-of-line
- transition
-
+ [aat] In NoncontextualSubtable, handle MarkLast with end-of-line transition
+
Fixes MORX-11 test.
src/hb-aat-layout-morx-table.hh | 4 ++--
@@ -38142,8 +37816,7 @@
test/shaping/data/text-rendering-tests/DISABLED | 3 ++-
test/shaping/data/text-rendering-tests/Makefile.sources | 3 ++-
- .../data/text-rendering-tests/fonts/TestMORXEleven.ttf | Bin 0 ->
- 1624 bytes
+ .../data/text-rendering-tests/fonts/TestMORXEleven.ttf | Bin 0 -> 1624 bytes
.../data/text-rendering-tests/tests/MORX-11.tests | 1 +
4 files changed, 5 insertions(+), 2 deletions(-)
@@ -38152,11 +37825,10 @@
Date: Thu Jan 11 15:15:07 2018 +0100
[aat] Implement ContextualSubtable
-
+
Tested with Zapfino and text "2nd". Sascha will create tests later.
- src/hb-aat-layout-morx-table.hh | 70
- ++++++++++++++++++++++++++++++++++++++---
+ src/hb-aat-layout-morx-table.hh | 70 ++++++++++++++++++++++++++++++++++++++---
1 file changed, 66 insertions(+), 4 deletions(-)
commit 335a9c1fe489db53549801b4996dd0f6f5eded62
@@ -38166,8 +37838,7 @@
[aat] Towards implementing ContextualSubtable
src/hb-aat-layout-common-private.hh | 58 ++++++++++++++++++++++--
- src/hb-aat-layout-morx-table.hh | 88
- ++++++++++++++++++++++++++-----------
+ src/hb-aat-layout-morx-table.hh | 88 ++++++++++++++++++++++++++-----------
2 files changed, 117 insertions(+), 29 deletions(-)
commit 62348f647f7b1604e008dbed46a54eff245fc106
@@ -38175,7 +37846,7 @@
Date: Thu Jan 11 12:00:28 2018 +0100
[aat] Implement end-of-text in state machine
-
+
Passes MORX-10 test now.
src/hb-aat-layout-morx-table.hh | 10 ++++++----
@@ -38188,10 +37859,8 @@
[test/text-rendering-tests] Update from upstream
test/shaping/data/text-rendering-tests/DISABLED | 1 +
- test/shaping/data/text-rendering-tests/Makefile.sources | 11
- ++++++-----
- .../data/text-rendering-tests/fonts/TestMORXTen.ttf | Bin 0 ->
- 1620 bytes
+ test/shaping/data/text-rendering-tests/Makefile.sources | 11 ++++++-----
+ .../data/text-rendering-tests/fonts/TestMORXTen.ttf | Bin 0 -> 1620 bytes
.../data/text-rendering-tests/tests/MORX-10.tests | 1 +
4 files changed, 8 insertions(+), 5 deletions(-)
@@ -38218,7 +37887,7 @@
Date: Thu Jan 11 11:49:07 2018 +0100
[aat] Generate finegrained unsafe-to-break in state-machine!
-
+
Neato.
src/hb-aat-layout-morx-table.hh | 11 +++++++++--
@@ -38248,10 +37917,8 @@
[test/in-house] Add Makefile.sources
- test/shaping/data/in-house/Makefile.am | 46
- ++---------------------------
- test/shaping/data/in-house/Makefile.sources | 46
- +++++++++++++++++++++++++++++
+ test/shaping/data/in-house/Makefile.am | 46 ++---------------------------
+ test/shaping/data/in-house/Makefile.sources | 46 +++++++++++++++++++++++++++++
2 files changed, 48 insertions(+), 44 deletions(-)
commit 7c32e01d04deaab511d41f5dec0dfd9fc0469f39
@@ -38272,13 +37939,11 @@
Date: Thu Jan 11 10:30:22 2018 +0100
[test/text-rendering-tests] Update from upstream
-
+
Also adds an update.sh script that does this automatically.
- test/shaping/data/text-rendering-tests/Makefile.am | 52
- +++------------------
- .../data/text-rendering-tests/Makefile.sources | 51
- ++++++++++++++++++++
+ test/shaping/data/text-rendering-tests/Makefile.am | 52 +++------------------
+ .../data/text-rendering-tests/Makefile.sources | 51 ++++++++++++++++++++
.../text-rendering-tests/fonts/TestMORXEight.ttf | Bin 0 -> 2184 bytes
.../text-rendering-tests/fonts/TestMORXNine.ttf | Bin 0 -> 1624 bytes
.../data/text-rendering-tests/tests/MORX-5.tests | 25 ++++++++++
@@ -38286,8 +37951,7 @@
.../data/text-rendering-tests/tests/MORX-7.tests | 1 +
.../data/text-rendering-tests/tests/MORX-8.tests | 3 ++
.../data/text-rendering-tests/tests/MORX-9.tests | 1 +
- test/shaping/data/text-rendering-tests/update.sh | 48
- +++++++++++++++++++
+ test/shaping/data/text-rendering-tests/update.sh | 48 +++++++++++++++++++
10 files changed, 136 insertions(+), 46 deletions(-)
commit c861daacc4255d41d2358868b917277422949dc9
@@ -38326,7 +37990,7 @@
Date: Thu Jan 11 09:57:55 2018 +0100
[aat] Mark state-machine-based lookup as completely unsafe-to-break
-
+
To be improved later.
src/hb-aat-layout-morx-table.hh | 2 ++
@@ -38339,8 +38003,7 @@
[aat] Implement RearrangementSubtable
src/hb-aat-layout-common-private.hh | 89 ++++++++++++++++-
- src/hb-aat-layout-morx-table.hh | 192
- +++++++++++++++++++++++++++++++-----
+ src/hb-aat-layout-morx-table.hh | 192 +++++++++++++++++++++++++++++++-----
src/hb-open-type-private.hh | 2 -
src/hb-private.hh | 7 +-
4 files changed, 254 insertions(+), 36 deletions(-)
@@ -38350,7 +38013,7 @@
Date: Thu Jan 11 12:33:22 2018 +0330
Move the #define of _GNU_SOURCE to the top of hb-private.hh (#697)
-
+
This fixes the build on Cygwin.
src/hb-private.hh | 4 ++--
@@ -38370,7 +38033,7 @@
Date: Thu Jan 11 08:48:22 2018 +0330
[test] Better tests output by converting stderr to stdout (#696)
-
+
https://gitlab.kitware.com/cmake/cmake/issues/17630
test/shaping/run-tests.py | 18 +++++++++---------
@@ -38392,8 +38055,7 @@
[cmake] Another try on making sure feature testing is working (#691)
- .circleci/config.yml | 131
- ++++++++++++++++++++++++++++-----------------------
+ .circleci/config.yml | 131 ++++++++++++++++++++++++++++-----------------------
CMakeLists.txt | 17 ++++---
2 files changed, 79 insertions(+), 69 deletions(-)
@@ -38411,7 +38073,7 @@
Date: Wed Jan 10 13:54:36 2018 +0100
[util] Set stdio files to line buffering
-
+
So we can stream lines to hb-shape and read output.
util/options.cc | 4 ++++
@@ -38422,7 +38084,7 @@
Date: Wed Jan 10 11:09:53 2018 +0100
[aat] Add Class subtable thingy
-
+
From old 'mort' table.
src/hb-aat-layout-common-private.hh | 24 ++++++++++++++++++++++++
@@ -38435,8 +38097,7 @@
[cmake] Add header existence tests (#685)
.circleci/config.yml | 4 ++--
- CMakeLists.txt | 53
- ++++++++++++++++++++++++++++++---------------
+ CMakeLists.txt | 53 ++++++++++++++++++++++++++++++---------------
test/shaping/CMakeLists.txt | 1 -
3 files changed, 37 insertions(+), 21 deletions(-)
@@ -38454,7 +38115,7 @@
Date: Wed Jan 10 07:12:07 2018 +0200
Improve HB_BUFFER_SERIALIZE_FLAG_NO_ADVANCES docs
-
+
Add the note about absolute glyph positions from the commit message.
src/hb-buffer.h | 3 ++-
@@ -38467,8 +38128,7 @@
[test] Move test handling to sundirectories
configure.ac | 3 +
- test/shaping/Makefile.am | 98
- +---------------------
+ test/shaping/Makefile.am | 98 +---------------------
test/shaping/data/Makefile.am | 9 ++
test/shaping/data/in-house/Makefile.am | 58 +++++++++++++
test/shaping/data/text-rendering-tests/Makefile.am | 60 +++++++++++++
@@ -38488,13 +38148,12 @@
Date: Wed Jan 10 05:13:47 2018 +0100
Calculate anchor positions in float, then round
-
+
Hoping to reduce rounding error, to make tests happier...
No luck.
src/hb-font-private.hh | 6 ++++++
- src/hb-ot-layout-gpos-table.hh | 44
- +++++++++++++++++++++---------------------
+ src/hb-ot-layout-gpos-table.hh | 44 +++++++++++++++++++++---------------------
2 files changed, 28 insertions(+), 22 deletions(-)
commit 0b28e1199d62765db4e855756b96022e423dcc17
@@ -38511,7 +38170,7 @@
Date: Wed Jan 10 04:33:08 2018 +0100
Round, instead of floor, when applying variations
-
+
Hoping this would fix remaining text-rendering-tests failures,
but so far no luck.
@@ -38552,7 +38211,7 @@
Date: Wed Jan 10 03:49:32 2018 +0100
[test] Another try
-
+
Making cmake happy this time.
test/shaping/Makefile.am | 4 +++-
@@ -38563,7 +38222,7 @@
Date: Wed Jan 10 03:48:09 2018 +0100
[test] Fix text disabling
-
+
Ouch, make!
test/shaping/Makefile.am | 27 ++++++++++++++-------------
@@ -38592,11 +38251,11 @@
Date: Wed Jan 10 03:35:20 2018 +0100
Add HB_BUFFER_FLAG_REMOVE_DEFAULT_IGNORABLES
-
+
New API:
HB_BUFFER_FLAG_REMOVE_DEFAULT_IGNORABLES
hb-shape / hb-view --remove-default-ignorables
-
+
One more text-rendering-tests test passing. Eleven failing.
src/hb-buffer.h | 17 ++++--
@@ -38640,11 +38299,9 @@
.../data/text-rendering-tests/tests/SHBALI-1.tests | 44 +++++++-------
.../data/text-rendering-tests/tests/SHBALI-2.tests | 24 ++++----
.../data/text-rendering-tests/tests/SHBALI-3.tests | 18 +++---
- .../data/text-rendering-tests/tests/SHKNDA-1.tests | 68
- +++++++++++-----------
+ .../data/text-rendering-tests/tests/SHKNDA-1.tests | 68 +++++++++++-----------
.../data/text-rendering-tests/tests/SHKNDA-2.tests | 32 +++++-----
- .../data/text-rendering-tests/tests/SHKNDA-3.tests | 62
- ++++++++++----------
+ .../data/text-rendering-tests/tests/SHKNDA-3.tests | 62 ++++++++++----------
util/options.cc | 1 +
util/options.hh | 14 +++--
46 files changed, 435 insertions(+), 419 deletions(-)
@@ -38654,12 +38311,11 @@
Date: Wed Jan 10 03:22:08 2018 +0100
[test/text-rendering-tests] Hook up font variations
-
+
Six more passing. Twelve failing now.
.../data/text-rendering-tests/extract-tests.py | 6 +++-
- .../data/text-rendering-tests/tests/AVAR-1.tests | 34
- +++++++++++-----------
+ .../data/text-rendering-tests/tests/AVAR-1.tests | 34 +++++++++++-----------
.../data/text-rendering-tests/tests/CFF2-1.tests | 18 ++++++------
.../data/text-rendering-tests/tests/CVAR-1.tests | 6 ++--
.../data/text-rendering-tests/tests/CVAR-2.tests | 6 ++--
@@ -38682,22 +38338,18 @@
Date: Wed Jan 10 03:16:56 2018 +0100
[test] Add tests from text-rendering-tests repo
-
+
https://github.com/unicode-org/text-rendering-tests
test/shaping/Makefile.am | 44 ++++++++++++++-
.../fonts/AdobeVFPrototype-Subset.otf | Bin 0 -> 7096 bytes
- .../text-rendering-tests/fonts/FDArrayTest257.otf | Bin 0 -> 145212
- bytes
- .../fonts/FDArrayTest65535.otf | Bin 0 -> 492740
- bytes
+ .../text-rendering-tests/fonts/FDArrayTest257.otf | Bin 0 -> 145212 bytes
+ .../fonts/FDArrayTest65535.otf | Bin 0 -> 492740 bytes
.../fonts/NotoSansBalinese-Regular.ttf | Bin 0 -> 32304 bytes
.../fonts/NotoSansKannada-Regular.ttf | Bin 0 -> 83868 bytes
.../fonts/NotoSerifKannada-Regular.ttf | Bin 0 -> 96936 bytes
- .../text-rendering-tests/fonts/Selawik-README.md | 60
- +++++++++++++++++++++
- .../fonts/Selawik-variable.ttf | Bin 0 -> 481504
- bytes
+ .../text-rendering-tests/fonts/Selawik-README.md | 60 +++++++++++++++++++++
+ .../fonts/Selawik-variable.ttf | Bin 0 -> 481504 bytes
.../data/text-rendering-tests/fonts/TestAVAR.ttf | Bin 0 -> 1608 bytes
.../data/text-rendering-tests/fonts/TestCMAP14.otf | Bin 0 -> 1628 bytes
.../fonts/TestCMAPMacTurkish.ttf | Bin 0 -> 19644 bytes
@@ -38704,8 +38356,7 @@
.../text-rendering-tests/fonts/TestCVARGVAROne.ttf | Bin 0 -> 12336 bytes
.../text-rendering-tests/fonts/TestCVARGVARTwo.ttf | Bin 0 -> 12256 bytes
.../text-rendering-tests/fonts/TestGLYFOne.ttf | Bin 0 -> 1516 bytes
- .../text-rendering-tests/fonts/TestGPOSFour.ttf | Bin 0 -> 315020
- bytes
+ .../text-rendering-tests/fonts/TestGPOSFour.ttf | Bin 0 -> 315020 bytes
.../text-rendering-tests/fonts/TestGPOSOne.ttf | Bin 0 -> 10384 bytes
.../text-rendering-tests/fonts/TestGPOSThree.ttf | Bin 0 -> 3500 bytes
.../text-rendering-tests/fonts/TestGPOSTwo.otf | Bin 0 -> 1680 bytes
@@ -38723,8 +38374,7 @@
.../text-rendering-tests/fonts/TestMORXOne.ttf | Bin 0 -> 2404 bytes
.../text-rendering-tests/fonts/TestMORXThree.ttf | Bin 0 -> 4104 bytes
.../text-rendering-tests/fonts/TestMORXTwo.ttf | Bin 0 -> 4960 bytes
- .../text-rendering-tests/fonts/TestShapeAran.ttf | Bin 0 -> 116044
- bytes
+ .../text-rendering-tests/fonts/TestShapeAran.ttf | Bin 0 -> 116044 bytes
.../text-rendering-tests/fonts/TestShapeEthi.ttf | Bin 0 -> 5292 bytes
.../data/text-rendering-tests/fonts/Zycon.ttf | Bin 0 -> 21036 bytes
.../data/text-rendering-tests/tests/AVAR-1.tests | 17 ++++++
@@ -38775,7 +38425,7 @@
Date: Wed Jan 10 03:07:30 2018 +0100
Prefix int types with HB
-
+
Such a headache that Windows defines UINT8, ...; Just prefix it.
src/hb-aat-layout-common-private.hh | 29 +++---
@@ -38792,8 +38442,7 @@
src/hb-ot-layout-gdef-table.hh | 22 ++---
src/hb-ot-layout-gpos-table.hh | 94 +++++++++----------
src/hb-ot-layout-gsub-table.hh | 30 +++---
- src/hb-ot-layout-gsubgpos-private.hh | 172
- +++++++++++++++++------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 172 +++++++++++++++++------------------
src/hb-ot-math-table.hh | 26 +++---
src/hb-ot-maxp-table.hh | 2 +-
src/hb-ot-name-table.hh | 16 ++--
@@ -38810,16 +38459,11 @@
Date: Wed Jan 10 02:56:29 2018 +0100
[aat] Try fixing VC bots
+
+ c:\projects\harfbuzz\src\hb-aat-layout-common-private.hh(51): error C2872: 'UINT16': ambiguous symbol [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
+ C:\Program Files (x86)\Windows Kits\10\Include\10.0.14393.0\shared\basetsd.h(80): note: could be 'unsigned short UINT16'
+ c:\projects\harfbuzz\src\hb-open-type-private.hh(648): note: or 'OT::UINT16'
- c:\projects\harfbuzz\src\hb-aat-layout-common-private.hh(51):
- error C2872: 'UINT16': ambiguous symbol
- [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
- C:\Program Files (x86)\Windows
- Kits\10\Include\10.0.14393.0\shared\basetsd.h(80): note: could be
- 'unsigned short UINT16'
- c:\projects\harfbuzz\src\hb-open-type-private.hh(648): note: or
- 'OT::UINT16'
-
src/hb-aat-layout-common-private.hh | 3 +++
src/hb-aat-layout-morx-table.hh | 3 +++
2 files changed, 6 insertions(+)
@@ -38829,7 +38473,7 @@
Date: Wed Jan 10 02:49:36 2018 +0100
Disable processing of morx table in ot shaper
-
+
So I can merge this to master...
src/hb-ot-shape.cc | 4 ++--
@@ -38840,14 +38484,12 @@
Date: Wed Jan 10 02:48:04 2018 +0100
[util] Add hb-shape --ned
-
- For not displaying extra data: no clusters, no advance. Just data
- pertaining
+
+ For not displaying extra data: no clusters, no advance. Just data pertaining
to where glyphs end up on the screen.
test/shaping/data/text-rendering-tests/extract-tests.py | 2 +-
- util/options.cc | 13
- +++++++++++++
+ util/options.cc | 13 +++++++++++++
2 files changed, 14 insertions(+), 1 deletion(-)
commit 7020130665316365c288d0960fc288faa8f5bdf7
@@ -38873,10 +38515,10 @@
Date: Wed Jan 10 02:20:14 2018 +0100
Add option to buffer serialization to not output glyph advances
-
+
When advances are not printed, glyph offsets reflect absolute glyph
positions.
-
+
New API:
HB_BUFFER_SERIALIZE_FLAG_NO_ADVANCES
hb-shape --no-advances
@@ -38893,13 +38535,12 @@
Date: Wed Jan 10 01:54:12 2018 +0100
[test] Add script for extracting tests from text-rendering-tests
-
+
Work in progress...
-
+
https://github.com/unicode-org/text-rendering-tests
- .../data/text-rendering-tests/extract-tests.py | 45
- ++++++++++++++++++++++
+ .../data/text-rendering-tests/extract-tests.py | 45 ++++++++++++++++++++++
1 file changed, 45 insertions(+)
commit 6b4d63f295f419f55983a8fc72f582802f55b09f
@@ -38916,9 +38557,9 @@
Date: Tue Jan 9 23:15:54 2018 +0100
[test] Simplify test runner
-
+
Always pass hb-shape as first argument to run-tests.py.
-
+
Also require automake 1.13.
configure.ac | 3 +--
@@ -38941,12 +38582,11 @@
Date: Tue Jan 9 21:58:57 2018 +0100
[test] Reorganize test suite
-
+
In anticipation of importing more test suites.
test/fuzzing/run-fuzzer-tests.py | 2 +-
- test/shaping/Makefile.am | 86
- +++++++++---------
+ test/shaping/Makefile.am | 86 +++++++++---------
test/shaping/{fonts => data/in-house}/COPYING | 7 +-
.../0509e80afb379d16560e9e47bdd7d888bebdebc6.ttf | Bin
.../051d92f8bc6ff724511b296c27623f824de256e9.ttf | Bin
@@ -39094,8 +38734,7 @@
test/shaping/data/in-house/tests/use-marchen.tests | 35 ++++++++
.../shaping/data/in-house/tests/use-syllable.tests | 7 ++
test/shaping/data/in-house/tests/use.tests | 4 +
- .../data/in-house/tests/variations-rvrn.tests | 100
- +++++++++++++++++++++
+ .../data/in-house/tests/variations-rvrn.tests | 100 +++++++++++++++++++++
test/shaping/data/in-house/tests/vertical.tests | 3 +
.../data/in-house/tests/zero-width-marks.tests | 11 +++
test/shaping/run-tests.py | 48 ++++------
@@ -39137,8 +38776,7 @@
test/shaping/tests/misc/use-marchen.tests | 35 --------
test/shaping/tests/misc/use-syllable.tests | 7 --
test/shaping/tests/misc/use.tests | 4 -
- test/shaping/tests/misc/variations-rvrn.tests | 100
- ---------------------
+ test/shaping/tests/misc/variations-rvrn.tests | 100 ---------------------
test/shaping/tests/misc/vertical.tests | 3 -
test/shaping/tests/misc/zero-width-marks.tests | 11 ---
.../script-arabic/language-persian/mehran.txt | 14 +--
@@ -39360,8 +38998,7 @@
.../script-tibetan/misc/contractions.txt | 0
.../shaper-tibetan/script-tibetan/misc/misc.txt | 0
.../shaper-use/script-batak/misc.txt | 0
- .../shaper-use/script-buginese/misc.txt | 92
- +++++++++----------
+ .../shaper-use/script-buginese/misc.txt | 92 +++++++++----------
.../shaper-use/script-cham/misc.txt | 0
.../shaper-use/script-kaithi/misc.txt | 0
.../shaper-use/script-kharoshti/misc.txt | 0
@@ -39399,8 +39036,7 @@
[test] Move test files around
test/fuzzing/run-fuzzer-tests.py | 2 +-
- test/shaping/Makefile.am | 82
- +++++++++++-----------
+ test/shaping/Makefile.am | 82 +++++++++++-----------
.../tests/{ => misc}/arabic-fallback-shaping.tests | 0
.../tests/{ => misc}/arabic-feature-order.tests | 0
.../tests/{ => misc}/arabic-like-joining.tests | 0
@@ -39449,13 +39085,11 @@
Date: Tue Jan 9 17:55:17 2018 +0100
[aat/morx] Implement NoncontextualSubtables
+
+ Also makes hb-ot-shape call morx for now instead of GSUB... Just for testing.
- Also makes hb-ot-shape call morx for now instead of GSUB... Just
- for testing.
-
src/hb-aat-layout-common-private.hh | 34 +++++++--------
- src/hb-aat-layout-morx-table.hh | 82
- ++++++++++++++++++++++++++++++++++---
+ src/hb-aat-layout-morx-table.hh | 82 ++++++++++++++++++++++++++++++++++---
src/hb-aat-layout-private.hh | 3 ++
src/hb-aat-layout.cc | 13 +++++-
src/hb-ot-shape.cc | 6 +++
@@ -39475,11 +39109,10 @@
Date: Tue Jan 9 15:48:51 2018 +0100
[aat] Implement Lookup table
-
+
Untested, but compiles.
- src/hb-aat-layout-common-private.hh | 308
- +++++++++++++++++++++++++++++++++++-
+ src/hb-aat-layout-common-private.hh | 308 +++++++++++++++++++++++++++++++++++-
src/hb-aat-layout-morx-table.hh | 9 +-
src/hb-aat-layout.cc | 14 ++
src/hb-face.cc | 6 +-
@@ -39521,8 +39154,7 @@
[aat] Start implementing common table formats
src/Makefile.sources | 2 +
- src/hb-aat-layout-common-private.hh | 134
- ++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-common-private.hh | 134 ++++++++++++++++++++++++++++++++++++
src/hb-aat-layout-morx-table.hh | 1 +
src/hb-aat-layout-private.hh | 37 ++++++++++
src/hb-aat-layout.cc | 1 +
@@ -39535,8 +39167,7 @@
[aat] Start implementing Apple AAT morx table
src/Makefile.sources | 2 +
- src/hb-aat-layout-morx-table.hh | 275
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-aat-layout-morx-table.hh | 275 ++++++++++++++++++++++++++++++++++++++++
src/hb-aat-layout.cc | 42 ++++++
src/hb-open-type-private.hh | 5 +
src/hb-ot-layout-private.hh | 5 +
@@ -39567,7 +39198,7 @@
Date: Fri Jan 5 18:09:29 2018 +0000
[khmer] Relax!
-
+
Apparently we don't use OT_A either.
src/hb-ot-shape-complex-khmer-machine.rl | 3 +--
@@ -39596,9 +39227,9 @@
Date: Fri Jan 5 18:03:00 2018 +0000
[khmer] Simplify grammar some more
-
+
Numbers down (from 38):
-
+
KHMER: 299090 out of 299124 tests passed. 34 failed (0.0113665%)
src/hb-ot-shape-complex-khmer-machine.rl | 2 +-
@@ -39627,9 +39258,9 @@
Date: Fri Jan 5 17:57:39 2018 +0000
[khmer] Relax number of consonants / matras allowed
-
+
New numbers (down from 39):
-
+
KHMER: 299086 out of 299124 tests passed. 38 failed (0.0127038%)
src/hb-ot-shape-complex-khmer-machine.rl | 6 +++---
@@ -39640,9 +39271,9 @@
Date: Fri Jan 5 17:52:24 2018 +0000
[khmer] Allow Independent Vowels where stacked consonants are allowed
-
+
New numbers (down from 44):
-
+
KHMER: 299085 out of 299124 tests passed. 39 failed (0.0130381%)
src/hb-ot-shape-complex-khmer-machine.rl | 4 ++--
@@ -39722,8 +39353,7 @@
[khmer] Shave off some more from the grammar
src/hb-ot-shape-complex-khmer-machine.rl | 9 ++-------
- src/hb-ot-shape-complex-khmer.cc | 34
- ++------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 34 ++------------------------------
2 files changed, 4 insertions(+), 39 deletions(-)
commit 014494d5c0469fe6b3112db3fdb3f2f262673ba1
@@ -39759,7 +39389,7 @@
Date: Fri Jan 5 17:06:29 2018 +0000
[khmer] Better fix for dangling final Coeng
-
+
This is how 1471cfee3bb2734dc44c58471362851ad27e8bd8 should have
been done.
@@ -39780,7 +39410,7 @@
Date: Fri Jan 5 17:01:37 2018 +0000
[khmer] Remove forced_rakar from grammar
-
+
Used by Sinhala only.
src/hb-ot-shape-complex-khmer-machine.rl | 3 +--
@@ -39792,9 +39422,9 @@
Date: Fri Jan 5 16:34:20 2018 +0000
[khmer] Allow a dangling final Coeng after matras
-
+
Uniscribe seems to allow that. New numbers:
-
+
KHMER: 299080 out of 299124 tests passed. 44 failed (0.0147096%)
src/hb-ot-shape-complex-khmer-machine.rl | 2 +-
@@ -39806,8 +39436,7 @@
[khmer] Remove some more unused code
- src/hb-ot-shape-complex-khmer.cc | 49
- ++--------------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 49 ++--------------------------------------
1 file changed, 2 insertions(+), 47 deletions(-)
commit bfad6ab897a38aedc82de694ee1a17132f90b25e
@@ -39816,8 +39445,7 @@
[khmer] Remove features not used by Khmer
- src/hb-ot-shape-complex-khmer.cc | 60
- ++++------------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 60 ++++------------------------------------
1 file changed, 5 insertions(+), 55 deletions(-)
commit 92a99ce084b19dff32d434de446144f0c4796803
@@ -39835,8 +39463,7 @@
[khmer] Remove non-Khmer matra positioning code
- src/hb-ot-shape-complex-khmer.cc | 76
- +++++++---------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 76 +++++++---------------------------------
1 file changed, 12 insertions(+), 64 deletions(-)
commit f8553c898a414298403c335f8d2ed6c588a1189f
@@ -39863,8 +39490,7 @@
[khmer] Remove indic_config->reph_pos
- src/hb-ot-shape-complex-khmer.cc | 333
- ++-------------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 333 ++-------------------------------------
1 file changed, 10 insertions(+), 323 deletions(-)
commit ffcd6c7efd21bf89b41ddbf148b05672a42ecadd
@@ -39873,8 +39499,7 @@
[khmer] Remove indic_config->base_pos
- src/hb-ot-shape-complex-khmer.cc | 229
- ++-------------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 229 ++-------------------------------------
1 file changed, 7 insertions(+), 222 deletions(-)
commit 0c91638d48d6fb86d1e30fb94c15785707395b42
@@ -39883,8 +39508,7 @@
[khmer] Remove other scripts
- src/hb-ot-shape-complex-khmer.cc | 131
- ++++++++++-----------------------------
+ src/hb-ot-shape-complex-khmer.cc | 131 ++++++++++-----------------------------
1 file changed, 34 insertions(+), 97 deletions(-)
commit 4c0199c573f79be5f40e7d4f8433ef6a1c9c24b2
@@ -39911,8 +39535,7 @@
[khmer] Remove indic_config->has_old_spec
- src/hb-ot-shape-complex-khmer.cc | 157
- ++++++---------------------------------
+ src/hb-ot-shape-complex-khmer.cc | 157 ++++++---------------------------------
1 file changed, 21 insertions(+), 136 deletions(-)
commit 961ebf85f1e7d417e056c3927ee73857f6f4cde6
@@ -39923,8 +39546,7 @@
src/hb-ot-shape-complex-indic-private.hh | 1 -
src/hb-ot-shape-complex-khmer-machine.rl | 7 +++----
- src/hb-ot-shape-complex-khmer.cc | 32
- ++++++++++++++++----------------
+ src/hb-ot-shape-complex-khmer.cc | 32 ++++++++++++++++----------------
3 files changed, 19 insertions(+), 21 deletions(-)
commit 9761f9d78214323b9ad58dd0b8ba41851c9e2d54
@@ -39932,12 +39554,11 @@
Date: Fri Jan 5 15:33:11 2018 +0000
[indic] Remove more Khmer-specific stuff from Indic shaper
-
+
No numbers changed.
src/hb-ot-shape-complex-indic-machine.rl | 8 ++---
- src/hb-ot-shape-complex-indic.cc | 57
- ++++++++++++--------------------
+ src/hb-ot-shape-complex-indic.cc | 57 ++++++++++++--------------------
2 files changed, 25 insertions(+), 40 deletions(-)
commit 075895364435ee88936696bcb5457283c4bb1a29
@@ -39946,8 +39567,7 @@
[indic] Remove main Khmer stuff
- src/hb-ot-shape-complex-indic.cc | 73
- ++--------------------------------------
+ src/hb-ot-shape-complex-indic.cc | 73 ++--------------------------------------
1 file changed, 2 insertions(+), 71 deletions(-)
commit dcf4d95fea45e19fbb3b39f0211b2aa96a907473
@@ -39955,13 +39575,13 @@
Date: Fri Jan 5 14:54:31 2018 +0000
[khmer] Split off Khmer shaper from Indic
-
+
Towards fixing https://github.com/harfbuzz/harfbuzz/issues/667
The Khmer spec is different enough from other Indic ones to require
its own grammar.
-
+
No change in functionality. Test numbers are:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
@@ -39968,8 +39588,7 @@
GURMUKHI: 60729 out of 60747 tests passed. 18 failed (0.0296311%)
KANNADA: 951300 out of 951913 tests passed. 613 failed (0.0643966%)
KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
@@ -39977,8 +39596,7 @@
src/Makefile.sources | 3 +
src/hb-ot-shape-complex-khmer-machine.rl | 130 +++
- src/hb-ot-shape-complex-khmer.cc | 1867
- ++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-khmer.cc | 1867 ++++++++++++++++++++++++++++++
src/hb-ot-shape-complex-private.hh | 5 +-
4 files changed, 2003 insertions(+), 2 deletions(-)
@@ -39996,11 +39614,11 @@
Date: Fri Jan 5 13:20:21 2018 +0000
[ot] Fix VariationStore evaluation algorithm
-
+
Ouch! Missing coords should still be evaluated as coord=0, which
most of the time results in a factor of 0. We were skipping these,
which was equivalent to a factor of 1.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/652
src/hb-ot-layout-common-private.hh | 5 +++--
@@ -40030,8 +39648,7 @@
Add test font for previous commit
- .../sha1sum/21b7fb9c1eeae260473809fbc1fe330f66a507cd.ttf | Bin 0 ->
- 4816 bytes
+ .../sha1sum/21b7fb9c1eeae260473809fbc1fe330f66a507cd.ttf | Bin 0 -> 4816 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 127bcc6ece4da64e807f652dd84a17c6a8c5e300
@@ -40046,18 +39663,17 @@
Date: Fri Jan 5 12:46:12 2018 +0000
Improve CGJ skipping logic
-
+
Previously we made CGJ unskippable. Now, if CGJ did NOT prevent
any reordering, allow skipping over it. To make this work we
had to make changes to the Arabic mark reordering algorithm
implementation to renumber moved MCM marks. See comments.
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/554
src/hb-buffer-private.hh | 1 +
src/hb-ot-layout-private.hh | 11 ++++++++-
- src/hb-ot-shape-complex-arabic.cc | 37
- ++++++++++++++++++++++--------
+ src/hb-ot-shape-complex-arabic.cc | 37 ++++++++++++++++++++++--------
src/hb-ot-shape-normalize.cc | 30 +++++++++++++-----------
test/shaping/tests/arabic-mark-order.tests | 4 ++++
5 files changed, 58 insertions(+), 25 deletions(-)
@@ -40069,8 +39685,7 @@
Improve tests (#679)
.circleci/config.yml | 2 +-
- CMakeLists.txt | 52
- +++++++++++++++++++++++++++++++++++----------
+ CMakeLists.txt | 52 +++++++++++++++++++++++++++++++++++----------
autogen.sh | 6 ++++--
src/Makefile.am | 3 +--
src/check-defs.sh | 2 +-
@@ -40095,15 +39710,13 @@
Date: Thu Jan 4 18:40:10 2018 +0700
atomics: Favor compiler primitives over macOS APIs. (#676)
-
+
In macOS 10.12, the `OSMemoryBarrier` and related APIs were deprecated
- in favor of using `std::atomic`. On the way to supporting
- `std::atomic`,
+ in favor of using `std::atomic`. On the way to supporting `std::atomic`,
we can favor using the "Intel primitives" which are also available on
macOS.
- src/hb-atomic-private.hh | 46
- +++++++++++++++++++++++-----------------------
+ src/hb-atomic-private.hh | 46 +++++++++++++++++++++++-----------------------
1 file changed, 23 insertions(+), 23 deletions(-)
commit 4f80078eb035054db0f6e33cf4f7345c6c85cb12
@@ -40111,7 +39724,7 @@
Date: Thu Jan 4 18:37:35 2018 +0700
[cmake] Colorize output when using cmake + ninja. (#674)
-
+
Due to how ninja runs clang and gcc, it doesn't colorize the output
like make does. This forces color output in this situation.
@@ -40140,8 +39753,7 @@
[use] Simplify more
src/gen-use-table.py | 11 +------
- src/hb-ot-shape-complex-use-table.cc | 62
- +++++++++++++++++++++---------------
+ src/hb-ot-shape-complex-use-table.cc | 62 +++++++++++++++++++++---------------
2 files changed, 38 insertions(+), 35 deletions(-)
commit 877d15e73c24159b26bb7cc6d2f62045d445d0fc
@@ -40149,7 +39761,7 @@
Date: Wed Jan 3 14:24:44 2018 +0000
[use] Simplify
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/661
src/gen-use-table.py | 2 +-
@@ -40161,7 +39773,7 @@
Date: Wed Jan 3 14:22:07 2018 +0000
[use] Fix Brahmi Number Joiner 1107F
-
+
Fixes https://github.com/harfbuzz/harfbuzz/pull/660
src/gen-indic-table.py | 6 +++---
@@ -40242,8 +39854,7 @@
[cmake] Run fuzzing and shaping tests (#666)
.circleci/config.yml | 2 +-
- CMakeLists.txt | 59
- ++++++++++++++++++++++++----------------
+ CMakeLists.txt | 59 ++++++++++++++++++++++++----------------
appveyor.yml | 4 +--
test/CMakeLists.txt | 5 ++++
test/api/CMakeLists.txt | 48 +++++++++++++-------------------
@@ -40261,8 +39872,7 @@
[cmake] Use GNUInstallDirs values (#665)
- CMakeLists.txt | 170
- ++++++++++++++++++++++++++++-----------------------------
+ CMakeLists.txt | 170 ++++++++++++++++++++++++++++-----------------------------
1 file changed, 85 insertions(+), 85 deletions(-)
commit 7d397c5d5ca684fae824a61dabf5bc422d0a516b
@@ -40293,8 +39903,7 @@
src/gen-use-table.py | 3 +++
src/hb-ot-shape-complex-use-table.cc | 2 +-
- .../sha1sum/59a585a63b3df608fbeef00956c8c108deec7de6.ttf | Bin 0 ->
- 1164 bytes
+ .../sha1sum/59a585a63b3df608fbeef00956c8c108deec7de6.ttf | Bin 0 -> 1164 bytes
test/shaping/tests/use-syllable.tests | 1 +
4 files changed, 5 insertions(+), 1 deletion(-)
@@ -40312,7 +39921,7 @@
Date: Sun Dec 24 16:05:07 2017 -0500
[use] Allow ZWJ before/after Halant
-
+
https://github.com/harfbuzz/harfbuzz/issues/542#issuecomment-353169729
src/hb-ot-shape-complex-use-machine.rl | 3 ++-
@@ -40360,7 +39969,7 @@
Date: Tue Dec 19 14:48:26 2017 -0500
[set] Handle nil set in add_range() / add_sorted_array()
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/657
src/hb-set-private.hh | 5 +++--
@@ -40381,7 +39990,7 @@
Date: Sun Dec 17 12:32:33 2017 -0500
[coretext] In hb_coretext_font_create() set ptem
-
+
Otherwise setting the CTFont was ineffective as it would have been
recreated anyway unless font size was set to 18 CSS points.
@@ -40402,17 +40011,14 @@
Date: Sat Dec 16 11:11:18 2017 -0500
[collect_glyphs] Bail if input data looks like garbage
-
- Specificaly, when a range or sorted array has unexpected order,
- we take that as
- font data being garbage and bail out. This fixes significant slowdown
- on a bad
+
+ Specificaly, when a range or sorted array has unexpected order, we take that as
+ font data being garbage and bail out. This fixes significant slowdown on a bad
version of Chandas font which has a 600KB GPOS with garbage inside.
-
- Later on, I like to add a maximum-work counter for collect_glyphs
- to protect
+
+ Later on, I like to add a maximum-work counter for collect_glyphs to protect
against malicious fonts as well.
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=794896
src/hb-ot-layout-common-private.hh | 14 +++++++-------
@@ -40424,11 +40030,10 @@
Date: Sat Dec 16 11:36:16 2017 -0500
[set] Optimize add_array() / add_sorted_array()
-
+
Does page lookup as needed.
- src/hb-set-private.hh | 54
- ++++++++++++++++++++++++++++++++++++---------------
+ src/hb-set-private.hh | 54 ++++++++++++++++++++++++++++++++++++---------------
1 file changed, 38 insertions(+), 16 deletions(-)
commit 71e6adf1e2d65eb905a0ba247672fe36169955ef
@@ -40437,8 +40042,7 @@
[collect_glyphs] handle ClassDef better
- src/hb-ot-layout-common-private.hh | 63
- ++++++++++++++++++++++++++++++------
+ src/hb-ot-layout-common-private.hh | 63 ++++++++++++++++++++++++++++++------
src/hb-ot-layout-gdef-table.hh | 2 +-
src/hb-ot-layout-gpos-table.hh | 5 +--
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
@@ -40449,7 +40053,7 @@
Date: Sat Dec 16 06:18:07 2017 -0800
[collect_glyphs] In PairPosFornat2 do not collect classDef1
-
+
The coverage already covered that.
src/hb-ot-layout-gpos-table.hh | 8 ++------
@@ -40460,18 +40064,15 @@
Date: Sat Dec 16 06:12:06 2017 -0800
More work towards improving collect_glyphs() against bad input
-
- The three "XXXXX"'s should be switched to false. Doing that
- separately for ease
+
+ The three "XXXXX"'s should be switched to false. Doing that separately for ease
of bisecting...
src/hb-ot-layout-common-private.hh | 7 +++----
src/hb-ot-layout-gpos-table.hh | 25 ++++++++++---------------
- src/hb-ot-layout-gsub-table.hh | 35
- +++++++++++++----------------------
+ src/hb-ot-layout-gsub-table.hh | 35 +++++++++++++----------------------
src/hb-set-digest-private.hh | 6 ++++--
- src/hb-set-private.hh | 36
- ++++++++++++++++++------------------
+ src/hb-set-private.hh | 36 ++++++++++++++++++------------------
5 files changed, 48 insertions(+), 61 deletions(-)
commit 5d02572034e3dafbe87000fd0aa34b858bd95075
@@ -40479,23 +40080,21 @@
Date: Thu Dec 14 19:33:55 2017 -0800
[set] Add add_sorted_array()
-
- Not optimized to use sortedness yet. Also start putting in place
- infra
+
+ Not optimized to use sortedness yet. Also start putting in place infra
to faster reject bad data.
-
+
A version of Chandas.ttf found on some Chrome bots has 660kb of GPOS,
mostly junk. That is causing 48 million of set->add() calls in
collect_glyphs(), which is insane.
-
+
In the upcoming commits, I'll be speeding that up by optimizing
add_sorted_array(), while also reducing work by rejecting out-of-sort
arrays quickly and propagate the rejection.
-
+
Part of https://bugs.chromium.org/p/chromium/issues/detail?id=794896
- src/hb-ot-layout-common-private.hh | 51
- +++++++++++++++++++++++-------------
+ src/hb-ot-layout-common-private.hh | 51 +++++++++++++++++++++++-------------
src/hb-ot-layout-gdef-table.hh | 2 +-
src/hb-ot-layout-gpos-table.hh | 10 +++----
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
@@ -40508,7 +40107,7 @@
Date: Thu Dec 14 19:04:55 2017 -0800
[set] Reduce number of preallocated pages from 8 to 1
-
+
Now that pagesize is 8192, this feels better.
src/hb-set-private.hh | 2 +-
@@ -40538,13 +40137,13 @@
Date: Thu Dec 14 13:30:38 2017 -0800
[set] Change pagesize from 512 bits to 8192 bits
-
+
Fixes perf regression on some heavy fonts in Chrome's FT+HB
interaction.
-
+
See:
https://bugs.chromium.org/p/chromium/issues/detail?id=782220
-
+
More work to be done:
https://bugs.chromium.org/p/chromium/issues/detail?id=794896
@@ -40556,9 +40155,8 @@
Date: Wed Dec 13 13:12:20 2017 -0800
[set] Add add_array()
-
- To be used to optimize adding a whole bunch of (sorted) items at
- the same time,
+
+ To be used to optimize adding a whole bunch of (sorted) items at the same time,
as in CoverageFormat1.
src/hb-ot-layout-common-private.hh | 4 +---
@@ -40591,8 +40189,7 @@
Rewrite run-tests in python (#647)
test/shaping/Makefile.am | 4 +-
- test/shaping/run-tests.py | 115
- ++++++++++++++++++++++++++++++++++++++++++++++
+ test/shaping/run-tests.py | 115 ++++++++++++++++++++++++++++++++++++++++++++++
test/shaping/run-tests.sh | 65 --------------------------
3 files changed, 117 insertions(+), 67 deletions(-)
@@ -40601,13 +40198,12 @@
Date: Wed Dec 6 21:08:20 2017 +0200
[ci] Sort out Travis configuration
-
+
Use a matrix to avoid a gazillion if's.
.ci/deploy-docs.sh | 2 ++
.ci/run-coveralls.sh | 14 +++++++++++
- .travis.yml | 69
- ++++++++++++++++++++++++++++++++--------------------
+ .travis.yml | 69 ++++++++++++++++++++++++++++++++--------------------
3 files changed, 58 insertions(+), 27 deletions(-)
commit 5a6d2b986a02fc47fa9dcbb330e6949af8e375ff
@@ -40675,7 +40271,7 @@
Date: Tue Dec 5 13:12:11 2017 -0800
[debug] Use %p to print pointers
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/640
src/hb-debug.hh | 2 +-
@@ -40704,7 +40300,7 @@
Date: Tue Dec 5 09:01:28 2017 -0800
Silence unused-variables warning on MSVC
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/635
src/hb-private.hh | 2 ++
@@ -40732,9 +40328,8 @@
Author: Olivier Blin <olivier.blin at softathome.com>
Date: Mon Dec 4 18:58:41 2017 +0100
- [hb-ft] Fix build when Multiple Master font support is disabled
- in freetype
-
+ [hb-ft] Fix build when Multiple Master font support is disabled in freetype
+
FT_Set_Var_Blend_Coordinates() is not available when "Multiple Master
font interface" is disabled in freetype's modules.cfg
@@ -40767,9 +40362,9 @@
Date: Sat Dec 2 15:14:26 2017 -0800
[set] Fix recent changes
-
+
Ouch!
-
+
Add tests.
test/api/test-set.c | 24 ++++++++++++++++++++++++
@@ -40789,14 +40384,13 @@
Date: Tue Nov 28 23:11:34 2017 -0800
[coretext] Add hb_coretext_font_create()
-
+
Fixes https://github.com/harfbuzz/harfbuzz/issues/628
-
+
New API:
hb_coretext_font_create()
- src/hb-coretext.cc | 55
- ++++++++++++++++++++++++++++++++++--------------------
+ src/hb-coretext.cc | 55 ++++++++++++++++++++++++++++++++++--------------------
src/hb-coretext.h | 3 +++
2 files changed, 38 insertions(+), 20 deletions(-)
@@ -40805,11 +40399,10 @@
Date: Fri Dec 1 13:56:06 2017 -0800
[set] Optimize add_range() some more
-
- It's as good as it gets, and seems to be on par with previous set
- implementation
+
+ It's as good as it gets, and seems to be on par with previous set implementation
in my benchmark.
-
+
Would be great if someone can double-check my bitops.
src/hb-set-private.hh | 16 +++++++++++++---
@@ -40820,15 +40413,13 @@
Date: Fri Dec 1 13:34:14 2017 -0800
[set] Optimize add_range()
-
+
With new set implementation, this became really costy. Optimize it.
There's more to be done, but this shaves off most of the fat.
+
+ Part of fixing https://bugs.chromium.org/p/chromium/issues/detail?id=782220
- Part of fixing
- https://bugs.chromium.org/p/chromium/issues/detail?id=782220
-
- src/hb-set-private.hh | 56
- +++++++++++++++++++++++++++++++++++++--------------
+ src/hb-set-private.hh | 56 +++++++++++++++++++++++++++++++++++++--------------
1 file changed, 41 insertions(+), 15 deletions(-)
commit be9e307a889e04d198042ad39949d3971232ab26
@@ -40845,11 +40436,10 @@
Date: Wed Nov 29 16:18:18 2017 -0800
Add another test for previous commit
-
+
From https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4273
- .../sha1sum/bbf4a308c402f0678c3e82844892a4da2ebe598f.ttf | Bin 0 ->
- 204 bytes
+ .../sha1sum/bbf4a308c402f0678c3e82844892a4da2ebe598f.ttf | Bin 0 -> 204 bytes
test/shaping/tests/fuzzed.tests | 1 +
2 files changed, 1 insertion(+)
@@ -40857,19 +40447,15 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Nov 29 16:08:11 2017 -0800
- [ot] Fix Extension type recurse to disallow recursing to another
- Extension
-
- Particularly hazardous if the second layer mixes forward and backward
- lookups.
-
+ [ot] Fix Extension type recurse to disallow recursing to another Extension
+
+ Particularly hazardous if the second layer mixes forward and backward lookups.
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4336
src/hb-ot-layout-gsub-table.hh | 6 ++++--
- .../sha1sum/9d8a94a67932a3ab75a596fc8b5c6d0392ca9e49.ttf | Bin 0 ->
- 4545 bytes
- .../sha1sum/ef2511f215aa3ca847cbfffbf861793b42170875.ttf | Bin 0 ->
- 1152 bytes
+ .../sha1sum/9d8a94a67932a3ab75a596fc8b5c6d0392ca9e49.ttf | Bin 0 -> 4545 bytes
+ .../sha1sum/ef2511f215aa3ca847cbfffbf861793b42170875.ttf | Bin 0 -> 1152 bytes
test/shaping/tests/fuzzed.tests | 2 ++
4 files changed, 6 insertions(+), 2 deletions(-)
@@ -40878,7 +40464,7 @@
Date: Wed Nov 29 14:20:09 2017 -0800
Try fixing Mac build with 10.12
-
+
Related
https://github.com/harfbuzz/harfbuzz/issues/345
https://github.com/harfbuzz/harfbuzz/pull/629
@@ -40900,12 +40486,11 @@
Date: Tue Nov 21 16:36:07 2017 -0800
[doc] Optimize HarfBuzz.png; add HarfBuzz.svg
-
+
SVG is unused. Just keeping it here.
docs/HarfBuzz.png | Bin 14203 -> 8814 bytes
- docs/HarfBuzz.svg | 277
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ docs/HarfBuzz.svg | 277 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 277 insertions(+)
commit 77efdecadddbd68bbbc0ff85ac84e24976ad4d4f
@@ -40937,8 +40522,7 @@
src/gen-use-table.py | 3 +++
src/hb-ot-shape-complex-use-table.cc | 2 +-
- .../sha1sum/373e67bf41ca264e260a9716162b71a23549e885.ttf | Bin 0 ->
- 1164 bytes
+ .../sha1sum/373e67bf41ca264e260a9716162b71a23549e885.ttf | Bin 0 -> 1164 bytes
test/shaping/tests/use-syllable.tests | 1 +
4 files changed, 5 insertions(+), 1 deletion(-)
@@ -40946,8 +40530,7 @@
Author: ebraminio <ebrahim at gnu.org>
Date: Tue Nov 21 01:07:26 2017 -0500
- [ci] Add Oracle Developer Studio (former Sun Studio) based compiler
- (#621)
+ [ci] Add Oracle Developer Studio (former Sun Studio) based compiler (#621)
.circleci/config.yml | 11 +++++++++++
1 file changed, 11 insertions(+)
@@ -40957,12 +40540,11 @@
Date: Mon Nov 20 19:43:22 2017 -0800
Fix fallback positioning of double diacritic marks
-
+
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=787284
src/hb-ot-shape-fallback.cc | 4 ++--
- .../sha1sum/856ff9562451293cbeff6f396d4e3877c4f0a436.ttf | Bin 0 ->
- 892 bytes
+ .../sha1sum/856ff9562451293cbeff6f396d4e3877c4f0a436.ttf | Bin 0 -> 892 bytes
test/shaping/tests/fallback-positioning.tests | 1 +
3 files changed, 3 insertions(+), 2 deletions(-)
@@ -40984,8 +40566,7 @@
docs/harfbuzz-docs.xml | 2 +-
...anual-buffers-language-script-and-direction.xml | 10 +++----
docs/usermanual-fonts-and-faces.xml | 2 +-
- docs/usermanual-hello-harfbuzz.xml | 34
- +++++++++++-----------
+ docs/usermanual-hello-harfbuzz.xml | 34 +++++++++++-----------
docs/usermanual-install-harfbuzz.xml | 2 +-
docs/usermanual-what-is-harfbuzz.xml | 20 ++++++-------
6 files changed, 35 insertions(+), 35 deletions(-)
@@ -40997,8 +40578,7 @@
Categorize U+0C80 as Consonant_Placeholder
src/hb-ot-shape-complex-indic.cc | 1 +
- .../sha1sum/81c368a33816fb20e9f647e8f24e2180f4720263.ttf | Bin 0 ->
- 1152 bytes
+ .../sha1sum/81c368a33816fb20e9f647e8f24e2180f4720263.ttf | Bin 0 -> 1152 bytes
test/shaping/tests/indic-syllable.tests | 1 +
3 files changed, 2 insertions(+)
@@ -41043,9 +40623,9 @@
Date: Tue Nov 14 21:53:48 2017 -0800
Limit how much recursion GSUB/GPOS does
-
+
This only counts recursions right now. Good start.
-
+
Hopefully...
Fixes https://github.com/behdad/harfbuzz/issues/429
@@ -41096,8 +40676,7 @@
src/hb-ot-layout-gdef-table.hh | 22 ++--
src/hb-ot-layout-gpos-table.hh | 94 ++++++++--------
src/hb-ot-layout-gsub-table.hh | 30 +++---
- src/hb-ot-layout-gsubgpos-private.hh | 172
- +++++++++++++++---------------
+ src/hb-ot-layout-gsubgpos-private.hh | 172 +++++++++++++++---------------
src/hb-ot-math-table.hh | 26 ++---
src/hb-ot-maxp-table.hh | 2 +-
src/hb-ot-name-table.hh | 16 +--
@@ -41126,7 +40705,7 @@
Date: Tue Nov 14 20:25:29 2017 -0800
[glyf] Try fixing undefined-behavior
-
+
Might fix https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1463
src/hb-ot-glyf-table.hh | 17 ++++++++---------
@@ -41137,9 +40716,9 @@
Date: Tue Nov 14 20:22:05 2017 -0800
[ot] Remove unneeded TODO item
-
+
Looks like hb-ot-font is complete after all!
-
+
CFF font names and CFF glyph metrics don't work though...
src/hb-ot-font.cc | 2 +-
@@ -41150,7 +40729,7 @@
Date: Tue Nov 14 20:16:45 2017 -0800
[hmtx] Use curiously recurring template pattern
-
+
https://en.wikipedia.org/wiki/Curiously_recurring_template_pattern
src/hb-ot-font.cc | 11 ++++-------
@@ -41163,8 +40742,7 @@
[ot] Move hb_ot_face_cmap_accelerator_t
- src/hb-ot-cmap-table.hh | 149
- +++++++++++++++++++++++++++++++++++++++++++++---
+ src/hb-ot-cmap-table.hh | 149 +++++++++++++++++++++++++++++++++++++++++++++---
src/hb-ot-font.cc | 130 +-----------------------------------------
2 files changed, 142 insertions(+), 137 deletions(-)
@@ -41174,8 +40752,7 @@
Shuffle
- src/hb-ot-hmtx-table.hh | 76
- ++++++++++++++++++++++++-------------------------
+ src/hb-ot-hmtx-table.hh | 76 ++++++++++++++++++++++++-------------------------
1 file changed, 38 insertions(+), 38 deletions(-)
commit a85d7ead04aff81d2f9df9110316892dbbefe1c2
@@ -41184,10 +40761,8 @@
[ot] Move hb_ot_face_metrics_accelerator_t
- src/hb-ot-font.cc | 108
- +-----------------------------------------------
- src/hb-ot-hmtx-table.hh | 108
- +++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-font.cc | 108 +-----------------------------------------------
+ src/hb-ot-hmtx-table.hh | 108 +++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 109 insertions(+), 107 deletions(-)
commit f00a94e1ec73c08d4bde1f50bff57d2dc9583ca8
@@ -41207,8 +40782,7 @@
[ot] Move hb_ot_face_glyf_accelerator_t
src/hb-ot-font.cc | 75 +----------------------------------
- src/hb-ot-glyf-table.hh | 103
- +++++++++++++++++++++++++++++++++++++++++-------
+ src/hb-ot-glyf-table.hh | 103 +++++++++++++++++++++++++++++++++++++++++-------
2 files changed, 90 insertions(+), 88 deletions(-)
commit c4e18e54dc5ffecac7b327bde9f52dd0927d6a08
@@ -41217,10 +40791,8 @@
[ot] Move hb_ot_face_cbdt_accelerator_t
- src/hb-ot-cbdt-table.hh | 85
- +++++++++++++++++++++++++++++++++++++++++++++++
- src/hb-ot-font.cc | 87
- +------------------------------------------------
+ src/hb-ot-cbdt-table.hh | 85 +++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-font.cc | 87 +------------------------------------------------
src/hb-ot-post-table.hh | 1 +
3 files changed, 87 insertions(+), 86 deletions(-)
@@ -41258,11 +40830,10 @@
Date: Tue Nov 14 15:56:21 2017 -0800
Add test for previous commit
-
+
At some point we should run tests under valgrind...
- .../sha1sum/dd9f0c7c7c36f75a18be0cab1cddf8f3ab0f366b.ttf | Bin 0 ->
- 2786 bytes
+ .../sha1sum/dd9f0c7c7c36f75a18be0cab1cddf8f3ab0f366b.ttf | Bin 0 -> 2786 bytes
test/shaping/tests/fuzzed.tests | 3 ++-
2 files changed, 2 insertions(+), 1 deletion(-)
@@ -41271,7 +40842,7 @@
Date: Tue Nov 14 15:47:55 2017 -0800
Fix invalid buffer access in OOM times
-
+
Hopefully fully fixes
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1856
@@ -41303,8 +40874,7 @@
Allow U+20F0 in USE clusters
src/gen-use-table.py | 4 +++
- src/hb-ot-shape-complex-use-table.cc | 34
- +++++++++++++--------
+ src/hb-ot-shape-complex-use-table.cc | 34 +++++++++++++--------
.../074a5ae6b19de8f29772fdd5df2d3d833f81f5e6.ttf | Bin 0 -> 2296 bytes
test/shaping/tests/use-syllable.tests | 1 +
4 files changed, 26 insertions(+), 13 deletions(-)
@@ -41324,15 +40894,15 @@
Date: Tue Nov 14 10:59:54 2017 -0800
Revert "[glib/ucdn/icu/ft/ot] Make returned funcs inert"
-
+
This reverts commit 5daf3bd4494cce6b4fb074533be9e99c4d9e0edd.
-
+
If other atexit callbacks try to destruct the objects we destruct
in atexit callbacks, bad things will happen.
-
+
I'll come up with some other way to catch premature destruction
of HB-owned objects.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/618
src/hb-ft.cc | 3 ---
@@ -41357,11 +40927,11 @@
Date: Mon Nov 13 20:25:02 2017 -0800
Clean up GlyphID
-
+
After 4a27c17ea0234dfe33e62f5830d9f92c26d48d30 we do not need
the special GlyphID.cmp(hb_codepoint_t), so just make GlyphID
a typedef.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/612
src/hb-open-type-private.hh | 5 +----
@@ -41372,7 +40942,7 @@
Date: Mon Nov 13 15:04:13 2017 -0800
Implement strtod_l() on MSVC
-
+
Patch from Jean Ghali on mailing list.
src/hb-common.cc | 21 +++++++++++++++------
@@ -41392,11 +40962,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Nov 10 17:14:27 2017 -0800
- [coretext/uniscribe/directwrite/graphite/fallback] Update for
- unsafe-to-break
-
+ [coretext/uniscribe/directwrite/graphite/fallback] Update for unsafe-to-break
+
Fixes https://github.com/behdad/harfbuzz/issues/615
-
+
We'll see which bots I broke.
src/hb-buffer-private.hh | 17 +++++++++++++++--
@@ -41421,14 +40990,13 @@
Date: Thu Nov 9 18:09:40 2017 -0800
[kern] Fix invalid memory access if offset is zero
-
+
If offset is zero, we return Null() object. Wasn't prepared for that.
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4088
src/hb-ot-kern-table.hh | 9 +++++----
- .../sha1sum/243798dd281c1c77c065958e1ff467420faa9bde.ttf | Bin 0 ->
- 225 bytes
+ .../sha1sum/243798dd281c1c77c065958e1ff467420faa9bde.ttf | Bin 0 -> 225 bytes
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 6 insertions(+), 4 deletions(-)
@@ -41437,7 +41005,7 @@
Date: Fri Nov 3 14:27:33 2017 +0200
[test] Use glyph ids instead of forcing ft funcs
-
+
We were using ft funcs because these are CFF fonts, but we can avoid
glyph names instead and keep testing both ot and ft.
@@ -41450,13 +41018,11 @@
Date: Thu Nov 2 09:45:06 2017 +0200
[test] Fix another instance of component rounding
-
+
See https://github.com/behdad/harfbuzz/pull/590#issuecomment-341194673
- .../sha1sum/7ef276fc886ea502a03b9b0e5c8b547d5dc2b61c.ttf | Bin 784 ->
- 0 bytes
- .../sha1sum/8228d035fcd65d62ec9728fb34f42c63be93a5d3.ttf | Bin 0 ->
- 784 bytes
+ .../sha1sum/7ef276fc886ea502a03b9b0e5c8b547d5dc2b61c.ttf | Bin 784 -> 0 bytes
+ .../sha1sum/8228d035fcd65d62ec9728fb34f42c63be93a5d3.ttf | Bin 0 -> 784 bytes
test/shaping/tests/fallback-positioning.tests | 3 +--
3 files changed, 1 insertion(+), 2 deletions(-)
@@ -41465,7 +41031,7 @@
Date: Wed Nov 8 17:04:31 2017 -0800
Fix indexing in unsafe-to-break marking for 'stch' feature
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=4099
src/hb-ot-shape-complex-arabic.cc | 2 +-
@@ -41476,7 +41042,7 @@
Date: Wed Nov 8 17:03:55 2017 -0800
[tests/arabic-stch.tests] Don't show flags
-
+
We don't need to test the actual flag values. For unsafe-to-break,
the --verify in run-tests.sh checks what we are interested in.
@@ -41498,11 +41064,9 @@
Mark non-initial left matras as unsafe to break
- src/hb-ot-shape-complex-indic.cc | 14
- +++++++++-----
+ src/hb-ot-shape-complex-indic.cc | 14 +++++++++-----
test/shaping/Makefile.am | 1 +
- .../sha1sum/1a3d8f381387dd29be1e897e4b5100ac8b4829e1.ttf | Bin 0 ->
- 1380 bytes
+ .../sha1sum/1a3d8f381387dd29be1e897e4b5100ac8b4829e1.ttf | Bin 0 -> 1380 bytes
test/shaping/tests/indic-init.tests | 1 +
4 files changed, 11 insertions(+), 5 deletions(-)
@@ -41520,7 +41084,7 @@
Date: Mon Nov 6 15:28:24 2017 -0500
[kern] Allow subtables longer than 64kb
-
+
Apparently calibri.ttf does this:
https://github.com/fonttools/fonttools/pull/1094#discussion_r148933791
@@ -41535,8 +41099,7 @@
[kern] Towards implementing format-2
src/hb-open-type-private.hh | 4 +--
- src/hb-ot-kern-table.hh | 69
- +++++++++++++++++++++++++++------------------
+ src/hb-ot-kern-table.hh | 69 +++++++++++++++++++++++++++------------------
2 files changed, 42 insertions(+), 31 deletions(-)
commit 74e82adaea08ced18493e3341823dbd5b6cd493e
@@ -41547,8 +41110,7 @@
src/hb-ot-shape-complex-arabic.cc | 1 +
test/shaping/Makefile.am | 1 +
- .../sha1sum/d9b8bc10985f24796826c29f7ccba3d0ae11ec02.ttf | Bin 0 ->
- 1420 bytes
+ .../sha1sum/d9b8bc10985f24796826c29f7ccba3d0ae11ec02.ttf | Bin 0 -> 1420 bytes
test/shaping/tests/arabic-stch.tests | 1 +
4 files changed, 3 insertions(+)
@@ -41557,7 +41119,7 @@
Date: Fri Nov 3 20:34:11 2017 -0400
[configure] Fix gobject default value in help output
-
+
Fixes https://github.com/behdad/harfbuzz/issues/607
configure.ac | 2 +-
@@ -41568,11 +41130,10 @@
Date: Fri Nov 3 17:16:26 2017 -0400
Simplify tracing code when tracing is disabled
-
+
Fixes https://github.com/behdad/harfbuzz/pull/605
- src/hb-debug.hh | 58
- +++++++++++++++++++++++++++++-------
+ src/hb-debug.hh | 58 +++++++++++++++++++++++++++++-------
src/hb-ot-layout-gsubgpos-private.hh | 10 +++----
2 files changed, 52 insertions(+), 16 deletions(-)
@@ -41581,14 +41142,13 @@
Date: Fri Nov 3 16:57:30 2017 -0400
Consolidate debug stuff into hb-debug.hh
-
+
Part of fixing https://github.com/behdad/harfbuzz/pull/605
src/Makefile.sources | 1 +
src/hb-blob.cc | 7 +-
src/hb-coretext.cc | 8 +-
- src/hb-debug.hh | 383
- +++++++++++++++++++++++++++++++++++
+ src/hb-debug.hh | 383 +++++++++++++++++++++++++++++++++++
src/hb-directwrite.cc | 6 +-
src/hb-ft.cc | 7 +-
src/hb-object-private.hh | 8 +-
@@ -41616,7 +41176,7 @@
Date: Fri Nov 3 09:05:00 2017 -0400
Trivial typos
-
+
Found using `codespell -i 3 -w -I '../harf-whitelist.txt'`
whereas the whitelist contents were:
```
@@ -41665,9 +41225,9 @@
Date: Wed Nov 1 19:41:29 2017 -0600
[ot] Hook up horizontal kerning to kern table
-
+
Seems to work. Yay!
-
+
Still to do: run kerning if GPOS doesn't have 'kern' feature.
src/hb-ot-font.cc | 2 +-
@@ -41678,12 +41238,11 @@
Date: Wed Nov 1 19:33:09 2017 -0600
[kern] More...
-
+
Almost there.
src/hb-ot-font.cc | 14 +++++++++
- src/hb-ot-kern-table.hh | 75
- ++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-kern-table.hh | 75 ++++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 88 insertions(+), 1 deletion(-)
commit 49c0f35580946c74bc64dae2d2c65c7834e46ab2
@@ -41710,8 +41269,7 @@
[kern] Implement Format0
- src/hb-ot-kern-table.hh | 51
- +++++++++++++++++++++++++++++++++++++++++++------
+ src/hb-ot-kern-table.hh | 51 +++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 45 insertions(+), 6 deletions(-)
commit ac3d937c6cb0e2c7e019aa391b02da25aa6970de
@@ -41720,8 +41278,7 @@
[kern] Implement some more
- src/hb-ot-kern-table.hh | 98
- ++++++++++++++++++++++++++++++++++++++-----------
+ src/hb-ot-kern-table.hh | 98 ++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 77 insertions(+), 21 deletions(-)
commit 2a16f647ae4c5115a356ba82245c77e0d01fcebf
@@ -41729,15 +41286,13 @@
Date: Wed Nov 1 17:31:29 2017 -0600
[kern] Start implementing kern table
-
- Pushing this out early to catch bot errors since I'm using template
- tricks
+
+ Pushing this out early to catch bot errors since I'm using template tricks
we were not using in HarfBuzz before.
src/Makefile.sources | 1 +
src/hb-ot-font.cc | 1 +
- src/hb-ot-kern-table.hh | 184
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-kern-table.hh | 184 ++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 186 insertions(+)
commit 292ef2675edb2cb579210183e77ac30335318a21
@@ -41763,17 +41318,14 @@
Date: Wed Nov 1 20:49:42 2017 +0200
[test] Fix difference between ft and ot font funcs
-
- See
- https://github.com/behdad/harfbuzz/pull/590#issuecomment-341194673.
-
+
+ See https://github.com/behdad/harfbuzz/pull/590#issuecomment-341194673.
+
I simply removed the composite glyph and use the referenced simple
glyph directly.
- .../sha1sum/4fac3929fc3332834e93673780ec0fe94342d193.ttf | Bin 0 ->
- 804 bytes
- .../sha1sum/6466d38c62e73a39202435a4f73bf5d6acbb73c0.ttf | Bin 824 ->
- 0 bytes
+ .../sha1sum/4fac3929fc3332834e93673780ec0fe94342d193.ttf | Bin 0 -> 804 bytes
+ .../sha1sum/6466d38c62e73a39202435a4f73bf5d6acbb73c0.ttf | Bin 824 -> 0 bytes
test/shaping/tests/cluster.tests | 2 +-
3 files changed, 1 insertion(+), 1 deletion(-)
@@ -41782,7 +41334,7 @@
Date: Wed Nov 1 20:33:43 2017 +0200
Revert "[test] We don’t care about glyph positions here"
-
+
This reverts commit 70137e2b4b46918d9608f824a4b4b5cef2819158.
test/shaping/tests/cluster.tests | 4 ++--
@@ -41802,15 +41354,13 @@
Date: Wed Nov 1 12:03:39 2017 +0200
[test] We don’t care about glyph positions here
-
- Freetype and OT font functions give different positions for some
- glyphs
+
+ Freetype and OT font functions give different positions for some glyphs
in this font (OT seems to be correct), but that is not what we are
interested in in this test.
+
+ See https://github.com/behdad/harfbuzz/pull/590#issuecomment-341045223.
- See
- https://github.com/behdad/harfbuzz/pull/590#issuecomment-341045223.
-
test/shaping/tests/cluster.tests | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -41819,7 +41369,7 @@
Date: Wed Nov 1 10:34:36 2017 +0200
[test] Use ft functions for this test
-
+
https://github.com/behdad/harfbuzz/pull/590#issuecomment-340967271
test/shaping/tests/vertical.tests | 2 +-
@@ -41830,9 +41380,8 @@
Date: Mon Oct 30 22:02:50 2017 +0200
[test] Always use ft font funcs for these tests
-
- These are CFF fonts and ot functions don’t support CFF glyph
- names yet.
+
+ These are CFF fonts and ot functions don’t support CFF glyph names yet.
The next commit will run all tests with ot functions.
test/shaping/tests/indic-consonant-with-stacker.tests | 8 ++++----
@@ -41865,7 +41414,7 @@
Date: Wed Nov 1 01:15:27 2017 -0600
[CircleCI] Ignore gh-pages branch
-
+
https://github.com/behdad/harfbuzz/pull/592
.circleci/config.yml | 4 ++++
@@ -41947,8 +41496,7 @@
Categorize Grantha candrabindu for use in Tamil
src/hb-ot-shape-complex-indic.cc | 2 +-
- .../sha1sum/b151cfcdaa77585d77f17a42158e0873fc8e2633.ttf | Bin 0 ->
- 1120 bytes
+ .../sha1sum/b151cfcdaa77585d77f17a42158e0873fc8e2633.ttf | Bin 0 -> 1120 bytes
test/shaping/tests/indic-script-extensions.tests | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
@@ -41957,7 +41505,7 @@
Date: Tue Oct 31 14:25:46 2017 -0600
[CircleCI] Fix build
-
+
Fixes https://github.com/behdad/harfbuzz/issues/589
.circleci/config.yml | 6 +++---
@@ -41975,11 +41523,10 @@
Date: Tue Oct 31 14:02:32 2017 -0600
Simplify hb-sort-r.hh
-
+
See https://github.com/behdad/harfbuzz/pull/592
- src/hb-sort-r.hh | 147
- ++++++-------------------------------------------------
+ src/hb-sort-r.hh | 147 ++++++-------------------------------------------------
1 file changed, 14 insertions(+), 133 deletions(-)
commit b7982c9e65e0b58616cc8264dd52cac37753ef79
@@ -41988,8 +41535,7 @@
[ci] Add CircleCI for cross-compiling (#592)
- .circleci/config.yml | 61
- ++++++++++++++++++++++++++++++++++++++++++++++++++++
+ .circleci/config.yml | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++
README | 1 +
2 files changed, 62 insertions(+)
@@ -41998,7 +41544,7 @@
Date: Tue Oct 31 13:18:21 2017 -0600
Define _GNU_SOURCE
-
+
Might help with https://github.com/behdad/harfbuzz/pull/592
Ie. bringing in qsort_r() prototype always.
@@ -42010,7 +41556,7 @@
Date: Tue Oct 31 11:17:43 2017 -0600
[coretext/uniscribe] Fix build
-
+
https://travis-ci.org/behdad/harfbuzz/jobs/295039536#L3468
https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.697/job/dr1ujlntxafeqbej#L142
@@ -42023,7 +41569,7 @@
Date: Mon Oct 30 14:11:59 2017 -0600
Fix Windows build
-
+
(And prevent it from happening in the future.)
src/hb-ot-layout.cc | 1 +
@@ -42035,11 +41581,10 @@
Date: Mon Oct 30 13:15:05 2017 -0600
[post] Implement glyph_from_name()
-
+
This concludes https://github.com/behdad/harfbuzz/pull/568
- src/hb-ot-post-table.hh | 119
- ++++++++++++++++++++++++++++++++++++------------
+ src/hb-ot-post-table.hh | 119 ++++++++++++++++++++++++++++++++++++------------
src/hb-private.hh | 10 ++--
src/hb-sort-r.hh | 2 +-
3 files changed, 96 insertions(+), 35 deletions(-)
@@ -42080,8 +41625,7 @@
[post] Minor; towards implementing get_glyph_from_name()
- src/hb-ot-post-table.hh | 56
- +++++++++++++++++++++++++++----------------------
+ src/hb-ot-post-table.hh | 56 +++++++++++++++++++++++++++----------------------
1 file changed, 31 insertions(+), 25 deletions(-)
commit 977679f229a10868dc668294082bd82125e4fe48
@@ -42114,8 +41658,7 @@
Add hb-sort-r, a portable qsort_r() replacement
src/Makefile.sources | 1 +
- src/hb-sort-r.hh | 227
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-sort-r.hh | 227 +++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 228 insertions(+)
commit 923a8f520addba095384b975ba8934e5a18fb696
@@ -42141,12 +41684,11 @@
Date: Sat Oct 28 19:54:04 2017 -0600
[ot] Speed up get_glyph_name()
-
+
get_glyph_from_name() coming soon.
src/hb-ot-font.cc | 13 ++--
- src/hb-ot-post-table.hh | 160
- +++++++++++++++++++------------------------
+ src/hb-ot-post-table.hh | 160 +++++++++++++++++++------------------------
src/test-buffer-serialize.cc | 4 +-
3 files changed, 81 insertions(+), 96 deletions(-)
@@ -42164,7 +41706,7 @@
Date: Sat Oct 28 12:00:49 2017 -0600
More nullptr fix
-
+
Fixes https://github.com/behdad/harfbuzz/issues/585
src/test.cc | 4 +---
@@ -42175,7 +41717,7 @@
Date: Fri Oct 27 16:34:01 2017 -0600
[glib/ucdn/icu/ft/ot] Make returned funcs inert
-
+
Such that client cannot accidentally destroy them, even though that
will be a bug in their code...
@@ -42192,7 +41734,7 @@
Date: Fri Oct 27 16:03:51 2017 -0600
Fix previous commit
-
+
Oops.
src/hb-glib.cc | 2 +-
@@ -42216,7 +41758,7 @@
Date: Fri Oct 27 15:13:50 2017 -0600
Correctly mark NullPool const
-
+
Saves some more code size as well!
src/hb-open-type-private.hh | 2 +-
@@ -42229,7 +41771,7 @@
Date: Fri Oct 27 15:09:22 2017 -0600
Reduce prealloced number of user-data items from 2 to 1
-
+
Even 1 is too many but putting 0 breaks compile. Saves 3k in .so
src/hb-private.hh | 2 +-
@@ -42240,7 +41782,7 @@
Date: Fri Oct 27 15:01:40 2017 -0600
Make the NullPool HB_INTERNAL shared
-
+
Saves 2k of .bss section.
src/hb-open-type-private.hh | 10 ++++++----
@@ -42253,7 +41795,7 @@
Date: Fri Oct 27 14:42:59 2017 -0600
[ot] Remove shaper name
-
+
In ten years we never used them...
src/hb-ot-shape-complex-arabic.cc | 1 -
@@ -42273,7 +41815,7 @@
Date: Fri Oct 27 14:29:12 2017 -0600
Fix IntType.cmp() to avoid narrowing down integer types
-
+
Fixes https://github.com/behdad/harfbuzz/issues/571
src/hb-open-type-private.hh | 5 +++--
@@ -42284,12 +41826,11 @@
Date: Fri Oct 27 10:29:25 2017 -0600
Make c++11 optional
-
+
Fixes https://github.com/behdad/harfbuzz/issues/585
configure.ac | 4 +-
- m4/ax_cxx_compile_stdcxx.m4 | 982
- ++++++++++++++++++++++++++++++++++++++++++++
+ m4/ax_cxx_compile_stdcxx.m4 | 982 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 983 insertions(+), 3 deletions(-)
commit 6c4689704071a76c49be819b8034feaf93e26a42
@@ -42315,7 +41856,7 @@
Date: Fri Oct 27 09:29:20 2017 -0600
Use NULL instead of polyfill, if nullptr is not available
-
+
Part of fixing https://github.com/behdad/harfbuzz/issues/585
src/hb-private.hh | 22 +++-------------------
@@ -42326,7 +41867,7 @@
Date: Fri Oct 27 09:22:30 2017 -0600
Include hb-private.hh more consistently
-
+
Part of fixing https://github.com/behdad/harfbuzz/issues/585
src/test-buffer-serialize.cc | 4 +---
@@ -42346,7 +41887,7 @@
Date: Fri Oct 27 00:25:11 2017 -0600
Towards compiling with pre-C++11 compilers and nullptr fallback
-
+
https://github.com/behdad/harfbuzz/issues/585
src/hb-atomic-private.hh | 4 ++--
@@ -42359,8 +41900,7 @@
[post] Make format1 names array avoid relocations
src/Makefile.sources | 1 +
- src/hb-ot-post-macroman.hh | 294
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-post-macroman.hh | 294 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-post-table.hh | 55 ++-------
3 files changed, 305 insertions(+), 45 deletions(-)
@@ -42369,13 +41909,12 @@
Date: Thu Oct 26 19:48:33 2017 -0600
Add hb-string-array.hh
-
+
Used to build static string arrays that use no relocation.
src/Makefile.sources | 1 +
src/hb-private.hh | 6 ++--
- src/hb-string-array.hh | 74
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-string-array.hh | 74 ++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 79 insertions(+), 2 deletions(-)
commit 6f08b12bc38166dee2f9740d396d617b32e887a3
@@ -42411,7 +41950,7 @@
Date: Thu Oct 26 11:43:33 2017 -0600
Fix warning
-
+
https://github.com/behdad/harfbuzz/commit/49a41dc75931cc2d2f7e74b7801f8cc327039e8e#commitcomment-25203194
test/api/test-set.c | 5 +++--
@@ -42422,7 +41961,7 @@
Date: Thu Oct 26 16:59:50 2017 +0100
[set] Fix page_map[] indexing in backward loop.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/579.
src/hb-set-private.hh | 4 ++--
@@ -42442,7 +41981,7 @@
Date: Thu Oct 26 17:54:55 2017 +0100
[test] Additional coverage in test_set_iter.
-
+
This adds a couple extra entries to the set used, such that iteration
would fail in 1.6.2 due to the bug in hb_set_t::page_t::next().
@@ -42463,7 +42002,7 @@
Date: Wed Oct 25 18:22:47 2017 -0600
[post] Oops!
-
+
https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.668/job/ikfj8peowgrp059t
src/hb-ot-post-table.hh | 4 ++--
@@ -42474,12 +42013,11 @@
Date: Wed Oct 25 17:40:50 2017 -0600
[post] Touch up and fixes
-
+
The get_glyph_from_name() is incorrect; needs fixing.
src/hb-ot-font.cc | 9 ++--
- src/hb-ot-post-table.hh | 139
- +++++++++++++++++++++++++++---------------------
+ src/hb-ot-post-table.hh | 139 +++++++++++++++++++++++++++---------------------
2 files changed, 81 insertions(+), 67 deletions(-)
commit d9e166f74c3ba3128c9ef3ccd8d7799e67f14eab
@@ -42489,8 +42027,7 @@
[ot-font] Implement hb_ot_get_glyph_from_name
src/hb-ot-font.cc | 22 ++++++++++++++++++-
- src/hb-ot-post-table.hh | 58
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-post-table.hh | 58 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 79 insertions(+), 1 deletion(-)
commit 9d4d2fb9af446d5d41058fbb1da8117b3af048d3
@@ -42498,14 +42035,12 @@
Date: Mon Oct 16 10:05:42 2017 +0200
[ot-font] Implement hb_ot_get_glyph_name
-
- Turns out we already have support for “post” table, it just
- needed to be
+
+ Turns out we already have support for “post” table, it just needed to be
activated and put in use.
src/hb-ot-font.cc | 46 ++++++++++++-
- src/hb-ot-post-table.hh | 96
- +++++++++++++++++++++++++++
+ src/hb-ot-post-table.hh | 96 +++++++++++++++++++++++++++
test/shaping/tests/fallback-positioning.tests | 2 +-
test/shaping/tests/indic-syllable.tests | 2 +-
test/shaping/tests/use.tests | 2 +-
@@ -42523,7 +42058,7 @@
Date: Wed Oct 25 16:17:45 2017 -0600
[test] Add more hb-set tests
-
+
https://github.com/behdad/harfbuzz/issues/579
test/api/test-set.c | 40 ++++++++++++++++++++++++++++++++++++++++
@@ -42562,7 +42097,7 @@
Date: Wed Oct 25 12:09:11 2017 -0400
Check for headers in builddir first, in check-*.sh
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=103346
src/check-c-linkage-decls.sh | 4 ++--
@@ -42576,13 +42111,12 @@
Date: Tue Oct 24 10:06:25 2017 -0400
check-externs.sh: Make output more verbose
-
+
Trying to figure out why this is failing on some Debian bots:
https://bugs.freedesktop.org/show_bug.cgi?id=103346
+
+ Maybe I should check for GNU grep specifically now that I'm using -n as well.
- Maybe I should check for GNU grep specifically now that I'm using
- -n as well.
-
src/check-externs.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
@@ -42610,10 +42144,9 @@
Date: Mon Oct 23 14:26:48 2017 -0400
[set] Fix crash
-
- Ouch! That's what happens when one plays with increment/decrement
- operators!
-
+
+ Ouch! That's what happens when one plays with increment/decrement operators!
+
Fixes https://github.com/behdad/harfbuzz/issues/578
src/hb-set-private.hh | 10 ++++++----
@@ -42625,8 +42158,7 @@
[RELEASING] Format
- RELEASING.md | 67
- +++++++++++++++++++++++++++++++++++++++++++-----------------
+ RELEASING.md | 67 +++++++++++++++++++++++++++++++++++++++++++-----------------
1 file changed, 48 insertions(+), 19 deletions(-)
commit 6a2e1649debd992211bf96ef80d075d2d04a49ed
@@ -42634,7 +42166,7 @@
Date: Mon Oct 23 13:01:34 2017 -0400
[doap] Switch to github issues
-
+
https://github.com/behdad/harfbuzz/pull/575#issuecomment-338514596
harfbuzz.doap | 2 +-
@@ -42645,7 +42177,7 @@
Date: Mon Oct 23 13:00:36 2017 -0400
[RELEASING] Minor
-
+
https://github.com/behdad/harfbuzz/pull/575
RELEASING.md | 4 ++--
@@ -42665,7 +42197,7 @@
Date: Mon Oct 23 08:36:40 2017 -0400
[set] Don't use major()
-
+
Fixes https://github.com/behdad/harfbuzz/issues/577
src/hb-set-private.hh | 10 +++++-----
@@ -42676,7 +42208,7 @@
Date: Mon Oct 23 08:34:30 2017 -0400
[set] Don't use PAGE_SIZE
-
+
Fixes https://github.com/behdad/harfbuzz/issues/576
src/hb-set-private.hh | 12 ++++++------
@@ -42704,7 +42236,7 @@
Date: Mon Oct 23 01:48:22 2017 +0330
Merge pull request #575 from behdad/releasing-edit
-
+
Clarify the last step of release
commit 19923279abd4c7615e8b02e05a02ba18f5c0b298
@@ -42785,7 +42317,7 @@
Date: Sat Oct 21 10:19:55 2017 +0330
Merge pull request #572 from fanc999/master.msvc
-
+
builds: Support HarfBuzz-GObject and introspection in CMake builds
commit d8adaa97fbf33071b8a4b5c05c3f2f15f2fd22ea
@@ -42793,11 +42325,9 @@
Date: Fri Oct 20 13:57:43 2017 -0400
Another try at fixing build bots
+
+ hb-ot-shape.cc:287:18: error: comparison of constant 32 with expression of type 'hb_unicode_general_category_t' is always true [-Werror,-Wtautological-constant-out-of-range-compare]
- hb-ot-shape.cc:287:18: error: comparison of constant 32 with
- expression of type 'hb_unicode_general_category_t' is always true
- [-Werror,-Wtautological-constant-out-of-range-compare]
-
src/hb-private.hh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
@@ -42806,7 +42336,7 @@
Date: Thu Oct 19 11:39:52 2017 -0700
Remove FLAG_SAFE()
-
+
No flag is safe, over time... See previous commit.
src/hb-ot-shape-complex-arabic.cc | 4 ++--
@@ -42821,12 +42351,12 @@
Date: Thu Oct 19 11:35:51 2017 -0700
[myanmar] Fix unsafe usage of FLAG_SAFE()
-
+
The commit f559c633073f63b9d87cb2440048b4413cfa1c05 caused
"undefined-shift" errors in Myanmar shaper as we changed the
numeric value of type D from 19 to 32 there, making the
"FLAG_SAFE (info.myanmar_category())" wrong.
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3546
src/hb-ot-shape-complex-myanmar.cc | 2 +-
@@ -42837,13 +42367,11 @@
Date: Thu Oct 19 18:36:32 2017 +0800
CMake builds: Support introspection builds
-
- This adds support for introspection builds on Windows that is
- enabled by
- the HB_HAVE_INTROSPECTION option, which will also enable
- HB_HAVE_GOBJECT
+
+ This adds support for introspection builds on Windows that is enabled by
+ the HB_HAVE_INTROSPECTION option, which will also enable HB_HAVE_GOBJECT
(and so HB_HAVE_GLIB) as they are required for introspection.
-
+
In order for this to work one must ensure that the Python installation
listed in PYTHON_EXECUTABLE is the same Python release series that was
used to build _giscanner.pyd (the Python module that is used by
@@ -42852,8 +42380,7 @@
are not in the standard PATH and PKG_CONFIG_PATH, which is actually
in-line with the *NIX builds.
- CMakeLists.txt | 161
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++---
+ CMakeLists.txt | 161 ++++++++++++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 154 insertions(+), 7 deletions(-)
commit 53db221259b5eea4d2244321b2fe96beb39aef7d
@@ -42861,28 +42388,24 @@
Date: Wed Oct 18 15:43:57 2017 +0800
CMake: Support building HarfBuzz-GObject
-
+
This adds support to the CMake build files to support building
HarfBuzz-GObject, which is actually a little bit complicated,
as we need to:
-
+
-Run glib-mkenums, which is a Python (for newer GLib/GObject) or PERL
(for older, pre 2.53.4, GLib/GObject) script. This matters more for
- Visual Studio builds as shebang lines are not supported, so we
- need to
+ Visual Studio builds as shebang lines are not supported, so we need to
test-run it with PERL or Python to determine which is the correct
interpretor to use.
-
+
-Next, we need to replace strings in the sources that we obtain from
- running glib-mkenums. So, the solution here is to use a small
- utility
- CMake script for our purposes here, to maintain maximum
- compatibility.
-
+ running glib-mkenums. So, the solution here is to use a small utility
+ CMake script for our purposes here, to maintain maximum compatibility.
+
-Ensure that things do work in the Visual Studio IDE builds.
- CMakeLists.txt | 128
- +++++++++++++++++++++++++++++++++++++++++++++
+ CMakeLists.txt | 128 +++++++++++++++++++++++++++++++++++++++++++++
Makefile.am | 1 +
replace-enum-strings.cmake | 21 ++++++++
3 files changed, 150 insertions(+)
@@ -42892,13 +42415,13 @@
Date: Wed Oct 18 22:27:28 2017 +0800
CMake builds: Fix builds
-
+
Include the fallback sources in the build, and update
src/Makefile.sources so that it can be read by the CMake build files.
-
+
Fix a typo in the DirectWrite configure option so that we can properly
enable DirectWrite builds.
-
+
Also, when building the utility program, install them as well.
CMakeLists.txt | 21 ++++++++++++++++++++-
@@ -42919,13 +42442,12 @@
Date: Tue Oct 17 15:06:31 2017 -0700
Switch from ICU deprecated unorm_normalize to unorm2_normalize. (#569)
-
+
The new unorm2_normalize has been public API since ICU 4.4, while
the old unorm_normalize has been deprecated since ICU 56.
-
+
Now, beginning with ICU 60, unorm_normalize will also be annotated
- U_DEPRECATED and trigger the compiler -Wdeprecated-declarations
- warning.
+ U_DEPRECATED and trigger the compiler -Wdeprecated-declarations warning.
src/hb-icu.cc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
@@ -42944,11 +42466,9 @@
Date: Tue Oct 17 11:16:36 2017 -0700
Try fixing build on VC
+
+ c:\projects\harfbuzz\src\hb-set-private.hh(151): error C2327: 'hb_set_t::page_t::v': is not a type name, static, or enumerator [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
- c:\projects\harfbuzz\src\hb-set-private.hh(151): error C2327:
- 'hb_set_t::page_t::v': is not a type name, static, or enumerator
- [C:\projects\harfbuzz\build\harfbuzz.vcxproj]
-
src/hb-set-private.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -42957,7 +42477,7 @@
Date: Tue Oct 17 11:14:48 2017 -0700
[coretext] Fix build
-
+
error: static_assert expression is not an integral constant expression
src/hb-coretext.cc | 2 +-
@@ -42986,7 +42506,7 @@
Date: Sun Oct 15 18:20:25 2017 -0400
[set] Disable vectorization
-
+
Fixes clang "non-const reference cannot bind to vector element" error.
src/hb-set-private.hh | 4 +++-
@@ -43034,10 +42554,8 @@
Properly detect vector_size attribute and use fallback otherwise
- src/hb-private.hh | 67
- +++++++++++++++++++++++++++++++++++++++++++++++++++
- src/hb-set-private.hh | 62
- ++---------------------------------------------
+ src/hb-private.hh | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-set-private.hh | 62 ++---------------------------------------------
2 files changed, 69 insertions(+), 60 deletions(-)
commit f8a0ec50e23264fdfe9e3a5a2e0453a87f415b3d
@@ -43046,8 +42564,7 @@
[set] Add fallback implementation of int-vector type
- src/hb-set-private.hh | 64
- ++++++++++++++++++++++++++++++++++++---------------
+ src/hb-set-private.hh | 64 ++++++++++++++++++++++++++++++++++++---------------
1 file changed, 45 insertions(+), 19 deletions(-)
commit deed4a48d15d4a475f8695aa3269547adf63867a
@@ -43055,12 +42572,11 @@
Date: Sun Oct 15 16:53:09 2017 +0200
Faster hb_set_t
-
+
Fixes https://github.com/behdad/harfbuzz/pull/23
src/hb-private.hh | 56 ++++---
- src/hb-set-private.hh | 431
- +++++++++++++++++++++++++++++++++++++++++---------
+ src/hb-set-private.hh | 431 +++++++++++++++++++++++++++++++++++++++++---------
test/api/test-set.c | 6 -
3 files changed, 391 insertions(+), 102 deletions(-)
@@ -43110,8 +42626,7 @@
Remove unused hb_cache_t
src/Makefile.sources | 1 -
- src/hb-cache-private.hh | 74
- -------------------------------------------------
+ src/hb-cache-private.hh | 74 -------------------------------------------------
src/hb-ft.cc | 2 --
3 files changed, 77 deletions(-)
@@ -43121,8 +42636,7 @@
Remove unused hb_frozen_set_t
- src/hb-set-private.hh | 55
- ---------------------------------------------------
+ src/hb-set-private.hh | 55 ---------------------------------------------------
1 file changed, 55 deletions(-)
commit 826a1daf2f2075459ff25a20ed8abec030d95c52
@@ -43133,8 +42647,7 @@
src/Makefile.sources | 1 +
src/hb-ot-layout-private.hh | 2 +-
- src/hb-set-digest-private.hh | 144
- +++++++++++++++++++++++++++++++++++++++++++
+ src/hb-set-digest-private.hh | 144 +++++++++++++++++++++++++++++++++++++++++++
src/hb-set-private.hh | 113 ---------------------------------
4 files changed, 146 insertions(+), 114 deletions(-)
@@ -43233,8 +42746,7 @@
util/hb-shape.cc | 14 ++--
util/helper-cairo.cc | 12 ++--
util/main-font-text.hh | 4 +-
- util/options.cc | 110
- ++++++++++++++---------------
+ util/options.cc | 110 ++++++++++++++---------------
util/options.hh | 56 +++++++--------
util/shape-consumer.hh | 10 +--
65 files changed, 563 insertions(+), 568 deletions(-)
@@ -43268,8 +42780,7 @@
src/hb-ot-shape-complex-arabic-fallback.hh | 6 +++---
src/hb-ot-shape-complex-indic.cc | 2 +-
src/hb-ot-shape-complex-use.cc | 2 +-
- src/hb-private.hh | 34
- +++++++++++++-----------------
+ src/hb-private.hh | 34 +++++++++++++-----------------
src/hb-set-private.hh | 8 +++----
src/hb-uniscribe.cc | 2 +-
util/options.cc | 3 ++-
@@ -43280,7 +42791,7 @@
Date: Sun Oct 15 11:24:35 2017 +0200
Add polyfill for static_assert and nullptr
-
+
Also fix hb_assert_constant_t.
src/hb-private.hh | 38 ++++++++++++++++++++++++++++++++++----
@@ -43291,7 +42802,7 @@
Date: Sun Oct 15 10:55:32 2017 +0200
[util] Include hb-private.hh
-
+
Simplifies compatibility issues by centralizing all boilerplate code
in hb-private.hh.
@@ -43303,16 +42814,14 @@
Date: Sun Oct 15 10:48:19 2017 +0200
Never skip over CGJ
-
+
We might want to tweak this some more. For now, never skipping over
it is better behavior than always skipping.
-
+
Part of https://github.com/behdad/harfbuzz/issues/554
- src/hb-ot-layout-private.hh | 19
- +++++++++++--------
- .../bf962d3202883a820aed019d9b5c1838c2ff69c6.ttf | Bin 0 ->
- 2468 bytes
+ src/hb-ot-layout-private.hh | 19 +++++++++++--------
+ .../bf962d3202883a820aed019d9b5c1838c2ff69c6.ttf | Bin 0 -> 2468 bytes
test/shaping/tests/default-ignorables.tests | 1 +
3 files changed, 12 insertions(+), 8 deletions(-)
@@ -43350,7 +42859,7 @@
Date: Fri Oct 13 10:21:07 2017 +0200
[coretext] Pass correct font size to CoreText
-
+
CoreText "point"s are not typographic points, but CSS pixels. Ie.
they are 96 per inch, not 72 per inch.
@@ -43369,14 +42878,12 @@
Date: Thu Oct 12 14:07:37 2017 +0200
[indic] Special-case Kannada Ra,H,ZWJ sequence
-
+
Fixes https://github.com/behdad/harfbuzz/issues/435
- src/hb-ot-shape-complex-indic.cc | 15
- +++++++++++++++
+ src/hb-ot-shape-complex-indic.cc | 15 +++++++++++++++
test/shaping/Makefile.am | 1 +
- .../sha1sum/3cae6bfe5b57c07ba81ddbd54c02fe4f3a1e3bf6.ttf | Bin 0 ->
- 2984 bytes
+ .../sha1sum/3cae6bfe5b57c07ba81ddbd54c02fe4f3a1e3bf6.ttf | Bin 0 -> 2984 bytes
test/shaping/tests/indic-special-cases.tests | 3 +++
4 files changed, 19 insertions(+)
@@ -43384,15 +42891,12 @@
Author: n8willis <n8willis at users.noreply.github.com>
Date: Thu Oct 12 12:48:48 2017 +0100
- Replacing 'cluster' with 'syllable' when comments describe certain
- Indic shaping behavior (#563)
+ Replacing 'cluster' with 'syllable' when comments describe certain Indic shaping behavior (#563)
+
+ * Clarified wording of syllable/cluster behavior in Uniscribe in final_reordering; changed one other probable typo.
+
+ * Additional syllable/cluster swap in comments for final reordering and for initial-reordering matra decomposition.
- * Clarified wording of syllable/cluster behavior in Uniscribe in
- final_reordering; changed one other probable typo.
-
- * Additional syllable/cluster swap in comments for final reordering
- and for initial-reordering matra decomposition.
-
src/hb-ot-shape-complex-indic.cc | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
@@ -43419,7 +42923,7 @@
Date: Thu Oct 12 11:49:37 2017 +0200
[coretext] Activate tracking for system fonts
-
+
Another attempt at fully fixing
https://github.com/behdad/harfbuzz/issues/360
@@ -43431,13 +42935,11 @@
Date: Thu Oct 12 12:05:08 2017 +0300
CMakelists.txt fix for Freetype builds (#564)
-
- Instead of searching for freetype using pkg-config, use the
- FindFreetype
- feature of CMake. This allows for better integration with other
- projects
+
+ Instead of searching for freetype using pkg-config, use the FindFreetype
+ feature of CMake. This allows for better integration with other projects
that make use of CMake.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/518
CMakeLists.txt | 24 +++++++-----------------
@@ -43448,9 +42950,9 @@
Date: Thu Oct 12 10:46:09 2017 +0200
[coretext] Use fabsf() instead of abs()
-
+
Fixes bots.
-
+
Link libharfbuzz.so with -lm. Surprising that we survived without
it so far!
@@ -43473,8 +42975,7 @@
win32/Makefile.vc | 67 ------------
win32/README.txt | 97 -----------------
win32/build-rules-msvc.mak | 130 -----------------------
- win32/config-msvc.mak | 230
- ----------------------------------------
+ win32/config-msvc.mak | 230 ----------------------------------------
win32/config.h.win32.in | 158 ---------------------------
win32/create-lists-msvc.mak | 147 -------------------------
win32/create-lists.bat | 42 --------
@@ -43495,15 +42996,13 @@
Date: Thu Oct 12 10:33:16 2017 +0200
[ft] Add hb_ft_font_changed()
-
- When the font size or variations settings on underlying FT_Face
- change,
- one can call hb_ft_font_changed() and continue using hb_font
- created using
+
+ When the font size or variations settings on underlying FT_Face change,
+ one can call hb_ft_font_changed() and continue using hb_font created using
hb_ft_font_create().
-
+
Fixes https://github.com/behdad/harfbuzz/issues/559
-
+
New API:
hb_ft_font_changed()
@@ -43517,10 +43016,10 @@
Date: Wed Oct 11 17:22:44 2017 +0200
Add hb_face_get_table_tags()
-
+
New API:
hb_face_get_table_tags()
-
+
Fixes https://github.com/behdad/harfbuzz/issues/560
src/hb-face.cc | 29 +++++++++++++++++++++++++++++
@@ -43533,7 +43032,7 @@
Date: Wed Oct 11 15:51:31 2017 +0200
Remove cast of functions to (hb_destroy_func_t)
-
+
Fixes https://github.com/behdad/harfbuzz/issues/474
src/hb-blob.cc | 8 +++++++-
@@ -43595,7 +43094,7 @@
Date: Wed Oct 11 15:02:48 2017 +0200
[coretext-aat] Also pass through CoreText if font has kerx table
-
+
SFNSText has kerx table which apparently is applied.
src/hb-coretext.cc | 20 +++++++++-----------
@@ -43617,7 +43116,7 @@
Date: Wed Oct 11 13:35:32 2017 +0200
Merge branch 'coretext-optical-sizing'
-
+
Should fix https://github.com/behdad/harfbuzz/issues/360
commit a5ebe1d4aec41bc5e289a7969e5e5f7bb57733b6
@@ -43625,7 +43124,7 @@
Date: Wed Oct 11 13:32:38 2017 +0200
[coretext] Recreate CTFont if pt size changed
-
+
Attempt at fixing #360
src/hb-coretext.cc | 5 +++--
@@ -43654,13 +43153,12 @@
Date: Wed Oct 11 13:05:59 2017 +0200
[coretext] Move CT_Font to font data
-
+
Towards implementing optical sizing. Untested; won't compile.
-
+
https://github.com/behdad/harfbuzz/issues/360
- src/hb-coretext.cc | 85
- ++++++++++++++++++++++++------------------------------
+ src/hb-coretext.cc | 85 ++++++++++++++++++++++++------------------------------
1 file changed, 37 insertions(+), 48 deletions(-)
commit f9b4c6570a4725eec5393f86e6468a189ac8c6be
@@ -43677,7 +43175,7 @@
Date: Wed Oct 11 12:43:46 2017 +0200
Infrastructure for creating CTFont with correct font size
-
+
https://github.com/behdad/harfbuzz/issues/360
src/hb-shaper-private.hh | 12 ++++++++++++
@@ -43697,10 +43195,10 @@
Date: Wed Oct 11 12:23:35 2017 +0200
Remove dirty tracking
-
+
Turns out I don't need this to resolve CoreText optical sizing
issue after all.
-
+
https://github.com/behdad/harfbuzz/issues/360
src/hb-face-private.hh | 9 ---------
@@ -43714,11 +43212,11 @@
Date: Wed Oct 11 11:47:47 2017 +0200
Add hb_font_[sg]et_ptem() to set/get point size on font
-
+
New API:
hb_font_set_ptem()
hb_font_get_ptem()
-
+
Needed for hb-coretext optical sizing:
https://github.com/behdad/harfbuzz/issues/360
@@ -43751,7 +43249,7 @@
Date: Sat Oct 7 12:56:53 2017 +0200
Add check for HB_EXTERNs
-
+
https://github.com/behdad/harfbuzz/pull/555
src/Makefile.am | 1 +
@@ -43762,41 +43260,33 @@
Author: fanc999 <fanc999 at yahoo.com.tw>
Date: Sat Oct 7 18:57:14 2017 +0800
- Fix build of HarfBuzz tools and HarfBuzz-GObject on Visual Studio
- (#555)
-
+ Fix build of HarfBuzz tools and HarfBuzz-GObject on Visual Studio (#555)
+
* hb-buffer.h: Mark hb_buffer_diff() for export
-
+
This will fix the tools builds on Visual Studio, as the symbol is used
by the tools.
-
+
* build: Adapt NMake Makefiles for GLib 2.53.4 or later
-
+
glib-mkenums was ported from a PERL script to a Python script, so we
- need to update how we generate the enum sources for HarfBuzz-GObject
- in
- the NMake builds. Let this be known in the build documentation
- for MSVC
+ need to update how we generate the enum sources for HarfBuzz-GObject in
+ the NMake builds. Let this be known in the build documentation for MSVC
builds.
-
- One of the problems with the underlying cmd.exe that the NMake
- Makefiles
+
+ One of the problems with the underlying cmd.exe that the NMake Makefiles
run on is that shebang lines are not recognized, so we need to to test
run the script with Python and see whether it succeeded by outputing a
source file that is larger than 0 in file size (since running the PERL
version of the script will clearly fail and cause an empty file to be
created).
-
- If it succeeds, we then run a small Python utility script that
- makes the
- necessary string replacements, and we are done. If that fails,
- then we
- run the glib-mkenums script with PERL, and do the replacements
- with the
+
+ If it succeeds, we then run a small Python utility script that makes the
+ necessary string replacements, and we are done. If that fails, then we
+ run the glib-mkenums script with PERL, and do the replacements with the
PERL one-liners as we did before.
-
- We need to make replace.py use latin-1 encoding when using Python
- 3.x to
+
+ We need to make replace.py use latin-1 encoding when using Python 3.x to
cope with the copyright sign that is in the generated enum sources.
src/hb-buffer.h | 2 +-
@@ -43813,7 +43303,7 @@
Date: Wed Oct 4 16:59:22 2017 +0200
[ot] Remove 'mal' and 'gle' lang tags
-
+
Fixes https://github.com/behdad/harfbuzz/issues/477
src/hb-ot-tag.cc | 2 --
@@ -43824,13 +43314,11 @@
Date: Wed Oct 4 15:06:48 2017 +0200
Improve performance of ligature component matching
-
- This O(N^2) was introduced in
- 8b2c94c43fd335b944d5e5487265706b8e0f9041.
+
+ This O(N^2) was introduced in 8b2c94c43fd335b944d5e5487265706b8e0f9041.
Make it O(N).
- src/hb-ot-layout-gsubgpos-private.hh | 37
- +++++++++++++++++++++++-------------
+ src/hb-ot-layout-gsubgpos-private.hh | 37 +++++++++++++++++++++++-------------
1 file changed, 24 insertions(+), 13 deletions(-)
commit ab8d70ec7023e51ba6fd7267d2b41c5f95ef0787
@@ -43838,11 +43326,10 @@
Date: Wed Oct 4 14:47:10 2017 +0200
[arabic] Implement Unicode Arabic Mark Ordering Algorithm UTR#53
-
+
Fixes https://github.com/behdad/harfbuzz/issues/509
- src/hb-ot-shape-complex-arabic.cc | 75
- +++++++++++++++++++++
+ src/hb-ot-shape-complex-arabic.cc | 75 +++++++++++++++++++++
src/hb-ot-shape-complex-default.cc | 1 +
src/hb-ot-shape-complex-hangul.cc | 1 +
src/hb-ot-shape-complex-hebrew.cc | 1 +
@@ -43875,17 +43362,16 @@
Date: Wed Oct 4 13:20:33 2017 +0200
Adjust normalizer for out-of-order marks
-
+
We are going to implement Unicode Arabic Mark Ordering Algorithm:
-
+
http://www.unicode.org/reports/tr53/tr53-1.pdf
-
+
which will reorder marks out of their sorted ccc order. Adjust
normalizer to stop combining as soon as dangerous ordering is
detected.
- src/hb-ot-shape-normalize.cc | 62
- ++++++++++++++++++++++++++------------------
+ src/hb-ot-shape-normalize.cc | 62 ++++++++++++++++++++++++++------------------
1 file changed, 37 insertions(+), 25 deletions(-)
commit a252ad61f077c3b7bbfd8335e1b105a57beb58ce
@@ -43902,9 +43388,9 @@
Date: Wed Oct 4 13:06:51 2017 +0200
Revert "Treat HAMZA ABOVE similar to SHADD for sorting purposes"
-
+
This reverts commit 5a330575768f5a213072230b9ec8faabac9c5737.
-
+
Proper fix coming soon.
src/hb-unicode-private.hh | 4 ----
@@ -43915,7 +43401,7 @@
Date: Wed Oct 4 11:33:47 2017 +0200
Shorthand format controls should not be ignored
-
+
Fixes https://github.com/behdad/harfbuzz/issues/503
src/hb-unicode-private.hh | 4 ++--
@@ -43926,7 +43412,7 @@
Date: Wed Oct 4 11:28:04 2017 +0200
Add Chinantec language tags
-
+
Fixes https://github.com/behdad/harfbuzz/issues/516
src/hb-ot-tag.cc | 14 ++++++++++++++
@@ -43937,11 +43423,10 @@
Date: Tue Oct 3 17:22:43 2017 +0200
Fix GPOS v_origin ordering
-
- This should affect mark attachment in vertical text. I have no font
- to test,
+
+ This should affect mark attachment in vertical text. I have no font to test,
but this sounds the right order.
-
+
Noticed while debugging https://github.com/behdad/harfbuzz/issues/532
src/hb-ot-shape.cc | 44 ++++++++++++++++++++------------------------
@@ -43952,7 +43437,7 @@
Date: Tue Oct 3 16:00:18 2017 +0200
[indic] Fix shaping of U+0AFB GUJARATI SIGN SHADDA
-
+
Fixes https://github.com/behdad/harfbuzz/issues/552
src/hb-ot-shape-complex-indic-private.hh | 2 +-
@@ -43964,7 +43449,7 @@
Date: Tue Oct 3 15:20:07 2017 +0200
[indic] Implement Consonent_With_Stacker
-
+
Fixes https://github.com/behdad/harfbuzz/issues/528
src/hb-ot-shape-complex-indic-machine.rl | 5 +++--
@@ -43978,7 +43463,7 @@
Date: Tue Oct 3 14:57:14 2017 +0200
[use] Implement Consonant_With_Stacker
-
+
Related to https://github.com/behdad/harfbuzz/issues/528
src/gen-use-table.py | 7 ++++---
@@ -43994,8 +43479,7 @@
Test Consonant_With_Stacker in Kannada (#530)
test/shaping/Makefile.am | 1 +
- test/shaping/fonts/COPYING | 100
- +++++++++++++++++++++
+ test/shaping/fonts/COPYING | 100 +++++++++++++++++++++
.../341421e629668b1a1242245d39238ca48432d35d.ttf | Bin 0 -> 1084 bytes
.../55c88ebbe938680b08f92c3de20713183e0c7481.ttf | Bin 0 -> 3300 bytes
.../663aef6b019dbf45ffd74089e2b5f2496ceceb18.ttf | Bin 0 -> 1204 bytes
@@ -44008,18 +43492,17 @@
Date: Tue Oct 3 13:46:25 2017 +0200
Tweak mark-base attachment
-
+
Apparently a base glyph can also become an attached component of a
ligature if the ligature-forming lookup used IgnoreBase. This was
being confused with a non-first component of a MultipleSubst and
hence not matched for mark-attachment. Tweak test to fix.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/543
src/hb-ot-layout-gpos-table.hh | 4 +++-
test/shaping/Makefile.am | 1 +
- .../sha1sum/98b7887cff91f722b92a8ff800120954606354f9.ttf | Bin 0 ->
- 1168 bytes
+ .../sha1sum/98b7887cff91f722b92a8ff800120954606354f9.ttf | Bin 0 -> 1168 bytes
test/shaping/tests/mark-attachment.tests | 1 +
4 files changed, 5 insertions(+), 1 deletion(-)
@@ -44045,7 +43528,7 @@
Date: Tue Oct 3 13:22:07 2017 +0200
Make bots happy
-
+
Fixes https://github.com/behdad/harfbuzz/issues/551
test/shaping/tests/indic-syllable.tests | 2 +-
@@ -44056,9 +43539,9 @@
Date: Tue Oct 3 13:14:17 2017 +0200
Tweak input matching some more
-
+
Followup to 8b2c94c43fd335b944d5e5487265706b8e0f9041
-
+
Allow matching sequences of marks attached to different ligatures,
as supposedly the base of the subsequent marks were already jumped
over.
@@ -44081,9 +43564,9 @@
Date: Mon Oct 2 20:28:56 2017 +0200
Add test for U+0A51
-
+
New Indic numbers are:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
@@ -44090,21 +43573,17 @@
GURMUKHI: 60729 out of 60747 tests passed. 18 failed (0.0296311%)
KANNADA: 951201 out of 951913 tests passed. 712 failed (0.0747968%)
KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
-
- Before 71c0a1429db7c7e7e32507be248c9457e1cbfc7d GURMUKHI used to be
- at 15,
- because Uniscribe seems to allow this character standalone, but
- that looks
+
+ Before 71c0a1429db7c7e7e32507be248c9457e1cbfc7d GURMUKHI used to be at 15,
+ because Uniscribe seems to allow this character standalone, but that looks
wrong.
- .../sha1sum/1735326da89f0818cd8c51a0600e9789812c0f94.ttf | Bin 0 ->
- 1008 bytes
+ .../sha1sum/1735326da89f0818cd8c51a0600e9789812c0f94.ttf | Bin 0 -> 1008 bytes
test/shaping/tests/indic-syllable.tests | 2 ++
2 files changed, 2 insertions(+)
@@ -44113,23 +43592,20 @@
Date: Mon Oct 2 20:02:45 2017 +0200
Tweak ligature component matching for ligature formation
-
- If two marks want to ligate and they belong to different components
- of the
- same ligature glyph, and said ligature glyph is to be ignored
- according to
+
+ If two marks want to ligate and they belong to different components of the
+ same ligature glyph, and said ligature glyph is to be ignored according to
mark-filtering rules, then allow.
-
+
Example Burmese senquence:
-
+
U+1004,U+103A,U+1039,U+101B,U+103D,U+102D
-
+
Test font provided by Norbert Lindenberg.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/545
- src/hb-ot-layout-gsubgpos-private.hh | 59
- +++++++++++++++++----
+ src/hb-ot-layout-gsubgpos-private.hh | 59 +++++++++++++++++----
.../a6c76d1bafde4a0b1026ebcc932d2e5c6fd02442.ttf | Bin 0 -> 1384 bytes
test/shaping/tests/ligature-id.tests | 1 +
3 files changed, 51 insertions(+), 9 deletions(-)
@@ -44139,15 +43615,14 @@
Date: Mon Oct 2 18:56:10 2017 +0200
[indic] Fix shaping of U+0A51
-
+
Mark it as matra below to allow the sequence U+0A15, U+0A51, U+0A47.
Oh well...
-
+
Fixes https://github.com/behdad/harfbuzz/issues/524
src/hb-ot-shape-complex-indic.cc | 6 ++++++
- .../sha1sum/85fe0be440c64ac77699e21c2f1bd933a919167e.ttf | Bin 0 ->
- 1224 bytes
+ .../sha1sum/85fe0be440c64ac77699e21c2f1bd933a919167e.ttf | Bin 0 -> 1224 bytes
test/shaping/tests/indic-syllable.tests | 1 +
3 files changed, 7 insertions(+)
@@ -44157,8 +43632,7 @@
[ucdn] Oops!
- src/hb-ucdn/{unicodedata_db.h => ucdn_db.h} | 4324
- ++++++++++++++-------------
+ src/hb-ucdn/{unicodedata_db.h => ucdn_db.h} | 4324 ++++++++++++++-------------
1 file changed, 2175 insertions(+), 2149 deletions(-)
commit cbec0cd65e1787b20ea55dd5583a7444938bd381
@@ -44194,7 +43668,7 @@
Date: Mon Oct 2 18:20:51 2017 +0200
[use] Hack to fix shaping of U+1A7F
-
+
Fixes https://github.com/behdad/harfbuzz/issues/525
src/gen-use-table.py | 3 +++
@@ -44206,14 +43680,13 @@
Date: Mon Oct 2 17:15:46 2017 +0200
[ucdn] Update to Unicode 10
-
+
Update to commit c000ebf79c095a7d58cf90090bde5715592c4834
plus this bug-fix: https://github.com/grigorig/ucdn/issues/18
src/hb-ucdn.cc | 4 +++
src/hb-ucdn/Makefile.sources | 2 +-
- src/hb-ucdn/ucdn.c | 69
- ++++++++++++++++++++++----------------------
+ src/hb-ucdn/ucdn.c | 69 ++++++++++++++++++++++----------------------
src/hb-ucdn/ucdn.h | 7 +++++
4 files changed, 47 insertions(+), 35 deletions(-)
@@ -44224,8 +43697,7 @@
[use] Update to Unicode 10
src/gen-use-table.py | 5 +--
- src/hb-ot-shape-complex-use-table.cc | 69
- ++++++++++++++++++++++++++----------
+ src/hb-ot-shape-complex-use-table.cc | 69 ++++++++++++++++++++++++++----------
2 files changed, 54 insertions(+), 20 deletions(-)
commit 29c244aff6e3c359796bb033496c14ad5537dbe0
@@ -44253,8 +43725,7 @@
[indic] Update table to Unicode 10
- src/hb-ot-shape-complex-indic-table.cc | 70
- +++++++++++++++++-----------------
+ src/hb-ot-shape-complex-indic-table.cc | 70 +++++++++++++++++-----------------
1 file changed, 36 insertions(+), 34 deletions(-)
commit cc79b666bc4a81a0342ed1e706dd7db109739dc5
@@ -44262,11 +43733,10 @@
Date: Mon Oct 2 09:19:15 2017 -0400
[indic] Add test for 1a0a356a0f2b2932581e4fd0437c01c058f4f6d1
-
+
https://github.com/behdad/harfbuzz/issues/538
- .../sha1sum/87f85d17d26f1fe9ad28d7365101958edaefb967.ttf | Bin 0 ->
- 1000 bytes
+ .../sha1sum/87f85d17d26f1fe9ad28d7365101958edaefb967.ttf | Bin 0 -> 1000 bytes
test/shaping/tests/indic-syllable.tests | 1 +
2 files changed, 1 insertion(+)
@@ -44294,7 +43764,7 @@
Date: Mon Oct 2 08:49:23 2017 -0400
[indic] Categorize U+0980 BENGALI ANJI as placeholder
-
+
Fixes https://github.com/behdad/harfbuzz/issues/538
src/hb-ot-shape-complex-indic.cc | 1 +
@@ -44304,11 +43774,9 @@
Author: jfkthame <jfkthame at gmail.com>
Date: Mon Oct 2 13:08:49 2017 +0100
- [shape-plan] Don't look for a cached plan if variation coords are
- specified. Fixes #549. (#550)
-
- This is a temporary hack just to avoid incorrect shaping results,
- pending proper support
+ [shape-plan] Don't look for a cached plan if variation coords are specified. Fixes #549. (#550)
+
+ This is a temporary hack just to avoid incorrect shaping results, pending proper support
for caching shape-plans with variation coordinates.
src/hb-shape-plan.cc | 16 +++++++++-------
@@ -44329,8 +43797,7 @@
Add release checklist (#529)
- RELEASING.md | 96
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ RELEASING.md | 96 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 96 insertions(+)
commit 66128d3cfb12705530141b5a4bd2706f0cbb9fc5
@@ -44338,9 +43805,9 @@
Date: Wed Sep 27 01:29:45 2017 +0700
Fix missing xscale in rtl graphite unpacking (#541)
-
+
* Fix missing xscale in rtl graphite unpacking
-
+
* Oops didn't need to mess with yscale
src/hb-graphite2.cc | 2 +-
@@ -44350,16 +43817,13 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Sep 14 20:50:35 2017 -0400
- Use strtod_l() to correctly parse decimal numbers in French &
- other locales
-
+ Use strtod_l() to correctly parse decimal numbers in French & other locales
+
Test with, eg.:
- $ LC_ALL=fr_FR.utf-8 ./hb-view NotoSansArabic-VF.ttf بهداد
- --variations wght=1.2
+ $ LC_ALL=fr_FR.utf-8 ./hb-view NotoSansArabic-VF.ttf بهداد --variations wght=1.2
configure.ac | 4 ++--
- src/hb-common.cc | 53
- +++++++++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-common.cc | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++--
2 files changed, 53 insertions(+), 4 deletions(-)
commit 9355218f582a6c2425cadcb868204f81b17d5767
@@ -44367,7 +43831,7 @@
Date: Sat Sep 9 11:21:07 2017 -0700
[util] Add a few shorthand forms for commandline options
-
+
-o, -O, -u, -v, -V
util/options.cc | 10 +++++-----
@@ -44388,9 +43852,9 @@
Date: Mon Sep 4 20:14:13 2017 -0700
Fix buffer_diff for empty buffers
-
+
If buffers are empty, content type should be ignored.
-
+
This fixes last of the failing tests: fuzzed.tests. Green again!
src/hb-buffer.cc | 2 +-
@@ -44403,7 +43867,7 @@
Date: Mon Sep 4 20:04:59 2017 -0700
[unsafe-to-break] Fix unsafe-to-break for cluster-level=1
-
+
Fixes tests/shaping/tests/cluster.tests
src/hb-ot-shape.cc | 17 +++++++++++------
@@ -44423,12 +43887,11 @@
Date: Fri Sep 1 19:09:54 2017 -0700
[util] Add --unicodes to hb-view / hb-shape
-
+
Fixes https://github.com/behdad/harfbuzz/issues/154
test/shaping/hb_test_tools.py | 2 +-
- util/options.cc | 65
- ++++++++++++++++++++++++++++++++++++++++++-
+ util/options.cc | 65 ++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 65 insertions(+), 2 deletions(-)
commit 0e5b475d98dd67e927534508fe2cd8dc9765e24e
@@ -44463,13 +43926,12 @@
Date: Fri Sep 1 10:34:21 2017 -0700
[indic] Treat Consonant_With_Stacker as consonant
-
+
Fixes https://github.com/behdad/harfbuzz/issues/528
"Kannada JIHVAMULIYA and UPADHMANIYA insert dotted circles"
src/hb-ot-shape-complex-indic-private.hh | 2 +-
- .../sha1sum/3d0b77a2360aa6faa1385aaa510509ab70dfbeff.ttf | Bin 0 ->
- 988 bytes
+ .../sha1sum/3d0b77a2360aa6faa1385aaa510509ab70dfbeff.ttf | Bin 0 -> 988 bytes
test/shaping/tests/indic-syllable.tests | 3 ++-
3 files changed, 3 insertions(+), 2 deletions(-)
@@ -44478,7 +43940,7 @@
Date: Wed Aug 30 17:28:22 2017 -0700
[unsafe-to-break] Mark during fraction-slash formation
-
+
Fixes tests/automatic-fractions.tests
src/hb-ot-shape.cc | 2 ++
@@ -44489,11 +43951,10 @@
Date: Wed Aug 30 17:25:10 2017 -0700
[util] Fix cluster sweeping during --verify
-
- If *I* get this wrong in 2017, I have no idea how others get their
- head around
+
+ If *I* get this wrong in 2017, I have no idea how others get their head around
cluster math...
-
+
Fixes tests/arabic-fallback-shaping.tests
util/options.hh | 11 ++++++++---
@@ -44514,11 +43975,9 @@
Date: Wed Aug 30 16:45:06 2017 -0700
hb_buffer_diff() tweak
-
- I like to have a mode where CONTAINS_NOTDEF and CONTAINS_DOTTEDCIRCLE
- are not
- returned. Abused a value of -1 for that. hb-shape now uses it.
- Fixes two
+
+ I like to have a mode where CONTAINS_NOTDEF and CONTAINS_DOTTEDCIRCLE are not
+ returned. Abused a value of -1 for that. hb-shape now uses it. Fixes two
of the six tests failing with --verify in test/shaping/run-tests.sh.
src/hb-buffer.cc | 16 ++++++++--------
@@ -44552,7 +44011,7 @@
Date: Wed Aug 23 14:35:58 2017 -0700
[test] Add --verify to hb-shape
-
+
Disabled for now. Will enable and fix failures after next release.
test/shaping/run-tests.sh | 3 ++-
@@ -44563,7 +44022,7 @@
Date: Wed Aug 23 13:12:54 2017 -0700
Add hb_glyph_info_get_glyph_flags()
-
+
New API.
src/hb-buffer.cc | 17 +++++++++++++++++
@@ -44574,8 +44033,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue Aug 22 17:56:25 2017 -0700
- Rename HB_BUFFER_DIFF_FLAG_MASK_MISMATCH to
- HB_BUFFER_DIFF_FLAG_GLYPH_FLAGS_MISMATCH
+ Rename HB_BUFFER_DIFF_FLAG_MASK_MISMATCH to HB_BUFFER_DIFF_FLAG_GLYPH_FLAGS_MISMATCH
src/hb-buffer.cc | 2 +-
src/hb-buffer.h | 2 +-
@@ -44615,11 +44073,9 @@
Date: Tue Aug 15 16:25:18 2017 -0700
Fix signed/unsigned warning (#522)
-
- Change hb_buffer_diff to explicitly cast result of abs to unsigned
- when
- comparing with position_fuzz to avoid unsafe signed/unsigned
- comparions
+
+ Change hb_buffer_diff to explicitly cast result of abs to unsigned when
+ comparing with position_fuzz to avoid unsafe signed/unsigned comparions
warnings on windows.
src/hb-buffer.cc | 8 ++++----
@@ -44660,11 +44116,11 @@
Date: Sat Jul 19 23:09:09 2014 +0100
Add function to compare two buffers
-
+
Based on patch from Jonathan Kew.
-
+
Needs more cleaning up and documentation.
-
+
New API:
hb_buffer_diff_flags_t
hb_buffer_diff()
@@ -44671,8 +44127,7 @@
src/hb-buffer-private.hh | 1 +
src/hb-buffer-serialize.cc | 4 +--
- src/hb-buffer.cc | 82
- ++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-buffer.cc | 82 ++++++++++++++++++++++++++++++++++++++++++++++
src/hb-buffer.h | 39 ++++++++++++++++++++++
4 files changed, 124 insertions(+), 2 deletions(-)
@@ -44702,14 +44157,13 @@
Date: Fri Aug 11 19:51:06 2017 -0700
[unsafe-to-break] Towards verifying unsafe-to-break in --verify
-
+
We break and shape fragments and reconstruct shape result from them.
Remains to compare to original buffer. Going to add some buffer
comparison API and use here, instead of open-coding.
src/hb-buffer.cc | 5 ++-
- util/options.hh | 131
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
+ util/options.hh | 131 ++++++++++++++++++++++++++++++++++++++++++++++++++++++-
2 files changed, 133 insertions(+), 3 deletions(-)
commit 6ce25f57c663f86326262a5ff7a42288f358ed51
@@ -44717,7 +44171,7 @@
Date: Fri Aug 11 19:31:05 2017 -0700
Fix hb_buffer_append()
-
+
Ouch!
src/hb-buffer.cc | 2 +-
@@ -44728,11 +44182,10 @@
Date: Fri Aug 11 19:06:07 2017 -0700
[unsafe-to-break] Copy flag to all glyphs in a cluster
-
+
Makes consumption easier.
- src/hb-buffer-private.hh | 46
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-buffer-private.hh | 46 +++++++++++++++++++++++++++++++++++++++++++++
src/hb-buffer.cc | 28 ++++++---------------------
src/hb-ot-layout-private.hh | 3 +--
src/hb-ot-shape.cc | 27 ++++++++++++++++++++++++++
@@ -44743,9 +44196,8 @@
Date: Fri Aug 11 18:24:27 2017 -0700
[unsafe-to-break] Mark unsafe is cluster merging is disabled
-
- We were relying on cluster merges not requiring unsafe flagging
- because
+
+ We were relying on cluster merges not requiring unsafe flagging because
they get merged. If cluster level requests no merging, then we flag
unsafe when merge would have happened.
@@ -44758,8 +44210,7 @@
New API: hb_buffer_append()
- src/hb-buffer.cc | 52
- +++++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-buffer.cc | 52 +++++++++++++++++++++++++++++++++++++++++++++++++++-
src/hb-buffer.h | 6 ++++++
2 files changed, 57 insertions(+), 1 deletion(-)
@@ -44768,10 +44219,9 @@
Date: Fri Aug 11 15:12:25 2017 -0700
[util] Add --verify to hb-shape / hb-view that verifies shape results
+
+ Right now it checks for monotone cluster values. Other checks to be added.
- Right now it checks for monotone cluster values. Other checks to
- be added.
-
util/hb-shape.cc | 7 ++-----
util/options.cc | 2 ++
util/options.hh | 42 +++++++++++++++++++++++++++++++++++++++---
@@ -44783,9 +44233,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Aug 11 11:30:39 2017 -0700
- [unsafe-to-break] Fix Use-of-uninitialized-value in
- unsafe_to_break_set_mask
-
+ [unsafe-to-break] Fix Use-of-uninitialized-value in unsafe_to_break_set_mask
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=3011
src/hb-ot-shape-complex-hangul.cc | 2 +-
@@ -44858,8 +44307,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Aug 10 20:10:12 2017 -0700
- [unsafe-to-break] Be careful with flag propagation when merging
- clusters
+ [unsafe-to-break] Be careful with flag propagation when merging clusters
src/hb-buffer-private.hh | 13 +++++++++++++
src/hb-buffer.cc | 17 ++++++++++-------
@@ -44871,7 +44319,7 @@
Date: Thu Aug 10 19:58:05 2017 -0700
Set mask to 0, instead of 1, by default
-
+
This shouldn't matter.
src/hb-buffer.cc | 2 +-
@@ -44912,11 +44360,10 @@
Date: Wed May 4 19:51:22 2016 +0200
[unsafe-to-break] Simplify logic
-
+
Always use the algorithm for non-monotone case. It's more robust.
- src/hb-buffer.cc | 57
- +++++++++++++-------------------------------------------
+ src/hb-buffer.cc | 57 +++++++++++++-------------------------------------------
1 file changed, 13 insertions(+), 44 deletions(-)
commit 40bd7e9a1cf422b17f15d0f66547bde9098e6ef3
@@ -44924,17 +44371,16 @@
Date: Mon May 2 14:47:45 2016 +0200
[unsafe-to-break] Add UNSAFE_TO_BREAK flag
-
+
Not all shapers code is updated to set this properly.
GSUB and Arabic shaper are updated.
GPOS and other shapers are NOT.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/224
src/hb-buffer-private.hh | 26 ++++++++------
src/hb-buffer-serialize.cc | 24 +++++++++----
- src/hb-buffer.cc | 67
- ++++++++++++++++++++++++++++++++++++
+ src/hb-buffer.cc | 67 ++++++++++++++++++++++++++++++++++++
src/hb-buffer.h | 10 ++++--
src/hb-ot-layout-gsub-table.hh | 7 ++--
src/hb-ot-layout-gsubgpos-private.hh | 27 ++++++++++-----
@@ -44977,7 +44423,7 @@
Date: Wed Aug 9 17:23:28 2017 -0700
Treat HAMZA ABOVE similar to SHADD for sorting purposes
-
+
Part of https://github.com/behdad/harfbuzz/issues/509
src/hb-unicode-private.hh | 4 ++++
@@ -44988,9 +44434,9 @@
Date: Wed Aug 9 17:09:21 2017 -0700
Protect against div-by-zero in CBDT extent code
-
+
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=1452#c5
-
+
CC https://github.com/behdad/harfbuzz/issues/139
src/hb-ft.cc | 4 ++--
@@ -45007,8 +44453,7 @@
test/shaping/Makefile.am | 1 +
.../d23d76ea0909c14972796937ba072b5a40c1e257.ttf | Bin 0 -> 1812 bytes
test/shaping/record-test.sh | 1 +
- test/shaping/tests/variations-rvrn.tests | 100
- +++++++++++++++++++++
+ test/shaping/tests/variations-rvrn.tests | 100 +++++++++++++++++++++
4 files changed, 102 insertions(+)
commit 7917792f01603f91b703d12e12d8baced655a615
@@ -45026,11 +44471,11 @@
Date: Mon Aug 7 21:37:07 2017 -0700
Two fixes to avar mapping
-
+
1. Handle segment with two entries correctly,
-
+
2. Fix rounding math. Ouch!
-
+
Fixes https://github.com/behdad/harfbuzz/issues/521
src/hb-ot-var-avar-table.hh | 13 +++++++++----
@@ -45041,7 +44486,7 @@
Date: Thu Aug 3 12:34:15 2017 +0100
[check-defs/symbols.sh] Drop empty-symbol lines
-
+
Fixes https://github.com/behdad/harfbuzz/issues/510
src/check-defs.sh | 2 +-
@@ -45053,7 +44498,7 @@
Date: Wed Jul 19 17:20:55 2017 -0700
[hb-shape] Rename --show-messages to --trace
-
+
https://github.com/behdad/harfbuzz/issues/506
util/hb-shape.cc | 2 +-
@@ -45066,17 +44511,13 @@
Date: Tue Jul 18 19:14:19 2017 -0700
[hb-shape] Improve shaping-debug output
-
- Before, that was printed using --debug (and in both hb-shape and
- hb-view).
- Changed it, now hb-shape has a new command-line argument called
- --show-messages.
- When invoked, it also respects other output formatting options.
- The messages
- are better formatted and printed to te same place that hb-shape
- output is
+
+ Before, that was printed using --debug (and in both hb-shape and hb-view).
+ Changed it, now hb-shape has a new command-line argument called --show-messages.
+ When invoked, it also respects other output formatting options. The messages
+ are better formatted and printed to te same place that hb-shape output is
directed to. Previously they were written to stderr.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/506
util/hb-ot-shape-closure.cc | 10 +++++++---
@@ -45112,12 +44553,11 @@
Date: Fri Jul 14 17:34:47 2017 +0100
[arabic] Adjust feature order again
-
+
Fixes https://github.com/behdad/harfbuzz/issues/505
src/hb-ot-shape-complex-arabic.cc | 7 ++++++-
- .../sha1sum/bf39b0e91ef9807f15a9e283a21a14a209fd2cfc.ttf | Bin 0 ->
- 7312 bytes
+ .../sha1sum/bf39b0e91ef9807f15a9e283a21a14a209fd2cfc.ttf | Bin 0 -> 7312 bytes
test/shaping/tests/arabic-feature-order.tests | 1 +
3 files changed, 7 insertions(+), 1 deletion(-)
@@ -45126,16 +44566,15 @@
Date: Fri Jul 14 17:11:46 2017 +0100
[coretext] Allow to disable kern (#508)
-
+
* Minor
-
+
* [coretext] Fix leak
-
+
* [coretext] Do not reset num_features
+
+ * [coretext] allow to disable kern; re-enabling doesn't seem to be working
- * [coretext] allow to disable kern; re-enabling doesn't seem to
- be working
-
src/hb-coretext.cc | 41 ++++++++++++++++++++++++++++++++---------
1 file changed, 32 insertions(+), 9 deletions(-)
@@ -45144,12 +44583,11 @@
Date: Fri Jul 14 17:01:27 2017 +0100
[use] Allow up to two medial-below letters
-
+
Fixes https://github.com/behdad/harfbuzz/issues/376
src/hb-ot-shape-complex-use-machine.rl | 3 ++-
- .../sha1sum/e68a88939e0f06e34d2bc911f09b70890289c8fd.ttf | Bin 0 ->
- 2192 bytes
+ .../sha1sum/e68a88939e0f06e34d2bc911f09b70890289c8fd.ttf | Bin 0 -> 2192 bytes
test/shaping/tests/use-syllable.tests | 3 +++
3 files changed, 5 insertions(+), 1 deletion(-)
@@ -45158,10 +44596,10 @@
Date: Fri Jul 14 16:38:51 2017 +0100
[use] Fix shaping of U+AA29 CHAM VOWEL SIGN AA
-
+
Part of https://github.com/behdad/harfbuzz/issues/376
Also see https://github.com/roozbehp/unicode-data/issues/6
-
+
Test added, using NotoSansCham built from Noto Phase III sources.
src/gen-arabic-table.py | 2 +-
@@ -45169,8 +44607,7 @@
src/gen-use-table.py | 8 +++++---
src/hb-ot-shape-complex-use-table.cc | 4 ++--
test/shaping/Makefile.am | 1 +
- .../sha1sum/96490dd2ff81233b335a650e7eb660e0e7b2eeea.ttf | Bin 0 ->
- 1368 bytes
+ .../sha1sum/96490dd2ff81233b335a650e7eb660e0e7b2eeea.ttf | Bin 0 -> 1368 bytes
test/shaping/tests/use-syllable.tests | 1 +
7 files changed, 11 insertions(+), 7 deletions(-)
@@ -45192,8 +44629,7 @@
src/hb-ot-shape-complex-indic-private.hh | 2 +-
src/hb-ot-shape-complex-indic.cc | 8 ++++++++
test/shaping/Makefile.am | 1 +
- .../sha1sum/54674a3111d209fb6be0ed31745314b7a8d2c244.ttf | Bin 0 ->
- 1352 bytes
+ .../sha1sum/54674a3111d209fb6be0ed31745314b7a8d2c244.ttf | Bin 0 -> 1352 bytes
test/shaping/tests/indic-syllable.tests | 1 +
5 files changed, 11 insertions(+), 1 deletion(-)
@@ -45202,11 +44638,11 @@
Date: Fri Jul 14 14:14:35 2017 +0100
[indic] Disable automatic ZWNJ handling for Indic features
-
+
Fixes https://github.com/behdad/harfbuzz/issues/294
-
+
Also fixes a bunch of other Indic issues. Test results after:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366355 out of 366457 tests passed. 102 failed (0.0278341%)
@@ -45213,15 +44649,14 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951201 out of 951913 tests passed. 712 failed (0.0747968%)
KHMER: 299071 out of 299124 tests passed. 53 failed (0.0177184%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091754 out of 1091754 tests passed. 0 failed (0%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
-
+
Before:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
@@ -45228,8 +44663,7 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
@@ -45237,8 +44671,7 @@
src/hb-ot-shape-complex-indic.cc | 4 ++--
test/shaping/Makefile.am | 1 +
- .../sha1sum/f443753e8ffe8e8aae606cfba158e00334b6efb1.ttf | Bin 0 ->
- 3972 bytes
+ .../sha1sum/f443753e8ffe8e8aae606cfba158e00334b6efb1.ttf | Bin 0 -> 3972 bytes
test/shaping/tests/indic-joiners.tests | 2 ++
4 files changed, 5 insertions(+), 2 deletions(-)
@@ -45246,13 +44679,11 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Jul 14 12:43:34 2017 +0100
- [indic] Add infrastructure to disable ZWNJ-skipping in
- context-matching
-
+ [indic] Add infrastructure to disable ZWNJ-skipping in context-matching
+
Not used yet.
- src/hb-ot-layout-gsubgpos-private.hh | 45
- ++++++++++++++++++++----------------
+ src/hb-ot-layout-gsubgpos-private.hh | 45 ++++++++++++++++++++----------------
src/hb-ot-layout.cc | 1 +
src/hb-ot-map-private.hh | 10 +++++---
src/hb-ot-map.cc | 8 +++++--
@@ -45263,27 +44694,21 @@
Date: Fri Jul 14 13:14:55 2017 +0200
Shaping tests for Tibetan vowels (#446)
-
+
* Shaping tests for Tibetan vowels
-
- * Test-cases for the Dzongkha contractions with multiple vowel-signs
- added.
-
+
+ * Test-cases for the Dzongkha contractions with multiple vowel-signs added.
+
* going to be removed
+
+ * Extended contraction-test-cases to all test cases in contractions.txt that actually use multiple-vowels (113 cases)
- * Extended contraction-test-cases to all test cases in
- contractions.txt that actually use multiple-vowels (113 cases)
-
test/shaping/Makefile.am | 3 ++
- .../2de1ab4907ab688c0cfc236b0bf51151db38bf2e.ttf | Bin 0 -> 125256
- bytes
+ .../2de1ab4907ab688c0cfc236b0bf51151db38bf2e.ttf | Bin 0 -> 125256 bytes
.../82f4f3b57bb55344e72e70231380202a52af5805.ttf | Bin 0 -> 11116 bytes
- .../a02a7f0ad42c2922cb37ad1358c9df4eb81f1bca.ttf | Bin 0 -> 106096
- bytes
- test/shaping/tests/tibetan-contractions-1.tests | 60
- +++++++++++++++++++++
- test/shaping/tests/tibetan-contractions-2.tests | 53
- ++++++++++++++++++
+ .../a02a7f0ad42c2922cb37ad1358c9df4eb81f1bca.ttf | Bin 0 -> 106096 bytes
+ test/shaping/tests/tibetan-contractions-1.tests | 60 +++++++++++++++++++++
+ test/shaping/tests/tibetan-contractions-2.tests | 53 ++++++++++++++++++
test/shaping/tests/tibetan-vowels.tests | 11 ++++
7 files changed, 127 insertions(+)
@@ -45292,16 +44717,15 @@
Date: Fri Jul 14 13:14:23 2017 +0200
Fix for reordering of Tibetan vowel u (#443)
-
+
* Undone change for Tibetan vowel u
-
+
* removed comment on reordering that became invalid with roll-back
-
+
* Support for Dzongkha contractions with multiple vowel-signs
+
+ * Removed non-functional and unnecessary defines for HB_MODIFIED_COMBINING_CLASS_CCC138,140
- * Removed non-functional and unnecessary defines for
- HB_MODIFIED_COMBINING_CLASS_CCC138,140
-
src/hb-unicode-private.hh | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
@@ -45310,21 +44734,17 @@
Date: Wed Jun 21 22:19:57 2017 +0800
Win32/NMake builds: Support builds from GIT (#498)
-
+
Add Python scripts to generate the full win32/config.h.win32 and
src/hb-version.h which can be used to build directly from a GIT
- checkout. Since the scripts are currently intended for building
- from a
+ checkout. Since the scripts are currently intended for building from a
GIT checkout, these are not distributed in the release tarballs.
-
- Also, support the re-build of Ragel-generated .hh headers using
- the NMake
- build system, and allow one to specify the path of the Ragel
- executable
+
+ Also, support the re-build of Ragel-generated .hh headers using the NMake
+ build system, and allow one to specify the path of the Ragel executable
if a suitable one cannot be found in the PATH.
-
- Update the Win32/NMake build documentation to let people know
- about how
+
+ Update the Win32/NMake build documentation to let people know about how
these mechanisms can be utilized.
win32/README.txt | 20 ++++++-
@@ -45333,10 +44753,8 @@
win32/create-lists-msvc.mak | 9 ++++
win32/generate-msvc.mak | 6 +++
win32/info-msvc.mak | 8 ++-
- win32/pc_base.py | 124
- ++++++++++++++++++++++++++++++++++++++++++++
- win32/replace.py | 115
- ++++++++++++++++++++++++++++++++++++++++
+ win32/pc_base.py | 124 ++++++++++++++++++++++++++++++++++++++++++++
+ win32/replace.py | 115 ++++++++++++++++++++++++++++++++++++++++
win32/setup.py | 62 ++++++++++++++++++++++
9 files changed, 353 insertions(+), 3 deletions(-)
@@ -45358,8 +44776,7 @@
src/hb-ot-shape-complex-indic.cc | 12 +++++-----
src/hb-ot-shape-complex-myanmar.cc | 2 +-
src/hb-ot-shape-complex-thai.cc | 12 +++++-----
- src/hb-ot-shape-complex-use-table.cc | 42
- ++++++++++++++++-----------------
+ src/hb-ot-shape-complex-use-table.cc | 42 ++++++++++++++++-----------------
src/hb-unicode-private.hh | 16 ++++++-------
src/hb-utf-private.hh | 18 +++++++-------
15 files changed, 110 insertions(+), 86 deletions(-)
@@ -45387,7 +44804,7 @@
Date: Mon May 29 12:53:30 2017 -0500
Avoid using strdup inside library. (#488)
-
+
If an application provides a malloc replacement through
hb_malloc_impl() it is important that it is used to allocate
everything, but the use of strdup() circumvents this and
@@ -45403,17 +44820,15 @@
Date: Wed May 17 21:32:47 2017 +0300
Do not skip TAG characters in glyph substitution (#487)
-
+
Hide them like Mongolian Free Variation Selectors instead.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/463
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
- src/hb-ot-layout-private.hh | 13
- +++++++++----
+ src/hb-ot-layout-private.hh | 13 +++++++++----
test/shaping/Makefile.am | 1 +
- .../sha1sum/53374c7ca3657be37efde7ed02ae34229a56ae1f.ttf | Bin 0 ->
- 5044 bytes
+ .../sha1sum/53374c7ca3657be37efde7ed02ae34229a56ae1f.ttf | Bin 0 -> 5044 bytes
test/shaping/tests/emoji-flag-tags.tests | 2 ++
5 files changed, 13 insertions(+), 5 deletions(-)
@@ -45469,8 +44884,7 @@
[cmake] Final touches (#473)
- CMakeLists.txt | 113
- +++++++++++++++++++++++++++------------------------------
+ CMakeLists.txt | 113 +++++++++++++++++++++++++++------------------------------
1 file changed, 54 insertions(+), 59 deletions(-)
commit aacca37590656e235218557ea509eb5624dfbff9
@@ -45478,15 +44892,14 @@
Date: Mon Apr 17 23:25:24 2017 -0700
Fix clang -Wcomma warnings (#471) (#472)
-
+
clang's new -Wcomma compiler option warns about possible misuse of the
comma operator such as between two statements.
-
+
hb-common.cc:190:9 [-Wcomma] possible misuse of comma operator here
hb-ot-layout-gsubgpos-private.hh:345:30 [-Wcomma] possible misuse of
comma operator here
- hb-shape-plan.cc:438:26 [-Wcomma] possible misuse of comma operator
- here
+ hb-shape-plan.cc:438:26 [-Wcomma] possible misuse of comma operator here
src/hb-common.cc | 6 ++++--
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
@@ -45497,8 +44910,7 @@
Author: ebraminio <ebrahim at gnu.org>
Date: Mon Apr 17 15:53:46 2017 +0430
- [cmake] Remove HB_DISABLE_DEPRECATED as it seems needed for pango
- build (#470)
+ [cmake] Remove HB_DISABLE_DEPRECATED as it seems needed for pango build (#470)
CMakeLists.txt | 2 --
1 file changed, 2 deletions(-)
@@ -45508,7 +44920,7 @@
Date: Mon Apr 17 01:33:42 2017 -0400
Use absolute paths of ragel generated headers (#467)
-
+
https://github.com/behdad/harfbuzz/issues/455
src/Makefile.am | 4 ++--
@@ -45564,9 +44976,8 @@
Date: Tue Apr 11 22:29:13 2017 +0100
Blacklist GDEF table in additional Tahoma versions. (#459)
-
- There are more broken versions of Tahoma out there on various
- Windows releases,
+
+ There are more broken versions of Tahoma out there on various Windows releases,
so we need to add them to our blacklist to avoid broken rendering.
See https://bugzilla.mozilla.org/show_bug.cgi?id=1279925 for details.
@@ -45579,8 +44990,7 @@
[cmake] Improve third party libraries support (#461)
- CMakeLists.txt | 57
- ++++++++++++++++++++++++++++++++++++--------
+ CMakeLists.txt | 57 ++++++++++++++++++++++++++++++++++++--------
src/hb-ucdn/Makefile.sources | 5 +++-
2 files changed, 51 insertions(+), 11 deletions(-)
@@ -45590,8 +45000,7 @@
[cmake] Add utils build support (#460)
- CMakeLists.txt | 150
- +++++++++++++++++++++++++++++++++++++++++----------------
+ CMakeLists.txt | 150 +++++++++++++++++++++++++++++++++++++++++----------------
1 file changed, 108 insertions(+), 42 deletions(-)
commit bc1244e2395f844b2b41315cb1eef29570e46b29
@@ -45599,14 +45008,12 @@
Date: Thu Apr 6 18:44:28 2017 +0800
NMake Makefiles: Fix ICU builds
-
+
Fix the check conditions in config-msvc.mak and info-msvc.mak so that
- the ICU items does indeed get built into the HarfBuzz main DLL,
- and that
+ the ICU items does indeed get built into the HarfBuzz main DLL, and that
the correct configuration info is displayed.
-
- Also update the checks in detectenv-msvc.mak so that we can detect
- that
+
+ Also update the checks in detectenv-msvc.mak so that we can detect that
we are using Visual Studio 2017 (although the 2015-built binaries use
the same CRT DLL as the 2017 ones).
@@ -45629,11 +45036,9 @@
Author: ebraminio <ebrahim at gnu.org>
Date: Wed Apr 5 02:21:23 2017 -0700
- Split ragel generated files lists and remove hardcoded rl files lists
- (#453)
+ Split ragel generated files lists and remove hardcoded rl files lists (#453)
- CMakeLists.txt | 126
- +++++++++++++++++++++-----------------------------
+ CMakeLists.txt | 126 +++++++++++++++++++++-----------------------------
src/Makefile.am | 2 +
src/Makefile.sources | 16 +++++--
win32/config-msvc.mak | 8 ++--
@@ -45645,8 +45050,7 @@
Add CMake build support (#444)
- CMakeLists.txt | 254
- +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ CMakeLists.txt | 254 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Makefile.am | 1 +
appveyor.yml | 61 +++++++++-----
3 files changed, 295 insertions(+), 21 deletions(-)
@@ -45656,7 +45060,7 @@
Date: Mon Apr 3 12:22:39 2017 +0100
avoid UBSan warning in get_stage_lookups (#450)
-
+
See https://bugzilla.mozilla.org/show_bug.cgi?id=1336600
src/hb-ot-map-private.hh | 2 +-
@@ -45666,8 +45070,7 @@
Author: Dominik Schloesser <dsc at dosc.net>
Date: Sun Mar 26 09:22:34 2017 +0200
- Current fonttools (3.9.1) generate subset-file called font.subset.ttf
- instead of older font.ttf.subset
+ Current fonttools (3.9.1) generate subset-file called font.subset.ttf instead of older font.ttf.subset
test/shaping/record-test.sh | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
@@ -45686,7 +45089,7 @@
Date: Sun Mar 26 10:48:53 2017 +0200
[tools] Make hb-unicode-code work with Python 3
-
+
Related to https://github.com/behdad/harfbuzz/pull/445
test/shaping/hb_test_tools.py | 13 ++++++++++++-
@@ -45697,7 +45100,7 @@
Date: Fri Mar 24 10:24:52 2017 -0700
Blacklist more versions of Padauk
-
+
Patch from Phil Race.
src/hb-ot-layout.cc | 8 ++++++++
@@ -45708,9 +45111,8 @@
Date: Thu Mar 23 00:35:36 2017 +0200
[ci] Fix msys2 build on AppVeyor
-
- For whatever reason the env variables need to be the Windows way
- or they
+
+ For whatever reason the env variables need to be the Windows way or they
end up being empty.
appveyor.yml | 2 +-
@@ -45730,11 +45132,9 @@
Date: Fri Feb 24 17:58:25 2017 +0800
src/hb-common.cc: Fix build on older Visual Studio
-
- Visual Studio only supported strtof() from Visual Studio 2013
- onwards, so
- use strtod() instead to do the operation, which should do the
- same thing,
+
+ Visual Studio only supported strtof() from Visual Studio 2013 onwards, so
+ use strtod() instead to do the operation, which should do the same thing,
sans going to a double, not a float.
src/hb-common.cc | 4 ++++
@@ -45745,22 +45145,18 @@
Date: Fri Feb 24 17:47:44 2017 +0800
Visual Studio builds: Fix Introspection when UCDN enabled
-
+
The sources in src/hb-ucdn and not included correctly into the NMake
- Makefiles, as we need their explicit relative location as we pass
- all the
+ Makefiles, as we need their explicit relative location as we pass all the
sources we used into the introspection scanner. This was not an issue
before as we excluded the UCDN sources in the build when we enabled
introspection (meaning GLib is enabled), but since we default on using
- UCDN on all builds unless explicitly disabled, we need to deal
- with this.
-
- This did not affect builds using UCDN without introspection due to
- the use
+ UCDN on all builds unless explicitly disabled, we need to deal with this.
+
+ This did not affect builds using UCDN without introspection due to the use
of NMake batch rules.
-
- Fix this by creating a NMake Makefile module on-the-fly with the
- correct
+
+ Fix this by creating a NMake Makefile module on-the-fly with the correct
subdir info, and using that list in there instead.
win32/Makefile.vc | 15 +++++++++++++++
@@ -45772,16 +45168,14 @@
Date: Thu Feb 23 13:02:49 2017 +0800
Update Visual Studio builds for UCDN usage
-
+
We now use UCDN by default, so make it so in the build files; however
don't hardcode HAVE_UCDN as one may still opt not to use it (but pass
- it in as a CFLAG unless one explicitly disables UCDN by using
- NO_UCDN=1
+ it in as a CFLAG unless one explicitly disables UCDN by using NO_UCDN=1
on the NMake command line).
-
+
Note that we are not blocking builds where UCDN is disabled along with
- GLib and ICU, as that will trigger a build error anyways which
- will tell
+ GLib and ICU, as that will trigger a build error anyways which will tell
the user what needs to be done to remedy this.
win32/README.txt | 6 +++---
@@ -45804,16 +45198,14 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Mar 10 13:23:02 2017 -0800
- Revert "Fix Context lookup application when moving back after a
- glyph delete"
-
+ Revert "Fix Context lookup application when moving back after a glyph delete"
+
This reverts commit b9b005f3a44ccf78a45b212b126287b69b9f4b40.
-
+
This introduced invalid access cases. Revert until I fix correctly.
src/hb-ot-layout-gsubgpos-private.hh | 7 ++++---
- .../sha1sum/5bbf3712e6f79775c66a4407837a90e591efbef2.ttf | Bin 6400 ->
- 0 bytes
+ .../sha1sum/5bbf3712e6f79775c66a4407837a90e591efbef2.ttf | Bin 6400 -> 0 bytes
test/shaping/tests/context-matching.tests | 1 -
3 files changed, 4 insertions(+), 4 deletions(-)
@@ -45822,7 +45214,7 @@
Date: Tue Mar 7 18:13:28 2017 -0800
Fix buffer serialize of empty buffer
-
+
Ouch!
src/hb-buffer-serialize.cc | 2 ++
@@ -45864,10 +45256,8 @@
BASE: start api
src/Makefile.sources | 2 ++
- src/hb-ot-base.cc | 58
- ++++++++++++++++++++++++++++++++++++++++++
- src/hb-ot-base.h | 56
- ++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-base.cc | 58 ++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-base.h | 56 ++++++++++++++++++++++++++++++++++++++++
src/hb-ot-layout-base-table.hh | 15 ++---------
4 files changed, 118 insertions(+), 13 deletions(-)
@@ -45885,13 +45275,12 @@
Date: Wed Mar 1 14:27:23 2017 -0800
Fix Context lookup application when moving back after a glyph delete
-
+
This was broken forever, since days that we did not allow moving
tape backwards. Works now. Reported by Doug Felt.
src/hb-ot-layout-gsubgpos-private.hh | 7 +++----
- .../sha1sum/5bbf3712e6f79775c66a4407837a90e591efbef2.ttf | Bin 0 ->
- 6400 bytes
+ .../sha1sum/5bbf3712e6f79775c66a4407837a90e591efbef2.ttf | Bin 0 -> 6400 bytes
test/shaping/tests/context-matching.tests | 1 +
3 files changed, 4 insertions(+), 4 deletions(-)
@@ -45910,8 +45299,7 @@
BASE: first complete version
- src/hb-ot-layout-base-table.hh | 444
- +++++++++++++++++++++++++++++------------
+ src/hb-ot-layout-base-table.hh | 444 +++++++++++++++++++++++++++++------------
1 file changed, 317 insertions(+), 127 deletions(-)
commit a11501444cfc4854bfe2b1d3ce0fc5a957e959d8
@@ -45920,14 +45308,10 @@
Add few tests found by libFuzzer and oss-fuzz
- .../sha1sum/a34a9191d9376bda419836effeef7e75c1386016.ttf | Bin 0 ->
- 1010 bytes
- .../sha1sum/a69118c2c2ada48ff803d9149daa54c9ebdae30e.ttf | Bin 0 ->
- 820 bytes
- .../sha1sum/b6acef662e0beb8d5fcf5b61c6b0ca69537b7402.ttf | Bin 0 ->
- 3301 bytes
- .../sha1sum/e88c339237f52d21e01c55f01b9c1b4cc14a0467.ttf | Bin 0 ->
- 515 bytes
+ .../sha1sum/a34a9191d9376bda419836effeef7e75c1386016.ttf | Bin 0 -> 1010 bytes
+ .../sha1sum/a69118c2c2ada48ff803d9149daa54c9ebdae30e.ttf | Bin 0 -> 820 bytes
+ .../sha1sum/b6acef662e0beb8d5fcf5b61c6b0ca69537b7402.ttf | Bin 0 -> 3301 bytes
+ .../sha1sum/e88c339237f52d21e01c55f01b9c1b4cc14a0467.ttf | Bin 0 -> 515 bytes
test/shaping/tests/fuzzed.tests | 4 ++++
5 files changed, 4 insertions(+)
@@ -45936,10 +45320,10 @@
Date: Sat Feb 25 13:30:38 2017 -0800
Fix buffer-overrun with Bengali reph positioning code
-
+
This has no security implications whatsoever since we always keep
and extra element at the end of buffer, just in case.
-
+
Discovered by oss-fuzz
CC https://github.com/behdad/harfbuzz/issues/139
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=660
@@ -45953,8 +45337,7 @@
BASE: WIP: more access functions
- src/hb-ot-layout-base-table.hh | 212
- +++++++++++++++++++++++++++++++++++++----
+ src/hb-ot-layout-base-table.hh | 212 +++++++++++++++++++++++++++++++++++++----
1 file changed, 191 insertions(+), 21 deletions(-)
commit 6685d281d6f50bf046bbfef4a5263e15d15f2f02
@@ -45973,8 +45356,7 @@
BASE: align member's names
- src/hb-ot-layout-base-table.hh | 70
- +++++++++++++++++++++---------------------
+ src/hb-ot-layout-base-table.hh | 70 +++++++++++++++++++++---------------------
1 file changed, 35 insertions(+), 35 deletions(-)
commit 499b4bef2a5b6d49374ab4977509d1fbf7bd6038
@@ -45983,8 +45365,7 @@
BASE: more consistent naming (with spec and Harfbuzz code base)
- src/hb-ot-layout-base-table.hh | 44
- +++++++++++++++++++++---------------------
+ src/hb-ot-layout-base-table.hh | 44 +++++++++++++++++++++---------------------
1 file changed, 22 insertions(+), 22 deletions(-)
commit a0bdd546c584eb7c7ea3ca7e19a178723e6fe77f
@@ -46002,8 +45383,7 @@
BASE: sanitize
- src/hb-ot-layout-base-table.hh | 151
- ++++++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-base-table.hh | 151 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 148 insertions(+), 3 deletions(-)
commit a657f23ca31237d652b5c101ed24194b6aeadaf8
@@ -46011,7 +45391,7 @@
Date: Mon Feb 20 21:52:07 2017 +0200
Blacklist another instance of Padauk (#419)
-
+
In https://crbug.com/681813 another instance of Padauk was identified
triggering collapsed glyphs. Blacklist this version by patching
hb-ot-layout.cc to print out gdef, gsub, and gpos table length, then
@@ -46027,8 +45407,7 @@
compile, move into hb-ot-layout.cc
src/hb-ot-font.cc | 1 -
- src/hb-ot-layout-base-table.hh | 57
- +++++++++++++++++++++++++++++++-----------
+ src/hb-ot-layout-base-table.hh | 57 +++++++++++++++++++++++++++++++-----------
src/hb-ot-layout.cc | 1 +
3 files changed, 43 insertions(+), 16 deletions(-)
@@ -46037,10 +45416,9 @@
Date: Sun Feb 19 08:48:22 2017 +0100
hb-ot-base-table.hh -> hb-ot-layout-base-table.hh
+
+ per https://github.com/behdad/harfbuzz/issues/418#issuecomment-280873811
- per
- https://github.com/behdad/harfbuzz/issues/418#issuecomment-280873811
-
src/Makefile.sources | 2 +-
src/hb-ot-font.cc | 2 +-
src/{hb-ot-base-table.hh => hb-ot-layout-base-table.hh} | 0
@@ -46053,8 +45431,7 @@
bootstraping structure
src/Makefile.sources | 1 +
- src/hb-ot-base-table.hh | 238
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-base-table.hh | 238 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-font.cc | 1 +
src/hb-ot-layout-private.hh | 2 +
4 files changed, 242 insertions(+)
@@ -46073,22 +45450,19 @@
Date: Fri Feb 17 03:03:24 2017 +0000
Guard against underflow when adjusting length (#421)
-
+
* Guard against underflow when adjusting length
-
- With the fuzz-testcase in mozilla bug 1295299, we end up with a
- recursed lookup that removes 3 items, when `match_positions[idx]`
- is 0, which results in (unsigned) `end` wrapping to a huge value.
-
+
+ With the fuzz-testcase in mozilla bug 1295299, we end up with a recursed lookup that removes 3 items, when `match_positions[idx]` is 0, which results in (unsigned) `end` wrapping to a huge value.
+
Making `end` a signed int is probably the simplest route to a fix.
-
+
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1295299.
-
+
* Add testcase for #421.
src/hb-ot-layout-gsubgpos-private.hh | 6 +++---
- .../sha1sum/558661aa659912f4d30ecd27bd09835171a8e2b0.ttf | Bin 0 ->
- 1358 bytes
+ .../sha1sum/558661aa659912f4d30ecd27bd09835171a8e2b0.ttf | Bin 0 -> 1358 bytes
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 4 insertions(+), 3 deletions(-)
@@ -46096,22 +45470,18 @@
Author: jfkthame <jfkthame at gmail.com>
Date: Thu Feb 16 17:40:21 2017 +0000
- [indic] Add support for Grantha marks that may be used in Tamil to
- th… (#401)
-
- * [indic] Add support for Grantha marks that may be used in Tamil
- to the Indic table.
-
+ [indic] Add support for Grantha marks that may be used in Tamil to th… (#401)
+
+ * [indic] Add support for Grantha marks that may be used in Tamil to the Indic table.
+
See https://bugzilla.mozilla.org/show_bug.cgi?id=1331339.
-
+
Testcase: U+0BA4,U+0BC6,U+1133c,U+0BAA,U+1133c,U+0BC6,U+1133c
+
+ * [indic] Add test for Grantha nukta that is allowed in Tamil by ScriptExtensions.txt
- * [indic] Add test for Grantha nukta that is allowed in Tamil by
- ScriptExtensions.txt
-
src/hb-ot-shape-complex-indic-table.cc | 7 +++++++
- .../sha1sum/3493e92eaded2661cadde752a39f9d58b11f0326.ttf | Bin 0 ->
- 1400 bytes
+ .../sha1sum/3493e92eaded2661cadde752a39f9d58b11f0326.ttf | Bin 0 -> 1400 bytes
test/shaping/tests/indic-script-extensions.tests | 1 +
3 files changed, 8 insertions(+)
@@ -46130,7 +45500,7 @@
Date: Wed Feb 8 14:36:18 2017 -0800
Merge pull request #357 from khaledhosny/graphite-scale
-
+
[graphite] Fix shaping with varying font sizes
commit 7c47474f209bdf84cf87844c277ed711cad78196
@@ -46138,7 +45508,7 @@
Date: Wed Feb 8 14:33:28 2017 -0800
Set LC_ALL instead of LANG when creating harfbuzz.def
-
+
Hopefully fixes Travis faliure?
https://github.com/behdad/harfbuzz/pull/413#issuecomment-278481882
https://travis-ci.org/khaledhosny/harfbuzz/jobs/199785332#L1065
@@ -46151,16 +45521,15 @@
Date: Wed Feb 8 21:56:57 2017 +0000
hb-font: Fix a potentially undefined use of memcmp() (#413)
-
- While it’s fine to call memcmp(x, 0, 0) in practice, the C99
- standard
+
+ While it’s fine to call memcmp(x, 0, 0) in practice, the C99 standard
explicitly says that this is not allowed: even if the length is zero,
the pointer arguments must be valid.
-
+
http://stackoverflow.com/a/16363034
-
+
Coverity ID: 141178
-
+
Signed-off-by: Philip Withnall <withnall at endlessm.com>
src/hb-font.cc | 3 ++-
@@ -46171,11 +45540,10 @@
Date: Tue Feb 7 18:25:12 2017 -0800
Update ax_pthread.m4 to latest upstream version
-
+
Might help with https://github.com/behdad/harfbuzz/issues/399
- m4/ax_pthread.m4 | 394
- ++++++++++++++++++++++++++++++++++++++++---------------
+ m4/ax_pthread.m4 | 394 ++++++++++++++++++++++++++++++++++++++++---------------
1 file changed, 285 insertions(+), 109 deletions(-)
commit a6ced90efccf869defc0b310effca220f01cf318
@@ -46183,7 +45551,7 @@
Date: Wed Feb 8 02:18:33 2017 +0000
test: Fix some memory leaks in test-font.c (#409)
-
+
Coverity IDs: 141039, 141040, 141041
test/api/test-font.c | 35 ++++++++++++++++++++++++++++++-----
@@ -46194,7 +45562,7 @@
Date: Wed Feb 8 02:17:48 2017 +0000
util: Add missing field initialisers in constructor (#410)
-
+
Coverity ID: 141042
util/hb-shape.cc | 4 +++-
@@ -46205,7 +45573,7 @@
Date: Tue Feb 7 16:53:21 2017 -0800
Silence Coverity warning
-
+
Fixes https://github.com/behdad/harfbuzz/issues/408
src/hb-ot-shape-complex-arabic.cc | 2 +-
@@ -46266,7 +45634,7 @@
Date: Fri Feb 3 10:39:40 2017 -0800
Add new API hb_font_set_face()
-
+
For completeness.
src/hb-font.cc | 29 +++++++++++++++++++++++++++++
@@ -46277,8 +45645,7 @@
Author: jfkthame <jfkthame at gmail.com>
Date: Thu Feb 2 18:48:23 2017 +0000
- Add Win10 Anniversary Update version of Tahoma to GDEF
- blacklist. (#412)
+ Add Win10 Anniversary Update version of Tahoma to GDEF blacklist. (#412)
src/hb-ot-layout.cc | 4 ++++
1 file changed, 4 insertions(+)
@@ -46288,7 +45655,7 @@
Date: Wed Feb 1 11:57:21 2017 -0800
Minor
-
+
Fixes https://github.com/behdad/harfbuzz/issues/411
src/hb-fallback-shape.cc | 2 +-
@@ -46300,15 +45667,14 @@
Date: Thu Jan 26 14:50:14 2017 -0800
Route Adlam through Arabic shaper
-
+
Fixes joined Adlam rendering.
-
+
Fixes https://github.com/googlei18n/noto-fonts/issues/828
src/hb-ot-shape-complex-private.hh | 3 +++
test/shaping/Makefile.am | 1 +
- .../5dfad7735c6a67085f1b90d4d497e32907db4c78.ttf | Bin 0 ->
- 21160 bytes
+ .../5dfad7735c6a67085f1b90d4d497e32907db4c78.ttf | Bin 0 -> 21160 bytes
test/shaping/tests/arabic-like-joining.tests | 1 +
4 files changed, 5 insertions(+)
@@ -46326,13 +45692,12 @@
Date: Mon Jan 23 23:42:53 2017 -0800
[var] Implement MVAR table
-
+
Unhooked. Untested.
src/Makefile.sources | 1 +
src/hb-font.cc | 2 +-
- src/hb-ot-var-mvar-table.hh | 110
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-var-mvar-table.hh | 110 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-var.cc | 1 +
4 files changed, 113 insertions(+), 1 deletion(-)
@@ -46360,7 +45725,7 @@
Date: Mon Jan 23 17:55:31 2017 -0800
[var] Hook up advance variations to hb-ot-font
-
+
Yay, works!
src/hb-ot-font.cc | 6 +++++-
@@ -46390,12 +45755,11 @@
Date: Mon Jan 23 11:56:08 2017 -0800
[var] Implement DeltaSetIndexMap and advance delta fetching
-
+
Not hooked up to hb-ot-font yet.
src/hb-ot-layout-common-private.hh | 8 ++++++
- src/hb-ot-var-hvar-table.hh | 56
- ++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-var-hvar-table.hh | 56 ++++++++++++++++++++++++++++++++++++--
2 files changed, 61 insertions(+), 3 deletions(-)
commit 7b399f73efa76cd97131fd123a9a1566f8639cfd
@@ -46408,8 +45772,7 @@
src/hb-ot-font.cc | 1 +
src/hb-ot-var-avar-table.hh | 1 -
src/hb-ot-var-fvar-table.hh | 1 -
- src/hb-ot-var-hvar-table.hh | 115
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-var-hvar-table.hh | 115 ++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 117 insertions(+), 2 deletions(-)
commit b732c53eb5bd0c2cc86f35a9d9623c92579a0b8c
@@ -46443,7 +45806,7 @@
Date: Sun Jan 22 20:16:51 2017 -0800
[var] Remove HB_OT_TAG_fvar/avar
-
+
We're not going to define public macros for tags for tables.
There's little use to those and they are implementation detail.
@@ -46478,12 +45841,11 @@
Date: Sun Jan 22 19:41:33 2017 -0800
[var] Implement 'avar' table mapping
-
+
Untested!
src/hb-ot-math.cc | 2 --
- src/hb-ot-var-avar-table.hh | 46
- ++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-var-avar-table.hh | 46 ++++++++++++++++++++++++++++++++++++++++++++-
src/hb-ot-var.cc | 23 +++++++++++++++--------
3 files changed, 60 insertions(+), 11 deletions(-)
@@ -46493,8 +45855,7 @@
[var] Flesh out --variations documentation
- util/options.cc | 53
- ++++++++++++++---------------------------------------
+ util/options.cc | 53 ++++++++++++++---------------------------------------
1 file changed, 14 insertions(+), 39 deletions(-)
commit 5ec96d30cad1592b5e468bd8ad1832dbaf0ad32b
@@ -46502,10 +45863,10 @@
Date: Sun Jan 22 18:52:00 2017 -0800
[var] Adjust API in prep for 'avar' implementation
-
+
The 'avar' table does not allow random access to axis maps,
so change API to avoid quadratic-time implementation.
-
+
Removed -hb_ot_var_normalize_axis_value(), added
+hb_ot_var_normalize_variations() and
+hb_ot_var_normalize_coords() instead.
@@ -46513,8 +45874,7 @@
docs/harfbuzz-sections.txt | 3 ++-
src/Makefile.sources | 1 +
src/hb-font.cc | 20 +++++---------------
- src/hb-ot-var.cc | 45
- +++++++++++++++++++++++++++++++++++++++------
+ src/hb-ot-var.cc | 45 +++++++++++++++++++++++++++++++++++++++------
src/hb-ot-var.h | 16 ++++++++++++----
5 files changed, 59 insertions(+), 26 deletions(-)
@@ -46524,8 +45884,7 @@
[var] Stub implementation of avar table
- src/hb-ot-var-avar-table.hh | 99
- +++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-var-avar-table.hh | 99 +++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 99 insertions(+)
commit 7647a05a0b37c53465560952b412db4e590f2716
@@ -46573,7 +45932,7 @@
Date: Sun Jan 22 16:41:45 2017 -0800
[hb-ft] Remove use of variable-length array
-
+
Hopefully also fixes build failure on msvc.
src/hb-ft.cc | 33 +++++++++++++++++++++------------
@@ -46584,7 +45943,7 @@
Date: Sat Jan 21 18:10:08 2017 -0800
[var] Hook up variations to FreeType face
-
+
hb-view correctly renders variations with ft font-funcs now.
hb-ot-font needs HVAR implementation.
@@ -46597,14 +45956,12 @@
Date: Sat Jan 21 17:51:41 2017 -0800
[util] Add --variations
-
- Is hooked up to the font, but not to FreeType, so raster doesn't
- show yet.
-
+
+ Is hooked up to the font, but not to FreeType, so raster doesn't show yet.
+
Documentation needs to be done.
- util/options.cc | 91
- +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ util/options.cc | 91 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
util/options.hh | 8 ++++-
2 files changed, 98 insertions(+), 1 deletion(-)
@@ -46613,7 +45970,7 @@
Date: Sat Jan 21 17:41:37 2017 -0800
[var] Rename var_coord to variation
-
+
Looks much better.
src/hb-common.cc | 36 ++++++++++++++++++------------------
@@ -46697,8 +46054,7 @@
[var] Add hb_var_coord_t and parsing routines
- src/hb-common.cc | 94
- +++++++++++++++++++++++++++++++++++++++++++++++++++++---
+ src/hb-common.cc | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++++---
src/hb-common.h | 15 ++++++++-
2 files changed, 103 insertions(+), 6 deletions(-)
@@ -46708,11 +46064,9 @@
Move code around
- src/hb-common.cc | 250
- +++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-common.cc | 250 +++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-common.h | 18 ++++
- src/hb-shape.cc | 248
- ------------------------------------------------------
+ src/hb-shape.cc | 248 ------------------------------------------------------
src/hb-shape.h | 16 ----
4 files changed, 268 insertions(+), 264 deletions(-)
@@ -46723,8 +46077,7 @@
[var] Flesh out some more
src/Makefile.am | 2 ++
- src/hb-ot-var-fvar-table.hh | 69
- ++++++++++++++++++++++++++++++++-------------
+ src/hb-ot-var-fvar-table.hh | 69 ++++++++++++++++++++++++++++++++-------------
src/hb-ot-var.cc | 39 ++++++++++++++++++++++++-
src/hb-ot-var.h | 21 +++++++++-----
4 files changed, 104 insertions(+), 27 deletions(-)
@@ -46735,8 +46088,7 @@
[var] Flesh out a bit
- src/hb-ot-var-fvar-table.hh | 72
- ++++++++++++++++++++++++++++++++++++---------
+ src/hb-ot-var-fvar-table.hh | 72 ++++++++++++++++++++++++++++++++++++---------
src/hb-ot-var.h | 10 ++++++-
2 files changed, 67 insertions(+), 15 deletions(-)
@@ -46772,14 +46124,13 @@
Date: Thu Jan 19 19:35:48 2017 -0800
Start adding hb-ot-var.h and implementation
-
+
Supports enumerating variation axes, normalizing values, etc.
src/Makefile.sources | 3 +
src/hb-ot-layout-private.hh | 6 ++
src/hb-ot-layout.cc | 4 ++
- src/hb-ot-var-fvar-table.hh | 133
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-var-fvar-table.hh | 133 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-var.cc | 63 +++++++++++++++++++++
src/hb-ot-var.h | 81 +++++++++++++++++++++++++++
src/hb-ot.h | 1 +
@@ -46835,19 +46186,16 @@
Date: Wed Jan 18 22:48:13 2017 +0200
[ot] Fix automatic fraction for RTL scripts (#405)
-
+
The numbers for right-to-left scripts are processed also from right to
- left, so the order of applying “numr” and “dnom” features
- should be
+ left, so the order of applying “numr” and “dnom” features should be
reversed in such case.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/395
- src/hb-ot-shape.cc | 16
- ++++++++++++++--
+ src/hb-ot-shape.cc | 16 ++++++++++++++--
test/shaping/Makefile.am | 1 +
- .../15dfc433a135a658b9f4b1a861b5cdd9658ccbb9.ttf | Bin 0 ->
- 4936 bytes
+ .../15dfc433a135a658b9f4b1a861b5cdd9658ccbb9.ttf | Bin 0 -> 4936 bytes
test/shaping/tests/automatic-fractions.tests | 3 +++
4 files changed, 18 insertions(+), 2 deletions(-)
@@ -46856,11 +46204,10 @@
Date: Wed Jan 18 13:51:02 2017 +0100
Update language tags to OpenType 1.8.1 (#403)
-
+
Resolves https://github.com/behdad/harfbuzz/issues/324
- src/hb-ot-tag.cc | 77
- ++++++++++++++++++++++++++++++++++++++++++++------
+ src/hb-ot-tag.cc | 77 ++++++++++++++++++++++++++++++++++++++++++++------
test/api/test-ot-tag.c | 58 +++++++++++++++++++++++++++++++++++++
2 files changed, 126 insertions(+), 9 deletions(-)
@@ -46900,10 +46247,8 @@
Move lazy-loader to more generic place
- src/hb-open-type-private.hh | 47
- ++++++++++++++++++++++++++++++++++++++++++++
- src/hb-ot-font.cc | 48
- ++-------------------------------------------
+ src/hb-open-type-private.hh | 47 ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-font.cc | 48 ++-------------------------------------------
2 files changed, 49 insertions(+), 46 deletions(-)
commit ac274331c285e1b42632870e150e1d66a9e21933
@@ -46958,10 +46303,10 @@
Date: Mon Jan 9 00:00:49 2017 -0800
Minor
-
+
Should be enough to get -hangul.cc out of SOURCES in Firefox build:
https://dxr.mozilla.org/mozilla-central/source/gfx/harfbuzz/src/moz.build
-
+
No one else should care!
src/hb-ot-shape-complex-hangul.cc | 2 +-
@@ -46972,15 +46317,14 @@
Date: Sun Jan 8 23:55:54 2017 -0800
[USE] Remove non-canonical decompositions
-
- We have had added this in Indic shaper to assist shaping these
- scripts.
+
+ We have had added this in Indic shaper to assist shaping these scripts.
In Universal Shaping Engine however, it is up to font designer to
decompose them. Hence moving them from Indic shaper to USE was
wrong.
-
+
Fixup for f6ba63b2e8eb577385f70758efdd3b8408c8a9cb
-
+
Part of fixing https://github.com/behdad/harfbuzz/issues/387
src/hb-ot-shape-complex-use.cc | 22 ----------------------
@@ -46991,7 +46335,7 @@
Date: Fri Nov 11 02:16:39 2016 +0200
[graphite] Stop creating unused gr_face
-
+
It is unused after previous commit, hb_graphite2_font_get_gr_font()
makes no sense now so deprecating it.
@@ -47004,9 +46348,9 @@
Date: Sun Oct 30 20:16:41 2016 +0200
[graphite] Fix shaping with varying font sizes
-
+
Shape using design units and scale the output.
-
+
See https://bugs.documentfoundation.org/show_bug.cgi?id=103403#c7
src/hb-graphite2.cc | 27 +++++++++++++++------------
@@ -47027,13 +46371,12 @@
Date: Thu Jan 5 20:20:06 2017 -0800
Add tests for USE using Marchen font and text
-
+
From http://www.babelstone.co.uk/Fonts/Marchen.html
test/shaping/Makefile.am | 1 +
.../85414f2552b654585b7a8d13dcc3e8fd9f7970a3.ttf | Bin 0 -> 66936 bytes
- test/shaping/tests/use-marchen.tests | 35
- +++++++++++++++++++++
+ test/shaping/tests/use-marchen.tests | 35 +++++++++++++++++++++
3 files changed, 36 insertions(+)
commit 53543f8b3e19456279c86f711feba42ce976668c
@@ -47041,9 +46384,9 @@
Date: Thu Jan 5 20:12:32 2017 -0800
Ship UCDN and use it by default
-
+
So we are not relying on version of Unicode data in glib...
-
+
Fixes https://github.com/behdad/harfbuzz/issues/386
Fixes https://github.com/behdad/harfbuzz/issues/388
@@ -47069,8 +46412,7 @@
src/Makefile.sources | 1 +
src/hb-ot-layout.cc | 244 ---------------------------------------------
- src/hb-ot-math.cc | 272
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-math.cc | 272 +++++++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 273 insertions(+), 244 deletions(-)
commit e053ccc5bb7268fe5900dd364d906638c58b2908
@@ -47078,12 +46420,11 @@
Date: Wed Dec 28 15:51:57 2016 -0500
Remove Android.mk
-
+
Android uses its own file these days and third-party developers should
be using the autotools-based system against Android NDK.
- Android.mk | 107
- ------------------------------------------------------------
+ Android.mk | 107 ------------------------------------------------------------
Makefile.am | 1 -
2 files changed, 108 deletions(-)
@@ -47092,11 +46433,11 @@
Date: Wed Dec 28 13:46:21 2016 -0500
Remove Tibetan decomposition rules from Indic shaper
-
+
The decomposition is very obscure and unlikely to help
any fonts. Just remove it since Uniscribe probably doesn't
do this either.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/382
src/hb-ot-shape-complex-indic.cc | 4 ----
@@ -47107,7 +46448,7 @@
Date: Wed Dec 28 13:45:32 2016 -0500
Port decompositions from Indic to USE shaper
-
+
Part of https://github.com/behdad/harfbuzz/issues/382
src/hb-ot-shape-complex-indic.cc | 16 ----------------
@@ -47119,10 +46460,10 @@
Date: Mon Dec 26 14:11:59 2016 -0500
[indic] Remove Chakma decomposition rule from Indic shaper
-
+
This is now added to USE:
https://github.com/behdad/harfbuzz/pull/383
-
+
See:
https://github.com/behdad/harfbuzz/issues/381
https://github.com/behdad/harfbuzz/issues/382
@@ -47144,9 +46485,9 @@
Date: Mon Dec 26 14:52:08 2016 -0500
Revert "[indic] Remove redundant Chakma decomposition rule"
-
+
This reverts commit 805f76fc002d703acfcc4c5727f0b4d1baecefaa.
-
+
Need to investigate why having this rule (with the reversed order)
fixes decomposition as reported by punchcutter:
https://github.com/behdad/harfbuzz/issues/381#issuecomment-269237796
@@ -47159,10 +46500,10 @@
Date: Mon Dec 26 14:11:59 2016 -0500
[indic] Remove redundant Chakma decomposition rule
-
+
This was not used BTW since Chakma doesn't go through Indic shaper
anymore.
-
+
See:
https://github.com/behdad/harfbuzz/issues/381
https://github.com/behdad/harfbuzz/issues/382
@@ -47184,14 +46525,12 @@
Date: Sat Dec 24 02:46:37 2016 +0100
Compilation Error for ASSERT_STATIC on Some Compilers (#380)
-
+
* this pointer in type definitions is not interpreted as a constant.
- This rule is not enforced strictly by all compilers, but the Green
- Hills Software compiler will regard this as an error.
-
+ This rule is not enforced strictly by all compilers, but the Green Hills Software compiler will regard this as an error.
+
* Merging branches for the DEFINE_SIZE_UNION macro
- Adding check for the existence of static_size field in the tested
- member.
+ Adding check for the existence of static_size field in the tested member.
src/hb-open-type-private.hh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -47201,19 +46540,17 @@
Date: Thu Dec 22 14:40:19 2016 -0600
Disable OTL processing for Hebrew if GPOS doesn't have Hebrew subtable
-
+
New approach to fix this:
https://github.com/behdad/harfbuzz/commit/69f9fbc4200442a35484d3c790ae8f4979be5d60
-
+
Previous approach was reverted as it was too broad. See context:
https://github.com/behdad/harfbuzz/issues/347#issuecomment-267838368
-
- With U+05E9,U+05B8,U+05C1,U+05DC and Arial Unicode, we now (correctly)
- disable
- GDEF and GPOS, so we get results very close to Uniscribe, but
- slightly different
+
+ With U+05E9,U+05B8,U+05C1,U+05DC and Arial Unicode, we now (correctly) disable
+ GDEF and GPOS, so we get results very close to Uniscribe, but slightly different
since our fallback position logic is not exactly the same:
-
+
Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434]
After: [gid1166=3+991|gid1142=0 at 402,-26+0|gid5798=0+1434]
Uniscribe: [gid1166=3+991|gid1142=0 at 348,0+0|gid5798=0+1434]
@@ -47235,13 +46572,11 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Dec 22 13:33:54 2016 -0600
- Revert "Synthesize GDEF glyph class for any glyph that does not have
- one in GDEF"
-
+ Revert "Synthesize GDEF glyph class for any glyph that does not have one in GDEF"
+
This reverts commit 69f9fbc4200442a35484d3c790ae8f4979be5d60.
-
- See
- https://github.com/behdad/harfbuzz/issues/347#issuecomment-268873401
+
+ See https://github.com/behdad/harfbuzz/issues/347#issuecomment-268873401
Fixes https://github.com/behdad/harfbuzz/issues/347
src/hb-ot-layout-gsub-table.hh | 22 ++--------------------
@@ -47253,15 +46588,14 @@
Date: Wed Dec 21 23:10:43 2016 -0600
Fix assert fail with contextual matching
-
+
As discovered by libFuzzer / Chromium fuzzing.
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=659496
CC https://github.com/behdad/harfbuzz/issues/139
src/hb-ot-layout-gsubgpos-private.hh | 6 +++++-
- .../sha1sum/217a934cfe15c548b572c203dceb2befdf026462.ttf | Bin 0 ->
- 1384 bytes
+ .../sha1sum/217a934cfe15c548b572c203dceb2befdf026462.ttf | Bin 0 -> 1384 bytes
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 6 insertions(+), 1 deletion(-)
@@ -47279,7 +46613,7 @@
Date: Wed Dec 21 15:51:28 2016 -0600
Avoid infinite loop in CoverageFormat2 iteration with bad fonts
-
+
Fixes https://github.com/behdad/harfbuzz/issues/363
src/hb-ot-layout-common-private.hh | 29 ++++++++++++++++++-----------
@@ -47310,11 +46644,10 @@
Date: Tue Dec 20 15:01:16 2016 -0600
Protect collect_glyphs() and closure() against malicious DDOS fonts
-
+
Fixes https://github.com/behdad/harfbuzz/issues/363
- src/hb-ot-layout-gsub-table.hh | 58
- ++++++++++++++++++++++++++++++++++--------
+ src/hb-ot-layout-gsub-table.hh | 58 ++++++++++++++++++++++++++++++++++--------
1 file changed, 48 insertions(+), 10 deletions(-)
commit 1c98ff87c76536553e53c131e75aba33033ee3a0
@@ -47322,23 +46655,23 @@
Date: Fri Sep 30 18:15:37 2016 +0900
Support building with older glib versions
-
+
It is desirable to be able to build against older versions of glib.
-
+
fd7a245 changed the configure check to require glib > 2.38 for
G_TEST_DIST. Before that, version 2.16 was required, but in fact,
since aafe395, G_PASTE is being used, which was introduced in 2.19.1.
And since 0ef179e2, hb-glib uses GBytes, which were introduced in
2.31.10.
-
+
2.19.1 is rather old, but 2.38 is rather new. For Firefox, building
against 2.22 is still supported, although we could probably get away
with bumping that to 2.28. Either way, GBytes is not available.
-
+
Arguably, if you build against a glib that doesn't support GBytes,
you're not going to use the hb_glib_blob_create function, so we hide
the function when building against such a glib.
-
+
As for G_TEST_DIST, when building against versions of glib that don't
support it, we can fallback to the previous behavior, which, AIUI, was
just making the test not work when building in a separate directory.
@@ -47354,7 +46687,7 @@
Date: Wed Dec 14 18:56:17 2016 +0100
Minor fixes to pacify Coverity code scan
-
+
Fixes https://github.com/behdad/harfbuzz/pull/377
src/hb-ot-font.cc | 6 +++++-
@@ -47367,8 +46700,7 @@
[dwrite] Provide an experimental API for justification (#279)
- src/hb-directwrite.cc | 48
- ++++++++++++++++++++++++++++++++++++++++--------
+ src/hb-directwrite.cc | 48 ++++++++++++++++++++++++++++++++++++++++--------
src/hb-directwrite.h | 4 ++++
2 files changed, 44 insertions(+), 8 deletions(-)
@@ -47438,7 +46770,7 @@
Date: Sat Sep 10 04:52:34 2016 -0700
[GX] Make FeatureVariations actually work
-
+
Yay!!!!
src/hb-ot-layout-common-private.hh | 19 +++++++------------
@@ -47450,7 +46782,7 @@
Date: Sat Sep 10 03:57:24 2016 -0700
[GX] Hook up feature variations
-
+
Shape-plan caching is not implemented.
src/hb-coretext.cc | 8 +++-
@@ -47463,8 +46795,7 @@
src/hb-ot-shape-private.hh | 6 ++-
src/hb-ot-shape.cc | 9 ++--
src/hb-shape-plan-private.hh | 9 +++-
- src/hb-shape-plan.cc | 102
- +++++++++++++++++++++++++++++++++++++++----
+ src/hb-shape-plan.cc | 102 +++++++++++++++++++++++++++++++++++++++----
src/hb-shape-plan.h | 19 ++++++++
src/hb-shape.cc | 5 ++-
src/hb-uniscribe.cc | 4 +-
@@ -47500,8 +46831,7 @@
Shuffle code around
- src/hb-ot-map.cc | 81
- ++++++++++++++++++++++++++++----------------------------
+ src/hb-ot-map.cc | 81 ++++++++++++++++++++++++++++----------------------------
1 file changed, 41 insertions(+), 40 deletions(-)
commit bde5e3959c0ffdb92db87668035b01aaee9b2352
@@ -47509,7 +46839,7 @@
Date: Sat Sep 10 02:43:20 2016 -0700
Move add_lookups from map to map-builder
-
+
In prep for more changes.
src/hb-ot-map-private.hh | 15 ++++++++-------
@@ -47521,7 +46851,7 @@
Date: Sat Sep 10 02:11:05 2016 -0700
[GX] Remove (partial) support for anisotropic variations
-
+
It doesn't always work, not part of FreeType, and we were not going
to expose it in the API anyway. Can always be added later.
@@ -47544,11 +46874,10 @@
Date: Sat Sep 10 01:24:28 2016 -0700
[GX] Implement Feature Variations
-
+
Not hooked up to shaper yet.
- src/hb-ot-layout-common-private.hh | 168
- ++++++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-common-private.hh | 168 ++++++++++++++++++++++++++++++++++-
src/hb-ot-layout-gdef-table.hh | 1 -
src/hb-ot-layout-gpos-table.hh | 2 -
src/hb-ot-layout-gsub-table.hh | 2 -
@@ -47560,7 +46889,7 @@
Date: Sat Sep 10 00:25:16 2016 -0700
[GX] Fix another x/y thinko
-
+
Thanks Werner!
src/hb-ot-layout-common-private.hh | 2 +-
@@ -47583,14 +46912,11 @@
Date: Sat Sep 10 00:01:10 2016 -0700
[GX] Fix build with some compilers
+
+ Eg. https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.48/job/o9mnd33kcdeeg30r
+
+ hb-open-type-private.hh:103:29: error: static data member 'OT::Device::<anonymous union>::<anonymous struct>::static_size' in unnamed class [-fpermissive]
- Eg.
- https://ci.appveyor.com/project/behdad/harfbuzz/build/1.0.48/job/o9mnd33kcdeeg30r
-
- hb-open-type-private.hh:103:29: error: static data member
- 'OT::Device::<anonymous union>::<anonymous struct>::static_size'
- in unnamed class [-fpermissive]
-
src/hb-ot-layout-common-private.hh | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
@@ -47618,7 +46944,7 @@
Date: Fri Sep 9 22:23:34 2016 -0700
[GX] Add new API hb_font_set_var_coords_normalized()
-
+
Will probably change.
src/hb-font.cc | 23 +++++++++++++++++++++++
@@ -47630,13 +46956,12 @@
Date: Fri Sep 9 17:03:11 2016 -0700
[GX] Hook up GPOS to Variation Store stored in GDEF
-
+
Untested.
src/hb-ot-layout-common-private.hh | 22 ++++++++++----------
src/hb-ot-layout-gdef-table.hh | 27 +++++++++++++++---------
- src/hb-ot-layout-gpos-table.hh | 40
- ++++++++++++++++--------------------
+ src/hb-ot-layout-gpos-table.hh | 40 ++++++++++++++++--------------------
src/hb-ot-layout-gsubgpos-private.hh | 2 ++
4 files changed, 48 insertions(+), 43 deletions(-)
@@ -47654,11 +46979,10 @@
Date: Fri Sep 9 16:27:03 2016 -0700
[GX] Pass apply-context down to get_anchor()
-
+
Needed to access GDEF for varStore.
- src/hb-ot-layout-gpos-table.hh | 57
- ++++++++++++++++++++++--------------------
+ src/hb-ot-layout-gpos-table.hh | 57 ++++++++++++++++++++++--------------------
1 file changed, 30 insertions(+), 27 deletions(-)
commit f0c3fd8c9ab402be923fe0845fb51d99841829b6
@@ -47666,7 +46990,7 @@
Date: Fri Sep 9 16:22:45 2016 -0700
[GX] Add varStore member to GDEF
-
+
Still not hooked up from GPOS.
src/hb-ot-layout-gdef-table.hh | 17 ++++++++++++++---
@@ -47686,11 +47010,10 @@
Date: Fri Sep 9 15:40:15 2016 -0700
[GX] Port variation stuff to Variation Store design
-
+
Not hooked up to GDEF yet.
- src/hb-ot-layout-common-private.hh | 294
- +++++++++++++++++++++++--------------
+ src/hb-ot-layout-common-private.hh | 294 +++++++++++++++++++++++--------------
src/hb-ot-layout-gpos-table.hh | 2 +-
2 files changed, 184 insertions(+), 112 deletions(-)
@@ -47707,15 +47030,13 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Sep 9 13:17:33 2016 -0700
- [GX] Revert "[GX] Add VariationAlternates, to allow conditional
- lookups in GSUB/GPOS"
-
+ [GX] Revert "[GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS"
+
This reverts commit 2859f1c7174d6f7ae5dcf0db5411bc0182b21594.
We are going in a different direction.
src/hb-open-type-private.hh | 1 -
- src/hb-ot-layout-common-private.hh | 99
- +-------------------------------------
+ src/hb-ot-layout-common-private.hh | 99 +-------------------------------------
2 files changed, 2 insertions(+), 98 deletions(-)
commit bb4d2e6ed562c248fff15313a013d49e38a18789
@@ -47732,12 +47053,11 @@
Date: Fri Mar 18 15:52:24 2016 -0700
[GX] Add compact VariationDevice implementation
-
+
Add compact format that uses signed bytes instead of shorts.
src/hb-open-type-private.hh | 1 +
- src/hb-ot-layout-common-private.hh | 35
- ++++++++++++++++++++++++-----------
+ src/hb-ot-layout-common-private.hh | 35 ++++++++++++++++++++++++-----------
2 files changed, 25 insertions(+), 11 deletions(-)
commit 71b06fd392680b6fcfece60d8a83ba6c56eada09
@@ -47744,14 +47064,12 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Sat Mar 12 23:49:09 2016 -0800
- [GX] Add VariationAlternates, to allow conditional lookups in
- GSUB/GPOS
-
+ [GX] Add VariationAlternates, to allow conditional lookups in GSUB/GPOS
+
Not hooked up to runtime yet.
src/hb-open-type-private.hh | 1 +
- src/hb-ot-layout-common-private.hh | 99
- +++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-common-private.hh | 99 +++++++++++++++++++++++++++++++++++++-
2 files changed, 98 insertions(+), 2 deletions(-)
commit 976eeb8e025e2b7601a91e661d6e9a88bf8afbd2
@@ -47787,8 +47105,7 @@
[GX] Hookup VariationDevice to Device table implementation
- src/hb-ot-layout-common-private.hh | 65
- +++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-common-private.hh | 65 +++++++++++++++++++++++++++++++++++++-
1 file changed, 64 insertions(+), 1 deletion(-)
commit a0c2366075fcb894212b9bf137e4dd34bb65537c
@@ -47796,7 +47113,7 @@
Date: Tue Mar 1 19:42:24 2016 +0900
[GX] Break out early if factor is zero
-
+
Also disable sanity-checking of variation records.
src/hb-ot-layout-common-private.hh | 9 ++++++++-
@@ -47807,7 +47124,7 @@
Date: Tue Mar 1 19:29:36 2016 +0900
[GX] Towards anisotropic interpolation
-
+
Also hookup to ValueRecord and Anchors.
src/hb-font-private.hh | 5 +++--
@@ -47824,8 +47141,7 @@
src/hb-font-private.hh | 10 ++++
src/hb-font.cc | 3 +
- src/hb-ot-layout-common-private.hh | 113
- +++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout-common-private.hh | 113 +++++++++++++++++++++++++++++++++++++
3 files changed, 126 insertions(+)
commit b843c6d8b66c2833cd35407ee494546465e6d775
@@ -47843,7 +47159,7 @@
Date: Sun Dec 4 20:28:38 2016 -0800
[hb-fuzzer] Get glyph extents for output glyphs
-
+
To exercise glyph-extents codepaths (glyf / CBLC+CBDT).
test/fuzzing/hb-fuzzer.cc | 13 +++++++++++++
@@ -47856,8 +47172,7 @@
[CBDT] Add test for fetching glyph extents
test/shaping/Makefile.am | 1 +
- .../sha1sum/ee39587d13b2afa5499cc79e45780aa79293bbd4.ttf | Bin 0 ->
- 3724 bytes
+ .../sha1sum/ee39587d13b2afa5499cc79e45780aa79293bbd4.ttf | Bin 0 -> 3724 bytes
test/shaping/tests/color-fonts.tests | 1 +
3 files changed, 2 insertions(+)
@@ -47895,8 +47210,7 @@
[cbdt] Move some more code around
- src/hb-ot-cbdt-table.hh | 61
- ++++++++++++++++++++++++++++++++++---------------
+ src/hb-ot-cbdt-table.hh | 61 ++++++++++++++++++++++++++++++++++---------------
src/hb-ot-font.cc | 18 ++++++---------
2 files changed, 49 insertions(+), 30 deletions(-)
@@ -47905,7 +47219,7 @@
Date: Sun Dec 4 18:56:24 2016 -0800
[cbdt] Fix sign bug
-
+
Was introduced in d495fc5e38038f4cfb20425b1109324fa70bf2f9
src/hb-ot-cbdt-table.hh | 2 +-
@@ -47916,7 +47230,7 @@
Date: Fri Dec 2 22:43:05 2016 -0800
[cbdt] Last of sanitization fixes
-
+
Should be all good now..
src/hb-ot-font.cc | 23 ++++++++++++++++-------
@@ -47927,11 +47241,10 @@
Date: Fri Dec 2 21:36:42 2016 -0800
[cbdt] Clean up some more
-
+
Almost there..
- src/hb-ot-cbdt-table.hh | 134
- +++++++++++++++++++++++++++++++++++++++++++-----
+ src/hb-ot-cbdt-table.hh | 134 +++++++++++++++++++++++++++++++++++++++++++-----
src/hb-ot-font.cc | 38 ++++----------
2 files changed, 131 insertions(+), 41 deletions(-)
@@ -47941,8 +47254,7 @@
[cbdt] More sanitize work
- src/hb-ot-cbdt-table.hh | 65
- +++++++++++++++++++++++++++++--------------------
+ src/hb-ot-cbdt-table.hh | 65 +++++++++++++++++++++++++++++--------------------
src/hb-ot-font.cc | 46 ++++++++++++++++++----------------
2 files changed, 63 insertions(+), 48 deletions(-)
@@ -47961,8 +47273,7 @@
[cbdt] Start fixing sanitization (or lack thereof)
- src/hb-ot-cbdt-table.hh | 77
- ++++++++++++++++++++++++++++++++++++-------------
+ src/hb-ot-cbdt-table.hh | 77 ++++++++++++++++++++++++++++++++++++-------------
src/hb-ot-font.cc | 22 +++++++-------
2 files changed, 68 insertions(+), 31 deletions(-)
@@ -47992,14 +47303,13 @@
Date: Fri Dec 2 15:03:50 2016 -0800
Introduce get_extent support for color bitmap font. (#351)
-
+
hb_font_get_glyph_extents now works for color bitmap fonts.
Currently only font having index format 1 and image format 17
is supported.
src/Makefile.sources | 1 +
- src/hb-ot-ebdt-table.hh | 193
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-ebdt-table.hh | 193 ++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-font.cc | 96 ++++++++++++++++++++++++
3 files changed, 290 insertions(+)
@@ -48007,8 +47317,7 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Fri Oct 28 21:49:11 2016 +0330
- Fix "nmake install" when ADDITIONAL_LIB_DIR is provided and test it
- on CI (#356)
+ Fix "nmake install" when ADDITIONAL_LIB_DIR is provided and test it on CI (#356)
appveyor.yml | 1 +
win32/detectenv-msvc.mak | 4 ++--
@@ -48021,8 +47330,7 @@
[tests] Add tests for vertical origin with ft and ot font-funcs
- .../sha1sum/f9b1dd4dcb515e757789a22cb4241107746fd3d0.ttf | Bin 0 ->
- 1004 bytes
+ .../sha1sum/f9b1dd4dcb515e757789a22cb4241107746fd3d0.ttf | Bin 0 -> 1004 bytes
test/shaping/tests/vertical.tests | 2 ++
2 files changed, 2 insertions(+)
@@ -48059,8 +47367,7 @@
Fix vertical glyph origin with hb-ot-font
- src/hb-font-private.hh | 51
- ++++++++++++++++++++++++++++----------------------
+ src/hb-font-private.hh | 51 ++++++++++++++++++++++++++++----------------------
1 file changed, 29 insertions(+), 22 deletions(-)
commit b3b0816d5fc00298621f738cf400de60f8a42c5d
@@ -48068,7 +47375,7 @@
Date: Wed Oct 26 17:19:07 2016 +0200
Fix vertical font metrics
-
+
Ouch!
src/hb-font-private.hh | 4 ++--
@@ -48118,7 +47425,7 @@
Date: Tue Oct 25 00:31:36 2016 +0300
Merge pull request #352 from fred-wang/makefile-am
-
+
Remove inexistent file ttx file from test/api/Makefile.am
commit c3fa5d0e03b57be131c66ea8720806c946d0e10f
@@ -48136,7 +47443,7 @@
Date: Sat Oct 22 12:23:05 2016 +0330
Merge pull request #349 from ebraminio/mergebackvcpkgpatches
-
+
[ci] Enable hb-freetype on Windows build tests
commit 755a0c20798e3c3e6bb933a28e38f9667fccdadc
@@ -48164,7 +47471,7 @@
Date: Fri Oct 14 13:54:55 2016 +0330
Merge pull request #340 from ebraminio/nouniscribe
-
+
Make Uniscribe optional on nmake win32 builds
commit d8e2eb9ee0f47af7e90056d8db5949d10a88786a
@@ -48172,15 +47479,12 @@
Date: Sun Oct 9 09:06:05 2016 +0330
Make Uniscribe optional on nmake win32 builds
-
- Most of harfbuzz clients don't need Uniscribe and DirectWrite support
- at all
- as harfbuzz is a replacement for Uniscribe so Chromium and Firefox
- are using
+
+ Most of harfbuzz clients don't need Uniscribe and DirectWrite support at all
+ as harfbuzz is a replacement for Uniscribe so Chromium and Firefox are using
harfbuzz without them on Windows.
-
- This removal also helps win32 nmake clients to have reduced binary
- size and
+
+ This removal also helps win32 nmake clients to have reduced binary size and
libs count.
appveyor.yml | 2 +-
@@ -48195,7 +47499,7 @@
Date: Tue Oct 11 13:45:22 2016 -0700
Fix configure on iOS
-
+
Fixes https://github.com/behdad/harfbuzz/issues/342
configure.ac | 3 ++-
@@ -48207,7 +47511,7 @@
Date: Tue Oct 11 17:23:41 2016 +0330
Merge pull request #344 from ebraminio/fixmacci
-
+
[ci] Whitelist more symbols and unbreak mac CI
commit bef240b36ee9086b0d92e351e4c5118c0bbb5df6
@@ -48215,7 +47519,7 @@
Date: Mon Oct 10 17:27:52 2016 +0330
[ci] Whitelist more symbols and unbreak mac CI
-
+
Thanks to @khaledhosny, actually this is his work :)
src/check-symbols.sh | 4 ++--
@@ -48226,7 +47530,7 @@
Date: Tue Oct 4 14:53:17 2016 -0700
LFS (large file system?) support in hb-*shap*, hb-view
-
+
Fixes https://github.com/behdad/harfbuzz/issues/336
configure.ac | 3 +++
@@ -48277,7 +47581,7 @@
Date: Tue Sep 27 17:15:59 2016 +0200
Merge branch 'math'
-
+
Supercedes https://github.com/behdad/harfbuzz/pull/326
Fixes https://github.com/behdad/harfbuzz/pull/331
@@ -48296,7 +47600,7 @@
Date: Tue Sep 27 16:44:22 2016 +0200
[MATH] Rename hb_math_*_t types to hb_ot_math_*_t
-
+
With this, I believe MATH table API is not ready to be merged.
docs/harfbuzz-sections.txt | 6 +++---
@@ -48322,8 +47626,7 @@
Document API for MathVariants (#330)
- src/hb-ot-layout.cc | 56
- +++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout.cc | 56 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 56 insertions(+)
commit 8d622f1114d6a0eca1786b94c7fc1a0bcd87f74b
@@ -48332,8 +47635,7 @@
Add tests for get_mathvariant (#329)
- test/api/test-ot-math.c | 160
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-ot-math.c | 160 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 160 insertions(+)
commit f73a87d9a8c76a181794b74b527ea268048f78e3
@@ -48352,8 +47654,7 @@
Add tests for hb_ot_math_get_glyph_variants (#328)
- test/api/test-ot-math.c | 126
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-ot-math.c | 126 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 126 insertions(+)
commit f16bf6c2dacf5b9c82b2d1ffacc092cc396189a7
@@ -48378,12 +47679,9 @@
Author: Frédéric Wang <fred.wang at free.fr>
Date: Tue Sep 27 11:02:08 2016 +0200
- test-ot-math: Use different scales for vertical
- and horizontal directions and add test for
- hb_ot_math_get_min_connector_overlap. (#327)
+ test-ot-math: Use different scales for vertical and horizontal directions and add test for hb_ot_math_get_min_connector_overlap. (#327)
- test/api/test-ot-math.c | 81
- ++++++++++++++++++++++++++++++-------------------
+ test/api/test-ot-math.c | 81 ++++++++++++++++++++++++++++++-------------------
1 file changed, 49 insertions(+), 32 deletions(-)
commit bc19f7fe20e89823dba07a46c3d48c7406b781b6
@@ -48401,8 +47699,7 @@
[MATH] Enable tests for glyph-assembly italics-correction
- test/api/test-ot-math.c | 49
- ++++++++++++++++++++++++++++++-------------------
+ test/api/test-ot-math.c | 49 ++++++++++++++++++++++++++++++-------------------
1 file changed, 30 insertions(+), 19 deletions(-)
commit 86106c7528d9bff8de6bc3e1487be780c31ea4fd
@@ -48415,10 +47712,8 @@
src/hb-ot-layout.cc | 69 ++++----
src/hb-ot-math.h | 56 +++---
test/api/Makefile.am | 6 +-
- test/api/test-ot-layout-math.c | 382
- -----------------------------------------
- test/api/test-ot-math.c | 381
- ++++++++++++++++++++++++++++++++++++++++
+ test/api/test-ot-layout-math.c | 382 -----------------------------------------
+ test/api/test-ot-math.c | 381 ++++++++++++++++++++++++++++++++++++++++
6 files changed, 447 insertions(+), 457 deletions(-)
commit 1ba767cd4e3606beb9dc59806b83b1e61f5958d4
@@ -48427,10 +47722,8 @@
[MATH] Move API from hb-ot-layout.h to hb-ot-math.h
- src/hb-ot-layout.h | 52
- --------------------------------------------------
- src/hb-ot-math.h | 56
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-layout.h | 52 --------------------------------------------------
+ src/hb-ot-math.h | 56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot.h | 1 +
3 files changed, 57 insertions(+), 52 deletions(-)
@@ -48449,8 +47742,7 @@
[MATH] Wire up get_glyph_assembly()
- src/hb-ot-layout-math-table.hh | 64
- ++++++++++++++++++++++++++++++++++++++----
+ src/hb-ot-layout-math-table.hh | 64 ++++++++++++++++++++++++++++++++++++++----
src/hb-ot-layout.cc | 26 +++++++++--------
src/hb-ot-layout.h | 14 ++++-----
3 files changed, 81 insertions(+), 23 deletions(-)
@@ -48462,8 +47754,7 @@
[MATH] Wire up get_glyph_variants()
src/hb-font-private.hh | 11 ++-
- src/hb-ot-layout-math-table.hh | 178
- +++++++++++++++++++----------------------
+ src/hb-ot-layout-math-table.hh | 178 +++++++++++++++++++----------------------
src/hb-ot-layout.cc | 7 +-
src/hb-ot-layout.h | 2 +-
4 files changed, 95 insertions(+), 103 deletions(-)
@@ -48476,8 +47767,7 @@
src/hb-font-private.hh | 4 +++
src/hb-ot-layout-math-table.hh | 10 ++----
- src/hb-ot-layout.cc | 73
- +++++++++++++++---------------------------
+ src/hb-ot-layout.cc | 73 +++++++++++++++---------------------------
src/hb-ot-layout.h | 20 ++++++++++++
src/hb-ot-math.h | 18 +++++++++++
5 files changed, 71 insertions(+), 54 deletions(-)
@@ -48497,8 +47787,7 @@
MATH table: Add API to access math variants.
- src/hb-ot-layout-math-table.hh | 253
- +++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-math-table.hh | 253 +++++++++++++++++++++++++++++++-
src/hb-ot-layout-private.hh | 10 ++
src/hb-ot-layout.cc | 54 +++++++
test/api/fonts/MathTestFontPartial4.otf | Bin 0 -> 14360 bytes
@@ -48539,7 +47828,7 @@
Date: Mon Sep 26 12:18:32 2016 +0100
[MATH] Clean up get_top_accent_attachment()
-
+
Note, the function now returns "half of horizontal advance width"
if top accent attachment for glyph is not explicitly defined.
This is what the spec requires. Updated tests.
@@ -48568,8 +47857,7 @@
[MATH] Clean up a bit more
src/hb-ot-layout-math-table.hh | 12 +--------
- src/hb-ot-layout.cc | 57
- ++++++++++++++++--------------------------
+ src/hb-ot-layout.cc | 57 ++++++++++++++++--------------------------
2 files changed, 22 insertions(+), 47 deletions(-)
commit 54c0cc38fba24fa4370231408ba121589b190a28
@@ -48588,8 +47876,7 @@
[MATH] Cleanup previous commit a bit
- src/hb-ot-layout-math-table.hh | 186
- ++++++++++++++++++++---------------------
+ src/hb-ot-layout-math-table.hh | 186 ++++++++++++++++++++---------------------
src/hb-ot-layout.cc | 30 +++----
src/hb-ot-layout.h | 14 ++--
3 files changed, 113 insertions(+), 117 deletions(-)
@@ -48600,8 +47887,7 @@
MATH Table: Add API to access glyph info.
- src/hb-ot-layout-math-table.hh | 271
- +++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-math-table.hh | 271 +++++++++++++++++++++++++++++++-
src/hb-ot-layout.cc | 114 ++++++++++++++
src/hb-ot-layout.h | 18 +++
src/hb-ot-math.h | 7 +
@@ -48636,8 +47922,7 @@
MATH Table: Add API to access math contants.
src/Makefile.sources | 1 +
- src/hb-ot-layout-math-table.hh | 146
- +++++++++++++++++++++++++++++++++++-
+ src/hb-ot-layout-math-table.hh | 146 +++++++++++++++++++++++++++++++++++-
src/hb-ot-layout.cc | 25 ++++++
src/hb-ot-layout.h | 5 ++
src/hb-ot-math.h | 100 ++++++++++++++++++++++++
@@ -48672,8 +47957,7 @@
test/api/Makefile.am | 14 ++++-
test/api/fonts/MathTestFontEmpty.otf | Bin 0 -> 14320 bytes
test/api/fonts/MathTestFontNone.otf | Bin 0 -> 14284 bytes
- test/api/test-ot-layout-math.c | 98
- +++++++++++++++++++++++++++++++++++
+ test/api/test-ot-layout-math.c | 98 +++++++++++++++++++++++++++++++++++
9 files changed, 227 insertions(+), 1 deletion(-)
commit 02bfd965af588640250c47f344ad3096c8a373e0
@@ -48681,7 +47965,7 @@
Date: Mon Sep 12 10:22:15 2016 +0200
Update detectenv-msvc.mak (#316)
-
+
Windows x86 ARM capability
win32/detectenv-msvc.mak | 3 +++
@@ -48720,7 +48004,7 @@
Date: Wed Sep 7 23:56:57 2016 +0300
Do reconfigure the cascade list for Emoji font on OS X 10.9.5 (#313)
-
+
This seems to fix crash issues on 10.9.5 reported on Chrome, compare
crbug.com/549610
@@ -48732,7 +48016,7 @@
Date: Mon Sep 5 11:27:25 2016 +0300
Blacklist Padauk 2.80 and 3.00 (#311)
-
+
According to comments in issue #305 broken GDEF tables lead
to incorrect rendering of Latin characters. Blacklisting
this font.
@@ -48784,7 +48068,7 @@
Date: Thu Aug 18 22:33:14 2016 +0200
Merge pull request #303 from behdad/fonnapa
-
+
Support Americanist Phonetic Notation
commit e7ecbba2cc3c9369c5e7dc7296cb210018aca3bb
@@ -48792,10 +48076,10 @@
Date: Thu Aug 18 12:48:38 2016 +0200
Support Americanist Phonetic Notation
-
+
OpenType language system tag: `APPH`
https://www.microsoft.com/typography/otspec/languagetags.htm
-
+
IETF BCP47 variant tag: `fonnapa`
http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
@@ -48809,7 +48093,7 @@
Date: Thu Aug 18 13:59:38 2016 +0200
Merge pull request #302 from khaledhosny/master
-
+
[travis] Fix MacOS libtool issue
commit a0f1b44b6c0e3b1e6a1ba63dde2be22e0425353f
@@ -48826,7 +48110,7 @@
Date: Tue Aug 16 02:49:48 2016 +0200
[travis] Fix MacOS libtool issue
-
+
Reveals another MacOS build breakage in the Core Text shaper.
.travis.yml | 1 +
@@ -48855,13 +48139,11 @@
Date: Mon Aug 8 18:06:09 2016 -0700
Add tests for Chinese language tags
-
+
Using font from https://github.com/behdad/harfbuzz/issues/300
- .../sha1sum/6991b13ce889466be6de3f66e891de2bc0f117ee.ttf | Bin 0 ->
- 5596 bytes
- test/shaping/tests/language-tags.tests | 12
- ++++++++++++
+ .../sha1sum/6991b13ce889466be6de3f66e891de2bc0f117ee.ttf | Bin 0 -> 5596 bytes
+ test/shaping/tests/language-tags.tests | 12 ++++++++++++
2 files changed, 12 insertions(+)
commit 37f21bdbb75c98d741e749b7f1e0f367941aef4e
@@ -48869,7 +48151,7 @@
Date: Mon Aug 8 17:57:06 2016 -0700
Map Macao to ZHH lang tag
-
+
Fixes https://github.com/behdad/harfbuzz/issues/300
src/hb-ot-tag.cc | 3 ++-
@@ -48880,10 +48162,9 @@
Date: Mon Aug 8 17:28:54 2016 -0700
Limit bits-per-feature to eight
-
+
Limits number of alternatives per glyph per feature to 255, so be it.
- That's better than possibly breaking shaping because of one bad
- feature
+ That's better than possibly breaking shaping because of one bad feature
value.
src/hb-ot-map.cc | 3 ++-
@@ -48894,14 +48175,14 @@
Date: Mon Aug 8 17:24:04 2016 -0700
Fix sign of shift operators
-
+
This one:
-
+
map->mask = (1 << (next_bit + bits_needed)) - (1 << next_bit);
-
+
before the fix, the shift was done as an int, causing overflow
if it ever got to 1 << 31. Sprinkle 'u's around.
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=634805
src/hb-buffer-private.hh | 6 +++---
@@ -48921,7 +48202,7 @@
Date: Mon Aug 8 16:51:08 2016 -0700
Map zh-Hant-HK to ZHH
-
+
Fixes https://github.com/behdad/harfbuzz/issues/300
src/hb-ot-tag.cc | 4 +++-
@@ -48932,7 +48213,7 @@
Date: Fri Jul 22 02:26:54 2016 +0300
Don’t build UCDN support when building with GLib (#296)
-
+
Regression from: b424b6c372dfe4c0ed75a49761eb34a416819446.
configure.ac | 2 +-
@@ -48943,7 +48224,7 @@
Date: Fri Jul 22 17:41:43 2016 -0700
[coretext] "Fix" crashes on CoreText < 10.10
-
+
Fixes https://github.com/behdad/harfbuzz/issues/297
src/hb-coretext.cc | 8 ++++++++
@@ -48964,7 +48245,7 @@
Date: Thu Jul 21 01:23:33 2016 -0700
[ucdn] Update to Unicode 9.0.0
-
+
Fixes https://github.com/grigorig/ucdn/issues/12
src/hb-ucdn.cc | 6 +
@@ -48971,8 +48252,7 @@
src/hb-ucdn/README | 1 -
src/hb-ucdn/ucdn.c | 80 +-
src/hb-ucdn/ucdn.h | 98 +-
- src/hb-ucdn/unicodedata_db.h | 4750
- +++++++++++++++++++++++-------------------
+ src/hb-ucdn/unicodedata_db.h | 4750 +++++++++++++++++++++++-------------------
5 files changed, 2783 insertions(+), 2152 deletions(-)
commit f3f6c1ccbf89e15cda03e0c3a2df4297e98adf60
@@ -48980,21 +48260,16 @@
Date: Thu Jun 16 00:10:42 2016 +0100
Blacklist GDEF tables of more fonts
-
- This is based on bug reports that have been filed against Firefox
- since it
- updated to a version of harfbuzz that uses zeroing by GDEF rather
- than by
- Unicode. I'm sure there are a bunch more font versions that should
- also be
- included; these are just the ones I have on hand and have confirmed
- as having
+
+ This is based on bug reports that have been filed against Firefox since it
+ updated to a version of harfbuzz that uses zeroing by GDEF rather than by
+ Unicode. I'm sure there are a bunch more font versions that should also be
+ included; these are just the ones I have on hand and have confirmed as having
bad GDEF data.
-
- Given how the list here is growing, I think we should reconsider
- the approach,
+
+ Given how the list here is growing, I think we should reconsider the approach,
and perhaps revert to zeroing by Unicode instead.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/264
Fixes https://github.com/behdad/harfbuzz/pull/266
@@ -49006,7 +48281,7 @@
Date: Wed Jul 20 02:35:54 2016 -0700
Implement symbol cmap in ft and ot fonts
-
+
Fixes https://github.com/behdad/harfbuzz/issues/236
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=627953
@@ -49019,7 +48294,7 @@
Date: Wed Jul 20 01:43:56 2016 -0700
Clean up buffer area when rewinding
-
+
Fixes https://bugs.chromium.org/p/chromium/issues/detail?id=614647
If allocation fails, we might be leaving junk behind. At least
clear it up.
@@ -49049,13 +48324,10 @@
Author: Birunthan Mohanathas <birunthan at mohanathas.com>
Date: Mon Jul 11 13:38:23 2016 -0700
- [ft] Fix unsafe cast of FT_Done_Face in
- hb_ft_{face,font}_create_referenced (#289)
-
- Prior to this change the function `FT_Error FT_Done_Face(FT_Face
- *)` was
- called through a pointer with the signature `void (void *)`
- resulting in
+ [ft] Fix unsafe cast of FT_Done_Face in hb_ft_{face,font}_create_referenced (#289)
+
+ Prior to this change the function `FT_Error FT_Done_Face(FT_Face *)` was
+ called through a pointer with the signature `void (void *)` resulting in
undefined behaviour.
src/hb-ft.cc | 12 +++++++++---
@@ -49076,7 +48348,7 @@
Date: Fri Jul 1 17:09:28 2016 -0700
Merge pull request #286 from khaledhosny/gi-tag_from_string
-
+
[introspection] Fix hb_tag_from_string annotation
commit e4d451ee55a57e1231b4076fcd1e87994f6b9528
@@ -49093,7 +48365,7 @@
Date: Thu Jun 30 11:01:22 2016 -0700
[python] Use utf-32 / utf-16 based on build of Python
-
+
Fixes https://github.com/behdad/harfbuzz/pull/271
src/sample.py | 22 +++++++++++++++++++++-
@@ -49114,7 +48386,7 @@
Date: Thu Jun 30 09:41:03 2016 -0700
Merge pull request #268 from drott/conflictingFontFix
-
+
Discard reconfigured CTFont if URL changes
commit 1bea49eb4b7a94ab6222f9c3c40320cbdb247b2d
@@ -49129,7 +48401,7 @@
Date: Tue Jun 28 21:00:37 2016 -0700
[gobject] Fix a few warnings
-
+
Part of https://github.com/behdad/harfbuzz/issues/277
src/hb-buffer.cc | 2 +-
@@ -49144,7 +48416,7 @@
Date: Tue Jun 28 21:15:28 2016 -0700
Merge pull request #280 from behdad/revert-271-patch-2
-
+
Revert "use utf32"
commit ae9054c740631e36b7582b44c5afb42ff4509461
@@ -49169,7 +48441,7 @@
Date: Mon Jun 27 14:33:27 2016 -0400
Merge pull request #273 from ebraminio/master
-
+
[dwrite] Use stream font loader instead GDI interop
commit 8179ff5d7ba4a140cf6743729a22072800e98a79
@@ -49177,7 +48449,7 @@
Date: Mon Jun 27 03:54:15 2016 +0430
[dwrite] Don't allocate more than needed
-
+
Addressing Nikolay Sivov reviews on harfbuzz mailing list
src/hb-directwrite.cc | 15 ++++++---------
@@ -49188,11 +48460,11 @@
Date: Fri Jun 24 16:42:27 2016 +0200
[CPAL] Return 0xFFFF as name id for unnamed palettes
-
+
The name id 0 is used as Copyright notice. It's quite unlikely that a
font supplies a color palette with the exact same name as the font's
copyright notice, but the API should not prevent this.
-
+
Also, try to fix a problem with GObject introspection, where the
auto-generated Python bindings could not return palette colors.
@@ -49205,7 +48477,7 @@
Date: Fri Jun 24 12:23:25 2016 +0430
[dwrite] Delete remained objects
-
+
No longer noticeable memory increase on create/destroy iterations,
highly better than current state of uniscribe backend
@@ -49217,9 +48489,8 @@
Date: Fri Jun 24 11:42:01 2016 +0430
[dwrite] Release allocated blob on face destroy
-
- This reduces memory consumption of my iterated font create/destroy
- cycle test
+
+ This reduces memory consumption of my iterated font create/destroy cycle test
significantly and makes it much better than uniscribe backend even
src/hb-directwrite.cc | 5 ++++-
@@ -49229,11 +48500,9 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Thu Jun 23 16:41:37 2016 +0430
- [dwrite] Remove ifdefs without breaking execution on old Windows
- versions
+ [dwrite] Remove ifdefs without breaking execution on old Windows versions
- src/hb-directwrite.cc | 205
- +++++++++++++++++++++++++-------------------------
+ src/hb-directwrite.cc | 205 +++++++++++++++++++++++++-------------------------
1 file changed, 103 insertions(+), 102 deletions(-)
commit 6b861dbd8b3662d0fa0e51fad1736d72192da868
@@ -49241,12 +48510,11 @@
Date: Tue Jun 21 13:57:26 2016 +0430
[dwrite] Use stream font loader instead GDI interop
-
+
With help of
https://dxr.mozilla.org/mozilla-central/source/gfx/2d/NativeFontResourceDWrite.cpp
- src/hb-directwrite.cc | 350
- +++++++++++++++++++-------------------------------
+ src/hb-directwrite.cc | 350 +++++++++++++++++++-------------------------------
src/hb-directwrite.h | 2 +-
2 files changed, 135 insertions(+), 217 deletions(-)
@@ -49274,8 +48542,7 @@
src/hb-ot.h | 1 +
test/api/Makefile.am | 1 +
test/api/hb-test.h | 30 ++
- test/api/test-ot-color.c | 318
- +++++++++++++++++++++
+ test/api/test-ot-color.c | 318 +++++++++++++++++++++
.../319f5d7ebffbefc5c5e6569f8cea73444d7a7268.ttf | Bin 0 -> 2128 bytes
.../e90374e5e439e00725b4fe7a8d73db57c5a97f82.ttf | Bin 0 -> 1948 bytes
14 files changed, 804 insertions(+), 1 deletion(-)
@@ -49295,7 +48562,7 @@
Date: Sun Jun 19 00:08:51 2016 +0300
Merge pull request #270 from khaledhosny/travis-failure
-
+
Fix make check on Travis
commit 988350586f607c7a46bbb658a2abecfd004f41fb
@@ -49303,12 +48570,11 @@
Date: Sat Jun 18 21:12:19 2016 +0200
[tests] Workaround Python 2 “narrow” builds
-
- The so-called Python 2 “narrow” builds support UCS2 only, this
- is a
+
+ The so-called Python 2 “narrow” builds support UCS2 only, this is a
workaround to allow unichr to work with any Unicode character in such
builds. This fixes Travis-CI failure as it has narrow Python 2 builds.
-
+
Copied from:
https://github.com/behdad/fonttools/blob/master/Lib/fontTools/misc/py23.py
@@ -49320,7 +48586,7 @@
Date: Thu Jun 16 14:19:39 2016 +0200
Discard reconfigured CTFont if URL changes
-
+
Fixes https://github.com/behdad/harfbuzz/issues/267
src/hb-coretext.cc | 24 +++++++++++++++++++++---
@@ -49331,7 +48597,7 @@
Date: Mon Jun 6 23:08:54 2016 -0700
Round, not truncate, when scaling values
-
+
Fixes https://github.com/behdad/harfbuzz/issues/255
src/hb-font-private.hh | 8 +++++++-
@@ -49342,7 +48608,7 @@
Date: Mon Jun 6 15:58:41 2016 -0700
Change bugreport URL to github
-
+
That's where everything is happening these days.
configure.ac | 2 +-
@@ -49373,7 +48639,7 @@
Date: Fri May 6 17:56:07 2016 +0100
[myanmar] Handle U+AA74..U+AA76
-
+
Fixes https://github.com/behdad/harfbuzz/issues/218
src/hb-ot-shape-complex-myanmar.cc | 5 +++++
@@ -49397,8 +48663,7 @@
src/gen-use-table.py | 29 +++--
src/hb-ot-shape-complex-use-machine.rl | 15 +--
src/hb-ot-shape-complex-use-private.hh | 1 -
- src/hb-ot-shape-complex-use-table.cc | 142
- ++++++++++-----------
+ src/hb-ot-shape-complex-use-table.cc | 142 ++++++++++-----------
src/hb-ot-shape-complex-use.cc | 11 +-
.../6ff0fbead4462d9f229167b4e6839eceb8465058.ttf | Bin 0 -> 1148 bytes
test/shaping/tests/use.tests | 1 +
@@ -49419,7 +48684,7 @@
Date: Fri May 6 17:17:00 2016 +0100
[use] Fix 'Number-joiner terminated cluster' to use HN instead of H
-
+
From draft update to USE.
src/hb-ot-shape-complex-use-machine.rl | 2 +-
@@ -49430,9 +48695,9 @@
Date: Fri May 6 16:19:19 2016 +0100
Allow MultipleSubst to delete glyph
-
+
Fixes https://github.com/behdad/harfbuzz/issues/253
-
+
Hopefully we got the logic right.
src/hb-ot-layout-gsub-table.hh | 17 +++++++----------
@@ -49445,8 +48710,7 @@
[indic] Remove more unused logic after Javanese is gone
- src/hb-ot-shape-complex-indic.cc | 50
- +++++++++++++++-------------------------
+ src/hb-ot-shape-complex-indic.cc | 50 +++++++++++++++-------------------------
1 file changed, 18 insertions(+), 32 deletions(-)
commit 8b5d6e755b271d0d22b31a7726d5bfbf2aae8b2f
@@ -49465,23 +48729,22 @@
Date: Fri May 6 15:52:27 2016 +0100
[indic/use] Move Javanese from Indic shaper to USE
-
+
Fixes https://github.com/behdad/harfbuzz/issues/243
-
+
With javatext.ttf, the reodering medial Ra gets its advance width
zero'ed in Uniscribe implementation, and the font adds the advance
back. Our Indic shaper does not do that, but USE does. So, route
Javanese through USE. That's what Microsoft does anyway. Test:
-
+
U+A9A5,U+A9BA
-
+
This also seems to fix the following sequence, and variations thereof:
-
+
U+A99F,U+A9C0,U+A9A2,U+A9BF
src/gen-indic-table.py | 1 -
- src/hb-ot-shape-complex-indic-table.cc | 23
- ++++------------------
+ src/hb-ot-shape-complex-indic-table.cc | 23 ++++------------------
src/hb-ot-shape-complex-private.hh | 5 +----
.../south-east-asian/script-javanese/misc.txt | 1 +
4 files changed, 6 insertions(+), 24 deletions(-)
@@ -49492,8 +48755,7 @@
Add Javanese sample text
- .../south-east-asian/script-javanese/misc.txt | 53
- ++++++++++++++++++++++
+ .../south-east-asian/script-javanese/misc.txt | 53 ++++++++++++++++++++++
1 file changed, 53 insertions(+)
commit e21921a68a959b7e929f71a4260a6cbe055ab4e6
@@ -49512,8 +48774,7 @@
[indic] Remove data for scripts that don't go thorough this shaper
src/gen-indic-table.py | 29 +-
- src/hb-ot-shape-complex-indic-table.cc | 604
- +--------------------------------
+ src/hb-ot-shape-complex-indic-table.cc | 604 +--------------------------------
2 files changed, 43 insertions(+), 590 deletions(-)
commit 7cd9269f4eba7b85cd72301a3fc39fab42a4e439
@@ -49521,12 +48782,11 @@
Date: Fri May 6 11:34:46 2016 +0100
Update tables to Unicode 9.0.0 beta
-
+
Fixes https://github.com/behdad/harfbuzz/issues/251
src/hb-ot-shape-complex-arabic-table.hh | 56 ++++++++-----
- src/hb-ot-shape-complex-indic-table.cc | 137
- +++++++++++++++++++++++---------
+ src/hb-ot-shape-complex-indic-table.cc | 137 +++++++++++++++++++++++---------
src/hb-ot-shape-complex-use-table.cc | 86 ++++++++++++++------
3 files changed, 196 insertions(+), 83 deletions(-)
@@ -49544,7 +48804,7 @@
Date: Fri May 6 12:08:18 2016 +0100
Add Unicode 9 beta scripts
-
+
These are frozen, so good time to add.
src/hb-common.cc | 3 +++
@@ -49577,7 +48837,7 @@
Date: Mon May 2 10:29:12 2016 +0200
[ot-font] Remove unused 'post' table include for now
-
+
To make a release...
src/hb-ot-font.cc | 2 +-
@@ -49589,10 +48849,8 @@
[tests] Fix test
- test/shaping/Makefile.am |
- 2 +-
- .../tests/{fallback-positioning.test => fallback-positioning.tests}
- | 0
+ test/shaping/Makefile.am | 2 +-
+ .../tests/{fallback-positioning.test => fallback-positioning.tests} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
commit f00ab2a33ab34ba64f38cbbe65830c770a3e071e
@@ -49600,15 +48858,12 @@
Date: Mon May 2 10:24:00 2016 +0200
[hb-ot-font] Make 'glyf' table loading lazy
-
- Apparently some clients have reference-table callbacks that copy
- the table.
- As such, avoid loading 'glyf' table which is only needed if fallback
- positioning
+
+ Apparently some clients have reference-table callbacks that copy the table.
+ As such, avoid loading 'glyf' table which is only needed if fallback positioning
happens.
- src/hb-ot-font.cc | 45
- ++++++++++++++++++++-
+ src/hb-ot-font.cc | 45 ++++++++++++++++++++-
test/shaping/Makefile.am | 1 +
.../7ef276fc886ea502a03b9b0e5c8b547d5dc2b61c.ttf | Bin 0 -> 784 bytes
test/shaping/tests/fallback-positioning.test | 2 +
@@ -49623,8 +48878,7 @@
src/Makefile.sources | 1 +
src/hb-open-type-private.hh | 12 ++++-
src/hb-ot-font.cc | 1 +
- src/hb-ot-post-table.hh | 119
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-post-table.hh | 119 ++++++++++++++++++++++++++++++++++++++++++++
4 files changed, 132 insertions(+), 1 deletion(-)
commit 9abaaac409b8e3a0a9182b67dc384133013f7878
@@ -49639,9 +48893,9 @@
Date: Wed Apr 27 03:11:41 2016 -0700
[tibetan] Reorder marks to better match Uniscribe
-
+
Fixes https://github.com/behdad/harfbuzz/issues/237
-
+
Note that Uniscribe enforces a certain syllable order. We don't.
But with this change, I get all of the tibetan contractions pass
with Microsoft Himalaya font.
@@ -49654,11 +48908,10 @@
Date: Wed Apr 27 02:44:35 2016 -0700
[test] Add text for Tibetan shorthand contractions
-
+
From http://www.babelstone.co.uk/Tibetan/Contractions.html
- .../script-tibetan/misc/contractions.txt | 612
- +++++++++++++++++++++
+ .../script-tibetan/misc/contractions.txt | 612 +++++++++++++++++++++
1 file changed, 612 insertions(+)
commit 264b7a728a41becfbf23ce258fc2a3af19d0cbbe
@@ -49667,7 +48920,7 @@
Date: Wed Apr 27 03:48:23 2016 +0300
Merge pull request #247 from khaledhosny/update-opentype-language-tags
-
+
Update opentype language tags
commit adafdcddced076da4bfa3114a00e15a387aaf1f7
@@ -49676,8 +48929,7 @@
Mass-added “difficult” tags – to be curated.
- src/hb-ot-tag.cc | 69
- +++++++++++++++++++++++++++++---------------------------
+ src/hb-ot-tag.cc | 69 +++++++++++++++++++++++++++++---------------------------
1 file changed, 36 insertions(+), 33 deletions(-)
commit 3d6a2c0d7d9f6c5b3097f78c1123f9e59dcc76e2
@@ -49686,8 +48938,7 @@
Initial import of missing OpenType 1.7 language tags.
- src/hb-ot-tag.cc | 67
- +++++++++++++++++++++++++++++++++++++++++++++++++++-----
+ src/hb-ot-tag.cc | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 61 insertions(+), 6 deletions(-)
commit 7e2da035f68e46ce8f4759b67b4ed3a1b211d793
@@ -49704,12 +48955,11 @@
Date: Tue Apr 26 16:41:17 2016 -0700
Do NOT ignore Mongolian Free Variation Selectors during matching
-
+
Fixes https://github.com/behdad/harfbuzz/issues/234
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
- src/hb-ot-layout-private.hh | 23
- +++++++++++++++++++--
+ src/hb-ot-layout-private.hh | 23 +++++++++++++++++++--
src/hb-ot-shape-complex-arabic.cc | 2 +-
.../a34a7b00f22ffb5fd7eef6933b81c7e71bc2cdfb.ttf | Bin 0 -> 3700 bytes
.../tests/mongolian-variation-selector.tests | 1 +
@@ -49720,7 +48970,7 @@
Date: Tue Apr 26 16:02:04 2016 -0700
Move ZWJ/ZWNJ bits to top byte of unicode_props()
-
+
To make room to remember Mongolian Free Variation Selectors.
Part of fixing https://github.com/behdad/harfbuzz/issues/234
@@ -49751,7 +49001,7 @@
Date: Tue Apr 26 11:38:16 2016 +0200
Merge pull request #245 from KonstantinRitt/fixes/ce
-
+
Unbreak build on Windows CE
commit 5069062d0a9342bb716eebf3ddc1efad91924caa
@@ -49759,7 +49009,7 @@
Date: Tue Apr 26 12:02:26 2016 +0400
Unbreak build on Windows CE
-
+
0475ef2f97e3035a2eea9a0f96031331e07e8e29 broke the build by using
vsnprintf(), which is not defined on Windows CE
@@ -49809,7 +49059,7 @@
Date: Fri Apr 8 13:16:33 2016 -0700
Merge pull request #239 from ebraminio/dwfix
-
+
Improve DirectWrite backend
commit d3134a66ad551ded726db9528d3c25459088f105
@@ -49838,8 +49088,7 @@
Add test for 6dd80faf0dcb3e8a8915c3a25da44e2a67cb0cd8
test/shaping/Makefile.am | 1 +
- .../f22416c692720a7d46fadf4af99f4c9e094f00b9.ttf | Bin 0 ->
- 16736 bytes
+ .../f22416c692720a7d46fadf4af99f4c9e094f00b9.ttf | Bin 0 -> 16736 bytes
test/shaping/tests/mark-filtering-sets.tests | 5 +++++
3 files changed, 6 insertions(+)
@@ -49857,9 +49106,9 @@
Date: Mon Apr 4 14:34:25 2016 -0700
Fix FixedVersion::to_int()
-
+
Ouch. Had broken it in 9a13ed453ef96822a47d6e6f58332b87f38d5c59
-
+
Fixes https://github.com/behdad/harfbuzz/issues/238
Will add test soon.
@@ -49881,8 +49130,7 @@
Use standard types instead Windows favourites ones
- src/hb-directwrite.cc | 100
- +++++++++++++++++++++++++-------------------------
+ src/hb-directwrite.cc | 100 +++++++++++++++++++++++++-------------------------
1 file changed, 50 insertions(+), 50 deletions(-)
commit adf20ba0d18d1506e633dcd9b4827a6c93abcadd
@@ -49889,11 +49137,9 @@
Author: Ebrahim Byagowi <ebrahim at gnu.org>
Date: Fri Apr 1 15:36:40 2016 +0000
- Limit GetJustifiedGlyphs only to scripts with custom justification
- character
+ Limit GetJustifiedGlyphs only to scripts with custom justification character
- src/hb-directwrite.cc | 98
- +++++++++++++++++++++++++++++++--------------------
+ src/hb-directwrite.cc | 98 +++++++++++++++++++++++++++++++--------------------
1 file changed, 60 insertions(+), 38 deletions(-)
commit 32ae9d1b3ffbe7e26e654437a56a26a95fe9f5a6
@@ -49902,8 +49148,7 @@
Add justification support
- src/hb-directwrite.cc | 321
- ++++++++++++++++++++++++++++++++------------------
+ src/hb-directwrite.cc | 321 ++++++++++++++++++++++++++++++++------------------
1 file changed, 205 insertions(+), 116 deletions(-)
commit 10c3d9e41520595c88dd2a8321590e03ce8fcf47
@@ -49912,8 +49157,7 @@
Basic opentype features support
- src/hb-directwrite.cc | 62
- ++++++++++++++++++++++++++++++++++-----------------
+ src/hb-directwrite.cc | 62 ++++++++++++++++++++++++++++++++++-----------------
1 file changed, 42 insertions(+), 20 deletions(-)
commit d129897120d3ad414220d603557c15a60aa69fa6
@@ -49922,8 +49166,7 @@
Refactor and remove dupe getglyphs call
- src/hb-directwrite.cc | 106
- ++++++++++++++++++++++++--------------------------
+ src/hb-directwrite.cc | 106 ++++++++++++++++++++++++--------------------------
1 file changed, 51 insertions(+), 55 deletions(-)
commit 5f1a8961008b93f72acc47336109af3a64e248d0
@@ -49949,7 +49192,7 @@
Date: Wed Mar 30 20:15:09 2016 +0000
Make DirectWrite backend to work with different font sizes
-
+
Actually copyedited same logic from Uniscribe to make it just work
src/hb-directwrite.cc | 7 ++++++-
@@ -49969,43 +49212,40 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Mar 17 11:59:43 2016 -0700
- Synthesize GDEF glyph class for any glyph that does not have one
- in GDEF
-
+ Synthesize GDEF glyph class for any glyph that does not have one in GDEF
+
Previously we only synthesized GDEF glyph classes if the glyphClassDef
array in GDEF was null. This worked well enough, and is indeed what
- OpenType requires: "If the font does not include a GlyphClassDef
- table,
+ OpenType requires: "If the font does not include a GlyphClassDef table,
the client must define and maintain this information when using the
GSUB and GPOS tables." That sentence does not quite make sense since
one needs Unicode properties as well, but is close enough.
-
+
However, looks like Arial Unicode as shipped on WinXP, does have GDEF
glyph class array, but defines no classes for Hebrew. This results
- in Hebrew marks not getting their widths zeroed. So, with this
- change,
+ in Hebrew marks not getting their widths zeroed. So, with this change,
we synthesize glyph class for any glyph that is not specified in the
GDEF glyph class table. Since, from our point of view, a glyph not
being listed in that table is a font bug, any unwanted consequence of
this change is a font bug :).
-
+
Note that we still don't get the same rendering as Uniscribe, since
Uniscribe seems to do fallback positioning as well, even though the
font does have a GPOS table (which does NOT cover Hebrew!). We are
not going to try to match that though.
-
+
Test string for Arial Unicode:
-
+
U+05E9,U+05B8,U+05C1,U+05DC
-
+
Before: [gid1166=3+991|gid1142=0+737|gid5798=0+1434]
After: [gid1166=3+991|gid1142=0+0|gid5798=0+1434]
Uniscribe: [gid1166=3+991|gid1142=0 at 348,0+0|gid5798=0+1434]
-
+
Note that our new output matches what we were generating until July
2014, because the Hebrew shaper used to zero mark advances based on
Unicode, NOT GDEF. That's 9e834e29e0b657f0555df1ab9cea79ff7abcf08d.
-
+
Reported by Greg Douglas.
src/hb-ot-layout-gsub-table.hh | 22 ++++++++++++++++++++--
@@ -50018,7 +49258,7 @@
Date: Sat Mar 12 19:15:15 2016 -0800
Merge pull request #232 from c0nk/wip-icu
-
+
Add --with-icu=builtin option; fix compile error
commit 01ea9eaac373d9f3de6e56c1ca26cdcd259ecc8e
@@ -50026,7 +49266,7 @@
Date: Fri Mar 11 18:50:02 2016 -0800
[build] Use tar-ustar instead of tar-pax
-
+
The default tar-v7 is not good enough for us (99 char filename
limit), so I have had bumped to tar-pax. We got one complaint
that someone's tar couldn't handle tar-pax. Set to tar-ustar
@@ -50049,7 +49289,7 @@
Date: Tue Mar 8 12:16:41 2016 -0800
Remove default clause in minor switch statements
-
+
Bending to clang warnings...
https://bugs.chromium.org/p/chromium/issues/detail?id=593057
@@ -50063,7 +49303,7 @@
Date: Fri Mar 4 17:20:35 2016 -0800
Merge pull request #231 from KonstantinRitt/post123buildfix
-
+
Fix build with HB_DISABLE_DEPRECATED
commit 731a430cd36caabcef04e099b21ebc6daedd536f
@@ -50071,16 +49311,16 @@
Date: Wed Mar 2 13:32:42 2016 -0800
Fix requiredFeature stage handling logic
-
+
Originally the way Jonathan had written this was correct in
"continue"ing:
-
+
https://github.com/jfkthame/harfbuzz/commit/35e28c7a733eaffcd9f062b18d7db9fbb3d990fc#diff-ead86a33a5cc9ad7f6e6381031a0baddR199
-
+
When I rewrote his patch, I messed it up:
-
+
https://github.com/behdad/harfbuzz/commit/da132937989acb4d8ca9bd41c79f98750e7dda30#diff-ead86a33a5cc9ad7f6e6381031a0baddR209
-
+
the intended behavior was NOT to set found=TRUE and NOT to continue.
This was resulting in feature_index[table_index] being left unset.
Oops!
@@ -50102,7 +49342,7 @@
Date: Tue Mar 1 16:41:26 2016 +0900
Use FWORD and UFWORD when it makes sense
-
+
I had forgotten about those types.
src/hb-ot-glyf-table.hh | 8 ++++----
@@ -50114,7 +49354,7 @@
Date: Fri Feb 26 00:36:17 2016 +0100
Fix missing ICU #include
-
+
Fix compile error in hb-icu.cc when ICU configured with
U_NO_DEFAULT_INCLUDE_UTF_HEADERS=1
@@ -50136,7 +49376,7 @@
Date: Thu Feb 25 18:55:28 2016 +0400
Fix build with HB_DISABLE_DEPRECATED
-
+
When HB_DISABLE_DEPRECATED is defined, no code from hb-deprecated.h
should be used, even from within HB itself.
@@ -50148,15 +49388,13 @@
Date: Thu Feb 25 14:40:09 2016 +0900
Speed up buffer variable allocation sanity check
-
+
This makes defining HB_NDEBUG much less relevant, to the
point of irrelevance. Sorry about all the fuss in previous
release!
- src/hb-buffer-private.hh | 67
- ++++++++++++++++++++++++++++-----------------
- src/hb-buffer.cc | 70
- ------------------------------------------------
+ src/hb-buffer-private.hh | 67 ++++++++++++++++++++++++++++-----------------
+ src/hb-buffer.cc | 70 ------------------------------------------------
2 files changed, 43 insertions(+), 94 deletions(-)
commit 91dd11565221bdb108c138662ea013aac14bb968
@@ -50164,16 +49402,16 @@
Date: Thu Feb 25 13:56:47 2016 +0900
Add HB_NDEBUG
-
+
API changes:
- If NDEBUG is defined, define HB_NDEBUG
- Disable costlier sanity checks if HB_NDEBUG is defined.
-
+
In 1.2.3 introduced some code to disable costly sanity checks if
NDEBUG is defined. NDEBUG, however, disables all assert()s as
well. With HB_NDEBUG, one can disable costlier checks but keep
assert()s.
-
+
I'll probably add a way to define HB_NDEBUG automatically in
release tarballs. But for now, production systems that do NOT
define NDEBUG, are encouraged to define HB_NDEBUG for our build.
@@ -50199,7 +49437,7 @@
Date: Thu Feb 25 12:23:02 2016 +0900
Disable internal buffer variable bookkeeping in NDEBUG builds
-
+
Saves some sweet time and binary size!
src/Makefile.am | 1 +
@@ -50221,7 +49459,7 @@
Date: Thu Feb 25 11:20:05 2016 +0900
[test] Pass closure to hb_font_set_glyph_func()
-
+
Exercises fix in c335fd7986fe360ab8e1c032c9b988d0d30511eb
test/api/test-shape.c | 2 +-
@@ -50232,7 +49470,7 @@
Date: Thu Feb 25 11:11:15 2016 +0900
Blacklist GDEF table of timesi.ttf and timesbi.ttf on Win 7
-
+
See discussion:
https://lists.freedesktop.org/archives/harfbuzz/2016-February/005489.html
@@ -50243,8 +49481,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Feb 25 09:16:05 2016 +0900
- In trampoline implementation of get_glyph(), don't destroy user
- data twice!
+ In trampoline implementation of get_glyph(), don't destroy user data twice!
src/hb-font.cc | 41 +++++++++++++++++++++++++++--------------
1 file changed, 27 insertions(+), 14 deletions(-)
@@ -50255,8 +49492,7 @@
[ot-font] Accelerate cmap format4 get_glyph
- src/hb-ot-cmap-table.hh | 111
- ++++++++++++++++++++++++++++--------------------
+ src/hb-ot-cmap-table.hh | 111 ++++++++++++++++++++++++++++--------------------
src/hb-ot-font.cc | 14 +++++-
2 files changed, 77 insertions(+), 48 deletions(-)
@@ -50284,7 +49520,7 @@
Date: Wed Feb 24 19:10:06 2016 +0900
[TODO] Update
-
+
This file is rather obsolete. Still, give it a refresh.
TODO | 16 ++--------------
@@ -50294,9 +49530,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Feb 24 19:05:23 2016 +0900
- Add get_nominal_glyph() and get_variation_glyph() instead of
- get_glyph()
-
+ Add get_nominal_glyph() and get_variation_glyph() instead of get_glyph()
+
New API:
- hb_font_get_nominal_glyph_func_t
- hb_font_get_variation_glyph_func_t
@@ -50304,11 +49539,11 @@
- hb_font_funcs_set_variation_glyph_func()
- hb_font_get_nominal_glyph()
- hb_font_get_variation_glyph()
-
+
Deprecated API:
- hb_font_get_glyph_func_t
- hb_font_funcs_set_glyph_func()
-
+
Clients that implement their own font-funcs are encouraged to replace
their get_glyph() implementation with a get_nominal_glyph() and
get_variation_glyph() pair. The variation version can assume that
@@ -50317,8 +49552,7 @@
src/hb-deprecated.h | 10 ++
src/hb-fallback-shape.cc | 4 +-
src/hb-font-private.hh | 26 +++--
- src/hb-font.cc | 203
- ++++++++++++++++++++++++++++++++++---
+ src/hb-font.cc | 203 ++++++++++++++++++++++++++++++++++---
src/hb-font.h | 55 +++++++---
src/hb-ft.cc | 38 ++++---
src/hb-ot-font.cc | 57 +++++++----
@@ -50345,7 +49579,7 @@
Date: Wed Feb 24 16:06:40 2016 +0900
Fix recent test
-
+
Not sure why the FT functions were returning advance 1024. This
caused failure on drone.io. Switch to hb-ot-font and disable
glyph names.
@@ -50367,19 +49601,18 @@
Date: Wed Feb 24 15:53:40 2016 +0900
Partially revert 86c68c7a2c971efe8e35b1f1bd99401dc8b688d2
-
+
That commit moved the advance adjustment for mark positioning to
be applied immediately, instead of doing late before. This breaks
if mark advances are zeroed late, like in Arabic. Also, easier to
hit it in RTL scripts since a single mark with non-zero advance is
enough to hit the bug, whereas in LTR, at least two marks are needed.
-
+
This reopens https://github.com/behdad/harfbuzz/issues/211
The cursive+mark interaction is broken again. To be fixed in a
different way.
- src/hb-ot-layout-gpos-table.hh | 28
- ++++++++++++----------------
+ src/hb-ot-layout-gpos-table.hh | 28 ++++++++++++----------------
test/shaping/tests/cursive-positioning.tests | 2 +-
2 files changed, 13 insertions(+), 17 deletions(-)
@@ -50388,12 +49621,11 @@
Date: Wed Feb 24 15:52:37 2016 +0900
Add test for mark positioning in rtl with non-zero mark advance
-
+
Apparently I broke this 86c68c7a2c971efe8e35b1f1bd99401dc8b688d2.
Fix coming.
- .../sha1sum/07f054357ff8638bac3711b422a1e31180bba863.ttf | Bin 0 ->
- 848 bytes
+ .../sha1sum/07f054357ff8638bac3711b422a1e31180bba863.ttf | Bin 0 -> 848 bytes
test/shaping/tests/cursive-positioning.tests | 1 +
2 files changed, 1 insertion(+)
@@ -50449,12 +49681,11 @@
Date: Tue Feb 23 13:45:38 2016 +0900
Remove MANIFEST files
-
+
They are unused currently. We can add later if we hook them up
to anything useful.
- test/shaping/fonts/sha1sum/MANIFEST | 52
- ----------------------
+ test/shaping/fonts/sha1sum/MANIFEST | 52 ----------------------
test/shaping/tests/MANIFEST | 19 --------
test/shaping/texts/MANIFEST | 1 -
test/shaping/texts/in-tree/MANIFEST | 9 ----
@@ -50587,14 +49818,12 @@
Date: Mon Feb 22 18:22:44 2016 +0900
In cluster-level=0, group ZWJ/ZWNJ with previous cluster
-
+
This better emulates Unicode grapheme clusters.
-
- Note that Uniscribe does NOT do this, but should be harmless with
- most clients,
- and improve fallback with clients that use HarfBuzz cluster as unit
- of fallback.
-
+
+ Note that Uniscribe does NOT do this, but should be harmless with most clients,
+ and improve fallback with clients that use HarfBuzz cluster as unit of fallback.
+
Fixes https://github.com/behdad/harfbuzz/issues/217
src/hb-ot-layout-private.hh | 6 ++++++
@@ -50619,8 +49848,7 @@
[coretext] Move CTFont construction to face_data
- src/hb-coretext.cc | 66
- +++++++++++++++++++++++++-----------------------------
+ src/hb-coretext.cc | 66 +++++++++++++++++++++++++-----------------------------
1 file changed, 30 insertions(+), 36 deletions(-)
commit ba3d49d9a56932d341bf1916a30f322be665e3a6
@@ -50629,8 +49857,7 @@
[coretext] Move code around
- src/hb-coretext.cc | 70
- +++++++++++++++++++++++++++++++-----------------------
+ src/hb-coretext.cc | 70 +++++++++++++++++++++++++++++++-----------------------
1 file changed, 40 insertions(+), 30 deletions(-)
commit 90194efb8480d58c55b7a19962624c7aadbdca63
@@ -50691,8 +49918,7 @@
[coretext] Move code around
- src/hb-coretext.cc | 109
- ++++++++++++++++++++++++++++++-----------------------
+ src/hb-coretext.cc | 109 ++++++++++++++++++++++++++++++-----------------------
1 file changed, 62 insertions(+), 47 deletions(-)
commit 04c64431530a4a6d9ebd33674c4665a8e6d25bdd
@@ -50719,7 +49945,7 @@
Date: Mon Feb 22 14:59:39 2016 +0900
[coretext] Fix shaping with varying font size
-
+
Fixes https://github.com/libass/libass/issues/212
src/hb-coretext.cc | 8 ++++----
@@ -50740,14 +49966,12 @@
Date: Fri Feb 19 15:13:07 2016 +0700
[fuzzing] Add test for recent fix
-
+
Test from https://github.com/behdad/harfbuzz/issues/223
+
+ I forgot that we do run hb-fuzzer on tests in shaping/tests/fuzzed.tests.
- I forgot that we do run hb-fuzzer on tests in
- shaping/tests/fuzzed.tests.
-
- .../sha1sum/205edd09bd3d141cc9580f650109556cc28b22cb.ttf | Bin 0 ->
- 1966 bytes
+ .../sha1sum/205edd09bd3d141cc9580f650109556cc28b22cb.ttf | Bin 0 -> 1966 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 2 insertions(+)
@@ -50775,13 +49999,11 @@
Date: Fri Feb 19 14:52:31 2016 +0700
Avoid buffer->move_to() in case of buffer error
-
+
Fixes https://github.com/behdad/harfbuzz/issues/223
-
- Right now we cannot test this because it has to be tested using
- hb-fuzzer.
- We should move all fuzzing tests from test/shaping/tests/fuzzed.tests
- to
+
+ Right now we cannot test this because it has to be tested using hb-fuzzer.
+ We should move all fuzzing tests from test/shaping/tests/fuzzed.tests to
test/fuzzing/ and have its own test runner. At that point, should add
test from this issue as well.
@@ -50794,7 +50016,7 @@
Date: Fri Feb 19 14:43:39 2016 +0700
[fuzzing] Make "make hb-fuzzer" build lib dependency
-
+
Not going to do with util/, but is convenient here.
test/fuzzing/Makefile.am | 3 +++
@@ -50805,7 +50027,7 @@
Date: Thu Feb 18 19:31:51 2016 +0700
Remove pointless overflow check in pointer math
-
+
Fixes https://github.com/behdad/harfbuzz/issues/227
src/hb-blob.cc | 1 -
@@ -50816,7 +50038,7 @@
Date: Thu Feb 18 17:06:25 2016 +0700
Emoji skin tone modifiers need to be treated as combining marks
-
+
Fixes https://github.com/behdad/harfbuzz/issues/169
src/hb-ot-layout-private.hh | 15 ++++++++++++++-
@@ -50828,16 +50050,14 @@
Date: Tue Feb 16 17:16:33 2016 +0700
[USE] Zero mark advances by GDEF early
-
+
This is what Microsoft's implementation does. Marks that need advance
- need to add it back using 'dist' or other feature in GPOS.
- Update tests to
+ need to add it back using 'dist' or other feature in GPOS. Update tests to
match.
src/hb-ot-shape-complex-use.cc | 2 +-
test/shaping/fonts/sha1sum/MANIFEST | 1 +
- .../sha1sum/f518eb6f6b5eec2946c9fbbbde44e45d46f5e2ac.ttf | Bin 0 ->
- 1356 bytes
+ .../sha1sum/f518eb6f6b5eec2946c9fbbbde44e45d46f5e2ac.ttf | Bin 0 -> 1356 bytes
test/shaping/tests/context-matching.tests | 2 +-
test/shaping/tests/use.tests | 2 ++
5 files changed, 5 insertions(+), 2 deletions(-)
@@ -50847,57 +50067,52 @@
Date: Tue Feb 16 16:07:20 2016 +0700
[GPOS] Fix interaction of mark attachments and cursive chaining
-
+
Fixes https://github.com/behdad/harfbuzz/issues/211
-
+
What happens in that bug is that a mark is attached to base first,
then a second mark is cursive-chained to the first mark. This only
"works" because it's in the Indic shaper where mark advances are
not zeroed.
-
+
Before, we didn't allow cursive to run on marks at all. Fix that.
We also where updating mark major offsets at the end of GPOS, such
that changes in advance of base will not change the mark attachment
- position. That was superior to the alternative (which is what
- Uniscribe
+ position. That was superior to the alternative (which is what Uniscribe
does BTW), but made it hard to apply cursive to the mark after it
was positioned. We could track major-direction offset changes and
apply that to cursive in the post process, but that's a much trickier
thing to do than the fix here, which is to immediately apply the
major-direction advance-width offsets... Ie.:
-
+
https://github.com/behdad/harfbuzz/issues/211#issuecomment-183194739
-
- If this breaks any fonts, the font should be fixed to do mark
- attachment
+
+ If this breaks any fonts, the font should be fixed to do mark attachment
after all the advances are set up first (kerning, etc).
-
+
Finally, this, still doesn't make us match Uniscribe, for I explained
in that bug. Looks like Uniscribe applies minor-direction cursive
adjustment immediate as well. We don't, and we like it our way, at
least for now. Eg. the sequence in the test case does this:
-
+
- The first subscript attaches with mark-to-base, moving in x only,
- - The second subscript attaches with cursive attachment to first
- subscript
+ - The second subscript attaches with cursive attachment to first subscript
moving in x only,
- A final context rule moves the first subscript up by 104 units.
-
+
The way we do, the final shift-up, also shifts up the second subscript
mark because it's cursively-attached. Uniscribe doesn't. We get:
-
+
[ttaorya=0+1307|casubscriptorya=0 at -242,104+-231|casubscriptnarroworya=0 at 20,104+507]
-
+
while Uniscribe gets:
-
+
[ttaorya=0+1307|casubscriptorya=0 at -242,104+-211|casubscriptnarroworya=0+487]
-
- note the different y-offset of the last glyph. In our view,
- after cursive,
+
+ note the different y-offset of the last glyph. In our view, after cursive,
things move together, period.
- src/hb-ot-layout-gpos-table.hh | 31
- +++++++++++----------
+ src/hb-ot-layout-gpos-table.hh | 31 +++++++++++----------
.../706c5d7b625f207bc0d874c67237aad6f1e9cd6f.ttf | Bin 0 -> 3868 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/cursive-positioning.tests | 1 +
@@ -50917,7 +50132,7 @@
Date: Thu Feb 11 16:57:52 2016 +0700
[GPOS] Minor
-
+
No effect.
src/hb-ot-layout-gpos-table.hh | 8 ++++----
@@ -50928,12 +50143,11 @@
Date: Thu Feb 11 16:48:13 2016 +0700
[GPOS] Merge fixing of offsets for cursive and mark attachments
-
+
Part of fixing https://github.com/behdad/harfbuzz/issues/211
src/hb-buffer-private.hh | 3 +-
- src/hb-ot-layout-gpos-table.hh | 73
- ++++++++++++++++++------------------------
+ src/hb-ot-layout-gpos-table.hh | 73 ++++++++++++++++++------------------------
2 files changed, 33 insertions(+), 43 deletions(-)
commit 7d8d58ac81fe267e29ea68cdc6f4a4fa8c22d40f
@@ -50940,9 +50154,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Feb 11 16:34:28 2016 +0700
- [GPOS] Divide position_finish() into two phases, for advances
- and offsets
-
+ [GPOS] Divide position_finish() into two phases, for advances and offsets
+
Right now the position_finish_advances() is empty. To be used for
spacing attachments proposal later.
@@ -50968,7 +50181,7 @@
Date: Thu Feb 11 15:28:55 2016 +0700
[GPOS] Add harmless recursion in fix_mark_attachment()
-
+
Will do nothing. Just useful for merging two functions.
src/hb-ot-layout-gpos-table.hh | 2 ++
@@ -50979,11 +50192,10 @@
Date: Thu Feb 11 15:25:28 2016 +0700
[GPOS] Merge attach_chain() and cursive_chain()
-
+
Differentiate, using new attach_type().
- src/hb-ot-layout-gpos-table.hh | 50
- +++++++++++++++++++++++++++---------------
+ src/hb-ot-layout-gpos-table.hh | 50 +++++++++++++++++++++++++++---------------
1 file changed, 32 insertions(+), 18 deletions(-)
commit 806ad8dc65931ab7893bff7d5592a67a9bd237ca
@@ -50999,11 +50211,9 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Feb 11 14:49:10 2016 +0700
- [GPOS] Negate sign of attach_lookback(), and rename it to
- attach_chain()
-
- No behavior change. Preparing to unify how cursive and mark
- attachments
+ [GPOS] Negate sign of attach_lookback(), and rename it to attach_chain()
+
+ No behavior change. Preparing to unify how cursive and mark attachments
work.
src/hb-ot-layout-gpos-table.hh | 17 +++++++++--------
@@ -51013,12 +50223,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Feb 11 12:15:38 2016 +0700
- [tests] Add test for advance zeroing of an ASCII letter marked as
- mark in GDEF
+ [tests] Add test for advance zeroing of an ASCII letter marked as mark in GDEF
test/shaping/fonts/sha1sum/MANIFEST | 1 +
- .../sha1sum/a98e908e2ed21b22228ea59ebcc0f05034c86f2e.ttf | Bin 0 ->
- 1016 bytes
+ .../sha1sum/a98e908e2ed21b22228ea59ebcc0f05034c86f2e.ttf | Bin 0 -> 1016 bytes
test/shaping/tests/zero-width-marks.tests | 1 +
3 files changed, 2 insertions(+)
@@ -51027,7 +50235,7 @@
Date: Thu Feb 11 12:14:27 2016 +0700
Remove font-dependent ASCII-only perf hack
-
+
Is confusing. I already hit it myself. Remove. We can optimize
ASCII based on Unicode properties. But should not do based on
assumptions on the font.
@@ -51050,21 +50258,15 @@
Date: Wed Feb 10 18:39:59 2016 +0700
[tests] Fix fonts in cc4a78bf22c4a735b84c89b04be3bb531f42135e
-
+
They had an invalid LookupFlag (32).
- .../sha1sum/0dd3a51c3ea50997cb1f72515d1060408f8b4b59.ttf | Bin 1412 ->
- 0 bytes
- .../sha1sum/56cfd0e18d07f41c38e9598545a6d369127fc6f9.ttf | Bin 0 ->
- 1412 bytes
- .../sha1sum/828114d00931885bc25abf7cdb878b2914a2e743.ttf | Bin 1448 ->
- 0 bytes
- .../sha1sum/894e96a367f00c196d82e6243673a1d4414f4f6a.ttf | Bin 1448 ->
- 0 bytes
- .../sha1sum/cc5f3d2d717fb6bd4dfae1c16d48a2cb8e12233b.ttf | Bin 0 ->
- 1448 bytes
- .../sha1sum/ffa0f5d2d9025486d8469d8b1fdd983e7632499b.ttf | Bin 0 ->
- 1448 bytes
+ .../sha1sum/0dd3a51c3ea50997cb1f72515d1060408f8b4b59.ttf | Bin 1412 -> 0 bytes
+ .../sha1sum/56cfd0e18d07f41c38e9598545a6d369127fc6f9.ttf | Bin 0 -> 1412 bytes
+ .../sha1sum/828114d00931885bc25abf7cdb878b2914a2e743.ttf | Bin 1448 -> 0 bytes
+ .../sha1sum/894e96a367f00c196d82e6243673a1d4414f4f6a.ttf | Bin 1448 -> 0 bytes
+ .../sha1sum/cc5f3d2d717fb6bd4dfae1c16d48a2cb8e12233b.ttf | Bin 0 -> 1448 bytes
+ .../sha1sum/ffa0f5d2d9025486d8469d8b1fdd983e7632499b.ttf | Bin 0 -> 1448 bytes
6 files changed, 0 insertions(+), 0 deletions(-)
commit eaadcbbc53e02838c847e53ef214a55d6915d677
@@ -51083,15 +50285,11 @@
[tests] Add tests for Latin mark zeroing
- .../sha1sum/0dd3a51c3ea50997cb1f72515d1060408f8b4b59.ttf | Bin 0 ->
- 1412 bytes
- .../sha1sum/828114d00931885bc25abf7cdb878b2914a2e743.ttf | Bin 0 ->
- 1448 bytes
- .../sha1sum/894e96a367f00c196d82e6243673a1d4414f4f6a.ttf | Bin 0 ->
- 1448 bytes
+ .../sha1sum/0dd3a51c3ea50997cb1f72515d1060408f8b4b59.ttf | Bin 0 -> 1412 bytes
+ .../sha1sum/828114d00931885bc25abf7cdb878b2914a2e743.ttf | Bin 0 -> 1448 bytes
+ .../sha1sum/894e96a367f00c196d82e6243673a1d4414f4f6a.ttf | Bin 0 -> 1448 bytes
test/shaping/fonts/sha1sum/MANIFEST | 4 ++++
- .../sha1sum/fcdcffbdf1c4c97c05308d7600e4c283eb47dbca.ttf | Bin 0 ->
- 1344 bytes
+ .../sha1sum/fcdcffbdf1c4c97c05308d7600e4c283eb47dbca.ttf | Bin 0 -> 1344 bytes
test/shaping/tests/zero-width-marks.tests | 4 ++++
6 files changed, 8 insertions(+)
@@ -51101,15 +50299,11 @@
[tests] Add tests for Thai mark zeroing
- .../sha1sum/45855bc8d46332b39c4ab9e2ee1a26b1f896da6b.ttf | Bin 0 ->
- 1088 bytes
- .../sha1sum/7a37dc4d5bf018456aea291cee06daf004c0221c.ttf | Bin 0 ->
- 1080 bytes
- .../sha1sum/8099955657a54e9ee38a6ba1d6f950ce58e3cc25.ttf | Bin 0 ->
- 1024 bytes
+ .../sha1sum/45855bc8d46332b39c4ab9e2ee1a26b1f896da6b.ttf | Bin 0 -> 1088 bytes
+ .../sha1sum/7a37dc4d5bf018456aea291cee06daf004c0221c.ttf | Bin 0 -> 1080 bytes
+ .../sha1sum/8099955657a54e9ee38a6ba1d6f950ce58e3cc25.ttf | Bin 0 -> 1024 bytes
test/shaping/fonts/sha1sum/MANIFEST | 4 ++++
- .../sha1sum/bb0c53752e85c3d28973ebc913287b8987d3dfe8.ttf | Bin 0 ->
- 976 bytes
+ .../sha1sum/bb0c53752e85c3d28973ebc913287b8987d3dfe8.ttf | Bin 0 -> 976 bytes
test/shaping/tests/zero-width-marks.tests | 4 ++++
6 files changed, 8 insertions(+)
@@ -51118,7 +50312,7 @@
Date: Wed Feb 10 18:10:15 2016 +0700
Change default mark advance zeroing behavior from Unicode to GDEF
-
+
See thread at:
https://lists.freedesktop.org/archives/harfbuzz/2016-February/005462.html
@@ -51142,7 +50336,7 @@
Date: Wed Feb 10 11:11:36 2016 +0700
Merge pull request #164 from fanc999/msvc.build
-
+
Enable Build of HarfBuzz under Visual Studio using NMake Makefiles
commit a168db4739148459bc33c7dae88e73efa0153d72
@@ -51159,16 +50353,12 @@
Date: Wed Dec 9 14:57:15 2015 +0800
MSVC builds: Add support to build DirectWrite shaping backend
-
+
Add into the NMake Makefiles to build the DirectWrite shaping backend,
- but as PR #134 mentions, this is considered to be in an experimental
- state,
- so don't include this in the build by default for now. This is
- most probably
- going to replace the Uniscribe backend eventually, since DirectWrite
- is meant
- to be Uniscribe's replacement, and is needed for Windows Store apps
- if a
+ but as PR #134 mentions, this is considered to be in an experimental state,
+ so don't include this in the build by default for now. This is most probably
+ going to replace the Uniscribe backend eventually, since DirectWrite is meant
+ to be Uniscribe's replacement, and is needed for Windows Store apps if a
system shaping API is to be used.
win32/README.txt | 4 ++++
@@ -51182,7 +50372,7 @@
Date: Wed Feb 3 18:31:23 2016 +0800
build: Build the DirectWrite sources if requested
-
+
This adds to the autotools build system so that the (experimental)
DirectWrite support for HarfBuzz is built (and dist'ed).
@@ -51196,32 +50386,23 @@
Date: Tue Nov 3 19:00:42 2015 +0800
build: Support Visual Studio builds using NMake
-
- This adds a set of NMake Makefiles that can be used to build
- HarfBuzz, from
+
+ This adds a set of NMake Makefiles that can be used to build HarfBuzz, from
the standard basic build building the minimal HarfBuzz DLL (consisting
- of OpenType, fallback and Uniscribe support only), to a full
- fledged build
- consisting of GLib and FreeType support, as well as building the
- utilities,
+ of OpenType, fallback and Uniscribe support only), to a full fledged build
+ consisting of GLib and FreeType support, as well as building the utilities,
the test programs in src/ and test/api, and HarfBuzz-ICU and
- HarfBuzz-GObject, and up to building the introspection files.
- This means a
- flexible build mechanism is supported here, so anything that is
- supported
+ HarfBuzz-GObject, and up to building the introspection files. This means a
+ flexible build mechanism is supported here, so anything that is supported
for a Windows build (code-wise), should all be supported by this build
system.
-
- As in an earlier commit, the source listings are shared with the
- autotools
- builds with the various Makefile.sources in src/, src/hb-ucdn and
- util/, and
- this set of NMake Makefiles will transform these lists into the
- form they
+
+ As in an earlier commit, the source listings are shared with the autotools
+ builds with the various Makefile.sources in src/, src/hb-ucdn and util/, and
+ this set of NMake Makefiles will transform these lists into the form they
want.
-
- In the current form, all the test programs in test/api pass, and
- this has
+
+ In the current form, all the test programs in test/api pass, and this has
been checked successfully with 'make -j8 distcheck'.
BUILD.md | 4 +-
@@ -51231,8 +50412,7 @@
win32/Makefile.vc | 52 +++++++++++
win32/README.txt | 75 ++++++++++++++++
win32/build-rules-msvc.mak | 140 ++++++++++++++++++++++++++++++
- win32/config-msvc.mak | 188
- ++++++++++++++++++++++++++++++++++++++++
+ win32/config-msvc.mak | 188 ++++++++++++++++++++++++++++++++++++++++
win32/create-lists-msvc.mak | 151 ++++++++++++++++++++++++++++++++
win32/create-lists.bat | 42 +++++++++
win32/detectenv-msvc.mak | 136 +++++++++++++++++++++++++++++
@@ -51248,21 +50428,17 @@
Date: Tue Nov 3 18:52:46 2015 +0800
MSVC builds: Add a pre-configured config.h(.win32) template
-
- This adds a pre-configured config.h template that can be used
- for Visual
- Studio builds, where autotools is not normally available. This has
- the
+
+ This adds a pre-configured config.h template that can be used for Visual
+ Studio builds, where autotools is not normally available. This has the
configs that are suitable for Visual Studio builds, as well as all the
features used for Windows builds enabled (HAVE_OT, HAVE_FALLBACK and
HAVE_UNISCRIBE).
-
- Note that the optional features are not enabled here, they are
- enabled by
+
+ Note that the optional features are not enabled here, they are enabled by
/D's (or -D's) in the NMake Makefiles as requested.
- win32/config.h.win32.in | 155
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ win32/config.h.win32.in | 155 ++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 155 insertions(+)
commit 35ded3af74a5bc4b038a07308354d5f7501ae3c7
@@ -51270,14 +50446,13 @@
Date: Tue Nov 3 16:56:27 2015 +0800
build: Move source listings into separate Makefile snippets
-
+
This moves all the source listings in src/Makefile.am,
src/hb-ucdn/Makefile.am and util/Makefile.am into separate Makefile
snippets, so that they may be shared between different Makefile-based
build systems, such as NMake for Visual Studio.
- src/Makefile.am | 165
- +++++++++----------------------------------
+ src/Makefile.am | 165 +++++++++----------------------------------
src/Makefile.sources | 147 ++++++++++++++++++++++++++++++++++++++
src/hb-ucdn/Makefile.am | 6 +-
src/hb-ucdn/Makefile.sources | 4 ++
@@ -51290,7 +50465,7 @@
Date: Tue Feb 2 16:39:19 2016 +0800
Fix more hangs in case of buffer allocation errors
-
+
Hopefully
fixes https://github.com/behdad/harfbuzz/issues/214
@@ -51305,7 +50480,7 @@
Date: Tue Feb 2 12:33:32 2016 +0800
Merge pull request #222 from n8willis/master
-
+
Add usermanual chapter on cluster levels
commit 498574e6c1a83bbd2768925af6e39806fe1ea8bb
@@ -51324,8 +50499,7 @@
Added initial usermanual chapter on cluster levels.
docs/harfbuzz-docs.xml | 1 +
- docs/usermanual-clusters.xml | 304
- +++++++++++++++++++++++++++++++++++++++++++
+ docs/usermanual-clusters.xml | 304 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 305 insertions(+)
commit 9a6a33ccbea8a2e23e779bd955958fa41974c1c7
@@ -51334,7 +50508,7 @@
Date: Mon Jan 18 12:47:18 2016 +0100
Merge pull request #216 from mhosken/master
-
+
Refactor graphite2 to make ovleraps into negative width spaces
commit 146fe252c3ebd0253344ce20981554e40926497b
@@ -51343,8 +50517,7 @@
Refactor graphite2 to make ovleraps into negative width spaces
- src/hb-graphite2.cc | 71
- ++++++++++++++++++++++++++++++++---------------------
+ src/hb-graphite2.cc | 71 ++++++++++++++++++++++++++++++++---------------------
1 file changed, 43 insertions(+), 28 deletions(-)
commit d05b783322d90208b2ddf06a5ebffc7c301be3d7
@@ -51352,7 +50525,7 @@
Date: Tue Jan 12 16:17:21 2016 +0000
Fix compiler warning
-
+
Fixes https://github.com/behdad/harfbuzz/issues/212
src/hb-ot-tag.cc | 2 +-
@@ -51372,9 +50545,9 @@
Date: Mon Jan 11 18:31:04 2016 +0000
[fuzzing] Fuzz input text
-
+
Very rudimentary right now, but will get kcc's bot going.
-
+
From
https://github.com/behdad/harfbuzz/issues/139#issuecomment-163580783
@@ -51386,14 +50559,14 @@
Date: Mon Jan 11 17:38:41 2016 +0000
[OT] Get list of lookup subtables once and loop through them
-
+
This speeds up shaping the Amiri font by over 15%.
-
+
This was primarily needed for my work on OpenType GX, since
we will be collecting only sublookups that are "active" for
current font instance; but it's a nice boost in general as
well.
-
+
We might, in the future, collect subtables in the lookup_accel.
That would also allow us to do a per-subtbale set-digest, which
should speed things up some more, specially for ContextChainFormat3
@@ -51400,8 +50573,7 @@
lookups... Amiri, for example, contains one lookup with 53
subtables!
- src/hb-ot-layout.cc | 120
- +++++++++++++++++++++++++++++++++++-----------------
+ src/hb-ot-layout.cc | 120 +++++++++++++++++++++++++++++++++++-----------------
1 file changed, 81 insertions(+), 39 deletions(-)
commit 11441291bbf4326dca9b14ec3e9cad3d4d229303
@@ -51428,7 +50600,7 @@
Date: Mon Jan 11 12:28:37 2016 +0000
[coretext] Speed up CoreText font fallback
-
+
Fixes https://code.google.com/p/chromium/issues/detail?id=547912
src/hb-coretext.cc | 45 ++++++++++++++++++++++++++++++++++++++++-----
@@ -51457,7 +50629,7 @@
Date: Thu Jan 7 19:11:41 2016 +0000
Add 9 reserved entries to hb_font_extents_t
-
+
Might add italic-angle, underline/strikethrough-position/thickness
in the future. Do this before new struct goes into a release.
@@ -51469,7 +50641,7 @@
Date: Wed Jan 6 12:29:50 2016 +0000
[uniscribe] Fix negative advance
-
+
This happens with at least one test font I have.
src/hb-uniscribe.cc | 2 +-
@@ -51494,7 +50666,7 @@
Date: Tue Jan 5 13:26:20 2016 +0000
Increase sanitize edit count from 8 to 32
-
+
See previous commit.
src/hb-open-type-private.hh | 2 +-
@@ -51505,7 +50677,7 @@
Date: Tue Jan 5 13:23:45 2016 +0000
Don't count fixing-up FeatureParams offset as error
-
+
The font Garamond Premier Pro Caption (and possibly many other
Adobe fonts), have many FeatureParamsSize tables with the old
wrong offset. We handle fixing those up, but they were still
@@ -51512,7 +50684,7 @@
contributing to edit_count, and when I reduced HB_SANITIZE_MAX_EDIT
from 100 to 8 in 14c2de321826c36037adde859ccca3e2011325a9, these
fonts were now getting GPOS dropped and hence kerning disabled.
-
+
Fix, by not counting edits made towareds offset fix-up. I'll
also increase edit count again, in the next commit.
@@ -51534,7 +50706,7 @@
Date: Sat Jan 2 00:59:14 2016 +0000
Merge pull request #208 from khaledhosny/travis-trusty
-
+
[travis] Try building on Trusty
commit 4b4948d360a2141e0ffda2994aa308645dc32f59
@@ -51542,7 +50714,7 @@
Date: Sat Jan 2 00:36:19 2016 +0400
[travis] Try building on Trusty
-
+
Trusty has gtk-doc 1.20 which has better markdown support which should
fix some of the brokenness in the newly added documentation. The build
seems to be as fast as the current container-based build on Precise.
@@ -51555,7 +50727,7 @@
Date: Fri Jan 1 19:06:43 2016 +0000
[travis] Only run coveralls if testing behdad/harfbuzz
-
+
Fixes failures in others' forks, like:
https://travis-ci.org/khaledhosny/harfbuzz/jobs/99719710#L3912
@@ -51568,7 +50740,7 @@
Date: Fri Jan 1 16:44:01 2016 +0000
Merge pull request #207 from khaledhosny/docs-4
-
+
[docs] More buffers documentation
commit 9ab9f974d42e0001966e243a23a64e6aefbd4764
@@ -51578,10 +50750,8 @@
[docs] More buffers documentation
docs/harfbuzz-sections.txt | 4 +-
- src/hb-buffer-serialize.cc | 85
- ++++++++++++++++++++++++++++++-------------
- src/hb-buffer.cc | 91
- +++++++++++++++++++++++++++++++++++-----------
+ src/hb-buffer-serialize.cc | 85 ++++++++++++++++++++++++++++++-------------
+ src/hb-buffer.cc | 91 +++++++++++++++++++++++++++++++++++-----------
src/hb-buffer.h | 78 +++++++++++++++++++++++++--------------
src/hb-shape.cc | 10 +++--
5 files changed, 187 insertions(+), 81 deletions(-)
@@ -51592,7 +50762,7 @@
Date: Wed Dec 30 22:20:14 2015 +0100
Merge pull request #205 from khaledhosny/more-docs
-
+
More docs
commit d7ed6f50b4ff13a94701131913d931f13a4d1266
@@ -51601,7 +50771,7 @@
Date: Wed Dec 30 22:20:00 2015 +0100
Merge pull request #206 from nico/patch-3
-
+
Remove unused HB_SHAPER_DATA_ENSURE_DECLARE lines.
commit a7f0e25dafa90bd21b01c38cb0782ade54b75cdc
@@ -51609,13 +50779,9 @@
Date: Wed Dec 30 16:05:52 2015 -0500
Remove unused HB_SHAPER_DATA_ENSURE_DECLARE lines.
+
+ The coretext_aat shaper delegates to the regular coretext_..._ensure() functions, so coretext_aat_..._ensure() functions defined by these macros are unused. The compiler warns about them, which in turn can confuse people to think that the coretext_aat_..._ensure() functions weren't called by accident.
- The coretext_aat shaper delegates to the regular coretext_..._ensure()
- functions, so coretext_aat_..._ensure() functions defined by these
- macros are unused. The compiler warns about them, which in turn can
- confuse people to think that the coretext_aat_..._ensure() functions
- weren't called by accident.
-
src/hb-coretext.cc | 4 ----
1 file changed, 4 deletions(-)
@@ -51624,13 +50790,11 @@
Date: Wed Dec 30 22:57:04 2015 +0400
[docs] Reduce gtkdoc-check errors
-
- Now it is just reporting one error about “503 undocumented or
- incomplete
+
+ Now it is just reporting one error about “503 undocumented or incomplete
symbols”, that will be the easy part I guess.
- docs/harfbuzz-docs.xml | 74
- ++++++++++++++++++++++++++++++++++++++++++++++
+ docs/harfbuzz-docs.xml | 74 ++++++++++++++++++++++++++++++++++++++++++++++
docs/harfbuzz-sections.txt | 40 +++++++++++++++++++++++++
2 files changed, 114 insertions(+)
@@ -51649,7 +50813,7 @@
Date: Wed Dec 30 16:44:19 2015 +0100
Merge pull request #203 from nico/patch-1
-
+
Remove unused `retry:` label.
commit 266bfa3772e75fedcd93db22bf8672a13ad7a7d9
@@ -51694,7 +50858,7 @@
Date: Wed Dec 30 15:45:43 2015 +0100
[docs] Shuffling code around in deploy-docs.sh
-
+
Temporarily makes it rebuild docs on every change again.
.ci/deploy-docs.sh | 46 +++++++++++++++++++++++++++-------------------
@@ -51706,7 +50870,7 @@
Date: Wed Dec 30 15:13:37 2015 +0100
Merge pull request #202 from khaledhosny/doc-fixes
-
+
Doc fixes
commit fb192c263e17081c87f4cc971274d9be42f19513
@@ -51717,8 +50881,7 @@
docs/harfbuzz-sections.txt | 2 ++
src/hb-buffer.cc | 7 +++---
- src/hb-buffer.h | 56
- ++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-buffer.h | 56 ++++++++++++++++++++++++++++++++++++++++++++--
3 files changed, 60 insertions(+), 5 deletions(-)
commit 8ab797c5b86c33eab6ee024471fd3c147325d26a
@@ -51728,8 +50891,7 @@
[docs] A bit more buffers documentation
docs/harfbuzz-sections.txt | 60 +++++++++++++++---------------
- src/hb-buffer.cc | 93
- +++++++++++++++++++++++++++++++---------------
+ src/hb-buffer.cc | 93 +++++++++++++++++++++++++++++++---------------
src/hb-buffer.h | 7 +++-
src/hb-common.cc | 43 +++++++++++++--------
src/hb-common.h | 15 +++++---
@@ -51740,12 +50902,11 @@
Date: Tue Dec 29 15:21:20 2015 +0400
[docs] Some documentation on buffers
-
+
Some of it (create, reference, destroy) are adapted from Cairo docs.
docs/harfbuzz-sections.txt | 55 +++++++-------
- src/hb-buffer.cc | 174
- +++++++++++++++++++++++++++------------------
+ src/hb-buffer.cc | 174 +++++++++++++++++++++++++++------------------
2 files changed, 132 insertions(+), 97 deletions(-)
commit d7bf9d05c519a369a7b3a02e9ed5ecc05a20cd3e
@@ -51753,7 +50914,7 @@
Date: Tue Dec 29 02:23:24 2015 +0400
[docs] Fix comment syntax
-
+
To lower the number of gtk-doc warnings.
.travis.yml | 2 +-
@@ -51767,10 +50928,9 @@
Date: Mon Dec 28 21:31:28 2015 -0500
Remove unused `retry:` label.
+
+ Fixes a -Wunused-label warning when building harfbuzz with clang -Wall.
- Fixes a -Wunused-label warning when building harfbuzz with clang
- -Wall.
-
src/hb-coretext.cc | 1 -
1 file changed, 1 deletion(-)
@@ -51779,7 +50939,7 @@
Date: Tue Dec 29 02:15:21 2015 +0400
[docs] Ignore the new HB_EXTERN decoration
-
+
Otherwise, almost all API functions are not extracted.
docs/Makefile.am | 3 ++-
@@ -51799,7 +50959,7 @@
Date: Sat Dec 26 06:35:08 2015 +0400
[travis] Build docs only on tagged revisions
-
+
Lets see if it works…
.ci/deploy-docs.sh | 4 +++-
@@ -51810,9 +50970,8 @@
Date: Fri Dec 25 18:41:41 2015 +0100
[travis] Remove secure var
-
- I've set up a secure var for behdad/harfbuzz through Travis web
- interface, no need
+
+ I've set up a secure var for behdad/harfbuzz through Travis web interface, no need
to set the var here.
.ci/deploy-docs.sh | 2 +-
@@ -51825,7 +50984,7 @@
Date: Fri Dec 25 18:21:08 2015 +0100
Merge pull request #199 from behdad/travis-docs
-
+
Deploy docs to gh-pages branch from Travis builds
commit 6173c2a6fc6ea0bf812f7f398770b5342974f9bf
@@ -51833,18 +50992,15 @@
Date: Fri Dec 25 18:18:23 2015 +0100
Fix flaky test
-
- This test font had a upem of 769, which results in rounding-related
- errors with
+
+ This test font had a upem of 769, which results in rounding-related errors with
the FreeType font funcs. Change the upem to 1024 to fix that.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/201
- ...> 1c2fb74c1b2aa173262734c1f616148f1648cfd6.ttf} | Bin 4064 ->
- 4064 bytes
+ ...> 1c2fb74c1b2aa173262734c1f616148f1648cfd6.ttf} | Bin 4064 -> 4064 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 +-
- test/shaping/tests/ligature-id.tests | 70
- ++++++++++-----------
+ test/shaping/tests/ligature-id.tests | 70 ++++++++++-----------
3 files changed, 36 insertions(+), 36 deletions(-)
commit 3fcae6d82da389c9944386a8ab41eb1c13b99330
@@ -51864,8 +51020,7 @@
docs/Makefile.am | 1 +
docs/harfbuzz-docs.xml | 15 ++++----
- docs/usermanual-install-harfbuzz.xml | 70
- ++++++++++++++++++++++++++++++++++++
+ docs/usermanual-install-harfbuzz.xml | 70 ++++++++++++++++++++++++++++++++++++
3 files changed, 80 insertions(+), 6 deletions(-)
commit 493a92220844c8996be67c8a7a2c5447942fe2c1
@@ -51873,14 +51028,12 @@
Date: Wed Dec 23 00:33:41 2015 +0400
Rename user manual files
-
+
Use chapter ids instead of numbers, so that we can reorder them,
introduce new ones etc. without the numbers becoming out of date.
- docs/Makefile.am | 12
- ++++++------
- docs/harfbuzz-docs.xml | 12
- ++++++------
+ docs/Makefile.am | 12 ++++++------
+ docs/harfbuzz-docs.xml | 12 ++++++------
... => usermanual-buffers-language-script-and-direction.xml} | 0
docs/{usermanual-ch04.xml => usermanual-fonts-and-faces.xml} | 0
...{usermanual-ch06.xml => usermanual-glyph-information.xml} | 0
@@ -51905,7 +51058,7 @@
Date: Mon Dec 14 23:33:51 2015 +0400
Deploy docs to gh-pages branch from Travis builds
-
+
Build docs in Travis and push them to the gh-pages branch, which makes
them available at http://behdad.github.io/harfbuzz/
@@ -51918,7 +51071,7 @@
Date: Wed Dec 23 14:50:53 2015 +0100
[layout] Collect coverage glyphs in PairPos
-
+
Apparently class=0 is used for ClassDef1. See:
https://github.com/adobe-type-tools/afdko/issues/90
@@ -51939,16 +51092,13 @@
Date: Fri Dec 18 18:17:07 2015 +0000
[buffer] Add debugging, aka, message, API
-
- Currently just announces lookup applications. Message-API *will*
- change.
- hb-shape / hb-view are updated to print-out messages to stder
- if --debug
+
+ Currently just announces lookup applications. Message-API *will* change.
+ hb-shape / hb-view are updated to print-out messages to stder if --debug
is specified.
src/hb-buffer-private.hh | 18 ++++++++++++++++++
- src/hb-buffer.cc | 44
- ++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-buffer.cc | 44 ++++++++++++++++++++++++++++++++++++++++++++
src/hb-buffer.h | 15 +++++++++++++++
src/hb-ot-layout.cc | 12 ++----------
util/main-font-text.hh | 18 ++++++++++++++++++
@@ -51968,8 +51118,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Dec 18 13:54:06 2015 +0000
- [use] Only set syllable-based topographical features if not
- Arabic-joining
+ [use] Only set syllable-based topographical features if not Arabic-joining
src/hb-ot-shape-complex-use.cc | 3 +++
1 file changed, 3 insertions(+)
@@ -51979,10 +51128,10 @@
Date: Fri Dec 18 13:47:16 2015 +0000
[indic] Followup fix for Malayalam context matching
-
+
We regeressed Malayalam in 508cc3d3cfcfb0383df0fe795cc28db4e0fd5729
This brings down the failures to 198 (from 750).
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
@@ -51989,8 +51138,7 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed
- (0.0188871%)
+ MALAYALAM: 1048136 out of 1048334 tests passed. 198 failed (0.0188871%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
@@ -52005,10 +51153,9 @@
Date: Fri Dec 18 11:05:11 2015 +0000
[indic] Update data tables to Unicode 8.0
-
- Test stats remain unchanged, except for Malayalam, which we
- investigate:
-
+
+ Test stats remain unchanged, except for Malayalam, which we investigate:
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
@@ -52015,21 +51162,19 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1047584 out of 1048334 tests passed. 750 failed
- (0.0715421%)
+ MALAYALAM: 1047584 out of 1048334 tests passed. 750 failed (0.0715421%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
-
+
Myanmar, compared to Windows 10 mmrtext.ttf:
-
+
MYANMAR: 1123865 out of 1123883 tests passed. 18 failed (0.00160159%)
src/gen-indic-table.py | 1 +
src/hb-ot-shape-complex-indic-private.hh | 40 ++--
- src/hb-ot-shape-complex-indic-table.cc | 372
- ++++++++++++++++++-------------
+ src/hb-ot-shape-complex-indic-table.cc | 372 ++++++++++++++++++-------------
src/hb-ot-shape-complex-indic.cc | 23 +-
src/hb-ot-shape-complex-myanmar.cc | 4 +
5 files changed, 244 insertions(+), 196 deletions(-)
@@ -52039,7 +51184,7 @@
Date: Thu Dec 17 17:47:35 2015 +0000
Remove HB_OT_SHAPE_ZERO_WIDTH_MARKS_DEFAULT
-
+
The DEFAULT naming wasn't helpful, so just remove it.
src/hb-ot-shape-complex-default.cc | 2 +-
@@ -52053,14 +51198,13 @@
Date: Thu Dec 17 17:31:17 2015 +0000
[indic] Allow context when matching for Malayalam new-spec
-
+
Test sequence:
U+0995,U+09CD,U+09B0
-
- With Nirmala shipped on Windows 10, this failed to form the below
- form.
+
+ With Nirmala shipped on Windows 10, this failed to form the below form.
Works now.
-
+
Reported by Sairus.
src/hb-ot-shape-complex-indic.cc | 11 +++++++++--
@@ -52071,14 +51215,13 @@
Date: Thu Dec 17 16:57:47 2015 +0000
[uniscribe] Handle E_NOT_SUFFICIENT_BUFFER as well as E_OUTOFMEMORY
-
+
On Windows 10 we are seeing that other error message...
-
+
Test sequence: U+0995,U+-9CD,U+09B0
- With Nirmala shipped on Windows 10, this failed to form the below
- form.
+ With Nirmala shipped on Windows 10, this failed to form the below form.
Works now.
-
+
Reported by Sairus.
src/hb-uniscribe.cc | 2 +-
@@ -52089,7 +51232,7 @@
Date: Thu Dec 17 16:28:38 2015 +0000
[util] Use O_BINARY instead of _O_BINARY
-
+
The latter doesn't seem to be available in Cygwin. I'm surprised it
compiled before...
@@ -52100,9 +51243,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Dec 17 15:23:09 2015 +0000
- Fix ligature component of a mark happening after a ligature within
- a ligature!
-
+ Fix ligature component of a mark happening after a ligature within a ligature!
+
Say, if we are ligating "A B_C m D", then previously 'm' was being
attached to 'B' in the combined A_B_C_D ligature. Now we attach it
to 'C'. No test for this though :(.
@@ -52115,14 +51257,13 @@
Date: Thu Dec 17 15:21:14 2015 +0000
Improve ligature-component handling
-
+
We use three bits for lig_id these days, so we finally got a report of
two separate ligatures with the same lig_id happening adjacent to each
other, and then the component-handling code was breaking things.
- Protect against that by ignoring same-lig-id but lig-comp=0 glyphs
- after
+ Protect against that by ignoring same-lig-id but lig-comp=0 glyphs after
a new ligature.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/198
src/hb-ot-layout-gsubgpos-private.hh | 12 +++++--
@@ -52130,8 +51271,7 @@
test/shaping/fonts/sha1sum/MANIFEST | 1 +
.../c78d1f25ea1df1210414f2fe2e0e1e53082bba76.ttf | Bin 0 -> 4064 bytes
test/shaping/tests/MANIFEST | 1 +
- test/shaping/tests/ligature-id.tests | 35
- +++++++++++++++++++++
+ test/shaping/tests/ligature-id.tests | 35 +++++++++++++++++++++
6 files changed, 47 insertions(+), 3 deletions(-)
commit 2ab0de9fbd03231b647345b01e31b136e2e00978
@@ -52139,7 +51279,7 @@
Date: Thu Dec 17 11:59:15 2015 +0000
[use] Fix halant detection
-
+
Before, we were just checking the use_category(). This detects as
halant a ligature that had the halant as first glyph (as seen in
NotoSansBalinese.) Change that to use the is_ligated() glyph prop
@@ -52147,16 +51287,14 @@
the rphf / pref tests. So we need to make sure the "ligated" bit
survives those tests. Since those only check the "substituted" bit,
we now only clear that bit for them and "ligated" survives.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/180
src/hb-ot-layout-private.hh | 6 ++----
- src/hb-ot-shape-complex-use.cc | 19
- ++++++++++++-------
+ src/hb-ot-shape-complex-use.cc | 19 ++++++++++++-------
test/shaping/Makefile.am | 1 +
test/shaping/fonts/sha1sum/MANIFEST | 1 +
- .../fbb6c84c9e1fe0c39e152fbe845e51fd81f6748e.ttf | Bin 0 ->
- 2616 bytes
+ .../fbb6c84c9e1fe0c39e152fbe845e51fd81f6748e.ttf | Bin 0 -> 2616 bytes
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/use.tests | 1 +
7 files changed, 18 insertions(+), 11 deletions(-)
@@ -52166,7 +51304,7 @@
Date: Thu Dec 17 11:04:33 2015 +0000
[arabic] Use glyph advance width in apply_stch() instead of extents
-
+
That seems to be what Windows is doing, and makes more sense.
src/hb-ot-shape-complex-arabic.cc | 24 +++++++-----------------
@@ -52177,7 +51315,7 @@
Date: Wed Dec 16 17:08:36 2015 +0100
Fix Since: tags for new API
-
+
https://github.com/behdad/harfbuzz/commit/e1d4d0f1dbd8518b5672245c05d73f22a9ed03ea#commitcomment-15006653
src/hb-font.cc | 6 +++---
@@ -52189,7 +51327,7 @@
Date: Mon Dec 14 14:19:03 2015 +0100
Merge pull request #196 from srl295/aix
-
+
AIX fixes
commit a13b023dbfd0532e8cd74c356fbbd4453d0ffaa0
@@ -52197,14 +51335,14 @@
Date: Fri Dec 11 10:21:27 2015 -0800
AIX fixes
-
+
- use '-w' instead of '\<...\>' for check-header-guards
grep manpage says these are the same
-
+
- put '-q' first in the grep options
-
+
- move VAR into hb-private.hh
-
+
- hb-font-private.hh - use [VAR] instead of [] for variable array
src/check-header-guards.sh | 5 ++---
@@ -52228,7 +51366,7 @@
Date: Thu Dec 10 16:56:07 2015 +0100
Merge branch 'font-extents'
-
+
Fixes https://github.com/behdad/harfbuzz/pull/165
commit 808d3fc0eadd379909f2a0308fd3db474f1efde8
@@ -52264,7 +51402,7 @@
Date: Thu Dec 10 15:54:42 2015 +0100
Add atomic ops for AIX
-
+
Patch from Volker Simonis.
src/hb-atomic-private.hh | 25 +++++++++++++++++++++++++
@@ -52275,28 +51413,19 @@
Date: Mon Dec 7 21:38:47 2015 +0100
Remove final pause from Arabic shaper
-
- Back in the old days, we used to apply 'calt' and 'cswh' in Arabic
- shaper,
- with a pause in between. Then we disabled the 'cswh' because
- Microsoft
+
+ Back in the old days, we used to apply 'calt' and 'cswh' in Arabic shaper,
+ with a pause in between. Then we disabled the 'cswh' because Microsoft
disabled it, but forgot to remove the unnecessary pause. Do that now.
-
- This has the benefit that it fixes shaping with monbaiti from
- Windows 10.
- In that version of that font, the lookups from 'calt' are duplicated
- in
- 'rclt', and Mongolian was changed to go through Universal Shaping
- Engine.
- We still use the Arabic shaper for Mongolian. With a pause after
- 'calt',
- we were applying the duplicate lookups from 'calt' and 'rclt' twice.
- It
+
+ This has the benefit that it fixes shaping with monbaiti from Windows 10.
+ In that version of that font, the lookups from 'calt' are duplicated in
+ 'rclt', and Mongolian was changed to go through Universal Shaping Engine.
+ We still use the Arabic shaper for Mongolian. With a pause after 'calt',
+ we were applying the duplicate lookups from 'calt' and 'rclt' twice. It
happened to be the case that these lookups were NOT idempotent. So we
- were getting wrong shaping. See thread "Windows 10 monbaiti.ttf
- upgrade
- (5.01 -> 5.51) caused loss of diacritical marks when shaped with
- harfbuz"
+ were getting wrong shaping. See thread "Windows 10 monbaiti.ttf upgrade
+ (5.01 -> 5.51) caused loss of diacritical marks when shaped with harfbuz"
on the mailing list. This fixes that.
src/hb-ot-shape-complex-arabic.cc | 2 +-
@@ -52308,7 +51437,7 @@
Date: Mon Dec 7 10:44:08 2015 +0100
Merge pull request #192 from behdad/jfkthame-stch
-
+
[issue 191] Make apply_stch() give a more precise fit
commit 255df6801201fb22402420f7b7b7ea8b042df8ba
@@ -52316,7 +51445,7 @@
Date: Mon Dec 7 10:34:47 2015 +0100
Fix undefined behavior in cmp function
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93274
src/hb-ot-map-private.hh | 3 ++-
@@ -52327,7 +51456,7 @@
Date: Mon Dec 7 10:30:43 2015 +0100
Fix sorting order of ot_languages array
-
+
Looks like the original sort was wrongly done.
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93275
@@ -52339,7 +51468,7 @@
Date: Mon Dec 7 10:28:46 2015 +0100
Add test to make sure ot-languages array is sorted
-
+
Currently fails. Part of
https://bugs.freedesktop.org/show_bug.cgi?id=93275
@@ -52353,7 +51482,7 @@
Date: Mon Dec 7 09:34:58 2015 +0100
Merge pull request #134 from ebraminio/dwrite
-
+
Add working but less prefect DirectWrite backend
commit a7ffe3535836032dba5559080dffeec79473197b
@@ -52361,12 +51490,9 @@
Date: Sat Dec 5 17:47:37 2015 +0000
Make apply_stch() give a more precise fit
+
+ This aims to make Syriac Abbr Mark sizing more accurate when repeating segments are used, by adding an extra repeat and tightening up the spacing slightly rather than leaving a shortfall corresponding to a partial repeat-width.
- This aims to make Syriac Abbr Mark sizing more accurate when repeating
- segments are used, by adding an extra repeat and tightening up the
- spacing slightly rather than leaving a shortfall corresponding to
- a partial repeat-width.
-
src/hb-ot-shape-complex-arabic.cc | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
@@ -52375,7 +51501,7 @@
Date: Mon Nov 30 16:53:21 2015 -0800
src/test.cc: wrong field printed
-
+
Fixes https://github.com/behdad/harfbuzz/issues/188
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=93182
@@ -52389,8 +51515,7 @@
Get font ascender and descender metrics from OS/2 table.
src/hb-font-private.hh | 39 ++++++++++++++++++-
- src/hb-font.cc | 102
- ++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-font.cc | 102 ++++++++++++++++++++++++++++++++++++++++++++++++-
src/hb-font.h | 62 ++++++++++++++++++++++++++++--
src/hb-ft.cc | 21 ++++++++++
src/hb-ot-font.cc | 58 ++++++++++++++++++++++++++--
@@ -52403,8 +51528,7 @@
Parse the OS/2 table.
src/Makefile.am | 1 +
- src/hb-ot-os2-table.hh | 105
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-os2-table.hh | 105 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 106 insertions(+)
commit d44d52bd0da033865641dfd39d94852119fd4fd7
@@ -52443,8 +51567,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Nov 26 19:22:22 2015 -0500
- Use C-style casts instead of compare to 0, to convert hb_bool_t
- to bool
+ Use C-style casts instead of compare to 0, to convert hb_bool_t to bool
src/hb-common.cc | 2 +-
src/hb-fallback-shape.cc | 2 +-
@@ -52463,11 +51586,11 @@
Date: Thu Nov 26 18:48:42 2015 -0500
Fix vertical GPOS
-
+
This was brorken earlier, though, it's really hard to notice it.
Unlike the glyph_h_origin(), an unset glyph_v_origin() does NOT
mean that the vertical origin is at 0,0.
-
+
Related to https://github.com/behdad/harfbuzz/issues/187
src/hb-ot-shape.cc | 13 ++++++++-----
@@ -52480,8 +51603,7 @@
Add tests for previous commit
test/shaping/Makefile.am | 1 +
- .../sha1sum/49c9f7485c1392fa09a1b801bc2ffea79275f22e.ttf | Bin 0 ->
- 1496 bytes
+ .../sha1sum/49c9f7485c1392fa09a1b801bc2ffea79275f22e.ttf | Bin 0 -> 1496 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/simple.tests | 2 ++
@@ -52492,12 +51614,12 @@
Date: Thu Nov 26 18:43:15 2015 -0500
Make nil glyph_h_origin() function return true
-
+
Fixes https://github.com/behdad/harfbuzz/issues/187
-
+
Funcs implementations that have a non-zero horizontal origin must
implement the glyph_h_origin() callback, nothing new here.
-
+
Other implementations (all I know of!) can simply not set
glyph_h_origin() now. I did that for hb-ot and hb-ft in
44f82750807475aa5b16099ccccd917d488df703, though that broke the
@@ -52512,7 +51634,7 @@
Date: Tue Nov 24 15:38:43 2015 -0600
Merge pull request #114 from ThePhD/vc++-fixes
-
+
Fix all VC++ warnings and errors
commit b344af80ca95b9eddfd6017aa6ae103388d6b5f8
@@ -52521,7 +51643,7 @@
Date: Tue Nov 24 15:30:27 2015 -0600
Merge pull request #177 from fanc999/exporting
-
+
Enable use of compiler directives to export symbols
commit 662acd26d10c38e96a9afcdaab2cb2979794966f
@@ -52530,7 +51652,7 @@
Date: Tue Nov 24 15:29:44 2015 -0600
Merge pull request #181 from mhosken/master
-
+
Fix y_scale problems in hb-gr
commit b24e93e3a4d98111c4684fa08e9080b471881d5c
@@ -52549,7 +51671,7 @@
Date: Tue Nov 24 18:37:35 2015 +0400
Merge pull request #185 from khaledhosny/travis-osx
-
+
[travis] Enable Mac OS X support
commit d538201918e6932ef7645f8d5b2c3491954936f8
@@ -52557,7 +51679,7 @@
Date: Tue Nov 24 12:46:35 2015 +0400
[travis] Enable Mac OS X support
-
+
Fixes https://github.com/behdad/harfbuzz/issues/182
.travis.yml | 22 ++++++++++++++++------
@@ -52568,7 +51690,7 @@
Date: Mon Nov 23 16:46:14 2015 -0600
[travis] Remove coverity scan
-
+
I never could get it to work, and it's a proprietary platform.
.travis.yml | 11 -----------
@@ -52589,12 +51711,10 @@
Date: Thu Nov 19 18:34:12 2015 +0800
Public headers: Decorate public symbols with HB_EXTERN
-
+
This prepares the headers for exporting symbols using visibility
- attributes or __declspec(dllexport), so that we do not need to
- maintain
- symbols listing files, as this is what was and is done in GLib
- and GTK+.
+ attributes or __declspec(dllexport), so that we do not need to maintain
+ symbols listing files, as this is what was and is done in GLib and GTK+.
src/hb-blob.h | 24 +++++-----
src/hb-buffer.h | 100 +++++++++++++++++++-------------------
@@ -52601,8 +51721,7 @@
src/hb-common.h | 22 ++++-----
src/hb-coretext.h | 6 +--
src/hb-face.h | 34 ++++++-------
- src/hb-font.h | 114
- ++++++++++++++++++++++----------------------
+ src/hb-font.h | 114 ++++++++++++++++++++++----------------------
src/hb-ft.h | 18 +++----
src/hb-glib.h | 8 ++--
src/hb-gobject-enums.h.tmpl | 2 +-
@@ -52637,7 +51756,7 @@
Date: Fri Nov 20 13:28:42 2015 -0800
Merge pull request #176 from behdad/missing-braces
-
+
Add braces for subobject initializer in _hb_font_funcs_nil
commit 1dc32ea4d2f294f9d1ae1c8fd19fb75f9278223b
@@ -52654,16 +51773,15 @@
Date: Fri Nov 20 13:21:29 2015 -0800
Define HB_MARK_AS_FLAG_T as a macro instead of using templates
-
- The generic template operator overloading was causing more problems
- than it
+
+ The generic template operator overloading was causing more problems than it
solved. Eg:
-
+
https://github.com/behdad/harfbuzz/pull/163
https://github.com/behdad/harfbuzz/issues/175
-
+
So, just use macros.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/175
Fixes https://github.com/behdad/harfbuzz/pull/178
@@ -52675,10 +51793,9 @@
Date: Fri Nov 20 08:43:49 2015 +0000
Add braces for subobject initializer in _hb_font_funcs_nil
+
+ To avoid triggering -Wmissing-braces; see https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c8
- To avoid triggering -Wmissing-braces; see
- https://bugzilla.mozilla.org/show_bug.cgi?id=1226175#c8
-
src/hb-font.cc | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
@@ -52687,17 +51804,16 @@
Date: Thu Nov 19 12:39:09 2015 -0800
Do not allow recursiving to same position and same lookup
-
+
This is just to make it harder to be extremely slow. There definitely
are ways still, just harder. Oh well... how do we tame this problem
without solving halting problem?!
-
+
Fixes https://github.com/behdad/harfbuzz/issues/174
src/hb-ot-layout-gsubgpos-private.hh | 5 +++++
test/shaping/fonts/sha1sum/MANIFEST | 1 +
- .../sha1sum/fab39d60d758cb586db5a504f218442cd1395725.ttf | Bin 0 ->
- 1894 bytes
+ .../sha1sum/fab39d60d758cb586db5a504f218442cd1395725.ttf | Bin 0 -> 1894 bytes
test/shaping/tests/fuzzed.tests | 1 +
4 files changed, 7 insertions(+)
@@ -52715,9 +51831,9 @@
Date: Thu Nov 19 11:59:03 2015 -0800
Revert "Fix hang in OOM situations"
-
+
This reverts commit f0599db761d7fc2d585d86e757a797f75ebc7499.
-
+
Commit abadc1717d997b69f987fdf1be9e12156d2d13d6 provides a better
fix for this.
@@ -52729,9 +51845,9 @@
Date: Thu Nov 19 11:50:58 2015 -0800
Revert "Make sure we make progress in OOM situations"
-
+
This reverts commit 68b507a3c3c62c28c38e13fee733702bb703b6ca.
-
+
Commit abadc1717d997b69f987fdf1be9e12156d2d13d6 provides a better
fix for this.
@@ -52763,10 +51879,10 @@
Date: Wed Nov 18 23:23:35 2015 -0800
[travis] Only coverity-scan the coverity_scan branch
-
+
This essentially disables coverity-scan right now, until we find
a pattern to continuously submit branches there.
-
+
For background reasoning, see:
Fixes https://github.com/behdad/harfbuzz/issues/171
@@ -52778,16 +51894,14 @@
Date: Wed Nov 18 23:09:13 2015 -0800
Add tests for previous two commits
-
+
To fully test what these are supposed to test, they should be run
against libharfbuzz-fuzzing.la instead of libharfbuzz.la, but for
now just record the files.
- .../sha1sum/43979b90b2dd929723cf4fe1715990bcb9c9a56b.ttf | Bin 0 ->
- 1804 bytes
+ .../sha1sum/43979b90b2dd929723cf4fe1715990bcb9c9a56b.ttf | Bin 0 -> 1804 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 ++
- .../sha1sum/b9e2aaa0d75fcef6971ec3a96d806ba4a6b31fe2.ttf | Bin 0 ->
- 1804 bytes
+ .../sha1sum/b9e2aaa0d75fcef6971ec3a96d806ba4a6b31fe2.ttf | Bin 0 -> 1804 bytes
test/shaping/tests/fuzzed.tests | 2 ++
4 files changed, 4 insertions(+)
@@ -52796,9 +51910,9 @@
Date: Wed Nov 18 23:04:45 2015 -0800
Fix another move_to assertion failure
-
+
If buf->idx is at end, don't set end past it...
-
+
Fixes https://github.com/behdad/harfbuzz/issues/173
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
@@ -52809,7 +51923,7 @@
Date: Wed Nov 18 17:52:08 2015 -0800
Try to better handle OOM situations
-
+
Fixes assert fail in https://github.com/behdad/harfbuzz/issues/161
with libharfbuzz-fuzzing.
@@ -52837,7 +51951,7 @@
Date: Wed Nov 18 16:27:32 2015 -0800
Enable building a bounded version of the library for fuzzing
-
+
test/fuzzing/hb-fuzzer links against libharfbuzz-fuzzing.so now.
src/Makefile.am | 16 ++++++++++++++++
@@ -52860,7 +51974,7 @@
Date: Tue Nov 17 18:40:10 2015 -0800
Merge pull request #163 from fanc999/msvc.src
-
+
Update the sources so they will compile under Visual Studio
commit 167c3271778cd1a8c4433b9d2230901ce17c099e
@@ -52868,24 +51982,17 @@
Date: Mon Nov 9 17:17:56 2015 +0800
Fix build on MSVC >= 2012
-
+
Use the DEFINE_ENUM_FLAG_OPERATORS macro in winnt.h on Visual Studio,
- which defines the bitwise operators for the enumerations that we
- want to
- mark as hb_mark_as_flags_t, which will take care of the situation
- on newer
- Visual Studio (>= 2012), where the build breaks with C2057 errors
- as the
- underlying types of the enumerations is not clear to the compiler
- when we
+ which defines the bitwise operators for the enumerations that we want to
+ mark as hb_mark_as_flags_t, which will take care of the situation on newer
+ Visual Studio (>= 2012), where the build breaks with C2057 errors as the
+ underlying types of the enumerations is not clear to the compiler when we
do a bitwise op within the declaration of the enumerations themselves.
-
- Also disable the C4200 (nonstandard extension used : zero-sized
- array in
- struct/union) and C4800 ('type' : forcing value to bool 'true' or
- 'false'
- (performance warning)) warnings as the C4200 is the intended
- scenario and
+
+ Also disable the C4200 (nonstandard extension used : zero-sized array in
+ struct/union) and C4800 ('type' : forcing value to bool 'true' or 'false'
+ (performance warning)) warnings as the C4200 is the intended scenario and
C4800 is harmless but is so far an unavoidable side effect of using
DEFINE_ENUM_FLAG_OPERATORS.
@@ -52901,7 +52008,7 @@
Date: Fri Nov 6 14:28:30 2015 +0800
hb-ot-shape-complex-arabic.cc: Fix build on Visual Studio
-
+
Visual Studio does not like declaring a enum variable within a for
statement, so fix the build by declaring the enum before doing the for
loop.
@@ -52914,11 +52021,9 @@
Date: Tue Nov 3 18:49:34 2015 +0800
MSVC builds: Add fallback implementation for pre-2013 MSVC
-
- Pre-2013 MSVC does not have scalbn() and scalbnf(), which are used
- in the
- utility programs. Add fallback implementations for these, which
- can be
+
+ Pre-2013 MSVC does not have scalbn() and scalbnf(), which are used in the
+ utility programs. Add fallback implementations for these, which can be
used when necessary.
util/options.hh | 17 +++++++++++++++++
@@ -52929,7 +52034,7 @@
Date: Mon Nov 2 16:55:29 2015 +0800
util: Fix build on Visual Studio
-
+
Use the fallback implementation for lround() only on pre-2013 Visual
Studio, and ensure we are clear about the types of the parameters for
lround() and scalbnf(), since Visual Studio can be quite picky on
@@ -52936,12 +52041,11 @@
ambiguous parameter types. Also, use g_ascii_strcasecmp() rather than
strcasecmp() as we are already using GLib for this code and we are
assured that g_ascii_strcasemp() is available.
-
+
For scalbnf() on pre-2013 Visaul Studio, a fallback implementation is
- needed, but use another forced-included header for those compilers,
- which
+ needed, but use another forced-included header for those compilers, which
will be added later.
-
+
Also use (char)27 on Visual Studio builds as '\e' is not a recognized
escape sequence, which will do the same thing.
@@ -52954,8 +52058,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue Nov 10 11:37:01 2015 -0800
- [util] Fix crash when --output-file is specified but not
- --output-format
+ [util] Fix crash when --output-file is specified but not --output-format
util/options.hh | 3 +++
1 file changed, 3 insertions(+)
@@ -52966,7 +52069,7 @@
Date: Sat Nov 7 07:50:58 2015 -0800
Merge pull request #167 from KonstantinRitt/unicode_cp_opt
-
+
Micro optimizations to UTF-16 and UTF-32 codecs
commit 04ff23e73d847ab3a5da0e9fac4fbca19aefd284
@@ -52974,7 +52077,7 @@
Date: Fri Nov 6 16:29:44 2015 -0800
[arabic] Improve stretch length calculation
-
+
Err on the side of being too short, than too wide. Reduces chance
of overlaps with neighboring glyphs.
@@ -52986,14 +52089,12 @@
Date: Fri Nov 6 16:27:44 2015 -0800
[arabic] Don't stretch over cased letters
-
+
Addresses
https://github.com/behdad/harfbuzz/commit/6e6f82b6f3dde0fc6c3c7d991d9ec6cfff57823d#commitcomment-14248516
- src/hb-ot-shape-complex-arabic.cc | 24
- +++++++++++++++++++++-
- src/hb-unicode-private.hh | 20
- ------------------
+ src/hb-ot-shape-complex-arabic.cc | 24 +++++++++++++++++++++-
+ src/hb-unicode-private.hh | 20 ------------------
.../script-syriac/misc/abbreviation-mark.txt | 4 ++--
3 files changed, 25 insertions(+), 23 deletions(-)
@@ -53002,9 +52103,9 @@
Date: Fri Nov 6 16:18:09 2015 -0800
Revert "Don't process lookups if buffer is in error"
-
+
This reverts commit f92bd86cc8c11d262d1830c631cb7c63fc9d4bc8.
-
+
We don't want to be like cairo, where as soon as there's an error,
nothing works anymore. So, lets process lookups as long as there's
no new memory needed. That's also a model that hides fewer bugs.
@@ -53017,7 +52118,7 @@
Date: Sat Nov 7 02:00:04 2015 +0400
Micro optimization to hb_utf16_t and hb_utf32_t ::prev()
-
+
Implement reverse lookup instead of re-using next()
src/hb-utf-private.hh | 29 +++++++++++++++++++----------
@@ -53065,11 +52166,10 @@
Date: Fri Nov 6 00:01:24 2015 -0800
[fuzzing] Add test case for OOM
-
+
From https://github.com/behdad/harfbuzz/issues/161
- .../sha1sum/3511ff5c1647150595846ac414c595cccac34f18.ttf | Bin 0 ->
- 1483 bytes
+ .../sha1sum/3511ff5c1647150595846ac414c595cccac34f18.ttf | Bin 0 -> 1483 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 +-
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 2 insertions(+), 1 deletion(-)
@@ -53079,7 +52179,7 @@
Date: Thu Nov 5 23:52:41 2015 -0800
Fix hang in OOM situations
-
+
Fixes https://github.com/behdad/harfbuzz/issues/161
src/hb-buffer-private.hh | 6 +++++-
@@ -53099,7 +52199,7 @@
Date: Thu Nov 5 23:44:59 2015 -0800
Limit buffer max size growth
-
+
https://github.com/behdad/harfbuzz/issues/161
src/hb-buffer-private.hh | 11 +++++++++++
@@ -53116,8 +52216,7 @@
configure.ac | 1 +
test/Makefile.am | 2 +-
- test/fuzzing/Makefile.am | 44
- ++++++++++++++++++++++++++++++++++++++++++++
+ test/fuzzing/Makefile.am | 44 ++++++++++++++++++++++++++++++++++++++++++++
test/fuzzing/README | 2 ++
test/fuzzing/hb-fuzzer.cc | 4 ++--
5 files changed, 50 insertions(+), 3 deletions(-)
@@ -53127,7 +52226,7 @@
Date: Thu Nov 5 22:50:52 2015 -0800
[fuzzer] Add README
-
+
https://github.com/behdad/harfbuzz/issues/139#issuecomment-154202645
test/fuzzing/README | 21 +++++++++++++++++++++
@@ -53138,16 +52237,15 @@
Date: Thu Nov 5 17:29:03 2015 -0800
Implement SYRIAC ABBREVIATION MARK with 'stch' feature
-
+
The feature is enabled for any character in the Arabic shaper.
We should experiment with using it for Arabic subtending marks.
Though, that has a directionality problem as well, since those
are used with digits...
-
+
Fixes https://github.com/behdad/harfbuzz/issues/141
- src/hb-ot-shape-complex-arabic.cc | 219
- ++++++++++++++++++++-
+ src/hb-ot-shape-complex-arabic.cc | 219 ++++++++++++++++++++-
src/hb-unicode-private.hh | 19 ++
.../shaper-arabic/script-syriac/misc/MANIFEST | 1 +
.../script-syriac/misc/abbreviation-mark.txt | 11 ++
@@ -53158,7 +52256,7 @@
Date: Thu Nov 5 17:33:57 2015 -0800
[ft] Fix extents with negative scales
-
+
Fixes https://github.com/behdad/harfbuzz/issues/162
src/hb-ft.cc | 10 ++++++++++
@@ -53178,9 +52276,9 @@
Date: Thu Nov 5 13:24:15 2015 -0800
Add new shaper method postprocess_glyphs()
-
+
Unused currently. To be used for Syriac stretch implementation.
-
+
https://github.com/behdad/harfbuzz/issues/141
src/hb-ot-shape-complex-arabic.cc | 3 ++-
@@ -53212,7 +52310,7 @@
Date: Wed Nov 4 22:55:11 2015 -0800
Don't try zeroing marks by GDEF if there are no non-ASCII
-
+
This one is a hack, but should be ok.
src/hb-ot-shape.cc | 4 ++++
@@ -53242,7 +52340,7 @@
Date: Wed Nov 4 22:42:41 2015 -0800
Skip GPOS cursive / attachment adjustmnent if none happened
-
+
I'm starting to really like how free these new scratch_flags are.
src/hb-ot-layout-gpos-table.hh | 3 +++
@@ -53271,7 +52369,7 @@
Date: Wed Nov 4 22:00:25 2015 -0800
Move variable-sized struct member to end
-
+
Hopefully makes clang build happy
src/hb-font-private.hh | 21 ++++++++++-----------
@@ -53292,7 +52390,7 @@
Date: Wed Nov 4 21:42:55 2015 -0800
Add font->has_...() to check for individual nil font funcs
-
+
Hopefully this wouldn't break any compiler. There was some magic
moments to getting this to compile...
@@ -53305,11 +52403,10 @@
Date: Wed Nov 4 21:16:26 2015 -0800
Minor reshaping of hb_font_funcs_t implementation
-
+
In anticipation of further changes. No functional changes.
- src/hb-font-private.hh | 80
- ++++++++++++++++++++++++++------------------------
+ src/hb-font-private.hh | 80 ++++++++++++++++++++++++++------------------------
src/hb-font.cc | 4 +--
2 files changed, 43 insertions(+), 41 deletions(-)
@@ -53328,8 +52425,7 @@
[ot] Remove font funcs that do nothing
- src/hb-ot-font.cc | 95
- ++++---------------------------------------------------
+ src/hb-ot-font.cc | 95 ++++---------------------------------------------------
1 file changed, 7 insertions(+), 88 deletions(-)
commit 75ea2daa1d9bbe235cd4a8570efb1913d58c3c62
@@ -53364,12 +52460,11 @@
Date: Wed Nov 4 20:22:44 2015 -0800
Separate nil font-funcs from parent-peeking font-funcs
-
+
API change: all fonts created with hb_font_create() now inherit from
(ie have parent) hb_font_get_empty().
- src/hb-font.cc | 211
- +++++++++++++++++++++++++++++++++++----------------
+ src/hb-font.cc | 211 +++++++++++++++++++++++++++++++++++----------------
test/api/test-font.c | 2 +-
2 files changed, 145 insertions(+), 68 deletions(-)
@@ -53378,12 +52473,11 @@
Date: Wed Nov 4 19:28:17 2015 -0800
Optimize positioning direction calculations
-
+
It makes the binary smaller AND faster. Yumm!
src/hb-font-private.hh | 40 +++++++++++++++++++++++++++++++++++++++
- src/hb-ot-shape.cc | 51
- +++++++++++++++++++++++++++-----------------------
+ src/hb-ot-shape.cc | 51 +++++++++++++++++++++++++++-----------------------
2 files changed, 68 insertions(+), 23 deletions(-)
commit e3e4bb011ae1a2f1ba05e7ea450595b185304bec
@@ -53402,7 +52496,7 @@
Date: Wed Nov 4 18:46:22 2015 -0800
Optimize runs without Default_Ignorable's
-
+
Now that we have a buffer-wide scratch flags facility, use it to
optimize away a few passes.
@@ -53418,10 +52512,10 @@
Date: Wed Nov 4 18:00:57 2015 -0800
Limit max edits during sanitize to 8
-
+
Used to be 100. If a tabe needs more than one or two edits, it's
probably completely bogus...
-
+
Might help with speeding up fuzzing for
https://github.com/behdad/harfbuzz/issues/157
@@ -53442,7 +52536,7 @@
Date: Wed Nov 4 17:45:06 2015 -0800
If font doesn't support U+2011, fall back to U+2010
-
+
Test passes now.
src/hb-ot-shape-normalize.cc | 10 ++++++++++
@@ -53454,8 +52548,7 @@
Untangle if/else waterfall
- src/hb-ot-shape-normalize.cc | 40
- +++++++++++++++++++++++++++-------------
+ src/hb-ot-shape-normalize.cc | 40 +++++++++++++++++++++++++++-------------
1 file changed, 27 insertions(+), 13 deletions(-)
commit 04fd8517f85ae9aa05b44f25578d2b19abfef7cb
@@ -53463,13 +52556,12 @@
Date: Wed Nov 4 17:38:22 2015 -0800
Add tests for hyphen fallback
-
+
U+2011 is <noBreak> equivaent of U+2010, so we should do the fallback
for it. Currently fails.
test/shaping/Makefile.am | 1 +
- .../sha1sum/1c04a16f32a39c26c851b7fc014d2e8d298ba2b8.ttf | Bin 0 ->
- 820 bytes
+ .../sha1sum/1c04a16f32a39c26c851b7fc014d2e8d298ba2b8.ttf | Bin 0 -> 820 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 ++
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/hyphens.tests | 2 ++
@@ -53489,20 +52581,19 @@
Date: Wed Nov 4 17:27:07 2015 -0800
Adjust the width of various spaces if font does not cover them
-
+
See discussion here:
https://github.com/behdad/harfbuzz/commit/81ef4f407d9c7bd98cf62cef951dc538b13442eb
-
+
There's no way to disable this fallback, but I don't think it would
be needed. Let's hope for the best!
-
+
Fixes https://github.com/behdad/harfbuzz/issues/153
src/hb-buffer-private.hh | 7 ++++
src/hb-buffer.cc | 2 ++
src/hb-ot-shape-fallback-private.hh | 4 +++
- src/hb-ot-shape-fallback.cc | 67
- +++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-fallback.cc | 67 +++++++++++++++++++++++++++++++++++++
src/hb-ot-shape-normalize.cc | 1 +
src/hb-ot-shape.cc | 3 ++
src/hb-unicode-private.hh | 56 +++++++++++++++++--------------
@@ -53528,23 +52619,21 @@
Date: Wed Nov 4 14:48:46 2015 -0800
Normalize various spaces to space if font doesn't support
-
+
This resurrects the space fallback feature, after I disabled
the compatibility decomposition. Now I can release HarfBuzz
again without breaking Pango!
-
+
It also remembers which space character it was, such that later
on we can approximate the width of this particular space
character. That part is not implemented yet.
-
+
We normalize all GC=Zs chars except for U+1680 OGHA SPACE MARK,
which is better left alone.
- src/hb-ot-layout-private.hh | 47
- +++------------------
+ src/hb-ot-layout-private.hh | 47 +++------------------
src/hb-ot-shape-normalize.cc | 12 +++++-
- src/hb-unicode-private.hh | 40
- ++++++++++++++++++
+ src/hb-unicode-private.hh | 40 ++++++++++++++++++
test/shaping/Makefile.am | 1 +
.../1c2c3fc37b2d4c3cb2ef726c6cdaaabd4b7f3eb9.ttf | Bin 0 -> 316 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
@@ -53575,7 +52664,7 @@
Date: Wed Nov 4 14:46:10 2015 -0800
Fix typo!
-
+
Ouch! Fortunately that function was unused.
src/hb-buffer-private.hh | 2 +-
@@ -53586,11 +52675,10 @@
Date: Wed Nov 4 14:18:39 2015 -0800
Add Unicode space category
-
+
Unused so far.
- src/hb-ot-layout-private.hh | 78
- +++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-layout-private.hh | 78 +++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 76 insertions(+), 2 deletions(-)
commit 8249ec3f86510fd24462ce71ed64a6978f0ade17
@@ -53617,7 +52705,7 @@
Date: Wed Nov 4 13:17:33 2015 -0800
Add _hb_glyph_info_is_unicode_mark()
-
+
Unused right now.
src/hb-ot-layout-private.hh | 6 ++++++
@@ -53647,22 +52735,21 @@
Date: Tue Nov 3 12:15:12 2015 -0800
[ot-font] Fix hmtx table length checking, *again*
-
+
Exactly the same problem that I fixed in
63ef0b41dc48d6112d1918c1b1de9de8ea90adb5
-
+
I rewrote the table checking yesterday in
67f8821fb25d9bd55719f5e29a582ae1af4b02b3
and introduced the exact same issue again. :(
Good thing we have ongoing fuzzing going now. Was discovered
immediately by libFuzzer. Thanks kcc!
-
+
https://github.com/behdad/harfbuzz/issues/139#issuecomment-153449473
Fixes https://github.com/behdad/harfbuzz/issues/156
src/hb-ot-font.cc | 4 ++--
- .../sha1sum/8240789f6d12d4cfc4b5e8e6f246c3701bcf861f.ttf | Bin 0 ->
- 633 bytes
+ .../sha1sum/8240789f6d12d4cfc4b5e8e6f246c3701bcf861f.ttf | Bin 0 -> 633 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/fuzzed.tests | 1 +
4 files changed, 4 insertions(+), 2 deletions(-)
@@ -53676,8 +52763,7 @@
util/helper-cairo.cc | 7 +++++--
util/main-font-text.hh | 22 ++++++++++++++++++---
util/options.cc | 21 ++++++++++----------
- util/options.hh | 53
- +++++++++++++++++++++++++++++++++-----------------
+ util/options.hh | 53 +++++++++++++++++++++++++++++++++-----------------
4 files changed, 70 insertions(+), 33 deletions(-)
commit 642135f3b2d6d6eb800153c76c4718239733c0e6
@@ -53685,11 +52771,11 @@
Date: Tue Nov 3 11:26:34 2015 -0800
[util] In --debug mode, duplicate font data
-
+
This has the effect that the font data will end up in a memory
section malloc()ed exactly to its size. This gives us better
valgrind detection of out-of-bounds access.
-
+
Previously, the font data was placed in a mmap()ed section or
GString-allocated area, which didn't have proper protections
at the end when running under valgrind.
@@ -53711,7 +52797,7 @@
Date: Mon Nov 2 17:52:45 2015 -0800
Remove irrelevant comment
-
+
I tried moving the is_default_ignorable() function to an INTERNAL
function. That made the binary size grow by 5k AND things got a
tad bit slower!
@@ -53734,11 +52820,10 @@
Date: Mon Nov 2 17:36:51 2015 -0800
Combine unicode_props0/1 into a uint16
-
+
Slightly faster. In prep for more changes.
- src/hb-ot-layout-private.hh | 55
- ++++++++++++++++++++++++---------------------
+ src/hb-ot-layout-private.hh | 55 ++++++++++++++++++++++++---------------------
1 file changed, 29 insertions(+), 26 deletions(-)
commit 71277185454482cff9b0c10b85c416eb4d6e0ed9
@@ -53746,10 +52831,9 @@
Date: Mon Nov 2 17:27:48 2015 -0800
[perf] Only call combining_class() for marks
+
+ Saves some time. Also preparing for reusing the ccc byte for other stuff.
- Saves some time. Also preparing for reusing the ccc byte for
- other stuff.
-
src/hb-ot-layout-private.hh | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
@@ -53758,7 +52842,7 @@
Date: Mon Nov 2 15:43:08 2015 -0800
Make max context-length and max nesting level configurable
-
+
...at compile time.
src/hb-ot-layout-common-private.hh | 10 ++++++++--
@@ -53771,9 +52855,8 @@
Date: Mon Nov 2 15:37:29 2015 -0800
[ot] Make bad-hmtx handling match FreeType
-
- Also route fuzzing-related tests through hb-ot-font, to reduce
- dependency
+
+ Also route fuzzing-related tests through hb-ot-font, to reduce dependency
on FreeType behavior for badly-broken fonts. Fixes failing test with
FreeType master.
@@ -53804,7 +52887,7 @@
Date: Wed Oct 21 17:20:55 2015 -0200
Disable compatibility decomposition usage during normalization
-
+
Fixes https://github.com/behdad/harfbuzz/issues/152
src/hb-ot-shape-normalize.cc | 24 ------------------------
@@ -53815,7 +52898,7 @@
Date: Wed Oct 21 11:23:12 2015 -0200
Fix two more -Wshadow warnings
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
src/hb-open-type-private.hh | 10 +++++-----
@@ -53826,7 +52909,7 @@
Date: Wed Oct 21 11:20:55 2015 -0200
Fix one more -Wshadow warning
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
src/hb-ot-layout-gsubgpos-private.hh | 6 +++---
@@ -53837,7 +52920,7 @@
Date: Wed Oct 21 11:16:49 2015 -0200
Fix a few more -Wshadow-local warnings
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
src/hb-ot-shape-complex-indic.cc | 10 +++++-----
@@ -53850,7 +52933,7 @@
Date: Wed Oct 21 11:13:21 2015 -0200
Fix one -Wshadow-compatible-local warning
-
+
From https://bugzilla.mozilla.org/show_bug.cgi?id=1215894
src/hb-ot-shape-complex-indic.cc | 4 ++--
@@ -53861,9 +52944,9 @@
Date: Wed Oct 21 11:10:10 2015 -0200
Avoid unnecessary cast to 64-bit
-
+
Fixes https://github.com/behdad/harfbuzz/issues/146
-
+
Or I think it should.
src/hb-private.hh | 2 +-
@@ -53874,7 +52957,7 @@
Date: Wed Oct 21 11:04:28 2015 -0200
Add HB_FALLTHROUGH
-
+
Borrowed from https://bugzilla.mozilla.org/show_bug.cgi?id=1215411
src/hb-ot-shape-complex-indic.cc | 2 +-
@@ -53889,8 +52972,7 @@
Add a prototype of DirectWrite as a shaping backend
- src/hb-directwrite.cc | 827
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-directwrite.cc | 827 ++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-directwrite.h | 34 +++
src/hb-shaper-list.hh | 3 +
3 files changed, 864 insertions(+)
@@ -53919,7 +53001,7 @@
Date: Tue Oct 20 15:19:41 2015 -0200
Merge pull request #148 from ebraminio/inst
-
+
Add BUILD.md based on harfbuzz.org docs
commit 904b0dc3811464cf61dc9457664de95ee4f61a86
@@ -53928,7 +53010,7 @@
Date: Mon Oct 19 16:59:43 2015 -0200
Merge pull request #147 from ebraminio/dockerci
-
+
[ci] change to docker infrastructure
commit ba096bcc28ca80e2096e0a15191848fcd175e395
@@ -53963,16 +53045,15 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Oct 15 20:20:22 2015 -0300
- [ft] Revert change-of-behavior of hb_ft_font_create() introduced
- in 1.0.5
-
+ [ft] Revert change-of-behavior of hb_ft_font_create() introduced in 1.0.5
+
The default FreeType load flags where changed from FT_LOAD_NO_HINTING
to FT_LOAD_DEFAULT in 2a9627c5641cd000e2adff0e42a0dc687b53ec70.
This is crashing HarfBuzz-enabled FreeType as I suppose it causes
infinite recursion between HB and FT autohinter...
-
+
Revert the behavior change.
-
+
Fixes https://github.com/behdad/harfbuzz/issues/143
src/hb-ft.cc | 2 +-
@@ -53983,15 +53064,13 @@
Date: Thu Oct 15 12:55:57 2015 -0300
Add tests for a couple of fixed issues found by libFuzzer
-
+
From:
https://github.com/behdad/harfbuzz/issues/139#issuecomment-147616887
https://github.com/behdad/harfbuzz/issues/139#issuecomment-148289957
- .../sha1sum/375d6ae32a3cbe52fbf81a4e5777e3377675d5a3.ttf | Bin 0 ->
- 1024 bytes
- .../sha1sum/641bd9db850193064d17575053ae2bf8ec149ddc.ttf | Bin 0 ->
- 305 bytes
+ .../sha1sum/375d6ae32a3cbe52fbf81a4e5777e3377675d5a3.ttf | Bin 0 -> 1024 bytes
+ .../sha1sum/641bd9db850193064d17575053ae2bf8ec149ddc.ttf | Bin 0 -> 305 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 ++
test/shaping/tests/fuzzed.tests | 2 ++
4 files changed, 4 insertions(+)
@@ -54001,9 +53080,9 @@
Date: Thu Oct 15 12:47:22 2015 -0300
[ot-font] Fix hmtx wrong table length check
-
+
Discovered by libFuzzer. Ouch!
-
+
https://github.com/behdad/harfbuzz/issues/139#issuecomment-148289957
src/hb-ot-font.cc | 2 +-
@@ -54014,11 +53093,11 @@
Date: Tue Oct 13 23:33:28 2015 -0300
Reduce max nesting level from 8 to 6
-
+
We probably should implement better system to catch cyclic lookups.
But for now, this speeds up worst case behavior with broken fonts
considerably without compromising legitimate usecases.
-
+
https://github.com/behdad/harfbuzz/issues/139#issuecomment-147788447
src/hb-ot-layout-common-private.hh | 2 +-
@@ -54039,7 +53118,7 @@
Date: Tue Oct 13 10:32:56 2015 -0300
[ot-font] Fix leak
-
+
https://github.com/behdad/harfbuzz/issues/139#issuecomment-147616887
src/hb-ot-font.cc | 1 +
@@ -54051,8 +53130,7 @@
Add test for previous commit
- .../sha1sum/0509e80afb379d16560e9e47bdd7d888bebdebc6.ttf | Bin 0 ->
- 61 bytes
+ .../sha1sum/0509e80afb379d16560e9e47bdd7d888bebdebc6.ttf | Bin 0 -> 61 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 2 insertions(+)
@@ -54062,10 +53140,9 @@
Date: Tue Oct 13 00:30:50 2015 -0400
Fix another memory access issue discovered by libFuzzer
+
+ Fixes https://github.com/behdad/harfbuzz/issues/139#issuecomment-146984679
- Fixes
- https://github.com/behdad/harfbuzz/issues/139#issuecomment-146984679
-
src/hb-ot-layout-gpos-table.hh | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
@@ -54074,11 +53151,10 @@
Date: Mon Oct 12 17:39:52 2015 -0400
[fuzz] Add fuzzing script from kcc@
-
+
https://github.com/behdad/harfbuzz/issues/139
- test/fuzzing/hb-fuzzer.cc | 47
- +++++++++++++++++++++++++++++++++++++++++++++++
+ test/fuzzing/hb-fuzzer.cc | 47 +++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 47 insertions(+)
commit cc6ea308d4c99b9dd6d625fa3a9b0ef62fa2614f
@@ -54096,8 +53172,7 @@
Add test for ee9b0b6cb5fdb08671ab064f26c299135f828260
- .../sha1sum/5a5daf5eb5a4db77a2baa3ad9c7a6ed6e0655fa8.ttf | Bin 0 ->
- 61 bytes
+ .../sha1sum/5a5daf5eb5a4db77a2baa3ad9c7a6ed6e0655fa8.ttf | Bin 0 -> 61 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/fuzzed.tests | 1 +
3 files changed, 2 insertions(+)
@@ -54116,7 +53191,7 @@
Date: Fri Oct 9 14:23:15 2015 -0400
Fix another sanitize bug
-
+
Also discovered by "libFuzzer".
src/hb-open-type-private.hh | 2 +-
@@ -54129,8 +53204,7 @@
Add test for previous fix
test/shaping/Makefile.am | 1 +
- .../sha1sum/1a6f1687b7a221f9f2c834b0b360d3c8463b6daf.ttf | Bin 0 ->
- 64 bytes
+ .../sha1sum/1a6f1687b7a221f9f2c834b0b360d3c8463b6daf.ttf | Bin 0 -> 64 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/fuzzed.tests | 1 +
@@ -54141,10 +53215,10 @@
Date: Fri Oct 9 12:25:55 2015 -0400
Fix return value of sanitize when subformat is not readable
-
+
This is a fix on top of the previous issue fixed in
c917965b9e6fe2b21ed6c51559673288fa3af4b7.
-
+
This was caught by "libFuzzer" testing.
src/hb-open-type-private.hh | 2 ++
@@ -54160,8 +53234,7 @@
Add hb_dispatch_context_t
src/hb-open-type-private.hh | 26 ++++++++++++++++++++++----
- src/hb-ot-layout-gsubgpos-private.hh | 36
- ++++++++++++------------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 36 ++++++++++++------------------------
src/hb-ot-layout.cc | 8 +++-----
3 files changed, 37 insertions(+), 33 deletions(-)
@@ -54170,7 +53243,7 @@
Date: Thu Oct 8 12:51:02 2015 -0400
Add hb_font_set_parent()
-
+
No reason to not have it. Makes life easier later.
We (hb-ft, hb-ot-font, etc) can use this API to inject new
parent into a font...
@@ -54194,15 +53267,14 @@
Date: Wed Oct 7 17:33:20 2015 -0400
[ft] API: Add hb_font_[sg]et_load_flags() API
-
+
This changes the default load_flags of fonts created using
hb_ft_font_create() from NO_HINTING to DEFAULT. Hope that doesn't
break too much client code.
-
+
Code calling hb_ft_font_set_funcs() is unaffected.
- src/hb-ft.cc | 163
- +++++++++++++++++++++++++++++++++++++++--------------------
+ src/hb-ft.cc | 163 +++++++++++++++++++++++++++++++++++++++--------------------
src/hb-ft.h | 13 +++--
2 files changed, 118 insertions(+), 58 deletions(-)
@@ -54220,9 +53292,8 @@
Date: Sat Oct 3 13:20:55 2015 +0100
Allow compiling with custom allocators
-
- User can define hb_malloc_impl, etc, to name of custom allocator
- functions
+
+ User can define hb_malloc_impl, etc, to name of custom allocator functions
that have the same signature as malloc.
src/hb-private.hh | 17 +++++++++++++++++
@@ -54233,7 +53304,7 @@
Date: Fri Oct 2 14:38:20 2015 +0100
Default font scale to face upem
-
+
Makes for a better default and avoids nasty inheritance issues.
See mailing list thread "Default hb_font_t scale".
@@ -54246,7 +53317,7 @@
Date: Fri Oct 2 14:21:29 2015 +0100
Make hb_font_create_sub_font() NOT make parent immutable
-
+
We don't rely on that. However, whenever hb_font_make_immutable()
is called, it makes its parenting chain immutable.
@@ -54259,7 +53330,7 @@
Date: Fri Oct 2 08:21:12 2015 +0100
Fix hb-ot-shape-normalize with empty buffer
-
+
Part of https://github.com/behdad/harfbuzz/issues/136
src/hb-ot-shape-normalize.cc | 2 ++
@@ -54281,10 +53352,9 @@
Date: Fri Oct 2 07:25:52 2015 +0100
Fix segfault with empty buffer in hb_shape_plan_execute()
-
- Move the empty-buffer check from hb_shape_full() to
- hb_shape_plan_execute().
-
+
+ Move the empty-buffer check from hb_shape_full() to hb_shape_plan_execute().
+
Reported by Simon Cozens.
src/hb-shape-plan.cc | 9 +++++++--
@@ -54306,7 +53376,7 @@
Date: Tue Sep 29 14:57:02 2015 +0100
Define return_trace()
-
+
Not functional change (expected!).
src/hb-open-file-private.hh | 20 +--
@@ -54319,8 +53389,7 @@
src/hb-ot-layout-common-private.hh | 108 ++++++-------
src/hb-ot-layout-gdef-table.hh | 44 ++---
src/hb-ot-layout-gpos-table.hh | 252 +++++++++++++++--------------
- src/hb-ot-layout-gsub-table.hh | 304
- ++++++++++++++++++-----------------
+ src/hb-ot-layout-gsub-table.hh | 304 ++++++++++++++++++-----------------
src/hb-ot-layout-gsubgpos-private.hh | 205 +++++++++++------------
src/hb-ot-layout-jstf-table.hh | 35 ++--
src/hb-ot-maxp-table.hh | 5 +-
@@ -54333,9 +53402,9 @@
Date: Tue Sep 29 14:45:35 2015 +0100
Add missing returns
-
+
Fixes possible invalid read of two bytes.
-
+
Reported by Behzad Najjarpour Jabbari, Secunia Research.
src/hb-ot-layout-gpos-table.hh | 14 +++++++-------
@@ -54348,7 +53417,7 @@
Date: Tue Sep 29 14:34:56 2015 +0100
Micro-optimize hb_language_from_string()
-
+
As measured / improved by Benson Limketkai.
src/hb-common.cc | 10 +++++-----
@@ -54359,13 +53428,13 @@
Date: Sun Jun 28 03:29:47 2015 +0200
Handle language tags that indicate phonetic IPA transcription
-
+
The BCP-47 registry defines a variant subtag "fonipa" that can be used
in combination with arbitrary other language tags. For example,
"rm-CH-fonipa-sursilv" indicates the Sursilvan dialect of Romansh
as used in Switzerland, transcribed used the International Phonetic
Alphabet.
-
+
http://www.iana.org/assignments/language-subtag-registry/language-subtag-registry
src/hb-ot-tag.cc | 15 ++++++++++++++-
@@ -54377,13 +53446,12 @@
Date: Thu Sep 3 15:53:22 2015 +0430
Fix Since tags
-
+
Fixes https://github.com/behdad/harfbuzz/issues/103
src/hb-blob.cc | 24 +++++++++----------
src/hb-buffer-serialize.cc | 10 ++++----
- src/hb-buffer.cc | 58
- +++++++++++++++++++++++-----------------------
+ src/hb-buffer.cc | 58 +++++++++++++++++++++++-----------------------
src/hb-buffer.h | 9 +++++++
src/hb-common.cc | 24 +++++++++----------
src/hb-common.h | 3 +++
@@ -54404,16 +53472,14 @@
Date: Thu Sep 3 14:55:59 2015 +0430
Fix Since: version tags on font and face APIs
-
- A while back we marked every API as version:1.0. We should fix
- them all
+
+ A while back we marked every API as version:1.0. We should fix them all
to reflect real version they were introduced. This is a start.
-
+
Patch from Nikolay Sivov.
src/hb-face.cc | 22 ++++++++---------
- src/hb-font.cc | 76
- +++++++++++++++++++++++++++++-----------------------------
+ src/hb-font.cc | 76 +++++++++++++++++++++++++++++-----------------------------
2 files changed, 49 insertions(+), 49 deletions(-)
commit 7f5405397406a24c5a001b5ef43dcf4d6926415e
@@ -54476,7 +53542,7 @@
Date: Tue Sep 1 16:15:25 2015 +0100
[myanmar] Use buffer->sort() to sort cluster
-
+
This can possibly produce more granular clusters.
src/hb-ot-shape-complex-myanmar.cc | 3 +--
@@ -54487,7 +53553,7 @@
Date: Tue Sep 1 16:13:32 2015 +0100
[OT] Merge clusters when reordering marks for normalization
-
+
Fixes https://bugzilla.gnome.org/show_bug.cgi?id=541608
and cluster test.
@@ -54501,12 +53567,11 @@
Date: Tue Sep 1 16:12:44 2015 +0100
[tests] Add Hebrew test for normalization under cluster-level=1
-
+
Currently fails.
https://bugzilla.gnome.org/show_bug.cgi?id=541608
- .../sha1sum/43ef465752be9af900745f72fe29cb853a1401a5.ttf | Bin 0 ->
- 4272 bytes
+ .../sha1sum/43ef465752be9af900745f72fe29cb853a1401a5.ttf | Bin 0 -> 4272 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/cluster.tests | 1 +
3 files changed, 2 insertions(+)
@@ -54525,7 +53590,7 @@
Date: Tue Sep 1 15:07:52 2015 +0100
Use insertion-sort instead of bubble-sort
-
+
Needed for upcoming merge-clusters fix.
src/hb-buffer.cc | 4 +--
@@ -54533,8 +53598,7 @@
src/hb-ot-shape-complex-indic.cc | 2 +-
src/hb-ot-shape-complex-myanmar.cc | 2 +-
src/hb-ot-shape-normalize.cc | 6 ++--
- src/hb-private.hh | 56
- +++++++++++++-----------------
+ src/hb-private.hh | 56 +++++++++++++-----------------
6 files changed, 34 insertions(+), 42 deletions(-)
commit fad2674874591b4a1df822603144c8864f5364c1
@@ -54564,13 +53628,11 @@
[docs] Move docs/reference/ contents into docs/
configure.ac | 3 +-
- docs/Makefile.am | 117
- ++++++++++++++++++++++++++-
+ docs/Makefile.am | 117 ++++++++++++++++++++++++++-
docs/{reference => }/harfbuzz-docs.xml | 0
docs/{reference => }/harfbuzz-overrides.txt | 0
docs/{reference => }/harfbuzz-sections.txt | 0
- docs/reference/Makefile.am | 118
- ----------------------------
+ docs/reference/Makefile.am | 118 ----------------------------
docs/{reference => }/usermanual-ch01.xml | 0
docs/{reference => }/usermanual-ch02.xml | 0
docs/{reference => }/usermanual-ch03.xml | 0
@@ -54602,7 +53664,7 @@
Date: Mon Aug 31 10:46:01 2015 +0100
Merge pull request #131 from simoncozens/docs
-
+
Use gtk-doc to build user's manual as well as reference
commit 01e16e88f50b65b82dcb84773f532f18a351319f
@@ -54611,8 +53673,7 @@
Combine user / reference information into gtk-doc generated manual.
- docs/reference/harfbuzz-docs.xml | 91
- +++++++++++++++++++++++-----------------
+ docs/reference/harfbuzz-docs.xml | 91 +++++++++++++++++++++++-----------------
1 file changed, 52 insertions(+), 39 deletions(-)
commit 11a07c4729174e1d4af028103ecb0a351e4c2707
@@ -54652,7 +53713,7 @@
Date: Mon Aug 31 09:53:16 2015 +0100
Merge pull request #129 from simoncozens/docs
-
+
First two chapters. More to follow.
commit 31594b98af0c9181982c77d8d3803753007f8fd4
@@ -54660,7 +53721,7 @@
Date: Sun Aug 30 17:33:04 2015 +0100
[test] Fix test-object
-
+
See previous commit.
test/api/test-object.c | 4 ----
@@ -54671,19 +53732,14 @@
Date: Sun Aug 30 17:29:21 2015 +0100
Poison freed objects such that double-free is detected
-
- Previously we were setting refcount of freed objects to the inert
- value, which
- was harmful because it caused further destroy()s of the freed object
- to NOT
- call free() and hence hide the bug. Indeed, after eb0bf3ae6688b7
- test-object
- was double-free'ing objects and this was never caught on Linux.
- It only was
+
+ Previously we were setting refcount of freed objects to the inert value, which
+ was harmful because it caused further destroy()s of the freed object to NOT
+ call free() and hence hide the bug. Indeed, after eb0bf3ae6688b7 test-object
+ was double-free'ing objects and this was never caught on Linux. It only was
caught as crashing on Mac.
-
- Now we poison refcount upon freeing and check that it's valid
- whenever reading
+
+ Now we poison refcount upon freeing and check that it's valid whenever reading
it. Makes test-object fail now.
src/hb-object-private.hh | 21 ++++++++++++++++-----
@@ -54695,8 +53751,7 @@
Current state and skeleton outline
- docs/usermanual-ch03.xml | 77
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ docs/usermanual-ch03.xml | 77 ++++++++++++++++++++++++++++++++++++++++++++++++
docs/usermanual-ch04.xml | 18 +++++++++++
docs/usermanual-ch05.xml | 13 ++++++++
docs/usermanual-ch06.xml | 8 +++++
@@ -54707,7 +53762,7 @@
Date: Tue Aug 25 20:24:59 2015 +0100
[GPOS] Fix cursive connection with mix of RTL and non-RTL lookups
-
+
See thread "Issue with cursive attachment" started by Khaled.
Turned out fixing this wasn't as bad as I had assumed. I like the
new code better; we now have a theoretical model of cursive
@@ -54721,17 +53776,15 @@
Date: Tue Aug 25 20:28:39 2015 +0100
[test] Add test for cursive-positioning with mixed directions
-
+
Fails now. Fix coming. See thread "Issue with cursive attachment"
started by Khaled. Test fonts were made by modifying test font
from Khaled to add more anchors.
test/shaping/Makefile.am | 1 +
- .../sha1sum/298c9e1d955f10f6f72c6915c3c6ff9bf9695cec.ttf | Bin 0 ->
- 2520 bytes
+ .../sha1sum/298c9e1d955f10f6f72c6915c3c6ff9bf9695cec.ttf | Bin 0 -> 2520 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 ++
- .../sha1sum/c4e48b0886ef460f532fb49f00047ec92c432ec0.ttf | Bin 0 ->
- 2512 bytes
+ .../sha1sum/c4e48b0886ef460f532fb49f00047ec92c432ec0.ttf | Bin 0 -> 2512 bytes
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/cursive-positioning.tests | 2 ++
6 files changed, 6 insertions(+)
@@ -54743,8 +53796,7 @@
First two chapters. More to follow.
docs/usermanual-ch01.xml | 115 ++++++++++++++++++++++++++++++
- docs/usermanual-ch02.xml | 182
- +++++++++++++++++++++++++++++++++++++++++++++++
+ docs/usermanual-ch02.xml | 182 +++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 297 insertions(+)
commit 58f2a73fb95af42e264a91cdef7bb5a89e965601
@@ -54752,7 +53804,7 @@
Date: Tue Aug 25 18:55:34 2015 +0100
[GPOS] Rewrite cursive attachment slightly differently
-
+
In anticipation for upcoming fix for bug reported by
Khaled in thread "Issue with cursive attachment".
@@ -54764,11 +53816,11 @@
Date: Mon Aug 24 13:49:55 2015 +0100
Add API/cmdline to show glyph extents when serializing buffer
-
+
New API: HB_BUFFER_SERIALIZE_FLAG_GLYPH_EXTENTS
-
+
hb-shape now accepts --show-extents.
-
+
Patch from Simon Cozens.
src/hb-buffer-serialize.cc | 17 +++++++++++++++++
@@ -54792,7 +53844,7 @@
Date: Sun Aug 23 14:42:20 2015 +0100
[ot-font] Implement glyph_extents() for TrueType fonts
-
+
This brings ot-fonts into almost-complete shape and mostly in par with
ft font.
@@ -54799,8 +53851,7 @@
src/Makefile.am | 1 +
src/hb-font.h | 9 +++--
src/hb-ot-font.cc | 90 +++++++++++++++++++++++++++++++++++++++--
- src/hb-ot-glyf-table.hh | 104
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-glyf-table.hh | 104 ++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-head-table.hh | 3 +-
5 files changed, 198 insertions(+), 9 deletions(-)
@@ -54818,7 +53869,7 @@
Date: Thu Aug 20 15:39:53 2015 +0100
[coretext] Use i32 instead of u32 as well
-
+
Shouldn't cause *any* functional changes, but is more correct.
src/hb-coretext.cc | 20 ++++++++++----------
@@ -54829,7 +53880,7 @@
Date: Thu Aug 20 15:39:06 2015 +0100
[uniscribe] Fix negative offsets
-
+
Ouch!
src/hb-uniscribe.cc | 8 ++++----
@@ -54859,7 +53910,7 @@
Date: Wed Aug 19 13:20:31 2015 +0100
[uniscribe] Fix font scale handling
-
+
By default shape at upem (or ppem), and scale results.
Similar to work done in CoreText backend, but using upem as default.
@@ -54871,7 +53922,7 @@
Date: Tue Aug 18 18:55:03 2015 +0100
Commented-out code to print buffer before each lookup
-
+
To be turned into a useful HB_DEBUG_SHAPE infrastructure...
src/hb-ot-layout.cc | 12 ++++++++++++
@@ -54882,7 +53933,7 @@
Date: Tue Aug 18 18:47:02 2015 +0100
Allow serializing buffer with output-buffer being used
-
+
Ie, don't call get_positions() if positions are not
requested for serialization.
@@ -54894,7 +53945,7 @@
Date: Tue Aug 18 18:42:47 2015 +0100
[ot] Change buffer content type right after we map to glyphs
-
+
Needed for upcoming debug output changes.
src/hb-ot-shape.cc | 2 ++
@@ -54914,7 +53965,7 @@
Date: Tue Aug 18 15:55:09 2015 +0100
Don't declare dependency on freetype in harfbuzz.pc
-
+
See comments.
src/Makefile.am | 7 ++++++-
@@ -54937,7 +53988,7 @@
Date: Tue Aug 18 10:22:16 2015 +0100
[coretext] Remove assert that kicks in on Mac OS 10.6
-
+
http://crbug.com/419769
src/hb-coretext.cc | 18 ++++++++++++++----
@@ -54973,7 +54024,7 @@
Date: Tue Aug 11 12:58:49 2015 +0200
Add Libs.private and Requires.private to harfbuzz.pc
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=64501
configure.ac | 12 +++++++++---
@@ -54986,7 +54037,7 @@
Date: Fri Aug 7 17:55:03 2015 +0100
Don't rely on .cluster in _hb_ot_shape_normalize()
-
+
Fixes https://github.com/behdad/harfbuzz/pull/124
src/hb-ot-shape-normalize.cc | 2 +-
@@ -54997,9 +54048,9 @@
Date: Fri Aug 7 17:51:28 2015 +0100
Don't rely on .cluster field in fallback_position
-
+
Fixes tests/cluster.
-
+
Fixes https://github.com/behdad/harfbuzz/pull/123
src/hb-ot-shape-fallback.cc | 5 ++---
@@ -55010,13 +54061,12 @@
Date: Sat Aug 8 18:02:18 2015 +0200
[tests] Add test for fallback positioning with cluster_level > 0
-
+
For https://github.com/behdad/harfbuzz/pull/123
Currently fails. Fix coming.
test/shaping/Makefile.am | 1 +
- .../sha1sum/6466d38c62e73a39202435a4f73bf5d6acbb73c0.ttf | Bin 0 ->
- 824 bytes
+ .../sha1sum/6466d38c62e73a39202435a4f73bf5d6acbb73c0.ttf | Bin 0 -> 824 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/cluster.tests | 1 +
@@ -55026,9 +54076,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Aug 7 11:13:27 2015 +0200
- Bug 91559 - HarfBuzz 1.0.1: Inconsistent DLL files
- specified/created...
-
+ Bug 91559 - HarfBuzz 1.0.1: Inconsistent DLL files specified/created...
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=91559
src/Makefile.am | 2 +-
@@ -55040,7 +54089,7 @@
Date: Mon Aug 3 22:47:18 2015 +0300
Merge pull request #122 from RomainNaour/static-fix
-
+
fix static linking with icu-uc
commit 160f635523d596f61e292776f638d4eb09673463
@@ -55048,14 +54097,14 @@
Date: Wed Jul 22 23:26:23 2015 +0200
fix static linking with icu-uc
-
+
When linking test-unicode statically it needs $(ICU_LIBS)
which contains all required flags.
Especially -lstdc++.
-
+
Fixes:
http://autobuild.buildroot.net/results/210/2107f9dfb39eeb6559fb4271c7af8b39aef521ca/
-
+
Signed-off-by: Romain Naour <romain.naour at openwide.fr>
test/api/Makefile.am | 2 +-
@@ -55122,15 +54171,13 @@
Date: Wed Jul 8 23:28:11 2015 +0200
Update UCDN to upstream commit 8af93f30
-
- This adds support for Unicode 8.0 and fixes a bug with wrong
- properties
+
+ This adds support for Unicode 8.0 and fixes a bug with wrong properties
for ranges of codepoints.
src/hb-ucdn.cc | 6 +
src/hb-ucdn/ucdn.h | 6 +
- src/hb-ucdn/unicodedata_db.h | 2167
- +++++++++++++++++++++---------------------
+ src/hb-ucdn/unicodedata_db.h | 2167 +++++++++++++++++++++---------------------
3 files changed, 1118 insertions(+), 1061 deletions(-)
commit 786ba45847127b9cd4d9c0c01ae0e6c61f3a8e06
@@ -55138,11 +54185,10 @@
Date: Thu Jul 23 13:04:34 2015 +0100
[test] Encode Kharoshti text
-
+
Ouch!
- .../in-tree/shaper-use/script-kharoshti/misc.txt | 72
- +++++++++++-----------
+ .../in-tree/shaper-use/script-kharoshti/misc.txt | 72 +++++++++++-----------
1 file changed, 36 insertions(+), 36 deletions(-)
commit b4231255032e243153a6f32cf8c93c158cb0bf6a
@@ -55155,8 +54201,7 @@
.../texts/in-tree/shaper-use/script-batak/MANIFEST | 1 +
.../texts/in-tree/shaper-use/script-batak/misc.txt | 9 +++
.../in-tree/shaper-use/script-buginese/MANIFEST | 1 +
- .../in-tree/shaper-use/script-buginese/misc.txt | 70
- ++++++++++++++++++++++
+ .../in-tree/shaper-use/script-buginese/misc.txt | 70 ++++++++++++++++++++++
5 files changed, 83 insertions(+)
commit b8c159ffccad090974a2b97be0a0140fa09af132
@@ -55165,26 +54210,16 @@
[test] Remove shaper-sea texts under shaper-use
- test/shaping/texts/in-tree/MANIFEST |
- 1 -
- test/shaping/texts/in-tree/shaper-sea/MANIFEST |
- 2 --
- test/shaping/texts/in-tree/shaper-sea/script-cham/MANIFEST |
- 1 -
- test/shaping/texts/in-tree/shaper-sea/script-tai-tham/MANIFEST |
- 1 -
- test/shaping/texts/in-tree/shaper-use/MANIFEST |
- 2 ++
- .../{shaper-sea/script-cham/misc => shaper-use/script-cham}/MANIFEST
- | 0
- .../{shaper-sea/script-cham/misc => shaper-use/script-cham}/misc.txt
- | 0
- .../script-tai-tham/misc => shaper-use/script-tai-tham}/MANIFEST
- | 0
- .../script-tai-tham/misc => shaper-use/script-tai-tham}/misc.txt
- | 0
- .../script-tai-tham/misc => shaper-use/script-tai-tham}/torture.txt
- | 0
+ test/shaping/texts/in-tree/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-sea/MANIFEST | 2 --
+ test/shaping/texts/in-tree/shaper-sea/script-cham/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-sea/script-tai-tham/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-use/MANIFEST | 2 ++
+ .../{shaper-sea/script-cham/misc => shaper-use/script-cham}/MANIFEST | 0
+ .../{shaper-sea/script-cham/misc => shaper-use/script-cham}/misc.txt | 0
+ .../script-tai-tham/misc => shaper-use/script-tai-tham}/MANIFEST | 0
+ .../script-tai-tham/misc => shaper-use/script-tai-tham}/misc.txt | 0
+ .../script-tai-tham/misc => shaper-use/script-tai-tham}/torture.txt | 0
10 files changed, 2 insertions(+), 5 deletions(-)
commit 67ba7320cc5545baeacfcff64cea338223b9bd6d
@@ -55192,17 +54227,13 @@
Date: Thu Jul 23 12:58:21 2015 +0100
[test] Remove New Tai Lue texts
-
+
New Tai Lue changed encoding to visual, boring, model.
- test/shaping/texts/in-tree/shaper-sea/MANIFEST |
- 1 -
- test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/MANIFEST |
- 1 -
- test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/misc/MANIFEST |
- 1 -
- test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/misc/misc.txt |
- 1 -
+ test/shaping/texts/in-tree/shaper-sea/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/misc/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-sea/script-new-tai-lue/misc/misc.txt | 1 -
4 files changed, 4 deletions(-)
commit c81d957a264539dfe3252f9a94ee066c4a44edf4
@@ -55212,8 +54243,7 @@
[test] Add tests for improved 'vert' feature
test/shaping/Makefile.am | 1 +
- .../sha1sum/191826b9643e3f124d865d617ae609db6a2ce203.ttf | Bin 0 ->
- 2140 bytes
+ .../sha1sum/191826b9643e3f124d865d617ae609db6a2ce203.ttf | Bin 0 -> 2140 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/vertical.tests | 1 +
@@ -55224,7 +54254,7 @@
Date: Thu Jul 23 12:49:09 2015 +0100
[test] Add recently added test
-
+
Ouch.
test/shaping/Makefile.am | 1 +
@@ -55236,8 +54266,7 @@
[test] Support additional options to hb-shape in micro-test suite
- test/shaping/record-test.sh | 47
- ++++++++++++++++++----
+ test/shaping/record-test.sh | 47 ++++++++++++++++++----
test/shaping/run-tests.sh | 9 ++++-
test/shaping/tests/arabic-fallback-shaping.tests | 2 +-
test/shaping/tests/arabic-feature-order.tests | 6 +--
@@ -55255,9 +54284,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Jul 23 11:52:11 2015 +0100
- [ot] Search globally for 'vert' feature if not found in specified
- script/lang
-
+ [ot] Search globally for 'vert' feature if not found in specified script/lang
+
Fixes https://github.com/behdad/harfbuzz/issues/63
src/hb-ot-layout-private.hh | 9 +++++++++
@@ -55309,8 +54337,7 @@
Add test case for deleting default ignorables with positioning
- .../sha1sum/051d92f8bc6ff724511b296c27623f824de256e9.ttf | Bin 0 ->
- 2028 bytes
+ .../sha1sum/051d92f8bc6ff724511b296c27623f824de256e9.ttf | Bin 0 -> 2028 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/default-ignorables.tests | 1 +
@@ -55320,9 +54347,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Jul 22 18:41:10 2015 +0100
- Fix hide-default-ignorables after
- f0010dfd01ef4a927b0bdc175dd4e343a8637174
-
+ Fix hide-default-ignorables after f0010dfd01ef4a927b0bdc175dd4e343a8637174
+
We can't delete things before hb_ot_layout_position_finish(). So,
just zero the advance before it, and remove later.
@@ -55334,13 +54360,12 @@
Date: Wed Jul 22 18:28:39 2015 +0100
Fix hide-ignorables if font doesn't have space glyph
-
+
Was broken by 82b521aeb7cc73879b44ca4278d6fa8b4347527f, as we have
positioning data by then and can't use the output buffer. Ouch!
src/hb-buffer-private.hh | 18 ------------------
- src/hb-ot-shape.cc | 44
- +++++++++++++++++++++++++++++++++++---------
+ src/hb-ot-shape.cc | 44 +++++++++++++++++++++++++++++++++++---------
2 files changed, 35 insertions(+), 27 deletions(-)
commit 4ba796b26ee62de0d2830a550f3aa3b4aecf6f59
@@ -55359,16 +54384,15 @@
Date: Wed Jul 22 17:36:23 2015 +0100
[ot] Hide default-ignorables before finishing off positioning
-
+
For example, fixes the following sequence with Arial XP:
628 25cc 651 25cc 64e 3a 20 628 651 34f 64e
628 25cc 64e 25cc 651 3a 20 628 64e 34f 651
-
+
Discovered as part of:
https://bugs.freedesktop.org/show_bug.cgi?id=85873
- src/hb-ot-shape.cc | 125
- +++++++++++++++++++++++++++--------------------------
+ src/hb-ot-shape.cc | 125 +++++++++++++++++++++++++++--------------------------
1 file changed, 63 insertions(+), 62 deletions(-)
commit 376d587f36b4ff10342ee6ca3bacd73532ea44c8
@@ -55376,15 +54400,14 @@
Date: Wed Jul 22 16:51:12 2015 +0100
Implement more granular cluster-merging
-
+
TODO: Documentation.
-
+
Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=71445
NEWS | 8 +++++++
src/hb-buffer-private.hh | 1 +
- src/hb-buffer.cc | 46
- ++++++++++++++++++++++++++++++++++-----
+ src/hb-buffer.cc | 46 ++++++++++++++++++++++++++++++++++-----
src/hb-buffer.h | 12 ++++++++++
src/hb-ot-shape-complex-hangul.cc | 13 +++++------
src/hb-ot-shape.cc | 7 ++++++
@@ -55416,8 +54439,7 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Wed Jul 22 15:24:26 2015 +0100
- [ot] Don't mirror character if font doesn't support mirrored
- character!
+ [ot] Don't mirror character if font doesn't support mirrored character!
src/hb-ot-shape.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -55427,11 +54449,10 @@
Date: Wed Jul 22 14:28:25 2015 +0100
[graphite2] Fix bunch of stuff
-
+
Based on patch from Martin Hosken, with review from Jonathan and I.
- src/hb-graphite2.cc | 82
- +++++++++++++++++++++++++++++++++++------------------
+ src/hb-graphite2.cc | 82 +++++++++++++++++++++++++++++++++++------------------
1 file changed, 54 insertions(+), 28 deletions(-)
commit ea7f8414e34d4b5efc7b98974637c08f75440f0e
@@ -55448,12 +54469,11 @@
Date: Wed Jul 22 13:27:06 2015 +0100
[USE] Implement topographical features for non-Arabic-joining scripts
-
+
This works per-syllable as per the spec, but we think it should be per
spacing/base/??? glyph instead.
- src/hb-ot-shape-complex-use.cc | 87
- ++++++++++++++++++++++++++++++++++++++----
+ src/hb-ot-shape-complex-use.cc | 87 ++++++++++++++++++++++++++++++++++++++----
1 file changed, 80 insertions(+), 7 deletions(-)
commit ecb0b24ef3f8177e7c789f45a2e858bd67e31be3
@@ -55462,8 +54482,7 @@
Use foreach_cluster in Indic shaper
- src/hb-ot-shape-complex-indic.cc | 90
- +++++++++-------------------------------
+ src/hb-ot-shape-complex-indic.cc | 90 +++++++++-------------------------------
1 file changed, 19 insertions(+), 71 deletions(-)
commit 56f71ff98890fc4fd13e8d9743dc34c4b9407309
@@ -55472,8 +54491,7 @@
Use foreach_syllable in Myanmar shaper
- src/hb-ot-shape-complex-myanmar.cc | 62
- ++++++++------------------------------
+ src/hb-ot-shape-complex-myanmar.cc | 62 ++++++++------------------------------
1 file changed, 12 insertions(+), 50 deletions(-)
commit ac596511a8c9eeaeb455ca16b5b9c5f1b9923b3a
@@ -55481,12 +54499,11 @@
Date: Wed Jul 22 11:54:02 2015 +0100
Add foreach_syllable
-
+
Use it in USE.
src/hb-ot-layout-private.hh | 24 ++++++++
- src/hb-ot-shape-complex-use.cc | 129
- +++++++++++++----------------------------
+ src/hb-ot-shape-complex-use.cc | 129 +++++++++++++----------------------------
2 files changed, 64 insertions(+), 89 deletions(-)
commit 8ba9e689680f7685c04cfe7c6019222bdf0c52b0
@@ -55495,8 +54512,7 @@
[USE] Do Arabic-like shaping
- src/hb-ot-shape-complex-use.cc | 77
- ++++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-shape-complex-use.cc | 77 ++++++++++++++++++++++++++++++++++++++++--
1 file changed, 75 insertions(+), 2 deletions(-)
commit 9daf2dfb6bd5683fd951bdf166c8b87938257e52
@@ -55506,8 +54522,7 @@
Add hb-ot-shape-complex-arabic-private.hh
src/Makefile.am | 1 +
- src/hb-ot-shape-complex-arabic-private.hh | 50
- +++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-arabic-private.hh | 50 +++++++++++++++++++++++++++++++
src/hb-ot-shape-complex-arabic.cc | 37 +++++++++++++----------
3 files changed, 73 insertions(+), 15 deletions(-)
@@ -55525,7 +54540,7 @@
Date: Tue Jul 21 18:09:40 2015 +0100
[USE] Don't compose split matras
-
+
Same logic as in Indic shaper.
src/hb-ot-shape-complex-use.cc | 15 ++++++++++++++-
@@ -55539,8 +54554,7 @@
src/Makefile.am | 4 -
src/hb-ot-shape-complex-sea-machine.rl | 102 ---------
- src/hb-ot-shape-complex-sea.cc | 380
- ---------------------------------
+ src/hb-ot-shape-complex-sea.cc | 380 ---------------------------------
3 files changed, 486 deletions(-)
commit db1e9cdd41ff7c97c29b4d9b64b2351ed0ef0403
@@ -55557,7 +54571,7 @@
Date: Tue Jul 21 17:31:43 2015 +0100
[USE] Only use USE shaper if script system is not DFLT
-
+
Same logic as Indic and SEA.
src/hb-ot-shape-complex-private.hh | 13 ++++++++++---
@@ -55568,15 +54582,12 @@
Date: Tue Jul 21 17:24:18 2015 +0100
Route misc untested scripts through USE shaper instead of Indic
-
- These were never tested with Indic shaper, and indeed wouldn't
- work there
- because they didn't have their viramas and other config defined.
- They are
+
+ These were never tested with Indic shaper, and indeed wouldn't work there
+ because they didn't have their viramas and other config defined. They are
all also supported by MS through USE, so route them there.
- src/hb-ot-shape-complex-private.hh | 91
- +++++---------------------------------
+ src/hb-ot-shape-complex-private.hh | 91 +++++---------------------------------
1 file changed, 11 insertions(+), 80 deletions(-)
commit 40c4a991c7ea18017273ff8993eecc3953869e69
@@ -55584,7 +54595,7 @@
Date: Tue Jul 21 17:14:54 2015 +0100
[USE] Implement dotted-circle
-
+
This makes USE feature-complete as far as the Indic-like features
are concerned.
@@ -55610,8 +54621,7 @@
[USE] Fix-up variation selectors and word joiner in table
src/gen-use-table.py | 7 ++++++-
- src/hb-ot-shape-complex-use-table.cc | 34
- +++++++++++++++++++++++-----------
+ src/hb-ot-shape-complex-use-table.cc | 34 +++++++++++++++++++++++-----------
2 files changed, 29 insertions(+), 12 deletions(-)
commit ad7178227f16abc17456f122deac1508031cbbc3
@@ -55621,8 +54631,7 @@
[USE] Use a couple warnings
src/gen-use-table.py | 20 ++++-----
- src/hb-ot-shape-complex-use-table.cc | 82
- ++++++++++++++++++------------------
+ src/hb-ot-shape-complex-use-table.cc | 82 ++++++++++++++++++------------------
2 files changed, 51 insertions(+), 51 deletions(-)
commit a85c4da9b1750c2f994f9f85226a3e755fafe50b
@@ -55631,8 +54640,7 @@
[USE] Move rphf
- src/hb-ot-shape-complex-use.cc | 105
- ++++++++++++++---------------------------
+ src/hb-ot-shape-complex-use.cc | 105 ++++++++++++++---------------------------
1 file changed, 35 insertions(+), 70 deletions(-)
commit 5b5617e0664e59770910d04d15175f643a5ffb73
@@ -55640,7 +54648,7 @@
Date: Tue Jul 21 15:52:15 2015 +0100
Add FLAG_UNSAFE()
-
+
Unused right now.
src/hb-private.hh | 1 +
@@ -55651,7 +54659,7 @@
Date: Tue Jul 21 15:50:02 2015 +0100
Add FLAG_SAFE() for values known to be small-enough
-
+
And add check to FLAG()
src/hb-ot-shape-complex-arabic.cc | 2 +-
@@ -55696,8 +54704,7 @@
[USE] Use use_category() for rphf/pref memory
- src/hb-ot-shape-complex-use.cc | 63
- +++++++++++++++---------------------------
+ src/hb-ot-shape-complex-use.cc | 63 +++++++++++++++---------------------------
1 file changed, 22 insertions(+), 41 deletions(-)
commit 595936ec25e9c0924851bd1aa1af5eed3723b54f
@@ -55705,12 +54712,11 @@
Date: Tue Jul 21 14:15:35 2015 +0100
[USE] Hook of rphf and pref custom processing
-
+
Still no reordering.
src/hb-ot-layout-private.hh | 8 ++
- src/hb-ot-shape-complex-use.cc | 181
- +++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-shape-complex-use.cc | 181 +++++++++++++++++++++++++++++++++++++++--
2 files changed, 181 insertions(+), 8 deletions(-)
commit ba72801325e4bd58f7597938d4409762c9fa530c
@@ -55729,8 +54735,7 @@
[USE] Set up features
- src/hb-ot-shape-complex-use.cc | 68
- +++++++++++++++++++++++-------------------
+ src/hb-ot-shape-complex-use.cc | 68 +++++++++++++++++++++++-------------------
1 file changed, 38 insertions(+), 30 deletions(-)
commit 52a957795697085a5d379921ddd8aa6cf2f1a99d
@@ -55738,12 +54743,11 @@
Date: Tue Jul 21 10:02:04 2015 +0100
[USE] Hook up new scripts to USE shaper
-
+
Don't reroute scripts that we were routing to other shapers
before (just yet).
- src/hb-ot-shape-complex-private.hh | 71
- ++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-private.hh | 71 ++++++++++++++++++++++++++++++++++++++
1 file changed, 71 insertions(+)
commit b4c0829bc18b696f140a260fa2e1089d10164519
@@ -55752,8 +54756,7 @@
[USE] Remove unused Unicode data enums from USE C++ side
- src/hb-ot-shape-complex-use-private.hh | 66
- +---------------------------------
+ src/hb-ot-shape-complex-use-private.hh | 66 +---------------------------------
src/hb-ot-shape-complex-use.cc | 14 ++------
2 files changed, 3 insertions(+), 77 deletions(-)
@@ -55762,12 +54765,11 @@
Date: Mon Jul 20 18:01:10 2015 +0100
[USE] Finish converting Unicode positional categories to USE
-
+
Even compiles.
src/gen-use-table.py | 114 +++++-
- src/hb-ot-shape-complex-use-table.cc | 702
- ++++++++++++++++++-----------------
+ src/hb-ot-shape-complex-use-table.cc | 702 ++++++++++++++++++-----------------
2 files changed, 467 insertions(+), 349 deletions(-)
commit ad725552521273a1f571f04bc96a04221c3e067a
@@ -55775,12 +54777,11 @@
Date: Mon Jul 20 17:00:06 2015 +0100
[USE] Map from Unicode data to USE syllabic categories
-
+
Positional sub-categories not applied yet.
src/gen-use-table.py | 128 ++--
- src/hb-ot-shape-complex-use-table.cc | 1062
- ++++++++++++----------------------
+ src/hb-ot-shape-complex-use-table.cc | 1062 ++++++++++++----------------------
2 files changed, 409 insertions(+), 781 deletions(-)
commit 20e246e674155d5fb6527722fc3ef3accf2413df
@@ -55790,8 +54791,7 @@
[USE] Start moving Unicode-to-USE mapping into Python code
src/Makefile.am | 2 +-
- src/gen-use-table.py | 176
- +++++++++++++++++++++++++++++++++--
+ src/gen-use-table.py | 176 +++++++++++++++++++++++++++++++++--
src/hb-ot-shape-complex-use-table.cc | 3 +-
3 files changed, 169 insertions(+), 12 deletions(-)
@@ -55800,7 +54800,7 @@
Date: Mon Jul 20 15:33:25 2015 +0100
[USE] Fix Number clusters
-
+
The spec wrongly has "H" where "HN" is meant.
src/hb-ot-shape-complex-use-machine.rl | 4 ++--
@@ -55813,8 +54813,7 @@
[USE] Start putting together the shaper body
src/hb-ot-shape-complex-use-private.hh | 2 +-
- src/hb-ot-shape-complex-use.cc | 339
- +++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-use.cc | 339 +++++++++++++++++++++++++++++++++
2 files changed, 340 insertions(+), 1 deletion(-)
commit e0eabd7f67462ac34fbfc749d897be478fbd1224
@@ -55822,13 +54821,11 @@
Date: Mon Jul 20 13:30:51 2015 +0100
[USE] Put a Ragel machine together
-
+
Grammar from the spec!
- src/hb-ot-shape-complex-use-machine.rl | 169
- +++++++++++++++++++++++++++++++++
- src/hb-ot-shape-complex-use-private.hh | 160
- +++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-use-machine.rl | 169 +++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-use-private.hh | 160 +++++++++++++++++++++++++++++++
2 files changed, 329 insertions(+)
commit fd74b939b176f47d34d34b3d33e2a09d255c2d9e
@@ -55859,8 +54856,7 @@
test/shaping/texts/in-tree/MANIFEST | 1 +
test/shaping/texts/in-tree/shaper-use/MANIFEST | 1 +
.../in-tree/shaper-use/script-kharoshti/MANIFEST | 1 +
- .../in-tree/shaper-use/script-kharoshti/misc.txt | 36
- ++++++++++++++++++++++
+ .../in-tree/shaper-use/script-kharoshti/misc.txt | 36 ++++++++++++++++++++++
4 files changed, 39 insertions(+)
commit c48ff288522f33dc6c78520de0a0a74306630895
@@ -55870,8 +54866,7 @@
[USE] Build Universal Shaping Engine data table from Unicode 8 files
src/gen-use-table.py | 35 +-
- src/hb-ot-shape-complex-use-table.cc | 1016
- ++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-use-table.cc | 1016 ++++++++++++++++++++++++++++++++++
2 files changed, 1032 insertions(+), 19 deletions(-)
commit e2c95116e1423f83a692d6170553d0cc95733d24
@@ -55881,8 +54876,7 @@
[USE] Add Universal Shaping Engine to Makefile
src/Makefile.am | 23 +++-
- src/gen-use-table.py | 237
- +++++++++++++++++++++++++++++++++
+ src/gen-use-table.py | 237 +++++++++++++++++++++++++++++++++
src/hb-ot-shape-complex-use-machine.rl | 0
src/hb-ot-shape-complex-use-private.hh | 0
src/hb-ot-shape-complex-use-table.cc | 0
@@ -55903,7 +54897,7 @@
Date: Wed Jul 15 01:36:39 2015 +0100
Add Unicode 8.0 scripts
-
+
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1183209
src/hb-common.cc | 3 +++
@@ -55915,16 +54909,15 @@
Date: Sun Jul 5 22:43:17 2015 +0100
Fix pragma usage
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=91228
-
+
Commit cdcdfe61b97a0a48ccf834b6d924d187da9609be changed two `#pragma
- message` to `#pragma error` in hb-unicode.cc, however MSVC uses
- #error,
+ message` to `#pragma error` in hb-unicode.cc, however MSVC uses #error,
just like the #else branch. `#pragma error` is an unknown pragma so
MSVC does not fail the build because of it, which I believe was the
intention of that commit.
-
+
If it's meant to be an #error, then the #ifdef for _MSC_VER can be
removed entirely.
@@ -55945,8 +54938,7 @@
Author: ThePhD <phdofthehouse at gmail.com>
Date: Tue Jun 23 09:07:17 2015 -0400
- Back to using regular `strdup`, with an `hb-private.hh` fix that
- special-cases VC++'s
+ Back to using regular `strdup`, with an `hb-private.hh` fix that special-cases VC++'s
definition and usage of the words
src/hb-common.cc | 2 +-
@@ -55975,7 +54967,7 @@
Date: Fri Jun 19 13:31:49 2015 -0700
When removing default-ignorables, merge clusters
-
+
Fixes test-shape, and:
https://code.google.com/p/chromium/issues/detail?id=497578
@@ -55989,15 +54981,14 @@
Date: Fri Jun 19 11:57:57 2015 -0700
Rewrite hide_default_ignorables
-
+
Separate the loops for the two cases of replacing with space
and deleting. For deleting, use the out-buffer machinery.
-
+
Needed for upcoming cluster merge fix.
src/hb-buffer-private.hh | 18 ++++++++++++++
- src/hb-ot-shape.cc | 65
- +++++++++++++++++++++++++++++-------------------
+ src/hb-ot-shape.cc | 65 +++++++++++++++++++++++++++++-------------------
2 files changed, 57 insertions(+), 26 deletions(-)
commit b3a2f6afbac1956b65f29a17b9dc896e86135329
@@ -56005,15 +54996,13 @@
Date: Thu Jun 18 17:15:33 2015 -0700
[test] Add test for cluster merging
-
- Based on test from
- https://code.google.com/p/chromium/issues/detail?id=497578
-
+
+ Based on test from https://code.google.com/p/chromium/issues/detail?id=497578
+
Currently fails. Basically, if there's a default_ignorable at the
- start of text, and font has no space glyph, we remove the
- default_ignorable,
+ start of text, and font has no space glyph, we remove the default_ignorable,
and that makes the first char in text to correspond to no cluster.
-
+
Fix coming.
test/api/test-shape.c | 43 +++++++++++++++++++++++++++++++++++++++++++
@@ -56034,7 +55023,7 @@
Date: Thu Jun 18 10:55:13 2015 -0700
[util] Disable hb-fc-list for now
-
+
Until I figure out what to do about the API, and finalize
the tool.
@@ -56046,7 +55035,7 @@
Date: Fri Jun 12 17:46:06 2015 -0700
[bindings] Fix hb_language_get_default() and hb_ot_tag_to_language()
-
+
Part of https://github.com/behdad/harfbuzz/issues/91
src/hb-common.cc | 2 +-
@@ -56058,7 +55047,7 @@
Date: Fri Jun 12 17:37:41 2015 -0700
[TravisCI] Hook up Coverity
-
+
First try...
.travis.yml | 13 +++++++++++++
@@ -56078,7 +55067,7 @@
Date: Wed Jun 10 10:57:46 2015 -0700
Fix warnings: "member call on null pointer of type"
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1167119
src/hb-private.hh | 4 ++--
@@ -56108,7 +55097,7 @@
Date: Mon Jun 1 13:27:37 2015 -0700
Merge pull request #111 from brawer/since
-
+
Fix "Since:" tags
commit 01c3a88543850c87483fd8671044df53b368c520
@@ -56116,7 +55105,7 @@
Date: Mon Jun 1 13:22:01 2015 +0200
Fix "Since:" tags
-
+
Based on data from http://upstream-tracker.org/versions/harfbuzz.html
Resolves #103
@@ -56131,8 +55120,7 @@
src/hb-ot-font.cc | 3 +++
src/hb-ot-layout.cc | 30 ++++++++++++++++++++++++++++
src/hb-ot-shape.cc | 6 ++++++
- src/hb-set.cc | 52
- ++++++++++++++++++++++++------------------------
+ src/hb-set.cc | 52 ++++++++++++++++++++++++------------------------
src/hb-shape-plan.cc | 18 ++++++++---------
src/hb-shape.cc | 8 ++++----
src/hb-unicode.cc | 6 +++---
@@ -56144,15 +55132,14 @@
Date: Thu May 21 14:00:15 2015 -0700
Fix unary minus operator applied to unsigned int
-
+
Applying unary minus operator to unsigned int causes the following
warning on MSVS:
-
- warning C4146: unary minus operator applied to unsigned type,
- result still unsigned
-
+
+ warning C4146: unary minus operator applied to unsigned type, result still unsigned
+
Based on patch from Koji Ishi.
-
+
Fixes https://github.com/behdad/harfbuzz/pull/110
src/hb-ot-font.cc | 2 +-
@@ -56163,16 +55150,15 @@
Date: Tue May 19 17:42:30 2015 -0700
[gobject] Remove hb_language_t workarounds for g-i shortcomings
-
+
Using latest gobject-introspection, I don't seem to be having this
problem anymore:
-
+
https://bugzilla.gnome.org/show_bug.cgi?id=707656
-
- Removing that kludge makes language_t behave more like the way I
- expect it
+
+ Removing that kludge makes language_t behave more like the way I expect it
in Python.
-
+
Also fixes:
https://github.com/behdad/harfbuzz/issues/91
@@ -56185,11 +55171,10 @@
Date: Tue May 19 17:20:58 2015 -0700
[gobject] Macroize value types
-
+
Fixes user_data_t
- src/hb-gobject-structs.cc | 73
- +++++++++++------------------------------------
+ src/hb-gobject-structs.cc | 73 +++++++++++------------------------------------
1 file changed, 17 insertions(+), 56 deletions(-)
commit 9df099b4837df722e738675af318efcc9ac39a78
@@ -56216,7 +55201,7 @@
Date: Thu May 7 10:46:42 2015 -0700
Merge pull request #105 from ebraminio/master
-
+
Fix Travis CI config to pass again
commit 74139f9839f69ea3e7a1d17627f52fea6c06d58a
@@ -56242,7 +55227,7 @@
Date: Tue May 5 22:31:19 2015 -0700
[minor] Remove comment about Navajo OpenType code.
-
+
Apparently the code is already standardized:
https://www.microsoft.com/typography/otspec/languagetags.htm
@@ -56255,7 +55240,7 @@
Date: Tue May 5 14:49:47 2015 -0700
Merge pull request #102 from roozbehp/master
-
+
Add OpenType language tag 'NAV ' for Navajo.
commit c60f3c8e1156fe7328d42851013cca97333c3bf7
@@ -56272,7 +55257,7 @@
Date: Mon May 4 23:09:51 2015 -0700
[travis] Comment out gobject-introspection again
-
+
Apparently the version on Travis is 1.32.0, while we require 1.34.0.
.travis.yml | 4 ++--
@@ -56301,12 +55286,11 @@
Date: Wed Jan 8 02:28:55 2014 +0200
Some attempt into initial hb-shape documentation
-
+
Very anaemic, needs to descripe the format understood by
hb_feature_from_string() etc., but it is just start.
- src/hb-shape.cc | 70
- ++++++++++++++++++++++++++++++++++++++-------------------
+ src/hb-shape.cc | 70 ++++++++++++++++++++++++++++++++++++++-------------------
src/hb-shape.h | 3 ---
2 files changed, 47 insertions(+), 26 deletions(-)
@@ -56325,7 +55309,7 @@
Date: Wed Apr 29 09:32:42 2015 -0700
Add OpenType language tag 'NAV ' for Navajo.
-
+
The code is not standardized yet, but is used in some Google fonts.
src/hb-ot-tag.cc | 1 +
@@ -56354,7 +55338,7 @@
Date: Thu Apr 23 14:32:33 2015 -0700
[test] Ignor 'n' and 'i' in hb-unicode-encode
-
+
Allows accepting uniXXXX format.
test/shaping/hb_test_tools.py | 2 +-
@@ -56374,7 +55358,7 @@
Date: Tue Apr 21 19:21:32 2015 -0700
[coretext] Fix positioning with trailing whitespace
-
+
Fixes https://code.google.com/p/chromium/issues/detail?id=476913
src/hb-coretext.cc | 11 +++++++++++
@@ -56394,9 +55378,9 @@
Date: Tue Apr 14 13:32:22 2015 -0700
Revert "Add MSVC pragma for UTF-8 source code"
-
+
This reverts commit 89cbd4d9533011fb5487caa99a0cd58923e7cf59.
-
+
See discussion:
https://bugzilla.gnome.org/show_bug.cgi?id=747772
@@ -56418,7 +55402,7 @@
Date: Mon Apr 13 23:40:35 2015 -0700
Merge pull request #86 from cpfair/hb-shape-output-help-improvement
-
+
Improve hb-shape/hb-view's help text w.r.t. output options
commit 89cbd4d9533011fb5487caa99a0cd58923e7cf59
@@ -56426,7 +55410,7 @@
Date: Mon Apr 13 12:27:08 2015 -0700
Add MSVC pragma for UTF-8 source code
-
+
Not sure we have any right now; motivated by this:
https://bugzilla.gnome.org/show_bug.cgi?id=747772
@@ -56439,7 +55423,7 @@
Date: Fri Apr 10 14:34:05 2015 -0700
Merge pull request #99 from khaledhosny/introspection-fixes2
-
+
More ntrospection fixes
commit 22524a514f6609a2bc009b6035f6b5b932c719c7
@@ -56447,7 +55431,7 @@
Date: Fri Apr 10 18:14:45 2015 +0200
[bindings] Fix hb_buffer_get_segment_properties
-
+
Annotate the output parameter.
src/hb-buffer.cc | 2 +-
@@ -56466,7 +55450,7 @@
Date: Fri Apr 10 12:19:57 2015 -0700
Merge pull request #98 from KonstantinRitt/WEC2013
-
+
Fix build on WEC2013
commit 04f89e8f7dfdb882e8c98afb613cba3f1d02ed7d
@@ -56474,7 +55458,7 @@
Date: Fri Apr 10 17:49:01 2015 +0200
[bindings] Fix ownership of returned hb_language_t
-
+
It should not be freed by the caller.
src/hb-buffer.cc | 2 +-
@@ -56486,7 +55470,7 @@
Date: Fri Apr 10 17:18:01 2015 +0400
Fix build on WEC2013
-
+
Based on patch from Björn Breitmeyer
src/hb-private.hh | 4 +++-
@@ -56497,7 +55481,7 @@
Date: Wed Aug 6 16:49:51 2014 -0400
[utils] Add hb-fc-list
-
+
This is a tool that lists all fonts that can render a given string.
It uses hb_shape() to do so, and as such is aware of HarfBuzz's
normalizer.
@@ -56504,8 +55488,7 @@
configure.ac | 19 +++++
util/Makefile.am | 15 ++++
- util/hb-fc-list.c | 222
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++
+ util/hb-fc-list.c | 222 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
util/hb-fc.cc | 149 ++++++++++++++++++++++++++++++++++++
util/hb-fc.h | 46 +++++++++++
5 files changed, 451 insertions(+)
@@ -56515,14 +55498,14 @@
Date: Wed Aug 6 15:36:41 2014 -0400
Relax inert checks
-
+
Previously, when creating an object from inert inputs (eg:
"hb_font_create(hb_face_get_empty())") we returned the inert
empty object. This is not helpful as there are legitimate
usecases to do that.
-
+
We now never return the inert object unless allocation failed.
-
+
Tests are revised to reflect.
src/hb-face.cc | 4 ++--
@@ -56538,8 +55521,7 @@
[util/hb-view] Fix rendering with all combinations of negative scales
- util/view-cairo.cc | 90
- ++++++++++++++++++++++++++++--------------------------
+ util/view-cairo.cc | 90 ++++++++++++++++++++++++++++--------------------------
util/view-cairo.hh | 2 --
2 files changed, 47 insertions(+), 45 deletions(-)
@@ -56556,11 +55538,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Apr 9 15:04:42 2015 -0700
- [util] Accept comma as well as space when separating components
- of args
-
+ [util] Accept comma as well as space when separating components of args
+
Applies to --font-size and --margin.
-
+
Hopefully the scanf usage here doesn't have compatibility issues
(star being counted in the return value, etc).
@@ -56599,7 +55580,7 @@
Date: Wed Apr 8 14:39:00 2015 -0700
Fix warnings
-
+
Part of https://github.com/behdad/harfbuzz/pull/68
src/hb-ot-font.cc | 4 ++--
@@ -56611,7 +55592,7 @@
Date: Wed Apr 8 13:25:04 2015 -0700
Err, instead of warn, if mutex / atomic / unicode funcs are missing
-
+
Hopefully this results in fewer badly built HarfBuzz integrations.
src/hb-unicode.cc | 8 ++++----
@@ -56633,17 +55614,16 @@
Date: Sat Mar 28 00:49:33 2015 +0400
Minor refactoring to the atomics implementation
-
+
s/atomic_int/atomic_int_impl/ and s/atomic_ptr/atomic_ptr_impl/
to bring it in par with hb_mutex_impl_t, then re-introduce
hb_atomic_int_t as a wrapper around hb_atomic_int_impl_t.
-
+
In hb_reference_count_t, make it clear the non-atomic get and set
are intentional due to nature of the cases they are used in
(comparison to -1 and the debug output/tracing).
- src/hb-atomic-private.hh | 86
- +++++++++++++++++++++++++++++++-----------------
+ src/hb-atomic-private.hh | 86 +++++++++++++++++++++++++++++++-----------------
src/hb-mutex-private.hh | 4 ++-
src/hb-object-private.hh | 21 ++++++------
3 files changed, 69 insertions(+), 42 deletions(-)
@@ -56662,7 +55642,7 @@
Date: Wed Apr 8 12:49:38 2015 -0700
Allow implementing atomic and mutex ops in config
-
+
Motivated by
https://github.com/behdad/harfbuzz/pull/92
@@ -56684,9 +55664,9 @@
Date: Mon Apr 6 14:51:31 2015 -0700
[test] Use /usr/bin/env python instead of /usr/bin/python
-
+
Bug 76494 - #!/usr/bin/python in testsuite
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=76494
test/shaping/hb-diff | 2 +-
@@ -56708,7 +55688,7 @@
Date: Mon Apr 6 14:41:32 2015 -0700
Merge pull request #93 from ebraminio/archpy3
-
+
Make hb_test_tools.py compatible with python 3
commit ce01ad7c2f5a259030f4dbec746f85522aa9c3f9
@@ -56734,15 +55714,14 @@
Date: Mon Mar 30 03:27:14 2015 +0430
Make hb_test_tools.py compatible with python 3
-
+
On ArchLinux, /usr/bin/python is linked to python 3 so
HarfBuzz `make check` is broken there.
-
+
This makes hb_test_tools.py compatible with python 3 while
no breaking it on python 2.
- test/shaping/hb_test_tools.py | 44
- ++++++++++++++++++++++++-------------------
+ test/shaping/hb_test_tools.py | 44 ++++++++++++++++++++++++-------------------
1 file changed, 25 insertions(+), 19 deletions(-)
commit aee685086c8fde6f6c4590e483a177c19f222540
@@ -56750,7 +55729,7 @@
Date: Thu Mar 26 14:13:53 2015 -0400
Fix VC++ /analyze warnings
-
+
out\debug\hb-buffer-deserialize-text.rl(47) : warning C6001: Using
uninitialized memory 'pos'.
@@ -56763,7 +55742,7 @@
Date: Sun Mar 22 16:18:57 2015 -0400
Merge pull request #90 from khaledhosny/introspection-fixes
-
+
[bindings] Fix *_from_string functions
commit a394bb66707184c995fe2d08c80e98220e6ec0b0
@@ -56771,7 +55750,7 @@
Date: Sun Mar 22 20:29:10 2015 +0200
[bindings] Fix *_from_string functions
-
+
Without the element-type they will be getting garbage, at least with
Python.
@@ -56795,9 +55774,9 @@
Date: Fri Mar 20 16:08:38 2015 -0400
Fix reverse_range() for empty range
-
+
Fixes coretext notdef loop consisting of all default_ignorable glyphs
-
+
https://code.google.com/p/chromium/issues/detail?id=464755
src/hb-buffer.cc | 2 +-
@@ -56808,7 +55787,7 @@
Date: Wed Mar 4 15:47:25 2015 -0800
Fix previous commit
-
+
I misunderstood how which works.
autogen.sh | 2 +-
@@ -56819,7 +55798,7 @@
Date: Wed Mar 4 15:43:05 2015 -0800
Accept glibtoolize as libtoolize
-
+
Of course, we don't really run it, autoreconf does. We just
err if neither is available. glibtoolize is the name it is
shipped under on OS X. Reported by Adam.
@@ -56851,7 +55830,7 @@
Date: Mon Mar 2 16:06:55 2015 -0800
Fix reverse_range() to only reverse alt array if positions are used
-
+
In hb-coretext, when we were using scratch buffer for book-keeping,
a reverse_range() caused by the notdef-insertion loop could mess up
our log_clusters. Ouch!
@@ -56864,7 +55843,7 @@
Date: Thu Feb 26 13:58:32 2015 -0800
Better error message if libtool is not installed
-
+
Fixes https://github.com/behdad/harfbuzz/pull/88
autogen.sh | 9 +++++++--
@@ -56938,12 +55917,11 @@
Date: Sat Feb 21 12:50:01 2015 +0300
[layout] Fix comparison of GlyphID and hb_codepoint_t
-
+
Before, the IntType::cmp functions providing this and was truncating
the hb_codepoint_t to 16bits before comparison. I have no idea how
this was never discovered, and I'm too lazy to try to reproduce this
- with Pango (which uses non-16bit codepoint numbers for missing
- glyphs).
+ with Pango (which uses non-16bit codepoint numbers for missing glyphs).
src/hb-open-type-private.hh | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
@@ -56979,12 +55957,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Feb 19 17:30:05 2015 +0300
- [layout] If lookup has only one subtable, move the forward loop down
- to subtable
+ [layout] If lookup has only one subtable, move the forward loop down to subtable
+
+ I was hoping to see a nice speedup, but it resulted in a very minor one.
- I was hoping to see a nice speedup, but it resulted in a very
- minor one.
-
src/hb-ot-layout.cc | 33 ++++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
@@ -56994,8 +55970,7 @@
[layout] Add apply_forward / apply_backward
- src/hb-ot-layout.cc | 69
- +++++++++++++++++++++++++++++++++++------------------
+ src/hb-ot-layout.cc | 69 +++++++++++++++++++++++++++++++++++------------------
1 file changed, 46 insertions(+), 23 deletions(-)
commit 1d4a328472f094c0d75a062f6e176c6b1875cfdc
@@ -57059,7 +56034,7 @@
Date: Thu Feb 19 10:40:23 2015 +0300
[layout] Don't check glyph props against lookup flags when recursing
-
+
Shouldn't be needed. I have a hard time imagining this breaking any
legitimate use case.
@@ -57072,16 +56047,14 @@
Date: Thu Feb 19 10:29:41 2015 +0300
[layout] Port sanitize() to use dispatch()
-
+
Needed some rework of Extension table. Hopefully I got it right, and
the new template usage doesn't break any compilers...
src/hb-open-type-private.hh | 5 ++-
- src/hb-ot-layout-gpos-table.hh | 82
- +----------------------------------
+ src/hb-ot-layout-gpos-table.hh | 82 +----------------------------------
src/hb-ot-layout-gsub-table.hh | 72 ++-----------------------------
- src/hb-ot-layout-gsubgpos-private.hh | 84
- ++++++++++++------------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 84 ++++++++++++------------------------
4 files changed, 37 insertions(+), 206 deletions(-)
commit 758fb20630f84c3d373cda37974b88f16c02995e
@@ -57141,7 +56114,7 @@
Date: Tue Feb 17 18:14:17 2015 +0300
[layout] Add may_dispatch()
-
+
No functional change right now.
src/hb-ot-layout-gpos-table.hh | 7 +++++++
@@ -57154,9 +56127,8 @@
Date: Tue Feb 17 17:27:44 2015 +0300
Make sanitize() a const method
-
- This makes a lot of code safer. We only try modifying the object
- in one
+
+ This makes a lot of code safer. We only try modifying the object in one
place, after making sure it's safe to do so. So, do a const_cast<> in
that one place...
@@ -57168,8 +56140,7 @@
src/hb-ot-hmtx-table.hh | 3 +-
src/hb-ot-layout-common-private.hh | 58 ++++++++++++-------
src/hb-ot-layout-gdef-table.hh | 30 ++++++----
- src/hb-ot-layout-gpos-table.hh | 108
- +++++++++++++++++++++++------------
+ src/hb-ot-layout-gpos-table.hh | 108 +++++++++++++++++++++++------------
src/hb-ot-layout-gsub-table.hh | 58 ++++++++++++-------
src/hb-ot-layout-gsubgpos-private.hh | 65 +++++++++++++--------
src/hb-ot-layout-jstf-table.hh | 12 ++--
@@ -57202,9 +56173,9 @@
Date: Thu Jan 29 13:59:42 2015 +0100
[layout] Allocate iters in the context
-
+
Can be further optimized, but I think I didn't break anything.
-
+
Saves another 3% off Roboto shaping.
src/hb-ot-layout-gpos-table.hh | 18 ++++++------------
@@ -57228,7 +56199,7 @@
Date: Thu Jan 29 13:40:39 2015 +0100
[lookup] Add skippy_iter.reset()
-
+
Towards reducing the cost of initializing skippy_iter()
src/hb-ot-layout-gpos-table.hh | 18 ++++++++++++------
@@ -57242,8 +56213,7 @@
[layout] Shuffle code around
- src/hb-ot-layout-gsubgpos-private.hh | 111
- ++++++++++++++++++-----------------
+ src/hb-ot-layout-gsubgpos-private.hh | 111 ++++++++++++++++++-----------------
1 file changed, 56 insertions(+), 55 deletions(-)
commit 696266981df5ef6c62ad0115133dad1d6c1d9acc
@@ -57253,8 +56223,7 @@
[layout] Merge forward and backward iterators
src/hb-ot-layout-gpos-table.hh | 12 +++---
- src/hb-ot-layout-gsubgpos-private.hh | 71
- ++++++++----------------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 71 ++++++++----------------------------
src/hb-ot-shape-fallback.cc | 2 +-
3 files changed, 23 insertions(+), 62 deletions(-)
@@ -57263,7 +56232,7 @@
Date: Thu Jan 29 13:05:25 2015 +0100
[layout] Fix backward reject()
-
+
Has no functional effect since reject was never used with
match_glyph_data.
@@ -57285,21 +56254,21 @@
Date: Thu Jan 29 11:08:43 2015 +0100
[lookup] Don't initialize skippy if coverage match fails
-
+
Currently:
-
+
- Initializing skippy is very expensive,
-
+
- Our lookup accelerator (using set-digests) can be very ineffecite,
-
+
As such, we end up many times initializing skippy but then failing
coverage check. Reordering fixes that.
-
+
When, later, we fix our accelerator to have truly small false-positive
rate (for example by using the frozen-sets), then we might want to
reorder these checks such that we wouldn't calculate coverage number
if skippy is going to fail.
-
+
This shows a 5% speedup with Roboto already.
src/hb-ot-layout-gpos-table.hh | 15 ++++++---------
@@ -57329,14 +56298,13 @@
Date: Wed Jan 28 21:46:07 2015 -0800
Add hb_frozen_set_t
-
+
I experimented with replacing use of hb_set_digest_t with this new
hb_frozen_set_t, hoping to get a huge speedup for busy lookups
(like kern lookup in Roboto), but I only got 6% speendup in Roboto
and 4% in NotoNastaliqUrduDraft :(.
- src/hb-set-private.hh | 57
- ++++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-set-private.hh | 57 ++++++++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 56 insertions(+), 1 deletion(-)
commit 241eac9559465fa79f396570af4e87f455b7e9d5
@@ -57365,7 +56333,7 @@
Date: Wed Feb 25 15:34:34 2015 -0800
Merge pull request #85 from KonstantinRitt/define_inline
-
+
Fix build with MSVC on CE
commit 9ee176ee978e6668c4faf00028811ce70979122e
@@ -57390,8 +56358,7 @@
Author: Collin Fair <cpf at cpfx.ca>
Date: Sat Feb 14 09:32:04 2015 -0500
- Remove reference to --help-output-content in --help-output (as
- --help-output-format's options aren't available in hb-view)
+ Remove reference to --help-output-content in --help-output (as --help-output-format's options aren't available in hb-view)
util/options.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -57400,8 +56367,7 @@
Author: Collin Fair <cpf at cpfx.ca>
Date: Sat Feb 14 09:29:35 2015 -0500
- Add serialization syntax documentation. Clarify naming and wording
- in --help-output/--help-format
+ Add serialization syntax documentation. Clarify naming and wording in --help-output/--help-format
util/options.cc | 30 ++++++++++++++++--------------
1 file changed, 16 insertions(+), 14 deletions(-)
@@ -57411,26 +56377,23 @@
Date: Sat Feb 14 00:58:51 2015 +0400
Fix build with MSVC on CE
-
+
This code is C++ only. There isn't a single C++ compiler that fails to
understand the "inline" keyword, since it's required by C++98. Any
compiler older than C++98 is likely to choke on the template usage
further down, so this isn't necessary.
-
+
Moreover, the C++ standard says you cannot define macros.
- [lib.macro.names] says "Nor shall such a translation unit define
- macros
+ [lib.macro.names] says "Nor shall such a translation unit define macros
for names lexically identical to keywords." -- technically, it's a
- promise that the Standard Library headers won't do it, the wording
- means
+ promise that the Standard Library headers won't do it, the wording means
that the entire translation unit won't do it, which implies no source
can do it.
-
+
MSVC complains about it:
- fatal error C1189: #error : The C++ Standard Library forbids
- macroizing
+ fatal error C1189: #error : The C++ Standard Library forbids macroizing
keywords. Enable warning C4005 to find the forbidden macro.
-
+
Author: Thiago Macieira <thiago.macieira at intel.com>
src/hb-private.hh | 10 ----------
@@ -57450,7 +56413,7 @@
Date: Wed Jan 28 10:51:33 2015 -0800
[coretext] Don't generate notdef glyph for default-ignorables
-
+
As discovered on Chrome Mac:
https://code.google.com/p/chromium/issues/detail?id=452326
@@ -57463,16 +56426,16 @@
Date: Wed Jan 28 10:43:32 2015 -0800
[coretext] Unbreak glyph positioning in presence of notdef runs
-
+
As discovered on Chrome Mac:
https://code.google.com/p/chromium/issues/detail?id=452326
-
+
This was originally broken in:
-
+
commit 5a0eed3b50629be4826e4e9428f2c3255195395d
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Mon Aug 11 23:47:16 2014 -0400
-
+
[coretext] Implement vertical shaping
src/hb-coretext.cc | 35 +++++++++++++++++++++++++++--------
@@ -57510,25 +56473,21 @@
Date: Mon Jan 26 14:25:52 2015 -0800
[API] Add hb_buffer_add_latin1()
-
+
This is by no ways to promote non-Unicode encodings. This is an entry
point that takes Unicode codepoints that happen to all be the first
- 256 characters and hence fit in 8bit strings. This is useful eg
- in Chrome
+ 256 characters and hence fit in 8bit strings. This is useful eg in Chrome
where strings that can fit in 8bit are implemented that way, and this
avoids copying into UTF-8 or UTF-16.
-
- Perhaps we should rename this to hb_buffer_add_codepoints8().
- I'm also
- curious if anyone would be really interested in
- hb_buffer_add_codepoints16().
-
+
+ Perhaps we should rename this to hb_buffer_add_codepoints8(). I'm also
+ curious if anyone would be really interested in hb_buffer_add_codepoints16().
+
Please discuss!
src/hb-buffer.cc | 36 +++++++++++++++++++++++++-------
src/hb-buffer.h | 8 ++++++++
- src/hb-utf-private.hh | 57
- ++++++++++++++++++++++++++++++++++++++-------------
+ src/hb-utf-private.hh | 57 ++++++++++++++++++++++++++++++++++++++-------------
3 files changed, 80 insertions(+), 21 deletions(-)
commit 78c6e86c04f12154c88b9f9264d0bd50b721699b
@@ -57546,7 +56505,7 @@
Date: Sun Jan 25 13:06:03 2015 -0800
Merge pull request #81 from KonstantinRitt/fixes/build/win8phone
-
+
winrt_buildfixes
commit f3537b620b0a7392ea27f01f465c5ba79459c858
@@ -57554,7 +56513,7 @@
Date: Sun Jan 25 09:50:51 2015 +0400
Move some code around
-
+
Just to keep Windows specific workarounds in a single place.
src/hb-private.hh | 25 ++++++++++++-------------
@@ -57565,7 +56524,7 @@
Date: Sun Jan 25 08:16:26 2015 +0400
Do not define MemoryBarrier on WinCE
-
+
There is a _HBMemoryBarrier() wrapper function that emulates
MemoryBarrier() behavior when it is not defined.
@@ -57577,10 +56536,10 @@
Date: Sun Jan 25 08:13:24 2015 +0400
Fix build on WinRT
-
+
There is no environment (like WinCE) and the basic version
of InitializeCriticalSection is unsupported.
-
+
https://codereview.qt-project.org/#/c/92496/
src/hb-mutex-private.hh | 4 ++++
@@ -57620,7 +56579,7 @@
Date: Wed Jan 21 18:50:57 2015 -0800
[coretext] Fix scaling
-
+
Before we were not accounting for possible differences in x_scale and
y_scale, as well as the signs of those. All should be in good shape
now.
@@ -57669,7 +56628,7 @@
Date: Tue Jan 20 12:30:45 2015 -0800
[util] Add --font-size to hb-shape
-
+
Also makes hb-view to use 8 bits of subpixel precision and shape at
requested size, instead of always shaping at upem and scaling results.
@@ -57679,8 +56638,7 @@
util/helper-cairo.cc | 16 ++++++++--------
util/helper-cairo.hh | 5 ++---
util/main-font-text.hh | 4 ++--
- util/options.cc | 44
- +++++++++++++++++++++++++++++++++++++++++---
+ util/options.cc | 44 +++++++++++++++++++++++++++++++++++++++++---
util/options.hh | 16 ++++++++++++----
util/view-cairo.cc | 2 +-
util/view-cairo.hh | 8 ++++----
@@ -57700,10 +56658,10 @@
Date: Mon Jan 19 17:00:31 2015 -0800
When matching second glyph of kerning pairs, use bsearch
-
+
Roboto has glyphs (like 'F') that have 200 kerning pairs.
Add a handcoded bsearch instead of previous linear search.
-
+
This doesn't show much speedup though, apparently we spend the
bulk of the time somewhere before here.
@@ -57725,7 +56683,7 @@
Date: Mon Jan 19 16:15:00 2015 -0800
Merge pull request #77 from roozbehp/master
-
+
Change New Tai Lue shaping engine from SEA to default
commit 5eb939ddfe9ef217da2e48d7d0f1f4b7501714ad
@@ -57733,15 +56691,15 @@
Date: Sun Jan 18 14:30:08 2015 -0800
Change New Tai Lue shaping engine from SEA to default
-
+
This is to reflect the UTC decision to change the encoding model of
New Tai Lue from logical to visual to be similar to Thai, Lao, and
Tai Viet: http://www.unicode.org/L2/L2014/14250.htm#141-C26
-
+
The visual encoding is already the current practice of encoding New
Tai Lue on the web anyway:
http://www.unicode.org/L2/L2014/14195-newtailue.txt
-
+
Fixes behdad/harfbuzz#66.
src/hb-ot-shape-complex-private.hh | 2 +-
@@ -57754,8 +56712,7 @@
[indic] Fix out-of-bounds access
src/gen-indic-table.py | 2 +-
- src/hb-ot-shape-complex-indic-table.cc | 36
- +++++++++++++++++-----------------
+ src/hb-ot-shape-complex-indic-table.cc | 36 +++++++++++++++++-----------------
2 files changed, 19 insertions(+), 19 deletions(-)
commit 238d6a38f2ceb7d8dceec9365a823f032b3b9f7d
@@ -57772,7 +56729,7 @@
Date: Tue Jan 6 19:16:38 2015 -0800
[bindings] Use hb_glib_blob_create() in sample
-
+
hb_blob_create() is considered C-only API.
src/hb-blob.cc | 8 ++++----
@@ -57814,7 +56771,7 @@
Date: Tue Jan 6 14:05:26 2015 -0800
Fix up gobject-introspection a bit
-
+
Minimal shaping works now!
src/hb-blob.cc | 6 +++---
@@ -57827,9 +56784,9 @@
Date: Mon Jan 5 14:43:13 2015 -0800
Remove hardcoded ICU include paths.
-
+
ICU exports them using LOCAL_EXPORT_C_INCLUDE_DIRS.
-
+
https://android-review.googlesource.com/#/c/121311/
Android.mk | 3 +--
@@ -57841,7 +56798,7 @@
Date: Sun Jan 4 20:32:18 2015 -0800
Merge pull request #76 from cpeterso/cpeterso/Wunused-function
-
+
Add #ifdef HB_USE_ATEXIT to fix -Wunused-function warnings
commit fb85d618f5883458bacf0ecb0894772291a2d738
@@ -57862,7 +56819,7 @@
Date: Sat Jan 3 21:55:30 2015 -0800
Merge pull request #75 from cpeterso/cpeterso/Wunused-value
-
+
Fix hb_atomic_ptr_cmpexch -Wunused-value warnings
commit d1897a98d8da40cffb57c07099a9a93cfeaacc36
@@ -57880,7 +56837,7 @@
Date: Fri Jan 2 14:09:23 2015 -0800
Add missing va_end()
-
+
Fixes https://github.com/behdad/harfbuzz/pull/74
util/options.cc | 1 +
@@ -57891,16 +56848,14 @@
Date: Sun Dec 28 18:56:15 2014 -0800
[ft] Don't set font ppem
-
+
For discussion see:
-
+
http://lists.freedesktop.org/archives/harfbuzz/2012-April/001905.html
-
- Over time we have had added NO_HINTING all over the place in hb-ft.
- Finish it off.
- Not setting ppem on hb-font disables get_contour_point() calls which
- is good anyway.
-
+
+ Over time we have had added NO_HINTING all over the place in hb-ft. Finish it off.
+ Not setting ppem on hb-font disables get_contour_point() calls which is good anyway.
+
See comments in the commit.
src/hb-ft.cc | 9 +++++++++
@@ -57910,63 +56865,46 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Sun Dec 28 17:44:26 2014 -0800
- [ft] Add hb_ft_face_create_referenced() and
- hb_ft_font_create_referenced()
-
- When I originally wrote hb-ft, FreeType objects did not support
- reference
+ [ft] Add hb_ft_face_create_referenced() and hb_ft_font_create_referenced()
+
+ When I originally wrote hb-ft, FreeType objects did not support reference
counting. As such, hb_ft_face_create() and hb_ft_font_create() had a
- "destroy" callback and client was responsible for making sure
- FT_Face is
+ "destroy" callback and client was responsible for making sure FT_Face is
kept around as long as the hb-font/face are alive.
-
+
However, since this was not clearly documented, some clienets didn't
- correctly did that. In particular, some clients assumed that
- it's safe
- to destroy FT_Face and then hb_face_t. This, indeed, used to work,
- until
- 45fd9424c723f115ca98995b8f8a25185a6fc71d, which make face destroy
- access
+ correctly did that. In particular, some clients assumed that it's safe
+ to destroy FT_Face and then hb_face_t. This, indeed, used to work, until
+ 45fd9424c723f115ca98995b8f8a25185a6fc71d, which make face destroy access
font tables.
-
- Now, I fixed that issue in 395b35903e052aecc97d0807e4f813c64c0d2b0b
- since
- the access was not needed, but the problem remains that not all
- clients
+
+ Now, I fixed that issue in 395b35903e052aecc97d0807e4f813c64c0d2b0b since
+ the access was not needed, but the problem remains that not all clients
handle this correctly. See:
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=86300
-
- Fortunately, FT_Reference_Face() was added to FreeType in 2010,
- and so we
+
+ Fortunately, FT_Reference_Face() was added to FreeType in 2010, and so we
can use it now. Originally I wanted to change hb_ft_face_create() and
- hb_ft_font_create() to reference the face if destroy==NULL was
- passed in.
- That would improve pretty much all clients, with little undesired
- effects.
- Except that FreeType itself, when compiled with HarfBuzz support,
- calls
- hb_ft_font_create() with destroy==NULL and saves the resulting
- hb-font on
+ hb_ft_font_create() to reference the face if destroy==NULL was passed in.
+ That would improve pretty much all clients, with little undesired effects.
+ Except that FreeType itself, when compiled with HarfBuzz support, calls
+ hb_ft_font_create() with destroy==NULL and saves the resulting hb-font on
the ft-face (why does it not free it immediately?). Making hb-face
- reference ft-face causes a cycling reference there. At least,
- that's my
+ reference ft-face causes a cycling reference there. At least, that's my
current understanding.
-
- At any rate, a cleaner approach, even if it means all clients will
- need a
+
+ At any rate, a cleaner approach, even if it means all clients will need a
change, is to introduce brand new API. Which this commit does.
-
- Some comments added to hb-ft.h, hoping to make future clients
- make better
+
+ Some comments added to hb-ft.h, hoping to make future clients make better
choices.
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=75299
configure.ac | 4 ++--
src/hb-ft.cc | 32 ++++++++++++++++++++++++++++++++
- src/hb-ft.h | 59
- ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
+ src/hb-ft.h | 59 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
3 files changed, 92 insertions(+), 3 deletions(-)
commit 9a3b74884b2e41c7040611030f4336f13d18fd3e
@@ -57974,7 +56912,7 @@
Date: Sun Dec 28 17:27:39 2014 -0800
Remove redundant check for FT_Face_GetCharVariantIndex
-
+
We require FreeType >= 2.8.3. This symbol was introduced earlier
than that.
@@ -57996,7 +56934,7 @@
Date: Sun Dec 28 16:20:31 2014 -0800
[ft] Open blob in READONLY mode
-
+
HB_MEMORY_MODE_READONLY_MAY_MAKE_WRITABLE is deprecated and fairly
useless now.
@@ -58008,13 +56946,11 @@
Date: Sun Dec 28 16:03:26 2014 -0800
Avoid accessing layout tables at face destruction
-
+
"Fixes" https://bugs.freedesktop.org/show_bug.cgi?id=86300
-
- Based on discussion someone else who had a similar issue, most
- probably
- the user is releasing FT_Face before destructing hb_face_t /
- hb_font_t.
+
+ Based on discussion someone else who had a similar issue, most probably
+ the user is releasing FT_Face before destructing hb_face_t / hb_font_t.
While that's a client bug, and while we can (and should) use FreeType
refcounting to help avoid that, it happens that we were accessing
the table when we didn't really have to. Avoid that.
@@ -58029,13 +56965,13 @@
Date: Thu Dec 18 18:22:21 2014 -0800
Fail blob creation if length overflows or is too large
-
+
Fail if blob start plus length overflows; or if blob length
is greater than 2GB. It takes a while for fonts to get to that
size. In the mean time, it protects against bugs like this:
-
+
http://www.icu-project.org/trac/ticket/11450
-
+
Also avoids some weird issues with 32bit vs 64bit systems
as we accept length as unsigned int. As such, a length of
-1 will cause overflow on 32bit machines, but happily
@@ -58050,7 +56986,7 @@
Date: Thu Dec 18 18:09:41 2014 -0800
Assert that blob length doesn't overflow address.
-
+
This will crash now, if blob was created with wrong length.
Check for that coming next commit.
@@ -58074,8 +57010,7 @@
[otlayout] Mark variables that are C arrays as opposed to OT::ArrayOf
src/hb-ot-layout-gpos-table.hh | 24 +++++++--------
- src/hb-ot-layout-gsubgpos-private.hh | 60
- ++++++++++++++++++------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 60 ++++++++++++++++++------------------
2 files changed, 42 insertions(+), 42 deletions(-)
commit 9df0a520306a491f973d42965597bfda6023e508
@@ -58150,16 +57085,16 @@
Date: Wed Dec 10 12:05:24 2014 -0800
[indic] Allow ZWJ/ZWNJ before SM
-
+
In Oriya, a ZWJ/ZWNJ might be added before candrabindu to encourage
or stop ligation of the candrabindu. This is clearly specified in
the Unicode section on Oriya. Allow it there. Note that Uniscribe
doesn't allow this.
-
+
Micro tests added using Noto Sans Oriya draft.
-
+
No changes in numbers. Currently at:
-
+
BENGALI: 353725 out of 354188 tests passed. 463 failed (0.130722%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
@@ -58166,8 +57101,7 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1048147 out of 1048334 tests passed. 187 failed
- (0.0178378%)
+ MALAYALAM: 1048147 out of 1048334 tests passed. 187 failed (0.0178378%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
@@ -58175,8 +57109,7 @@
src/hb-ot-shape-complex-indic-machine.rl | 2 +-
test/shaping/Makefile.am | 1 +
- .../sha1sum/5028afb650b1bb718ed2131e872fbcce57828fff.ttf | Bin 0 ->
- 4720 bytes
+ .../sha1sum/5028afb650b1bb718ed2131e872fbcce57828fff.ttf | Bin 0 -> 4720 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/indic-joiner-candrabindu.tests | 2 ++
@@ -58197,12 +57130,12 @@
Date: Wed Oct 29 11:23:08 2014 -0700
In hb_ot_collect_glyphs(), don't recurse to a lookup more than once
-
+
Otherwise, we might process a lookup thousands of times, with no
benefit. This pathological case was hit by Noto Nastaliq Urdu Draft
in Firefox's code to determine whether space glyph is involved in
any GSUB/GPOS rules. A test page is at http://behdad.org/urdu
-
+
See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1090869
@@ -58215,8 +57148,7 @@
Move code around
- src/hb-open-type-private.hh | 50
- ++++++++++++++++++++++-----------------------
+ src/hb-open-type-private.hh | 50 ++++++++++++++++++++++-----------------------
1 file changed, 25 insertions(+), 25 deletions(-)
commit 666b42f73bd1f516657b206ef738108825bf239f
@@ -58224,11 +57156,10 @@
Date: Tue Oct 14 21:24:59 2014 -0700
Move macros around
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=84491
- src/hb-open-type-private.hh | 63
- ++++++++++++++++++++++++++++++++++++++-------
+ src/hb-open-type-private.hh | 63 ++++++++++++++++++++++++++++++++++++++-------
src/hb-private.hh | 41 -----------------------------
src/hb-uniscribe.cc | 6 +++++
3 files changed, 60 insertions(+), 50 deletions(-)
@@ -58238,7 +57169,7 @@
Date: Tue Oct 14 20:07:31 2014 -0700
Fix misc warnings
-
+
Fixes https://github.com/behdad/harfbuzz/pull/51
src/hb-buffer-deserialize-json.rl | 4 ++--
@@ -58450,7 +57381,7 @@
Date: Wed Oct 1 12:41:03 2014 -0400
Don't use tmp files in Makefile
-
+
Useful for code-coverage generation of the ragel-generated files
as they will now contain the correct .hh filename in them.
@@ -58462,7 +57393,7 @@
Date: Wed Oct 1 11:56:07 2014 -0400
check-static-inits: Filter out zero-length sections
-
+
When compiling with -O0, zero-sized constructors were showing up
and confusing the test.
@@ -58511,8 +57442,7 @@
[ot-font] Add hb_ot_face_cmap_accelerator_t
- src/hb-ot-font.cc | 113
- +++++++++++++++++++++++++++++++-----------------------
+ src/hb-ot-font.cc | 113 +++++++++++++++++++++++++++++++-----------------------
1 file changed, 66 insertions(+), 47 deletions(-)
commit d088ccaf11d9475fe0d269ce130b1793b8a1ffbf
@@ -58539,8 +57469,7 @@
[ot-font] Add metrics_accel_t
- src/hb-ot-font.cc | 111
- ++++++++++++++++++++++--------------------------
+ src/hb-ot-font.cc | 111 ++++++++++++++++++++++--------------------------
src/hb-ot-hhea-table.hh | 2 +-
src/hb-ot-hmtx-table.hh | 4 +-
3 files changed, 54 insertions(+), 63 deletions(-)
@@ -58552,8 +57481,7 @@
[ot-font] Start adding vertical support
src/hb-ot-font.cc | 57 ++++++++++++++++++++++++++++++++++----------
- src/hb-ot-hhea-table.hh | 63
- ++++++++++++++++++++++++++-----------------------
+ src/hb-ot-hhea-table.hh | 63 ++++++++++++++++++++++++++-----------------------
src/hb-ot-hmtx-table.hh | 35 +++++++++++++++++----------
3 files changed, 100 insertions(+), 55 deletions(-)
@@ -58571,9 +57499,9 @@
Date: Mon Aug 25 12:31:19 2014 -0400
[arabic] Don't #include __FILE__
-
+
Fine!
-
+
https://code.google.com/p/chromium/issues/detail?id=406957
src/hb-ot-shape-complex-arabic-win1256.hh | 2 +-
@@ -58584,7 +57512,7 @@
Date: Mon Aug 25 11:48:12 2014 -0400
[arabic] Allow disabling win1256 fallback code
-
+
By defining HB_NO_WIN1256.
src/hb-ot-shape-complex-arabic-fallback.hh | 2 +-
@@ -58594,9 +57522,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Fri Aug 22 12:06:57 2014 -0400
- [ot] Prefer Windows platform cmap tables / accept all Unicode
- encodingIDs
-
+ [ot] Prefer Windows platform cmap tables / accept all Unicode encodingIDs
+
Some fonts on the Mac ship with (0,1).
src/hb-ot-font.cc | 7 +++++--
@@ -58636,8 +57563,7 @@
Simplify hb-object
- src/hb-object-private.hh | 118
- +++++++++++++++--------------------------------
+ src/hb-object-private.hh | 118 +++++++++++++++--------------------------------
1 file changed, 36 insertions(+), 82 deletions(-)
commit 9d861b81f349188a4507350398786a6e94038095
@@ -58646,8 +57572,7 @@
Really fix clang build this time
- src/hb-object-private.hh | 141
- +++++++++++++++++++++++------------------------
+ src/hb-object-private.hh | 141 +++++++++++++++++++++++------------------------
1 file changed, 68 insertions(+), 73 deletions(-)
commit 272226f294382b0c6921b36e0e67fc53daa765d3
@@ -58655,7 +57580,7 @@
Date: Thu Aug 14 13:11:33 2014 -0400
Revert "Fix build on clang after previous commit"
-
+
This reverts commit 9c80cbc87f23040a334e30c750f64523d9ef10c8.
src/hb-object-private.hh | 34 +++++++++++++---------------------
@@ -58675,7 +57600,7 @@
Date: Thu Aug 14 13:05:36 2014 -0400
Rewrite this==NULL checks to avoid undefined behavior
-
+
Fixes https://code.google.com/p/chromium/issues/detail?id=403594
src/hb-object-private.hh | 18 ++++++++----------
@@ -58686,7 +57611,7 @@
Date: Thu Aug 14 12:59:16 2014 -0400
Remove this==NULL check from face->reference_table()
-
+
Not supposed to happen, and apparently this is undefined in C++.
https://code.google.com/p/chromium/issues/detail?id=403594
@@ -58698,7 +57623,7 @@
Date: Thu Aug 14 12:57:02 2014 -0400
Make hb_object_t members private
-
+
In preparation for fixing:
https://code.google.com/p/chromium/issues/detail?id=403594
@@ -58766,9 +57691,8 @@
Date: Tue Aug 12 17:15:09 2014 -0400
[shape-plan] Fix typo!
-
- The only effect is, if shaper_list was not NULL and no shaper
- was found,
+
+ The only effect is, if shaper_list was not NULL and no shaper was found,
we now don't insert anything into cache and return earlier.
src/hb-shape-plan.cc | 2 +-
@@ -58805,11 +57729,10 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue Aug 12 16:50:22 2014 -0400
- [shape-plan] Fix shape-plan caching with more than one requested
- shaper
-
+ [shape-plan] Fix shape-plan caching with more than one requested shaper
+
Wasn't breaking out of loop, ouch!
-
+
http://www.mail-archive.com/debian-bugs-dist@lists.debian.org/msg1246370.html
src/hb-shape-plan.cc | 9 ++++++---
@@ -58829,7 +57752,7 @@
Date: Tue Aug 12 15:49:47 2014 -0400
[coretext] Fix buffer resizing
-
+
Was very broken. Now fixed and tested.
src/hb-coretext.cc | 17 +++++++++++++----
@@ -58849,9 +57772,9 @@
Date: Tue Aug 12 13:12:31 2014 -0400
[wince] Two more Windows CE fixes
-
+
Report has it that it builds (and works) now:
-
+
https://codereview.qt-project.org/#/c/92087/
src/hb-mutex-private.hh | 2 +-
@@ -58863,19 +57786,18 @@
Date: Tue Aug 12 10:32:41 2014 -0400
[coretext] Compare CGFont and PS name, if CTFont didn't match
-
+
See comments.
-
+
Fixes vertical text. CoreText backend is in very good shape now!
-
+
Also see:
5a0eed3b50629be4826e4e9428f2c3255195395d
25f4fb9b56bb3f8bec821571c78f8829e40daa54
-
+
Fixes http://github.com/behdad/harfbuzz/pull/36
- src/hb-coretext.cc | 54
- ++++++++++++++++++++++++++++++++++++++++++++++++------
+ src/hb-coretext.cc | 54 ++++++++++++++++++++++++++++++++++++++++++++++++------
1 file changed, 48 insertions(+), 6 deletions(-)
commit 5a0eed3b50629be4826e4e9428f2c3255195395d
@@ -58883,13 +57805,12 @@
Date: Mon Aug 11 23:47:16 2014 -0400
[coretext] Implement vertical shaping
-
+
Currently doesn't work though, we detect font fallback. Apparently
matching on ct_font is not safe for this. Looks like commit
25f4fb9b56bb3f8bec821571c78f8829e40daa54 wasn't enough after all.
- src/hb-coretext.cc | 127
- ++++++++++++++++++++++++++++++++++-------------------
+ src/hb-coretext.cc | 127 ++++++++++++++++++++++++++++++++++-------------------
1 file changed, 81 insertions(+), 46 deletions(-)
commit 1b55077f03758e49f93b8bc1de678e96ea58718c
@@ -58897,7 +57818,7 @@
Date: Mon Aug 11 20:45:12 2014 -0400
[coretext] Remove unnecessary alt_size
-
+
Wasn't needed after a6b8dc87421de33746b0b14d86d2d1532aec02af.
src/hb-coretext.cc | 4 ++--
@@ -58908,7 +57829,7 @@
Date: Mon Aug 11 20:02:45 2014 -0400
[coretext] Use CFRunStatus
-
+
Assert that all runs had expected direction, and take hint for
non-monotone clusters.
@@ -58938,13 +57859,13 @@
Date: Mon Aug 11 18:40:01 2014 -0400
API: Do not clear buffer-flags in hb_buffer_clear_contents()
-
+
After 763e5466c0a03a7c27020e1e2598e488612529a7, one doesn't
need to set flags for different pieces of text. The flags now
are something the client sets up once, depending on how it
actually uses the buffer. As such, don't clear it in
clear_contents().
-
+
Tests updated.
src/hb-buffer-private.hh | 4 +---
@@ -58966,7 +57887,7 @@
Date: Mon Aug 11 17:46:50 2014 -0400
[coretext] Pass buffer direction to CoreText
-
+
Have to use a CTTypesetter for this.
src/hb-coretext.cc | 26 ++++++++++++++++++++++----
@@ -58977,7 +57898,7 @@
Date: Mon Aug 11 17:46:12 2014 -0400
[coretext] Minor
-
+
It's hard to handle all possible NULL returns from CoreText. Add one
more...
@@ -58989,7 +57910,7 @@
Date: Mon Aug 11 15:29:18 2014 -0400
[coretext] Attach marks to base clusters
-
+
Fixes https://githu.com/behdad/harfbuzz/issues/49
to the extent that it can be fixed.
@@ -59001,10 +57922,9 @@
Date: Mon Aug 11 15:11:59 2014 -0400
[coretext] Use input clusters
-
+
Before, this shaper was returning UTF-16 cluster indices instead of
- returning whatever cluster values the user had had set up in the
- buffer.
+ returning whatever cluster values the user had had set up in the buffer.
Ouch!
src/hb-coretext.cc | 6 ++----
@@ -59015,14 +57935,13 @@
Date: Mon Aug 11 15:08:19 2014 -0400
[coretext] Fix buffer resize handling
-
+
We can't really resize buffer and continue in this shaper as we are
using the scratch buffer for string_ref and log_cluster. Restructure
shaper to retry from (almost) scratch.
src/hb-buffer-private.hh | 3 +
- src/hb-coretext.cc | 428
- ++++++++++++++++++++++++++---------------------
+ src/hb-coretext.cc | 428 ++++++++++++++++++++++++++---------------------
2 files changed, 238 insertions(+), 193 deletions(-)
commit 9b3c60c88b118f01610ae7a608b138f79f2dc7be
@@ -59030,7 +57949,7 @@
Date: Mon Aug 11 13:25:43 2014 -0400
[coretext] Always compute log_clusters
-
+
To be used soon.
src/hb-coretext.cc | 24 +++++++++++-------------
@@ -59069,7 +57988,7 @@
Date: Sun Aug 10 19:05:25 2014 -0400
[coretext] Fix fallback detection
-
+
Fixes http://github.com/behdad/harfbuzz/pull/36
src/hb-coretext.cc | 29 ++++++++++++++++++++---------
@@ -59080,12 +57999,11 @@
Date: Sun Aug 10 18:59:47 2014 -0400
[coretext] Fix last range
-
+
Test with:
+
+ hb-view /Library/Fonts/Zapfino.ttf ZapfinoZapfino --features=-dlig[7:] --shaper=coretext
- hb-view /Library/Fonts/Zapfino.ttf ZapfinoZapfino --features=-dlig[7:]
- --shaper=coretext
-
src/hb-coretext.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -59094,7 +58012,7 @@
Date: Sun Aug 10 18:52:07 2014 -0400
Fix hb_in_range() for types smaller than int
-
+
As exercised by hb-coretext .notdef code.
src/hb-private.hh | 4 +++-
@@ -59105,10 +58023,10 @@
Date: Sun Aug 10 18:04:50 2014 -0400
[wince] Try to fix some stuff on Windows CE
-
+
Based on errors seen here:
http://testresults.qt-project.org/ci/QtBase_dev_Integration/build_03837/wince70embedded-armv4i-msvc2008_Windows_7/log.txt.gz
-
+
Fully untested.
src/hb-private.hh | 8 ++++++++
@@ -59129,7 +58047,7 @@
Date: Sun Aug 10 17:40:24 2014 -0400
[coretext] Fix assert on Yosemite
-
+
Apparently those functions documented as sometimes returning NULL
actually exercise that right in OS X 10.10 Yosemite. The scratch
was too small for that. I *think* I fixed it, but haven't tested
@@ -59152,7 +58070,7 @@
Date: Thu Aug 7 15:38:52 2014 -0400
[arabic] Bug 82306 - Mandaic had errors in its Unicode Joining_Type
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=82306
src/hb-ot-shape-complex-arabic-table.hh | 2 +-
@@ -59163,12 +58081,12 @@
Date: Wed Aug 6 13:34:49 2014 -0400
Use atexit() only if it's safe to call from shared library
-
+
Apparently they are not (advertised as?) safe on BSD systems.
We ignore the case of static libraries.
-
+
Whitelisted on glibc, Android, and MSVC / mingw.
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=82246
src/hb-common.cc | 4 ++--
@@ -59184,18 +58102,17 @@
Date: Tue Aug 5 14:19:01 2014 -0400
[arabic] Fix fallback shaping regression
-
+
Was broken in 615d00ea252739da57edbd980ff27e573.
-
+
Fixes https://github.com/behdad/harfbuzz/pull/48
-
+
Micro-test added.
src/hb-ot-shape-complex-arabic.cc | 4 ++--
test/shaping/Makefile.am | 1 +
test/shaping/fonts/sha1sum/MANIFEST | 1 +
- .../sha1sum/df768b9c257e0c9c35786c47cae15c46571d56be.ttf | Bin 0 ->
- 6332 bytes
+ .../sha1sum/df768b9c257e0c9c35786c47cae15c46571d56be.ttf | Bin 0 -> 6332 bytes
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/arabic-fallback-shaping.tests | 1 +
6 files changed, 6 insertions(+), 2 deletions(-)
@@ -59224,7 +58141,7 @@
Date: Sat Aug 2 17:18:46 2014 -0400
Make sure gsubgpos buffer vars are available during fallback_position
-
+
Add buffer var allocation asserts to a few key places.
src/hb-ot-layout-gpos-table.hh | 4 ++--
@@ -59241,7 +58158,7 @@
Date: Sat Aug 2 16:31:16 2014 -0400
Disable 'liga' for vertical text
-
+
The reason we turned it on is because Kazuraki uses it. But that's
not reason enough. Until the OpenType spec gets its act together re
adding design-direction to lookups, this is better user experience.
@@ -59254,41 +58171,39 @@
Date: Sat Aug 2 16:17:44 2014 -0400
Make it easier to use HB_BUFFER_FLAG_BOT/EOT
-
+
Previously, we expected users to provide BOT/EOT flags when the
text *segment* was at paragraph boundaries. This meant that for
clients that provide full paragraph to HarfBuzz (eg. Pango), they
had code like this:
-
+
hb_buffer_set_flags (hb_buffer,
(item_offset == 0 ? HB_BUFFER_FLAG_BOT : 0) |
- (item_offset + item_length == paragraph_length
- ?
+ (item_offset + item_length == paragraph_length ?
HB_BUFFER_FLAG_EOT : 0));
-
+
hb_buffer_add_utf8 (hb_buffer,
paragraph_text, paragraph_length,
item_offset, item_length);
-
+
After this change such clients can simply say:
-
+
hb_buffer_set_flags (hb_buffer,
HB_BUFFER_FLAG_BOT | HB_BUFFER_FLAG_EOT);
-
+
hb_buffer_add_utf8 (hb_buffer,
paragraph_text, paragraph_length,
item_offset, item_length);
-
+
Ie, HarfBuzz itself checks whether the segment is at the beginning/end
of the paragraph. Clients that only pass item-at-a-time to HarfBuzz
continue not setting any flags whatsoever.
-
+
Another way to put it is: if there's pre-context text in the buffer,
HarfBuzz ignores the BOT flag. If there's post-context, it ignores
EOT flag.
- src/hb-ot-shape-complex-arabic.cc | 40
- +++++++++++++++++++--------------------
+ src/hb-ot-shape-complex-arabic.cc | 40 +++++++++++++++++++--------------------
src/hb-ot-shape.cc | 1 +
2 files changed, 20 insertions(+), 21 deletions(-)
@@ -59313,13 +58228,12 @@
Date: Fri Aug 1 19:05:33 2014 -0400
[arabic/win1256] Really fix lam-alef this time
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c26
https://github.com/behdad/harfbuzz/commit/b276e897d17519a2c28f79d024904ac2bdd86bcf#commitcomment-7243499
src/hb-ot-shape-complex-arabic-fallback.hh | 2 +-
- src/hb-ot-shape-complex-arabic-win1256.hh | 49
- +++++++++---------------------
+ src/hb-ot-shape-complex-arabic-win1256.hh | 49 +++++++++---------------------
2 files changed, 15 insertions(+), 36 deletions(-)
commit 55977f2a462b7fa1248eab3787053dc82320d3e5
@@ -59327,13 +58241,12 @@
Date: Fri Aug 1 16:14:33 2014 -0400
[arabic/win1256] Hook up lamMedi lookup
-
+
Restructure lookup array to accommodate.
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c18
- src/hb-ot-shape-complex-arabic-fallback.hh | 26
- ++++++++++----------------
+ src/hb-ot-shape-complex-arabic-fallback.hh | 26 ++++++++++----------------
src/hb-ot-shape-complex-arabic-win1256.hh | 1 +
2 files changed, 11 insertions(+), 16 deletions(-)
@@ -59342,7 +58255,7 @@
Date: Fri Aug 1 16:09:31 2014 -0400
[arabic/win1256] Fix TEH MARBUTA final form
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c18
src/hb-ot-shape-complex-arabic-win1256.hh | 8 ++++----
@@ -59353,7 +58266,7 @@
Date: Thu Jul 31 18:21:05 2014 -0400
[arabic/win1256] Fix shaping of JEEM, HAH, and KHAH
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=1045139#c16
src/hb-ot-shape-complex-arabic-win1256.hh | 22 ++++++++++++----------
@@ -59364,24 +58277,20 @@
Date: Thu Jul 31 11:04:00 2014 -0400
[arabic/win1256] Remove GCC'ism
-
- The table can now compile independently too. If we cannot make
- it work
+
+ The table can now compile independently too. If we cannot make it work
on MSVC, we can always generate the data and distribute it.
-
+
The code now compiles cleanly with:
-
- gcc -c -xc -std=c99 -Werror -pedantic
- hb-ot-shape-complex-arabic-win1256.hh
- g++ -c -xc -std=c++1x -Werror -pedantic
- hb-ot-shape-complex-arabic-win1256.hh
-
+
+ gcc -c -xc -std=c99 -Werror -pedantic hb-ot-shape-complex-arabic-win1256.hh
+ g++ -c -xc -std=c++1x -Werror -pedantic hb-ot-shape-complex-arabic-win1256.hh
+
See:
https://github.com/behdad/harfbuzz/commit/a97f537cec209649302899975d76ca2b2661da7a#commitcomment-7218736
src/hb-ot-shape-complex-arabic-fallback.hh | 4 +-
- src/hb-ot-shape-complex-arabic-win1256.hh | 123
- +++++++++++++++++------------
+ src/hb-ot-shape-complex-arabic-win1256.hh | 123 +++++++++++++++++------------
2 files changed, 75 insertions(+), 52 deletions(-)
commit f28b1c823db2ad56fed356ef864a7508d23048b8
@@ -59389,26 +58298,23 @@
Date: Wed Jul 30 02:15:44 2014 -0400
[arabic] Implement Windows-1256 private shaping
-
- Bug 1045139 - The Arabic text with "MS Sans Serif" font is rendered
- bad
+
+ Bug 1045139 - The Arabic text with "MS Sans Serif" font is rendered bad
https://bugzilla.mozilla.org/show_bug.cgi?id=1045139
-
+
This is only enabled on Windows platforms, and requires support from
Uniscribe to work. But for clients that do hook up to Uniscribe, this
- fixes shaping of Windows-1256-encoded bitmap fonts like "MS Sans
- Serif".
-
+ fixes shaping of Windows-1256-encoded bitmap fonts like "MS Sans Serif".
+
The code and table together have just less than a 1kb footprint when
enabled.
-
+
UNTESTED. I might even have broken regular Arabic fallback shaping.
src/Makefile.am | 1 +
src/check-includes.sh | 2 +-
src/hb-ot-shape-complex-arabic-fallback.hh | 125 +++++++++--
- src/hb-ot-shape-complex-arabic-win1256.hh | 328
- +++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-arabic-win1256.hh | 328 +++++++++++++++++++++++++++++
4 files changed, 442 insertions(+), 14 deletions(-)
commit ac53443f1cea83ed43a4e41a9fdb91902f7fae7b
@@ -59416,22 +58322,18 @@
Date: Thu Jul 31 18:51:37 2014 -0400
[hangul] Don't apply 'calt'
-
+
See comments.
-
+
Micro-test added.
- src/hb-ot-shape-complex-hangul.cc | 11
- ++++++++++-
+ src/hb-ot-shape-complex-hangul.cc | 11 ++++++++++-
test/shaping/Makefile.am | 1 +
- .../sha1sum/757ebd573617a24aa9dfbf0b885c54875c6fe06b.ttf | Bin 0 ->
- 1804 bytes
- .../sha1sum/7e14e7883ed152baa158b80e207b66114c823a8b.ttf | Bin 0 ->
- 1644 bytes
+ .../sha1sum/757ebd573617a24aa9dfbf0b885c54875c6fe06b.ttf | Bin 0 -> 1804 bytes
+ .../sha1sum/7e14e7883ed152baa158b80e207b66114c823a8b.ttf | Bin 0 -> 1644 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 ++
test/shaping/tests/MANIFEST | 1 +
- test/shaping/tests/hangul-jamo.tests | 11
- +++++++++++
+ test/shaping/tests/hangul-jamo.tests | 11 +++++++++++
7 files changed, 25 insertions(+), 1 deletion(-)
commit 8292f96b2be173ebceb1b54426c271cfeaecd633
@@ -59457,20 +58359,19 @@
Date: Sat Jul 26 20:34:01 2014 -0400
[hebrew] Zero mark advance by GDEF late
-
+
Seems to be what Uniscribe does.
-
+
At this point I think it's work checking our default...
-
+
Fixes Bug 76767 - Zeroing of advance of 2nd component of multiple
substitution with SBL Hebrew
https://bugs.freedesktop.org/show_bug.cgi?id=76767
-
+
Micro-test added.
src/hb-ot-shape-complex-hebrew.cc | 2 +-
- .../sha1sum/8454d22037f892e76614e1645d066689a0200e61.ttf | Bin 0 ->
- 6068 bytes
+ .../sha1sum/8454d22037f892e76614e1645d066689a0200e61.ttf | Bin 0 -> 6068 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/zero-width-marks.tests | 1 +
4 files changed, 3 insertions(+), 1 deletion(-)
@@ -59480,23 +58381,21 @@
Date: Sat Jul 26 19:17:44 2014 -0400
Add old-Myanmar shaper
-
+
Looks like Unsicribe responds to the 'mymr' tag by zeroing marks
GDEF_LATE instead of generic-shaper UNICODE_LATE. Implement that.
-
+
Fixes
Bug 81775 - Incorrect Rendering with harfbuzz-ng myanmar unicode
https://bugs.freedesktop.org/show_bug.cgi?id=81775
-
+
Micro-test added based on Padauk.
- src/hb-ot-shape-complex-myanmar.cc | 18
- ++++++++++++++++++
+ src/hb-ot-shape-complex-myanmar.cc | 18 ++++++++++++++++++
src/hb-ot-shape-complex-private.hh | 5 +++--
test/shaping/Makefile.am | 1 +
test/shaping/fonts/sha1sum/MANIFEST | 1 +
- .../bb9473d2403488714043bcfb946c9f78b86ad627.ttf | Bin 0 ->
- 3440 bytes
+ .../bb9473d2403488714043bcfb946c9f78b86ad627.ttf | Bin 0 -> 3440 bytes
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/zero-width-marks.tests | 1 +
7 files changed, 25 insertions(+), 2 deletions(-)
@@ -59534,7 +58433,7 @@
Date: Fri Jul 25 12:30:47 2014 -0400
Fix snprintf() format
-
+
Patch from Maks Naumov.
Fixes https://github.com/behdad/harfbuzz/pull/22
@@ -59546,7 +58445,7 @@
Date: Fri Jul 25 12:21:49 2014 -0400
Make sure broken feature strings are not partially parsed
-
+
If user doesn't check hb_feature_from_string() return value, we
don't want them to end up see the partially-parsed feature.
@@ -59558,7 +58457,7 @@
Date: Fri Jul 25 12:15:33 2014 -0400
Allow quotation marks around feature tag in hb_feature_from_string()
-
+
With this, I believe we accept CSS feature strings completely.
src/hb-shape.cc | 24 +++++++++++++++++++++---
@@ -59587,7 +58486,7 @@
Date: Fri Jul 25 12:01:22 2014 -0400
Allow on/off in hb_feature_from_string()
-
+
We now allow things like "dlig on" / "dlig=on".
src/hb-shape.cc | 26 ++++++++++++++++++++++++--
@@ -59598,7 +58497,7 @@
Date: Fri Jul 25 11:56:01 2014 -0400
Remove duplicate definition of ISALNUM
-
+
It's defined in hb-private.h already.
src/hb-shape.cc | 2 --
@@ -59618,7 +58517,7 @@
Date: Fri Jul 25 11:44:35 2014 -0400
Do not require the '=' in hb_feature_from_string()
-
+
Towards accepting CSS font-feature-settings strings.
src/hb-shape.cc | 6 +++++-
@@ -59638,9 +58537,8 @@
Date: Fri Jul 25 11:18:11 2014 -0400
Minor warnings fixes
-
- Some systems insist on -Wmissing-field-initializers. We have
- too many,
+
+ Some systems insist on -Wmissing-field-initializers. We have too many,
by design. Fix a few easy ones.
src/hb-open-type-private.hh | 2 +-
@@ -59653,13 +58551,12 @@
Date: Wed Jul 23 16:48:51 2014 -0400
[indic] Handle old-spec Malayalam reordering with final Halant
-
+
See comment.
-
+
Micro-tests added.
- src/hb-ot-shape-complex-indic.cc | 28
- +++++++++++++++++----
+ src/hb-ot-shape-complex-indic.cc | 28 +++++++++++++++++----
test/shaping/Makefile.am | 1 +
.../270b89df543a7e48e206a2d830c0e10e5265c630.ttf | Bin 0 -> 3428 bytes
.../57a9d9f83020155cbb1d2be1f43d82388cbecc88.ttf | Bin 0 -> 2272 bytes
@@ -59674,7 +58571,7 @@
Date: Wed Jul 23 11:38:49 2014 -0400
Give CC to gir-scanner
-
+
From:
https://github.com/Alexpux/MINGW-packages/blob/master/mingw-w64-harfbuzz/0001-give-cc-to-gir-scanner.all.patch
@@ -59705,7 +58602,7 @@
Date: Tue Jul 22 16:26:27 2014 -0400
Disallow changing settings on immutable face
-
+
Ouch!
src/hb-face.cc | 8 ++++----
@@ -59718,7 +58615,7 @@
Date: Mon Jul 21 11:12:54 2014 -0400
[win] Fix Cygwin build
-
+
https://github.com/behdad/harfbuzz/commit/db308280488c2ee11ba865a9922eb6a0c1abeef3#commitcomment-7077778
src/hb-private.hh | 2 +-
@@ -59729,7 +58626,7 @@
Date: Sun Jul 20 01:17:40 2014 -0400
Add HB_TAG_MAX_SIGNED / _HB_SCRIPT_MAX_VALUE_SIGNED
-
+
To make C language police happy.
src/hb-common.h | 17 ++++++++++++-----
@@ -59740,7 +58637,7 @@
Date: Sat Jul 19 17:31:23 2014 -0400
[gobject] Skip _HB_SCRIPT_MAX_VALUE
-
+
Fixes https://github.com/behdad/harfbuzz/pull/38
src/hb-common.h | 2 +-
@@ -59782,9 +58679,9 @@
Date: Sat Jul 19 16:10:21 2014 -0400
More fixing MemoryBarrier() on Mingw32
-
+
Set requested windows header to Vista. See discussion:
-
+
https://github.com/behdad/harfbuzz/commit/fbb2847f541389f40718af71c4945024ae177ab2#commitcomment-7054700
src/hb-atomic-private.hh | 3 +++
@@ -59796,8 +58693,7 @@
[test] Remove unused micro-font
- .../9d64156923a1b9fed1e05f74599c16563eca42d9.ttf | Bin 81968 ->
- 0 bytes
+ .../9d64156923a1b9fed1e05f74599c16563eca42d9.ttf | Bin 81968 -> 0 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 -
2 files changed, 1 deletion(-)
@@ -59806,15 +58702,13 @@
Date: Fri Jul 18 14:37:49 2014 -0400
[test] Add more Mongolian variation selector tests
-
+
From
https://code.google.com/p/chromium/issues/detail?id=393896
- .../9d64156923a1b9fed1e05f74599c16563eca42d9.ttf | Bin 0 ->
- 81968 bytes
+ .../9d64156923a1b9fed1e05f74599c16563eca42d9.ttf | Bin 0 -> 81968 bytes
test/shaping/fonts/sha1sum/MANIFEST | 2 ++
- .../bb29ce50df2bdba2d10726427c6b7609bf460e04.ttf | Bin 0 ->
- 74856 bytes
+ .../bb29ce50df2bdba2d10726427c6b7609bf460e04.ttf | Bin 0 -> 74856 bytes
test/shaping/tests/mongolian-variation-selector.tests | 1 +
.../shaper-arabic/script-mongolian/misc/MANIFEST | 1 +
.../script-mongolian/misc/variation-selectors.txt | 8 ++++++++
@@ -59834,7 +58728,7 @@
Date: Thu Jul 17 17:13:54 2014 -0400
[arabic] Disable 'cswh' again
-
+
Ouch!
src/hb-ot-shape-complex-arabic.cc | 2 +-
@@ -59864,14 +58758,13 @@
Date: Thu Jul 17 13:36:09 2014 -0400
[arabic] Apply init/medi/isol/fini/... in separate stages
-
+
Follows the order of the Arabic/Syriac specs. Also don't stop
between rlig and calt in non-Arabic scripts.
-
+
Micro-tests for Arabic and Mongolian added for the latter.
- src/hb-ot-shape-complex-arabic.cc | 56
- +++++++++++++--------
+ src/hb-ot-shape-complex-arabic.cc | 56 +++++++++++++--------
test/shaping/Makefile.am | 2 +
.../813c2f8e5512187fd982417a7fb4286728e6f4a8.ttf | Bin 0 -> 3428 bytes
.../8a9fea2a7384f2116e5b84a9b31f83be7850ce21.ttf | Bin 0 -> 3428 bytes
@@ -59896,8 +58789,7 @@
Micro optimization
- src/hb-fallback-shape.cc | 36
- +++++++++++++++++++-----------------
+ src/hb-fallback-shape.cc | 36 +++++++++++++++++++-----------------
src/hb-ot-shape-complex-arabic.cc | 19 +++++++++++--------
src/hb-ot-shape-complex-indic.cc | 15 ++++++++++-----
src/hb-ot-shape-complex-myanmar.cc | 7 +++++--
@@ -59911,17 +58803,16 @@
Date: Thu Jul 17 14:16:38 2014 -0400
Another try to fix Mongolian free variation selectors
-
+
This reverts bf029281 and fixes it properly. That commit
was not enough as it was only inheriting the shaping_action
for prev_action, but not curr_action.
-
+
Micro-test added.
-
+
https://code.google.com/p/chromium/issues/detail?id=393896
- src/hb-ot-shape-complex-arabic.cc | 24
- +++++++++++++++------
+ src/hb-ot-shape-complex-arabic.cc | 24 +++++++++++++++------
src/hb-unicode-private.hh | 3 ++-
test/shaping/fonts/sha1sum/MANIFEST | 1 +
.../ef86fe710cfea877bbe0dbb6946a1f88d0661031.ttf | Bin 0 -> 2748 bytes
@@ -59932,16 +58823,15 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Jul 17 12:23:44 2014 -0400
- Revert "Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode
- codepoints"
-
+ Revert "Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode codepoints"
+
We now handle U+FFFD replacement in hb_buffer_add_utf*(). Any other
manipulation can happen in user callbacks. No need for this.
-
+
https://github.com/behdad/harfbuzz/commit/efe74214bbb68eaa3d7621e73869b5d58210107e#commitcomment-7039404
-
+
This reverts commit efe74214bbb68eaa3d7621e73869b5d58210107e.
-
+
Conflicts:
src/hb-ot-shape-normalize.cc
@@ -59981,26 +58871,25 @@
Date: Wed Jul 16 15:34:20 2014 -0400
New API: hb_buffer_[sg]et_replacement_codepoint()
-
+
With this change, we now by default replace broken UTF-8/16/32 bits
with U+FFFD. This can be changed by calling new API on the buffer.
Previously the replacement value used to be (hb_codepoint_t)-1.
-
+
Note that hb_buffer_clear_contents() does NOT reset the replacement
character.
-
+
See discussion here:
-
+
https://github.com/behdad/harfbuzz/commit/6f13b6d62daae4989e3cc2fe4b168e5c59650964
-
+
New API:
-
+
hb_buffer_set_replacement_codepoint()
hb_buffer_get_replacement_codepoint()
src/hb-buffer-private.hh | 1 +
- src/hb-buffer.cc | 45
- ++++++++++++++++++++++++++++++++++++++++++---
+ src/hb-buffer.cc | 45 ++++++++++++++++++++++++++++++++++++++++++---
src/hb-buffer.h | 15 ++++++++++++++-
src/hb-utf-private.hh | 34 ++++++++++++++++++++--------------
test/api/test-buffer.c | 26 +++++++++++++++-----------
@@ -60011,7 +58900,7 @@
Date: Wed Jul 16 14:59:04 2014 -0400
New API hb_buffer_add_codepoints()
-
+
Like hb_buffer_add_utf32, but doesn't do any Unicode validation.
This is like what hb_buffer_add_utf32 used to be until a couple
commits ago.
@@ -60027,8 +58916,7 @@
[buffer] Templatize UTF-* functions
src/hb-buffer.cc | 10 +-
- src/hb-utf-private.hh | 307
- ++++++++++++++++++++++++++------------------------
+ src/hb-utf-private.hh | 307 ++++++++++++++++++++++++++------------------------
2 files changed, 166 insertions(+), 151 deletions(-)
commit e634fed4285ce440d277345727ed01757df6d779
@@ -60036,12 +58924,11 @@
Date: Wed Jul 16 14:17:26 2014 -0400
[buffer] Validate UTF-32 input
-
+
Same as what we do for UTF-8 and UTF-16.
src/hb-utf-private.hh | 13 +++++++++---
- test/api/test-buffer.c | 55
- ++++++++++++++++++++++++++++++++++++++++++++++++++
+ test/api/test-buffer.c | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 65 insertions(+), 3 deletions(-)
commit b98c5db32d15fcfb27ce2f6737203ce1ad124319
@@ -60060,8 +58947,7 @@
[tests] Add record-test.sh
test/shaping/Makefile.am | 1 +
- test/shaping/record-test.sh | 49
- +++++++++++++++++++++++++++++++++++++++++++++
+ test/shaping/record-test.sh | 49 +++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 50 insertions(+)
commit 3b861421a772f52eb232ff93bd74b5a8214801ec
@@ -60069,30 +58955,26 @@
Date: Wed Jul 16 13:22:05 2014 -0400
Fix Mongolian Variation Selectors for fonts without GDEF
-
+
Originally we fixed those in 79d1007a501fd63c0ba4d51038c513e6b8b94740.
- However, fonts like MongolianWhite don't have GDEF, but have
- IgnoreMarks
+ However, fonts like MongolianWhite don't have GDEF, but have IgnoreMarks
in their LigatureSubstitute init/etc features. We were synthesizing a
GDEF class of mark for Mongolian Variation Selectors and as such the
ligature lookups where not matching. Uniscribe doesn't do that.
-
+
I tried with more sophisticated fixes, like, if there is no GDEF and
a lookup-flag mismatch happens, instead of rejecting a match, try
skipping that glyph. That surely produces some interesting behavior,
- but since we don't want to support fonts missing GDEF more than
- we have
+ but since we don't want to support fonts missing GDEF more than we have
to, I went for this simpler fix which is to always mark
default-ignorables as base when synthesizing GDEF.
-
+
Micro-test added.
-
+
Fixes rest of https://bugs.freedesktop.org/show_bug.cgi?id=65258
- src/hb-ot-shape.cc | 13
- +++++++++++--
- .../sha1sum/37033cc5cf37bb223d7355153016b6ccece93b28.ttf | Bin 0 ->
- 2780 bytes
+ src/hb-ot-shape.cc | 13 +++++++++++--
+ .../sha1sum/37033cc5cf37bb223d7355153016b6ccece93b28.ttf | Bin 0 -> 2780 bytes
test/shaping/fonts/sha1sum/MANIFEST | 1 +
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/mongolian-variation-selector.tests | 1 +
@@ -60167,12 +59049,11 @@
Date: Fri Jul 11 16:10:58 2014 -0400
Only accept well-formed UTF-8 sequences
-
+
Enable tests that were disabled before, and adjust one test,
and add more tests.
- src/hb-utf-private.hh | 93
- +++++++++++++++++++++++++++++++++-----------------
+ src/hb-utf-private.hh | 93 +++++++++++++++++++++++++++++++++-----------------
test/api/test-buffer.c | 9 +++--
2 files changed, 68 insertions(+), 34 deletions(-)
@@ -60190,14 +59071,13 @@
Date: Fri Jul 11 15:05:36 2014 -0400
Use hb_in_range() for arabic and indic tables
-
+
Though, looks like gcc was smart enough to produce the same code
before...
src/gen-arabic-table.py | 18 +-
src/gen-indic-table.py | 10 +-
- src/hb-ot-shape-complex-arabic-table.hh | 420
- ++++++++++++++++----------------
+ src/hb-ot-shape-complex-arabic-table.hh | 420 ++++++++++++++++----------------
src/hb-ot-shape-complex-indic-table.cc | 88 +++----
4 files changed, 268 insertions(+), 268 deletions(-)
@@ -60206,7 +59086,7 @@
Date: Fri Jul 11 14:54:42 2014 -0400
Mark unsigned integer literals with the u suffix
-
+
Simplifies hb_in_range() calls as the type can be inferred.
The rest is obsessiveness, I admit.
@@ -60231,8 +59111,7 @@
src/hb-ot-shape-complex-arabic-fallback.hh | 2 +-
src/hb-ot-shape-complex-hangul.cc | 36 +++---
src/hb-ot-shape-complex-hebrew.cc | 134 ++++++++++-----------
- src/hb-ot-shape-complex-indic.cc | 182
- ++++++++++++++---------------
+ src/hb-ot-shape-complex-indic.cc | 182 ++++++++++++++---------------
src/hb-ot-shape-complex-myanmar.cc | 56 ++++-----
src/hb-ot-shape-complex-sea.cc | 8 +-
src/hb-ot-shape-complex-thai.cc | 84 ++++++-------
@@ -60250,7 +59129,7 @@
Date: Fri Jul 11 14:18:01 2014 -0400
Simplify hb_in_range()
-
+
It's both faster and produces smaller code. Now I feel stupid for
not writing it this way before.
@@ -60271,15 +59150,15 @@
Date: Fri Jul 11 11:59:48 2014 -0400
Show U+FFFD REPLACEMENT CHARACTER for invalid Unicode codepoints
-
+
Only if the font doesn't support it. Ie, this gives the user to
use non-Unicode codepoints as private values and return a meaningful
glyph for them. But if it's invalid and font callback doesn't
like it, and if font has U+FFFD, show that instead.
-
+
Font functions that do not want this automatic replacement to
happen should return true from get_glyph() if unicode > 0x10FFFF.
-
+
Replaces https://github.com/behdad/harfbuzz/pull/27
src/hb-ot-shape-normalize.cc | 7 +++++++
@@ -60289,9 +59168,8 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Jul 10 19:31:40 2014 -0400
- When parsing UTF-16, generate invalid codepoint for lonely low
- surrogate
-
+ When parsing UTF-16, generate invalid codepoint for lonely low surrogate
+
Test passes now.
src/hb-utf-private.hh | 42 ++++++++++++++++++++++++++++--------------
@@ -60302,7 +59180,7 @@
Date: Thu Jul 10 19:31:16 2014 -0400
[test-buffer] Add test for lonely low-surrogate
-
+
Currenty fails. Ouch!
test/api/test-buffer.c | 1 +
@@ -60323,7 +59201,7 @@
Date: Thu Jul 10 19:20:35 2014 -0400
Fix lang matching logic
-
+
Previous code was broken logically, but harmless.
src/hb-ot-tag.cc | 2 +-
@@ -60354,7 +59232,7 @@
Date: Wed Jul 9 19:09:08 2014 -0400
[Android.mk] Update for new ICU
-
+
https://android-review.googlesource.com/#/c/100722/1/Android.mk
Android.mk | 2 +-
@@ -60393,7 +59271,7 @@
Date: Wed Jul 9 17:17:18 2014 -0400
Define _POSIX_C_SOURCE only if it is not defined
-
+
Fixes https://github.com/behdad/harfbuzz/pull/45
src/hb-blob.cc | 2 ++
@@ -60404,12 +59282,12 @@
Date: Wed Jul 9 17:07:06 2014 -0400
[tests] Remove bash'ish
-
+
Apparently on travis-ci, bash is linked to dash, which doesn't
understand "let". Failing tests were not being noticed. See eg:
-
+
https://travis-ci.org/behdad/harfbuzz/jobs/29544211
-
+
Don't rely on bash.
test/shaping/run-tests.sh | 4 ++--
@@ -60429,7 +59307,7 @@
Date: Wed Jul 9 16:51:38 2014 -0400
[ucdn] Update to Unicode 7.0.0 data
-
+
From http://github.com/behdad/ucdn
src/hb-ucdn.cc | 23 +
@@ -60436,8 +59314,7 @@
src/hb-ucdn/README | 1 +
src/hb-ucdn/ucdn.c | 2 +-
src/hb-ucdn/ucdn.h | 27 +
- src/hb-ucdn/unicodedata_db.h | 3711
- ++++++++++++++++++++++--------------------
+ src/hb-ucdn/unicodedata_db.h | 3711 ++++++++++++++++++++++--------------------
5 files changed, 2039 insertions(+), 1725 deletions(-)
commit 9d4ede3a97fff544a5ec2a671e49a92a79645b61
@@ -60472,7 +59349,7 @@
Date: Tue Jul 8 20:02:29 2014 -0400
[util/hb-shape] Accept an empty output-format that would skip output
-
+
Useful for benchmarking, to avoid buffer serialization overhead (which
seems to by far dominate shaping!)
@@ -60493,13 +59370,11 @@
Date: Sat Jul 5 15:50:18 2014 -0400
[util] Add option to set font function implementation to use
-
- Supports ft and ot right now. hb-view currently not rendering
- with ot.
+
+ Supports ft and ot right now. hb-view currently not rendering with ot.
Will fix after some clean up.
- util/options.cc | 76
- ++++++++++++++++++++++++++++++++++++++++++++++++++-------
+ util/options.cc | 76 ++++++++++++++++++++++++++++++++++++++++++++++++++-------
util/options.hh | 21 ++++++++++++++++
2 files changed, 88 insertions(+), 9 deletions(-)
@@ -60518,7 +59393,7 @@
Date: Tue Jul 1 15:51:54 2014 -0400
Add Roozbeh to AUTHORS
-
+
He's been my shadow for all Indic-related changes in the last
few months.
@@ -60539,7 +59414,7 @@
Date: Mon Jun 30 15:39:39 2014 -0400
[indic] Remove special-casing of U+1CF2,1CF3
-
+
These were introduced in a498565cedf0441ae723c5e5969f637d792a15e7,
but IndicSyllabicCategory has had the correct value already, so the
special code was never needed.
@@ -60552,7 +59427,7 @@
Date: Mon Jun 30 15:24:02 2014 -0400
[indic-table] Update to Unicode 7.0 data
-
+
Touch code just enough to preserve previous syllable structure
and functionality as closely as possible. Many further cleanups
coming later.
@@ -60559,8 +59434,7 @@
src/gen-indic-table.py | 4 +
src/hb-ot-shape-complex-indic-private.hh | 23 +-
- src/hb-ot-shape-complex-indic-table.cc | 468
- ++++++++++++++++++++++---------
+ src/hb-ot-shape-complex-indic-table.cc | 468 ++++++++++++++++++++++---------
src/hb-ot-shape-complex-indic.cc | 21 --
src/hb-ot-shape-complex-myanmar.cc | 2 -
5 files changed, 355 insertions(+), 163 deletions(-)
@@ -60572,8 +59446,7 @@
[indic-table] Fix category frequency counts in comments
src/gen-indic-table.py | 2 +-
- src/hb-ot-shape-complex-indic-table.cc | 46
- +++++++++++++++++-----------------
+ src/hb-ot-shape-complex-indic-table.cc | 46 +++++++++++++++++-----------------
2 files changed, 24 insertions(+), 24 deletions(-)
commit 5c4e3e9a57b6b735e7d72cbd5f4070cf024d7015
@@ -60582,8 +59455,7 @@
Whitespace
- src/hb-ot-shape-complex-indic-private.hh | 76
- ++++++++++++++++----------------
+ src/hb-ot-shape-complex-indic-private.hh | 76 ++++++++++++++++----------------
1 file changed, 38 insertions(+), 38 deletions(-)
commit af528b6674bccac3efd13f8b33fcdc6aeb178f4c
@@ -60600,11 +59472,11 @@
Date: Fri Jun 27 17:30:59 2014 -0400
Mark unsed members with a "Z" suffix
-
+
There may be more. There are members that are by definition
redundant or reserved and not needed, NOT what we *currently*
don't use.
-
+
I'm sure there's more...
src/hb-open-file-private.hh | 6 +++---
@@ -60627,8 +59499,7 @@
[cmap] Implement subtable format 14
- src/hb-ot-cmap-table.hh | 147
- +++++++++++++++++++++++++++++++++++++++++++-----
+ src/hb-ot-cmap-table.hh | 147 +++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 133 insertions(+), 14 deletions(-)
commit 586b60622c33878f9ca4826b4ef07369d32bf039
@@ -60744,14 +59615,14 @@
Date: Tue Jun 24 10:20:36 2014 -0600
Add back API removed recently
-
+
Add hb_ot_layout_language_get_required_feature_index() again, which
is used in Pango. This was removed in
da132937989acb4d8ca9bd41c79f98750e7dda30 in favor of
hb_ot_layout_language_get_required_feature().
-
+
API changes:
-
+
- Added hb_ot_layout_language_get_required_feature_index back.
src/hb-ot-layout.cc | 15 +++++++++++++++
@@ -60791,7 +59662,7 @@
Date: Sat Jun 21 15:25:59 2014 -0600
[indic-table] Update to Unicode 6.3.0
-
+
Was from 6.2.0. It's a no-op. Committing for the record.
src/hb-ot-shape-complex-indic-table.cc | 12 ++++++------
@@ -60811,13 +59682,11 @@
Date: Sat Jun 21 14:19:34 2014 -0600
[arabic-table] Update to Unicode 7.0
-
- Old table was from 6.2. Remove hard-coded Mongolian and Phags-pa
- data.
+
+ Old table was from 6.2. Remove hard-coded Mongolian and Phags-pa data.
This completes support for new scripts Manichian and Psaltar Pahlavi.
- src/hb-ot-shape-complex-arabic-table.hh | 72
- ++++++++++++++++++++++++++++-----
+ src/hb-ot-shape-complex-arabic-table.hh | 72 ++++++++++++++++++++++++++++-----
src/hb-ot-shape-complex-arabic.cc | 22 ----------
2 files changed, 63 insertions(+), 31 deletions(-)
@@ -60837,12 +59706,11 @@
Date: Sat Jun 21 14:07:00 2014 -0600
[arabic-table] Further tune
-
+
In anticipation of Unicode 7.0 data coming in the next commit.
src/gen-arabic-table.py | 10 ++++++---
- src/hb-ot-shape-complex-arabic-table.hh | 38
- +++++++++++++++------------------
+ src/hb-ot-shape-complex-arabic-table.hh | 38 +++++++++++++++------------------
2 files changed, 24 insertions(+), 24 deletions(-)
commit a133e6067aaebc494c0156b5fac7f4a879e12dbe
@@ -60859,11 +59727,10 @@
Date: Fri Jun 20 17:59:43 2014 -0400
[arabic-table] Use segmented table
-
+
No functional change.
- src/gen-arabic-table.py | 82
- +++++++++++++++++++++++----------
+ src/gen-arabic-table.py | 82 +++++++++++++++++++++++----------
src/hb-ot-shape-complex-arabic-table.hh | 53 ++++++++++++++-------
src/hb-ot-shape-complex-arabic.cc | 8 ++--
3 files changed, 97 insertions(+), 46 deletions(-)
@@ -60882,7 +59749,7 @@
Date: Fri Jun 20 16:47:43 2014 -0400
[indic-table] Minor
-
+
No output change.
src/gen-indic-table.py | 7 +------
@@ -60893,12 +59760,11 @@
Date: Fri Jun 20 16:30:10 2014 -0400
[arabic-table] Don't write comments
-
+
No functional change.
src/gen-arabic-table.py | 20 +-
- src/hb-ot-shape-complex-arabic-table.hh | 710
- ++------------------------------
+ src/hb-ot-shape-complex-arabic-table.hh | 710 ++------------------------------
2 files changed, 38 insertions(+), 692 deletions(-)
commit 200dfe3eb10feda2ad25940338b08011f4757ca4
@@ -60906,12 +59772,11 @@
Date: Fri Jun 20 16:20:59 2014 -0400
[arabic-table] Use short names for values
-
+
No functional change.
src/gen-arabic-table.py | 16 +-
- src/hb-ot-shape-complex-arabic-table.hh | 1386
- ++++++++++++++++---------------
+ src/hb-ot-shape-complex-arabic-table.hh | 1386 ++++++++++++++++---------------
2 files changed, 716 insertions(+), 686 deletions(-)
commit 3f5327a41efcf50f64d9498ef3dfd6875ef6a5ab
@@ -60919,12 +59784,11 @@
Date: Fri Jun 20 16:17:42 2014 -0400
[arabic-table] Read Blocks.txt and shuffle code around
-
+
No functional change.
src/Makefile.am | 2 +-
- src/gen-arabic-table.py | 80
- +++++++++++++++++++--------------
+ src/gen-arabic-table.py | 80 +++++++++++++++++++--------------
src/hb-ot-shape-complex-arabic-table.hh | 30 ++++++++-----
3 files changed, 67 insertions(+), 45 deletions(-)
@@ -60933,12 +59797,11 @@
Date: Fri Jun 20 15:25:30 2014 -0400
[indic-table] Black-list Thai, Lao, and Tibetan
-
+
We don't need Indic table for those.
src/gen-indic-table.py | 3 ++
- src/hb-ot-shape-complex-indic-table.cc | 94
- +++++++---------------------------
+ src/hb-ot-shape-complex-indic-table.cc | 94 +++++++---------------------------
2 files changed, 21 insertions(+), 76 deletions(-)
commit 65ac2dae4f284f563b2dc476a21e2b5a48124de8
@@ -60948,8 +59811,7 @@
[indic-table] Speed up lookup
src/gen-indic-table.py | 22 +++++++++---
- src/hb-ot-shape-complex-indic-table.cc | 61
- +++++++++++++++++++++++-----------
+ src/hb-ot-shape-complex-indic-table.cc | 61 +++++++++++++++++++++++-----------
2 files changed, 59 insertions(+), 24 deletions(-)
commit 64442a3f4c5c7be08893454742cad6bfe73cb8d7
@@ -60967,16 +59829,15 @@
Date: Fri Jun 20 14:56:22 2014 -0400
[indic-table] Make table more compact by not covering full blocks
-
+
-#define indic_offset_total 4416
+#define indic_offset_total 3816
-
+
-}; /* Table occupancy: 60% */
+}; /* Table occupancy: 69% */
src/gen-indic-table.py | 24 ++++--
- src/hb-ot-shape-complex-indic-table.cc | 150
- +++++++++------------------------
+ src/hb-ot-shape-complex-indic-table.cc | 150 +++++++++------------------------
2 files changed, 57 insertions(+), 117 deletions(-)
commit 190a251479b3cfc68871ff1daf9a9d1abe3f86e6
@@ -60984,12 +59845,11 @@
Date: Fri Jun 20 14:41:39 2014 -0400
[indic-table] Remove block range from data table
-
+
No functional change.
src/gen-indic-table.py | 4 +-
- src/hb-ot-shape-complex-indic-table.cc | 102
- ++++++++++++++++-----------------
+ src/hb-ot-shape-complex-indic-table.cc | 102 ++++++++++++++++-----------------
2 files changed, 54 insertions(+), 52 deletions(-)
commit 2b051c6057920c564c13c5d6a3e6dca93446fa12
@@ -60997,16 +59857,16 @@
Date: Fri Jun 20 14:09:57 2014 -0400
Rename HB_VERSION_CHECK and hb_version_check to "atleast"
-
+
HB_VERSION_CHECK's comparison was originally written wrongly
by mistake. When API tests were written, they were also written
wrongly to pass given the wrong implementation... Sigh.
-
+
Given the purpose of this API, there's no point in fixing it
without renaming it. As such, rename.
-
+
API changes:
-
+
HB_VERSION_CHECK -> HB_VERSION_ATLEAST
hb_version_check -> hb_version_atleast
@@ -61030,27 +59890,25 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Sun Apr 27 14:05:24 2014 +0100
- Rework handling of requiredFeature to solve problem with rlig in
- arial.ttf from winxp
-
+ Rework handling of requiredFeature to solve problem with rlig in arial.ttf from winxp
+
https://bugzilla.mozilla.org/show_bug.cgi?id=986802
Fixes https://github.com/behdad/harfbuzz/pull/39
-
+
API Change:
-
+
-hb_ot_layout_language_get_required_feature_index
+hb_ot_layout_language_get_required_feature
-
+
New API takes an extra pointer argument. Pass NULL in to get
behavior of previous API.
-
+
Reworked by behdad
src/hb-ot-layout-gsubgpos-private.hh | 4 +--
src/hb-ot-layout.cc | 29 ++++++++++++---------
src/hb-ot-layout.h | 11 ++++----
- src/hb-ot-map.cc | 50
- ++++++++++++++++++++++++++----------
+ src/hb-ot-map.cc | 50 ++++++++++++++++++++++++++----------
src/main.cc | 4 +--
5 files changed, 64 insertions(+), 34 deletions(-)
@@ -61059,7 +59917,7 @@
Date: Thu Jun 19 15:39:18 2014 -0400
Rename search() to bsearch() and lsearch()
-
+
Such that the complexity of the algorithm used is clear at
call site.
@@ -61073,7 +59931,7 @@
Date: Thu Jun 19 15:30:18 2014 -0400
Rename sort() to qsort()
-
+
In an effort to make the algorithm used clear.
src/hb-coretext.cc | 4 ++--
@@ -61088,8 +59946,7 @@
[unicode7] Update list of Default_Ignorable codepoints
- src/hb-unicode-private.hh | 66
- +++++++++++++++++++++--------------------------
+ src/hb-unicode-private.hh | 66 +++++++++++++++++++++--------------------------
1 file changed, 30 insertions(+), 36 deletions(-)
commit 7cfee3827636f0dff7df5c8975a4fadd1b4bfbd5
@@ -61097,7 +59954,7 @@
Date: Mon Apr 28 15:09:30 2014 -0700
[unicode7] Route Manichaean and Psalter Pahlavi through Arabic shaper
-
+
Still needs update to joining table to fully work.
src/hb-ot-shape-complex-private.hh | 4 ++++
@@ -61144,13 +60001,12 @@
Date: Tue Jun 10 13:10:30 2014 +0100
When zeroing mark widths for LTR, also adjust offset...
-
+
...so that they overstrike preceding glyph.
-
+
https://github.com/behdad/harfbuzz/pull/43
- src/hb-ot-shape.cc | 50
- +++++++++++++++++++++++++++++++++++++++-----------
+ src/hb-ot-shape.cc | 50 +++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 39 insertions(+), 11 deletions(-)
commit 80f7405a5208f88b8615aa4ce4c54ffeb16f04f8
@@ -61157,8 +60013,7 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Tue Jun 10 13:10:02 2014 +0100
- [Thai] set the correct general category on Nikhahit when decomposing
- Sara-Am.
+ [Thai] set the correct general category on Nikhahit when decomposing Sara-Am.
src/hb-ot-shape-complex-thai.cc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
@@ -61168,21 +60023,20 @@
Date: Fri Jun 6 17:55:02 2014 -0400
Fix base-position when 'pref' is NOT formed
-
+
If pre-base reordering Ra is NOT formed (or formed and then
broken up), we should consider that Ra as base. This is
observable when there's a left matra or dotreph that positions
before base.
-
+
Now, it might be that we shouldn't do this if the Ra happend
to form a below form. We can't quite deduce that right now...
-
+
Micro test added. Also at:
-
+
https://code.google.com/a/google.com/p/noto-alpha/issues/detail?id=186#c29
- src/hb-ot-shape-complex-indic.cc | 28
- +++++++++++++++++++--
+ src/hb-ot-shape-complex-indic.cc | 28 +++++++++++++++++++--
test/shaping/fonts/sha1sum/MANIFEST | 5 ++++
.../e207635780b42f898d58654b65098763e340f5c7.ttf | Bin 0 -> 3000 bytes
test/shaping/tests/indic-pref-blocking.tests | 3 ++-
@@ -61193,11 +60047,11 @@
Date: Fri Jun 6 17:28:38 2014 -0400
[indic] Recover OT_H undergone ligation and multiplication
-
+
Sometimes font designers form half/pref/etc consonant forms
unconditionally and then undo that conditionally. Try to
recover the OT_H classification in those cases.
-
+
No test number changes expected.
src/hb-ot-layout-private.hh | 8 ++++++++
@@ -61209,7 +60063,7 @@
Date: Fri Jun 6 17:19:35 2014 -0400
[indic] Improve base re-finding
-
+
No test numbers change.
src/hb-ot-shape-complex-indic.cc | 5 ++---
@@ -61229,7 +60083,7 @@
Date: Mon Jun 9 14:17:33 2014 -0400
Fix commit 3f38c1137b6219a646da141b08463ffa922d4e35
-
+
Previous commit was not compiling with clang.
configure.ac | 4 ++--
@@ -61240,10 +60094,10 @@
Date: Fri Jun 6 16:03:40 2014 -0400
Don't use -mstructure-size-boundary=8 on clang arm
-
+
As in building for Android / iPhone. Only set it if
struct{char} alignment is not 1.
-
+
NOT tested on an actual Arm architecture. Guess we'll know
when this makes it to people's build bots.
@@ -61264,28 +60118,26 @@
Date: Wed Jun 4 16:57:42 2014 -0400
[indic] Don't reorder reph/pref if ligature was expanded
-
+
Normally if you want to, say, conditionally prevent a 'pref', you
would use blocking contextual matching. Some designers instead
form the 'pref' form, then undo it in context. To detect that
we now also remember glyphs that went through MultipleSubst.
-
+
In the only place that this is used, Uniscribe seems to only care
about the "last" transformation between Ligature and Multiple
substitions. Ie. if you ligate, expand, and ligate again, it
moves the pref, but if you ligate and expand it doesn't. That's
why we clear the MULTIPLIED bit when setting LIGATED.
-
+
Micro-test added. Test: U+0D2F,0D4D,0D30 with font from:
-
+
[1]
https://code.google.com/a/google.com/p/noto-alpha/issues/detail?id=186#c29
src/hb-ot-layout-gsub-table.hh | 2 +-
- src/hb-ot-layout-gsubgpos-private.hh | 20
- ++++++++++++++++----
- src/hb-ot-layout-private.hh | 16
- +++++++++++++++-
+ src/hb-ot-layout-gsubgpos-private.hh | 20 ++++++++++++++++----
+ src/hb-ot-layout-private.hh | 16 +++++++++++++++-
src/hb-ot-shape-complex-indic.cc | 4 ++--
test/shaping/Makefile.am | 5 ++++-
.../226bc2deab3846f1a682085f70c67d0421014144.ttf | Bin 0 -> 2828 bytes
@@ -61344,10 +60196,10 @@
Date: Wed Jun 4 18:47:55 2014 -0400
[ot-font] Work around broken cmap subtable format 4 length
-
+
Roboto was hitting this. FreeType also has pretty much the
same code for this, in ttcmap.c:tt_cmap4_validate():
-
+
/* in certain fonts, the `length' field is invalid and goes */
/* out of bound. We try to correct this here... */
if ( table + length > valid->limit )
@@ -61354,7 +60206,7 @@
{
if ( valid->level >= FT_VALIDATE_TIGHT )
FT_INVALID_TOO_SHORT;
-
+
length = (FT_UInt)( valid->limit - table );
}
@@ -61376,7 +60228,7 @@
Date: Wed Jun 4 18:17:29 2014 -0400
[ot-font] Don't select a Null cmap subtable
-
+
Can happen either in broken fonts, or as a result of sanitize().
src/hb-ot-cmap-table.hh | 2 +-
@@ -61387,7 +60239,7 @@
Date: Tue Jun 3 17:57:00 2014 -0400
Fix some cppcheck warnings
-
+
Bug 77800 - cppcheck reports
src/hb-common.cc | 4 +++-
@@ -61411,8 +60263,7 @@
Move code around
- src/hb-private.hh | 134
- ++++++++++++++++++++++++++----------------------------
+ src/hb-private.hh | 134 ++++++++++++++++++++++++++----------------------------
1 file changed, 65 insertions(+), 69 deletions(-)
commit 17c3b809f42aec34d83dba2e6229ad85804bebae
@@ -61420,9 +60271,9 @@
Date: Mon Jun 2 15:08:18 2014 -0400
[indic] Treat U+A8E0..A8F1 as OT_A instead of OT_VD
-
+
Apparently they can intermix with other OT_A.
-
+
Test: U+0915,A8E2,1CD0
src/hb-ot-shape-complex-indic.cc | 2 +-
@@ -61433,9 +60284,9 @@
Date: Fri May 30 17:38:14 2014 -0400
[graphite2] Fix cluster mapping
-
+
Patch from Martin Hosken. I expect this to fix the following bugs:
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=75076
https://bugzilla.gnome.org/show_bug.cgi?id=723582
https://bugzilla.redhat.com/show_bug.cgi?id=998812
@@ -61458,13 +60309,11 @@
Date: Thu May 29 15:34:26 2014 -0400
[indic] Allow decimal and Brahmi digits as placeholders
-
+
Tests: U+0967,0951 U+0031,093F
- src/hb-ot-shape-complex-indic.cc |
- 4 ++++
- .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt |
- 2 ++
+ src/hb-ot-shape-complex-indic.cc | 4 ++++
+ .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 2 ++
2 files changed, 6 insertions(+)
commit e8b5d64039614ecce472eda1a7a603736da25d86
@@ -61472,15 +60321,13 @@
Date: Thu May 29 15:18:27 2014 -0400
[indic] Do NOT allow reph formation on placeholders
-
+
Only allow it on DOTTED CIRCLE. No effect on test numbers.
-
+
Test: U+0930,094D,00A0
- src/hb-ot-shape-complex-indic-machine.rl |
- 2 +-
- .../in-tree/shaper-indic/indic/script-devanagari/misc/dottedcircle.txt |
- 1 +
+ src/hb-ot-shape-complex-indic-machine.rl | 2 +-
+ .../in-tree/shaper-indic/indic/script-devanagari/misc/dottedcircle.txt | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
commit 52b562a6a058131c0103aaa5404d053e6465bb23
@@ -61488,7 +60335,7 @@
Date: Tue May 27 18:18:23 2014 -0400
[indic] Clean up a bit
-
+
No functional change intended.
src/hb-ot-shape-complex-indic.cc | 17 +++++------------
@@ -61529,7 +60376,7 @@
Date: Tue May 27 17:49:45 2014 -0400
[myanmar] Use OT_NBSP instead of OT_DOTTEDCIRCLE for OT_GB
-
+
No functional change.
src/hb-ot-shape-complex-myanmar-machine.rl | 2 +-
@@ -61552,7 +60399,7 @@
Date: Tue May 27 17:39:01 2014 -0400
[indic] Treat U+0A72..0A73 like regular consonants
-
+
Unicode 6.x IndicSyllableCategory categorizes them as
placeholders, but they can subjoin.
@@ -61582,7 +60429,7 @@
Date: Fri May 23 15:39:55 2014 -0400
[indic] Simplify grammar
-
+
No functional change.
src/hb-ot-shape-complex-indic-machine.rl | 7 +++----
@@ -61593,7 +60440,7 @@
Date: Fri May 23 15:38:42 2014 -0400
[indic] Always start new syllable for Avagraha
-
+
In fact, the previous grammar was ambigious. No functional
change.
@@ -61605,7 +60452,7 @@
Date: Fri May 23 15:33:13 2014 -0400
[indic] Rename avagraha cluster to symbol cluster
-
+
In anticipation of adding more characters to that class of clusters.
src/hb-ot-shape-complex-indic-machine.rl | 10 +++++-----
@@ -61654,7 +60501,7 @@
Date: Thu May 22 19:12:10 2014 -0400
[indic] Treat U+1CE1 as a tone-mark too
-
+
It's spacing, but otherwise the same as the other ones.
src/hb-ot-shape-complex-indic.cc | 2 +-
@@ -61665,7 +60512,7 @@
Date: Thu May 22 18:50:34 2014 -0400
[indic] Recategorize U+A8E0..A8F1 as OT_VD
-
+
Up to two of them come after all OT_A characters.
src/hb-ot-shape-complex-indic-machine.rl | 2 +-
@@ -61677,7 +60524,7 @@
Date: Thu May 22 18:43:14 2014 -0400
[indic] Allow up to three tone marks
-
+
According to Roozbeh, there are valid combinations in Unicode
proposals for up to three. Previously we were allowing up to two.
@@ -61689,7 +60536,7 @@
Date: Thu May 22 18:41:49 2014 -0400
[indic] Support more extended Devanagari tone marks
-
+
Also adjust U+0953,0954 handling.
src/hb-ot-shape-complex-indic.cc | 18 ++++++++++++------
@@ -61709,19 +60556,17 @@
Date: Thu May 15 14:04:02 2014 -0600
[indic] Improve reph formation of Sinhala and Telugu
-
- Sinhala and Telugu use "explicit" reph. That is, the reph is
- formed by
- a Ra,H,ZWJ sequence. Previously, upon detecting this sequence,
- we were
+
+ Sinhala and Telugu use "explicit" reph. That is, the reph is formed by
+ a Ra,H,ZWJ sequence. Previously, upon detecting this sequence, we were
checking checking whether the 'rphf' feature applies to the first two
glyphs of the sequence. This is how the Microsoft fonts are designed.
However, testing with Noto shows that apparently Uniscribe also forms
the reph if the lookup ligates all three glyphs. So, try both
sequences.
-
+
Doesn't affect test results for Sinhala or Telugu.
-
+
https://code.google.com/a/google.com/p/noto-alpha/issues/detail?id=232
src/hb-ot-shape-complex-indic.cc | 9 +++++++--
@@ -61732,7 +60577,7 @@
Date: Wed May 14 22:10:09 2014 +0100
Fix build with --coretext on older OS X
-
+
Fixes https://github.com/behdad/harfbuzz/pull/40
src/hb-coretext.h | 2 +-
@@ -61743,11 +60588,11 @@
Date: Wed May 14 16:44:39 2014 -0600
[myanmar] Allow MedialYa+Asat in the grammar
-
+
The grammar in the OT spec, and the existing Windows implementation
seem to be confused around where to allow Asat around the medial
consonants.
-
+
The previous grammar for medial group was allowing an Asat after
the medial group only if there was a medial Wa or Ha, but not if
there was only a medial Ya. This doesn't make sense to me and
@@ -61761,7 +60606,7 @@
produce dotted-circle where Windows is not, this commit changes
the grammar to allow one Asat after the medial group no matter
what comes in the group.
-
+
Test: U+1002,103A,103B vs U+1002,103B,103A
src/hb-ot-shape-complex-myanmar-machine.rl | 2 +-
@@ -61772,12 +60617,11 @@
Date: Wed May 14 16:44:16 2014 -0600
Add tests for Myanmar Asat+MedialYa and MedialYa+Asat sequences
-
+
One of them currently produces dotted-circle. Fix and detailed
message coming.
- test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/misc.txt |
- 2 ++
+ test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/misc.txt | 2 ++
1 file changed, 2 insertions(+)
commit c95587618c88d187be64f923033dae151cf820be
@@ -61814,8 +60658,7 @@
[ot] Factor out code between cmap subtable format 6 and 10
- src/hb-ot-cmap-table.hh | 49
- ++++++++++---------------------------------------
+ src/hb-ot-cmap-table.hh | 49 ++++++++++---------------------------------------
1 file changed, 10 insertions(+), 39 deletions(-)
commit 1a8ffc512987c1ff1b4896549f80b145c85454a8
@@ -61833,8 +60676,7 @@
[ot] Implement cmap subtable formats 6 and 10
- src/hb-ot-cmap-table.hh | 77
- +++++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-cmap-table.hh | 77 +++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 74 insertions(+), 3 deletions(-)
commit d294a2cb165c4f20daa5624969067c51eb9aef58
@@ -61843,8 +60685,7 @@
[ot] Implement cmap subtable format 13
- src/hb-ot-cmap-table.hh | 47
- +++++++++++++++++++++++++++++++++++++++++------
+ src/hb-ot-cmap-table.hh | 47 +++++++++++++++++++++++++++++++++++++++++------
1 file changed, 41 insertions(+), 6 deletions(-)
commit 0d75793fae95ed9f6b8522ae3af4fcdf397d8c36
@@ -61853,8 +60694,7 @@
[ot] Implement cmap subtable format 12
- src/hb-ot-cmap-table.hh | 63
- +++++++++++++++++++++++++++++++++++++++++++++++--
+ src/hb-ot-cmap-table.hh | 63 +++++++++++++++++++++++++++++++++++++++++++++++--
src/hb-ot-font.cc | 5 ++++
2 files changed, 66 insertions(+), 2 deletions(-)
@@ -61874,8 +60714,7 @@
[ot] Implement cmap subtable format 4
- src/hb-ot-cmap-table.hh | 52
- +++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-cmap-table.hh | 52 +++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
commit 4719621f20dfd6a0377c650a7b4df223c18dc143
@@ -61894,8 +60733,7 @@
[ot] Start implementing cmap table
src/Makefile.am | 1 +
- src/hb-ot-cmap-table.hh | 171
- ++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-cmap-table.hh | 171 ++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot-font.cc | 1 +
3 files changed, 173 insertions(+)
@@ -61941,7 +60779,7 @@
Date: Mon Apr 28 14:29:39 2014 -0700
Add static storage classifier to inline functions
-
+
Before we were just relying on the compiler inlining them and not
leaving a trace in our public API. Try to fix. Hopefully not
breaking anyone's build.
@@ -61959,9 +60797,9 @@
Date: Mon Apr 28 12:38:25 2014 -0700
[tibetan] Reorder PADMA sign to occur after other below marks
-
+
Based on suggestion from Andrew Glass.
-
+
Test: U+0F40,0FC6,0F83
src/hb-unicode-private.hh | 4 ++++
@@ -61972,11 +60810,10 @@
Date: Mon Apr 28 12:43:42 2014 -0700
[test] Add test case for Tibetan sign PADMA
-
+
Currently fails.
- test/shaping/texts/in-tree/shaper-tibetan/script-tibetan/misc/misc.txt |
- 1 +
+ test/shaping/texts/in-tree/shaper-tibetan/script-tibetan/misc/misc.txt | 1 +
1 file changed, 1 insertion(+)
commit ee703bc3ef740c300718fca7a12c050c322dce19
@@ -61985,28 +60822,17 @@
Reshuffle test data
- test/shaping/texts/in-tree/MANIFEST |
- 3 +++
- test/shaping/texts/in-tree/shaper-default/MANIFEST |
- 3 ---
- .../in-tree/{shaper-default => shaper-hangul}/script-hangul/MANIFEST
- | 0
- .../{shaper-default => shaper-hangul}/script-hangul/misc/MANIFEST
- | 0
- .../{shaper-default => shaper-hangul}/script-hangul/misc/misc.txt
- | 0
- .../in-tree/{shaper-default => shaper-hebrew}/script-hebrew/MANIFEST
- | 0
- .../{shaper-default => shaper-hebrew}/script-hebrew/misc/MANIFEST
- | 0
- .../script-hebrew/misc/diacritics.txt |
- 0
- .../in-tree/{shaper-default => shaper-tibetan}/script-tibetan/MANIFEST
- | 0
- .../{shaper-default => shaper-tibetan}/script-tibetan/misc/MANIFEST
- | 0
- .../{shaper-default => shaper-tibetan}/script-tibetan/misc/misc.txt
- | 0
+ test/shaping/texts/in-tree/MANIFEST | 3 +++
+ test/shaping/texts/in-tree/shaper-default/MANIFEST | 3 ---
+ .../in-tree/{shaper-default => shaper-hangul}/script-hangul/MANIFEST | 0
+ .../{shaper-default => shaper-hangul}/script-hangul/misc/MANIFEST | 0
+ .../{shaper-default => shaper-hangul}/script-hangul/misc/misc.txt | 0
+ .../in-tree/{shaper-default => shaper-hebrew}/script-hebrew/MANIFEST | 0
+ .../{shaper-default => shaper-hebrew}/script-hebrew/misc/MANIFEST | 0
+ .../script-hebrew/misc/diacritics.txt | 0
+ .../in-tree/{shaper-default => shaper-tibetan}/script-tibetan/MANIFEST | 0
+ .../{shaper-default => shaper-tibetan}/script-tibetan/misc/MANIFEST | 0
+ .../{shaper-default => shaper-tibetan}/script-tibetan/misc/misc.txt | 0
11 files changed, 3 insertions(+), 3 deletions(-)
commit b082ef373cefb35dd98b5f2f0b677ccc7806f51e
@@ -62023,54 +60849,40 @@
Date: Fri Apr 18 16:53:34 2014 -0700
[indic] Fix-up zero-context matching
-
+
commit b5a0f69e47ace468b06e21cf069a18ddcfcf6064
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Thu Oct 17 18:04:23 2013 +0200
-
- [indic] Pass zero-context=false to would_substitute for newer
- scripts
-
- For scripts without an old/new spec distinction, use
- zero-context=false.
- This changes behavior in Sinhala / Khmer, but doesn't seem
- to regress.
+
+ [indic] Pass zero-context=false to would_substitute for newer scripts
+
+ For scripts without an old/new spec distinction, use zero-context=false.
+ This changes behavior in Sinhala / Khmer, but doesn't seem to regress.
This will be useful and used in Javanese.
-
- The *intention* was to change zero-context from true to false for
- scripts that
- don't have old-vs-new specs. However, checking the code, looks
- like we
- essentially change zero-context to always be true; ie. we only
- changed things
+
+ The *intention* was to change zero-context from true to false for scripts that
+ don't have old-vs-new specs. However, checking the code, looks like we
+ essentially change zero-context to always be true; ie. we only changed things
for old-spec, and we broke them. That's what causes this bug:
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=76705
-
+
The root of the bug is here:
-
- /* Use zero-context would_substitute() matching for new-spec of
- the main
- * Indic scripts, but not for old-spec or scripts with one spec
- only. */
- bool zero_context = indic_plan->config->has_old_spec ||
- !indic_plan->is_old_spec;
-
+
+ /* Use zero-context would_substitute() matching for new-spec of the main
+ * Indic scripts, but not for old-spec or scripts with one spec only. */
+ bool zero_context = indic_plan->config->has_old_spec || !indic_plan->is_old_spec;
+
Note that is_old_spec itself is:
-
- indic_plan->is_old_spec = indic_plan->config->has_old_spec &&
- ((plan->map.chosen_script[0] & 0x000000FF) != '2');
-
- It's easy to show that zero_context is now always true. What we
- really meant was:
-
- bool zero_context = indic_plan->config->has_old_spec &&
- !indic_plan->is_old_spec;
-
- Ie, "&&" instead of "||". We made this change supposedly to make
- Javanese
- work. But apparently we got it working regardless! So I'm going
- to fix this
+
+ indic_plan->is_old_spec = indic_plan->config->has_old_spec && ((plan->map.chosen_script[0] & 0x000000FF) != '2');
+
+ It's easy to show that zero_context is now always true. What we really meant was:
+
+ bool zero_context = indic_plan->config->has_old_spec && !indic_plan->is_old_spec;
+
+ Ie, "&&" instead of "||". We made this change supposedly to make Javanese
+ work. But apparently we got it working regardless! So I'm going to fix this
to only change the logic for old-spec and not touch other cases.
src/hb-ot-shape-complex-indic.cc | 4 ++--
@@ -62081,7 +60893,7 @@
Date: Mon Apr 14 15:55:42 2014 -0700
Add HB_NO_MERGE_CLUSTERS
-
+
Disables any cluster-merging. Added for testing purposes while
we investigate what kind of API to add for this.
@@ -62094,8 +60906,7 @@
Add Khmer test for U+17DD
- .../shaper-indic/south-east-asian/script-khmer/misc/other-marks.txt
- | 1 +
+ .../shaper-indic/south-east-asian/script-khmer/misc/other-marks.txt | 1 +
1 file changed, 1 insertion(+)
commit 50a00535ccac538bbf93358fd2d2442e4c12542f
@@ -62103,7 +60914,7 @@
Date: Thu Apr 10 16:03:29 2014 -0700
Require gobject-introspection 1.34.0
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=75384
configure.ac | 2 +-
@@ -62114,7 +60925,7 @@
Date: Wed Apr 9 16:38:26 2014 -0700
Further adjust check-defs and check-symbols for mipsel
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=74491
src/check-defs.sh | 2 +-
@@ -62126,7 +60937,7 @@
Date: Wed Apr 9 16:33:32 2014 -0700
Tighten up check-static-inits.sh check
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=74490
src/check-static-inits.sh | 2 +-
@@ -62146,7 +60957,7 @@
Date: Tue Apr 8 16:03:35 2014 -0700
[indic] Support U+17DD KHMER SIGN ATTHACAN
-
+
As requested by Martin Hosken on the list.
src/hb-ot-shape-complex-indic.cc | 3 ++-
@@ -62157,7 +60968,7 @@
Date: Wed Apr 2 11:35:27 2014 +0100
Use __aarch64__ for 64-bit ARM detection, not __arm64__
-
+
Many GCC versions don't define __arm64__
src/hb-atomic-private.hh | 2 +-
@@ -62181,8 +60992,7 @@
src/Makefile.am | 3 +-
src/hb-glib.cc | 2 +-
src/hb-icu.cc | 2 +-
- src/hb-ot-font.cc | 260
- ++++++++++++++++++++++++++++++++++++
+ src/hb-ot-font.cc | 260 ++++++++++++++++++++++++++++++++++++
src/{hb-tt-font.cc => hb-ot-font.h} | 56 ++------
src/hb-ot-hhea-table.hh | 2 +-
src/hb-ot-hmtx-table.hh | 2 +-
@@ -62205,7 +61015,7 @@
Date: Fri Mar 21 12:53:08 2014 -0700
One more fix for build without gtk-doc
-
+
Fixes https://github.com/behdad/harfbuzz/pull/35
autogen.sh | 2 +-
@@ -62216,7 +61026,7 @@
Date: Thu Mar 20 16:01:30 2014 +0200
Fix build with --coretext on iOS
-
+
On iOS CoreText and CoreGraphics are stand-alone frameworks
configure.ac | 23 +++++++++++++++++++----
@@ -62280,7 +61090,7 @@
Date: Sun Mar 16 20:22:42 2014 -0700
Don't use "register" storage class specifier
-
+
Fixes warnings.
https://bugzilla.mozilla.org/show_bug.cgi?id=984081
@@ -62292,10 +61102,9 @@
Date: Sun Mar 16 08:25:17 2014 +0000
wrap definition of free_langs() with HAVE_ATEXIT
+
+ ...to avoid an unused function warning; see mozilla bug https://bugzilla.mozilla.org/show_bug.cgi?id=984081.
- ...to avoid an unused function warning; see mozilla bug
- https://bugzilla.mozilla.org/show_bug.cgi?id=984081.
-
src/hb-common.cc | 2 ++
1 file changed, 2 insertions(+)
@@ -62304,11 +61113,10 @@
Date: Fri Mar 14 19:55:46 2014 -0700
[coretext] Add hb_coretext_face_create()
-
+
Not tested.
- src/hb-coretext.cc | 57
- +++++++++++++++++++++++++++++++++++++++++++++---------
+ src/hb-coretext.cc | 57 +++++++++++++++++++++++++++++++++++++++++++++---------
src/hb-coretext.h | 4 ++++
2 files changed, 52 insertions(+), 9 deletions(-)
@@ -62317,17 +61125,16 @@
Date: Fri Mar 14 19:37:55 2014 -0400
[coretext] Add coretext_aat shaper
-
+
This is a higher-priority shaper than default shaper ("ot"), but
only picks up fonts that have AAT "morx"/"mort" table.
-
+
Note that for this to work the font face's get_table() implementation
should know how to return the full font blob.
-
+
Based on patch from Konstantin Ritt.
- src/hb-coretext.cc | 94
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-coretext.cc | 94 +++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-coretext.h | 4 +++
src/hb-shaper-list.hh | 4 +++
3 files changed, 102 insertions(+)
@@ -62337,7 +61144,7 @@
Date: Fri Mar 14 15:52:47 2014 -0700
If HAVE_ICU_BUILTIN is defined, use hb-icu Unicode callbacks
-
+
Useful for Android / Chrome / etc when ICU is built in the same
library as harfbuzz itself.
@@ -62359,10 +61166,8 @@
Add Myanmar test case from OpenType Myanmar spec
- test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/MANIFEST |
- 1 +
- .../shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/otspec.txt |
- 2 ++
+ test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/MANIFEST | 1 +
+ .../shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/otspec.txt | 2 ++
2 files changed, 3 insertions(+)
commit 158985908981189a2fd4d15275a641286fc770fe
@@ -62371,12 +61176,9 @@
Minor
- test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/MANIFEST
- | 1 -
- test/shaping/texts/in-tree/shaper-sea/script-tai-tham/misc/MANIFEST
- | 1 +
- .../script-myanmar => shaper-sea/script-tai-tham}/misc/torture.txt
- | 0
+ test/shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/MANIFEST | 1 -
+ test/shaping/texts/in-tree/shaper-sea/script-tai-tham/misc/MANIFEST | 1 +
+ .../script-myanmar => shaper-sea/script-tai-tham}/misc/torture.txt | 0
3 files changed, 1 insertion(+), 1 deletion(-)
commit bb8ffb581b89cf27fb8e0743b81bbda21654233e
@@ -62395,13 +61197,13 @@
Date: Tue Feb 18 15:53:56 2014 -0500
Only do fallback Hebrew composition if no GPOS 'mark' available
-
+
Apparently some modern fonts have proper GPOS mark positioning
tables, but undesirable precomposed forms! See thread
"Hebrew composition to presentation forms" and:
-
+
http://tex.stackexchange.com/questions/156775/having-trouble-with-vowel-positioning-in-ezra-sil-xelatex
-
+
Test case: U+fb1d,05d9,05b4
src/hb-ot-shape-complex-hebrew.cc | 2 +-
@@ -62413,7 +61215,7 @@
Date: Tue Feb 11 17:29:40 2014 -0500
Allow bootstrapping without gtk-doc
-
+
Seems like configure.ac is already able to handle it.
autogen.sh | 10 +++++-----
@@ -62442,7 +61244,7 @@
Date: Wed Feb 5 08:22:06 2014 -0500
Improve MemoryBarrier() implementation
-
+
See thread "[HarfBuzz] compilation error of 0.9.26 with MinGW"
started by Werner.
@@ -62464,7 +61266,7 @@
Date: Wed Jan 29 14:07:58 2014 +0000
Ensure hb_script_t can safely hold any hb_tag_t value it's given.
-
+
Fixes https://github.com/behdad/harfbuzz/pull/21
src/hb-common.h | 8 +++++++-
@@ -62475,7 +61277,7 @@
Date: Tue Jan 28 17:29:42 2014 -0500
[coretext] Handle surrogate pairs when generating notdef glyphs
-
+
Fixes github.com/behdad/harfbuzz/pull/19
src/hb-coretext.cc | 18 ++++++++++++++----
@@ -62513,7 +61315,7 @@
Date: Wed Jan 22 21:07:13 2014 +0200
Make it possible to disable the fallback shaper at configure time
-
+
The OT shaper supersedes the fallback shaper in every case
and the latter become an extra weight for 99.9% of users.
@@ -62527,7 +61329,7 @@
Date: Thu Jan 23 14:18:49 2014 -0500
Fix clang warning 'private field 'xxx' is not used
-
+
Fixes https://github.com/behdad/harfbuzz/pull/16
src/hb-open-type-private.hh | 2 +-
@@ -62538,7 +61340,7 @@
Date: Thu Jan 23 14:11:03 2014 -0500
Fix typo in _hb_buffer_serialize_glyphs_text()
-
+
Fixes https://github.com/behdad/harfbuzz/pull/17
src/hb-buffer-serialize.cc | 2 +-
@@ -62549,10 +61351,10 @@
Date: Wed Jan 22 11:03:02 2014 -0500
[arabic] Disable 'cswh' by default
-
+
I believe Windows 8 disables it, and spec update dated
Jan 2014 also clearly says it's disabled by default:
-
+
http://www.microsoft.com/typography/OpenTypeDev/arabic/intro.htm#features
src/hb-ot-shape-complex-arabic.cc | 1 -
@@ -62573,7 +61375,7 @@
Date: Wed Jan 22 04:43:51 2014 -0800
Merge pull request #13 from jfkthame/hangul-shaper
-
+
Tone-mark reordering and improved Old Hangul support
commit 62cb28dfc668cae9cbff826229bde2271e157927
@@ -62589,8 +61391,7 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Mon Jan 20 19:49:47 2014 +0000
- [hangul] Fix ordering of dotted circle with Hangul tone mark (reported
- by Dohyun Kim).
+ [hangul] Fix ordering of dotted circle with Hangul tone mark (reported by Dohyun Kim).
src/hb-ot-shape-complex-hangul.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -62599,8 +61400,7 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Mon Jan 20 10:38:27 2014 +0000
- [hangul] Don't force zero-width for marks - this is not wanted for
- the Jamo Filler glyphs.
+ [hangul] Don't force zero-width for marks - this is not wanted for the Jamo Filler glyphs.
src/hb-ot-shape-complex-hangul.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
@@ -62609,8 +61409,7 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Mon Jan 20 10:37:32 2014 +0000
- [unicode] Exclude the Jamo Filler characters from Default_Ignorable,
- as some fonts want these to be visible/spacing glyphs.
+ [unicode] Exclude the Jamo Filler characters from Default_Ignorable, as some fonts want these to be visible/spacing glyphs.
src/hb-unicode-private.hh | 15 +++++++--------
1 file changed, 7 insertions(+), 8 deletions(-)
@@ -62619,11 +61418,9 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Mon Jan 20 10:35:51 2014 +0000
- [hangul] Reorder Hangul tone mark to beginning of syllable, unless
- font implements it using a zero-width glyph.
+ [hangul] Reorder Hangul tone mark to beginning of syllable, unless font implements it using a zero-width glyph.
- src/hb-ot-shape-complex-hangul.cc | 59
- ++++++++++++++++++++++++++++++++++++++-
+ src/hb-ot-shape-complex-hangul.cc | 59 ++++++++++++++++++++++++++++++++++++++-
1 file changed, 58 insertions(+), 1 deletion(-)
commit 103436838df3a77552d3d33fc4bd80f09d9bf079
@@ -62630,12 +61427,9 @@
Author: Jonathan Kew <jfkthame at gmail.com>
Date: Mon Jan 20 10:35:07 2014 +0000
- [hangul] Apply the appropriate *jmo features to decomposed
- syllables, including Old Hangul sequences that don't have Unicode
- compositions. Merge clusters in decomposed syllables.
+ [hangul] Apply the appropriate *jmo features to decomposed syllables, including Old Hangul sequences that don't have Unicode compositions. Merge clusters in decomposed syllables.
- src/hb-ot-shape-complex-hangul.cc | 197
- +++++++++++++++++++++++++++++++-------
+ src/hb-ot-shape-complex-hangul.cc | 197 +++++++++++++++++++++++++++++++-------
1 file changed, 165 insertions(+), 32 deletions(-)
commit 8fc1f7fe74a25bf8549f5edd79c7da6b720eb064
@@ -62643,7 +61437,7 @@
Date: Thu Jan 2 17:04:04 2014 +0800
[ot/hangul] Don't decompose Hangul even when combining marks present
-
+
As discussed on
https://github.com/behdad/harfbuzz/pull/10#issuecomment-31442030
@@ -62657,7 +61451,7 @@
Date: Thu Jan 2 14:33:10 2014 +0800
[ot] Simplify composing
-
+
Not tested. Ouch.
src/hb-ot-shape-normalize.cc | 5 +++--
@@ -62688,7 +61482,7 @@
Date: Thu Jan 2 14:20:00 2014 +0800
[hangul] Fix decomposition logic
-
+
Seems to be working now.
src/hb-ot-shape-complex-hangul.cc | 19 ++++++++-----------
@@ -62699,7 +61493,7 @@
Date: Thu Jan 2 14:04:30 2014 +0800
[hangul] Fix decomposition
-
+
Part of https://github.com/behdad/harfbuzz/pull/10
src/hb-ot-shape-complex-hangul.cc | 4 ++--
@@ -62710,7 +61504,7 @@
Date: Thu Jan 2 14:01:56 2014 +0800
[hangul] Tighten up character categories
-
+
I had tried to expand to fill the blocks, but that sounds wrong in
retrospect.
@@ -62722,14 +61516,12 @@
Date: Tue Dec 31 16:49:15 2013 +0800
[ot] Separate out hebrew and tibetan shapers from default
-
+
Now default shaper is truly no-op.
src/Makefile.am | 2 +
- src/hb-ot-shape-complex-default.cc | 161
- +---------------------------------
- src/hb-ot-shape-complex-hebrew.cc | 172
- +++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-default.cc | 161 +---------------------------------
+ src/hb-ot-shape-complex-hebrew.cc | 172 +++++++++++++++++++++++++++++++++++++
src/hb-ot-shape-complex-private.hh | 17 +++-
src/hb-ot-shape-complex-tibetan.cc | 61 +++++++++++++
5 files changed, 251 insertions(+), 162 deletions(-)
@@ -62751,10 +61543,9 @@
Date: Tue Dec 31 16:04:35 2013 +0800
[ot] Simplify normalization_preference again
+
+ No shaper has more than one behavior re this, so no need for a callback.
- No shaper has more than one behavior re this, so no need for
- a callback.
-
src/hb-ot-shape-complex-arabic.cc | 2 +-
src/hb-ot-shape-complex-default.cc | 8 +-------
src/hb-ot-shape-complex-hangul.cc | 2 +-
@@ -62771,10 +61562,10 @@
Date: Tue Dec 31 15:55:40 2013 +0800
[ot] Add Hangul shaper
-
+
Not exhaustively tested, but I think I got the intended logic
right.
-
+
The logic can perhaps be simplified. Maybe we should disabled
normalization with this shaper. Then again, for now focusing on
correctness.
@@ -62781,8 +61572,7 @@
src/Makefile.am | 1 +
src/hb-ot-shape-complex-default.cc | 13 ---
- src/hb-ot-shape-complex-hangul.cc | 232
- +++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape-complex-hangul.cc | 232 +++++++++++++++++++++++++++++++++++++
src/hb-ot-shape-complex-private.hh | 10 +-
src/hb-private.hh | 6 +
5 files changed, 240 insertions(+), 22 deletions(-)
@@ -62822,8 +61612,7 @@
src/Makefile.am | 1 +
src/hb-ot-layout.h | 5 -----
- src/hb-ot-shape.h | 53
- +++++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape.h | 53 +++++++++++++++++++++++++++++++++++++++++++++++++++++
src/hb-ot.h | 9 +--------
4 files changed, 55 insertions(+), 13 deletions(-)
@@ -62871,21 +61660,20 @@
Date: Sun Dec 22 16:17:54 2013 -0500
Bug 72698 - Automatically support frac / numr / dnom
-
+
When seeing U+2044 FRACTION SLASH in the text, find decimal
digits (Unicode General Category Decimal_Number) around it,
and mark the pre-slash digits with 'numr' feature, the post-slash
digits with 'dnom' feature, and the whole sequence with 'frac'
feature.
-
+
This beautifully renders fractions with major Windows fonts,
and any other font that implements those features (numr/dnom is
enough for most fonts.)
-
+
Not the fastest way to do this, but good enough for a start.
- src/hb-ot-shape.cc | 51
- +++++++++++++++++++++++++++++++++++++++++++++++++++
+ src/hb-ot-shape.cc | 51 +++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 51 insertions(+)
commit 014f369ec98fdbb3e7a2ef68aea2c4e017e7b680
@@ -62902,7 +61690,7 @@
Date: Sat Dec 21 00:18:18 2013 -0500
Initialize masks before mirroring
-
+
We were throwing away the rtlm feature mask set during
mirroring...
@@ -62956,7 +61744,7 @@
Date: Thu Dec 5 18:19:35 2013 -0500
Drop required automake version back to 1.11.3
-
+
Work around broken automake-1.13 changes.
configure.ac | 3 ++-
@@ -62996,9 +61784,9 @@
Date: Wed Dec 4 19:59:48 2013 -0500
Require automake 1.13
-
+
Fix tests build.
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=71353
configure.ac | 2 +-
@@ -63010,7 +61798,7 @@
Date: Mon Dec 2 20:41:41 2013 -0500
Revert "Karen" language mapping back to what it was before
-
+
https://bugzilla.mozilla.org/show_bug.cgi?id=941470
src/hb-ot-tag.cc | 4 ++--
@@ -63052,8 +61840,7 @@
cache shape plans even if (global) user features are set
src/hb-shape-plan-private.hh | 3 +++
- src/hb-shape-plan.cc | 59
- ++++++++++++++++++++++++++++++++++++++++----
+ src/hb-shape-plan.cc | 59 ++++++++++++++++++++++++++++++++++++++++----
2 files changed, 57 insertions(+), 5 deletions(-)
commit 8ffa528f28a24ae85952ad1c1b0206e736bcfeab
@@ -63061,7 +61848,7 @@
Date: Mon Dec 2 05:17:14 2013 -0500
Add note about unsafe shape_plan->face
-
+
Will fix by removing shape_plan->face completely.
src/hb-shape-plan.cc | 2 ++
@@ -63090,11 +61877,9 @@
Date: Fri Nov 29 19:01:56 2013 -0500
[coretext] Avoid font fallback with CoreText shaper
-
- CoreText does automatic font fallback (AKA "cascading") for
- characters
- not supported by the requested font, and provides no way to turn
- it off,
+
+ CoreText does automatic font fallback (AKA "cascading") for characters
+ not supported by the requested font, and provides no way to turn it off,
so detect if the returned run uses a font other than the requested one
and fill in the buffer with .notdef glyphs instead of random indices
glyph from a different font.
@@ -63134,15 +61919,15 @@
Date: Mon Nov 25 18:10:38 2013 -0500
[myanmar] Allow punctuation clusters
-
+
The spec and Uniscribe don't allow these, but UTN#11
specifically says the sequence U+104B,U+1038 is valid.
As such, allow all "P V" sequences. There's about
eight sequences that match that structure, but Roozbeh
thinks it's fine to allow all of them.
-
+
Test case: U+104B, U+1038
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=71947
src/hb-ot-shape-complex-myanmar-machine.rl | 3 +++
@@ -63154,12 +61939,12 @@
Date: Mon Nov 25 18:03:34 2013 -0500
[myanmar] Mark U+104E MYANMAR SYMBOL AFOREMENTIONED as Consonant
-
+
The spec and Uniscribe treat it as consonant in the grammar, but
it's not in IndicSyllableCategory.txt, so fix up.
-
+
Test sequence: U+1004,U+103A,U+1039,U+104E
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=71948
src/hb-ot-shape-complex-myanmar.cc | 4 ++++
@@ -63170,15 +61955,15 @@
Date: Mon Nov 25 17:50:07 2013 -0500
[myanmar] Relax pwo-tone group a bit
-
+
This is broken sequence according to OpenType spec, Uniscribe,
and current HarfBuzz implementation. But Roozbeh says this
is a valid sequence, so allow it. There are multiple
"(DB As?)?" constructs in the grammar, but Roozbeh thinks only
this one needs changing.
-
+
Test case: 1014,1063,103A
-
+
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=71949
src/hb-ot-shape-complex-myanmar-machine.rl | 2 +-
@@ -63189,15 +61974,14 @@
Date: Mon Nov 25 17:47:19 2013 -0500
Add more Myanmar test cases
-
+
All three are broken right now according to Roozbeh.
-
+
https://bugs.freedesktop.org/show_bug.cgi?id=71947
https://bugs.freedesktop.org/show_bug.cgi?id=71948
https://bugs.freedesktop.org/show_bug.cgi?id=71949
- .../shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/misc.txt |
- 4 ++++
+ .../shaping/texts/in-tree/shaper-myanmar/script-myanmar/misc/misc.txt | 4 ++++
1 file changed, 4 insertions(+)
commit 08c2d27d35093e07142168665139274ac99395e8
@@ -63205,13 +61989,12 @@
Date: Sat Nov 23 21:39:31 2013 -0800
Added support for several new languages
-
+
Based on research into latest SIL and Windows fonts, pulling in
the latest OpenType language tag proposal from Microsoft, and updating
to latest language tags and names from ISO 639.
- src/hb-ot-tag.cc | 314
- +++++++++++++++++++++++++++++++++++++++++++------------
+ src/hb-ot-tag.cc | 314 +++++++++++++++++++++++++++++++++++++++++++------------
1 file changed, 247 insertions(+), 67 deletions(-)
commit 05511acd198d0c2157cdb41e1d36eac0b8075357
@@ -63219,7 +62002,7 @@
Date: Sat Nov 23 15:19:07 2013 -0800
Added language tags for S'gaw Karen and Khamti
-
+
Tags based on support in Windows 8.1's 'Myanmar Text' font.
src/hb-ot-tag.cc | 2 ++
@@ -63239,7 +62022,7 @@
Date: Fri Nov 15 13:05:38 2013 -0500
Set buffer content type to INVALID in hb_buffer_set_length(0)
-
+
Previously we were only setting this in hb_buffer_clear_contents(),
but set_length(0) is a valid way to reinitialize buffer to use with
new text.
@@ -63263,7 +62046,7 @@
Date: Wed Nov 13 14:50:25 2013 -0500
Use long alignment for scratch buffer
-
+
Fixes last of scratch alignment warnings in hb-coretext.
src/hb-buffer-private.hh | 2 +-
@@ -63320,9 +62103,9 @@
Date: Wed Nov 6 14:46:04 2013 -0500
Fix llvm warnings on Mac
-
+
Patch from Scott Fleischman. Warnings were:
-
+
harfbuzz/src/hb-font-private.hh:121:42: Implicit conversion loses
integer precision: 'long long' to 'hb_position_t' (aka 'int')
harfbuzz/src/hb-font-private.hh:126:42: Implicit conversion loses
@@ -63329,8 +62112,7 @@
integer precision: 'long long' to 'hb_position_t' (aka 'int')
harfbuzz/src/hb-font-private.hh:400:85: Implicit conversion loses
integer precision: 'long long' to 'hb_position_t' (aka 'int')
- harfbuzz/src/hb-ot-layout-common-private.hh:1115:37: Implicit
- conversion
+ harfbuzz/src/hb-ot-layout-common-private.hh:1115:37: Implicit conversion
loses integer precision: 'long long' to 'int'
harfbuzz/src/hb-ft.cc:421:97: Implicit conversion loses integer
precision: 'unsigned long long' to 'int'
@@ -63347,13 +62129,12 @@
Date: Wed Oct 30 17:30:11 2013 +0000
[otlayout] Remove unused is_inplace()
-
+
Patch from Jonathan Kew.
src/hb-ot-layout-gpos-table.hh | 6 --
src/hb-ot-layout-gsub-table.hh | 56 ------------
- src/hb-ot-layout-gsubgpos-private.hh | 159
- -----------------------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 159 -----------------------------------
3 files changed, 221 deletions(-)
commit 176fd17d02ac183af32a0e710ec32d25c9322021
@@ -63361,7 +62142,7 @@
Date: Wed Oct 30 17:27:24 2013 +0000
Bug 70971 - Signed/unsigned compiler warnings on windows
-
+
Patch from Emil Eklund.
src/hb-buffer-serialize.cc | 8 ++++----
@@ -63412,9 +62193,8 @@
Date: Mon Oct 28 19:26:02 2013 +0100
[otlayout] Optimize inplace
-
- See thread started by Jonathan with subject "an optimization for
- complex
+
+ See thread started by Jonathan with subject "an optimization for complex
fonts".
src/hb-ot-layout.cc | 6 +++---
@@ -63425,17 +62205,17 @@
Date: Mon Oct 28 00:20:59 2013 +0100
Revert "Zero marks by GDEF for Tibetan"
-
+
This reverts commit d5bd0590ae2fbc7b0dee86385a565aef00ffb835.
-
+
The reasoning behind that logic was flawed and made under
a misunderstanding of the original problem, and caused
regressions as reported by Jonathan Kew in thread titled
"tibetan marks" in Oct 2013. Apparently I have had fixed
the original problem with this commit:
-
+
7e08f1258da229dfaf7e1c4b5c41e5bb83906cb0
-
+
So, revert the faulty commit and everything seems to be in good
shape.
@@ -63455,7 +62235,7 @@
Date: Mon Oct 28 00:09:05 2013 +0100
Pass CPPFLAGS=-Werror to Travis-CI
-
+
We want default gcc / clang warnings to fail the CI build.
.travis.yml | 2 +-
@@ -63476,7 +62256,7 @@
Date: Sun Oct 27 23:36:35 2013 +0100
Work with old and new glib
-
+
Avoids "deprecated" warnings.
src/test-buffer-serialize.cc | 7 +++++--
@@ -63493,11 +62273,11 @@
Date: Sun Oct 27 23:24:50 2013 +0100
[indic] Adjust pref reordering logic
-
+
For Javanese (pref_len == 1) only reorder if it didn't ligate. That's
sensible, and what the spec says. For other Indic (pref_len > 1)
only reorder if ligated.
-
+
Doesn't change any test numbers.
src/hb-ot-shape-complex-indic.cc | 9 +++++++--
@@ -63508,13 +62288,12 @@
Date: Sun Oct 27 21:04:55 2013 +0100
Optimize fallback kerning
-
+
Patch from Jonathan Kew. "These changes seem to yield a small but
just-about-measurable improvement with old fonts that lack GPOS
kerning."
- src/hb-ot-shape-fallback.cc | 47
- ++++++++++++++++++++++++++++-----------------
+ src/hb-ot-shape-fallback.cc | 47 ++++++++++++++++++++++++++++-----------------
1 file changed, 29 insertions(+), 18 deletions(-)
commit 133eeba6a32769ec1a7520e7c8a0d2eb1ad986f8
@@ -63522,7 +62301,7 @@
Date: Sun Oct 27 00:24:59 2013 +0200
Minor
-
+
See:
https://github.com/prezi/harfbuzz-js/pull/1/files#r7032397
@@ -63534,7 +62313,7 @@
Date: Thu Oct 24 11:46:33 2013 +0200
[indic] Fix CM2, really
-
+
Followup from 6e613f3365bf4e9fd778758c53e7de00c64beca1.
src/hb-ot-shape-complex-indic-machine.rl | 2 +-
@@ -63555,8 +62334,7 @@
Refactor
- src/hb-ot-layout-gpos-table.hh | 120
- ++++++++++++++++++++++-------------------
+ src/hb-ot-layout-gpos-table.hh | 120 ++++++++++++++++++++++-------------------
src/hb-ot-layout.cc | 31 +++++------
src/hb-ot-shape-normalize.cc | 29 +++++-----
src/hb-ot-shape.cc | 82 ++++++++++++++++------------
@@ -63576,18 +62354,17 @@
Date: Fri Oct 18 18:07:11 2013 +0200
[indic] Improve positioning of post-base bells and whistles
-
- Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not
- provide
+
+ Bug 58714 - Kannada u+0cb0 u+200d u+0ccd u+0c95 u+0cbe does not provide
same results as Windows8
https://bugs.freedesktop.org/show_bug.cgi?id=58714
-
+
Test with U+0CB0,U+200D,U+0CCD,U+0C95,U+0CBF and tunga.ttf.
-
+
Improves some scripts. Improves Bengali too, but numbers
are up because we produce better results than Uniscribe for some
sequences now.
-
+
New numbers:
BENGALI: 353724 out of 354188 tests passed. 464 failed (0.131004%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
@@ -63595,8 +62372,7 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951190 out of 951913 tests passed. 723 failed (0.0759523%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed
- (0.0185056%)
+ MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed (0.0185056%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271662 out of 271847 tests passed. 185 failed (0.068053%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
@@ -63610,7 +62386,7 @@
Date: Fri Oct 18 16:44:54 2013 +0200
Zero marks by GDEF for Tibetan
-
+
See:
http://lists.freedesktop.org/archives/harfbuzz/2013-April/003101.html
@@ -63639,7 +62415,7 @@
Date: Fri Oct 18 16:08:53 2013 +0200
[otfallback] Don't shift down above-marks too much
-
+
This seems to generate much better, almost-perfect, positioning for
Arabic as well as Latin above marks.
@@ -63651,7 +62427,7 @@
Date: Fri Oct 18 15:57:36 2013 +0200
[otfallback] Never fallback-position a below-mark upwards
-
+
Test with WinXP times.ttf and U+05D9,U+05B5.
src/hb-ot-shape-fallback.cc | 6 ++++++
@@ -63671,12 +62447,11 @@
Date: Fri Oct 18 02:27:00 2013 +0200
[indic] Add Javanese support!
-
+
Seems to be working just fine!
src/hb-ot-shape-complex-indic-machine.rl | 14 ++++++------
- src/hb-ot-shape-complex-indic-private.hh | 37
- ++++++++++++++++----------------
+ src/hb-ot-shape-complex-indic-private.hh | 37 ++++++++++++++++----------------
src/hb-ot-shape-complex-indic.cc | 9 ++++++--
3 files changed, 34 insertions(+), 26 deletions(-)
@@ -63685,7 +62460,7 @@
Date: Fri Oct 18 11:17:42 2013 +0200
[ft] Round metrics instead of truncate
-
+
Lohit-Punjabi has a upem of 769! We were losing one unit in our
code, and FreeType is losing another one... Test with U+0A06.
Has an advance of 854 in the font. We were producing 852.
@@ -63699,9 +62474,9 @@
Date: Fri Oct 18 02:14:53 2013 +0200
[indic] Swith pref logic to use _hb_glyph_info_substituted()
-
+
See comments from caveat! Seems to work fine.
-
+
This is useful for Javanese which has an atomically encoded pre-base
reordering Ra which should only be reordered if it was substituted
by the pref feature.
@@ -63723,7 +62498,7 @@
Date: Fri Oct 18 01:11:05 2013 +0200
[otlayout] Add _hb_glyph_info_substituted()
-
+
Currently unused.
src/hb-ot-layout-private.hh | 6 ++++++
@@ -63734,7 +62509,7 @@
Date: Fri Oct 18 01:09:08 2013 +0200
[otlayout] Switch over from old is_a_ligature() to IS_LIGATED
-
+
Impact should be minimal and positive.
src/hb-ot-layout-gsubgpos-private.hh | 2 +-
@@ -63749,7 +62524,7 @@
Date: Fri Oct 18 01:05:58 2013 +0200
[otlayout] Add HB_OT_LAYOUT_GLYPH_PROPS_LIGATED
-
+
Currently unused.
src/hb-ot-layout-gsubgpos-private.hh | 15 ++++++++++-----
@@ -63761,7 +62536,7 @@
Date: Fri Oct 18 00:45:59 2013 +0200
[otlayout] Add HB_OT_LAYOUT_GLYPH_PROPS_SUBSTITUTED
-
+
Currently unused.
src/hb-ot-layout-gsubgpos-private.hh | 5 +++--
@@ -63777,8 +62552,7 @@
src/hb-ot-layout-gpos-table.hh | 16 +++----
src/hb-ot-layout-gsub-table.hh | 13 +++--
src/hb-ot-layout-gsubgpos-private.hh | 8 ++--
- src/hb-ot-layout-private.hh | 92
- ++++++++++++++++++++++++++++++++----
+ src/hb-ot-layout-private.hh | 92 ++++++++++++++++++++++++++++++++----
src/hb-ot-shape.cc | 8 ++--
5 files changed, 102 insertions(+), 35 deletions(-)
@@ -63787,7 +62561,7 @@
Date: Fri Oct 18 00:21:59 2013 +0200
[otlayout] Add _hb_glyph_info_set_glyph_props()
-
+
No functional change.
src/hb-ot-layout-gsub-table.hh | 2 +-
@@ -63814,8 +62588,7 @@
src/hb-ot-layout-gpos-table.hh | 18 +++++++-------
src/hb-ot-layout-gsub-table.hh | 2 +-
src/hb-ot-layout-gsubgpos-private.hh | 36 +++++++++++++--------------
- src/hb-ot-layout-private.hh | 48
- +++++++++++++++++++++---------------
+ src/hb-ot-layout-private.hh | 48 +++++++++++++++++++++---------------
src/hb-ot-shape-complex-indic.cc | 5 ++--
src/hb-ot-shape-complex-myanmar.cc | 2 +-
src/hb-ot-shape-fallback.cc | 8 +++---
@@ -63828,8 +62601,7 @@
[otlayout] More shuffling
- src/hb-ot-layout-private.hh | 252
- +++++++++++++++++++++++---------------------
+ src/hb-ot-layout-private.hh | 252 +++++++++++++++++++++++---------------------
1 file changed, 130 insertions(+), 122 deletions(-)
commit 469524692bd0a258b28e63294c984e677a9c2477
@@ -63897,8 +62669,7 @@
[indic] Towards supporting atomicly-encoded prebase-reorderings
- src/hb-ot-shape-complex-indic.cc | 65
- ++++++++++++++++++++++++----------------
+ src/hb-ot-shape-complex-indic.cc | 65 ++++++++++++++++++++++++----------------
1 file changed, 40 insertions(+), 25 deletions(-)
commit efed40b975110d78c9c505441e7e17a8c13e85c8
@@ -63925,7 +62696,7 @@
Date: Thu Oct 17 18:16:14 2013 +0200
Route Buginese through the SEA shaper
-
+
Both Indic and SEA seem to do it just fine, but SEA is much
simpler.
@@ -63937,9 +62708,8 @@
Date: Thu Oct 17 18:04:23 2013 +0200
[indic] Pass zero-context=false to would_substitute for newer scripts
-
- For scripts without an old/new spec distinction, use
- zero-context=false.
+
+ For scripts without an old/new spec distinction, use zero-context=false.
This changes behavior in Sinhala / Khmer, but doesn't seem to regress.
This will be useful and used in Javanese.
@@ -63960,7 +62730,7 @@
Date: Thu Oct 17 16:49:06 2013 +0200
[indic] Add BASE_POS_LAST_SINHALA
-
+
Previously we planted this into the mode used for Khmer. There's not
really much in common between the two, so separate again.
@@ -63972,7 +62742,7 @@
Date: Thu Oct 17 16:27:38 2013 +0200
[indic] Adjust Sinhala cluster merging under uniscribe
-
+
Similar to 190c8f2b60af0851bf692f653c1604cfbf0561a5 but for
Sinhala.
@@ -63985,8 +62755,7 @@
[otlayout] Minor
- src/hb-ot-layout-gsubgpos-private.hh | 62
- +++++++++++++++++++-----------------
+ src/hb-ot-layout-gsubgpos-private.hh | 62 +++++++++++++++++++-----------------
1 file changed, 33 insertions(+), 29 deletions(-)
commit 6cc136f7531a45e71ea08a7dc8a2187172cb813d
@@ -64003,7 +62772,7 @@
Date: Thu Oct 17 13:52:51 2013 +0200
[otlayout] Increase MAX_CONTEXT_LENGTH
-
+
It's cheap.
src/hb-ot-layout-common-private.hh | 2 +-
@@ -64014,7 +62783,7 @@
Date: Thu Oct 17 13:49:51 2013 +0200
[otlayout] Simplify ligate_input()
-
+
Shouldn't change behavior at all, but is faster / more robust.
src/hb-ot-layout-gsub-table.hh | 16 +++++++---------
@@ -64035,10 +62804,10 @@
Date: Thu Oct 17 13:05:05 2013 +0200
[indic] Apply calt,clig in the same stage as presentation features
-
+
Whic means these twp are applied per-syllable now. Apparently
in some Khmer fonts the clig interacts with presentation features.
-
+
Test case: U+1781,U+17D2,U+1789,U+17BB,U+17C6 with Mondulkiri-R.ttf
should produce one big ligature.
@@ -64050,7 +62819,7 @@
Date: Thu Oct 17 12:24:55 2013 +0200
[indic] Fix pref vs blwf interaction
-
+
If a glyph can be both blwf and pref, we were wrongly sorting it
in the post position instead of below position.
@@ -64062,7 +62831,7 @@
Date: Thu Oct 17 12:20:24 2013 +0200
[indic] Don't apply blwf before base under old-spec mode
-
+
Test case: U+09AC,U+09CD,U+09A6 with Lohit-Bengali 2.5.3.
src/hb-ot-shape-complex-indic.cc | 3 ++-
@@ -64073,7 +62842,7 @@
Date: Thu Oct 17 12:01:50 2013 +0200
[otlayout] Fix up recent Context matching change
-
+
Commit 6b65a76b40522a4f57a6fedcbdfc5a4d736f1d3c. "end" was becoming
negative. Was trigerred by Lohit-Kannada 2.5.3 and the sequence:
U+0CB0,U+200D,U+0CBE,U+0CB7,U+0CCD,U+0C9F,U+0CCD,U+0CB0,U+0C97,U+0CB3
@@ -64097,18 +62866,18 @@
Date: Wed Oct 16 19:06:29 2013 +0200
[indic] Misc harmless fixes!
-
+
First, we were abusing OT_VD instead of OT_A. Fix that
but moving OT_A in the grammar where it belongs (which
is different from what the spec says).
-
+
Also, only allow medial consonants after all other
consonants. This doesn't affect any current character.
-
+
Finally, fix Halant attachment in presence of medial
consonants. Again, this currently doesn't affect any
sequence.
-
+
I lied. There's Gurmukhi U+0A75 which is Consonant_Medial.
Uniscribe allows one of those in each of these positions:
before matras, after matras and before syllable modifiers,
@@ -64125,19 +62894,18 @@
Date: Wed Oct 16 13:42:38 2013 +0200
[arabic] Make ZWJ prevent ligatures instead of facilitating it
-
+
Unicode 6.2.0 Section 16.2 / Figure 16.3 says:
-
+
"For backward compatibility, between Arabic characters a ZWJ acts just
like the sequence <ZWJ, ZWNJ, ZWJ>, preventing a ligature from forming
instead of requesting the use of a ligature that would not normally be
used. As a result, there is no plain text mechanism for requesting the
use of a ligature in Arabic text."
-
+
As such, we flip internal zwj to zwnj flags for GSUB matching, which
means it will block ligation in all features, unless the font
- explicitly matches U+200D glyph. This doesn't affect joining
- behavior.
+ explicitly matches U+200D glyph. This doesn't affect joining behavior.
src/hb-ot-layout-private.hh | 6 ++++++
src/hb-ot-shape-complex-arabic.cc | 18 ++++++++++++++++++
@@ -64158,8 +62926,7 @@
[indic] More granular post-base cluster merging!
- src/hb-ot-shape-complex-indic.cc | 45
- ++++++++++++++++++++++++++++++++++------
+ src/hb-ot-shape-complex-indic.cc | 45 ++++++++++++++++++++++++++++++++++------
1 file changed, 39 insertions(+), 6 deletions(-)
commit 9cb59d460e80d769087045535a8d54ec9ed7985c
@@ -64167,7 +62934,7 @@
Date: Wed Oct 16 11:34:07 2013 +0200
[indic] Fix cluster merging of left matras
-
+
The merge_clusters there was totally broken.
src/hb-ot-shape-complex-indic.cc | 2 +-
@@ -64178,7 +62945,7 @@
Date: Wed Oct 16 11:33:18 2013 +0200
[indic] Adjust cluster merging under uniscribe mode for Tamil
-
+
Apparently Uniscribe Tamil shaper doesn't ship chubby clusters
for Tamil. Adjust to that.
@@ -64190,23 +62957,21 @@
Date: Wed Oct 16 11:14:15 2013 +0200
[indic] Allow up to two syllable modifiers
-
+
Bug 70509 - Candrabindu+Visarga doesn't work in Devanagari
https://bugs.freedesktop.org/show_bug.cgi?id=70509
-
+
We categorize both bindus and visarga as syllable-modifiers.
OT spec doesn't actually say what characters go in the syllable
modifier category, and allows one. We just allow up to two now.
-
+
Test case: U+0930,U+0941,U+0901,U+0903
-
+
Uniscribe currently doesn't support that and produces a
dotted circle.
- src/hb-ot-shape-complex-indic-machine.rl |
- 2 +-
- .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt |
- 1 +
+ src/hb-ot-shape-complex-indic-machine.rl | 2 +-
+ .../texts/in-tree/shaper-indic/indic/script-devanagari/misc/misc.txt | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
commit f5299eff5c0065d6329cd536c0ac339abea085b0
@@ -64214,7 +62979,7 @@
Date: Tue Oct 15 18:13:07 2013 +0200
[indic] Simplify reph logic
-
+
*Shouldn't* break anything.
src/hb-ot-shape-complex-indic.cc | 11 +++--------
@@ -64225,14 +62990,13 @@
Date: Tue Oct 15 18:08:05 2013 +0200
[indic] If Malayalam dot-reph formed a ligature, don't move it
-
+
Rachana-0.6 implements dot-reph by ligation, so we shouldn't move it.
Uniscribe doesn't either. Test case:
-
+
U+0D4E,U+0D1A,U+0D4D,U+0D1A,U+0D4D
- src/hb-ot-shape-complex-indic.cc | 23
- ++++++++++++++++------
+ src/hb-ot-shape-complex-indic.cc | 23 ++++++++++++++++------
.../indic/script-malayalam/misc/dot-reph.txt | 3 +++
2 files changed, 20 insertions(+), 6 deletions(-)
@@ -64251,8 +63015,7 @@
[tests] Remove Myanmar micro-font and test
- .../sha1sum/ceadd106a8205214fbe7337ef9de32a862b59762.ttf | Bin 3040 ->
- 0 bytes
+ .../sha1sum/ceadd106a8205214fbe7337ef9de32a862b59762.ttf | Bin 3040 -> 0 bytes
test/shaping/tests/context-matching.tests | 1 -
2 files changed, 1 deletion(-)
@@ -64260,16 +63023,13 @@
Author: Behdad Esfahbod <behdad at behdad.org>
Date: Tue Oct 15 15:26:44 2013 +0200
- [indic] Apply 'kern' for all scripts except for Khmer in Uniscribe
- mode
-
+ [indic] Apply 'kern' for all scripts except for Khmer in Uniscribe mode
+
Seems to better match Uniscribe.
-
- Note: NotoSansTelugu-Regular has kern feature, so this fixes most
- of the
+
+ Note: NotoSansTelugu-Regular has kern feature, so this fixes most of the
positioning failures there, except for the kern pairs blocked by a
- (non-)joiner, in which case we (correctly) kern, but Uniscribe
- doesn't.
+ (non-)joiner, in which case we (correctly) kern, but Uniscribe doesn't.
src/hb-ot-shape-complex-indic.cc | 11 +++++++++--
1 file changed, 9 insertions(+), 2 deletions(-)
@@ -64279,10 +63039,10 @@
Date: Tue Oct 15 13:47:27 2013 +0200
[indic] Don't apply presentation features across syllables
-
+
More like Uniscribe... We still allow user-defined features to
work across syllables, but not pres,blws,abs,psts,etc.
-
+
This "regressed" Sinhala numbers by 11. These are cases were
there's Consonant followed by Ra,Halant,ZWJ at the of text.
The Ra,Halant,ZWJ ends up forming reph, which is wrong...
@@ -64289,9 +63049,9 @@
But before we were also ligating that reph with the previous
consonant. That's even more wrong. That's also what Uniscribe
does.
-
+
Current numbers:
-
+
BENGALI: 353732 out of 354188 tests passed. 456 failed (0.128745%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
@@ -64298,15 +63058,13 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed
- (0.0185056%)
+ MALAYALAM: 1048140 out of 1048334 tests passed. 194 failed (0.0185056%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271655 out of 271847 tests passed. 192 failed (0.070628%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
TELUGU: 970555 out of 970573 tests passed. 18 failed (0.00185457%)
- src/hb-ot-shape-complex-indic.cc | 21
- +++++++++++++++++----
+ src/hb-ot-shape-complex-indic.cc | 21 +++++++++++++++++----
.../shaper-indic/indic/script-sinhala/misc/misc.txt | 1 +
2 files changed, 18 insertions(+), 4 deletions(-)
@@ -64315,14 +63073,13 @@
Date: Tue Oct 15 11:21:01 2013 +0200
[indic] Handle Avagraha
-
+
It can come either at the end(ish!) of the syllable, or independently.
When independent, it accepts a few bits and pieces.
src/hb-ot-shape-complex-indic-machine.rl | 5 ++++-
src/hb-ot-shape-complex-indic-private.hh | 5 +++--
- src/hb-ot-shape-complex-indic.cc | 14
- +++++++++++++-
+ src/hb-ot-shape-complex-indic.cc | 14 +++++++++++++-
.../shaper-indic/indic/script-devanagari/misc/misc.txt | 1 +
.../in-tree/shaper-indic/indic/script-telugu/misc/misc.txt | 1 +
5 files changed, 22 insertions(+), 4 deletions(-)
@@ -64341,13 +63098,13 @@
Date: Tue Oct 15 12:15:49 2013 +0200
[indic] Some scripts like blwf applied to pre-base characters
-
+
...while some don't!
-
+
Improved Bengali, Devanagari, Gurmukhi, Malayalam.
-
+
Updated numbers:
-
+
BENGALI: 353732 out of 354188 tests passed. 456 failed (0.128745%)
DEVANAGARI: 707307 out of 707394 tests passed. 87 failed (0.0122987%)
GUJARATI: 366349 out of 366457 tests passed. 108 failed (0.0294714%)
@@ -64354,8 +63111,7 @@
GURMUKHI: 60732 out of 60747 tests passed. 15 failed (0.0246926%)
KANNADA: 951030 out of 951913 tests passed. 883 failed (0.0927606%)
KHMER: 299070 out of 299124 tests passed. 54 failed (0.0180527%)
- MALAYALAM: 1048134 out of 1048334 tests passed. 200 failed
- (0.0190779%)
+ MALAYALAM: 1048134 out of 1048334 tests passed. 200 failed (0.0190779%)
ORIYA: 42320 out of 42329 tests passed. 9 failed (0.021262%)
SINHALA: 271666 out of 271847 tests passed. 181 failed (0.0665816%)
TAMIL: 1091753 out of 1091754 tests passed. 1 failed (9.15957e-05%)
@@ -64378,13 +63134,13 @@
Date: Mon Oct 14 18:51:39 2013 +0200
[otlayout] Fix (Chain)Context recursion!
-
+
Previously we only supported recursive sublookups with
ascending indices. We were also not correctly handling
non-1-to-1 recursed lookups.
-
+
Fix all that!
-
+
Fixes the three tests in test/shaping/tests/context-matching.tests,
which were derived from NotoSansBengali and NotoSansDevanagari
among others.
@@ -64393,8 +63149,7 @@
src/hb-buffer.cc | 46 ++++++++++
src/hb-ot-layout-common-private.hh | 1 +
src/hb-ot-layout-gsub-table.hh | 1 +
- src/hb-ot-layout-gsubgpos-private.hh | 157
- +++++++++++++++++------------------
+ src/hb-ot-layout-gsubgpos-private.hh | 157 +++++++++++++++++------------------
5 files changed, 127 insertions(+), 82 deletions(-)
commit 841e20d083aec8d814cd8d90aa6ab60127c0d1f2
@@ -64402,13 +63157,13 @@
Date: Mon Oct 14 18:47:51 2013 +0200
Add test suite for shaping results
-
+
The new test suite runs tests included under
hb/test/shaping/tests/*.tests, which themselves reference
font files stored by sha1sum under hb/test/shaping/fonts/sha1sum.
The fonts are produced using a subsetter to only include glyphs
needed to run the test.
-
+
Four initial tests are added for (Chain)Context matching,
of which three currently fail.
@@ -64417,8 +63172,7 @@
.../ceadd106a8205214fbe7337ef9de32a862b59762.ttf | Bin 0 -> 3040 bytes
.../d629e7fedc0b350222d7987345fe61613fa3929a.ttf | Bin 0 -> 1768 bytes
.../f499fbc23865022234775c43503bba2e63978fe1.ttf | Bin 0 -> 3564 bytes
- test/shaping/run-tests.sh | 34
- +++++++++++++++++++++
+ test/shaping/run-tests.sh | 34 +++++++++++++++++++++
test/shaping/tests/MANIFEST | 1 +
test/shaping/tests/context-matching.tests | 4 +++
8 files changed, 48 insertions(+), 1 deletion(-)
@@ -64446,7 +63200,7 @@
Date: Thu Oct 10 20:04:42 2013 +0200
Don't use g_mapped_file_unref()
-
+
Was introduced in glib 2.22.
src/test-buffer-serialize.cc | 2 +-
@@ -64471,7 +63225,7 @@
Date: Thu Oct 3 14:54:50 2013 -0400
[OTLayout] Protect against out-of-range lookup indices
-
+
Filter them out when compiling map.
src/hb-ot-layout.cc | 17 +++++++++++++++++
@@ -64496,8 +63250,7 @@
- use common src files for both static and shared libs
- remove empty LOCAL_SHARED_LIBRARIES
- Android.mk | 58
- +++++++++++++++++-----------------------------------------
+ Android.mk | 58 +++++++++++++++++-----------------------------------------
1 file changed, 17 insertions(+), 41 deletions(-)
commit 622bc3d829cab84c3a4148b88f2c91fee491ef39
@@ -64506,7 +63259,7 @@
Date: Sun Sep 29 13:31:58 2013 -0700
Merge pull request #4 from amarullz/master
-
+
Add build static library on Android.mk
commit 3d2c4f0c2ff8fab4262988aad65b170e5b479b20
@@ -64514,7 +63267,7 @@
Date: Fri Sep 27 17:06:29 2013 -0400
Fix hiding of default_ignorables if font doesn't have space glyph
-
+
Based on patch from Jonathan Kew. See discussion on the list.
src/hb-ot-shape.cc | 40 ++++++++++++++++++++++++++++++----------
@@ -64525,7 +63278,7 @@
Date: Fri Sep 27 19:04:32 2013 +0700
Add build static library on Android.mk
-
+
Use UCDN instead ICU
HAVE Freetype
@@ -64537,7 +63290,7 @@
Date: Thu Sep 26 18:26:43 2013 -0400
[util] Don't use g_array_unref()
-
+
Was introduced in glib 2.22.
util/view-cairo.hh | 2 +-
@@ -64548,7 +63301,7 @@
Date: Thu Sep 26 16:48:42 2013 -0400
Bug 68990 - test-common fails on i686-linux
-
+
Fix use-after-end-of-scope.
src/hb-common.cc | 6 ++++--
@@ -64600,9 +63353,9 @@
Date: Fri Sep 13 20:23:51 2013 -0400
[introspection] Annotate Unicode / font callbacks
-
+
@@ Diff output truncated at 1234567 characters. @@
More information about the tex-live-commits
mailing list