texlive[49855] Master: consistently use $0 on tldie msgs; precede

commits+karl at tug.org commits+karl at tug.org
Mon Jan 28 23:47:02 CET 2019


Revision: 49855
          http://tug.org/svn/texlive?view=revision&revision=49855
Author:   karl
Date:     2019-01-28 23:47:02 +0100 (Mon, 28 Jan 2019)
Log Message:
-----------
consistently use $0 on tldie msgs; precede with newline

Modified Paths:
--------------
    trunk/Master/install-tl
    trunk/Master/tlpkg/TeXLive/TLUtils.pm

Modified: trunk/Master/install-tl
===================================================================
--- trunk/Master/install-tl	2019-01-28 22:35:31 UTC (rev 49854)
+++ trunk/Master/install-tl	2019-01-28 22:47:02 UTC (rev 49855)
@@ -1,7 +1,6 @@
 #!/usr/bin/env perl
 # $Id$
-# 
-# Copyright 2007-2018
+# Copyright 2007-2019
 # Reinhard Kotucha, Norbert Preining, Karl Berry, Siep Kroonenberg.
 # This file is licensed under the GNU General Public License version 2
 # or any later version.
@@ -471,7 +470,8 @@
       log("Trying to verify cryptographic signatures!\n")
     } else {
       if ($opt_verify_downloads) {
-        tldie("No gpg found, verification explicitly requested on command line, quitting.\n");
+        tldie("$0: No gpg found, but verification explicitly requested "
+              . "on command line, so quitting.\n");
       } else {
         # implicitly requested, just 
         debug("Couldn't detect gpg so will proceed without verification!\n");
@@ -546,7 +546,8 @@
   chomp( my $un = `uname -r`);
   if ($un =~ m/^(\d+)\.(\d+)\./) {
     if ($1 < 2 && $2 < 7) {
-      tldie("\nSorry, the TL binaries require at least cygwin 1.7.\n");
+      tldie("$0: Sorry, the TL binaries require at least cygwin 1.7, "
+            . "not $1.$2\n");
     }
   }
 }
@@ -833,8 +834,8 @@
       info("Platform overridden, binaries taken from $opt_custom_bin\n"
            . "and will be installed into .../bin/custom.\n");
     } else {
-      tldie("$opt_custom_bin: Argument to -custom-bin must be a directory "
-            . "with TeX Live binaries.\n");
+      tldie("$0: -custom-bin argument must be a directory "
+            . "with TeX Live binaries, not like: $opt_custom_bin\n");
     }
   }
   if ($media eq "local_uncompressed") {

Modified: trunk/Master/tlpkg/TeXLive/TLUtils.pm
===================================================================
--- trunk/Master/tlpkg/TeXLive/TLUtils.pm	2019-01-28 22:35:31 UTC (rev 49854)
+++ trunk/Master/tlpkg/TeXLive/TLUtils.pm	2019-01-28 22:47:02 UTC (rev 49855)
@@ -1,6 +1,6 @@
 # $Id$
 # TeXLive::TLUtils.pm - the inevitable utilities for TeX Live.
-# Copyright 2007-2018 Norbert Preining, Reinhard Kotucha
+# Copyright 2007-2019 Norbert Preining, Reinhard Kotucha
 # This file is licensed under the GNU General Public License version 2
 # or any later version.
 
@@ -3476,12 +3476,13 @@
 
 =item C<tldie ($str1, $str2, ...)>
 
-Uses C<tlwarn> to issue a warning, then exits with exit code 1.
+Uses C<tlwarn> to issue a warning for @_ preceded by a newline, then
+exits with exit code 1.
 
 =cut
 
 sub tldie {
-  tlwarn(@_);
+  tlwarn("\n", @_);
   if ($::gui_mode) {
     Tk::exit(1);
   } else {



More information about the tex-live-commits mailing list