[tex-k] Patch for -Wall

Martin Schröder martin at oneiros.de
Tue Jan 3 18:59:20 CET 2006


Hi,
compiling pdfTeX with -Wall is an interesting experience. :-{

gcc complains thus:
pdfetexextra.c: In function `ipcpage':
pdfetexextra.c:545: warning: unused variable `i'
pdfetexextra.c: In function `readtcxfile':
pdfetexextra.c:640: warning: suggest parentheses around assignment used as truth value
pdfetexextra.c: In function `gettexstring':
pdfetexextra.c:1677: warning: unused variable `i'
pdfetexextra.c: In function `makesrcspecial':
pdfetexextra.c:1720: warning: unused variable `len'
pdfetexextra.c: At top level:
pdfetexextra.c:1616: warning: `checkpoolpointer' defined but not used

the check in readtcxfile (the warning in line 640 of texmfmp.c)
looks wrong to me:
---------------
  if (translate_filename) {
    string line;
    unsigned line_count = 0;
    FILE *translate_file = xfopen (translate_filename, FOPEN_R_MODE);
    while (line = read_line (translate_file)) {
---------------
Shouldn't that be 
    while (strcmp (line, read_line (translate_file))) {
?

Best
    Martin
-- 
                    http://www.tm.oneiros.de



More information about the tex-k mailing list