[latex3-commits] [latex3/latex3] main: Deprecate \seq_(g)set_map_x:NNn (69b7c6fd0)

[github at latex-project.org]

Repository : https://github.com/latex3/latex3
On branch  : main
Link       : https://github.com/latex3/latex3/commit/69b7c6fd06d692d6674ccf44ce8ed2706508a4f1

>---------------------------------------------------------------

commit 69b7c6fd06d692d6674ccf44ce8ed2706508a4f1
Author: Joseph Wright <joseph.wright at morningstar2.co.uk>
Date:   Thu Oct 26 21:23:11 2023 +0100

    Deprecate \seq_(g)set_map_x:NNn


>---------------------------------------------------------------

69b7c6fd06d692d6674ccf44ce8ed2706508a4f1
 l3kernel/CHANGELOG.md           |  4 ++++
 l3kernel/doc/l3obsolete.txt     |  2 ++
 l3kernel/l3deprecation.dtx      |  9 +++++++++
 l3kernel/l3regex.dtx            |  2 +-
 l3kernel/l3seq.dtx              | 14 +++++++-------
 l3kernel/testfiles/m3seq004.lvt |  2 +-
 6 files changed, 24 insertions(+), 9 deletions(-)

diff --git a/l3kernel/CHANGELOG.md b/l3kernel/CHANGELOG.md
index f4cb775a7..2aa26d6eb 100644
--- a/l3kernel/CHANGELOG.md
+++ b/l3kernel/CHANGELOG.md
@@ -8,6 +8,7 @@ this project uses date-based 'snapshot' version identifiers.
 ## [Unreleased]
 
 ### Added
+- `\seq_set_map_e:NNn`
 - Documentation for `\ExplLoaderFileDate` in `expl3.pdf`
 
 ### Changed
@@ -15,6 +16,9 @@ this project uses date-based 'snapshot' version identifiers.
 - Refine action of `\text_titlecase_first:n(n)` to be focussed strictly on
   first (relevant) codepoint in the input
 
+### Deprecated
+- `\seq_(g)set_map_x:NNn` in favor of `e`-type naming
+
 ### Fixed
 - `\fp_clear_variable:n` should act locally (issue \#1298)
 - `\fp_clear_function:n` should act locally and correctly
diff --git a/l3kernel/doc/l3obsolete.txt b/l3kernel/doc/l3obsolete.txt
index 7b9c808e5..078f8bf66 100644
--- a/l3kernel/doc/l3obsolete.txt
+++ b/l3kernel/doc/l3obsolete.txt
@@ -55,6 +55,8 @@ Function                            Date deprecated
 \str_upper_case:n                        2020-01-03
 \seq_indexed_map_inline:Nn               2020-06-18
 \seq_indexed_map_function:NN             2020-06-18
+\seq_gset_map_x:NNn                      2023-10-26
+\seq_set_map_x:NNn                       2023-10-26
 \sys_load_deprecation:                   2021-01-11
 \text_titlecase:n                        2023-07-08
 \text_titlecase:nn                       2023-07-08
diff --git a/l3kernel/l3deprecation.dtx b/l3kernel/l3deprecation.dtx
index 98d8df40e..3663f1291 100644
--- a/l3kernel/l3deprecation.dtx
+++ b/l3kernel/l3deprecation.dtx
@@ -536,6 +536,15 @@
 %    \end{macrocode}
 % \end{macro}
 %
+% \begin{macro}{\seq_set_map_x:NNn, \seq_gset_map_x:NNn}
+%    \begin{macrocode}
+\__kernel_patch_deprecation:nnNNpn { 2023-10-26 } { \seq_set_map_e:NNn }
+\cs_gset_protected:Npn \seq_set_map_x:NNn { \seq_set_map_e:NNn }
+\__kernel_patch_deprecation:nnNNpn { 2023-10-26 } { \seq_gset_map_e:NNn }
+\cs_gset_protected:Npn \seq_gset_map_x:NNn { \seq_gset_map_e:NNn }
+%    \end{macrocode}
+% \end{macro}
+%
 % \subsection{Deprecated \pkg{l3sys} functions}
 %
 %    \begin{macrocode}
diff --git a/l3kernel/l3regex.dtx b/l3kernel/l3regex.dtx
index cd7bd9f33..52cc53843 100644
--- a/l3kernel/l3regex.dtx
+++ b/l3kernel/l3regex.dtx
@@ -4220,7 +4220,7 @@
 \cs_new_protected:Npn \@@_show_item_exact_cs:n #1
   {
     \seq_set_split:Nnn \l_@@_internal_seq { \scan_stop: } {#1}
-    \seq_set_map_x:NNn \l_@@_internal_seq
+    \seq_set_map_e:NNn \l_@@_internal_seq
       \l_@@_internal_seq { \iow_char:N\\##1 }
     \@@_show_one:n
       { control~sequence~ \seq_use:Nn \l_@@_internal_seq { ~or~ } }
diff --git a/l3kernel/l3seq.dtx b/l3kernel/l3seq.dtx
index 56662dc62..8be8f3d56 100644
--- a/l3kernel/l3seq.dtx
+++ b/l3kernel/l3seq.dtx
@@ -2389,17 +2389,17 @@
 % \end{macro}
 % \end{macro}
 %
-% \begin{macro}{\seq_set_map_x:NNn, \seq_gset_map_x:NNn}
-% \begin{macro}{\@@_set_map_x:NNNn}
+% \begin{macro}{\seq_set_map_e:NNn, \seq_gset_map_e:NNn}
+% \begin{macro}{\@@_set_map_e:NNNn}
 %   Very similar to \cs{seq_set_filter:NNn}. We could actually
 %   merge the two within a single function, but it would have weird
 %   semantics.
 %    \begin{macrocode}
-\cs_new_protected:Npn \seq_set_map_x:NNn
-  { \@@_set_map_x:NNNn \__kernel_tl_set:Ne }
-\cs_new_protected:Npn \seq_gset_map_x:NNn
-  { \@@_set_map_x:NNNn \__kernel_tl_gset:Ne }
-\cs_new_protected:Npn \@@_set_map_x:NNNn #1#2#3#4
+\cs_new_protected:Npn \seq_set_map_e:NNn
+  { \@@_set_map_e:NNNn \__kernel_tl_set:Ne }
+\cs_new_protected:Npn \seq_gset_map_e:NNn
+  { \@@_set_map_e:NNNn \__kernel_tl_gset:Ne }
+\cs_new_protected:Npn \@@_set_map_e:NNNn #1#2#3#4
   {
     \@@_push_item_def:n { \exp_not:N \@@_item:n {#4} }
     #1 #2 { #3 }
diff --git a/l3kernel/testfiles/m3seq004.lvt b/l3kernel/testfiles/m3seq004.lvt
index 80ce12e88..fb0e19950 100644
--- a/l3kernel/testfiles/m3seq004.lvt
+++ b/l3kernel/testfiles/m3seq004.lvt
@@ -89,7 +89,7 @@
           { \tl_if_head_eq_meaning_p:nN {#1} a }
           { \int_compare_p:n { #1 < 2 } }
     }
-  \seq_set_map_x:NNn \l_my_seq \l_my_seq { \int_eval:n { #1 * #1 } }
+  \seq_set_map_e:NNn \l_my_seq \l_my_seq { \int_eval:n { #1 * #1 } }
   \seq_log:N \l_my_seq
   \seq_set_map:NNn \l_my_seq \l_my_seq { \exp_not:c {#1} }
   \seq_log:N \l_my_seq