[tldistro] kpathsea/c-auto.h should be installed

Ken Brown kbrow1i at gmail.com
Sat Mar 18 21:50:41 CET 2017


On 3/14/2017 6:19 PM, Karl Berry wrote:
>     +kpseinclude_HEADERS = config.h c-auto.h $(direct_headers) 
> 
> Ok, installed that change. Installing these configure-generated headers
> seems strange to me, but whatever's needed ... --thanks, k.

Hi Karl,

I've been reading up on Automake, and I realize now that c-auto.h should be in nodist_kpseinclude_HEADERS rather than kpseinclude_HEADERS, since it shouldn't be part of a source tarball.

Also, I see that it's currently in nodist_kpselib_HEADERS, which makes no sense to me.  Why should a header be installed in a lib directory, where it will never be found by any #include?  Moreover, it's the only file installed in kpselibdir, so the latter is not needed.

I think the following patch fixes things up:

--- Build/source/texk/kpathsea/Makefile.am      (revision 43535)
+++ Build/source/texk/kpathsea/Makefile.am      (working copy)
@@ -113,16 +113,12 @@
 kpseincludedir = ${includedir}/kpathsea

 nodist_kpseinclude_HEADERS = \
+       c-auto.h \
        kpathsea.h \
        paths.h

-kpseinclude_HEADERS = config.h c-auto.h $(direct_headers) $(indirect_headers)
+kpseinclude_HEADERS = config.h $(direct_headers) $(indirect_headers)

-kpselibdir = ${libdir}/kpathsea
-
-nodist_kpselib_HEADERS = \
-       c-auto.h
-
 # Headers included directly into kpathsea.h
 #
 direct_headers = \


Sorry for the confusion, and I hope I've got it right this time.

Ken


More information about the tldistro mailing list