<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi,<br>
<br>
On 2011-11-07 22:21, Paul A Norman wrote:
<blockquote
cite="mid:CAG2d78CNcpbsir2WDr4GoS5CfZwbx=oGykJYSshAh-UOg2-7eQ@mail.gmail.com"
type="cite">And now I show my complete ignorance of C++ - in
line 532
<div><br>
</div>
<div><span style="font-family: monospace; line-height: 16px;
white-space: pre; background-color: rgb(255, 255, 255);
font-size: medium; ">openUrl(QUrl(QString(</span><span
class="stx-string" style="color: rgb(0, 136, 0); font-family:
monospace; line-height: 16px; white-space: pre;
background-color: rgb(255, 255, 255); font-size: medium; ">"<span
class="GEQUXKXGK" id="m_c0_0" style="background-image:
initial; background-attachment: initial; background-origin:
initial; background-clip: initial; background-color:
rgb(136, 255, 184); font-weight: bold; background-position:
initial initial; background-repeat: initial initial; ">mailto:</span>%1?&body=%3"</span><span
style="font-family: monospace; line-height: 16px; white-space:
pre; background-color: rgb(255, 255, 255); font-size: medium;
">).arg(address).arg(body)));</span>
</div>
<div><span style="font-family: monospace; line-height: 16px;
white-space: pre; background-color: rgb(255, 255, 255);
font-size: medium; "><br>
</span></div>
<div><span style="background-color: rgb(255, 255, 255); "><font
face="monospace" size="3"><span style="line-height: 16px;
white-space: pre;">There are only two arguments? but the
QString substitutions are looking for %1 and %3
intuitively I was expecting %1 and %2 where would %3 come
from? - but I have already expressed my ignorance so let
me learn ;)</span></font></span></div>
</blockquote>
<br>
Wow - for someone claiming not to know C++ (did you, actually?)
you're incredibly apt!<br>
Indeed, this should read "%2", I apparently overlooked that when
removing the subject line, and since it worked (you already
established why in your other mail) I didn't see it in quick
testing.<br>
<br>
Anyway, this was changed in r949. In addition, I added an empty
"subject" (which shouldn't hurt), improved the body text (to avoid
directly rubbing "Instructions" in everyone's face), and replaced
"\n" by "\r\n" on Windows (maybe that helps with the missing line
breaks I've seen a couple of times around here).<br>
<br>
Cheers,<br>
Stefan<br>
</body>
</html>