<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
Hi,<br>
<br>
this is looking awesome, thanks! If you agree, I'd like to write
something up (well, actually, copy from you ;)) for the Tw wiki.<br>
<br>
WARNING (for non-developers): The rest of this message is very
technical.<br>
<br>
<br>
A few questions:<br>
1) is it possible to use the upstream svn repo instead of cloning a
git version of it? That would have the benefit that people don't
have to rely/wait on you pulling changes, as long as nothing
dramatic changes.<br>
<br>
2) Can you add support for stable releases? They are in /tags in the
svn repo (if the answer to 1) is yes, this is trivial)<br>
<br>
3) I noticed you mention homebrew; can your cmake system be
incorporated into homebrew?<br>
<br>
On 2011-05-12 07:23, Charlie Sharpsteen wrote:
<blockquote
cite="mid:BANLkTimSw_r+h6SJ7M3dXAk_b4xbdD2cwQ@mail.gmail.com"
type="cite">If someone wants to play with the build system, the
code is available at:
<div><br>
</div>
<div> <a moz-do-not-send="true"
href="https://github.com/downloads/Sharpie/TeXworks">https://github.com/downloads/Sharpie/TeXworks</a></div>
</blockquote>
<br>
This didn't work for me.<br>
<br>
<blockquote
cite="mid:BANLkTimSw_r+h6SJ7M3dXAk_b4xbdD2cwQ@mail.gmail.com"
type="cite">
<div>Direct git access:</div>
<div><br>
</div>
<div> git://<a moz-do-not-send="true"
href="http://github.com/Sharpie/TeXworks.git">github.com/Sharpie/TeXworks.git</a></div>
<div><br>
</div>
<div>If anyone has any improvements/corrections, feel free to fork
the repo and send a pull request.</div>
</blockquote>
<br>
Done. I wanted to send separate pull requests for different sets of
changes, but didn't succeed (is it possible at all? I have
practically no experience with git/github).<br>
<br>
<blockquote
cite="mid:BANLkTimSw_r+h6SJ7M3dXAk_b4xbdD2cwQ@mail.gmail.com"
type="cite">
<div>If the core developers are interested in bringing this new
build system into the SVN repository, the following patch should
apply cleanly against revision 813:</div>
<div><br>
</div>
<div> <a moz-do-not-send="true"
href="https://github.com/Sharpie/TeXworks/compare/texworks-svn...cmake-only">https://github.com/Sharpie/TeXworks/compare/texworks-svn...cmake-only</a></div>
<div><br>
</div>
<div>There is only one teenie-tiny change to src/TWApp.h to guard
against D-Bus that affects the existing code code.</div>
</blockquote>
<br>
Bringing the whole CMake system in will need some thinking and
discussion, so please be patient.<br>
Regarding the patch: it seems trivial, but the way I read the Qt
docs, Q_WS_X11 and Q_WS_MAC should be mutually exclusive. See, e.g.,
main.cpp, which also uses dbus, but only guards against Q_WS_X11 -
why doesn't that cause problems for you? The only thing I can think
of is that your workaround "ADD_DEFINITIONS( -DQ_WS_MAC )" is not
really resolving the issue (note that there is TwApp.h, but no
main.h, to be processed by moc). I could imagine that QT4_WRAP_CPP
actually mistakes the system and defines Q_WS_X11 _instead of_
DQ_WS_MAC. Can this be overridden by "REMOVE_DEFINITIONS( -DQ_WS_X11
)"?<br>
All in all, I'd rather have a proper solution if possible rather
than hacking the svn code...<br>
<br>
<blockquote
cite="mid:BANLkTimSw_r+h6SJ7M3dXAk_b4xbdD2cwQ@mail.gmail.com"
type="cite">
<div>Hope this is useful to someone!</div>
</blockquote>
<br>
I think it will be tremendously useful! Thanks very much again!<br>
<br>
-Stefan<br>
</body>
</html>