texlive[45970] KPSE_COMPILER_VISIBILITY: do not restore from

[commits+karl at tug.org]

Revision: 45970
          http://tug.org/svn/texlive?view=revision&revision=45970
Author:   karl
Date:     2017-12-03 00:50:45 +0100 (Sun, 03 Dec 2017)
Log Message:
-----------
KPSE_COMPILER_VISIBILITY: do not restore from kpse_save_flags unless it was set

Modified Paths:
--------------
    trunk/Build/source/m4/ChangeLog
    trunk/Build/source/m4/kpse-visibility.m4

Property Changed:
----------------
    trunk/Build/source/m4/kpse-visibility.m4

Modified: trunk/Build/source/m4/ChangeLog
===================================================================
--- trunk/Build/source/m4/ChangeLog	2017-12-02 22:24:17 UTC (rev 45969)
+++ trunk/Build/source/m4/ChangeLog	2017-12-02 23:50:45 UTC (rev 45970)
@@ -1,3 +1,11 @@
+2017-12-02  Karl Berry  <karl at freefriends.org>
+
+	* kpse-visibility.m4 (KPSE_COMPILER_VISIBILITY): write debug line.
+	(_KPSE_VISIBILITY_FLAGS): only restore from kpse_save_flags
+	if we set it, i.e., if not using the cached value. (Otherwise,
+	e.g., in libpng, we can end up overriding the user-set CFLAGS with
+	the empty string.)
+
 2017-11-02  Karl Berry  <karl at freefriends.org>
 
 	* kpse-setup.m4 (_KPSE_RECURSE): revert previous change,
@@ -5,7 +13,7 @@
 	and (2) for 2018, more packages (icu, poppler, ...) are going to
 	require C++11, so we can't hack around it again. So not worth
 	spending more time refining.
-	Also, add debugging line writing to >&AS_MESSAGE_LOG_FD (config.log).
+	Also, write debug line to >&AS_MESSAGE_LOG_FD (config.log).
 	reautoconf.
 
 2017-02-17  Karl Berry  <karl at freefriends.org>

Modified: trunk/Build/source/m4/kpse-visibility.m4
===================================================================
--- trunk/Build/source/m4/kpse-visibility.m4	2017-12-02 22:24:17 UTC (rev 45969)
+++ trunk/Build/source/m4/kpse-visibility.m4	2017-12-02 23:50:45 UTC (rev 45970)
@@ -1,5 +1,7 @@
+# $Id$
 # Public macros for the TeX Live (TL) tree.
-# Copyright (C) 2013, 2014 Peter Breitenlohner <tex-live at tug.org>
+# Copyright 2017 Karl Berry <tex-live at tug.org>
+# Copyright 2013-2014 Peter Breitenlohner <tex-live at tug.org>
 #
 # This file is free software; the copyright holder
 # gives unlimited permission to copy and/or distribute it,
@@ -13,6 +15,7 @@
 # them a Makefile.am must use them, e.g., in AM_CFLAGS or AM_CXXFLAGS.
 AC_DEFUN([KPSE_COMPILER_VISIBILITY],
 [dnl arrange that AC_PROG_CC uses _KPSE_VISIBILITY_CFLAGS etc.
+echo 'dbg:[_KPSE_COMPILER_VISIBILITY] called.' >&AS_MESSAGE_LOG_FD
 AC_PROVIDE_IFELSE([AC_PROG_CC],
                   [_KPSE_VISIBILITY_CFLAGS],
                   [m4_define([AC_PROG_CC],
@@ -64,11 +67,10 @@
   AS_TR_CPP($2)="$kpse_save_flags -Werror $kpse_flag"
   AC_COMPILE_IFELSE([], [kpse_cv_visibility_$2=$kpse_flag; break])
 done
+AS_TR_CPP($2)=$kpse_save_flags
 AC_LANG_POP([$1])
 ])
-AS_TR_CPP($2)=$kpse_save_flags
 AS_CASE([$kpse_cv_visibility_$2],
         [unknown], [],
         [AC_SUBST([VISIBILITY_]AS_TR_CPP($2), [$kpse_cv_visibility_$2])])
 ]) # _KPSE_VISIBILITY_FLAGS
-


Property changes on: trunk/Build/source/m4/kpse-visibility.m4
___________________________________________________________________
Added: svn:keywords
## -0,0 +1 ##
+Date Author Id
\ No newline at end of property