[latex3-commits] [git/l3build] manifest: manifest: extractfiledesc -> skipfiledescription (0da89dc)

[Will Robertson]

Repository : https://github.com/latex3/l3build
On branch  : manifest
Link       : https://github.com/latex3/l3build/commit/0da89dcb2bd0a0c61bd01ae4b04b3e1d89fea66d

>---------------------------------------------------------------

commit 0da89dcb2bd0a0c61bd01ae4b04b3e1d89fea66d
Author: Will Robertson <wspr81 at gmail.com>
Date:   Tue Dec 26 11:05:20 2017 +0800

    manifest: extractfiledesc -> skipfiledescription
    
    still not sure if this naming is best...


>---------------------------------------------------------------

0da89dcb2bd0a0c61bd01ae4b04b3e1d89fea66d
 l3build-manifest-setup.lua |    6 +++---
 l3build-manifest.lua       |   10 +++++-----
 l3build.dtx                |    2 +-
 3 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/l3build-manifest-setup.lua b/l3build-manifest-setup.lua
index fbdfdff..8965a42 100644
--- a/l3build-manifest-setup.lua
+++ b/l3build-manifest-setup.lua
@@ -68,7 +68,7 @@ documentation files listed above.
     {
        name    = "Text files",
        files   = {textfiles},
-       extractfiledesc = false,
+       skipfiledescription = true,
     },
     {
        name    = "Demo files",
@@ -83,7 +83,7 @@ documentation files listed above.
        files   = {installfiles},
        exclude = {excludefiles,sourcefiles},
        dir     = unpackdir,
-       extractfiledesc = false,
+       skipfiledescription = true,
     },
     {
        name    = "Typeset documents",
@@ -113,7 +113,7 @@ different engines (pdfTeX, XeTeX, LuaTeX, etc.).
        ]],
        files   = {"*"..lvtext,"*"..lveext,"*"..tlgext},
        dir     = testfiledir,
-       extractfiledesc = false,
+       skipfiledescription = true,
     },
   }
   return groups
diff --git a/l3build-manifest.lua b/l3build-manifest.lua
index 72cd807..f3047ac 100644
--- a/l3build-manifest.lua
+++ b/l3build-manifest.lua
@@ -91,10 +91,10 @@ manifest_build_init = function(entry)
 
   -- currently these aren't customisable; I guess they could/should be?
   local manifest_group_defaults = {
-    extractfiledesc  = true           ,
-    rename           = false          ,
-    dir              = maindir        ,
-    exclude          = {excludefiles} ,
+    skipfiledescription  = false          ,
+    rename               = false          ,
+    dir                  = maindir        ,
+    exclude              = {excludefiles} ,
   }
 
   -- internal data added to each group in the table that needs to be initialised
@@ -149,7 +149,7 @@ manifest_build_file = function(entry,this_file)
       
     end
 
-    if not(entry.rename) and entry.extractfiledesc then
+    if not(entry.rename) and not(entry.skipfiledescription) then
     
       local ff = assert(io.open(entry.dir .. "/" .. this_file, "r"))
       this_descr  = manifest_extract_filedesc(ff,this_file)
diff --git a/l3build.dtx b/l3build.dtx
index 4eddc2c..746a4f9 100644
--- a/l3build.dtx
+++ b/l3build.dtx
@@ -1465,7 +1465,7 @@
 %       \var{exclude}            & Files to exclude (default |{excludefiles}|)          \\
 %       \var{dir}                & The directory to search (default |maindir|)          \\
 %       \var{rename}             & An array with a |gsub| redefinition for the filename \\
-%       \var{extractfiledesc}    & Whether to extract file descriptions from these files (default |true|) \\
+%       \var{skipfiledescription} & Whether to extract file descriptions from these files (default |false|) \\
 %     \bottomrule
 %     \end{tabular}
 % \end{table}