[latex3-commits] [l3svn] branch master updated (66ca83c -> 0dfa6c8)

[Bruno Le Floch]

Good job Joseph, switching from prop to tl and adding inheritance.  That
latter point seems interesting!

Minor comments on these commits

- If I read the code correctly the cs { \c_@@_type_root_tl
\l_keys_path_tl } can only be undefined or equal to "choice".  Would it
make sense to have a boolean perhaps?  Maybe not, if the real
distinction is between defined and undefined (it might be annoying to
have to test separately if a key is defined and if that bool is true/false).

- Showing the key doesn't tell us all the information (such as whether
it is a choice key) anymore it seems?

- Inherit looks interesting.  Could you expand the doc?  Are keys
defined previously for bar/ clobbered by "bar .inherit:n = foo" (I guess
yes, or error message perhaps)?  Can further keys be defined (I guess
yes)? What if "foo" is a key rather than a module containing keys?
Basically can I use it to copy a key name as in the following?

\keys_set:nn { mymodule }
  {
    a4paper .bool_set:N = \l_aivpaper_bool ,
    standardeuropeanpaper .inherit:n = a4paper
  }

Should I think of it as "cp", or "ln -s" namely if the original is
altered afterward, is the inheriting also altered?

- In the corresponding test file, only "Defining key module/key-one on
line ..." appears, not the corresponding line "Defining key
module2/path/key-one on line ..." that could be helpful to determine
what keys are defined.  Of course from the implementation point of view
the way it currently is is more natural.

Thanks!

Bruno



On 11/22/2016 05:08 AM, noreply at latex-project.org wrote:
> This is an automated email from the git hooks/post-receive script.
> 
> joseph pushed a change to branch master
> in repository l3svn.
> 
>       from  66ca83c   Missed one doc thing ...
>        new  ef8b34f   Stray blank line
>        new  8d9061e   Finalise moving keys data to set of tls
>        new  7e86613   No longer need \__keys_ensure_exists:N
>        new  bdd0e96   Turns out we weren't logging all key declarations!
>        new  6513b2f   Basic key inheritance
>        new  0dfa6c8   Allow for empty key modules
> 
> The 6 revisions listed above as "new" are entirely new to this
> repository and will be described in separate emails.  The revisions
> listed as "adds" were already present in the repository and have only
> been added to this reference.
> 
> 
> Summary of changes:
>  l3kernel/l3keys.dtx                     |  214 ++++++++++++++++++-------------
>  l3kernel/testfiles/m3expl001.luatex.tlg |   23 +++-
>  l3kernel/testfiles/m3expl001.ptex.tlg   |   23 +++-
>  l3kernel/testfiles/m3expl001.tlg        |   23 +++-
>  l3kernel/testfiles/m3expl001.uptex.tlg  |   23 +++-
>  l3kernel/testfiles/m3expl001.xetex.tlg  |   23 +++-
>  l3kernel/testfiles/m3expl003.luatex.tlg |   23 +++-
>  l3kernel/testfiles/m3expl003.ptex.tlg   |   23 +++-
>  l3kernel/testfiles/m3expl003.tlg        |   23 +++-
>  l3kernel/testfiles/m3expl003.uptex.tlg  |   23 +++-
>  l3kernel/testfiles/m3expl003.xetex.tlg  |   23 +++-
>  l3kernel/testfiles/m3keys001.lvt        |   11 ++
>  l3kernel/testfiles/m3keys001.tlg        |    8 ++
>  l3kernel/testfiles/m3keys002.tlg        |   48 +++++++
>  l3kernel/testfiles/m3keys003.lvt        |   16 +++
>  l3kernel/testfiles/m3keys003.tlg        |   19 +++
>  l3kernel/testfiles/m3keys004.tlg        |    3 +-
>  l3kernel/testfiles/m3keys005.tlg        |    1 +
>  18 files changed, 388 insertions(+), 162 deletions(-)
>